Page MenuHomePhabricator

[depends] bump protobuf to 24.0
AbandonedPublicDraft

Authored by PiRK on Aug 14 2023, 11:26.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

abseil-cpp is no longer included in the protobuf release archive, so it needs to be compiled separately.
Also convert protobuf.mk to use cmake because recent versions of protobuf no longer work with make.

Test Plan

gitian builds

contrib/guix/guix-build

Event Timeline

Tail of the build log:

 * [new tag]             phabricator/diff/41696 -> phabricator/diff/41696
 * [new tag]             phabricator/diff/41697 -> phabricator/diff/41697
 * [new tag]             phabricator/diff/41712 -> phabricator/diff/41712
 * [new tag]             phabricator/diff/41726 -> phabricator/diff/41726
 * [new tag]             phabricator/diff/41730 -> phabricator/diff/41730
 * [new tag]             phabricator/diff/41731 -> phabricator/diff/41731
 * [new tag]             phabricator/diff/41735 -> phabricator/diff/41735
 * [new tag]             phabricator/diff/41736 -> phabricator/diff/41736
 * [new tag]             phabricator/diff/41737 -> phabricator/diff/41737
 * [new tag]             phabricator/diff/41738 -> phabricator/diff/41738
 * [new tag]             phabricator/diff/41740 -> phabricator/diff/41740
 * [new tag]             phabricator/diff/41741 -> phabricator/diff/41741
 * [new tag]             phabricator/diff/41745 -> phabricator/diff/41745
 * [new tag]             phabricator/diff/41746 -> phabricator/diff/41746
 * [new tag]             phabricator/diff/41747 -> phabricator/diff/41747
 * [new tag]             phabricator/diff/41748 -> phabricator/diff/41748
 * [new tag]             phabricator/diff/41749 -> phabricator/diff/41749
 * [new tag]             phabricator/diff/41752 -> phabricator/diff/41752
 * [new tag]             phabricator/diff/41753 -> phabricator/diff/41753
 * [new tag]             phabricator/diff/41754 -> phabricator/diff/41754
 * [new tag]             phabricator/diff/41756 -> phabricator/diff/41756
 * [new tag]             phabricator/diff/41774 -> phabricator/diff/41774
 * [new tag]             phabricator/diff/41780 -> phabricator/diff/41780
 * [new tag]             phabricator/diff/41782 -> phabricator/diff/41782
 * [new tag]             phabricator/diff/41783 -> phabricator/diff/41783
 * [new tag]             phabricator/diff/41784 -> phabricator/diff/41784
 * [new tag]             phabricator/diff/41786 -> phabricator/diff/41786
 * [new tag]             phabricator/diff/41787 -> phabricator/diff/41787
 * [new tag]             phabricator/diff/41788 -> phabricator/diff/41788
 * [new tag]             phabricator/diff/41789 -> phabricator/diff/41789
 * [new tag]             phabricator/diff/41790 -> phabricator/diff/41790
 * [new tag]             phabricator/diff/41798 -> phabricator/diff/41798
 * [new tag]             phabricator/diff/41806 -> phabricator/diff/41806
 * [new tag]             phabricator/diff/41811 -> phabricator/diff/41811
 * [new tag]             phabricator/diff/41816 -> phabricator/diff/41816
 * [new tag]             phabricator/diff/8992  -> phabricator/diff/8992
 * [new tag]             phabricator/diff/8993  -> phabricator/diff/8993
 * [new branch]          master                 -> master
--- Building for bullseye amd64 ---
Stopping target if it is up
Error response from daemon: No such container: gitian-target
Error: No such container: gitian-target
Making a new image copy
Starting target
Checking if target is up.
Preparing build environment
Updating apt-get repository (log in var/install.log)
Installing additional packages (log in var/install.log)
Upgrading system, may take a while (log in var/install.log)
Creating package manifest
Creating build script (var/build-script)
Running build script (log in var/build.log)
./bin/gbuild:23:in `system!': failed to run on-target setarch x86_64 bash -x < var/build-script > var/build.log 2>&1 (RuntimeError)
	from ./bin/gbuild:185:in `build_one_configuration'
	from ./bin/gbuild:339:in `block (2 levels) in <main>'
	from ./bin/gbuild:334:in `each'
	from ./bin/gbuild:334:in `block in <main>'
	from ./bin/gbuild:332:in `each'
	from ./bin/gbuild:332:in `<main>'
Build gitian-linux failed with exit code 1
PiRK edited the test plan for this revision. (Show Details)

try omitting .0 suffix in version and see if it fixes the gitian build for arm64

Tail of the build log:

 * [new tag]             phabricator/diff/41695 -> phabricator/diff/41695
 * [new tag]             phabricator/diff/41696 -> phabricator/diff/41696
 * [new tag]             phabricator/diff/41697 -> phabricator/diff/41697
 * [new tag]             phabricator/diff/41712 -> phabricator/diff/41712
 * [new tag]             phabricator/diff/41726 -> phabricator/diff/41726
 * [new tag]             phabricator/diff/41730 -> phabricator/diff/41730
 * [new tag]             phabricator/diff/41731 -> phabricator/diff/41731
 * [new tag]             phabricator/diff/41735 -> phabricator/diff/41735
 * [new tag]             phabricator/diff/41736 -> phabricator/diff/41736
 * [new tag]             phabricator/diff/41737 -> phabricator/diff/41737
 * [new tag]             phabricator/diff/41738 -> phabricator/diff/41738
 * [new tag]             phabricator/diff/41740 -> phabricator/diff/41740
 * [new tag]             phabricator/diff/41741 -> phabricator/diff/41741
 * [new tag]             phabricator/diff/41745 -> phabricator/diff/41745
 * [new tag]             phabricator/diff/41746 -> phabricator/diff/41746
 * [new tag]             phabricator/diff/41747 -> phabricator/diff/41747
 * [new tag]             phabricator/diff/41748 -> phabricator/diff/41748
 * [new tag]             phabricator/diff/41749 -> phabricator/diff/41749
 * [new tag]             phabricator/diff/41752 -> phabricator/diff/41752
 * [new tag]             phabricator/diff/41753 -> phabricator/diff/41753
 * [new tag]             phabricator/diff/41754 -> phabricator/diff/41754
 * [new tag]             phabricator/diff/41756 -> phabricator/diff/41756
 * [new tag]             phabricator/diff/41774 -> phabricator/diff/41774
 * [new tag]             phabricator/diff/41780 -> phabricator/diff/41780
 * [new tag]             phabricator/diff/41782 -> phabricator/diff/41782
 * [new tag]             phabricator/diff/41783 -> phabricator/diff/41783
 * [new tag]             phabricator/diff/41784 -> phabricator/diff/41784
 * [new tag]             phabricator/diff/41786 -> phabricator/diff/41786
 * [new tag]             phabricator/diff/41787 -> phabricator/diff/41787
 * [new tag]             phabricator/diff/41788 -> phabricator/diff/41788
 * [new tag]             phabricator/diff/41789 -> phabricator/diff/41789
 * [new tag]             phabricator/diff/41790 -> phabricator/diff/41790
 * [new tag]             phabricator/diff/41798 -> phabricator/diff/41798
 * [new tag]             phabricator/diff/41806 -> phabricator/diff/41806
 * [new tag]             phabricator/diff/41811 -> phabricator/diff/41811
 * [new tag]             phabricator/diff/41816 -> phabricator/diff/41816
 * [new tag]             phabricator/diff/41817 -> phabricator/diff/41817
 * [new tag]             phabricator/diff/8992  -> phabricator/diff/8992
 * [new tag]             phabricator/diff/8993  -> phabricator/diff/8993
 * [new branch]          master                 -> master
--- Building for bullseye amd64 ---
Stopping target if it is up
Making a new image copy
Starting target
Checking if target is up.
Preparing build environment
Updating apt-get repository (log in var/install.log)
Installing additional packages (log in var/install.log)
Upgrading system, may take a while (log in var/install.log)
Creating package manifest
Creating build script (var/build-script)
Running build script (log in var/build.log)
./bin/gbuild:23:in `system!': failed to run on-target setarch x86_64 bash -x < var/build-script > var/build.log 2>&1 (RuntimeError)
	from ./bin/gbuild:185:in `build_one_configuration'
	from ./bin/gbuild:339:in `block (2 levels) in <main>'
	from ./bin/gbuild:334:in `each'
	from ./bin/gbuild:334:in `block in <main>'
	from ./bin/gbuild:332:in `each'
	from ./bin/gbuild:332:in `<main>'
Build gitian-linux failed with exit code 1

build abseil-cpp with PIC, comment out postprocessing_cmds, add debugging info for finding protobuf (FIXME: it still finds the native protobuf install instead of the one compiled by the toolchain)

@bot gitian-linux gitian-win gitian-osx

Tail of the build log:

 * [new tag]             phabricator/diff/41726 -> phabricator/diff/41726
 * [new tag]             phabricator/diff/41730 -> phabricator/diff/41730
 * [new tag]             phabricator/diff/41731 -> phabricator/diff/41731
 * [new tag]             phabricator/diff/41735 -> phabricator/diff/41735
 * [new tag]             phabricator/diff/41736 -> phabricator/diff/41736
 * [new tag]             phabricator/diff/41737 -> phabricator/diff/41737
 * [new tag]             phabricator/diff/41738 -> phabricator/diff/41738
 * [new tag]             phabricator/diff/41740 -> phabricator/diff/41740
 * [new tag]             phabricator/diff/41741 -> phabricator/diff/41741
 * [new tag]             phabricator/diff/41745 -> phabricator/diff/41745
 * [new tag]             phabricator/diff/41746 -> phabricator/diff/41746
 * [new tag]             phabricator/diff/41747 -> phabricator/diff/41747
 * [new tag]             phabricator/diff/41748 -> phabricator/diff/41748
 * [new tag]             phabricator/diff/41749 -> phabricator/diff/41749
 * [new tag]             phabricator/diff/41752 -> phabricator/diff/41752
 * [new tag]             phabricator/diff/41753 -> phabricator/diff/41753
 * [new tag]             phabricator/diff/41754 -> phabricator/diff/41754
 * [new tag]             phabricator/diff/41756 -> phabricator/diff/41756
 * [new tag]             phabricator/diff/41774 -> phabricator/diff/41774
 * [new tag]             phabricator/diff/41780 -> phabricator/diff/41780
 * [new tag]             phabricator/diff/41782 -> phabricator/diff/41782
 * [new tag]             phabricator/diff/41783 -> phabricator/diff/41783
 * [new tag]             phabricator/diff/41784 -> phabricator/diff/41784
 * [new tag]             phabricator/diff/41786 -> phabricator/diff/41786
 * [new tag]             phabricator/diff/41787 -> phabricator/diff/41787
 * [new tag]             phabricator/diff/41788 -> phabricator/diff/41788
 * [new tag]             phabricator/diff/41789 -> phabricator/diff/41789
 * [new tag]             phabricator/diff/41790 -> phabricator/diff/41790
 * [new tag]             phabricator/diff/41798 -> phabricator/diff/41798
 * [new tag]             phabricator/diff/41806 -> phabricator/diff/41806
 * [new tag]             phabricator/diff/41811 -> phabricator/diff/41811
 * [new tag]             phabricator/diff/41816 -> phabricator/diff/41816
 * [new tag]             phabricator/diff/41817 -> phabricator/diff/41817
 * [new tag]             phabricator/diff/41820 -> phabricator/diff/41820
 * [new tag]             phabricator/diff/41829 -> phabricator/diff/41829
 * [new tag]             phabricator/diff/8992  -> phabricator/diff/8992
 * [new tag]             phabricator/diff/8993  -> phabricator/diff/8993
 * [new branch]          master                 -> master
--- Building for bullseye amd64 ---
Stopping target if it is up
Error response from daemon: No such container: gitian-target
Error: No such container: gitian-target
Making a new image copy
Starting target
Checking if target is up.
Preparing build environment
Updating apt-get repository (log in var/install.log)
Installing additional packages (log in var/install.log)
Upgrading system, may take a while (log in var/install.log)
Creating package manifest
Creating build script (var/build-script)
Running build script (log in var/build.log)
./bin/gbuild:23:in `system!': failed to run on-target setarch x86_64 bash -x < var/build-script > var/build.log 2>&1 (RuntimeError)
	from ./bin/gbuild:185:in `build_one_configuration'
	from ./bin/gbuild:339:in `block (2 levels) in <main>'
	from ./bin/gbuild:334:in `each'
	from ./bin/gbuild:334:in `block in <main>'
	from ./bin/gbuild:332:in `each'
	from ./bin/gbuild:332:in `<main>'
Build gitian-win failed with exit code 1

Tail of the build log:

 * [new tag]             phabricator/diff/40990 -> phabricator/diff/40990
 * [new tag]             phabricator/diff/40995 -> phabricator/diff/40995
 * [new tag]             phabricator/diff/41024 -> phabricator/diff/41024
 * [new tag]             phabricator/diff/41027 -> phabricator/diff/41027
 * [new tag]             phabricator/diff/41028 -> phabricator/diff/41028
 * [new tag]             phabricator/diff/41029 -> phabricator/diff/41029
 * [new tag]             phabricator/diff/41033 -> phabricator/diff/41033
 * [new tag]             phabricator/diff/41043 -> phabricator/diff/41043
 * [new tag]             phabricator/diff/41044 -> phabricator/diff/41044
 * [new tag]             phabricator/diff/41086 -> phabricator/diff/41086
 * [new tag]             phabricator/diff/41087 -> phabricator/diff/41087
 * [new tag]             phabricator/diff/41103 -> phabricator/diff/41103
 * [new tag]             phabricator/diff/41133 -> phabricator/diff/41133
 * [new tag]             phabricator/diff/41180 -> phabricator/diff/41180
 * [new tag]             phabricator/diff/41181 -> phabricator/diff/41181
 * [new tag]             phabricator/diff/41204 -> phabricator/diff/41204
 * [new tag]             phabricator/diff/41218 -> phabricator/diff/41218
 * [new tag]             phabricator/diff/41232 -> phabricator/diff/41232
 * [new tag]             phabricator/diff/41239 -> phabricator/diff/41239
 * [new tag]             phabricator/diff/41244 -> phabricator/diff/41244
 * [new tag]             phabricator/diff/41255 -> phabricator/diff/41255
 * [new tag]             phabricator/diff/41385 -> phabricator/diff/41385
 * [new tag]             phabricator/diff/41462 -> phabricator/diff/41462
 * [new tag]             phabricator/diff/41509 -> phabricator/diff/41509
 * [new tag]             phabricator/diff/41563 -> phabricator/diff/41563
 * [new tag]             phabricator/diff/41595 -> phabricator/diff/41595
 * [new tag]             phabricator/diff/41596 -> phabricator/diff/41596
 * [new tag]             phabricator/diff/41599 -> phabricator/diff/41599
 * [new tag]             phabricator/diff/41603 -> phabricator/diff/41603
 * [new tag]             phabricator/diff/41604 -> phabricator/diff/41604
 * [new tag]             phabricator/diff/41655 -> phabricator/diff/41655
 * [new tag]             phabricator/diff/41710 -> phabricator/diff/41710
 * [new tag]             phabricator/diff/41752 -> phabricator/diff/41752
 * [new tag]             phabricator/diff/41783 -> phabricator/diff/41783
 * [new tag]             phabricator/diff/41829 -> phabricator/diff/41829
 * [new tag]             phabricator/diff/8992  -> phabricator/diff/8992
 * [new tag]             phabricator/diff/8993  -> phabricator/diff/8993
 * [new branch]          master                 -> master
--- Building for bullseye amd64 ---
Stopping target if it is up
Error response from daemon: No such container: gitian-target
Error: No such container: gitian-target
Making a new image copy
Starting target
Checking if target is up.
Preparing build environment
Updating apt-get repository (log in var/install.log)
Installing additional packages (log in var/install.log)
Upgrading system, may take a while (log in var/install.log)
Creating package manifest
Creating build script (var/build-script)
Running build script (log in var/build.log)
./bin/gbuild:23:in `system!': failed to run on-target setarch x86_64 bash -x < var/build-script > var/build.log 2>&1 (RuntimeError)
	from ./bin/gbuild:185:in `build_one_configuration'
	from ./bin/gbuild:339:in `block (2 levels) in <main>'
	from ./bin/gbuild:334:in `each'
	from ./bin/gbuild:334:in `block in <main>'
	from ./bin/gbuild:332:in `each'
	from ./bin/gbuild:332:in `<main>'
Build gitian-osx failed with exit code 1

Tail of the build log:

 * [new tag]             phabricator/diff/41266 -> phabricator/diff/41266
 * [new tag]             phabricator/diff/41272 -> phabricator/diff/41272
 * [new tag]             phabricator/diff/41382 -> phabricator/diff/41382
 * [new tag]             phabricator/diff/41383 -> phabricator/diff/41383
 * [new tag]             phabricator/diff/41390 -> phabricator/diff/41390
 * [new tag]             phabricator/diff/41392 -> phabricator/diff/41392
 * [new tag]             phabricator/diff/41418 -> phabricator/diff/41418
 * [new tag]             phabricator/diff/41419 -> phabricator/diff/41419
 * [new tag]             phabricator/diff/41432 -> phabricator/diff/41432
 * [new tag]             phabricator/diff/41466 -> phabricator/diff/41466
 * [new tag]             phabricator/diff/41522 -> phabricator/diff/41522
 * [new tag]             phabricator/diff/41538 -> phabricator/diff/41538
 * [new tag]             phabricator/diff/41539 -> phabricator/diff/41539
 * [new tag]             phabricator/diff/41585 -> phabricator/diff/41585
 * [new tag]             phabricator/diff/41588 -> phabricator/diff/41588
 * [new tag]             phabricator/diff/41594 -> phabricator/diff/41594
 * [new tag]             phabricator/diff/41595 -> phabricator/diff/41595
 * [new tag]             phabricator/diff/41599 -> phabricator/diff/41599
 * [new tag]             phabricator/diff/41633 -> phabricator/diff/41633
 * [new tag]             phabricator/diff/41635 -> phabricator/diff/41635
 * [new tag]             phabricator/diff/41643 -> phabricator/diff/41643
 * [new tag]             phabricator/diff/41651 -> phabricator/diff/41651
 * [new tag]             phabricator/diff/41657 -> phabricator/diff/41657
 * [new tag]             phabricator/diff/41658 -> phabricator/diff/41658
 * [new tag]             phabricator/diff/41660 -> phabricator/diff/41660
 * [new tag]             phabricator/diff/41752 -> phabricator/diff/41752
 * [new tag]             phabricator/diff/41782 -> phabricator/diff/41782
 * [new tag]             phabricator/diff/41784 -> phabricator/diff/41784
 * [new tag]             phabricator/diff/41786 -> phabricator/diff/41786
 * [new tag]             phabricator/diff/41787 -> phabricator/diff/41787
 * [new tag]             phabricator/diff/41788 -> phabricator/diff/41788
 * [new tag]             phabricator/diff/41789 -> phabricator/diff/41789
 * [new tag]             phabricator/diff/41792 -> phabricator/diff/41792
 * [new tag]             phabricator/diff/41822 -> phabricator/diff/41822
 * [new tag]             phabricator/diff/41829 -> phabricator/diff/41829
 * [new tag]             phabricator/diff/8992  -> phabricator/diff/8992
 * [new tag]             phabricator/diff/8993  -> phabricator/diff/8993
 * [new branch]          master                 -> master
--- Building for bullseye amd64 ---
Stopping target if it is up
Error response from daemon: No such container: gitian-target
Error: No such container: gitian-target
Making a new image copy
Starting target
Checking if target is up.
Preparing build environment
Updating apt-get repository (log in var/install.log)
Installing additional packages (log in var/install.log)
Upgrading system, may take a while (log in var/install.log)
Creating package manifest
Creating build script (var/build-script)
Running build script (log in var/build.log)
./bin/gbuild:23:in `system!': failed to run on-target setarch x86_64 bash -x < var/build-script > var/build.log 2>&1 (RuntimeError)
	from ./bin/gbuild:185:in `build_one_configuration'
	from ./bin/gbuild:339:in `block (2 levels) in <main>'
	from ./bin/gbuild:334:in `each'
	from ./bin/gbuild:334:in `block in <main>'
	from ./bin/gbuild:332:in `each'
	from ./bin/gbuild:332:in `<main>'
Build gitian-linux failed with exit code 1