Page MenuHomePhabricator

test: use MiniWallet for feature_csv_activation.py
AbandonedPublicDraft

Authored by PiRK on Aug 22 2023, 13:33.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

This test can now be run even with the Bitcoin ABC wallet disabled.

This is a backport of core#21900
https://github.com/bitcoin/bitcoin/pull/21900/commits/2eca46b0aa0ecf4738500b53523d7013985b387d

Test Plan

ninja check-functional

Diff Detail

Event Timeline

Failed tests logs:

====== Bitcoin ABC functional tests: feature_csv_activation.py ======

------- Stdout: -------
2023-08-22T13:39:26.615000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20230822_133828/feature_csv_activation_17
2023-08-22T13:39:26.974000Z TestFramework (INFO): Generate blocks in the past for coinbase outputs.
2023-08-22T13:39:27.624000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 142, in main
    self.run_test()
  File "/work/test/functional/feature_csv_activation.py", line 258, in run_test
    send_generic_input_tx(self.nodes[0], self.coinbase_blocks)
  File "/work/test/functional/feature_csv_activation.py", line 123, in send_generic_input_tx
    return miniwallet.send_self_transfer(from_node=node, utxo_to_spend=utxo_to_spend)[
  File "/work/test/functional/test_framework/wallet.py", line 145, in send_self_transfer
    self.sendrawtransaction(from_node=kwargs["from_node"], tx_hex=tx["hex"])
  File "/work/test/functional/test_framework/wallet.py", line 198, in sendrawtransaction
    txid = from_node.sendrawtransaction(tx_hex)
  File "/work/test/functional/test_framework/coverage.py", line 47, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 179, in __call__
    raise JSONRPCException(response["error"], status)
test_framework.authproxy.JSONRPCException: non-mandatory-script-verify-flag (Stack size must be exactly one after execution) (-26)
2023-08-22T13:39:27.675000Z TestFramework (INFO): Stopping nodes
2023-08-22T13:39:27.827000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20230822_133828/feature_csv_activation_17
2023-08-22T13:39:27.827000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20230822_133828/feature_csv_activation_17/test_framework.log
2023-08-22T13:39:27.827000Z TestFramework (ERROR): 
2023-08-22T13:39:27.827000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20230822_133828/feature_csv_activation_17' to consolidate all logs
2023-08-22T13:39:27.827000Z TestFramework (ERROR): 
2023-08-22T13:39:27.827000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2023-08-22T13:39:27.827000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2023-08-22T13:39:27.827000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: feature_csv_activation.py

Failed tests logs:

====== Bitcoin ABC functional tests: feature_csv_activation.py ======

------- Stdout: -------
2023-08-22T13:39:13.339000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20230822_133714/feature_csv_activation_17
2023-08-22T13:39:13.977000Z TestFramework (INFO): Generate blocks in the past for coinbase outputs.
2023-08-22T13:39:16.989000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 142, in main
    self.run_test()
  File "/work/test/functional/feature_csv_activation.py", line 258, in run_test
    send_generic_input_tx(self.nodes[0], self.coinbase_blocks)
  File "/work/test/functional/feature_csv_activation.py", line 123, in send_generic_input_tx
    return miniwallet.send_self_transfer(from_node=node, utxo_to_spend=utxo_to_spend)[
  File "/work/test/functional/test_framework/wallet.py", line 145, in send_self_transfer
    self.sendrawtransaction(from_node=kwargs["from_node"], tx_hex=tx["hex"])
  File "/work/test/functional/test_framework/wallet.py", line 198, in sendrawtransaction
    txid = from_node.sendrawtransaction(tx_hex)
  File "/work/test/functional/test_framework/coverage.py", line 47, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 179, in __call__
    raise JSONRPCException(response["error"], status)
test_framework.authproxy.JSONRPCException: non-mandatory-script-verify-flag (Stack size must be exactly one after execution) (-26)
2023-08-22T13:39:17.040000Z TestFramework (INFO): Stopping nodes
2023-08-22T13:39:17.141000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20230822_133714/feature_csv_activation_17
2023-08-22T13:39:17.141000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20230822_133714/feature_csv_activation_17/test_framework.log
2023-08-22T13:39:17.141000Z TestFramework (ERROR): 
2023-08-22T13:39:17.141000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20230822_133714/feature_csv_activation_17' to consolidate all logs
2023-08-22T13:39:17.141000Z TestFramework (ERROR): 
2023-08-22T13:39:17.142000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2023-08-22T13:39:17.142000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2023-08-22T13:39:17.142000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: feature_csv_activation.py

Failed tests logs:

====== Bitcoin ABC functional tests: feature_csv_activation.py ======

------- Stdout: -------
2023-08-22T13:43:06.849000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20230822_134141/feature_csv_activation_17
2023-08-22T13:43:07.227000Z TestFramework (INFO): Generate blocks in the past for coinbase outputs.
2023-08-22T13:43:07.888000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 142, in main
    self.run_test()
  File "/work/test/functional/feature_csv_activation.py", line 258, in run_test
    send_generic_input_tx(self.nodes[0], self.coinbase_blocks)
  File "/work/test/functional/feature_csv_activation.py", line 123, in send_generic_input_tx
    return miniwallet.send_self_transfer(from_node=node, utxo_to_spend=utxo_to_spend)[
  File "/work/test/functional/test_framework/wallet.py", line 145, in send_self_transfer
    self.sendrawtransaction(from_node=kwargs["from_node"], tx_hex=tx["hex"])
  File "/work/test/functional/test_framework/wallet.py", line 198, in sendrawtransaction
    txid = from_node.sendrawtransaction(tx_hex)
  File "/work/test/functional/test_framework/coverage.py", line 47, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 179, in __call__
    raise JSONRPCException(response["error"], status)
test_framework.authproxy.JSONRPCException: non-mandatory-script-verify-flag (Stack size must be exactly one after execution) (-26)
2023-08-22T13:43:07.939000Z TestFramework (INFO): Stopping nodes
2023-08-22T13:43:08.090000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20230822_134141/feature_csv_activation_17
2023-08-22T13:43:08.090000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20230822_134141/feature_csv_activation_17/test_framework.log
2023-08-22T13:43:08.090000Z TestFramework (ERROR): 
2023-08-22T13:43:08.091000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20230822_134141/feature_csv_activation_17' to consolidate all logs
2023-08-22T13:43:08.091000Z TestFramework (ERROR): 
2023-08-22T13:43:08.091000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2023-08-22T13:43:08.091000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2023-08-22T13:43:08.091000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests with the next upgrade activated: feature_csv_activation.py ======

------- Stdout: -------
2023-08-22T13:47:43.303000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20230822_134627/feature_csv_activation_17
2023-08-22T13:47:43.742000Z TestFramework (INFO): Generate blocks in the past for coinbase outputs.
2023-08-22T13:47:44.394000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 142, in main
    self.run_test()
  File "/work/test/functional/feature_csv_activation.py", line 258, in run_test
    send_generic_input_tx(self.nodes[0], self.coinbase_blocks)
  File "/work/test/functional/feature_csv_activation.py", line 123, in send_generic_input_tx
    return miniwallet.send_self_transfer(from_node=node, utxo_to_spend=utxo_to_spend)[
  File "/work/test/functional/test_framework/wallet.py", line 145, in send_self_transfer
    self.sendrawtransaction(from_node=kwargs["from_node"], tx_hex=tx["hex"])
  File "/work/test/functional/test_framework/wallet.py", line 198, in sendrawtransaction
    txid = from_node.sendrawtransaction(tx_hex)
  File "/work/test/functional/test_framework/coverage.py", line 47, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 179, in __call__
    raise JSONRPCException(response["error"], status)
test_framework.authproxy.JSONRPCException: non-mandatory-script-verify-flag (Stack size must be exactly one after execution) (-26)
2023-08-22T13:47:44.445000Z TestFramework (INFO): Stopping nodes
2023-08-22T13:47:44.596000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20230822_134627/feature_csv_activation_17
2023-08-22T13:47:44.596000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20230822_134627/feature_csv_activation_17/test_framework.log
2023-08-22T13:47:44.596000Z TestFramework (ERROR): 
2023-08-22T13:47:44.596000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20230822_134627/feature_csv_activation_17' to consolidate all logs
2023-08-22T13:47:44.596000Z TestFramework (ERROR): 
2023-08-22T13:47:44.596000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2023-08-22T13:47:44.596000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2023-08-22T13:47:44.596000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: feature_csv_activation.py
Bitcoin ABC functional tests with the next upgrade activated: feature_csv_activation.py