Differential D14428

[e.cash] Fix twitter image tag
ClosedPublic
Actions

Authored by johnkuney on Aug 29 2023, 17:27.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC9ad56c68e893: [e.cash] Fix twitter image tag

Summary

Adding the twitter:image meta tag to the head to resolve the image not showing up when shared

Test Plan

After the change is live try sharing the e.cash url on twitter and see if the image shows. (their card validator no longer works afaik)

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

johnkuney created this revision.Aug 29 2023, 17:27

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 29 2023, 17:27

johnkuney requested review of this revision.Aug 29 2023, 17:27

Harbormaster completed remote builds in B24890: Diff 41990.Aug 29 2023, 17:27

bytesofman accepted this revision.Aug 29 2023, 17:28

This revision is now accepted and ready to land.Aug 29 2023, 17:28

Closed by commit rABC9ad56c68e893: [e.cash] Fix twitter image tag (authored by johnkuney). · Explain WhyAug 29 2023, 17:32

This revision was automatically updated to reflect the committed changes.

johnkuney added a commit: rABC9ad56c68e893: [e.cash] Fix twitter image tag.

Revision Contents
Changeset List

Path

Size

web/

e.cash/

components/

layout/

index.js

4 lines

Diff 41991

View Options

web/e.cash/components/layout/index.js

[e.cash] Fix twitter image tagClosedPublicActions