Page MenuHomePhabricator
Differential D14564

[electrum] make the coinchooser respect the tx relay size policy
DraftPublic
Actions

Authored by PiRK on Oct 2 2023, 06:32.
This is a draft revision that has not yet been submitted for review.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

This fixes a long standing issue about Electrum ABC producing transactions that are too large and fail to be broadcast for single address wallets with many coins.
Just don't overfill the buckets.

TODO: now we also need to handle the cases where a single bucket is not enough to cover the output amount. This still can still produce transactions that are too large.

Test Plan

python test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
coinchooser_tx_size
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25216
Build 50020: Build Diffelectrum-tests
Build 50019: arc lint + arc unit

Revision Contents
Changeset List

PathSize
electrum/
electrumabc/
60 lines
17 lines
tests/
53 lines
9 lines
electrumabc_gui/
qt/
8 lines

Diff 42467

View Options

electrum/electrumabc/coinchooser.py

Loading...
View Options

electrum/electrumabc/consolidate.py

Loading...
View Options

electrum/electrumabc/tests/test_coinchooser.py

Loading...
View Options

electrum/electrumabc/transaction.py

Loading...
View Options

electrum/electrumabc_gui/qt/consolidate_coins_dialog.py

Loading...