Differential D14857

[e.cash] Update instant exchanges scoring criteria
ClosedPublic
Actions

Authored by johnkuney on Nov 27 2023, 21:13.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABCc8e66dd9ac97: [e.cash] Update instant exchanges scoring criteria

Summary

We added a new field on scorecard.cash for 'issues', and adjusted the scoring values. Updating here to reflect the same

Test Plan

Preview the site and check the instant exchanges on /get-ecash line up with those on scorecard.cash

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

johnkuney created this revision.Nov 27 2023, 21:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 27 2023, 21:13

johnkuney requested review of this revision.Nov 27 2023, 21:13

Harbormaster completed remote builds in B25748: Diff 43277.Nov 27 2023, 21:13

@bot preview-e.cash

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.178.130.230:41501 for the next 60 minutes.

lines up according to test plan.

separate from this diff -- I see we have swapzone widget on our exchange page, even though Sideshift is the top scoring instant exchange. Why not replace swapzone with sideshift, or at least add in sideshift?

This revision is now accepted and ready to land.Nov 27 2023, 22:56

Closed by commit rABCc8e66dd9ac97: [e.cash] Update instant exchanges scoring criteria (authored by johnkuney). · Explain WhyNov 28 2023, 17:52

This revision was automatically updated to reflect the committed changes.

johnkuney added a commit: rABCc8e66dd9ac97: [e.cash] Update instant exchanges scoring criteria.

For sure Im not opposed to adding the sideshift widget

Revision Contents
Changeset List

Path

Size

web/

e.cash/

data/

scores.js

10 lines

Diff 43296

View Options

[e.cash] Update instant exchanges scoring criteriaClosedPublicActions