Drop the extension-specific version of App.js. Consolidate functionality into one App.js, with state-functions specific to the WebApp and the Extension contained in their own separate components, conditionally included in App.js at build time depending on the extension build env var.
Details
Details
- Reviewers
- None
- Group Reviewers
Restricted Project
npm run extension
Test getAddress at components.cashtab.com
Test paybutton
npm run build
Deploy to netlify at new url, test notification request
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- extension-one-app-js
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 25968 Build 51510: Build Diff cashtab-tests Build 51509: arc lint + arc unit
Event Timeline
Comment Actions
Steps
- WebApp functionality to its own WebApp component D14989
- Extension functionality to its own Extension component D14990
- Extension vs WebApp rendering differences (popout)
- no service worker in extension
- extension css global style
- No swap in extension
- deprecate extension/src/components/App.js and update extension.sh build script
Next
- port connection in extension should be managed in state and handle disconnects