Page MenuHomePhabricator

[Cashtab] Pass genesis token output with value as int and not string
AbandonedPublicDraft

Authored by bytesofman on Feb 23 2024, 14:13.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

chronik nng returns a string for the value key of utxos. ecash-coinselect then converts these to int, which TransactionBuilder requires for signing.

When we get to in-node chronik-client, the value key will always be an integer. In general, we should not be explicitly setting something to be a string in this function if we know it needs to be an integer later.

The send method in this page is updated separately in D15519

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pass-int-output
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 27357
Build 54277: Build Diffcashtab-tests
Build 54276: arc lint + arc unit