Page MenuHomePhabricator

[Cashtab] Use react location and not window.location to trigger updates on new version
AbandonedPublicDraft

Authored by bytesofman on Mar 1 2024, 13:30.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

I am not sure if this will work better or not. Currently, updates do not work well -- as in, user clicks "close" on notification, page reloadds as intended, but the version may not be updated unless this is done 2 or 3 times.

This issue did not exist when we used the modal -- ref diff D15521. However, I can't determine any core logic changed in that diff.

Potential fix here. If it doesn't work, will revert. But what we currently have doesn't work well either.

Test Plan

npm test to confirm this does not break the app. Will need to be observed over updates in prod to determine if this improves performance.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
better-updates
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 27569
Build 54701: Build Diffcashtab-tests
Build 54700: arc lint + arc unit