Page MenuHomePhabricator

[e.cash] Adjust image height on core-tech
ClosedPublic

Authored by johnkuney on May 14 2024, 16:17.

Details

Reviewers
Kronkmeister
Group Reviewers
Restricted Project
Commits
rABC5aaf45afad05: [e.cash] Adjust image height on core-tech
Summary

The eToken image on /core-tech was too large and all of the images have the same height.
Adding an optional height prop so we can adjust as needed

Test Plan

preview the site and check /core-tech. See all the images look good

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Kronkmeister requested changes to this revision.EditedMay 14 2024, 19:24

When manually adjusting the window size, reducing it from fullscreen, the spinningcoin animation gets excessively large. While other images also resize, they don't grow as much. Any way to fix that?

Images below for comparison:

This is how large the hand gets:

image.png (1×1 px, 389 KB)

this is the max size other animations get:

image.png (780×1 px, 164 KB)

Probably because all the other animations are wide or square, while the spinninigcoin one has a relatively small width.

This revision now requires changes to proceed.May 14 2024, 19:24

unify imgage heights on mobile

good to go. images behave a bit differently based on source file. but we plan on swapping out images, so might just fix this at a later date. for now the sizes are not too far off.

This revision is now accepted and ready to land.May 24 2024, 20:40
This revision was automatically updated to reflect the committed changes.