Paths

Table of Contentst

Diffusion Bitcoin ABC ecada1e39579

move-only: Extract common/args and common/config.cpp from util/system
ecada1e39579
Actions

Tags

None

Subscribers

None

Description

move-only: Extract common/args and common/config.cpp from util/system

Summary:
This is an extraction of ArgsManager related functions from util/system
into their own common file.

Config file related functions are moved to common/configfile.cpp.

The background of this commit is an ongoing effort to decouple the
libbitcoinkernel library from the ArgsManager. The ArgsManager belongs
into the common library, since the kernel library should not depend on
it. See doc/design/libraries.md for more information on this rationale.

This is a backport of core#27419
Depends on D16203

Note that due to missing backports, I had to make CheckValid and InterpretOption non-static and add them to args.h so that they are available both for args.cpp and configfile.cpp. These two static functions will go away when we backport core#22766

Test Plan: ninja all check-all bench-bitcoin bitcoin-fuzzers

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D16202

Details

Provenance

PiRK	Authored on May 22 2024, 10:25
PiRK	Pushed on May 23 2024, 07:58

Reviewer

Restricted Project

Differential Revision

D16202: move-only: Extract common/args and common/config.cpp from util/system

Parents

rABC4c05a04a597e: add missing includes and remove unneeded ones

Branches

Unknown

Tags

Unknown

Event Timeline

PiRK committed rABCecada1e39579: move-only: Extract common/args and common/config.cpp from util/system (authored by PiRK).May 23 2024, 07:58

PiRK added an edge: D16202: move-only: Extract common/args and common/config.cpp from util/system.

Changes (104)
Show All Changes

Very Large Commit

This commit is very large. Load each file individually.

Path

Size

arcanist/

linter/

LocaleDependenceLinter.php

chronik/

chronik-cpp/

src/

avalanche/

peermanager.cpp

bench/

bench_bitcoin.cpp

bitcoin-chainstate.cpp

bitcoin-cli.cpp

bitcoin-wallet.cpp

chainparams.cpp

chainparamsbase.cpp

	common/
	util/

	args.cpp
	system.cpp

	args.h
	system.h

common/

consensus/

currencyunit.cpp

dummywallet.cpp

index/

blockfilterindex.cpp

coinstatsindex.cpp

init/

mempool_args.cpp

net_processing.cpp

node/

blockmanager_args.cpp

chainstatemanager_args.cpp

coins_view_args.cpp

database_args.cpp

mempool_persist_args.cpp

utxo_snapshot.cpp

validation_cache_args.cpp

policy/

block/

preconsensus.cpp

stakingrewards.cpp

qt/

bitcoinunits.cpp

clientmodel.cpp

optionsmodel.cpp

paymentrequestplus.cpp

paymentserver.cpp

test/

bitcoinaddressvalidatortests.cpp

transactiondesc.cpp

utilitydialog.cpp

walletmodel.cpp

rpc/

server_util.cpp

script/

seeder/

test/

options_tests.cpp

test/

checkqueue_tests.cpp

denialofservice_tests.cpp

flatfile_tests.cpp

fuzz/

transaction.cpp

util/

setup_common.cpp

util/

wallet/

coincontrol.cpp

rpc/

scriptpubkeyman.cpp

zmq/

zmqnotificationinterface.cpp

test/

lint/

lint-circular-dependencies.sh

rABCecada1e39579

arcanist/linter/LocaleDependenceLinter.php

chronik/chronik-cpp/chronik.cpp

src/CMakeLists.txt

src/addrdb.cpp

src/avalanche/avalanche.cpp

src/avalanche/peermanager.cpp

src/avalanche/processor.cpp

src/avalanche/proof.cpp

src/bench/bench_bitcoin.cpp

src/bitcoin-chainstate.cpp

src/bitcoin-cli.cpp

src/bitcoin-tx.cpp

src/bitcoin-wallet.cpp

src/bitcoind.cpp

src/chainparams.cpp

src/chainparamsbase.cpp

src/common/args.cpp

src/common/args.h

src/common/configfile.cpp

src/consensus/activation.cpp

src/consensus/amount.cpp

src/currencyunit.cpp

src/dnsseeds.cpp

src/dummywallet.cpp

src/httprpc.cpp

src/httpserver.cpp

src/i2p.cpp

src/index/base.cpp

src/index/blockfilterindex.cpp

src/index/coinstatsindex.cpp

src/index/txindex.cpp

src/init.cpp

src/init/common.cpp

src/mempool_args.cpp

src/minerfund.cpp

src/net.cpp

src/net_processing.cpp

src/node/blockmanager_args.cpp

src/node/caches.cpp

src/node/chainstatemanager_args.cpp

src/node/coins_view_args.cpp

src/node/database_args.cpp

src/node/interfaces.cpp

src/node/mempool_persist_args.cpp

src/node/miner.cpp

src/node/utxo_snapshot.cpp

src/node/validation_cache_args.cpp

src/policy/block/preconsensus.cpp

src/policy/block/stakingrewards.cpp

src/protocol.cpp

src/qt/bitcoin.cpp

src/qt/bitcoinunits.cpp

src/qt/clientmodel.cpp

src/qt/guiutil.cpp

src/qt/intro.cpp

src/qt/optionsmodel.cpp

src/qt/paymentrequestplus.cpp

src/qt/paymentserver.cpp

src/qt/test/bitcoinaddressvalidatortests.cpp

src/qt/test/uritests.cpp

src/qt/transactiondesc.cpp

src/qt/utilitydialog.cpp

src/qt/walletmodel.cpp

src/rpc/avalanche.cpp

src/rpc/blockchain.cpp

src/rpc/client.cpp

src/rpc/request.cpp

src/rpc/server.cpp

src/rpc/server.h

src/rpc/server_util.cpp

src/rpc/util.cpp

src/script/descriptor.cpp

src/seeder/bitcoin.cpp

src/seeder/main.cpp

src/seeder/options.cpp

src/seeder/test/options_tests.cpp

src/test/checkqueue_tests.cpp

src/test/denialofservice_tests.cpp

src/test/flatfile_tests.cpp

src/test/fuzz/banman.cpp

src/test/fuzz/integer.cpp

src/test/fuzz/string.cpp

src/test/fuzz/system.cpp

src/test/fuzz/transaction.cpp

src/test/util/setup_common.cpp

src/test/util/setup_common.h

src/timedata.cpp

src/torcontrol.cpp

src/util/system.cpp

src/util/system.h

src/validation.cpp

src/wallet/bdb.cpp

src/wallet/coincontrol.cpp

src/wallet/init.cpp

src/wallet/interfaces.cpp

src/wallet/load.cpp

src/wallet/rpc/backup.cpp

src/wallet/scriptpubkeyman.cpp

src/wallet/spend.cpp

src/wallet/wallet.cpp

src/wallet/walletdb.cpp

src/wallet/walletutil.cpp

src/zmq/zmqnotificationinterface.cpp

test/lint/lint-circular-dependencies.sh