Paths

Table of Contentst

Differential D16203

add missing includes and remove unneeded ones
ClosedPublic
Actions

Authored by PiRK on May 22 2024, 15:03.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC4c05a04a597e: add missing includes and remove unneeded ones

Summary

Most of the headers added in this diff are currently included indirectly via system.h. This will change after D16202, so include them directly to prevent future compilation errors.

proofbuilder.cpp no longer needs to include system.h for gArgs after D11914

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.May 22 2024, 15:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 22 2024, 15:03

PiRK requested review of this revision.May 22 2024, 15:03

PiRK added inline comments.May 22 2024, 15:06

src/banman.cpp
10 ↗	(On Diff #47890)	This one was flagged as unused by my IDE after I added logging.h
src/chainparams.cpp
30 ↗	(On Diff #47890)	`arc lint` wants this
src/wallet/bdb.cpp
6 ↗	(On Diff #47890)	this line is moved to another group of includes, below

PiRK added a child revision: D16202: move-only: Extract common/args and common/config.cpp from util/system.May 22 2024, 15:11

Harbormaster completed remote builds in B29075: Diff 47890.May 22 2024, 15:30

We should try to get a iwyu linter at some point. It can be integrated into cmake iirc

Fabien accepted this revision.May 23 2024, 07:18

This revision is now accepted and ready to land.May 23 2024, 07:18

Closed by commit rABC4c05a04a597e: add missing includes and remove unneeded ones (authored by PiRK). · Explain WhyMay 23 2024, 07:58

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC4c05a04a597e: add missing includes and remove unneeded ones.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

proofbuilder.cpp

1 line

2 lines

bitcoin-cli.cpp

2 lines

chainparams.cpp

2 lines

1 line

1 line

2 lines

qt/

1 line

rpc/

1 line

2 lines

script/

1 line

seeder/

test/

options_tests.cpp

1 line

test/

getarg_tests.cpp

1 line

1 line

1 line

1 line

wallet/

1 line

5 lines

coinselection.cpp

1 line

scriptpubkeyman.h

1 line

scriptpubkeyman.cpp

1 line

1 line

zmq/

zmqnotificationinterface.cpp

1 line

zmqpublishnotifier.cpp

1 line

Diff 47916

src/avalanche/proofbuilder.cpp

Loading...

src/banman.cpp

Loading...

src/bitcoin-cli.cpp

Loading...

src/chainparams.cpp

Loading...

src/dbwrapper.h

Loading...

src/httprpc.cpp

Loading...

src/protocol.cpp

Loading...

src/qt/guiutil.cpp

Loading...

src/rpc/server.cpp

Loading...

src/rpc/util.cpp

Loading...

src/script/sigcache.cpp

Loading...

src/seeder/test/options_tests.cpp

Loading...

src/test/getarg_tests.cpp

Loading...

src/timedata.cpp

Loading...

src/torcontrol.cpp

Loading...

src/txmempool.cpp

Loading...

src/wallet/bdb.h

Loading...

src/wallet/bdb.cpp

Loading...

src/wallet/coinselection.cpp

Loading...

src/wallet/scriptpubkeyman.h

Loading...

src/wallet/scriptpubkeyman.cpp

Loading...

src/wallet/wallet.h

Loading...

src/zmq/zmqnotificationinterface.cpp

Loading...

src/zmq/zmqpublishnotifier.cpp

Loading...