[avalanche] Add comment to clarify pm::exists
ClosedPublic
Actions

Authored by roqqit on Aug 7 2024, 17:45.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABCde1a66ace842: [avalanche] Add comment to clarify pm::exists

Summary

The addition of danglingProofPool made the API of this function less clear.
Renaming the function is debatable so I prefer to just comment it and move on.

Test Plan

Read the comment and verify the implementation matches those expectations.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

roqqit created this revision.Aug 7 2024, 17:45

Owners added a reviewer: Restricted Owners Package.Aug 7 2024, 17:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 7 2024, 17:45

roqqit requested review of this revision.Aug 7 2024, 17:45

Fabien accepted this revision.Aug 7 2024, 17:50

This revision is now accepted and ready to land.Aug 7 2024, 17:50

Harbormaster completed remote builds in B29892: Diff 49083.Aug 7 2024, 18:16

Closed by commit rABCde1a66ace842: [avalanche] Add comment to clarify pm::exists (authored by roqqit). · Explain WhyAug 7 2024, 19:39

This revision was automatically updated to reflect the committed changes.

roqqit added a commit: rABCde1a66ace842: [avalanche] Add comment to clarify pm::exists.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

peermanager.h

4 lines

Diff 49087

View Options

src/avalanche/peermanager.h

[avalanche] Add comment to clarify pm::existsClosedPublicActions