Differential D16691

[avalanche] Make buildRandomProof use a random payout script
ClosedPublic
Actions

Authored by roqqit on Aug 28 2024, 19:23.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABC7aafd2f1c1e7: [avalanche] Make buildRandomProof use a random payout script

Summary

It is easy to accidentally write tests assuming that buildRandomProof() will produce proofs with random payout scripts. This is not the case. There does not appear to be good case for random proofs to payout to UNSPENDABLE_ECREG_PAYOUT_SCRIPT considering all tests pass without any modification.

Test Plan

ninja check-avalanche

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

roqqit created this revision.Aug 28 2024, 19:23

Owners added a reviewer: Restricted Owners Package.Aug 28 2024, 19:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 28 2024, 19:23

roqqit requested review of this revision.Aug 28 2024, 19:23

Harbormaster completed remote builds in B30119: Diff 49396.Aug 28 2024, 19:43

PiRK accepted this revision.Aug 29 2024, 06:33

This revision is now accepted and ready to land.Aug 29 2024, 06:33

Closed by commit rABC7aafd2f1c1e7: [avalanche] Make buildRandomProof use a random payout script (authored by roqqit). · Explain WhyAug 29 2024, 16:04

This revision was automatically updated to reflect the committed changes.

roqqit added a commit: rABC7aafd2f1c1e7: [avalanche] Make buildRandomProof use a random payout script.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

test/

7 lines

Diff 49410

src/avalanche/test/util.cpp

Loading...