Page MenuHomePhabricator
Differential D17056

[electrum] remove outdated error message
AbandonedPublic
Actions

Authored by PiRK on Oct 31 2024, 20:16.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

The node will not respond with this message since D4576. Remove it to avoid future confusion.

Test Plan

proof-read, check that grep -r upgrade-conditional-script-failure does not return anything in the entire monorepo

Diff Detail

Repository
rABC Bitcoin ABC
Branch
upgrade-conditional-script-failure
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 30952
Build 61407: Build Diffelectrum-tests
Build 61406: arc lint + arc unit

Event Timeline

PiRK created this revision.Oct 31 2024, 20:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 31 2024, 20:16
PiRK requested review of this revision.Oct 31 2024, 20:16
PiRK planned changes to this revision.Oct 31 2024, 20:21

Actually I'm not sure we should remove it. It seems like this was reused and re-removed even after D4576 (see D5283). Maybe we should keep looking for it in Electrum it for another potential future node consensus upgrade?

Harbormaster completed remote builds in B30952: Diff 50591.Oct 31 2024, 20:32
PiRK abandoned this revision.Nov 2 2024, 19:28

Revision Contents
Changeset List

PathSize
electrum/
electrumabc/
1 line

Diff 50591

View Options

electrum/electrumabc/network.py

Loading...