Now that isFinal is returned by chronik and chronik-client, update types
Details
Details
- Reviewers
- None
- Group Reviewers
Restricted Project
npm test
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- herald-to-new-chronik-types
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 31265 Build 62028: Build Diff ecash-herald-tests Build 62027: arc lint + arc unit
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (ecash-herald-tests) failed.
Tail of the build log:
TSError: ⨯ Unable to compile TypeScript:
test/mocks/mockChronikCalls.ts(76,5): error TS2353: Object literal may only specify known properties, and 'isFinal' does not exist in type 'Tx'.
test/mocks/mockChronikCalls.ts(169,5): error TS2353: Object literal may only specify known properties, and 'isFinal' does not exist in type 'Tx'.
test/mocks/mockChronikCalls.ts(251,5): error TS2353: Object literal may only specify known properties, and 'isFinal' does not exist in type 'Tx'.
test/mocks/mockChronikCalls.ts(321,5): error TS2353: Object literal may only specify known properties, and 'isFinal' does not exist in type 'Tx'.
at createTSError (/work/apps/ecash-herald/node_modules/ts-node/src/index.ts:859:12)
at reportTSError (/work/apps/ecash-herald/node_modules/ts-node/src/index.ts:863:19)
at getOutput (/work/apps/ecash-herald/node_modules/ts-node/src/index.ts:1077:36)
at Object.compile (/work/apps/ecash-herald/node_modules/ts-node/src/index.ts:1433:41)
at Module.m._compile (/work/apps/ecash-herald/node_modules/ts-node/src/index.ts:1617:30)
at module.exports (/usr/lib/node_modules/nyc/node_modules/default-require-extensions/js.js:7:9)
at /usr/lib/node_modules/nyc/node_modules/append-transform/index.js:64:4
at require.extensions.<computed> (/work/apps/ecash-herald/node_modules/ts-node/src/index.ts:1621:12)
at Object.<anonymous> (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:64:4)
at Module.load (node:internal/modules/cjs/loader:1288:32)
at Function.Module._load (node:internal/modules/cjs/loader:1104:12)
at Module.require (node:internal/modules/cjs/loader:1311:19)
at require (node:internal/modules/helpers:179:18)
at Object.<anonymous> (/work/apps/ecash-herald/test/chronik.test.ts:14:1)
at Module._compile (node:internal/modules/cjs/loader:1469:14)
at Module.replacementCompile (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:60:13)
at Module.m._compile (/work/apps/ecash-herald/node_modules/ts-node/src/index.ts:1618:23)
at module.exports (/usr/lib/node_modules/nyc/node_modules/default-require-extensions/js.js:7:9)
at /usr/lib/node_modules/nyc/node_modules/append-transform/index.js:64:4
at require.extensions.<computed> (/work/apps/ecash-herald/node_modules/ts-node/src/index.ts:1621:12)
at Object.<anonymous> (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:64:4)
at Module.load (node:internal/modules/cjs/loader:1288:32)
at Function.Module._load (node:internal/modules/cjs/loader:1104:12)
at Module.require (node:internal/modules/cjs/loader:1311:19)
at require (node:internal/modules/helpers:179:18)
at Object.exports.requireOrImport (/work/apps/ecash-herald/node_modules/mocha/lib/nodejs/esm-utils.js:53:16)
at async Object.exports.loadFilesAsync (/work/apps/ecash-herald/node_modules/mocha/lib/nodejs/esm-utils.js:100:20)
at async singleRun (/work/apps/ecash-herald/node_modules/mocha/lib/cli/run-helpers.js:125:3)
at async Object.exports.handler (/work/apps/ecash-herald/node_modules/mocha/lib/cli/run.js:370:5)
------------------------|---------|----------|---------|---------|----------------------------------
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
------------------------|---------|----------|---------|---------|----------------------------------
All files | 16.66 | 0 | 0 | 11.8 |
ecash-herald | 100 | 100 | 100 | 100 |
config.ts | 100 | 100 | 100 | 100 |
ecash-herald/constants | 100 | 100 | 100 | 100 |
addresses.ts | 100 | 100 | 100 | 100 |
ecash-herald/src | 14.63 | 0 | 0 | 9.46 |
chronik.ts | 11.82 | 0 | 0 | 7.95 | 23-64,82-141,155-182,198-265
utils.ts | 15.97 | 0 | 0 | 10.22 | ...3-368,382-392,402-424,444-483
------------------------|---------|----------|---------|---------|----------------------------------
##teamcity[blockOpened name='Code Coverage Summary']
##teamcity[buildStatisticValue key='CodeCoverageAbsBCovered' value='49']
##teamcity[buildStatisticValue key='CodeCoverageAbsBTotal' value='294']
##teamcity[buildStatisticValue key='CodeCoverageAbsRCovered' value='0']
##teamcity[buildStatisticValue key='CodeCoverageAbsRTotal' value='79']
##teamcity[buildStatisticValue key='CodeCoverageAbsMCovered' value='0']
##teamcity[buildStatisticValue key='CodeCoverageAbsMTotal' value='37']
##teamcity[buildStatisticValue key='CodeCoverageAbsLCovered' value='32']
##teamcity[buildStatisticValue key='CodeCoverageAbsLTotal' value='271']
##teamcity[blockClosed name='Code Coverage Summary']
mv: cannot stat 'test_results/ecash-herald-junit.xml': No such file or directory
Build ecash-herald-tests failed with exit code 1