Differential D17679

Remove extra mockscheduler call in abc_p2p_getavaaddr
ClosedPublic
Actions

Authored by Fabien on Wed, Feb 19, 17:01.

Details

Reviewers

roqqit

Group Reviewers

Restricted Project

Commits

rABC2a1c960435b6: Remove extra mockscheduler call in abc_p2p_getavaaddr

Summary

The scheduler is already mocked repeatidily to ensure the expected condition is met. Calling it one more time might change the status and break the expectation, causing the test to fail.

Test Plan

./test/functional/test_runner.py abc_p2p_getavaaddr

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Wed, Feb 19, 17:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Feb 19, 17:01

Fabien requested review of this revision.Wed, Feb 19, 17:01

Harbormaster completed remote builds in B32420: Diff 52678.Wed, Feb 19, 17:10

roqqit accepted this revision.Wed, Feb 19, 20:59

This revision is now accepted and ready to land.Wed, Feb 19, 20:59

Closed by commit rABC2a1c960435b6: Remove extra mockscheduler call in abc_p2p_getavaaddr (authored by Fabien). · Explain WhyThu, Feb 20, 08:28

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC2a1c960435b6: Remove extra mockscheduler call in abc_p2p_getavaaddr.

Revision Contents
Changeset List

Path

Size

test/

functional/

abc_p2p_getavaaddr.py

2 lines

Diff 52686

View Options

test/functional/abc_p2p_getavaaddr.py

Remove extra mockscheduler call in abc_p2p_getavaaddrClosedPublicActions