Differential D17983

[avalanche] Prevent regressions in the case that promotion happens twice for a block
ClosedPublic
Actions

Authored by roqqit on Wed, Apr 23, 17:23.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCec671e1e6767: [avalanche] Prevent regressions in the case that promotion happens twice for a…

Summary

This ensures that any future design changes in contenders that could trigger promotion multiple times on the same block do not overwrite any polling results that may have occurred since the first promotion.

Test Plan

ninja check-avalanche-stakecontendercache_tests

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

roqqit created this revision.Wed, Apr 23, 17:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Apr 23, 17:23

roqqit requested review of this revision.Wed, Apr 23, 17:23

Harbormaster completed remote builds in B33079: Diff 53649.Wed, Apr 23, 17:34

Fabien accepted this revision.Wed, Apr 23, 18:53

This revision is now accepted and ready to land.Wed, Apr 23, 18:53

Closed by commit rABCec671e1e6767: [avalanche] Prevent regressions in the case that promotion happens twice for a… (authored by roqqit). · Explain WhyWed, Apr 23, 21:10

This revision was automatically updated to reflect the committed changes.

roqqit added a commit: rABCec671e1e6767: [avalanche] Prevent regressions in the case that promotion happens twice for a….

Revision Contents
Changeset List

Path

Size

src/

avalanche/

test/

stakecontendercache_tests.cpp

15 lines

Diff 53660

View Options

src/avalanche/test/stakecontendercache_tests.cpp

[avalanche] Prevent regressions in the case that promotion happens twice for a blockClosedPublicActions