Page MenuHomePhabricator
Differential D19059

[chronik-client] Remove phantom pagination params from unconfirmedTxs endpoints
Needs ReviewPublic
Actions

Authored by bytesofman on Fri, Dec 5, 13:56.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

These pagination params are not doing anything. Remove them

Test Plan

npm test, CI

Diff Detail

Event Timeline

bytesofman created this revision.Fri, Dec 5, 13:56
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Dec 5, 13:56
Harbormaster completed remote builds in B35250: Diff 56898.Fri, Dec 5, 14:09
teamcity added a comment.Fri, Dec 5, 14:09
Build Bitcoin ABC Diffs / Diff Testing (ecash-herald-tests) failed.

Tail of the build log:

> chronik-client@3.7.1 build
> tsc

/work/modules/ecash-lib /work/abc-ci-builds/ecash-herald-tests

added 271 packages, and audited 275 packages in 1s

37 packages are looking for funding
  run `npm fund` for details

8 vulnerabilities (1 low, 6 moderate, 1 high)

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

> ecash-lib@4.5.2 build
> tsc && tsc -p ./tsconfig.build.json && cp -r ./src/ffi ./dist

/work/modules/ecash-wallet /work/abc-ci-builds/ecash-herald-tests

added 221 packages, and audited 224 packages in 2s

57 packages are looking for funding
  run `npm fund` for details

5 vulnerabilities (3 low, 1 moderate, 1 high)

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

> ecash-wallet@2.3.5 build
> tsc -p ./tsconfig.build.json

/work/modules/ecash-agora /work/abc-ci-builds/ecash-herald-tests

added 273 packages, and audited 1634 packages in 3s

110 packages are looking for funding
  run `npm fund` for details

16 vulnerabilities (3 low, 9 moderate, 3 high, 1 critical)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.

> ecash-agora@2.6.7 build
> tsc && tsc -p ./tsconfig.build.json

src/agora.ts(1048,21): error TS2554: Expected 1 arguments, but got 3.
Build ecash-herald-tests failed with exit code 2
bytesofman updated this revision to Diff 56899.Fri, Dec 5, 14:14

build lint

teamcity added a comment.Fri, Dec 5, 14:18
Build Bitcoin ABC Diffs / Diff Testing (ecash-agora-integration-tests) failed.

Tail of the build log:

[561/598] Linking CXX executable src/bench/bitcoin-bench
[562/598] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/addressbookpage.cpp.o
[563/598] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/createwalletdialog.cpp.o
[564/598] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/coincontroltreewidget.cpp.o
[565/598] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/splashscreen.cpp.o
[566/598] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/editaddressdialog.cpp.o
[567/598] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/qrc_bitcoin_locale.cpp.o
[568/598] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/askpassphrasedialog.cpp.o
[569/598] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/qrimagewidget.cpp.o
[570/598] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/openuridialog.cpp.o
[571/598] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/addresstablemodel.cpp.o
[572/598] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/overviewpage.cpp.o
[573/598] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/transactionfilterproxy.cpp.o
[574/598] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/receiverequestdialog.cpp.o
[575/598] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/transactiondescdialog.cpp.o
[576/598] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/recentrequeststablemodel.cpp.o
[577/598] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/sendcoinsentry.cpp.o
[578/598] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/receivecoinsdialog.cpp.o
[579/598] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/coincontroldialog.cpp.o
[580/598] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/rpcconsole.cpp.o
[581/598] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/transactionrecord.cpp.o
[582/598] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/paymentserver.cpp.o
[583/598] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/signverifymessagedialog.cpp.o
[584/598] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/walletframe.cpp.o
[585/598] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/walletmodeltransaction.cpp.o
[586/598] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/transactionview.cpp.o
[587/598] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/transactiondesc.cpp.o
[588/598] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/paymentrequestplus.cpp.o
[589/598] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/transactiontablemodel.cpp.o
[590/598] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/walletcontroller.cpp.o
[591/598] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/sendcoinsdialog.cpp.o
[592/598] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/walletview.cpp.o
[593/598] Building CXX object src/qt/CMakeFiles/bitcoin-qt-base.dir/walletmodel.cpp.o
[594/598] Linking CXX static library src/qt/libbitcoin-qt-base.a
[595/598] Automatic MOC for target bitcoin-qt
[596/598] Building CXX object src/qt/CMakeFiles/bitcoin-qt.dir/bitcoin-qt_autogen/mocs_compilation.cpp.o
[597/598] Building CXX object src/qt/CMakeFiles/bitcoin-qt.dir/main.cpp.o
[598/598] Linking CXX executable src/qt/bitcoin-qt
/work/modules/ecash-agora /work/abc-ci-builds/ecash-agora-integration-tests

added 273 packages, and audited 1634 packages in 3s

110 packages are looking for funding
  run `npm fund` for details

16 vulnerabilities (3 low, 9 moderate, 3 high, 1 critical)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.

> ecash-agora@2.6.7 build
> tsc && tsc -p ./tsconfig.build.json

src/agora.ts(1048,21): error TS2554: Expected 1 arguments, but got 3.
Build ecash-agora-integration-tests failed with exit code 2
teamcity added a comment.Fri, Dec 5, 14:21
Build Bitcoin ABC Diffs / Diff Testing (chronik-client-integration-tests) failed.

Tail of the build log:

2025-12-05T14:16:07.406000Z TestFramework (INFO): Step 8: Invalidate block with first two txs
2025-12-05T14:16:07.409000Z TestFramework (INFO): Step 9: Create a block with more groups
2025-12-05T14:16:07.556000Z TestFramework (INFO): Step 10: Send a tx that spends all 'all' utxos
2025-12-05T14:16:07.603000Z TestFramework (INFO): Step 11: Mine the tx that spends all 'all' utxos
2025-12-05T14:16:07.622000Z TestFramework (INFO): Step 12: Spend all utxos that have an integer as group
plugin_groups.ts tests complete, shutting down child process
2025-12-05T14:16:07.673000Z TestFramework (INFO): Got a next message but no more step, exiting
2025-12-05T14:16:07.723000Z TestFramework (INFO): Stopping nodes
2025-12-05T14:16:07.875000Z TestFramework (INFO): Cleaning up /work/abc-ci-builds/chronik-client-integration-tests/test/tmp/test_runner_₿₵_🏃_20251205_141605_9809/setup_scripts/chronik-client_plugin_groups_0 on exit
2025-12-05T14:16:07.876000Z TestFramework (INFO): Tests successful
Running Unit Tests for Test Framework Modules
setup_scripts/chronik-client_plugin_groups.py started
setup_scripts/chronik-client_plugin_groups.py passed, Duration: 2 s

TEST                                          | STATUS    | DURATION

setup_scripts/chronik-client_plugin_groups.py | ✓ Passed  | 2 s

ALL                                           | ✓ Passed  | 2 s (accumulated) 
Runtime: 2 s

testRunner complete in plugin_groups.ts
Starting test_runner for chronik-client_plugins
Test runner for chronik-client_plugins started
2025-12-05T14:16:08.207000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/chronik-client-integration-tests/test/tmp/test_runner_₿₵_🏃_20251205_141608_6649/setup_scripts/chronik-client_plugins_0
2025-12-05T14:16:08.724000Z TestFramework (INFO): Passed test setup data to mocha
chronikUrl set to ["http://127.0.0.1:26000"]
Mocha timeout set to 240 seconds
2025-12-05T14:16:09.523000Z TestFramework (INFO): Step 1: Empty regtest chain
2025-12-05T14:16:09.556000Z TestFramework (INFO): Step 2: Send a tx to create plugin utxos in group 'a'
2025-12-05T14:17:09.698000Z TestFramework (INFO): Step 3: Send a second tx to create plugin utxos in group 'b'
2025-12-05T14:18:09.709000Z TestFramework (INFO): Step 4: Mine these first two transactions
2025-12-05T14:19:09.754000Z TestFramework (INFO): Step 5: Send a third tx to create plugin utxos in group 'c'
Exited plugins.ts test setup after exceeding mocha timeout.
----------------------|---------|----------|---------|---------|------------------------------------
File                  | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                  
----------------------|---------|----------|---------|---------|------------------------------------
All files             |   27.56 |    10.57 |   25.04 |    27.5 |                                    
 chronik-client       |     100 |      100 |     100 |     100 |                                    
  index.ts            |     100 |      100 |     100 |     100 |                                    
 chronik-client/proto |   20.79 |     7.95 |   15.28 |   20.97 |                                    
  chronik.ts          |   20.79 |     7.95 |   15.28 |   20.97 | ...1,6847-6850,6856-6898,6934-6943 
 chronik-client/src   |   55.91 |    40.22 |   52.79 |   55.27 |                                    
  ChronikClient.ts    |   47.57 |    38.75 |    49.6 |   47.89 | ...5,1567,1577,1602,1614,1625-1709 
  failoverProxy.ts    |   78.94 |    59.37 |   66.66 |   78.37 | ...285,288,301,308,312,316,325,329 
  hex.ts              |   89.47 |       50 |      75 |   87.87 | 58,66-68                           
  validation.ts       |   53.33 |     12.5 |      40 |    47.5 | 17,21,33,38-49,62-63,70-71,81-96   
----------------------|---------|----------|---------|---------|------------------------------------

##teamcity[blockOpened name='Code Coverage Summary']
##teamcity[buildStatisticValue key='CodeCoverageAbsBCovered' value='934']
##teamcity[buildStatisticValue key='CodeCoverageAbsBTotal' value='3388']
##teamcity[buildStatisticValue key='CodeCoverageAbsRCovered' value='233']
##teamcity[buildStatisticValue key='CodeCoverageAbsRTotal' value='2203']
##teamcity[buildStatisticValue key='CodeCoverageAbsMCovered' value='155']
##teamcity[buildStatisticValue key='CodeCoverageAbsMTotal' value='619']
##teamcity[buildStatisticValue key='CodeCoverageAbsLCovered' value='921']
##teamcity[buildStatisticValue key='CodeCoverageAbsLTotal' value='3349']
##teamcity[blockClosed name='Code Coverage Summary']
Build chronik-client-integration-tests failed with exit code 1
Harbormaster completed remote builds in B35251: Diff 56899.Fri, Dec 5, 14:37
teamcity added a comment.Fri, Dec 5, 14:37
Build Bitcoin ABC Diffs / Diff Testing (chronik-client-integration-tests) failed.

Tail of the build log:

2025-12-05T14:32:06.882000Z TestFramework (INFO): Step 8: Invalidate block with first two txs
2025-12-05T14:32:06.885000Z TestFramework (INFO): Step 9: Create a block with more groups
2025-12-05T14:32:07.031000Z TestFramework (INFO): Step 10: Send a tx that spends all 'all' utxos
2025-12-05T14:32:07.081000Z TestFramework (INFO): Step 11: Mine the tx that spends all 'all' utxos
2025-12-05T14:32:07.102000Z TestFramework (INFO): Step 12: Spend all utxos that have an integer as group
plugin_groups.ts tests complete, shutting down child process
2025-12-05T14:32:07.155000Z TestFramework (INFO): Got a next message but no more step, exiting
2025-12-05T14:32:07.205000Z TestFramework (INFO): Stopping nodes
2025-12-05T14:32:07.357000Z TestFramework (INFO): Cleaning up /work/abc-ci-builds/chronik-client-integration-tests/test/tmp/test_runner_₿₵_🏃_20251205_143205_51244/setup_scripts/chronik-client_plugin_groups_0 on exit
2025-12-05T14:32:07.357000Z TestFramework (INFO): Tests successful
Running Unit Tests for Test Framework Modules
setup_scripts/chronik-client_plugin_groups.py started
setup_scripts/chronik-client_plugin_groups.py passed, Duration: 2 s

TEST                                          | STATUS    | DURATION

setup_scripts/chronik-client_plugin_groups.py | ✓ Passed  | 2 s

ALL                                           | ✓ Passed  | 2 s (accumulated) 
Runtime: 2 s

testRunner complete in plugin_groups.ts
Starting test_runner for chronik-client_plugins
Test runner for chronik-client_plugins started
2025-12-05T14:32:07.649000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/chronik-client-integration-tests/test/tmp/test_runner_₿₵_🏃_20251205_143207_37215/setup_scripts/chronik-client_plugins_0
2025-12-05T14:32:08.157000Z TestFramework (INFO): Passed test setup data to mocha
chronikUrl set to ["http://127.0.0.1:26000"]
Mocha timeout set to 240 seconds
2025-12-05T14:32:08.984000Z TestFramework (INFO): Step 1: Empty regtest chain
2025-12-05T14:32:09.017000Z TestFramework (INFO): Step 2: Send a tx to create plugin utxos in group 'a'
2025-12-05T14:33:09.113000Z TestFramework (INFO): Step 3: Send a second tx to create plugin utxos in group 'b'
2025-12-05T14:34:09.146000Z TestFramework (INFO): Step 4: Mine these first two transactions
2025-12-05T14:35:09.191000Z TestFramework (INFO): Step 5: Send a third tx to create plugin utxos in group 'c'
Exited plugins.ts test setup after exceeding mocha timeout.
----------------------|---------|----------|---------|---------|------------------------------------
File                  | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                  
----------------------|---------|----------|---------|---------|------------------------------------
All files             |   27.56 |    10.57 |   25.04 |    27.5 |                                    
 chronik-client       |     100 |      100 |     100 |     100 |                                    
  index.ts            |     100 |      100 |     100 |     100 |                                    
 chronik-client/proto |   20.79 |     7.95 |   15.28 |   20.97 |                                    
  chronik.ts          |   20.79 |     7.95 |   15.28 |   20.97 | ...1,6847-6850,6856-6898,6934-6943 
 chronik-client/src   |   55.91 |    40.22 |   52.79 |   55.27 |                                    
  ChronikClient.ts    |   47.57 |    38.75 |    49.6 |   47.89 | ...5,1567,1577,1602,1614,1625-1709 
  failoverProxy.ts    |   78.94 |    59.37 |   66.66 |   78.37 | ...285,288,301,308,312,316,325,329 
  hex.ts              |   89.47 |       50 |      75 |   87.87 | 58,66-68                           
  validation.ts       |   53.33 |     12.5 |      40 |    47.5 | 17,21,33,38-49,62-63,70-71,81-96   
----------------------|---------|----------|---------|---------|------------------------------------

##teamcity[blockOpened name='Code Coverage Summary']
##teamcity[buildStatisticValue key='CodeCoverageAbsBCovered' value='934']
##teamcity[buildStatisticValue key='CodeCoverageAbsBTotal' value='3388']
##teamcity[buildStatisticValue key='CodeCoverageAbsRCovered' value='233']
##teamcity[buildStatisticValue key='CodeCoverageAbsRTotal' value='2203']
##teamcity[buildStatisticValue key='CodeCoverageAbsMCovered' value='155']
##teamcity[buildStatisticValue key='CodeCoverageAbsMTotal' value='619']
##teamcity[buildStatisticValue key='CodeCoverageAbsLCovered' value='921']
##teamcity[buildStatisticValue key='CodeCoverageAbsLTotal' value='3349']
##teamcity[blockClosed name='Code Coverage Summary']
Build chronik-client-integration-tests failed with exit code 1
bytesofman updated this revision to Diff 56904.Fri, Dec 5, 17:20

update test expectations

Harbormaster completed remote builds in B35255: Diff 56904.Fri, Dec 5, 17:32
teamcity added a comment.Fri, Dec 5, 17:32
Build Bitcoin ABC Diffs / Diff Testing (chronik-client-integration-tests) failed.

Failed tests logs:

====== Get script().history and script().utxos(): New regtest chain.Get script().history and script().utxos() New regtest chain ======
AssertionError: expected promise to be rejected with an error including 'Failed getting /script/p2pkh/justsome…' but got 'Failed getting /script/p2pkh/justsome…'

      + expected - actual

      -Failed getting /script/p2pkh/justsomestring/unconfirmed-txs: 400: Invalid hex: Invalid character 'j' at position 0
      +Failed getting /script/p2pkh/justsomestring/unconfirmed-txs?page=0&page_size=25: 400: Invalid hex: Invalid character 'j' at position 0

Each failure log is accessible here:
Get script().history and script().utxos(): New regtest chain.Get script().history and script().utxos() New regtest chain

bytesofman updated this revision to Diff 56905.Fri, Dec 5, 17:37

more expectations updated

Harbormaster completed remote builds in B35256: Diff 56905.Fri, Dec 5, 17:47
bytesofman published this revision for review.Fri, Dec 5, 17:48

Revision Contents
Changeset List

PathSize
modules/
chronik-client/
1 line
4 lines
2 lines
src/
45 lines
test/
integration/
4 lines
16 lines
ecash-agora/
src/
2 lines

Diff 56905

View Options

modules/chronik-client/README.md

Loading...
View Options

modules/chronik-client/package-lock.json

Loading...
View Options

modules/chronik-client/package.json

Loading...
View Options

modules/chronik-client/src/ChronikClient.ts

Loading...
View Options

modules/chronik-client/test/integration/plugins.ts

Loading...
View Options

modules/chronik-client/test/integration/script_endpoints.ts

Loading...
View Options

modules/ecash-agora/src/agora.ts

Loading...