Page MenuHomePhabricator
Differential D4655

[Backport] Never bind INADDR_ANY by default, and warn when doing so explicitly
Needs RevisionPublic
Actions

Authored by ProtocolCash on Dec 5 2019, 22:45.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

net: Always default rpcbind to localhost, never "all interfaces"
We don't support binding to untrusted networks, so avoid a default where that is typical

fix defaultPort

CNetAddr: Add IsBindAny method to check for INADDR_ANY

rpcbind: Warn about exposing RPC to untrusted networks

Backport of Bitcoin Core PR14532

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14532
Lint
Lint Passed
SeverityLocationCodeMessage
Auto-Fixsrc/httpserver.cpp:1CFMTCode style violation
Unit
No Test Coverage
Build Status
Buildable 8439
Build 14893: Default Diff Build & Tests
Build 14892: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
17 lines
12 lines
2 lines
9 lines

Diff 14668

View Options

src/httpserver.cpp

Loading...
View Options

src/init.cpp

Loading...
View Options

src/netaddress.h

Loading...
View Options

src/netaddress.cpp

Loading...