Page MenuHomePhabricator

deadalnix (Amaury SÉCHET)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
May 14 2017, 13:52 (273 w, 1 d)
Roles
Administrator

Recent Activity

Fri, Aug 5

deadalnix requested changes to D11750: [avalanche] Make proof dust threshold configurable.

I don't think this design with a config is a plus. A ton of code just got significantly more convoluted.

Fri, Aug 5, 12:32

Fri, Jul 22

deadalnix added inline comments to D11793: [avalanche] Fix occasional invalid node count in getavalancheinfo.
Fri, Jul 22, 15:49
deadalnix accepted D11793: [avalanche] Fix occasional invalid node count in getavalancheinfo.
Fri, Jul 22, 15:49

Thu, Jul 14

deadalnix accepted D11729: [avalanche] Add count of finalized proofs to getavalancheinfo.
Thu, Jul 14, 23:01
deadalnix added inline comments to D11724: [arcanist] Move jest unit tests to arc unit.
Thu, Jul 14, 23:00
deadalnix accepted D11748: use m_chain in CChainState::UpdateFlagsForBlock and CChainState::FinalizeBlock.
Thu, Jul 14, 22:59
deadalnix accepted D11749: [avalanche] Fix typo in dust threshold validation result type.
Thu, Jul 14, 22:59
deadalnix requested changes to D11750: [avalanche] Make proof dust threshold configurable.
Thu, Jul 14, 22:59
deadalnix accepted D11704: [avalanche] pass chainman to Proof::verify.
Thu, Jul 14, 22:58
deadalnix accepted D11701: [avalanche] Don't rely on the service bit for sending the avalanche message.
Thu, Jul 14, 22:57

Jul 8 2022

deadalnix accepted D11703: [avalanche] Pass chainman to PeerManager.
Jul 8 2022, 15:40
deadalnix requested changes to D11704: [avalanche] pass chainman to Proof::verify.
Jul 8 2022, 15:39

Jul 6 2022

deadalnix accepted D11713: Prepare release notes for 0.25.9.
Jul 6 2022, 01:40
deadalnix requested changes to D11703: [avalanche] Pass chainman to PeerManager.
Jul 6 2022, 00:55

Jul 5 2022

deadalnix requested changes to D11699: [avalanche] Send an empty compact proofs request if there is no shortid.
Jul 5 2022, 13:00
deadalnix requested changes to D11701: [avalanche] Don't rely on the service bit for sending the avalanche message.
Jul 5 2022, 12:58
deadalnix requested changes to D11700: [avalanche] Send a sendava message to notify we support avalanche.

I don't think we need a different message from avahello. You are creating a rube goldberg machine here.

Jul 5 2022, 12:54
deadalnix requested changes to D11704: [avalanche] pass chainman to Proof::verify.

Is there a reason not to pass the chain manager here, instead of passing down various values extracted from it?

Jul 5 2022, 12:52
deadalnix added inline comments to D11702: [avalanche] Pass chainman to Processor.
Jul 5 2022, 12:51
deadalnix accepted D11707: [avalanche] Request addresses and proofs from our inbounds while the quorum is not established.
Jul 5 2022, 12:50
deadalnix requested changes to D11698: [avalanche] Don't clean up the proof radix tree when it's already null.

You are creating special cases where none is necessary. Just handle the zero proof case like any other case is handled.

Jul 5 2022, 12:49
deadalnix added inline comments to D11703: [avalanche] Pass chainman to PeerManager.
Jul 5 2022, 12:47

Jul 3 2022

deadalnix accepted D11697: [avalanche] Add count of orphan proofs to getavalancheinfo.
Jul 3 2022, 11:12
deadalnix accepted D11696: [avalanche] Add count of conflicting proofs to getavalancheinfo.
Jul 3 2022, 11:12

Jul 1 2022

deadalnix resigned from D11693: [avalanche] Vote on proofs if the quorum is not established.
Jul 1 2022, 18:57
deadalnix accepted D11693: [avalanche] Vote on proofs if the quorum is not established.
Jul 1 2022, 18:45
deadalnix accepted D11692: [avalanche] Correctly flag the inflight compact proofs request.
Jul 1 2022, 17:50

Jun 30 2022

deadalnix accepted D11677: [avalanche] Poll for unorphaned proofs.
Jun 30 2022, 00:05
deadalnix accepted D11681: [avalanche] Skip processing compact proofs with no shortid.
Jun 30 2022, 00:02
deadalnix accepted D11680: [avalanche] Add a facility for building an compact proofs message in tests.
Jun 30 2022, 00:01

Jun 29 2022

deadalnix accepted D11676: [avalanche] Don't attempt to register the same proof several times during orphan rescan.
Jun 29 2022, 23:59

Jun 26 2022

deadalnix accepted D11630: [avalanche] Don't process proofs that are not worth polling.
Jun 26 2022, 23:35

Jun 21 2022

deadalnix added inline comments to D11622: [avalanche] Enforce min UTXO age in avalanche proofs.
Jun 21 2022, 00:52
deadalnix requested changes to D11630: [avalanche] Don't process proofs that are not worth polling.
Jun 21 2022, 00:50
deadalnix requested changes to D11637: [avalanche] Remove obsolete orphan proofs.

The rationale makes no sense. It is possible to balloon the pool in 30mins, so this is insufficient. So you need another criteria to evict from the pool, but it you have that other criteria, it is more likely than not that this one becomes useless.

Jun 21 2022, 00:44

Jun 18 2022

deadalnix added inline comments to D11630: [avalanche] Don't process proofs that are not worth polling.
Jun 18 2022, 21:56

Jun 17 2022

deadalnix requested changes to D11637: [avalanche] Remove obsolete orphan proofs.
Jun 17 2022, 19:42
deadalnix requested changes to D11630: [avalanche] Don't process proofs that are not worth polling.
Jun 17 2022, 12:33
deadalnix added inline comments to D11622: [avalanche] Enforce min UTXO age in avalanche proofs.
Jun 17 2022, 12:29

Jun 14 2022

deadalnix accepted D11625: [LINT] Fix trailing whitespaces in the contributing doc.
Jun 14 2022, 10:27

Jun 8 2022

deadalnix accepted D11545: [avalanche] Request missing proofs from short ids.
Jun 8 2022, 22:38
deadalnix accepted D11574: Leverage Empty Base Optimization for the radix tree Adapter.
Jun 8 2022, 22:37
deadalnix requested changes to D11574: Leverage Empty Base Optimization for the radix tree Adapter.
Jun 8 2022, 14:11
deadalnix requested changes to D11582: [avalanche] Limit the size of the valid proof pool.

No this does not help, because you'll have to get rid of proofs for which there is no node regardless. In fact, not only do you need to, but this becomes significantly more important to once you limit how many proofs you can accept.

Jun 8 2022, 13:23

Jun 7 2022

deadalnix added inline comments to D11575: [avalanche] Respond to missing proof indices request.
Jun 7 2022, 23:22
deadalnix accepted D11575: [avalanche] Respond to missing proof indices request.
Jun 7 2022, 23:22
deadalnix added a comment to D11582: [avalanche] Limit the size of the valid proof pool.

Maybe we should just evict proof for which we have no peer after some time instead. We kind of have to do it anyways, and this makes this patch moot as far as I can tell.

Jun 7 2022, 23:20
deadalnix requested changes to D11545: [avalanche] Request missing proofs from short ids.
Jun 7 2022, 22:49

Jun 6 2022

deadalnix added inline comments to D11571: Extract the compact block processing into a generic helper class.
Jun 6 2022, 12:32
deadalnix accepted D11453: [avalanche] Introduce a CompactProofs class for managing the short proof ids.
Jun 6 2022, 12:30
deadalnix accepted D11562: [avalanche] Add a way to get the lowest scoring proof in a pool.
Jun 6 2022, 12:29

Jun 2 2022

deadalnix accepted D11556: Clarify that m_tx_relay and m_proof_relay are thread safe.
Jun 2 2022, 12:02
deadalnix accepted D11549: [avalanche] Request compact proofs from our avalanche outbound peers.
Jun 2 2022, 11:57
deadalnix accepted D11553: Fix includes in net.h related to past avalanche refactors.
Jun 2 2022, 00:04

Jun 1 2022

deadalnix requested changes to D11549: [avalanche] Request compact proofs from our avalanche outbound peers.

I'm not app at all with ho this is going.

Jun 1 2022, 20:51
deadalnix added inline comments to D11549: [avalanche] Request compact proofs from our avalanche outbound peers.
Jun 1 2022, 15:44
deadalnix requested changes to D11453: [avalanche] Introduce a CompactProofs class for managing the short proof ids.
Jun 1 2022, 15:43
deadalnix requested changes to D11545: [avalanche] Request missing proofs from short ids.
Jun 1 2022, 15:41
deadalnix requested changes to D11549: [avalanche] Request compact proofs from our avalanche outbound peers.
Jun 1 2022, 13:15
deadalnix requested changes to D11453: [avalanche] Introduce a CompactProofs class for managing the short proof ids.
Jun 1 2022, 11:07
deadalnix accepted D11548: [avalanche] Make stale voting parameters configurable.
Jun 1 2022, 11:03

May 31 2022

deadalnix added inline comments to D11453: [avalanche] Introduce a CompactProofs class for managing the short proof ids.
May 31 2022, 19:23
deadalnix requested changes to D11548: [avalanche] Make stale voting parameters configurable.
May 31 2022, 19:16
deadalnix requested changes to D11545: [avalanche] Request missing proofs from short ids.
May 31 2022, 16:32
deadalnix accepted D11533: [avalanche] Extract the compact proofs functional test to its own file.
May 31 2022, 12:42
deadalnix requested changes to D11544: [avalanche] Add network permission for a peer to send unrequested compact proofs.

I don't understand what's the purpose of this. At no point we should expect a node to send the whole set of proof without being requested. I don't think solves any problem.

May 31 2022, 12:42

May 29 2022

deadalnix accepted D11524: [avalanche] Drop stale votes and stale proofs.
May 29 2022, 23:56
deadalnix requested changes to D11532: [xec-js] Initial baseline for npm publication.

I had a quick look. Didn't review everything in there as it is quite big, but the little I review is quite worrying. This cealry doesn't match the kind of quality we want to put out there.

May 29 2022, 23:54

May 28 2022

deadalnix requested changes to D11524: [avalanche] Drop stale votes and stale proofs.
May 28 2022, 00:08

May 24 2022

deadalnix accepted D11502: [avalanche] Add a way to check if a VoteRecord is stale.
May 24 2022, 20:42
deadalnix accepted D11450: [avalanche] Maintain a radix tree of the proofs.
May 24 2022, 15:58
deadalnix added inline comments to D11453: [avalanche] Introduce a CompactProofs class for managing the short proof ids.
May 24 2022, 15:53
deadalnix requested changes to D11502: [avalanche] Add a way to check if a VoteRecord is stale.

These number do not make sense to me.

May 24 2022, 15:50
deadalnix requested changes to D11450: [avalanche] Maintain a radix tree of the proofs.
May 24 2022, 14:33

May 23 2022

deadalnix requested changes to D11453: [avalanche] Introduce a CompactProofs class for managing the short proof ids.
May 23 2022, 12:27
deadalnix requested changes to D11513: [avalanche] Update the default proof constructor so it can pass a serialization roundtrip.

Why do we want to compute the id of a proof that isn't initialized, and then recompute the correct one later? That doesn't make sense.

May 23 2022, 11:44
deadalnix accepted D11514: [RCU] Make it possible to serialize/deserialize a RCUPtr.
May 23 2022, 11:42
deadalnix accepted D11512: rpc/rawtx: Use existing NodeContext.
May 23 2022, 00:06

May 21 2022

deadalnix accepted D11503: [avalanche] Set voterecord_tests node ID using a fixture.
May 21 2022, 23:32
deadalnix added a comment to D11502: [avalanche] Add a way to check if a VoteRecord is stale.

These thresholds seems REALLY low. How did you pick them?

May 21 2022, 23:26
deadalnix accepted D11509: [RCU] Add an implicit converting constructor.
May 21 2022, 23:25

May 20 2022

deadalnix requested changes to D11453: [avalanche] Introduce a CompactProofs class for managing the short proof ids.
May 20 2022, 20:56
deadalnix accepted D11507: validation: Make BlockManager::LookupBlockIndex const.
May 20 2022, 19:43
deadalnix added inline comments to D11509: [RCU] Add an implicit converting constructor.
May 20 2022, 18:55
deadalnix accepted D11466: [avalanche] Turn ProofRef into a RCUPtr.
May 20 2022, 14:52
deadalnix requested changes to D11509: [RCU] Add an implicit converting constructor.
May 20 2022, 14:47
deadalnix requested changes to D11504: Revert "miner: Pass in chainstate to BlockAssembler::CreateNewBlock".

There is no need to break things before fixing them.

May 20 2022, 13:32
deadalnix accepted D11508: Move the Uint256RadixKey to its own header.
May 20 2022, 12:54
deadalnix requested changes to D11502: [avalanche] Add a way to check if a VoteRecord is stale.

So one successful round and w can stale forever? Seriously, I don't even know what to say, this is obviously not good.

May 20 2022, 12:53

May 19 2022

deadalnix accepted D11456: [radix] Adds the capability to use an adapter for key manipulation.
May 19 2022, 17:49
deadalnix accepted D11497: scripted-diff: net_processing: Use existing chainman.

This needs to happen for GetAvalancheVoteForBlock too.

May 19 2022, 17:46
deadalnix accepted D11495: net_processing: Move some static functions to PeerManager.
May 19 2022, 17:45
deadalnix accepted D11496: move getAvalancheVoteForBlock to PeerManagerImpl.

I see, it is about to use a member. LGTM.

May 19 2022, 17:44
deadalnix requested changes to D11496: move getAvalancheVoteForBlock to PeerManagerImpl.

It doesn't looks like it is using any state of the object, so why should this be a member method of that object? That doesn't make sense.

May 19 2022, 17:43
deadalnix requested changes to D11498: [avalanche] Maintain a count of the proofs in the proof pool.

This count cannot be simply retrieved using size() because it is a multimap like structure.

May 19 2022, 17:42
deadalnix accepted D11499: [avalanche] Move VoteRecord tests to their own file.
May 19 2022, 17:37
deadalnix requested changes to D11450: [avalanche] Maintain a radix tree of the proofs.
May 19 2022, 17:36
deadalnix requested changes to D11494: [avalanche] Fix underflow when clearing too many inflight requests.

I don't understand what problem this is solving. First, this is using low free gizmo that seem completely unecessary - aren't VoteReccord owned by locks to begin with?

May 19 2022, 17:30
deadalnix requested changes to D11466: [avalanche] Turn ProofRef into a RCUPtr.
May 19 2022, 17:27
deadalnix accepted D11463: [avalanche] Use the ProofComparator for sets and maps.
May 19 2022, 17:22