- User Since
- May 14 2017, 13:52 (140 w, 3 d)
Mon, Jan 20
It would reverse the metric setting logic as to avoid a double negation. Everything else is good to go.
Update as per comments
The general approach look good. Obviously, Without changing ScriptExecutionMetrics, it's hard to ensure your invariants hold, so you may want to unpod that guy as well.
Sun, Jan 19
A few minor improvement, but it's getting there. You should consider starting to work on activation logic and tests.
Requesting change, but most of it are actually questions. The only thing I'm really suspicious of is the block template thing.
Requesting changes, but it's more like questions.
Sat, Jan 18
From what I gather, it is fairly obvious that you actually don't want a but are trying to make things work as a pod. The problem when you distribute responsibilities is that you always end up with something inconsistent down the road or a huge pile of spaghetti because various pieces of code needs to be kept in sync.
Fri, Jan 17