Page MenuHomePhabricator

deadalnix (Amaury SÉCHET)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
May 14 2017, 13:52 (96 w, 1 d)
Roles
Administrator

Recent Activity

Yesterday

deadalnix accepted D2697: test: Replace remaining sprintf with snprintf.
Mon, Mar 18, 17:09
deadalnix accepted D2687: [CMAKE] Harden the executables.
Mon, Mar 18, 17:04

Thu, Mar 14

deadalnix requested changes to D2687: [CMAKE] Harden the executables.

Things have been reordered for no apparent good reason. That just makes the review difficult.

Thu, Mar 14, 02:53
deadalnix requested changes to D2682: [CMAKE] Avoid displaying the console when launching bitcoin-qt.exe.
Thu, Mar 14, 02:45

Wed, Mar 13

deadalnix changed the edit policy for T526: Schnorr-ifying.
Wed, Mar 13, 23:39
deadalnix changed the edit policy for T529: Schnorr batch verification.
Wed, Mar 13, 23:39
deadalnix added inline comments to D2686: [WIP] Added build-secp256k1.sh for running secp tests in TeamCity.
Wed, Mar 13, 02:09

Tue, Mar 12

deadalnix requested changes to D2685: [secp256k1] fix java secp256k1 test.

Please provide a detailed test plan. Running the tests is not sufficient as this specific test is not ran by default.

Tue, Mar 12, 23:33
deadalnix added a comment to D2133: Move shared qt/bitcoind initialization steps to shared functions..

Unless there is a larger plan here, this is just moving away from core without any clear benefit.

Tue, Mar 12, 20:20
deadalnix accepted D2657: [CMAKE] Check for linker flag support.
Tue, Mar 12, 20:15
deadalnix accepted D2644: [CMAKE] Override the flags for the Debug CMake configuration.
Tue, Mar 12, 20:14
deadalnix added inline comments to D2653: [CMAKE] Fix cached variable that prevents testing for flag support.
Tue, Mar 12, 20:12
deadalnix accepted D2653: [CMAKE] Fix cached variable that prevents testing for flag support.
Tue, Mar 12, 20:10
deadalnix requested changes to D2667: [CMAKE] Fix bitcoin-qt cross compilation for Windows.
Tue, Mar 12, 20:08
deadalnix added a comment to D2681: [secp256k1] remove guava dep.

Also, adding a test of the java binding to CI would be beneficial so that we can catch these things.

Tue, Mar 12, 20:01
deadalnix requested changes to D2681: [secp256k1] remove guava dep.

Can we get the java tests fixed before changes are made rather than mix the two together ?

Tue, Mar 12, 20:01
deadalnix added a comment to D2658: [CMAKE] Add stack protection flag.

Just port hardening at once. Right now there are no way to check if hardening is ported properly and as this diffs proves, individual steps seems to be broken.

Tue, Mar 12, 15:24

Sat, Mar 9

Herald added a reviewer for D2678: Update seeds.: Restricted Project.
Sat, Mar 9, 00:41
deadalnix abandoned D2665: Remove the public contructor for Amount.

I'm stupid.

Sat, Mar 9, 00:20
deadalnix committed rABC6a503184ceb2: Limit the number of orphan considered per node. (authored by deadalnix).
Limit the number of orphan considered per node.
Sat, Mar 9, 00:19
deadalnix closed D2676: Limit the number of orphan considered per node..
Sat, Mar 9, 00:19

Fri, Mar 8

deadalnix added inline comments to D2653: [CMAKE] Fix cached variable that prevents testing for flag support.
Fri, Mar 8, 21:35
deadalnix accepted D2666: [CMAKE] Use static linkage when cross compiling for windows.
Fri, Mar 8, 21:28
deadalnix added inline comments to D2664: [CMAKE] Fix bitcoind cross compilation for windows.
Fri, Mar 8, 21:26
deadalnix accepted D2674: [CMAKE] Add an option to enable/disable hardening.
Fri, Mar 8, 21:25
deadalnix accepted D2675: Partial backport of Core PR9681 to add CWallet::SignTransaction.
Fri, Mar 8, 21:24
Herald added a reviewer for D2676: Limit the number of orphan considered per node.: Restricted Project.
Fri, Mar 8, 21:21
deadalnix accepted D2672: Cleanup remaining instances of txconfirmtarget.
Fri, Mar 8, 12:40
deadalnix accepted D2671: Remove unused struct in fees.h.
Fri, Mar 8, 12:24
deadalnix committed rABC0a37e0354f3c: Add braces in netaddress.{h|cpp} (authored by deadalnix).
Add braces in netaddress.{h|cpp}
Fri, Mar 8, 12:23
deadalnix closed D2663: Add braces in netaddress.{h|cpp}.
Fri, Mar 8, 12:23

Thu, Mar 7

deadalnix accepted D2661: Tweak translation docs for regenerating translation strings in out-of-tree builds.
Thu, Mar 7, 17:50
deadalnix added inline comments to D2644: [CMAKE] Override the flags for the Debug CMake configuration.
Thu, Mar 7, 17:43
deadalnix requested changes to D2660: [CMAKE] Define FORTIFY_SOURCE=2.

This raises also the fact that D2640 was wrong as well.

Thu, Mar 7, 17:38
deadalnix requested changes to D2667: [CMAKE] Fix bitcoin-qt cross compilation for Windows.
Thu, Mar 7, 17:30
deadalnix accepted D2614: Remove unused param from txmempool::estimateFee.
Thu, Mar 7, 17:18
deadalnix added inline comments to D2653: [CMAKE] Fix cached variable that prevents testing for flag support.
Thu, Mar 7, 17:17
deadalnix added a comment to D2653: [CMAKE] Fix cached variable that prevents testing for flag support.

I'd suggest building a proper sanitation function that escape char properly as this only is susceptible to collisions.

Thu, Mar 7, 17:16
deadalnix requested changes to D2653: [CMAKE] Fix cached variable that prevents testing for flag support.

This will generate the same names for C and C++.

Thu, Mar 7, 17:15
deadalnix updated the diff for D2663: Add braces in netaddress.{h|cpp}.

Add missing braces

Thu, Mar 7, 17:07
deadalnix accepted D2662: Regenerate out-of-date translation strings.
Thu, Mar 7, 16:57
Herald added a reviewer for D2665: Remove the public contructor for Amount: Restricted Project.
Thu, Mar 7, 16:49
deadalnix requested changes to D2654: [CMAKE] Add an append_flag_to_variable facility.

Unless there is something more that append_flag_to_variable is supposed to do, this really sound to me like the kind of contraption you'd find in J2EE. Command line are space agnostics, so it really doesn't matter, and create a level of indirection for nothing.

Thu, Mar 7, 16:45
Herald added a reviewer for D2663: Add braces in netaddress.{h|cpp}: Restricted Project.
Thu, Mar 7, 14:27

Wed, Mar 6

deadalnix accepted D2655: [CMAKE] Split remove_compiler_flags into C and CXX variants.
Wed, Mar 6, 13:22

Tue, Mar 5

deadalnix requested changes to D2645: Reject headers building on invalid chains by tracking invalidity.
Tue, Mar 5, 21:53
deadalnix requested changes to D2644: [CMAKE] Override the flags for the Debug CMake configuration.
Tue, Mar 5, 21:48
deadalnix accepted D2651: [CMAKE] Remove the -DNDEBUG flag from the release build configurations.
Tue, Mar 5, 21:36
deadalnix requested changes to D2643: [CMAKE] Make RelWithDebInfo the default CMake configuration.

Please do not change the config to something that's not working as expected. RelWithDebInfo is not working properly yet.

Tue, Mar 5, 20:51
deadalnix requested changes to D2652: Changed DEFAULT_MAX_MEMPOOL_SIZE to bytes rather than megabytes..

This will fuck up the configuration of everyone. What's the benefit ?

Tue, Mar 5, 20:46
deadalnix requested changes to D2645: Reject headers building on invalid chains by tracking invalidity.
Tue, Mar 5, 16:00
deadalnix accepted D2647: Fix FreeBSD build by including utilstrencodings.h.
Tue, Mar 5, 15:45
deadalnix accepted D2648: doc: split FreeBSD build instructions out of build-unix.md.
Tue, Mar 5, 15:44
deadalnix accepted D2649: FreeBSD: Document Python 3 requirement for 'gmake check'.
Tue, Mar 5, 15:44
deadalnix accepted D2650: doc: update FreeBSD build guide for 12.0.
Tue, Mar 5, 15:43
deadalnix requested changes to D2644: [CMAKE] Override the flags for the Debug CMake configuration.
Tue, Mar 5, 15:41
deadalnix accepted D2616: Added Execute(JSONRPCRequest) overload in RPCCommandBase for wallet and help commands.
Tue, Mar 5, 15:41
deadalnix added inline comments to D2639: [CMAKE] Override the flags for the RelWithDebInfo build configuration.
Tue, Mar 5, 14:58
deadalnix requested changes to D2639: [CMAKE] Override the flags for the RelWithDebInfo build configuration.
Tue, Mar 5, 14:49
deadalnix requested changes to D2646: Changed vMatch naming in merkleblock.* to more accurately reflect its use..

So this clearly raise a lot more question than it answer. This seems to be using a soup of TxId and TxHash, yet the type used is always uint256. I suspect that it's neither because this include merkle path. This seems to make thing more confusing rather than anything else.

Tue, Mar 5, 14:48

Mon, Mar 4

deadalnix added inline comments to D2616: Added Execute(JSONRPCRequest) overload in RPCCommandBase for wallet and help commands.
Mon, Mar 4, 22:03
deadalnix requested changes to D2616: Added Execute(JSONRPCRequest) overload in RPCCommandBase for wallet and help commands.
Mon, Mar 4, 22:02
deadalnix added inline comments to D2614: Remove unused param from txmempool::estimateFee.
Mon, Mar 4, 21:59
deadalnix requested changes to D2644: [CMAKE] Override the flags for the Debug CMake configuration.
Mon, Mar 4, 21:55
deadalnix requested changes to D2639: [CMAKE] Override the flags for the RelWithDebInfo build configuration.

If I pass -DCMAKE_BUILD_TYPE=RelWithDebInfo to cmake, I already get these flags. As far as I can tell, this code does nothing more than what cmake already does.

Mon, Mar 4, 21:33
deadalnix requested changes to D2643: [CMAKE] Make RelWithDebInfo the default CMake configuration.

This generates a ton of warning, so there is likely something not correct about what RelWithDebInfo does. It's not -O2 or -g though.

Mon, Mar 4, 21:15
deadalnix accepted D2640: [CMAKE] Add PIC/PIE flags on non Windows platforms.
Mon, Mar 4, 17:40
deadalnix requested changes to D2639: [CMAKE] Override the flags for the RelWithDebInfo build configuration.

As far as I can tell, building with RelWithDebInfo as build type already use the proper flags for optimization and debug. So at least a good chunk of this patch is just redoing what cmake already does, probably adding bugs in the process.

Mon, Mar 4, 17:38
deadalnix updated the summary of D2639: [CMAKE] Override the flags for the RelWithDebInfo build configuration.
Mon, Mar 4, 17:11

Sat, Mar 2

deadalnix accepted D2638: Added LogPrintf() calls to indicate state of fCheckpointsEnabled/the -checkpoints option..
Sat, Mar 2, 15:27
deadalnix accepted D2613: Added functional test for estimatefee RPC.
Sat, Mar 2, 00:45
deadalnix accepted D2632: Fix undefined behavior in rpc/server.cpp.
Sat, Mar 2, 00:44
deadalnix accepted D2637: Fix a bug in ibd.sh where multiple args provided to the script would not be parsed correctly.
Sat, Mar 2, 00:44
deadalnix requested changes to D2614: Remove unused param from txmempool::estimateFee.

Look like removing the option from the GUI is the first step here.

Sat, Mar 2, 00:43
deadalnix accepted D2518: Add an argument to the test framework to enable great wall activation.
Sat, Mar 2, 00:42

Fri, Mar 1

deadalnix accepted D2635: Remove enable_mocktime from wallet_listreceivedby.
Fri, Mar 1, 14:04
deadalnix accepted D2636: Remove unused enable/disable_mocktime() from test_framework.py.
Fri, Mar 1, 14:01
deadalnix requested changes to D2632: Fix undefined behavior in rpc/server.cpp.
Fri, Mar 1, 13:59
deadalnix requested changes to D2630: Avoid sync_all in rpc_listtransactions.

The API surface this overs now has increase quite a bit - so the test will be more fragile, it's unclear what side effect of sync_all would cause this test to pass erroneously as this test is not testing how node synchronize, and the fact that marginally faster is not measured makes it a dubious argument at best.

Fri, Mar 1, 13:58
deadalnix requested changes to D2633: Fix unlocked_until in getwalletinfo rpc.

getwalletinfo on an encrypted wallet before and after applying the patch.

Fri, Mar 1, 13:46
deadalnix added inline comments to D2634: Fix debug build test failures.
Fri, Mar 1, 11:17
deadalnix accepted D2634: Fix debug build test failures.
Fri, Mar 1, 11:16
deadalnix added inline comments to D2614: Remove unused param from txmempool::estimateFee.
Fri, Mar 1, 00:39
deadalnix committed rABCfb8b2109af5d: [avalanche] Reject votes that fromnodes which already are in the quorum. (authored by deadalnix).
[avalanche] Reject votes that fromnodes which already are in the quorum.
Fri, Mar 1, 00:38
deadalnix closed D2586: [avalanche] Reject votes that fromnodes which already are in the quorum..
Fri, Mar 1, 00:38

Thu, Feb 28

deadalnix accepted D2008: Change signrawtransaction to signrawtransactionwithwallet in tests, add a test for legacy signrawtransaction.
Thu, Feb 28, 22:12
deadalnix requested changes to D2009: [Target v0.19] Deprecate and add test for signrawtransaction.
Thu, Feb 28, 22:10
deadalnix added a comment to D2462: Make c++14 standard the default for compilation.

Can you remove documentation mentioning support for plateform for which C++14 do not work yet ? Once this is done, I have no problem with that, to the contrary :)

Thu, Feb 28, 18:08
deadalnix requested changes to D2616: Added Execute(JSONRPCRequest) overload in RPCCommandBase for wallet and help commands.

Currently there is a grand total of zero commands that are handled by that framework. I'm not even sure this is required or not, but I'm fairly confident that it's better to have something that handle many the RPC calls rather than have something that could handle them all but handle none in practice. Beside priorities, it is also very possible that other limitation in the current design will be uncovered when actually using it, and any complication of the design will get in the way rather than help.

Thu, Feb 28, 17:39
deadalnix accepted D2627: Fix nits in comments in feature_bip68_sequence.
Thu, Feb 28, 17:21
deadalnix accepted D2629: Remove enable_mocktime in rpc_listtransactions.
Thu, Feb 28, 17:20
deadalnix accepted D2628: Leave IBD in rpc_listtransactions.

Please just backport the changes in the test and code associated instead of redoing everything next time.

Thu, Feb 28, 17:20
deadalnix added a comment to D2630: Avoid sync_all in rpc_listtransactions.

Why is that better at all to explicit a bunch of things that are not at all related to listtransactions, which presumably is what is checked ?

Thu, Feb 28, 17:19
deadalnix updated the diff for D2586: [avalanche] Reject votes that fromnodes which already are in the quorum..

And improve the test to node rely on a specific node id.

Thu, Feb 28, 16:58
deadalnix accepted D2608: Require no cs_main lock for ProcessNewBlock/ActivateBestChain.
Thu, Feb 28, 16:36
deadalnix accepted D2631: Acquire cs_main lock before cs_wallet during wallet initialization.
Thu, Feb 28, 16:36
deadalnix accepted D2421: Add Fabien to the keys for gitian signing.
Thu, Feb 28, 14:53
deadalnix accepted D2611: Add helper to wait for validation interface queue to catch up.
Thu, Feb 28, 14:52
deadalnix accepted D2610: Block ActivateBestChain to empty validationinterface queue.
Thu, Feb 28, 14:50
deadalnix accepted D2609: Add an interface to get the queue depth out of CValidationInterface.
Thu, Feb 28, 14:39