Page MenuHomePhabricator

deadalnix (Amaury SÉCHET)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
May 14 2017, 13:52 (135 w, 18 h)
Roles
Administrator

Recent Activity

Fri, Dec 13

deadalnix requested changes to D4698: [CMAKE] Allow to run boost unit tests in parallel.

That is not a good solution if you need to specify the parallelism level for the test. ninja already does job scheduling.

Fri, Dec 13, 02:52
deadalnix accepted D4694: Remove unused functions in seeder/db.h.
Fri, Dec 13, 02:49
deadalnix requested changes to D4677: checkmultisig: refactor nullfail check.
Fri, Dec 13, 02:47
deadalnix added inline comments to D4678: add nSigChecks counting to EvalScript.
Fri, Dec 13, 02:45
deadalnix requested changes to D4716: do not accept anything into mempool before UAHF has activated.

Add a test.

Fri, Dec 13, 02:40
deadalnix accepted D4701: reduce code duplication in UpdateFlags.
Fri, Dec 13, 02:38

Wed, Dec 11

deadalnix requested changes to D3898: Use best-fit strategy in Arena, now O(log(n)) instead O(n).

It overall looks, good, expect the fact that many nits should have been done prior to the back port, and not have a handful of them in.

Wed, Dec 11, 02:41
deadalnix added a comment to D4548: Fix compilation errors in support/lockedpool.cpp.

Is there a reason why the original patch is backported as this, even though it is known to be bogus, and then this?

Wed, Dec 11, 02:31
deadalnix requested changes to D4659: Replace integer literals in dnshandle() with an enum class.
Wed, Dec 11, 02:29
deadalnix requested changes to D4673: add SCHNORR_MULTISIG to mandatory flags.
Wed, Dec 11, 02:28
deadalnix requested changes to D4694: Remove unused functions in seeder/db.h.

If you are going to clean this up, actually clean it up. There are other dead functions, in fact there is a function that is declared and NEVER defined anywhere.

Wed, Dec 11, 02:18
deadalnix requested changes to D4677: checkmultisig: refactor nullfail check.
Wed, Dec 11, 01:54
deadalnix requested changes to D4678: add nSigChecks counting to EvalScript.
Wed, Dec 11, 01:48
deadalnix accepted D4679: add SCRIPT_VERIFY_MINIMALDATA to mandatory flags.

Could you do the same for SCRIPT_ENABLE_SCHNORR_MULTISIG and SCRIPT_VERIFY_CHECKDATASIG_SIGOPS, please?

Wed, Dec 11, 01:28
deadalnix accepted D4682: [CMAKE] Silent the Qt translation files generation.

Thanks!

Wed, Dec 11, 01:27
deadalnix requested changes to D4684: Release cs_main during RewindBlockIndex operation.
Wed, Dec 11, 01:26
deadalnix accepted D4683: Merge the disconnection and erasing loops in RewindBlockIndex.

Some small changes, but LGTM

Wed, Dec 11, 01:20
deadalnix requested changes to D4681: Fix enum NumConnections shadowing warning.
Wed, Dec 11, 01:17
deadalnix requested changes to D4669: Move erasure of non-active blocks to a separate loop in RewindBlockIndex.
Wed, Dec 11, 01:15
deadalnix accepted D4653: Abstract EraseBlockData out of RewindBlockIndex.

One small change, but otherwise, LGTM

Wed, Dec 11, 01:11
deadalnix committed rABC405c4da10609: allow cuckoocache to function as a map (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).
allow cuckoocache to function as a map
Wed, Dec 11, 01:10
deadalnix closed D4621: allow cuckoocache to function as a map.
Wed, Dec 11, 01:10
deadalnix added inline comments to D4621: allow cuckoocache to function as a map.
Wed, Dec 11, 01:07
deadalnix requested changes to D4680: Fix -Wcast-align in crypto_hash.cpp.
Wed, Dec 11, 01:04

Tue, Dec 10

deadalnix requested changes to D4670: Fix -Wself-assign-overloaded in uint256_tests.

Then the test doesn't test what it is supposed to be testing.

Tue, Dec 10, 17:58
deadalnix accepted D4671: fix incomplete txvalidationcache_tests.
Tue, Dec 10, 17:57
deadalnix updated the diff for D4621: allow cuckoocache to function as a map.

Address comments

Tue, Dec 10, 14:21
deadalnix added inline comments to D4621: allow cuckoocache to function as a map.
Tue, Dec 10, 14:00
deadalnix added a comment to D4653: Abstract EraseBlockData out of RewindBlockIndex.

That looks better, let me do a pass over this tomorow.

Tue, Dec 10, 03:50
deadalnix updated the diff for D4621: allow cuckoocache to function as a map.

Address comments, except making the constructor of the test map element explicit, as it makes the test way more complex and the upside is not very clear.

Tue, Dec 10, 03:49
deadalnix requested changes to D4672: document MANDATORY_SCRIPT_VERIFY_FLAGS accurately.
Tue, Dec 10, 03:48
deadalnix accepted D4667: Fix cuckoocache_tests -Wcast-align warnings.
Tue, Dec 10, 03:45
deadalnix committed rABCbddacbe760f1: [cuckoocache] Use getKey and KeyType for contains (authored by deadalnix).
[cuckoocache] Use getKey and KeyType for contains
Tue, Dec 10, 03:43
deadalnix closed D4643: [cuckoocache] Use getKey and KeyType for contains.
Tue, Dec 10, 03:43
deadalnix commandeered D4621: allow cuckoocache to function as a map.
Tue, Dec 10, 03:40
deadalnix requested changes to D4659: Replace integer literals in dnshandle() with an enum class.
Tue, Dec 10, 03:37

Mon, Dec 9

deadalnix requested changes to D3898: Use best-fit strategy in Arena, now O(log(n)) instead O(n).

PR16161 was merged.

Mon, Dec 9, 00:45
deadalnix accepted D4628: fuzz: Move deserialize tests to test/fuzz/deserialize.cpp.
Mon, Dec 9, 00:42
deadalnix added inline comments to D4629: fuzz: Script validation flags.
Mon, Dec 9, 00:40
deadalnix accepted D4663: Merge #13603: bitcoin-tx: Stricter check for valid integers.
Mon, Dec 9, 00:28

Sun, Dec 8

deadalnix added a comment to D4665: partial revert of tx decode sanity check backport.

Adding tests would be good.

Sun, Dec 8, 15:42
deadalnix accepted D4665: partial revert of tx decode sanity check backport.
Sun, Dec 8, 15:42
deadalnix requested changes to D4659: Replace integer literals in dnshandle() with an enum class.
Sun, Dec 8, 01:57

Fri, Dec 6

deadalnix changed the visibility for D3880: Add wallet acceptance / mempool acceptance tests for non-standard variants.
Fri, Dec 6, 18:38
deadalnix requested changes to D4627: qa: Add test/fuzz/test_runner.py.
Fri, Dec 6, 11:54
deadalnix requested changes to D4653: Abstract EraseBlockData out of RewindBlockIndex.
Fri, Dec 6, 11:41
deadalnix accepted D4615: test: Build fuzz targets into seperate executables.
Fri, Dec 6, 11:15
deadalnix accepted D4630: test: Add missing LIBBITCOIN_ZMQ to test_test_bitcoin_LDADD.
Fri, Dec 6, 11:08
deadalnix requested changes to D4655: [Backport] Never bind INADDR_ANY by default, and warn when doing so explicitly.

Back on your queue. It looks like this broke the rpc_bind test.

Fri, Dec 6, 11:08
deadalnix requested changes to D4642: Cleanup graviton activation tests.

It would be preferable to remove the tests along side the code that they do test. Doing this as this simply reduce test coverage.

Fri, Dec 6, 11:06

Thu, Dec 5

deadalnix requested changes to D4637: Remove gotos in seeder/dns.cpp.
Thu, Dec 5, 21:59
deadalnix added a comment to D4637: Remove gotos in seeder/dns.cpp.

Using goto to not litter otherwise good code with error handling is a fairly common practice. Surely, if this makes this code bad in some way, the specifics can be pointed at rather than blanket statement about goto being harmful.

Thu, Dec 5, 21:57
deadalnix updated the diff for D4643: [cuckoocache] Use getKey and KeyType for contains.

Remove now unecessary matchKey

Thu, Dec 5, 17:45
deadalnix committed rABC2da49591e709: Remove check-source-control-tools from check and check-all targets (authored by deadalnix).
Remove check-source-control-tools from check and check-all targets
Thu, Dec 5, 13:20
deadalnix closed D4644: Remove check-source-control-tools from check and check-all targets.
Thu, Dec 5, 13:19
deadalnix created D4644: Remove check-source-control-tools from check and check-all targets.
Thu, Dec 5, 13:17
deadalnix created D4643: [cuckoocache] Use getKey and KeyType for contains.
Thu, Dec 5, 13:13
deadalnix committed rABC90d243144c49: [cuckoocache] Use matchKey instead of the == operator. (authored by deadalnix).
[cuckoocache] Use matchKey instead of the == operator.
Thu, Dec 5, 13:09
deadalnix closed D4641: [cuckoocache] Use matchKey instead of the == operator..
Thu, Dec 5, 13:09

Wed, Dec 4

deadalnix accepted D4638: Fix a bug where test-autopatch would fail when the local master branch does not have the same HEAD as origin/master.

While this is a pretty bad idea to have said config, it is an even worse idea to have a unit test depends on user config, not testing the software, yet ran as part as its test suite by default, running a buggy script.

Wed, Dec 4, 23:29
deadalnix accepted D4635: Fix a bug where test-autopatch would fail in an env where no global git config is set.

As it turns out, having test that depends on the user's global config, not testing the actual software but running by default on the software test suite.

Wed, Dec 4, 23:25
deadalnix accepted D4639: Merge #13566: Fix get balance.
Wed, Dec 4, 23:19
deadalnix requested changes to D4630: test: Add missing LIBBITCOIN_ZMQ to test_test_bitcoin_LDADD.

Looks like you broke the build.

Wed, Dec 4, 23:13
deadalnix created D4641: [cuckoocache] Use matchKey instead of the == operator..
Wed, Dec 4, 22:39
deadalnix added a comment to D4640: [Backport] Never bind INADDR_ANY by default, and warn when doing so explicitly.

Please mention PR1243653 (with no # in the middle) in the description so that it can be searched for.

Wed, Dec 4, 22:32
deadalnix committed rABC5cf580f0f756: Various nits in cuckoocache_tests.cpp (authored by deadalnix).
Various nits in cuckoocache_tests.cpp
Wed, Dec 4, 22:24
deadalnix closed D4632: Various nits in cuckoocache_tests.cpp.
Wed, Dec 4, 22:24
deadalnix committed rABCeecfa67b2223: doc: Doxygen-friendly CuckooCache comments (authored by Jon Layton <me@jonl.io>).
doc: Doxygen-friendly CuckooCache comments
Wed, Dec 4, 22:20
deadalnix closed D4631: doc: Doxygen-friendly CuckooCache comments.
Wed, Dec 4, 22:20
deadalnix created D4632: Various nits in cuckoocache_tests.cpp.
Wed, Dec 4, 18:07
deadalnix created D4631: doc: Doxygen-friendly CuckooCache comments.
Wed, Dec 4, 17:59
deadalnix accepted D4300: Integrate gArgs and chainparams into the Seeder.
Wed, Dec 4, 17:09
deadalnix accepted D4624: refactoring: add a method for determining if a block is pruned or not.
Wed, Dec 4, 02:25
deadalnix requested changes to D4625: Cleanup test-autopatch output during `ninja check`.

That whole thing depends on a gazillion environments variables, internet connectivity, and whatever else, and doesn't check at all that bitcoin-abc is working. I really don't see why someone who want to checkout the ABC sources and run the tests to make sure it works have to go through the bullshit of installing arc, setting up an auth token and alike. That makes no sense whatsoever. The software is supposed to get better *FOR USERS* over time. What does it do in the middle of ninja check? How come, when the output of ninja check is polluted, nobody stops one second to ask themsleves "Wait, why is that thing in the output to begin with? Does it need to be?" but instead go on changing all the output formatting so that the main problem remains, but is less visible?

Wed, Dec 4, 02:21
deadalnix requested changes to D4619: Merge #14451: Allow building GUI without BIP70 support.

Do not deprecate BIP70.

Wed, Dec 4, 01:47
deadalnix accepted D4626: Rename contrib/arcanist to source-control-tools.
Wed, Dec 4, 01:45

Tue, Dec 3

deadalnix accepted D4623: Various nits in Seeder files.

likestamp

Tue, Dec 3, 21:34
deadalnix accepted D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.
Tue, Dec 3, 17:50
deadalnix requested changes to D4621: allow cuckoocache to function as a map.

You probably want to investigate why the build failed.

Tue, Dec 3, 17:41
deadalnix accepted D4622: Fix -Wunused-const-variable in descriptor_tests.cpp.
Tue, Dec 3, 13:43

Mon, Dec 2

deadalnix accepted D3694: Update the github issue template to include disclosure policy.
Mon, Dec 2, 23:44
deadalnix requested changes to D4300: Integrate gArgs and chainparams into the Seeder.
Mon, Dec 2, 23:42
deadalnix accepted D4618: fix undefined behaviour in seeder (select() aliasing).
Mon, Dec 2, 23:32
deadalnix requested changes to D4617: add sigChecks counting and a flag that restricts it per-input.

The general direction is good, but there are a few problem with this patch.

Mon, Dec 2, 22:01
deadalnix accepted D4612: tests: Use MakeUnique to construct objects owned by unique_ptrs.
Mon, Dec 2, 17:26
deadalnix accepted D4614: docs: Spelling error fix on fuzzing.md.
Mon, Dec 2, 17:25
deadalnix abandoned D4604: [univalue] Define dependency properly for generate_univalue_escapes_h.
Mon, Dec 2, 14:56
deadalnix committed rABC14d47c56608e: Make TxIndex::FindTx use BlockHash (authored by deadalnix).
Make TxIndex::FindTx use BlockHash
Mon, Dec 2, 14:54
deadalnix closed D4610: Make TxIndex::FindTx use BlockHash.
Mon, Dec 2, 14:54
deadalnix committed rABCfbfbc19b56f4: Update GetTransaction's parameters (authored by deadalnix).
Update GetTransaction's parameters
Mon, Dec 2, 14:51
deadalnix closed D4609: Update GetTransaction's parameters.
Mon, Dec 2, 14:51
deadalnix committed rABCe37a511fd797: Update mempool and compact block logic to use TxHash (authored by deadalnix).
Update mempool and compact block logic to use TxHash
Mon, Dec 2, 14:47
deadalnix closed D4600: Update mempool and compact block logic to use TxHash.
Mon, Dec 2, 14:47
deadalnix committed rABCe635d1c6c5cd: tx pool: Use class methods to hide raw map iterator impl details (authored by MarcoFalke <falke.marco@gmail.com>).
tx pool: Use class methods to hide raw map iterator impl details
Mon, Dec 2, 14:41
deadalnix closed D4601: tx pool: Use class methods to hide raw map iterator impl details.
Mon, Dec 2, 14:41
deadalnix retitled D4600: Update mempool and compact block logic to use TxHash from Update mempool and compact block logic to use TxHash . to Update mempool and compact block logic to use TxHash.
Mon, Dec 2, 14:39
deadalnix added inline comments to D4613: build: Allow to configure --with-sanitizers=fuzzer.
Mon, Dec 2, 14:37
deadalnix committed rABC04a26c5bcd54: Update mempool's mapDelta to use TxId (authored by deadalnix).
Update mempool's mapDelta to use TxId
Mon, Dec 2, 14:33
deadalnix closed D4599: Update mempool's mapDelta to use TxId.
Mon, Dec 2, 14:33
deadalnix committed rABC8a300d51d9c3: Update mempool's mapTx to index from TxId. (authored by deadalnix).
Update mempool's mapTx to index from TxId.
Mon, Dec 2, 14:28