Page MenuHomePhabricator

deadalnix (Amaury SÉCHET)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
May 14 2017, 13:52 (140 w, 3 d)
Roles
Administrator

Recent Activity

Today

deadalnix accepted D4940: add a flag that (if unset) zeroes sigchecks reported by VerifyScript.
Wed, Jan 22, 02:05

Yesterday

deadalnix updated the diff for D5030: Make WINDOW_G configurable.

Address comments

Tue, Jan 21, 21:37
deadalnix committed rABCd3cdd0f3b3f6: Use trivial algorithm in ecmult_multi if scratch space is small (authored by Jonas Nick <jonasd.nick@gmail.com>).
Use trivial algorithm in ecmult_multi if scratch space is small
Tue, Jan 21, 21:33
deadalnix closed D5032: Use trivial algorithm in ecmult_multi if scratch space is small.
Tue, Jan 21, 21:33
deadalnix added inline comments to D5030: Make WINDOW_G configurable.
Tue, Jan 21, 21:25
deadalnix accepted D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.
Tue, Jan 21, 21:21
deadalnix added inline comments to D5031: Enable context creation in preallocated memory.
Tue, Jan 21, 17:02
deadalnix added inline comments to D5031: Enable context creation in preallocated memory.
Tue, Jan 21, 17:01
deadalnix accepted D5037: [CMAKE] Attach the linker flags to target properties.
Tue, Jan 21, 14:00
deadalnix accepted D5035: [CMAKE] Bump minimum version to 3.13.
Tue, Jan 21, 13:59
deadalnix accepted D5034: [CMAKE] Fix the native build when the target is in the current build dir.
Tue, Jan 21, 13:59
deadalnix accepted D5033: [SECP256K1] Use the cmake version from Kitware PPA on Travis.
Tue, Jan 21, 13:57

Mon, Jan 20

deadalnix created D5032: Use trivial algorithm in ecmult_multi if scratch space is small.
Mon, Jan 20, 23:43
deadalnix created D5031: Enable context creation in preallocated memory.
Mon, Jan 20, 23:39
deadalnix created D5030: Make WINDOW_G configurable.
Mon, Jan 20, 23:27
deadalnix requested changes to D4943: Add an option to set the functional test suite name.
Mon, Jan 20, 22:53
deadalnix accepted D5019: CreateNewBlock: insert entries into block slightly earlier so that correct size is logged.
Mon, Jan 20, 22:41
deadalnix requested changes to D4940: add a flag that (if unset) zeroes sigchecks reported by VerifyScript.

It would reverse the metric setting logic as to avoid a double negation. Everything else is good to go.

Mon, Jan 20, 18:56
deadalnix requested changes to D4418: Add unit tests for parse_name().
Mon, Jan 20, 18:50
deadalnix committed rABC25dd8a720622: [cmake] Refactor native build cmake generation (authored by deadalnix).
[cmake] Refactor native build cmake generation
Mon, Jan 20, 15:09
deadalnix closed D5026: [cmake] Refactor native build cmake generation.
Mon, Jan 20, 15:09
deadalnix updated the diff for D5026: [cmake] Refactor native build cmake generation.

Update as per comments

Mon, Jan 20, 14:37
deadalnix added inline comments to D5026: [cmake] Refactor native build cmake generation.
Mon, Jan 20, 14:35
deadalnix committed rABC3ed9038f912b: [cmake] Do not generate git_ignored_files.txt (authored by deadalnix).
[cmake] Do not generate git_ignored_files.txt
Mon, Jan 20, 14:26
deadalnix closed D5021: [cmake] Do not generate git_ignored_files.txt.
Mon, Jan 20, 14:26
deadalnix requested changes to D5028: [WIP] track per-transaction SigChecks using a TransactionMetricsAccumulator.
Mon, Jan 20, 14:16
deadalnix added a comment to D5028: [WIP] track per-transaction SigChecks using a TransactionMetricsAccumulator.

The general approach look good. Obviously, Without changing ScriptExecutionMetrics, it's hard to ensure your invariants hold, so you may want to unpod that guy as well.

Mon, Jan 20, 14:15

Sun, Jan 19

deadalnix accepted D5025: Bump version to 0.20.12.
Sun, Jan 19, 22:09
deadalnix created D5026: [cmake] Refactor native build cmake generation.
Sun, Jan 19, 22:08
deadalnix requested changes to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

A few minor improvement, but it's getting there. You should consider starting to work on activation logic and tests.

Sun, Jan 19, 17:31
deadalnix accepted D5022: CreateNewBlock: small tweaks.
Sun, Jan 19, 16:53
deadalnix requested changes to D4917: more optimal virtualsize accounting with increments.
Sun, Jan 19, 16:51
deadalnix requested changes to D4903: Use virtualsize for mining/mempool priority.

Requesting change, but most of it are actually questions. The only thing I'm really suspicious of is the block template thing.

Sun, Jan 19, 16:42
deadalnix accepted D5004: Merge #14146: wallet: Remove trailing separators from -walletdir arg.
Sun, Jan 19, 15:07
deadalnix accepted D5017: [abc-wallet-standardness] do test the signing error code.
Sun, Jan 19, 14:27
deadalnix accepted D5016: fix a test in anticipation of SCRIPT_VERIFY_INPUT_SIGCHECKS activation.
Sun, Jan 19, 14:22
deadalnix accepted D5009: Merge #14105: util: Report parse errors in configuration file.
Sun, Jan 19, 14:21
deadalnix accepted D5011: Merge #14413: tests: Allow closed rpc handler in assert_start_raises_init_error.
Sun, Jan 19, 14:19
deadalnix accepted D5012: Merge #14494: Error if # is used in rpcpassword in conf.
Sun, Jan 19, 14:19
deadalnix added inline comments to D4941: track ScriptExecutionMetrics in CheckInputs.
Sun, Jan 19, 14:18
deadalnix requested changes to D4941: track ScriptExecutionMetrics in CheckInputs.
Sun, Jan 19, 14:17
deadalnix requested changes to D5019: CreateNewBlock: insert entries into block slightly earlier so that correct size is logged.
Sun, Jan 19, 14:04
deadalnix accepted D5018: add input sigchecks limit to STANDARD_SCRIPT_VERIFY_FLAGS (but not mempool flags).
Sun, Jan 19, 14:02
deadalnix added inline comments to D4834: add sigChecks value to script cache.
Sun, Jan 19, 14:02
deadalnix accepted D5023: [CMAKE] Fix static linkage when building for Windows.
Sun, Jan 19, 13:58
deadalnix accepted D5024: Fix type mismatch for GetVirtualSizeWith<Descendants|Ancerstors>.
Sun, Jan 19, 13:58
deadalnix requested changes to D5019: CreateNewBlock: insert entries into block slightly earlier so that correct size is logged.

Requesting changes, but it's more like questions.

Sun, Jan 19, 03:51

Sat, Jan 18

deadalnix requested changes to D4834: add sigChecks value to script cache.

From what I gather, it is fairly obvious that you actually don't want a but are trying to make things work as a pod. The problem when you distribute responsibilities is that you always end up with something inconsistent down the road or a huge pile of spaghetti because various pieces of code needs to be kept in sync.

Sat, Jan 18, 23:51
deadalnix accepted D5010: Merge #9963: util: Properly handle errors during log message formatting.
Sat, Jan 18, 23:39
deadalnix accepted D5015: simplify ATMP standard flag computation [2/2] - move computation to another function.
Sat, Jan 18, 23:33
deadalnix accepted D5014: simplify ATMP standard flag computation [1/2] - remove CHECKDATASIG_SIGOPS.
Sat, Jan 18, 23:30
deadalnix created D5021: [cmake] Do not generate git_ignored_files.txt.
Sat, Jan 18, 23:22
deadalnix committed rABCfaf086373ffc: [cmake] Only set the native build marker once (authored by deadalnix).
[cmake] Only set the native build marker once
Sat, Jan 18, 18:07
deadalnix closed D5020: [cmake] Only set the native build marker once.
Sat, Jan 18, 18:07
deadalnix created D5020: [cmake] Only set the native build marker once.
Sat, Jan 18, 17:48

Fri, Jan 17

deadalnix accepted D5005: Merge #13862: utils: drop boost::interprocess::file_lock.
Fri, Jan 17, 22:10
deadalnix requested changes to D5004: Merge #14146: wallet: Remove trailing separators from -walletdir arg.
Fri, Jan 17, 22:09
deadalnix requested changes to D5005: Merge #13862: utils: drop boost::interprocess::file_lock.
Fri, Jan 17, 21:51
deadalnix accepted D5007: [CMAKE] Fix getentropy detection on OSX.
Fri, Jan 17, 21:40
deadalnix committed rABC634c2286f402: [cmake] Always run native build standalone (authored by deadalnix).
[cmake] Always run native build standalone
Fri, Jan 17, 17:41
deadalnix closed D5001: [cmake] Always run native build standalone.
Fri, Jan 17, 17:41
deadalnix accepted D4968: Update chainparams.
Fri, Jan 17, 17:38
deadalnix accepted D5002: [CMAKE] Get rid of `add_compiler_flags_to_var`.
Fri, Jan 17, 16:44
deadalnix updated the diff for D5001: [cmake] Always run native build standalone.

Rerun build

Fri, Jan 17, 16:22
deadalnix committed rABC9d9fd76f3b0f: Note intention of timing sidechannel freeness. (authored by Gregory Maxwell <greg@xiph.org>).
Note intention of timing sidechannel freeness.
Fri, Jan 17, 16:18
deadalnix closed D5000: Note intention of timing sidechannel freeness..
Fri, Jan 17, 16:18
deadalnix committed rABC308c4b941203: configure: Use CFLAGS_FOR_BUILD when checking native compiler (authored by Tim Ruffing <crypto@timruffing.de>).
configure: Use CFLAGS_FOR_BUILD when checking native compiler
Fri, Jan 17, 16:16
deadalnix closed D4997: configure: Use CFLAGS_FOR_BUILD when checking native compiler.
Fri, Jan 17, 16:16
deadalnix committed rABCbea9546d907e: Respect LDFLAGS and #undef STATIC_PRECOMPUTATION if using basic config (authored by DesWurstes <DesWurstes@users.noreply.github.com>).
Respect LDFLAGS and #undef STATIC_PRECOMPUTATION if using basic config
Fri, Jan 17, 16:14
deadalnix closed D4996: Respect LDFLAGS and #undef STATIC_PRECOMPUTATION if using basic config.
Fri, Jan 17, 16:14
deadalnix requested changes to D5002: [CMAKE] Get rid of `add_compiler_flags_to_var`.
Fri, Jan 17, 16:12
deadalnix committed rABCed9587d98918: Make sure we're not using an uninitialized variable in secp256k1_wnaf_const(...) (authored by practicalswift <practicalswift@users.noreply.github.com>).
Make sure we're not using an uninitialized variable in secp256k1_wnaf_const(...)
Fri, Jan 17, 16:12
deadalnix closed D4995: Make sure we're not using an uninitialized variable in secp256k1_wnaf_const(...).
Fri, Jan 17, 16:12
deadalnix committed rABC242e9d4bc7b5: Pass scalar by reference in secp256k1_wnaf_const() (authored by Tim Ruffing <crypto@timruffing.de>).
Pass scalar by reference in secp256k1_wnaf_const()
Fri, Jan 17, 16:10
deadalnix closed D4994: Pass scalar by reference in secp256k1_wnaf_const().
Fri, Jan 17, 16:09
deadalnix closed D4998: Avoid implementation-defined and undefined behavior when dealing with sizes.
Fri, Jan 17, 16:08
deadalnix committed rABC56260aeec5fc: Avoid implementation-defined and undefined behavior when dealing with sizes (authored by Tim Ruffing <crypto@timruffing.de>).
Avoid implementation-defined and undefined behavior when dealing with sizes
Fri, Jan 17, 16:08
deadalnix committed rABCfd526a1dc259: Guard memcmp in tests against mixed size inputs. (authored by Gregory Maxwell <greg@xiph.org>).
Guard memcmp in tests against mixed size inputs.
Fri, Jan 17, 15:48
deadalnix closed D4999: Guard memcmp in tests against mixed size inputs..
Fri, Jan 17, 15:48
deadalnix committed rABCa071308f1954: Use __GNUC_PREREQ for detecting __builtin_expect (authored by Tim Ruffing <crypto@timruffing.de>).
Use __GNUC_PREREQ for detecting __builtin_expect
Fri, Jan 17, 15:45
deadalnix closed D4973: Use __GNUC_PREREQ for detecting __builtin_expect.
Fri, Jan 17, 15:45
deadalnix updated the diff for D5001: [cmake] Always run native build standalone.

Tweaks

Fri, Jan 17, 15:42
deadalnix created D5001: [cmake] Always run native build standalone.
Fri, Jan 17, 15:39
deadalnix accepted D4961: [CMAKE] Add a check_linker_flag function.
Fri, Jan 17, 15:07
deadalnix committed rABCbaaa4fa3e1d8: Add $(COMMON_LIB) to exhaustive tests to fix ARM asm build (authored by Gregory Maxwell <greg@xiph.org>).
Add $(COMMON_LIB) to exhaustive tests to fix ARM asm build
Fri, Jan 17, 14:50
deadalnix closed D4988: Add $(COMMON_LIB) to exhaustive tests to fix ARM asm build.
Fri, Jan 17, 14:50
deadalnix created D5000: Note intention of timing sidechannel freeness..
Fri, Jan 17, 14:29
deadalnix created D4999: Guard memcmp in tests against mixed size inputs..
Fri, Jan 17, 14:28
deadalnix created D4998: Avoid implementation-defined and undefined behavior when dealing with sizes.
Fri, Jan 17, 14:26
deadalnix closed D4989: Switch x86_64 asm to use "i" instead of "n" for immediate values..
Fri, Jan 17, 14:19
deadalnix committed rABCa7b56de6fc3c: Switch x86_64 asm to use "i" instead of "n" for immediate values. (authored by Gregory Maxwell <greg@xiph.org>).
Switch x86_64 asm to use "i" instead of "n" for immediate values.
Fri, Jan 17, 14:19
deadalnix committed rABC850100d894fa: Allow field_10x26_arm.s to compile for ARMv7 architecture (authored by Roman Zeyde <me@romanzey.de>).
Allow field_10x26_arm.s to compile for ARMv7 architecture
Fri, Jan 17, 14:17
deadalnix closed D4992: Allow field_10x26_arm.s to compile for ARMv7 architecture.
Fri, Jan 17, 14:16
deadalnix committed rABC3edf3fa19742: Clear a copied secret key after negation (authored by Seonpyo Kim <spkim@kodebox.io>).
Clear a copied secret key after negation
Fri, Jan 17, 14:13
deadalnix closed D4993: Clear a copied secret key after negation.
Fri, Jan 17, 14:13
deadalnix committed rABCd3afd5bacd84: Use size_t shifts when computing a size_t (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Use size_t shifts when computing a size_t
Fri, Jan 17, 14:11
deadalnix closed D4991: Use size_t shifts when computing a size_t.
Fri, Jan 17, 14:11
deadalnix committed rABCfd66a562632e: Fix integer overflow in ecmult_multi_var when n is large (authored by Jonas Nick <jonasd.nick@gmail.com>).
Fix integer overflow in ecmult_multi_var when n is large
Fri, Jan 17, 14:10
deadalnix closed D4987: Fix integer overflow in ecmult_multi_var when n is large.
Fri, Jan 17, 14:09
deadalnix committed rABC69b03d6352c8: Add trivial ecmult_multi algorithm which does not require a scratch space (authored by Jonas Nick <jonasd.nick@gmail.com>).
Add trivial ecmult_multi algorithm which does not require a scratch space
Fri, Jan 17, 14:08