Page MenuHomePhabricator
People deadalnix

deadalnix (Amaury SÉCHET)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
May 14 2017, 13:52 (164 w, 3 d)
Roles
Administrator

Recent Activity
View All

Today

deadalnix accepted D6864: Update -banscore and -bantime help text.
Thu, Jul 9, 01:03
deadalnix accepted D6865: Remove confusing statement from setban RPC help text.
Thu, Jul 9, 01:02
deadalnix requested review of D6866: Report most cppcheck errors.
Thu, Jul 9, 01:02
deadalnix requested changes to D6860: Merge #15921: validation: Tidy up ValidationState interface.

Mixing automate changes with manual ones makes this basically impossible to review. You need to split this up.

Thu, Jul 9, 00:46
deadalnix requested review of D6863: arc lint everything.
Thu, Jul 9, 00:44

Yesterday

deadalnix requested changes to D6861: [refactor] refactor FinalizeBlockAndInvalidate.
Wed, Jul 8, 23:20
deadalnix committed rABC9b4c6570a9a1: [avalanche] Remove Peer::score (authored by deadalnix).
[avalanche] Remove Peer::score
Wed, Jul 8, 20:56
deadalnix closed D6857: [avalanche] Remove Peer::score.
Wed, Jul 8, 20:56
deadalnix committed rABC16c80a3b741e: [avalanche] Remove ability to rescore a peer (authored by deadalnix).
[avalanche] Remove ability to rescore a peer
Wed, Jul 8, 20:54
deadalnix closed D6856: [avalanche] Remove ability to rescore a peer.
Wed, Jul 8, 20:54
deadalnix committed rABC7491f1030768: [avalanche] Use Proof in Processor (authored by deadalnix).
[avalanche] Use Proof in Processor
Wed, Jul 8, 18:27
deadalnix closed D6858: [avalanche] Use Proof in Processor.
Wed, Jul 8, 18:27
deadalnix requested review of D6858: [avalanche] Use Proof in Processor.
Wed, Jul 8, 17:40
deadalnix requested review of D6857: [avalanche] Remove Peer::score.
Wed, Jul 8, 16:11
deadalnix requested review of D6856: [avalanche] Remove ability to rescore a peer.
Wed, Jul 8, 16:08
deadalnix committed rABC43b890a36ae9: [avalanche] Kill PeerManager::addPeer (authored by deadalnix).
[avalanche] Kill PeerManager::addPeer
Wed, Jul 8, 14:55
deadalnix closed D6851: [avalanche] Kill PeerManager::addPeer.
Wed, Jul 8, 14:55
deadalnix committed rABC216aa09cb42b: [avalanche] Remove PeerManager::addNodeToPeer (authored by deadalnix).
[avalanche] Remove PeerManager::addNodeToPeer
Wed, Jul 8, 14:54
deadalnix closed D6850: [avalanche] Remove PeerManager::addNodeToPeer.
Wed, Jul 8, 14:54
deadalnix retitled D6851: [avalanche] Kill PeerManager::addPeer from Kill PeerManager::addPeer to [avalanche] Kill PeerManager::addPeer.
Wed, Jul 8, 14:54
deadalnix updated the diff for D6850: [avalanche] Remove PeerManager::addNodeToPeer.

Fix Processor::addPeer

Wed, Jul 8, 14:53
deadalnix committed rABC6fc04cf5f151: [avalanche] Attach Proof to each Peer (authored by deadalnix).
[avalanche] Attach Proof to each Peer
Wed, Jul 8, 14:47
deadalnix closed D6848: [avalanche] Attach Proof to each Peer.
Wed, Jul 8, 14:47
deadalnix committed rABC1e7137e1a1c8: [avalanche] Use ProofId instead of PeerId (authored by deadalnix).
[avalanche] Use ProofId instead of PeerId
Wed, Jul 8, 14:46
deadalnix closed D6847: [avalanche] Use ProofId instead of PeerId.
Wed, Jul 8, 14:45
deadalnix accepted D6853: [SECP256K1] Fix the Travis build wrong targets names.
Wed, Jul 8, 14:44
deadalnix committed rABC0a5b569ba45b: Put CConnmanTest in an anonymous namespace (authored by deadalnix).
Put CConnmanTest in an anonymous namespace
Wed, Jul 8, 14:44
deadalnix closed D6838: Put CConnmanTest in an anonymous namespace.
Wed, Jul 8, 14:44
deadalnix accepted D6835: [backport#19188] test: Avoid overwriting the NodeContext member of the testing setup [-Wshadow-field].
Wed, Jul 8, 00:54
deadalnix accepted D6846: [backport#15245] remove deprecated mentions of signrawtransaction from fundraw help.
Wed, Jul 8, 00:22
deadalnix accepted D6849: [backport#13310] Report progress in ReplayBlocks while rolling forward.
Wed, Jul 8, 00:21
deadalnix committed rABCa90587eb13c2: [avalanche] Rename getSuitableNodeToQuery => selectNode (authored by deadalnix).
[avalanche] Rename getSuitableNodeToQuery => selectNode
Wed, Jul 8, 00:20
deadalnix closed D6845: [avalanche] Rename getSuitableNodeToQuery => selectNode.
Wed, Jul 8, 00:20
deadalnix requested review of D6851: [avalanche] Kill PeerManager::addPeer.
Wed, Jul 8, 00:20
deadalnix requested review of D6850: [avalanche] Remove PeerManager::addNodeToPeer.
Wed, Jul 8, 00:16

Tue, Jul 7

deadalnix requested review of D6848: [avalanche] Attach Proof to each Peer.
Tue, Jul 7, 23:57
deadalnix retitled D6847: [avalanche] Use ProofId instead of PeerId from [avalanche] Use proofs instead of PeerId to [avalanche] Use ProofId instead of PeerId.
Tue, Jul 7, 23:51
deadalnix requested review of D6847: [avalanche] Use ProofId instead of PeerId.
Tue, Jul 7, 23:51
deadalnix requested review of D6845: [avalanche] Rename getSuitableNodeToQuery => selectNode.
Tue, Jul 7, 23:31
deadalnix requested changes to D6539: [backport#14193] validation: Add missing mempool locks.

There is a missing lock when invalidating a block - and presumably parking too.

Tue, Jul 7, 22:24
deadalnix committed rABCb69dba069d23: [avalanche] More namespace instead of smurfnaming (authored by deadalnix).
[avalanche] More namespace instead of smurfnaming
Tue, Jul 7, 16:31
deadalnix closed D6842: [avalanche] More namespace instead of smurfnaming.
Tue, Jul 7, 16:31
deadalnix requested review of D6842: [avalanche] More namespace instead of smurfnaming.
Tue, Jul 7, 16:07
deadalnix updated the diff for D6838: Put CConnmanTest in an anonymous namespace.

rebase

Tue, Jul 7, 15:45
deadalnix committed rABC71ec74fa7535: [avalanche] Use namespace instead of smurfnaming (authored by deadalnix).
[avalanche] Use namespace instead of smurfnaming
Tue, Jul 7, 15:43
deadalnix closed D6837: [avalanche] Use namespace instead of smurfnaming.
Tue, Jul 7, 15:43
deadalnix committed rABC6f94e9fc1bcc: Factor out SaltedUint256Hasher (authored by deadalnix).
Factor out SaltedUint256Hasher
Tue, Jul 7, 15:42
deadalnix closed D6840: Factor out SaltedUint256Hasher.
Tue, Jul 7, 15:42
deadalnix requested review of D6840: Factor out SaltedUint256Hasher.
Tue, Jul 7, 12:54
deadalnix requested review of D6838: Put CConnmanTest in an anonymous namespace.
Tue, Jul 7, 10:03
deadalnix requested review of D6837: [avalanche] Use namespace instead of smurfnaming.
Tue, Jul 7, 09:53
deadalnix committed rABCcef7c8a30135: [avalanche] Use PerrManager instead of ad hoc logic in AvalancheProcessor (authored by deadalnix).
[avalanche] Use PerrManager instead of ad hoc logic in AvalancheProcessor
Tue, Jul 7, 08:53
deadalnix closed D6834: [avalanche] Use PerrManager instead of ad hoc logic in AvalancheProcessor.
Tue, Jul 7, 08:49

Mon, Jul 6

deadalnix requested review of D6834: [avalanche] Use PerrManager instead of ad hoc logic in AvalancheProcessor.
Mon, Jul 6, 21:51
deadalnix committed rABC7d1e29374d16: [avalanche] Factor AvalancheNode from PeerManager (authored by deadalnix).
[avalanche] Factor AvalancheNode from PeerManager
Mon, Jul 6, 21:49
deadalnix closed D6831: [avalanche] Factor AvalancheNode from PeerManager.
Mon, Jul 6, 21:49
deadalnix committed rABC2625cfcf5ed7: [avalanche] Move AvalancheNode to its own file (authored by deadalnix).
[avalanche] Move AvalancheNode to its own file
Mon, Jul 6, 21:48
deadalnix closed D6830: [avalanche] Move AvalancheNode to its own file.
Mon, Jul 6, 21:48
deadalnix added inline comments to D6831: [avalanche] Factor AvalancheNode from PeerManager.
Mon, Jul 6, 21:48
deadalnix accepted D6829: [refactor] add const CChainParams& m_params to interface::ChainImpl.
Mon, Jul 6, 21:47
deadalnix committed rABC4148611617c6: [avalanche] Remove getPubkey API (authored by deadalnix).
[avalanche] Remove getPubkey API
Mon, Jul 6, 21:42
deadalnix closed D6828: [avalanche] Remove getPubkey API.
Mon, Jul 6, 21:42
deadalnix requested review of D6831: [avalanche] Factor AvalancheNode from PeerManager.
Mon, Jul 6, 20:49
deadalnix updated the summary of D6830: [avalanche] Move AvalancheNode to its own file.
Mon, Jul 6, 20:48
deadalnix requested review of D6830: [avalanche] Move AvalancheNode to its own file.
Mon, Jul 6, 20:47
deadalnix requested changes to D6829: [refactor] add const CChainParams& m_params to interface::ChainImpl.

Good start, but you needlessly complicated yourself for the tests.

Mon, Jul 6, 20:00
deadalnix requested review of D6828: [avalanche] Remove getPubkey API.
Mon, Jul 6, 18:11
deadalnix committed rABCc357d6422cbd: [avalanche] Add a facility to update node's timeout (authored by deadalnix).
[avalanche] Add a facility to update node's timeout
Mon, Jul 6, 12:41
deadalnix closed D6825: [avalanche] Add a facility to update node's timeout.
Mon, Jul 6, 12:41
deadalnix added inline comments to D6825: [avalanche] Add a facility to update node's timeout.
Mon, Jul 6, 12:40
deadalnix committed rABCdcae6a72516c: [avalanche] Add facilities to delete nodes from the PeerManager (authored by deadalnix).
[avalanche] Add facilities to delete nodes from the PeerManager
Mon, Jul 6, 12:39
deadalnix closed D6824: [avalanche] Add facilities to delete nodes from the PeerManager.
Mon, Jul 6, 12:39
deadalnix committed rABC785a2f794bac: [avalanche] Add node related functions to the peermanager (authored by deadalnix).
[avalanche] Add node related functions to the peermanager
Mon, Jul 6, 12:38
deadalnix closed D6822: [avalanche] Add node related functions to the peermanager.
Mon, Jul 6, 12:37
deadalnix committed rABCb406ddfc609f: [avalanche] Add the notion of Peer to the PeerManager (authored by deadalnix).
[avalanche] Add the notion of Peer to the PeerManager
Mon, Jul 6, 12:36
deadalnix closed D6818: [avalanche] Add the notion of Peer to the PeerManager.
Mon, Jul 6, 12:36
deadalnix committed rABC77ce7e791586: [avalanche] Use an hash_unique key for the node/round index in QuerySet (authored by deadalnix).
[avalanche] Use an hash_unique key for the node/round index in QuerySet
Mon, Jul 6, 12:34
deadalnix closed D6823: [avalanche] Use an hash_unique key for the node/round index in QuerySet.
Mon, Jul 6, 12:34
deadalnix committed rABC52d09d010769: Move NO_NODE to net.h (authored by deadalnix).
Move NO_NODE to net.h
Mon, Jul 6, 12:33
deadalnix closed D6826: Move NO_NODE to net.h.
Mon, Jul 6, 12:33
deadalnix requested review of D6826: Move NO_NODE to net.h.
Mon, Jul 6, 00:01

Sun, Jul 5

deadalnix requested review of D6825: [avalanche] Add a facility to update node's timeout.
Sun, Jul 5, 21:59
deadalnix requested review of D6824: [avalanche] Add facilities to delete nodes from the PeerManager.
Sun, Jul 5, 21:46
deadalnix updated the diff for D6822: [avalanche] Add node related functions to the peermanager.

Flatten things such as one multi_index is used and all nodes are in it.

Sun, Jul 5, 17:56
deadalnix updated the diff for D6818: [avalanche] Add the notion of Peer to the PeerManager.

Simplify the Peer struct so that it doesn't contain nodes. Nodes wills be stored in their own datastructure later on.

Sun, Jul 5, 17:25
deadalnix planned changes to D6822: [avalanche] Add node related functions to the peermanager.

See D6818

Sun, Jul 5, 02:42
deadalnix planned changes to D6818: [avalanche] Add the notion of Peer to the PeerManager.

There is a better way to do this using multi index magic.

Sun, Jul 5, 02:41
deadalnix requested review of D6823: [avalanche] Use an hash_unique key for the node/round index in QuerySet.
Sun, Jul 5, 02:28
deadalnix updated the diff for D6822: [avalanche] Add node related functions to the peermanager.

rebase

Sun, Jul 5, 00:44
deadalnix updated the diff for D6818: [avalanche] Add the notion of Peer to the PeerManager.

rebase

Sun, Jul 5, 00:44
deadalnix accepted D6819: [backport#15267] doc: explain AcceptToMemoryPoolWorker's coins_to_uncache.
Sun, Jul 5, 00:41
deadalnix committed rABC0f4e51c145e0: [avalanche] Use std::chrono for time constants (authored by deadalnix).
[avalanche] Use std::chrono for time constants
Sun, Jul 5, 00:38
deadalnix closed D6821: [avalanche] Use std::chrono for time constants.
Sun, Jul 5, 00:38
deadalnix committed rABC7bd7f8c0caea: [avalanche] Use constexpr for global constants (authored by deadalnix).
[avalanche] Use constexpr for global constants
Sun, Jul 5, 00:34
deadalnix closed D6820: [avalanche] Use constexpr for global constants.
Sun, Jul 5, 00:34
deadalnix updated the summary of D6822: [avalanche] Add node related functions to the peermanager.
Sun, Jul 5, 00:31
deadalnix requested review of D6822: [avalanche] Add node related functions to the peermanager.
Sun, Jul 5, 00:31

Sat, Jul 4

deadalnix updated the diff for D6821: [avalanche] Use std::chrono for time constants.

Name tweaks

Sat, Jul 4, 23:52
deadalnix requested review of D6821: [avalanche] Use std::chrono for time constants.
Sat, Jul 4, 23:45
deadalnix updated the diff for D6820: [avalanche] Use constexpr for global constants.

Also do AVALANCHE_TIME_STEP_MILLISECONDS

Sat, Jul 4, 23:41