- User Since
- May 14 2017, 13:52 (131 w, 21 h)
It's getting there, this is now much better, but there are still a few things that could be improved.
More test is always welcome, unless they are flaky or slow as shit.
See comments in D4356
Overall it looks good. A few details needs to be changed, though.
This isn't a really a change request per se, but I don't understand how the template come to be used, considering it is not referenced anywhere.
I don't think the design here is sound. You don't have an error boundary set anywhere, but a parameter that you pass down to ask what's downstream to not error out. This is not solid. The whole point of the maneuver is to not trust what downstream of the error boundary.
Sat, Nov 16
Fri, Nov 15
Thu, Nov 14
The iff description doesn't match what this does, because it clearly does more than simply receiving and processing the headers messages, it also filter/ban nodes based on it.
I don't see any filtering going on anywhere is that patch.
Wed, Nov 13
Add fogoten brace
Tue, Nov 12
It's not super useful, ut helps backports.
Rebase and address comments
Fix doc and rebase
Mon, Nov 11
rebase and fix merge conflict
Sun, Nov 10
You can include this with the test. It's not really possible to figure out if that is a good idea or not without having an idea of where this is going.
Depending on system libs will cause the build to not be reproducible. You need to be using depends libs.
You need to be using the depends libs and not the system's.
You need to be using the libs from depends and not the system libs.
Sat, Nov 9
Remove release notes. Will add them back when backporting PR13697 and PR14096
Thu, Nov 7
Wed, Nov 6
Add release notes, sort imports
This PR doesn't contain any change to the release notes. I'm not sure why we would want to warn people about this, it's not breaking any existing behavior, or fixing any bug they'd waiting on, and is not a very major change.
make static and reorder imports
Fix missing else