Page MenuHomePhabricator

deadalnix (Amaury SÉCHET)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
May 14 2017, 13:52 (193 w, 20 h)
Roles
Administrator

Recent Activity

Sat, Jan 23

deadalnix accepted D8947: test: add wait_for_cookie_credentials() to framework for rpcwait tests.
Sat, Jan 23, 20:50
deadalnix accepted D9046: Add Trunk Based Development link to CONTRIBUTING.
Sat, Jan 23, 00:25

Fri, Jan 22

deadalnix requested changes to D8899: Check for overflow when calculating sum of outputs.
Fri, Jan 22, 23:06
deadalnix abandoned D8811: [cashtab] Upgrade node modules.
Fri, Jan 22, 23:00

Thu, Jan 21

deadalnix accepted D9017: script: prevent UB when computing abs value for num opcode serialize.
Thu, Jan 21, 20:52
deadalnix accepted D8942: [net_processing] Pass chainparams to PeerLogicValidation constructor.
Thu, Jan 21, 20:51
deadalnix requested changes to D8942: [net_processing] Pass chainparams to PeerLogicValidation constructor.

Back to your queue due to test failures.

Thu, Jan 21, 18:12

Mon, Jan 18

deadalnix requested changes to D8942: [net_processing] Pass chainparams to PeerLogicValidation constructor.

The config is needed down the road is just saying nothing at all.

Mon, Jan 18, 21:58
deadalnix requested changes to D8947: test: add wait_for_cookie_credentials() to framework for rpcwait tests.
Mon, Jan 18, 17:03
deadalnix requested changes to D8942: [net_processing] Pass chainparams to PeerLogicValidation constructor.

You say that it differs from the original by passing a config, but provide no reason as to why. It doesn't looks like to me that this difference is justified.

Mon, Jan 18, 13:27
deadalnix accepted D8941: test: Replace boost::mutex with std::mutex.
Mon, Jan 18, 13:26

Sat, Jan 16

deadalnix requested changes to D8899: Check for overflow when calculating sum of outputs.
Sat, Jan 16, 15:55

Thu, Jan 14

deadalnix requested changes to D8899: Check for overflow when calculating sum of outputs.
In D8899#204315, @PiRK wrote:

I added a few tests, but now I 'm no longer sure that all situations described in the PR are possible. I don't know how to reasonably generate a CTransaction whose outputs would add up to an int64 overflow without any single one of the outputs being larger than MAX_MONEY.
It would require 439208192231 outputs.

Thu, Jan 14, 02:51

Wed, Jan 13

deadalnix closed D8901: [CashTab] Update react-copy-to-clipboard.
Wed, Jan 13, 17:05
deadalnix committed rABCc17adeb89179: [CashTab] Update react-copy-to-clipboard (authored by deadalnix).
[CashTab] Update react-copy-to-clipboard
Wed, Jan 13, 17:05
deadalnix accepted D8900: RPC: Fix more formatting nits.
Wed, Jan 13, 14:58
deadalnix requested review of D8901: [CashTab] Update react-copy-to-clipboard.
Wed, Jan 13, 14:50
deadalnix requested changes to D8899: Check for overflow when calculating sum of outputs.

I know there isn't int he original code, but there should really be tests cases for this.

Wed, Jan 13, 14:22
deadalnix accepted D8762: [backport#16658] validation: Rename CheckInputs to CheckInputScripts.
Wed, Jan 13, 14:21

Tue, Jan 12

deadalnix accepted D8886: Update copyright year to 2021.
Tue, Jan 12, 23:12
deadalnix accepted D8883: Limit decimal range of numbers ParseScript accepts.
Tue, Jan 12, 15:54
deadalnix accepted D8882: util: Fail to parse space-only strings in ParseMoney(...) (instead of parsing as zero).
Tue, Jan 12, 15:34
deadalnix closed D8862: [avalanche] Initiate avalanche when the service bit is present and we have a stake..
Tue, Jan 12, 11:35
deadalnix committed rABC42a8d3bc2caa: [avalanche] Initiate avalanche when the service bit is present and we have a… (authored by deadalnix).
[avalanche] Initiate avalanche when the service bit is present and we have a…
Tue, Jan 12, 11:35
deadalnix accepted D8879: lockedpool: When possible, use madvise to avoid including sensitive information in core dumps.
Tue, Jan 12, 10:58
deadalnix accepted D8880: lockedpool: avoid sensitive data in core files (FreeBSD).
Tue, Jan 12, 10:57

Mon, Jan 11

deadalnix accepted D8877: [CI] Work around LCOV stupid behavior.
Mon, Jan 11, 23:11
deadalnix updated the diff for D8862: [avalanche] Initiate avalanche when the service bit is present and we have a stake..

Address comments

Mon, Jan 11, 23:04
deadalnix added inline comments to D8862: [avalanche] Initiate avalanche when the service bit is present and we have a stake..
Mon, Jan 11, 20:26
deadalnix updated the diff for D8862: [avalanche] Initiate avalanche when the service bit is present and we have a stake..

rebase

Mon, Jan 11, 01:47
deadalnix closed D8861: [net] Add extra entropy to the version message.
Mon, Jan 11, 01:34
deadalnix committed rABC9343802bc731: [net] Add extra entropy to the version message (authored by deadalnix).
[net] Add extra entropy to the version message
Mon, Jan 11, 01:34

Sun, Jan 10

deadalnix requested review of D8861: [net] Add extra entropy to the version message.

The requested change differ from the existing code style for a benefit that is at best elusive.

Sun, Jan 10, 16:12
deadalnix updated the diff for D8862: [avalanche] Initiate avalanche when the service bit is present and we have a stake..

Remove debug logs

Sun, Jan 10, 03:20

Sat, Jan 9

deadalnix requested review of D8862: [avalanche] Initiate avalanche when the service bit is present and we have a stake..
Sat, Jan 9, 23:44
deadalnix updated the diff for D8861: [net] Add extra entropy to the version message.

Fix node version message (relay and extra entropy were reverted)

Sat, Jan 9, 23:19
deadalnix closed D8860: [test framework] Simplify version message handling.
Sat, Jan 9, 22:03
deadalnix committed rABC3584de484d22: [test framework] Simplify version message handling (authored by deadalnix).
[test framework] Simplify version message handling
Sat, Jan 9, 22:03
deadalnix updated the summary of D8861: [net] Add extra entropy to the version message.
Sat, Jan 9, 22:03
deadalnix requested review of D8861: [net] Add extra entropy to the version message.
Sat, Jan 9, 22:02
deadalnix requested review of D8860: [test framework] Simplify version message handling.
Sat, Jan 9, 21:00
deadalnix closed D8850: [cashtab] Update to react 17.
Sat, Jan 9, 15:54
deadalnix committed rABC1e0eb96c2ff0: [cashtab] Update to react 17 (authored by deadalnix).
[cashtab] Update to react 17
Sat, Jan 9, 15:54

Fri, Jan 8

deadalnix accepted D8845: rpc: Document an RPCResult for all calls; Enforce at compile time.
Fri, Jan 8, 16:28
deadalnix accepted D8849: [cashtab] use npm ci instead of install on CI.
Fri, Jan 8, 15:34
deadalnix requested review of D8850: [cashtab] Update to react 17.
Fri, Jan 8, 15:29
deadalnix closed D8838: [cashtab] Upgrade webpack modules.
Fri, Jan 8, 14:41
deadalnix committed rABC0dddb517c3f8: [cashtab] Upgrade webpack modules (authored by deadalnix).
[cashtab] Upgrade webpack modules
Fri, Jan 8, 14:41
deadalnix requested review of D8838: [cashtab] Upgrade webpack modules.
Fri, Jan 8, 14:00
deadalnix updated the diff for D8838: [cashtab] Upgrade webpack modules.

Updated package-lock and rebase

Fri, Jan 8, 13:43
deadalnix added a comment to D8838: [cashtab] Upgrade webpack modules.

I'm able to get npm install to work here with node v15.3.0 or v15.4.0 and npm v7.0.15 (but package-lock.json is different)

npm v7.3.0 runs into dependency issue without --legacy-peer-deps

What version of node and npm did you use for this diff?

Could you please run

cd cashtab/web
rm -rf node_modules
rm package-lock-json
npm i

and submit?

Fri, Jan 8, 13:43
deadalnix closed D8841: [cashtab] Downgrade css-loader.
Fri, Jan 8, 13:38
deadalnix committed rABCb1515370602b: [cashtab] Downgrade css-loader (authored by deadalnix).
[cashtab] Downgrade css-loader
Fri, Jan 8, 13:38
deadalnix requested changes to D8845: rpc: Document an RPCResult for all calls; Enforce at compile time.

Check build failure

Fri, Jan 8, 11:06
deadalnix accepted D8846: Fix mining to an invalid target + ensure that a new block has the correct hash internally in Python tests.
Fri, Jan 8, 11:05
deadalnix requested changes to D8673: Add -overridednsseed for testing DNS seed behavior.
Fri, Jan 8, 11:04
deadalnix accepted D8847: tests: simplify next_block() function in feature_block.
Fri, Jan 8, 11:02
deadalnix accepted D8848: rand: remove getentropy() fallback for macOS < 10.12.
Fri, Jan 8, 11:02

Thu, Jan 7

deadalnix requested review of D8841: [cashtab] Downgrade css-loader.
Thu, Jan 7, 21:05
deadalnix accepted D8828: [CASHTAB] Update the jest dependency.
Thu, Jan 7, 18:57
deadalnix requested review of D8838: [cashtab] Upgrade webpack modules.
Thu, Jan 7, 18:56
deadalnix accepted D8830: test: Add missing syncwithvalidationinterfacequeue.
Thu, Jan 7, 15:45
deadalnix accepted D8829: Remove redundant type information from rpc docs.
Thu, Jan 7, 15:44
deadalnix accepted D8831: util: HelpExampleRpc formatting fixup.
Thu, Jan 7, 15:43
deadalnix requested changes to D8828: [CASHTAB] Update the jest dependency.

If you need --legacy-peer-deps you have regressed something.

Thu, Jan 7, 15:39
deadalnix requested changes to D8825: css-loader to highest version without breaking npm start.

1/ I cannot reproduce, npm start works just fine on master.
2/ Knowing what the error is would help assert if the solution is appropriate.

Thu, Jan 7, 14:41
deadalnix updated the diff for D8811: [cashtab] Upgrade node modules.

Removed @testing-library/react-hooks because it has conflicts, and it doesn't seems liek it is used. It would be good to double check, because everything seems busted around here.

Thu, Jan 7, 06:12
deadalnix closed D8818: [cashtab] Upgrade mini-css-extract-plugin.
Thu, Jan 7, 06:09
deadalnix committed rABC57dcf13a43d3: [cashtab] Upgrade mini-css-extract-plugin (authored by deadalnix).
[cashtab] Upgrade mini-css-extract-plugin
Thu, Jan 7, 06:09
deadalnix closed D8819: [cashtab] Update css-loader.
Thu, Jan 7, 06:08
deadalnix committed rABC3586bf69bd64: [cashtab] Update css-loader (authored by deadalnix).
[cashtab] Update css-loader
Thu, Jan 7, 06:08
deadalnix closed D8814: [cashtab] Update file-loader and fs-extra.
Thu, Jan 7, 06:07
deadalnix committed rABC77b7324561c4: [cashtab] Update file-loader and fs-extra (authored by deadalnix).
[cashtab] Update file-loader and fs-extra
Thu, Jan 7, 06:07
deadalnix closed D8813: [cashtab] Upgrade eslint.
Thu, Jan 7, 06:05
deadalnix committed rABCd8be8a399c7d: [cashtab] Upgrade eslint (authored by deadalnix).
[cashtab] Upgrade eslint
Thu, Jan 7, 06:05
deadalnix closed D8812: [cashtab] Update webpack.
Thu, Jan 7, 06:04
deadalnix committed rABC9f4ec7600822: [cashtab] Update webpack (authored by deadalnix).
[cashtab] Update webpack
Thu, Jan 7, 06:04
deadalnix requested review of D8819: [cashtab] Update css-loader.
Thu, Jan 7, 06:00
deadalnix updated the diff for D8812: [cashtab] Update webpack.

rebase

Thu, Jan 7, 05:52
deadalnix updated the diff for D8814: [cashtab] Update file-loader and fs-extra.

rebase

Thu, Jan 7, 05:51
deadalnix updated the diff for D8814: [cashtab] Update file-loader and fs-extra.

rebase

Thu, Jan 7, 05:50
deadalnix updated the diff for D8813: [cashtab] Upgrade eslint.

rebase

Thu, Jan 7, 05:46
deadalnix updated the diff for D8818: [cashtab] Upgrade mini-css-extract-plugin.

rebase

Thu, Jan 7, 05:45
deadalnix closed D8817: [cashtab] Downgrade terser-webpack-plugin to use a supported version of webpack.
Thu, Jan 7, 05:44
deadalnix committed rABCa4b9fcd7c15f: [cashtab] Downgrade terser-webpack-plugin to use a supported version of webpack (authored by deadalnix).
[cashtab] Downgrade terser-webpack-plugin to use a supported version of webpack
Thu, Jan 7, 05:44
deadalnix closed D8816: Do not format autogenerated files.
Thu, Jan 7, 05:43
deadalnix committed rABCcb1e74da0403: Do not format autogenerated files (authored by deadalnix).
Do not format autogenerated files
Thu, Jan 7, 05:43
deadalnix closed D8815: [cashtab] Update fbt.
Thu, Jan 7, 05:43
deadalnix committed rABCc34cf16f70f8: [cashtab] Update fbt (authored by deadalnix).
[cashtab] Update fbt
Thu, Jan 7, 05:43
deadalnix requested review of D8818: [cashtab] Upgrade mini-css-extract-plugin.
Thu, Jan 7, 05:37
deadalnix requested review of D8817: [cashtab] Downgrade terser-webpack-plugin to use a supported version of webpack.
Thu, Jan 7, 05:25
deadalnix updated the diff for D8812: [cashtab] Update webpack.

Stay on webpack 4

Thu, Jan 7, 05:13
deadalnix updated the diff for D8816: Do not format autogenerated files.

Remove useless prettierignore

Thu, Jan 7, 02:35
deadalnix requested review of D8816: Do not format autogenerated files.
Thu, Jan 7, 02:34
deadalnix requested review of D8815: [cashtab] Update fbt.
Thu, Jan 7, 02:16
deadalnix requested review of D8814: [cashtab] Update file-loader and fs-extra.
Thu, Jan 7, 01:56
deadalnix updated the diff for D8813: [cashtab] Upgrade eslint.

Remove typescript-eslint modules, as we don't use typescript

Thu, Jan 7, 01:45
deadalnix requested review of D8813: [cashtab] Upgrade eslint.
Thu, Jan 7, 01:38
deadalnix requested review of D8812: [cashtab] Update webpack.
Thu, Jan 7, 01:17
deadalnix closed D8809: Downgrade react-test-renderer.
Thu, Jan 7, 01:13