♟ deadalnix

Accepting because doing all the nits + the backport would become very tedious. I trust you'll follow through.

Fix mixture of tab and spaces

Back on your queue, this is apparently breaking many tests.

@markblundeberg Both are necessary. one is a public API, one is a private one.

reorder code so verify come before sign. This allows to change the signature code (for instance for multisig) without causing the verification code lost in the middle of the signature code.

remove useless static

Refactor the signing code.

Extract a function to generate a proper value for k
Use that fucntion in the signing code.

Some small nits, but overall it's good.

Use R.x in part of the explaination where r is not defined

Explain test cases more in details.

[avalanche] Add the concept of inconclusive votes

[avalanche] Use black magic for popcount.

Please investigate with harbormaster is failing before landing.

I have no idea what problem this diff solves.

Add explaination about error codes

Add explainations and link for the blakc magic.
Add parenthesis to make the compiler happy.

This ends up changing all the tests for no good reasons. Just add the new tests cases after the existing ones. You can use reconsiderblock/invalidate block to recreate the situation you desire.

A few small changes, but LGTM.

[avalanche] Expire queries once they reached their timeout.

[avalanche] Delegate node management to caller

[avalanche] Make sure the round variable is initialized properly

[avalanche] Use a multi_index to track request so it is easy to determine which…

[avalanche] Ensure block added to avalanche have the proper acceptance.

[avalanche] Enforce cooldown request present in AvalancheResponse

[avalanche] consistently use avanodeid in avalanche's test.

Make CNodeStats a struct and add a blurb explaining what it is.

[avalanche] Implement the challenge/response protocol

[avalanche] Report the list of finalized blocks when votes are accounted for

[avalanche] Add support to poll multiple block at once.

[avalanche] Add a facility to select invs to poll

[avalanche] Create an event loop facility.

[avalanche] Add a block registry and facility to register votes on these blocks.

Move finalization suck as reconsiderblock actualy reconsider blocks

Fix various bugs in the seeder.

[avalanche] Create a structure to accumulate avalanche votes

Process transaction in reverse order in DisconnectedBlockTransactions…

Add test case and release notes for auto finalization

Add an RPC to finalize a block

Auto-finalize block once they reached a certain depth (by default 10)

Reconsider parked chains when enough works piles up

Do not unpark children of blocks outside of the RPC

revert changes to abc-p2p-compactblock.py

Fix block construction in abc-p2p-compactblocks.py

[qa] Fix p2p-fullblocktest.py for magnetic anomaly

Fix sources of flackiness in p2p-fullblocktest.py

Nits in AcceptBlockHeader

Make error message more meaningful when a block contains a duplicate transaction

Add a checkpoint for the fork block

Ensure CPU mining is reliable

Fix comment in util.py

Remove alerts support from mininode.py

Nits in arith_uint256_tests.cpp

Run checkdatasig_tests on a larger set of flags

Add missing include in rwcollection.h

Add RWCollection, a read-write locked collection with a mostly safe API

Update relase checklist

Add a way to stop scheduleEvery instances.

[avalanche] Expire queries once they reached their timeout.

[avalanche] Delegate node management to caller

deadalnix (Amaury SÉCHET)Administrator
User

Projects

User Details

Recent Activity
View All

Tue, Dec 11

Sat, Dec 8

Fri, Dec 7

Thu, Dec 6

Tue, Dec 4

Mon, Dec 3

Sun, Dec 2

Sat, Dec 1

Fri, Nov 30

Thu, Nov 29

deadalnix (Amaury SÉCHET)AdministratorUser