Page MenuHomePhabricator

deadalnix (Amaury SÉCHET)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
May 14 2017, 13:52 (105 w, 2 d)
Roles
Administrator

Recent Activity

Yesterday

deadalnix accepted D3074: Fix undefined behavior in avalanche.cpp.
Mon, May 20, 20:29
deadalnix accepted D3014: Merge #10095: refactor: Move GetDifficulty out of `rpc/server.h`.
Mon, May 20, 20:18
deadalnix requested changes to D3073: [RPC] Serialize in getblock without cs_main.

Please mention the PR that is backport in the description like this:

  • This is backport of Core PR12345
  • The test plan is inadequate as it doesn't run the RPC tests - and probably should do so using the debug build to check that there are at least no regression (that build is not green for RPC tests).
  • This seems to be a duplicate of D3021 and suffer from the same problem that there is a test dependency that is missing - or if it is not, then there should be at least some justification as to why this is the case.
Mon, May 20, 17:23
deadalnix added a comment to D3021: Merge #12151: rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON.

t seems like this would depend on whatever added the get_difficulty_for_null_tip test.

Mon, May 20, 17:20
deadalnix requested changes to D3014: Merge #10095: refactor: Move GetDifficulty out of `rpc/server.h`.

The test place doesn't cover RPC tests, however, this is clearly changing RPC tests.

Mon, May 20, 17:15
deadalnix requested changes to D3074: Fix undefined behavior in avalanche.cpp.

If the problem is that nodeid is signed, then this is what needs fixing, not all the constants.

Mon, May 20, 16:37
deadalnix requested changes to D3065: Remove segwit recovery activation.

Ok the approach this diff takes is a bit backward. It doesn't really remove the activation of anything, it just change the activation point to the genesis block. Here is a better approach:

  • Create a flag that disalow segwit recovery.
  • Make that flag a standard flag.
  • Remove all mention of the flag in all validation path except mempool admission.
Mon, May 20, 00:16
deadalnix requested changes to D3069: Add CHECKDATASIG to standard flags..

A few changes, but overall, it looks good.

Mon, May 20, 00:11

Sat, May 18

deadalnix accepted D3015: [CMAKE] Add support for libqrencode.
Sat, May 18, 20:37
deadalnix accepted D3068: [CI] Run functional tests both pre and post graviton.
Sat, May 18, 16:23
deadalnix requested changes to D3069: Add CHECKDATASIG to standard flags..

That should really be made a standard flag first for a while. If not then a client could get banned during IBD.

Sat, May 18, 16:23

Fri, May 17

deadalnix updated the diff for D3061: Update prevector.

Rebase and remove empty line.

Fri, May 17, 19:19
deadalnix added a comment to D3061: Update prevector.

GCC4.x doesn't do C++14

Fri, May 17, 19:11
deadalnix accepted D3064: Use angle brackets in windows resource files.
Fri, May 17, 19:10
deadalnix accepted D3056: Separate version info into bitcoin-version.h from bitcoin-config.h.
Fri, May 17, 18:03
deadalnix accepted D3062: Make release-process.md IBD instruction more precise.
Fri, May 17, 11:51
deadalnix requested changes to D3056: Separate version info into bitcoin-version.h from bitcoin-config.h.
Fri, May 17, 11:11

Thu, May 16

deadalnix accepted D3019: [CMAKE] Add cross build toolchain files for PC Linux platform.
Thu, May 16, 23:09
deadalnix accepted D2892: [CMAKE] Add an option to enable the glibc compatibility features.
Thu, May 16, 23:07
deadalnix requested changes to D3015: [CMAKE] Add support for libqrencode.
Thu, May 16, 23:05
deadalnix accepted D3059: Remove redundant items from STANDARD_SCRIPT_VERIFY_FLAGS.
Thu, May 16, 22:57
deadalnix accepted D3060: Clarify comment for SCRIPT_ENABLE_CHECKDATASIG.
Thu, May 16, 22:56
Herald added a reviewer for D3061: Update prevector: Restricted Project.
Thu, May 16, 22:32
deadalnix committed rABC7254fd799a0b: Have gArgs handle printing help (authored by deadalnix).
Have gArgs handle printing help
Thu, May 16, 22:03
deadalnix closed D3058: Have gArgs handle printing help.
Thu, May 16, 22:03
deadalnix requested changes to D3017: [CMAKE] Add QT plugins according to the target platform.
Thu, May 16, 17:10
deadalnix requested changes to D2792: Add a build command to arcanist.

Back on your queue. This would not serve much of a purpose before cmake build works anyways.

Thu, May 16, 17:06
deadalnix requested changes to D2997: [CMAKE] Add support for Miniupnpc.
Thu, May 16, 17:06
deadalnix accepted D2904: [index] Create new TxIndex class..
Thu, May 16, 17:02
deadalnix accepted D3032: [CMAKE] Fix bitcoind cross build for OSX.

I'm pretty sure the dependency graph for this is completely wrong.

Thu, May 16, 16:58
deadalnix committed rABC23b59f2259d5: [docs] Reformat -help output for help2man (authored by Tim Ruffing <crypto@timruffing.de>).
[docs] Reformat -help output for help2man
Thu, May 16, 16:19
deadalnix closed D3043: [docs] Reformat -help output for help2man.
Thu, May 16, 16:19
Herald added a reviewer for D3058: Have gArgs handle printing help: Restricted Project.
Thu, May 16, 16:15
deadalnix accepted D3031: [CMAKE] Cleanup the OSX platform file.
Thu, May 16, 16:06
deadalnix requested changes to D2980: Merge #12287: Optimise lock behaviour for GuessVerificationProgress().
Thu, May 16, 16:05
deadalnix requested changes to D3017: [CMAKE] Add QT plugins according to the target platform.
Thu, May 16, 16:00
deadalnix requested changes to D3021: Merge #12151: rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON.
Thu, May 16, 15:52
deadalnix accepted D3020: [CMAKE] Add cross compiling support for ARM32 and ARM64.
Thu, May 16, 15:51
deadalnix accepted D3024: [tests] Remove unused variables.
Thu, May 16, 15:50
deadalnix updated the test plan for D3043: [docs] Reformat -help output for help2man.
Thu, May 16, 15:47
deadalnix added a comment to D3043: [docs] Reformat -help output for help2man.

Updated test plan

Thu, May 16, 15:46
deadalnix requested review of D3043: [docs] Reformat -help output for help2man.
Thu, May 16, 15:46
deadalnix updated the test plan for D3043: [docs] Reformat -help output for help2man.
Thu, May 16, 15:46
deadalnix requested changes to D3056: Separate version info into bitcoin-version.h from bitcoin-config.h.

config contains allt he confgure generated files, so config/version.h would make much more sense.

Thu, May 16, 14:57
deadalnix accepted D3057: Fix braces in warnings.cpp.
Thu, May 16, 14:50
deadalnix updated the diff for D3043: [docs] Reformat -help output for help2man.

rebase

Thu, May 16, 12:56
deadalnix committed rABC9aa686d254d1: wallet: Refactor g_wallet_init_interface to const reference (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
wallet: Refactor g_wallet_init_interface to const reference
Thu, May 16, 12:53
deadalnix closed D3048: wallet: Refactor g_wallet_init_interface to const reference.
Thu, May 16, 12:53
deadalnix committed rABCc4731a27868f: wallet: Make WalletInitInterface members const (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
wallet: Make WalletInitInterface members const
Thu, May 16, 12:51
deadalnix closed D3045: wallet: Make WalletInitInterface members const.
Thu, May 16, 12:51
deadalnix updated the diff for D3048: wallet: Refactor g_wallet_init_interface to const reference.

rebase

Thu, May 16, 12:40
deadalnix committed rABC24718b29dbf7: Move RPC registration out of AppInitParameterInteraction (authored by Russell Yanofsky <russ@yanofsky.org>).
Move RPC registration out of AppInitParameterInteraction
Thu, May 16, 12:34
deadalnix closed D3047: Move RPC registration out of AppInitParameterInteraction.
Thu, May 16, 12:34
deadalnix committed rABC0cd601821488: Fix D2181 by including DumpRPC (authored by deadalnix).
Fix D2181 by including DumpRPC
Thu, May 16, 12:33
deadalnix closed D3046: Fix D2181 by including DumpRPC.
Thu, May 16, 12:33
deadalnix accepted D3033: [CMAKE] Add missing files to build bitcoin-qt on OSX.
Thu, May 16, 12:32
deadalnix accepted D3055: Bump version number to 0.19.7.
Thu, May 16, 12:32
deadalnix requested review of D3046: Fix D2181 by including DumpRPC.
Thu, May 16, 12:30
deadalnix updated the diff for D3047: Move RPC registration out of AppInitParameterInteraction.

Reup fubared diff

Thu, May 16, 11:47

Wed, May 15

deadalnix accepted D3030: [CMAKE] Fix missing protobuf include directory.
Wed, May 15, 18:43
deadalnix committed rABCfd1e8051b429: Count checkdatasig for transaction entering the mempool (authored by deadalnix).
Count checkdatasig for transaction entering the mempool
Wed, May 15, 14:24
deadalnix closed D3053: Count checkdatasig for transaction entering the mempool.
Wed, May 15, 14:24
Herald added a reviewer for D3053: Count checkdatasig for transaction entering the mempool: Restricted Project.
Wed, May 15, 14:17
deadalnix accepted D3052: Update man pages for v0.19.6.
Wed, May 15, 12:41
deadalnix accepted D3051: Update chainparams for 0.19.6 release.
Wed, May 15, 12:39
deadalnix accepted D3050: Fix more init bugs..
Wed, May 15, 11:19

Tue, May 14

deadalnix requested changes to D3014: Merge #10095: refactor: Move GetDifficulty out of `rpc/server.h`.

Please write a proper test plan.

Tue, May 14, 22:57
deadalnix updated the diff for D3047: Move RPC registration out of AppInitParameterInteraction.

Fix initial diff broken due to DDoS

Tue, May 14, 22:47
deadalnix accepted D3044: Merge #11385: Remove some unused functions and methods.
Tue, May 14, 22:42
deadalnix accepted D3041: [CMAKE] Allow to use sanitizers with cmake.
Tue, May 14, 22:41
Herald added a reviewer for D3048: wallet: Refactor g_wallet_init_interface to const reference: Restricted Project.
Tue, May 14, 22:40
Herald added a reviewer for D3047: Move RPC registration out of AppInitParameterInteraction: Restricted Project.
Tue, May 14, 22:32
Herald added a reviewer for D3046: Fix D2181 by including DumpRPC: Restricted Project.
Tue, May 14, 21:42
deadalnix updated the diff for D3045: wallet: Make WalletInitInterface members const.

Reup

Tue, May 14, 21:15
deadalnix committed rABCf4cea37d423c: Remove useless include of boost thread (authored by deadalnix).
Remove useless include of boost thread
Tue, May 14, 19:07
deadalnix closed D3042: Remove useless include of boost thread.
Tue, May 14, 19:06
Herald added a reviewer for D3043: [docs] Reformat -help output for help2man: Restricted Project.
Tue, May 14, 17:15
Herald added a reviewer for D3042: Remove useless include of boost thread: Restricted Project.
Tue, May 14, 16:01
deadalnix accepted D3034: [CMAKE] Disable OpenGL in Qt static build for OSX.
Tue, May 14, 13:23
deadalnix requested changes to D3041: [CMAKE] Allow to use sanitizers with cmake.

The fact you should ECM to implement this is of little interest as fr as the API is concerned.

Tue, May 14, 13:22

Sun, May 12

deadalnix requested changes to D3025: [Wallet] CheckBalance instead of GetBalance for 13% faster sendtoaddress.
Sun, May 12, 23:30
deadalnix requested changes to D3024: [tests] Remove unused variables.

Where is part 1 ? Why doesn't this depends on part 1 ?

Sun, May 12, 23:29
deadalnix requested changes to D3020: [CMAKE] Add cross compiling support for ARM32 and ARM64.

ARM64 is typically called AArch64 and 32 just ARM

Sun, May 12, 23:27
deadalnix requested changes to D3019: [CMAKE] Add cross build toolchain files for PC Linux platform.

It's not clear that this depends on any way on the diff you say it depends on.

Sun, May 12, 23:26
deadalnix requested changes to D3017: [CMAKE] Add QT plugins according to the target platform.
Sun, May 12, 23:22
deadalnix accepted D2948: [CMAKE] Fix the prl conversion script library path issue.
Sun, May 12, 23:14
deadalnix requested changes to D3018: [CMAKE] Fix CMake cross build for OSX.

It is clear you are aware this patches does many things at once, because you enumerate them in the description.

Sun, May 12, 23:13
deadalnix requested changes to D3015: [CMAKE] Add support for libqrencode.

This invent a new way to configure things for no apparent reason.

Sun, May 12, 22:21

Tue, May 7

deadalnix committed rABCee7267de6060: Init: Remove redundant exit(EXIT_FAILURE) instances and replace with return… (authored by donaloconnor <donaloconnor@gmail.com>).
Init: Remove redundant exit(EXIT_FAILURE) instances and replace with return…
Tue, May 7, 13:56
deadalnix closed D2953: Init: Remove redundant exit(EXIT_FAILURE) instances and replace with return false.
Tue, May 7, 13:56
deadalnix committed rABC913c1dd302bd: Ignore macOS daemon() depracation warning (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
Ignore macOS daemon() depracation warning
Tue, May 7, 13:56
deadalnix closed D2954: Ignore macOS daemon() depracation warning.
Tue, May 7, 13:56
Herald added a reviewer for D2954: Ignore macOS daemon() depracation warning: Restricted Project.
Tue, May 7, 00:10
Herald added a reviewer for D2953: Init: Remove redundant exit(EXIT_FAILURE) instances and replace with return false: Restricted Project.
Tue, May 7, 00:06

Mon, May 6

deadalnix committed rABCe77c51451d36: Backport dev notes on RPC (authored by Matt Corallo <git@bluematt.me>).
Backport dev notes on RPC
Mon, May 6, 23:06
deadalnix closed D2941: Backport dev notes on RPC.
Mon, May 6, 23:06
deadalnix committed rABC0b84b5e6f32a: Disallow using addresses in createmultisig (authored by Andrew Chow <achow101-github@achow101.com>).
Disallow using addresses in createmultisig
Mon, May 6, 22:34
deadalnix closed D2002: Disallow using addresses in createmultisig.
Mon, May 6, 22:34
deadalnix accepted D2926: blockfilter: Use unordered_set instead of set in blockfilter..
Mon, May 6, 21:14
deadalnix accepted D2942: Merge #10027: Set to nullptr after delete.
Mon, May 6, 21:12