- User Since
- May 14 2017, 13:52 (118 w, 5 d)
Thu, Aug 22
What steps did you take to make sure that this assert is unreachable?
Wed, Aug 21
Wed, Aug 14
Tue, Aug 13
Are you really confident you want to take ownership of this?
Mon, Aug 12
Sat, Aug 10
Fri, Aug 9
Thu, Aug 8
Wed, Aug 7
Tue, Aug 6
This breaks the set of warning when building standalone.
Make it version 7.x or something. From a major version to another, clang format do change how it formats some things.
Looks good overall, but it looks like there are leftovers.
There is a risk of collision doing it this way. Adding the hex code of the invalid character or something would be preferable. But this isn't meant to be used billions of time, so it can do for now.
Mon, Aug 5
The test plan is a mix of comments and command without distinction, which makes it impossible to follow.
f scope is narrowed, then the warning was removed from the rest of the codebase. This is a net negative.
Does this detect issues from D3795 ? In any case; this is good.
Sun, Aug 4
Sat, Aug 3
This kind of stuff should definitively have a linter. clang-tidy seems like good candidate.
Fri, Aug 2
Make sure we have strictly less than 32 pubkeys
Thu, Aug 1
bottom => first
Add mixed ECDSA/Schnorr test cases.
Fix various typos.
I don't see any point in removing warning for which the codebase is green.
Wed, Jul 31
Tue, Jul 30
Mon, Jul 29
You should consider changing the script to use a regex or something.
Fri, Jul 26
This doesn't look like it's going to be very useful if thins are working this way as we'll keep forgetting to add files in there.
Thu, Jul 25
There are 2 more instances in the codebase.
Rebase and clarify logic.
Jul 25 2019
Include stddef to get size_t
Make the size unsigned.
count => size