Page MenuHomePhabricator

deadalnix (Amaury SÉCHET)Administrator
User

Projects

User does not belong to any projects.

User Details

User Since
May 14 2017, 13:52 (88 w, 3 d)
Roles
Administrator

Recent Activity

Today

deadalnix committed rABCde824307ecc9: Initial implementation of RadixTree (authored by deadalnix).
Initial implementation of RadixTree
Wed, Jan 23, 17:02
deadalnix closed D2311: Initial implementation of RadixTree.
Wed, Jan 23, 17:02
deadalnix accepted D2387: Add a check-doc exception for -greatwallactivationtime.
Wed, Jan 23, 16:02
deadalnix accepted D2391: Add setter for g_initial_block_download_completed.
Wed, Jan 23, 14:45
deadalnix accepted D2392: Fix uninitialized g_connman crash in Shutdown().
Wed, Jan 23, 14:43
deadalnix added a comment to D2392: Fix uninitialized g_connman crash in Shutdown().

You should group these backports with the original patch you backport as to not leave master vulnerable.

Wed, Jan 23, 14:43
deadalnix requested changes to D2395: Cleanups for walletdir PR.

You forgot the angle brackets in wallet/walletutil.cpp

Wed, Jan 23, 14:42
deadalnix accepted D2375: Add function 'IsGreatWallEnabled'.
Wed, Jan 23, 00:39
deadalnix updated the diff for D2371: [Radix] Use RCUPtr to keep track of items in the tree.

Rebase on top of patches using the NULLPTR trick to make old versions of boost happy.

Wed, Jan 23, 00:19
deadalnix updated the diff for D2336: Implement delete function for the RadixTree.

Use the NULLPTR trick to make boost happy

Wed, Jan 23, 00:12

Yesterday

deadalnix updated the diff for D2311: Initial implementation of RadixTree.

Try to make boost happy.

Tue, Jan 22, 23:54
deadalnix accepted D2364: [tests] Rename feature_* functional tests..
Tue, Jan 22, 19:40
deadalnix added a parent revision for D2385: [Radix] Have the radix tree cleanup after itself: D2371: [Radix] Use RCUPtr to keep track of items in the tree.
Tue, Jan 22, 19:10
deadalnix added a child revision for D2371: [Radix] Use RCUPtr to keep track of items in the tree: D2385: [Radix] Have the radix tree cleanup after itself.
Tue, Jan 22, 19:09
Herald added a reviewer for D2385: [Radix] Have the radix tree cleanup after itself: Restricted Project.
Tue, Jan 22, 19:09
deadalnix requested changes to D2375: Add function 'IsGreatWallEnabled'.
Tue, Jan 22, 17:15
deadalnix added inline comments to D2375: Add function 'IsGreatWallEnabled'.
Tue, Jan 22, 17:14
deadalnix accepted D2382: Update timings.json.
Tue, Jan 22, 17:13
deadalnix accepted D2379: [tests] Rename p2p_* functional tests.
Tue, Jan 22, 17:13
deadalnix accepted D2380: [tests] Rename rpc_* functional tests.
Tue, Jan 22, 17:12
deadalnix accepted D2378: tests] Rename wallet_* functional tests.
Tue, Jan 22, 17:12
deadalnix accepted D2359: [tests] Move only: move NodeConnCB below NodeConn.
Tue, Jan 22, 17:11
deadalnix added a comment to D2373: add flags to VerifySignature and sigcache.

Just add friend class CSignatureCacheTest and define CSignatureCacheTest in the test and access whatever you want through it.

Tue, Jan 22, 15:23
deadalnix accepted D2318: Remove magnetic anomaly transitional code, activate on block height.
Tue, Jan 22, 15:06
deadalnix updated the diff for D2371: [Radix] Use RCUPtr to keep track of items in the tree.

Remove call to synchronize now that it is not needed as we use RCUPtr.

Tue, Jan 22, 02:18
deadalnix requested changes to D2375: Add function 'IsGreatWallEnabled'.
Tue, Jan 22, 01:38
deadalnix added a comment to D2373: add flags to VerifySignature and sigcache.

So the code looks good, but the new behavior is missing a test. You need to check that caching still works when flags like SCRIPT_VERIFY_MINIMALIF, but do hit a different key when SCRIPT_ENABLE_SCHNORR is passed.

Yes, I've been trying to think how to do this somehow. The only way to I can think of how to distinguish a correct cache hit from an unwanted cache miss would be to measure timing, or to add additional API that exposes the private cache. 🤔

Tue, Jan 22, 01:30
deadalnix added inline comments to D2375: Add function 'IsGreatWallEnabled'.
Tue, Jan 22, 01:22
deadalnix added inline comments to D2372: sighashtype: clarify subtle logic of isDefined().
Tue, Jan 22, 01:16
deadalnix updated the summary of D2376: Bump automatic replay protection to Nov 2019 upgrade.
Tue, Jan 22, 01:13
deadalnix requested changes to D2376: Bump automatic replay protection to Nov 2019 upgrade.

Marking as request change, even though there is really no change to be made, just to clear the review queue.

Tue, Jan 22, 01:13
deadalnix added a comment to D2376: Bump automatic replay protection to Nov 2019 upgrade.

This looks good to me but will need to wait for the release with the feature freeze.

Tue, Jan 22, 01:12
deadalnix updated the diff for D2336: Implement delete function for the RadixTree.

Add a synchronize after removing the element from the tree. As it turns out, we may delete the element we just inserted and have to ensure all other threads are past it for correctness. Not a hue deal because this code is going away anyways, but worth fixing for correctness.

Tue, Jan 22, 01:10
deadalnix requested changes to D2373: add flags to VerifySignature and sigcache.

So the code looks good, but the new behavior is missing a test. You need to check that caching still works when flags like SCRIPT_VERIFY_MINIMALIF, but do hit a different key when SCRIPT_ENABLE_SCHNORR is passed.

Tue, Jan 22, 01:05

Mon, Jan 21

deadalnix accepted D2367: [tests] define NODE_NETWORK_LIMITED in test framework.
Mon, Jan 21, 23:36
deadalnix updated the summary of D2367: [tests] define NODE_NETWORK_LIMITED in test framework.
Mon, Jan 21, 23:34
deadalnix accepted D2374: [tests] Fix tx padding.
Mon, Jan 21, 23:33
deadalnix committed rABC7f396108c438: [RCU] Add facility to register cleanup actions to be run when other thread… (authored by deadalnix).
[RCU] Add facility to register cleanup actions to be run when other thread…
Mon, Jan 21, 20:46
deadalnix closed D2317: [RCU] Add facility to register cleanup actions to be run when other thread catch up.
Mon, Jan 21, 20:46
deadalnix requested changes to D2373: add flags to VerifySignature and sigcache.
Mon, Jan 21, 20:44
deadalnix updated the diff for D2317: [RCU] Add facility to register cleanup actions to be run when other thread catch up.

Fix typo

Mon, Jan 21, 19:03
deadalnix accepted D2358: [tests] Tidy up mininode.
Mon, Jan 21, 18:03
deadalnix accepted D2370: [tests] refactor node_network_limited.
Mon, Jan 21, 17:35
deadalnix accepted D2369: [tests] remove redundant duplicate tests from node_network_limited.
Mon, Jan 21, 17:34
deadalnix accepted D2368: [tests] node_network_limited - remove race condition.
Mon, Jan 21, 17:33
deadalnix requested changes to D2367: [tests] define NODE_NETWORK_LIMITED in test framework.

The description is incorrect.

Mon, Jan 21, 17:32
deadalnix accepted D2366: [tests] fix flake8 warnings in node_network_limited.py.
Mon, Jan 21, 17:30
deadalnix requested changes to D2364: [tests] Rename feature_* functional tests..

You should split this up in several diffs.

Mon, Jan 21, 17:29
deadalnix accepted D2362: [tests] Rename NodeConn and NodeConnCB.
Mon, Jan 21, 17:25
deadalnix accepted D2361: [tests] Move version message sending from NodeConn to NodeConnCB.
Mon, Jan 21, 17:22
deadalnix committed rABC5158d7f79c63: [RCU] Use assert in tests instead of BOOST_CHECK when they aren't in the main… (authored by deadalnix).
[RCU] Use assert in tests instead of BOOST_CHECK when they aren't in the main…
Mon, Jan 21, 17:21
deadalnix closed D2365: [RCU] Use assert in tests instead of BOOST_CHECK when they aren't in the main thread..
Mon, Jan 21, 17:21
deadalnix accepted D2360: [tests] Make NodeConnCB a subclass of NodeConn.
Mon, Jan 21, 17:20
deadalnix requested changes to D2358: [tests] Tidy up mininode.
Mon, Jan 21, 17:02
deadalnix accepted D2357: [tests] Remove mininode periodic (half-hour) ping messages.
Mon, Jan 21, 17:00
deadalnix accepted D2356: qa: Only allow disconnecting all NodeConns.
Mon, Jan 21, 16:59
deadalnix accepted D2344: Clear container after move.
Mon, Jan 21, 16:57
deadalnix added a parent revision for D2351: [RCU] Implement equality check for RCUPtr: D2350: [RCU] Add new features to RCUPtr.
Mon, Jan 21, 16:57
deadalnix added a child revision for D2350: [RCU] Add new features to RCUPtr: D2351: [RCU] Implement equality check for RCUPtr.
Mon, Jan 21, 16:56
Herald added a reviewer for D2371: [Radix] Use RCUPtr to keep track of items in the tree: Restricted Project.
Mon, Jan 21, 16:56
deadalnix added a child revision for D2351: [RCU] Implement equality check for RCUPtr: D2371: [Radix] Use RCUPtr to keep track of items in the tree.
Mon, Jan 21, 16:56
deadalnix added a child revision for D2336: Implement delete function for the RadixTree: D2371: [Radix] Use RCUPtr to keep track of items in the tree.
Mon, Jan 21, 16:56
Herald added a reviewer for D2365: [RCU] Use assert in tests instead of BOOST_CHECK when they aren't in the main thread.: Restricted Project.
Mon, Jan 21, 15:54

Sun, Jan 20

deadalnix committed rSTAGING17f86abfcc73: [RCU] Use strong CAS where apropriate (authored by deadalnix).
[RCU] Use strong CAS where apropriate
Sun, Jan 20, 23:56
deadalnix committed rSTAGINGad6b32a3e039: Use callbacks to cache whether wallet transactions are in mempool (authored by Matt Corallo <git@bluematt.me>).
Use callbacks to cache whether wallet transactions are in mempool
Sun, Jan 20, 23:56
deadalnix committed rSTAGINGef7ab2674294: Add calls to CWallet::BlockUntilSyncedToCurrentChain() in RPCs (authored by Matt Corallo <git@bluematt.me>).
Add calls to CWallet::BlockUntilSyncedToCurrentChain() in RPCs
Sun, Jan 20, 23:56
deadalnix committed rSTAGINGa428e37c8181: Various nits in the RCU mechanism (authored by deadalnix).
Various nits in the RCU mechanism
Sun, Jan 20, 23:56
deadalnix committed rSTAGINGf2de2629d33b: Upgrade clang-format to 7.0 (authored by deadalnix).
Upgrade clang-format to 7.0
Sun, Jan 20, 23:56
deadalnix committed rSTAGINGf2d83c807cab: [RCU] Interlock synchronize operation when there is contention (authored by deadalnix).
[RCU] Interlock synchronize operation when there is contention
Sun, Jan 20, 23:55
deadalnix committed rSTAGING9189d17f97d3: Implement RCU synchronization mechanism (authored by deadalnix).
Implement RCU synchronization mechanism
Sun, Jan 20, 23:55
deadalnix committed rSTAGING2733a57797f8: Update seeds (authored by deadalnix).
Update seeds
Sun, Jan 20, 23:55
deadalnix committed rSTAGINGcfc45879eb59: Add CWallet::BlockUntilSyncedToCurrentChain() (authored by Matt Corallo <git@bluematt.me>).
Add CWallet::BlockUntilSyncedToCurrentChain()
Sun, Jan 20, 23:55
deadalnix committed rSTAGINGd539b4ec5514: Add CallFunctionInQueue to wait on validation interface queue drain (authored by Matt Corallo <git@bluematt.me>).
Add CallFunctionInQueue to wait on validation interface queue drain
Sun, Jan 20, 23:55
deadalnix committed rSTAGINGd67b63b09437: Call TransactionRemovedFromMempool in the CScheduler thread (authored by Matt Corallo <git@bluematt.me>).
Call TransactionRemovedFromMempool in the CScheduler thread
Sun, Jan 20, 23:55
deadalnix committed rSTAGING8b4b0382782c: Add a CValidationInterface::TransactionRemovedFromMempool (authored by Matt Corallo <git@bluematt.me>).
Add a CValidationInterface::TransactionRemovedFromMempool
Sun, Jan 20, 23:55
deadalnix committed rSTAGING2af3fdb645f2: break circular dependency: random/sync -> util -> random/sync (authored by Chun Kuan Lee <ken2812221@gmail.com>).
break circular dependency: random/sync -> util -> random/sync
Sun, Jan 20, 23:55
deadalnix committed rSTAGING3db2f5fe86eb: Use information stored in TestNode to connect nodes via p2p and RPC (authored by deadalnix).
Use information stored in TestNode to connect nodes via p2p and RPC
Sun, Jan 20, 23:55
deadalnix committed rSTAGINGba12b8e01f69: [avalanche] Add some safety to AvalancheBlockUpdate using static asserts (authored by deadalnix).
[avalanche] Add some safety to AvalancheBlockUpdate using static asserts
Sun, Jan 20, 23:54
deadalnix committed rSTAGINGe1512648c212: Apply lint on all files (authored by deadalnix).
Apply lint on all files
Sun, Jan 20, 23:54
deadalnix committed rSTAGINGa9325353e2b7: Nits in src/qt/init.cpp (authored by schancel).
Nits in src/qt/init.cpp
Sun, Jan 20, 23:54
deadalnix committed rSTAGING951cef9ded2a: Add a local variable for the rpc port (authored by deadalnix).
Add a local variable for the rpc port
Sun, Jan 20, 23:54
deadalnix committed rSTAGING6f0329fdf657: Store the value of the P2P port used in each TestNode instances (authored by deadalnix).
Store the value of the P2P port used in each TestNode instances
Sun, Jan 20, 23:54
deadalnix committed rSTAGINGcec5bc1110a0: Store the node name as a local variable rather than recomputing it every time… (authored by deadalnix).
Store the node name as a local variable rather than recomputing it every time…
Sun, Jan 20, 23:54
deadalnix committed rSTAGINGe51b7e90f6c6: Regenerate timing.json (authored by deadalnix).
Regenerate timing.json
Sun, Jan 20, 23:54
deadalnix committed rSTAGING9dde3da1bac9: Remove check for thread_local in build systems (authored by deadalnix).
Remove check for thread_local in build systems
Sun, Jan 20, 23:54
deadalnix committed rSTAGING8787bfd34ea4: [qa] Change connect_nodes_bi API to not assume an array of nodes. (authored by deadalnix).
[qa] Change connect_nodes_bi API to not assume an array of nodes.
Sun, Jan 20, 23:53
deadalnix committed rSTAGINGd1cf448cabaa: Do not validate TTOR anymore (authored by deadalnix).
Do not validate TTOR anymore
Sun, Jan 20, 23:53
deadalnix committed rSTAGING9237f5963ce4: Update disconnect_nodes API so it does take the node object directly (authored by deadalnix).
Update disconnect_nodes API so it does take the node object directly
Sun, Jan 20, 23:53
deadalnix committed rSTAGINGa9bed00cfd4f: Update connect_nodes API so it does take the node object directly (authored by deadalnix).
Update connect_nodes API so it does take the node object directly
Sun, Jan 20, 23:53
deadalnix committed rSTAGING295ecf0ab9de: Use tobytes instead of tostring in netutil.py (authored by deadalnix).
Use tobytes instead of tostring in netutil.py
Sun, Jan 20, 23:53
deadalnix committed rSTAGING7f7f55cc7216: [avalanche] Add the concept of inconclusive votes (authored by deadalnix).
[avalanche] Add the concept of inconclusive votes
Sun, Jan 20, 23:52
deadalnix committed rSTAGINGc7b844fb409d: [avalanche] Use black magic for popcount. (authored by deadalnix).
[avalanche] Use black magic for popcount.
Sun, Jan 20, 23:52
deadalnix added a comment to D2354: Renamed TestBuilder.Push( string hex ) to .PushHex( string hex ).

I don't understand what this task is about. What is inconsistent ? Why is this naming more consistent ? Who's going to maintain that test going forward ?

Sun, Jan 20, 23:11
Herald added a reviewer for D2352: [RCU] Make RCUPtr compatible with const payloads.: Restricted Project.
Sun, Jan 20, 22:16
deadalnix added a child revision for D2350: [RCU] Add new features to RCUPtr: D2352: [RCU] Make RCUPtr compatible with const payloads..
Sun, Jan 20, 22:16
deadalnix added inline comments to D2347: API renames of script signature functions to mention ECDSA.
Sun, Jan 20, 19:20
Herald added a reviewer for D2351: [RCU] Implement equality check for RCUPtr: Restricted Project.
Sun, Jan 20, 19:17
deadalnix added a parent revision for D2350: [RCU] Add new features to RCUPtr: D2340: [RCU] Implement RCUPtr, a smart pointer that free asynchronousely when other threads did synchronize..
Sun, Jan 20, 17:55
deadalnix added a child revision for D2340: [RCU] Implement RCUPtr, a smart pointer that free asynchronousely when other threads did synchronize.: D2350: [RCU] Add new features to RCUPtr.
Sun, Jan 20, 17:55
Herald added a reviewer for D2350: [RCU] Add new features to RCUPtr: Restricted Project.
Sun, Jan 20, 17:54