Page MenuHomePhabricator

deadalnix (Amaury SÉCHET)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
May 14 2017, 13:52 (149 w, 6 d)
Roles
Administrator

Recent Activity

Fri, Mar 27

deadalnix committed rABC98369fa6fd64: [secp256k1] Install all packages in travis (authored by deadalnix).
[secp256k1] Install all packages in travis
Fri, Mar 27, 15:28
deadalnix closed D5589: [secp256k1] Install all packages in travis.
Fri, Mar 27, 15:27
deadalnix updated the diff for D5589: [secp256k1] Install all packages in travis.

Make sure that the opposite of no is indeed gmp.

Fri, Mar 27, 15:18
deadalnix retitled D5589: [secp256k1] Install all packages in travis from [secp256k1] Install all packes in travis to [secp256k1] Install all packages in travis.
Fri, Mar 27, 15:10
deadalnix accepted D5590: [SECP256K1] Turn off ASM by default on target with no ASM support.
Fri, Mar 27, 15:09
deadalnix updated the diff for D5589: [secp256k1] Install all packages in travis.

Make bignum explicitely yes and remove install directive

Fri, Mar 27, 14:31
deadalnix created D5589: [secp256k1] Install all packages in travis.
Fri, Mar 27, 14:26
deadalnix accepted D5588: [SECP256K1] Fix Travis missing ninja.
Fri, Mar 27, 13:55
deadalnix requested changes to D5490: [SECP256K1] turn NativeSecp256k1 class into a regular class.

I'm sorry, but I don't buy the finalization argument, mostly because it's not an argument. I've seen enough cultish behavior in this industry to know people will say you shouldn't do X or must do Y the Z way with absolutely no reason whatsoever and it often turns out to be a bad idea. If there is a reason to not do it, then people should be able to state it and we should be able to assert why it applies or not to our current situation. Every time someone brings up that this is the "the way" without providing a proper rationale, this is only a stronger reason to dismiss this concern.

Fri, Mar 27, 13:34

Thu, Mar 26

deadalnix accepted D5582: Merge #14813: qa: Add wallet_encryption error tests.
Thu, Mar 26, 23:19
deadalnix accepted D5581: Add missing softforks help text to getblockchaininfo.
Thu, Mar 26, 23:16
deadalnix updated the diff for D5580: Constant-time behaviour test using valgrind memtest..

Fix travis

Thu, Mar 26, 18:07
deadalnix created D5580: Constant-time behaviour test using valgrind memtest..
Thu, Mar 26, 18:02
deadalnix committed rABC46e449e05795: Eliminate harmless non-constant time operations on secret data. (authored by Gregory Maxwell <greg@xiph.org>).
Eliminate harmless non-constant time operations on secret data.
Thu, Mar 26, 16:33
deadalnix closed D5524: Eliminate harmless non-constant time operations on secret data..
Thu, Mar 26, 16:32
deadalnix accepted D5573: [depends] Don't build libevent sample code.
Thu, Mar 26, 15:13
deadalnix committed rABC0bd04e38c10b: [avalanche] sign avaresponse (authored by deadalnix).
[avalanche] sign avaresponse
Thu, Mar 26, 14:56
deadalnix closed D5537: [avalanche] sign avaresponse.
Thu, Mar 26, 14:56
deadalnix added inline comments to D5571: Merge #14796: rpc: Pass argument descriptions to RPCHelpMan.
Thu, Mar 26, 01:53
deadalnix added a comment to D5571: Merge #14796: rpc: Pass argument descriptions to RPCHelpMan.
Thu, Mar 26, 01:51
deadalnix requested changes to D5571: Merge #14796: rpc: Pass argument descriptions to RPCHelpMan.
Thu, Mar 26, 01:50
deadalnix added inline comments to D5537: [avalanche] sign avaresponse.
Thu, Mar 26, 01:39
deadalnix updated the diff for D5537: [avalanche] sign avaresponse.

Address comments

Thu, Mar 26, 00:22

Wed, Mar 25

deadalnix accepted D5562: Return a status enum from ScanForWalletTransactions.
Wed, Mar 25, 23:58
deadalnix accepted D5557: qt: test: Create at most one testing setup.
Wed, Mar 25, 23:49
deadalnix accepted D5531: build: macOS toolchain update.
Wed, Mar 25, 23:48
deadalnix committed rABCed15a61e72c8: [avalanche] Fix test when ran without wallet (authored by deadalnix).
[avalanche] Fix test when ran without wallet
Wed, Mar 25, 22:54
deadalnix closed D5568: [avalanche] Fix test when ran without wallet.
Wed, Mar 25, 22:54
deadalnix created D5568: [avalanche] Fix test when ran without wallet.
Wed, Mar 25, 19:46
deadalnix committed rABCfe0c8d1c3766: [avalanche] Add handling of ava_poll command in the network layer (authored by deadalnix).
[avalanche] Add handling of ava_poll command in the network layer
Wed, Mar 25, 19:02
deadalnix closed D5528: [avalanche] Add handling of ava_poll command in the network layer.
Wed, Mar 25, 19:02
deadalnix accepted D5564: wallet: Initialize stop_block to nullptr in ScanForWalletTransactions.
Wed, Mar 25, 19:02
deadalnix requested changes to D5562: Return a status enum from ScanForWalletTransactions.
Wed, Mar 25, 18:59
deadalnix accepted D5563: Add stop_block out arg to ScanForWalletTransactions.
Wed, Mar 25, 18:58
deadalnix accepted D5562: Return a status enum from ScanForWalletTransactions.
Wed, Mar 25, 18:56
deadalnix accepted D5561: Make CWallet::ScanForWalletTransactions args and return value const.
Wed, Mar 25, 18:41
deadalnix accepted D5553: util: Log early messages.
Wed, Mar 25, 18:40
deadalnix updated the diff for D5537: [avalanche] sign avaresponse.

Update

Wed, Mar 25, 18:40
deadalnix accepted D5560: wallet: Avoid leaking nLockTime fingerprint when anti-fee-sniping.
Wed, Mar 25, 18:38

Tue, Mar 24

deadalnix updated the diff for D5528: [avalanche] Add handling of ava_poll command in the network layer.

Address comments

Tue, Mar 24, 18:12
deadalnix added inline comments to D5528: [avalanche] Add handling of ava_poll command in the network layer.
Tue, Mar 24, 17:28
deadalnix requested changes to D5553: util: Log early messages.
Tue, Mar 24, 13:47
deadalnix accepted D5546: Fixup paths in wallet_multiwallet.
Tue, Mar 24, 09:21
deadalnix committed rABCa56ad26ff18b: [schnorr] Add verification routine to the test framework schnorr signature… (authored by deadalnix).
[schnorr] Add verification routine to the test framework schnorr signature…
Tue, Mar 24, 08:38
deadalnix closed D5536: [schnorr] Add verification routine to the test framework schnorr signature facility.
Tue, Mar 24, 08:38

Mon, Mar 23

deadalnix added inline comments to D5528: [avalanche] Add handling of ava_poll command in the network layer.
Mon, Mar 23, 19:21
deadalnix accepted D5535: Add another UBSAN vptr suppression.
Mon, Mar 23, 01:20
deadalnix created D5537: [avalanche] sign avaresponse.
Mon, Mar 23, 01:18
deadalnix created D5536: [schnorr] Add verification routine to the test framework schnorr signature facility.
Mon, Mar 23, 00:31

Sun, Mar 22

deadalnix updated the diff for D5528: [avalanche] Add handling of ava_poll command in the network layer.

Remove leftover print

Sun, Mar 22, 18:12
deadalnix added a comment to D5534: Revert "Merge #14291: wallet: Add ListWalletDir utility function".

So I test with clang 8, clang 8 and gcc 9 and I cannot repro. This suggest that this is a problem with the CI and that it should be fixed there - or that there is something the CI is doing that we are not, in which case we also need to know.

Sun, Mar 22, 16:18
deadalnix requested changes to D5534: Revert "Merge #14291: wallet: Add ListWalletDir utility function".

Well, what's the log of the bitcoind process? Why did it exit?

Sun, Mar 22, 15:03

Sat, Mar 21

deadalnix requested changes to D5534: Revert "Merge #14291: wallet: Add ListWalletDir utility function".

This still doesn't say what the problem is.

Sat, Mar 21, 23:09
deadalnix committed rABC810bc41bb400: Nits in rwcollection.h (authored by deadalnix).
Nits in rwcollection.h
Sat, Mar 21, 23:08
deadalnix closed D5533: Nits in rwcollection.h.
Sat, Mar 21, 23:08
deadalnix requested changes to D5534: Revert "Merge #14291: wallet: Add ListWalletDir utility function".

Can you provide a reason in the description?

Sat, Mar 21, 18:13
deadalnix added a comment to D5534: Revert "Merge #14291: wallet: Add ListWalletDir utility function".

Why?

Sat, Mar 21, 18:08
deadalnix created D5533: Nits in rwcollection.h.
Sat, Mar 21, 17:05
deadalnix committed rABC86e9f1f2e9c6: Update autotools for new seeder tests (authored by nakihito).
Update autotools for new seeder tests
Sat, Mar 21, 14:48
deadalnix closed D5529: Update autotools for new seeder tests.
Sat, Mar 21, 14:48
deadalnix added inline comments to D5531: build: macOS toolchain update.
Sat, Mar 21, 14:34
deadalnix accepted D5530: Fix the OSX gitian build.
Sat, Mar 21, 14:32
deadalnix accepted D5532: Fix the CI gitian build script when the OSX SDK is should be downloaded.
Sat, Mar 21, 14:32
deadalnix updated the diff for D5528: [avalanche] Add handling of ava_poll command in the network layer.

Remove unecesary include

Sat, Mar 21, 02:44
deadalnix created D5528: [avalanche] Add handling of ava_poll command in the network layer.
Sat, Mar 21, 02:21
deadalnix accepted D5469: Add some unit tests for write_name() for seeder.
Sat, Mar 21, 00:39
deadalnix accepted D5527: Merge #14291: wallet: Add ListWalletDir utility function.
Sat, Mar 21, 00:20
deadalnix added inline comments to D5490: [SECP256K1] turn NativeSecp256k1 class into a regular class.
Sat, Mar 21, 00:15

Fri, Mar 20

deadalnix requested changes to D5490: [SECP256K1] turn NativeSecp256k1 class into a regular class.

There is still no finalizer for that class unless I messed it, which means context will be leaked when things are garbage collected.

Fri, Mar 20, 19:28
deadalnix accepted D5520: Some left overs from PR12490.
Fri, Mar 20, 19:18
deadalnix accepted D5525: [CMAKE] Fix the bench build for windows.
Fri, Mar 20, 19:17
deadalnix accepted D5526: Remove unused misc.h.
Fri, Mar 20, 17:41
deadalnix requested changes to D5525: [CMAKE] Fix the bench build for windows.

If event needs ws2_32 on some plateform, then it needs it on some plateforms. This needs to be part of the fix.

Fri, Mar 20, 17:36
deadalnix requested changes to D5520: Some left overs from PR12490.

Test plan is inadequate.

Fri, Mar 20, 17:12
deadalnix accepted D5518: Merge #14208: [build] Actually remove ENABLE_WALLET.
Fri, Mar 20, 17:12
deadalnix requested changes to D5525: [CMAKE] Fix the bench build for windows.

Event requires lib ws2_32 on windows

Fri, Mar 20, 17:06
deadalnix accepted D5517: Merge #14373: Consistency fixes for RPC descriptions.
Fri, Mar 20, 00:41
deadalnix created D5524: Eliminate harmless non-constant time operations on secret data..
Fri, Mar 20, 00:37
deadalnix committed rABCc631b912b1e7: [cmake] Fix typo in error message (authored by deadalnix).
[cmake] Fix typo in error message
Fri, Mar 20, 00:20
deadalnix closed D5521: [cmake] Fix typo in error message.
Fri, Mar 20, 00:20
deadalnix requested changes to D5518: Merge #14208: [build] Actually remove ENABLE_WALLET.

The test plan is inadequate.

Fri, Mar 20, 00:19
deadalnix accepted D5523: Merge #14718: Remove unreferenced boost headers.
Fri, Mar 20, 00:18
deadalnix requested changes to D5522: Fix linking in bitcoin-bench for Windows build.

This is obviously wrong. The fact that it happens to work doesn't make it right.

Fri, Mar 20, 00:17

Thu, Mar 19

deadalnix created D5521: [cmake] Fix typo in error message.
Thu, Mar 19, 23:28
deadalnix accepted D5514: build: set minimum supported macOS to 10.12.
Thu, Mar 19, 17:31
deadalnix accepted D5513: depends: switch to secure download of all dependencies.
Thu, Mar 19, 14:49
deadalnix accepted D5512: Delete README_osx.md and move its contents into build-osx.md.
Thu, Mar 19, 14:49
deadalnix requested changes to D5321: [CMAKE] Add support for generating test coverage reports.
Thu, Mar 19, 14:10
deadalnix requested changes to D5490: [SECP256K1] turn NativeSecp256k1 class into a regular class.

Theres also fixing cloneContext, which IMO should result in returning a new NativeSecp256k1 class with the cloned native lib context in, but i was hoping to fix that on another ticket.

Thu, Mar 19, 14:02
deadalnix requested changes to D5321: [CMAKE] Add support for generating test coverage reports.
Thu, Mar 19, 13:24
deadalnix accepted D5504: [depends] expat 2.2.5, miniupnpc 2.0.20180203.
Thu, Mar 19, 13:17
deadalnix accepted D4627: qa: Add test/fuzz/test_runner.py.
Thu, Mar 19, 13:16
deadalnix accepted D5499: Make the fuzzer test runner compatible with cmake.
Thu, Mar 19, 13:15
deadalnix requested changes to D5499: Make the fuzzer test runner compatible with cmake.

Looks like there is some duplication with the test runner.

Thu, Mar 19, 00:39
deadalnix requested changes to D4627: qa: Add test/fuzz/test_runner.py.
Thu, Mar 19, 00:38
deadalnix requested changes to D5490: [SECP256K1] turn NativeSecp256k1 class into a regular class.

This is leaking. Note that it was already leaking, indeed, but because everything was static, the application would just leak one context and voila. Now it can leak n contexts, and this is bad. There is also a problem of error management when the context is created or used. This also is preexisting, but one can assume that creating one context at program startup is less likely to fail (for instance due to OOM) than when the java app is up and runnign and eating 16GB of RAM, like all self respecting java apps do.

Thu, Mar 19, 00:33
deadalnix requested changes to D5321: [CMAKE] Add support for generating test coverage reports.

Well then, if it is a build type, then it is a build type, no? Not an option.

Thu, Mar 19, 00:16
deadalnix requested changes to D5504: [depends] expat 2.2.5, miniupnpc 2.0.20180203.
Thu, Mar 19, 00:14

Wed, Mar 18

deadalnix accepted D5480: [SECP256K1] CMake: Build the ARM ASM field implementation.
Wed, Mar 18, 16:53
deadalnix accepted D5500: Add a script for setting up Debian build containers.
Wed, Mar 18, 16:51