Page MenuHomePhabricator

deadalnix (Amaury SÉCHET)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
May 14 2017, 13:52 (118 w, 5 d)
Roles
Administrator

Recent Activity

Yesterday

deadalnix accepted D3936: Disable wallet and address book Qt tests on macOS minimal platform.
Fri, Aug 23, 15:04
deadalnix accepted D3931: Merge #12561: Check for block corruption in ConnectBlock().
Fri, Aug 23, 15:03

Thu, Aug 22

deadalnix requested changes to D3935: Merge #11411: script: Change SignatureHash input index check to an assert..

What steps did you take to make sure that this assert is unreachable?

Thu, Aug 22, 18:16
deadalnix accepted D3925: Docs: Add disable-wallet section to OSX build instructions.
Thu, Aug 22, 18:04
deadalnix accepted D3926: Various textual improvements in build docs.
Thu, Aug 22, 18:03
deadalnix accepted D3927: Remove the ZMQ example for Python 2.
Thu, Aug 22, 18:02
deadalnix accepted D3928: Add python3 script shebang lint.
Thu, Aug 22, 18:02
deadalnix added inline comments to D3936: Disable wallet and address book Qt tests on macOS minimal platform.
Thu, Aug 22, 18:01

Wed, Aug 21

deadalnix accepted D3929: Remove Qt4 from the OSX build documentation.
Wed, Aug 21, 19:22
deadalnix added inline comments to D3930: trivial: Improve include comment in src/interfaces/wallet.h.
Wed, Aug 21, 19:22

Wed, Aug 14

deadalnix added a comment to D3834: [TRIVIAL] Cleanup the JNI test file.
In D3834#90773, @Fabien wrote:

@deadalnix It's already the case, see D2681 or D2755. Also I have D3835 that will take ownership even more, but make your life easier for testing with buster.

Wed, Aug 14, 05:02
deadalnix accepted D3867: Merge #13188: qa: Remove unused option --srcdir.
Wed, Aug 14, 04:58

Tue, Aug 13

deadalnix added a comment to D3834: [TRIVIAL] Cleanup the JNI test file.

Are you really confident you want to take ownership of this?

Tue, Aug 13, 06:03

Mon, Aug 12

deadalnix accepted D3827: [CMAKE] Make secp256k1 build standalone.
Mon, Aug 12, 05:57
deadalnix accepted D3844: Merge #11617: Avoid lock: Call FlushStateToDisk(...) regardless of fCheckForPruning.
Mon, Aug 12, 05:32

Sat, Aug 10

deadalnix accepted D3849: Merge #11573: [Util] Update tinyformat.h.
Sat, Aug 10, 05:36
deadalnix accepted D3850: Merge #12969: Drop dead code CScript::Find.
Sat, Aug 10, 05:34

Fri, Aug 9

deadalnix accepted D3823: build: Enable -Wredundant-decls where available.
Fri, Aug 9, 05:20

Thu, Aug 8

deadalnix accepted D3806: Enforce clang-format version 7.x.
Thu, Aug 8, 05:37

Wed, Aug 7

deadalnix accepted D3813: Merge #12797: init: Fix help message for checkblockindex.
Wed, Aug 7, 04:28
deadalnix accepted D3811: better error message for mandatory-flag tx rejections.
Wed, Aug 7, 03:44

Tue, Aug 6

deadalnix added a comment to D3798: [CMAKE] Refactor warnings for secp256k1.

This breaks the set of warning when building standalone.

Tue, Aug 6, 16:48
deadalnix accepted D3802: [CMAKE] Refactor the AddCompilerFlags facilities.
Tue, Aug 6, 16:15
deadalnix accepted D3807: Fix some more copies in loops.
Tue, Aug 6, 16:14
deadalnix requested changes to D3806: Enforce clang-format version 7.x.

Make it version 7.x or something. From a major version to another, clang format do change how it formats some things.

Tue, Aug 6, 16:13
deadalnix requested changes to D3802: [CMAKE] Refactor the AddCompilerFlags facilities.

Looks good overall, but it looks like there are leftovers.

Tue, Aug 6, 06:24
deadalnix requested changes to D3805: Merge #12716: Fix typos and cleanup in various files.
Tue, Aug 6, 06:16
deadalnix accepted D3805: Merge #12716: Fix typos and cleanup in various files.
Tue, Aug 6, 06:14
deadalnix accepted D3799: [CMAKE] Enable -Wthread-safety-analysis.
Tue, Aug 6, 06:13
deadalnix accepted D3800: [CMAKE] Avoid warning when checking flags.

There is a risk of collision doing it this way. Adding the hex code of the invalid character or something would be preferable. But this isn't meant to be used billions of time, so it can do for now.

Tue, Aug 6, 05:54

Mon, Aug 5

deadalnix requested changes to D3732: Added a script to generate chainparams intermediate files.
Mon, Aug 5, 07:04
deadalnix added a comment to D3732: Added a script to generate chainparams intermediate files.

The test plan is a mix of comments and command without distinction, which makes it impossible to follow.

Mon, Aug 5, 06:58
deadalnix added inline comments to D3732: Added a script to generate chainparams intermediate files.
Mon, Aug 5, 06:14
deadalnix accepted D3770: [tests] simplify binary and hex response parsing in interface_rest.py.
Mon, Aug 5, 06:11
deadalnix accepted D3769: [tests] only use 2 nodes in interface_rest.py.
Mon, Aug 5, 06:10
deadalnix accepted D3768: [tests] refactor interface_rest.py to avoid code repetition.
Mon, Aug 5, 06:09
deadalnix accepted D3767: [tests] Make json request building more consistent in interface_rest.py.
Mon, Aug 5, 06:04
deadalnix accepted D3766: [tests] improve logging and documentation in interface_rest.py.
Mon, Aug 5, 06:03
deadalnix requested changes to D3786: [CMAKE] Make warnings the same with cmake and autotools.

f scope is narrowed, then the warning was removed from the rest of the codebase. This is a net negative.

Mon, Aug 5, 05:45
deadalnix accepted D3789: Merge #12225: Mempool cleanups.
Mon, Aug 5, 05:43
deadalnix accepted D3793: macOS: Prevent Xcode 9.3 build warnings.
Mon, Aug 5, 05:40
deadalnix accepted D3792: [CMAKE] Improve link flag compiler support detection.
Mon, Aug 5, 05:24
deadalnix accepted D3796: Avoid copies in range-for loops and add a warning to detect them.

Does this detect issues from D3795 ? In any case; this is good.

Mon, Aug 5, 05:11
deadalnix accepted D3791: [CMAKE] Fix OSX native build.
Mon, Aug 5, 05:10

Sun, Aug 4

deadalnix accepted D3764: [REST] Handle UTXO retrieval when ignoring the mempool.
Sun, Aug 4, 08:06
deadalnix accepted D3771: tests/tools: Enable additional Python flake8 rules for automatic linting.
Sun, Aug 4, 08:05
deadalnix accepted D3784: Fix missing lock in denialofservice_tests.
Sun, Aug 4, 08:04
deadalnix accepted D3711: Merge #12118: Sort mempool by min(feerate, ancestor_feerate).
Sun, Aug 4, 08:01
deadalnix accepted D3759: [tests] Make rpcauth.py testable and add unit tests.
Sun, Aug 4, 07:58

Sat, Aug 3

deadalnix added inline comments to D3759: [tests] Make rpcauth.py testable and add unit tests.
Sat, Aug 3, 07:24
deadalnix accepted D3795: scripted-diff: Avoid temporary copies when looping over std::map.

This kind of stuff should definitively have a linter. clang-tidy seems like good candidate.

Sat, Aug 3, 07:21
deadalnix accepted D3794: Add a message to static_assert.
Sat, Aug 3, 07:20

Fri, Aug 2

deadalnix accepted D3763: MINIMALDATA consensus activation.
Fri, Aug 2, 00:49
deadalnix accepted D3757: Use a regex to determine the list of sources for check-rpc-mappings.
Fri, Aug 2, 00:40
deadalnix accepted D3736: New Schnorr multisig activation.
Fri, Aug 2, 00:36
deadalnix committed rABCfbb292307a62: Implement new checkmultisig trigger logic and execution logic. (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).
Implement new checkmultisig trigger logic and execution logic.
Fri, Aug 2, 00:24
deadalnix closed D3474: Implement new checkmultisig trigger logic and execution logic..
Fri, Aug 2, 00:24
deadalnix updated the diff for D3474: Implement new checkmultisig trigger logic and execution logic..

Make sure we have strictly less than 32 pubkeys

Fri, Aug 2, 00:18
deadalnix accepted D3783: Fix -Wthread-safety-analysis warnings.
Fri, Aug 2, 00:08
deadalnix added inline comments to D3792: [CMAKE] Improve link flag compiler support detection.
Fri, Aug 2, 00:01
deadalnix requested changes to D3792: [CMAKE] Improve link flag compiler support detection.
Fri, Aug 2, 00:00

Thu, Aug 1

deadalnix updated the diff for D3474: Implement new checkmultisig trigger logic and execution logic..

bottom => first

Thu, Aug 1, 23:43
deadalnix updated the diff for D3474: Implement new checkmultisig trigger logic and execution logic..

Add mixed ECDSA/Schnorr test cases.
Fix various typos.

Thu, Aug 1, 23:31
deadalnix requested changes to D3786: [CMAKE] Make warnings the same with cmake and autotools.

I don't see any point in removing warning for which the codebase is green.

Thu, Aug 1, 06:21
deadalnix accepted D3782: rpcauth: Improve by using argparse and getpass modules.
Thu, Aug 1, 06:19
deadalnix accepted D3781: Properly generate salt in rpcauth.py, update tests.
Thu, Aug 1, 06:18
deadalnix accepted D3780: rpcauth: Make it possible to provide a custom password.
Thu, Aug 1, 06:17
deadalnix accepted D3779: Tests: add usage note to check-rpc-mappings.py.
Thu, Aug 1, 06:16
deadalnix requested changes to D3759: [tests] Make rpcauth.py testable and add unit tests.
Thu, Aug 1, 06:16
deadalnix accepted D3756: RPC: Introduce getblockstats to plot things.
Thu, Aug 1, 06:12
deadalnix accepted D3755: Refactor: RPC: Separate GetBlockChecked() from getblock().
Thu, Aug 1, 06:11

Wed, Jul 31

deadalnix accepted D3758: test: Add rpcauth pair that generated by rpcauth.
Wed, Jul 31, 18:25
deadalnix accepted D3785: bench: Don't return a bool from main.
Wed, Jul 31, 18:21
deadalnix accepted D3787: build: split warnings out of CXXFLAGS.
Wed, Jul 31, 18:21
deadalnix accepted D3788: When build fails due to lib missing, indicate which one.
Wed, Jul 31, 18:20

Tue, Jul 30

deadalnix accepted D3772: Add linter: Make sure we explicitly open all text files using UTF-8.
Tue, Jul 30, 21:02
deadalnix accepted D3765: [tests] fix flake8 warnings in interface_rest.py test.
Tue, Jul 30, 21:01

Mon, Jul 29

deadalnix accepted D3751: Add src/rpc/abc.cpp to the files checked by check-rpc-mappings.

You should consider changing the script to use a regex or something.

Mon, Jul 29, 00:32

Fri, Jul 26

deadalnix accepted D3753: Fix nits in blockchain.cpp RPC table.
Fri, Jul 26, 14:29
deadalnix added a comment to D3751: Add src/rpc/abc.cpp to the files checked by check-rpc-mappings.

This doesn't look like it's going to be very useful if thins are working this way as we'll keep forgetting to add files in there.

Fri, Jul 26, 13:53
deadalnix accepted D3752: [LINTER] Integrate check-rpc-mappings to arcanist.
Fri, Jul 26, 13:32
deadalnix added inline comments to D3749: [CI] Enable the undefined behaviour sanitizer.
Fri, Jul 26, 13:31

Thu, Jul 25

deadalnix requested changes to D3750: Merge #12159: Use the character based overload for std::string::find..

There are 2 more instances in the codebase.

Thu, Jul 25, 23:43
deadalnix accepted D3748: Merge #12431: Only call NotifyBlockTip when chainActive changes.
Thu, Jul 25, 23:41
deadalnix updated the diff for D3474: Implement new checkmultisig trigger logic and execution logic..

Rebase and clarify logic.

Thu, Jul 25, 23:39
deadalnix commandeered D3474: Implement new checkmultisig trigger logic and execution logic..
Thu, Jul 25, 23:38
deadalnix accepted D3745: Bump version to 0.19.12.
Thu, Jul 25, 18:37
deadalnix accepted D3743: Update manpages for 0.19.11 release.
Thu, Jul 25, 17:17
deadalnix accepted D3737: Add phpcs to the code formatting tools in the CONTRIBUTING document.
Thu, Jul 25, 17:16
deadalnix accepted D3744: Updated seeds.
Thu, Jul 25, 17:16
deadalnix accepted D3739: Fix undefined behavior in rcu_tests.
Thu, Jul 25, 17:16
deadalnix accepted D3742: Update chainparams.
Thu, Jul 25, 17:03
deadalnix committed rABCa5124feb0e30: Make countBits available to the whole codebase (authored by deadalnix).
Make countBits available to the whole codebase
Thu, Jul 25, 17:01
deadalnix closed D3738: Make countBits available to the whole codebase.
Thu, Jul 25, 17:01

Jul 25 2019

deadalnix committed rABC9364c3a392e7: Add a facility to parse and validate script bitfields. (authored by deadalnix).
Add a facility to parse and validate script bitfields.
Jul 25 2019, 13:21
deadalnix closed D3735: Add a facility to parse and validate script bitfields..
Jul 25 2019, 13:21
deadalnix created D3738: Make countBits available to the whole codebase.
Jul 25 2019, 13:02
deadalnix updated the diff for D3735: Add a facility to parse and validate script bitfields..

Include stddef to get size_t

Jul 25 2019, 10:59
deadalnix updated the diff for D3735: Add a facility to parse and validate script bitfields..

Make the size unsigned.
count => size

Jul 25 2019, 10:38
deadalnix added inline comments to D3735: Add a facility to parse and validate script bitfields..
Jul 25 2019, 10:35