Page MenuHomePhabricator

deadalnix (Amaury SÉCHET)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
May 14 2017, 13:52 (175 w, 10 h)
Roles
Administrator

Recent Activity

Today

deadalnix updated the diff for D7494: Add ChaCha20Poly1305@Bitcoin AEAD implementation.

rebase

Mon, Sep 21, 00:01

Yesterday

deadalnix updated the diff for D7493: Add Poly1305 implementation.

rebase

Sun, Sep 20, 23:59
deadalnix committed rABC8b2c2a2813dc: Add ChaCha20 encryption option (XOR) (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
Add ChaCha20 encryption option (XOR)
Sun, Sep 20, 23:57
deadalnix closed D7491: Add ChaCha20 encryption option (XOR).
Sun, Sep 20, 23:57
deadalnix requested review of D7496: Remove dead folder obj-test.
Sun, Sep 20, 17:32
deadalnix requested review of D7495: Relayout a comment.
Sun, Sep 20, 17:23
deadalnix updated the diff for D7494: Add ChaCha20Poly1305@Bitcoin AEAD implementation.

Various nits

Sun, Sep 20, 17:07
deadalnix updated the diff for D7493: Add Poly1305 implementation.

braces

Sun, Sep 20, 17:06
deadalnix requested review of D7494: Add ChaCha20Poly1305@Bitcoin AEAD implementation.
Sun, Sep 20, 17:00
deadalnix requested review of D7493: Add Poly1305 implementation.
Sun, Sep 20, 16:30
deadalnix abandoned D7492: Add Poly1305 bench.
Sun, Sep 20, 16:29
deadalnix requested review of D7492: Add Poly1305 bench.
Sun, Sep 20, 16:16
deadalnix requested review of D7491: Add ChaCha20 encryption option (XOR).
Sun, Sep 20, 16:03

Sat, Sep 19

deadalnix accepted D7489: [buildbot] Strip out commonly used separators when detecting backports in diff summaries.
Sat, Sep 19, 13:32
deadalnix accepted D7490: Decouple AUR patch recipe from the rest of the automated commits pipeline.
Sat, Sep 19, 13:31
deadalnix accepted D5808: [land-bot] Bail early if there's nothing to land.
Sat, Sep 19, 13:24

Fri, Sep 18

deadalnix requested changes to D7487: Use pure python for functional tests schnorr computation.

At least for the field size thing.

Fri, Sep 18, 23:21
deadalnix requested changes to D7458: [lint] update expected circular dependencies.

This doesn't really answer the question.

Fri, Sep 18, 23:21
deadalnix accepted D7478: [land-bot] Fix git HEAD after checking revision.
Fri, Sep 18, 23:20
deadalnix requested changes to D7489: [buildbot] Strip out commonly used separators when detecting backports in diff summaries.

No. This makes history ungreppable.

Fri, Sep 18, 23:19
deadalnix added inline comments to D7487: Use pure python for functional tests schnorr computation.
Fri, Sep 18, 23:18
deadalnix added inline comments to D7481: Add a check for unstaged changes when generating automated commits.
Fri, Sep 18, 23:11
deadalnix requested changes to D7473: [CMAKE] Move the manpages generation logic to doc/man.
Fri, Sep 18, 23:09
deadalnix accepted D7470: [CMAKE] Silent the man pages generation.
Fri, Sep 18, 23:00
deadalnix requested changes to D7479: [land-bot] Add an entry point for the land bot.

Ok so you you ave something that goes roughly as

Fri, Sep 18, 00:56
deadalnix requested changes to D7478: [land-bot] Fix git HEAD after checking revision.
Fri, Sep 18, 00:53
deadalnix requested changes to D7480: [land-bot] Cleanup unnecessary revision acceptable check.
Fri, Sep 18, 00:50
deadalnix requested changes to D7481: Add a check for unstaged changes when generating automated commits.
Fri, Sep 18, 00:47
deadalnix accepted D7482: Use heredoc for outputting help text in automated commit scripts.
Fri, Sep 18, 00:46

Thu, Sep 17

deadalnix accepted D7476: [land-bot] Call land-patch when generating automated commits.

I' not sure why you would revert back other changes, there were not bad per se.

Thu, Sep 17, 17:10
deadalnix accepted D7475: use markdown syntax for links (part 2).
Thu, Sep 17, 17:07
deadalnix added a comment to D7475: use markdown syntax for links (part 2).
In D7475#177718, @PiRK wrote:

update diff message with arc diff --edit

Thu, Sep 17, 17:07
deadalnix requested changes to D7475: use markdown syntax for links (part 2).

Please fix the test plan, it doesn't display properly.

Thu, Sep 17, 16:33
deadalnix added inline comments to D7467: [land-bot] Split land bot logic into distinct scripts.
Thu, Sep 17, 16:30
deadalnix requested changes to D7476: [land-bot] Call land-patch when generating automated commits.

This is doing exactly the wrong things. Instead of consolidating the framework in which automated commit happen, this instead consolidate the fact that there some kind of big ball of mud type script that can do every signle automated commit, but only half the workflow.

Thu, Sep 17, 16:24
deadalnix added a comment to D7468: [land-bot] Add a sanity rebase after running smoke tests.

You want something like:

Thu, Sep 17, 16:17
deadalnix requested changes to D7468: [land-bot] Add a sanity rebase after running smoke tests.

This does not solve the problem mentioned, because there might be more changes in between the rebase and the push. This is fundamentally broken and cannot be fixed with this approach.

Thu, Sep 17, 15:49
deadalnix requested changes to D7473: [CMAKE] Move the manpages generation logic to doc/man.
Thu, Sep 17, 15:31
deadalnix added inline comments to D7474: Remove freebsd build instructions.
Thu, Sep 17, 15:29
deadalnix accepted D7469: [CMAKE] Rename the test wrapper util.
Thu, Sep 17, 14:36
deadalnix accepted D7472: use markdown syntax for links.
Thu, Sep 17, 14:34
deadalnix accepted D7455: [land-bot] Split arc land into distinct parts in preparation for supporting non-revision patches.
Thu, Sep 17, 14:13
deadalnix accepted D7467: [land-bot] Split land bot logic into distinct scripts.
Thu, Sep 17, 13:04
deadalnix requested changes to D7468: [land-bot] Add a sanity rebase after running smoke tests.

I don't see what problem this solves. The description doesn't explains this.

Thu, Sep 17, 13:03
deadalnix accepted D7471: [CMAKE] Rename the man pages generation target.
Thu, Sep 17, 13:02
deadalnix requested changes to D7470: [CMAKE] Silent the man pages generation.
Thu, Sep 17, 13:02
deadalnix requested changes to D7469: [CMAKE] Rename the test wrapper util.

run_silent is a pretty bad name, considering this is not running "silent". Running something silently is also not the only thing that this script is doing.

Thu, Sep 17, 12:35

Wed, Sep 16

deadalnix accepted D7466: [land-bot] Use --nobranch for revisions by default.
Wed, Sep 16, 23:37
deadalnix accepted D7465: Fix blog feed escaping of unicode characters.
Wed, Sep 16, 21:57
deadalnix accepted D7462: Update the debian package build to use the generated man pages.
Wed, Sep 16, 18:58
deadalnix accepted D7461: Add a generic back button to markdown-generated pages.
Wed, Sep 16, 18:56
deadalnix accepted D7456: Sort docs by version, with latest at the top.
Wed, Sep 16, 18:56
deadalnix added inline comments to D7457: Add release notes to the docs index.
Wed, Sep 16, 18:55
deadalnix accepted D7457: Add release notes to the docs index.
Wed, Sep 16, 18:55
deadalnix accepted D7459: Fixup docs index font sizes.
Wed, Sep 16, 18:54
deadalnix requested changes to D7458: [lint] update expected circular dependencies.

How come arc lint didn't yell at us without this patch? Not really a change request, but this needs to be figure out.

Wed, Sep 16, 18:54
deadalnix accepted D7460: .gitignore new versioned doc files.
Wed, Sep 16, 18:53
deadalnix accepted D7452: [CMAKE] Exclude the man pages from the install-debug target.

There are manpages in tree, you probably want to clean this up.

Wed, Sep 16, 15:26
deadalnix accepted D7454: Update the AUR packages builds to use the generated man pages.
Wed, Sep 16, 15:21
deadalnix accepted D7453: [backport#15699] Remove no-op CClientUIInterface::[signal_name]_disconnect. Disconnect BlockNotifyGenesisWait and RPCNotifyBlockChange properly..
Wed, Sep 16, 15:21

Tue, Sep 15

deadalnix accepted D7450: [CMAKE] Fix NSIS installing failing to find the man pages.

You probably want to make the makepage generated via the build instead of being committed in source control.

Tue, Sep 15, 22:48
deadalnix accepted D7443: Revert "[land-bot] Add buildbot support for requests to land diff patches".
Tue, Sep 15, 22:47
deadalnix accepted D7449: Move version comparison utility functions to their own file.

Accepting, but this is looking more and more like you want to invest in some python here.

Tue, Sep 15, 22:46
deadalnix requested changes to D7444: Add a script for preparing an automated commit based on configuration.

You are build a Rube Goldberg machine. Just have some kind of automated patch script in which you can plug whatever code generation part you want.

Tue, Sep 15, 22:45
deadalnix added inline comments to D7442: Migrate update seeds automation to a config file.
Tue, Sep 15, 22:33
deadalnix requested changes to D7442: Migrate update seeds automation to a config file.

The title is wrong.

Tue, Sep 15, 22:31
deadalnix accepted D6539: [backport#14193] validation: Add missing mempool locks.
Tue, Sep 15, 22:30
deadalnix accepted D7439: [refactor] pass CTxMempool& to DisconnectedBlockTransactions methods.
Tue, Sep 15, 22:26
deadalnix accepted D7440: [backport#14193][test] Add test to check mempool consistency in case of reorgs.
Tue, Sep 15, 22:12

Sat, Sep 12

deadalnix accepted D7434: Merge #18866: test: Fix verack race to avoid intermittent test failures.
Sat, Sep 12, 00:01

Fri, Sep 11

deadalnix committed rABCa20e21d8b0ea: Move man2html.sh in build/config (authored by deadalnix).
Move man2html.sh in build/config
Fri, Sep 11, 21:55
deadalnix closed D7429: Move man2html.sh in build/config.
Fri, Sep 11, 21:54
deadalnix accepted D7432: Move fetch-blog-feed script to more appropriate location.
Fri, Sep 11, 21:54
deadalnix accepted D7433: Merge #18496: test: remove redundant sync_with_ping after add_p2p_connection.
Fri, Sep 11, 21:54
deadalnix accepted D7428: [build] correctly set -fstack-reuse=none only for gcc.
Fri, Sep 11, 20:03
deadalnix requested review of D7429: Move man2html.sh in build/config.
Fri, Sep 11, 19:43
deadalnix requested changes to D7424: [land-bot] Add helper script for checking if a Differential diff was authored by a trusted source.

The description doesn't really explain the problem that this solves or why this approach. For instance why do we need to send the patch to phabricator to then redownload it at the other end? That seems to provide zero value over transferring the diff right away.

Fri, Sep 11, 01:34
deadalnix accepted D7425: [land-bot] Add buildbot support for requests to land diff patches.
Fri, Sep 11, 01:24

Thu, Sep 10

deadalnix accepted D7423: [land-bot] Cleanup unnecessary brace expansion.
Thu, Sep 10, 23:21
deadalnix accepted D7421: [land-bot] Extract revision status check code.
Thu, Sep 10, 22:34
deadalnix accepted D7422: [land-bot] Cleanup unused code paths for diff patches.
Thu, Sep 10, 22:33
deadalnix accepted D7313: Remove legacy announcements feed.
Thu, Sep 10, 22:32
deadalnix accepted D7420: [backport#17381 5/5] Add missing SetupGeneration error handling in EncryptWallet.
Thu, Sep 10, 22:32
deadalnix accepted D7419: [backport#17381 4/5] Clean up nested scope in GetReservedDestination.
Thu, Sep 10, 22:31
deadalnix accepted D7418: [backport#17381 3/5] Get rid of confusing LegacyScriptPubKeyMan::TopUpKeyPool method.
Thu, Sep 10, 22:31
deadalnix accepted D7417: [backport#17381 2/5] Pass CTxDestination to ScriptPubKeyMan::GetMetadata.
Thu, Sep 10, 22:31
deadalnix accepted D7416: [backport#17381 1/5] Add EnsureLegacyScriptPubKeyMan and use in rpcwallet.cpp.
Thu, Sep 10, 22:29

Wed, Sep 9

deadalnix accepted D7412: Fix logo link in non-prod environments.
Wed, Sep 9, 23:50
deadalnix accepted D7409: [CMAKE] Make the doc-rpc target actually generate the rpc docs.
Wed, Sep 9, 13:17
deadalnix requested changes to D7409: [CMAKE] Make the doc-rpc target actually generate the rpc docs.
Wed, Sep 9, 12:26
deadalnix accepted D7408: [CMAKE] Add a check rule for the buildbot test.
Wed, Sep 9, 12:24
deadalnix accepted D7407: [CMAKE] Don't ship the AUR package sources as part of the release.
Wed, Sep 9, 12:23
deadalnix added inline comments to D7406: [backport#19022] test: Fix intermittent failure in feature_dbcrash.
Wed, Sep 9, 00:54
deadalnix accepted D7406: [backport#19022] test: Fix intermittent failure in feature_dbcrash.
Wed, Sep 9, 00:54
deadalnix accepted D7395: [backport#14047 3/4] Add HKDF HMAC_SHA256 L=32 implementations.
Wed, Sep 9, 00:26

Tue, Sep 8

deadalnix accepted D7387: [backport#17280] refactor: Change occurences of c_str() used with size() to data().
Tue, Sep 8, 22:31
deadalnix accepted D7404: Remove unused avatar code.
Tue, Sep 8, 22:28
deadalnix accepted D7401: Remove unused minimal layout.

lol

Tue, Sep 8, 22:27
deadalnix accepted D7400: Migrate footer to flexbox.
Tue, Sep 8, 22:27
deadalnix accepted D7399: Remove bigimg support and cleanup header.
Tue, Sep 8, 22:27