Page MenuHomePhabricator

deadalnix (Amaury SÉCHET)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
May 14 2017, 13:52 (131 w, 21 h)
Roles
Administrator

Recent Activity

Today

deadalnix added inline comments to D4304: Merge #9662: Add createwallet "disableprivatekeys" option: a sane mode for watchonly-wallets.
Mon, Nov 18, 00:23

Yesterday

deadalnix requested changes to D4300: Replace getopts() with gArgs in the Seeder..

It's getting there, this is now much better, but there are still a few things that could be improved.

Sun, Nov 17, 23:55
deadalnix created D4458: Add brace in bitcoin-tx.cpp.
Sun, Nov 17, 23:43
deadalnix accepted D4450: qa: Premine to deterministic address with -disablewallet.
Sun, Nov 17, 23:25
deadalnix accepted D4447: RPC: Add new getzmqnotifications method..
Sun, Nov 17, 23:22
deadalnix accepted D4455: add a couple more Schnorr checkmultisig tests.

More test is always welcome, unless they are flaky or slow as shit.

Sun, Nov 17, 23:14
deadalnix requested changes to D4404: [CMAKE] Migrate windows gitian build to cmake and ninja.

See comments in D4356

Sun, Nov 17, 23:06
deadalnix requested changes to D4356: [CMAKE] Migrate linux gitian build to cmake and ninja.

Overall it looks good. A few details needs to be changed, though.

Sun, Nov 17, 23:04
deadalnix requested changes to D4445: [CMAKE] Use a NSIS custom template.

This isn't a really a change request per se, but I don't understand how the template come to be used, considering it is not referenced anywhere.

Sun, Nov 17, 22:51
deadalnix added inline comments to D4438: [CMAKE] Use a stripped binary to build the dist and DMG for OSX.
Sun, Nov 17, 22:47
deadalnix accepted D4438: [CMAKE] Use a stripped binary to build the dist and DMG for OSX.
Sun, Nov 17, 22:46
deadalnix accepted D4437: [CMAKE] Only build the bitcoin-qt application bundle on OSX.
Sun, Nov 17, 22:44
deadalnix updated the diff for D4424: Add outputtype module.

Add spaces

Sun, Nov 17, 22:19
deadalnix requested changes to D4025: Added empty block fallback to CreateNewBlock.

I don't think the design here is sound. You don't have an error boundary set anywhere, but a parameter that you pass down to ask what's downstream to not error out. This is not solid. The whole point of the maneuver is to not trust what downstream of the error boundary.

Sun, Nov 17, 22:01
deadalnix created D4457: Fix merging of global unknown data in PSBTs.
Sun, Nov 17, 17:46
deadalnix created D4456: Check that PSBT keys are the correct length.
Sun, Nov 17, 17:33
deadalnix created D4454: Fix PSBT error test vectors.
Sun, Nov 17, 00:23

Sat, Nov 16

deadalnix added inline comments to D4424: Add outputtype module.
Sat, Nov 16, 14:46
deadalnix updated the diff for D4424: Add outputtype module.

Address comments

Sat, Nov 16, 13:37

Fri, Nov 15

deadalnix accepted D4449: Merge #14025: p2p: Remove dead code for nVersion=10300.
Fri, Nov 15, 22:11
deadalnix accepted D4451: fix txvalidationcache_tests to not rely on NULLDUMMY.
Fri, Nov 15, 14:43
deadalnix requested changes to D4449: Merge #14025: p2p: Remove dead code for nVersion=10300.
Fri, Nov 15, 14:41
deadalnix committed rABC98d6c5327761: Various nits in the ChainParams code. (authored by deadalnix).
Various nits in the ChainParams code.
Fri, Nov 15, 14:18
deadalnix closed D4446: Various nits in the ChainParams code..
Fri, Nov 15, 14:17

Thu, Nov 14

deadalnix requested changes to D4439: Allow Seeder to handle receiving HEADER messages.

The iff description doesn't match what this does, because it clearly does more than simply receiving and processing the headers messages, it also filter/ban nodes based on it.

Thu, Nov 14, 15:33
deadalnix requested changes to D4442: Seeder filters nodes by chainparams.

I don't see any filtering going on anywhere is that patch.

Thu, Nov 14, 14:57
deadalnix requested changes to D4300: Replace getopts() with gArgs in the Seeder..
Thu, Nov 14, 14:45
deadalnix created D4446: Various nits in the ChainParams code..
Thu, Nov 14, 14:43
deadalnix added inline comments to D4444: [CI] Add a new build configuration to run tests with cmake and ninja.
Thu, Nov 14, 14:21
deadalnix accepted D4443: [CI] Rename build.sh to build_autotools.sh.
Thu, Nov 14, 14:18
deadalnix committed rABC2ca660ddcf75: Various nits in cuckoocache.h (authored by deadalnix).
Various nits in cuckoocache.h
Thu, Nov 14, 02:18
deadalnix closed D4440: Various nits in cuckoocache.h.
Thu, Nov 14, 02:18

Wed, Nov 13

deadalnix updated the diff for D4440: Various nits in cuckoocache.h.

Add fogoten brace

Wed, Nov 13, 23:06
deadalnix created D4440: Various nits in cuckoocache.h.
Wed, Nov 13, 23:01

Tue, Nov 12

deadalnix updated the diff for D4424: Add outputtype module.

rebase

Tue, Nov 12, 16:11
deadalnix added a comment to D4424: Add outputtype module.

It's not super useful, ut helps backports.

Tue, Nov 12, 16:09
deadalnix committed rABCee04f3cbc3e5: Add descriptor reference documentation (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Add descriptor reference documentation
Tue, Nov 12, 15:42
deadalnix closed D4422: Add descriptor reference documentation.
Tue, Nov 12, 15:42
deadalnix updated the diff for D4422: Add descriptor reference documentation.

Rebase and address comments

Tue, Nov 12, 14:38
deadalnix added inline comments to D4426: [CMAKE] Strip the osx bundle binary.
Tue, Nov 12, 14:38
deadalnix committed rABCda453ae29215: Swap in descriptors support into scantxoutset (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Swap in descriptors support into scantxoutset
Tue, Nov 12, 14:35
deadalnix closed D4421: Swap in descriptors support into scantxoutset.
Tue, Nov 12, 14:35
deadalnix added inline comments to D4422: Add descriptor reference documentation.
Tue, Nov 12, 14:34
deadalnix requested changes to D4426: [CMAKE] Strip the osx bundle binary.
Tue, Nov 12, 13:57
deadalnix updated the diff for D4422: Add descriptor reference documentation.

Fix doc and rebase

Tue, Nov 12, 13:43
deadalnix updated the diff for D4421: Swap in descriptors support into scantxoutset.

Add braces

Tue, Nov 12, 13:33
deadalnix committed rABCa3f767ce220d: Output descriptors module (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Output descriptors module
Tue, Nov 12, 13:28
deadalnix closed D4420: Output descriptors module.
Tue, Nov 12, 13:28
deadalnix added inline comments to D4420: Output descriptors module.
Tue, Nov 12, 00:41
deadalnix committed rABCef4d3766839c: Get rid of ambiguous OutputType::NONE value (authored by Russell Yanofsky <russ@yanofsky.org>).
Get rid of ambiguous OutputType::NONE value
Tue, Nov 12, 00:33
deadalnix closed D4423: Get rid of ambiguous OutputType::NONE value.
Tue, Nov 12, 00:33

Mon, Nov 11

deadalnix committed rABC28f918df531c: Fix unecessary copies in rpcwallet.cpp (authored by deadalnix).
Fix unecessary copies in rpcwallet.cpp
Mon, Nov 11, 22:16
deadalnix closed D4427: Fix unecessary copies in rpcwallet.cpp.
Mon, Nov 11, 22:16
deadalnix created D4427: Fix unecessary copies in rpcwallet.cpp.
Mon, Nov 11, 15:56
deadalnix updated the diff for D4422: Add descriptor reference documentation.

rebase and fix merge conflict

Mon, Nov 11, 14:54
deadalnix updated the diff for D4420: Output descriptors module.

Address comments

Mon, Nov 11, 14:39
deadalnix added inline comments to D4420: Output descriptors module.
Mon, Nov 11, 14:30
deadalnix committed rABC11ca044a129f: Add scantxoutset RPC method (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
Add scantxoutset RPC method
Mon, Nov 11, 14:16
deadalnix closed D4357: Add scantxoutset RPC method.
Mon, Nov 11, 14:16
deadalnix created D4424: Add outputtype module.
Mon, Nov 11, 01:03

Sun, Nov 10

deadalnix added a comment to D4419: Modify CSeederNode to allow more testing.

You can include this with the test. It's not really possible to figure out if that is a good idea or not without having an idea of where this is going.

Sun, Nov 10, 17:40
deadalnix created D4423: Get rid of ambiguous OutputType::NONE value.
Sun, Nov 10, 17:36
deadalnix requested changes to D4415: [CI] Allow to pass addditional arguments to bitcoind.
Sun, Nov 10, 16:01
deadalnix requested changes to D4418: Add unit tests for parse_name().
Sun, Nov 10, 15:50
deadalnix requested changes to D4417: Add a separate executible for seeder tests.
Sun, Nov 10, 15:32
deadalnix requested changes to D4300: Replace getopts() with gArgs in the Seeder..
Sun, Nov 10, 13:43
deadalnix added inline comments to D4406: [CMAKE] Build a stripped version of the application bundle and use it.
Sun, Nov 10, 13:27
deadalnix requested changes to D4406: [CMAKE] Build a stripped version of the application bundle and use it.
Sun, Nov 10, 13:05
deadalnix requested changes to D4407: [GITIAN] Migrate OSX Gitian builds to CMake and Ninja.

Depending on system libs will cause the build to not be reproducible. You need to be using depends libs.

Sun, Nov 10, 12:58
deadalnix requested changes to D4404: [CMAKE] Migrate windows gitian build to cmake and ninja.

You need to be using the depends libs and not the system's.

Sun, Nov 10, 12:57
deadalnix requested changes to D4356: [CMAKE] Migrate linux gitian build to cmake and ninja.

You need to be using the libs from depends and not the system libs.

Sun, Nov 10, 12:56
deadalnix accepted D4403: [CMAKE] Install DLL to bin/ by default.
Sun, Nov 10, 12:55

Sat, Nov 9

deadalnix created D4422: Add descriptor reference documentation.
Sat, Nov 9, 22:59
deadalnix created D4421: Swap in descriptors support into scantxoutset.
Sat, Nov 9, 22:53
deadalnix created D4420: Output descriptors module.
Sat, Nov 9, 22:43
deadalnix updated the diff for D4357: Add scantxoutset RPC method.

Remove release notes. Will add them back when backporting PR13697 and PR14096

Sat, Nov 9, 22:32
deadalnix updated the diff for D4357: Add scantxoutset RPC method.

Rebase

Sat, Nov 9, 22:22
deadalnix added inline comments to D4357: Add scantxoutset RPC method.
Sat, Nov 9, 22:22
deadalnix committed rABC39959c11347e: Add simple FlatSigningProvider (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Add simple FlatSigningProvider
Sat, Nov 9, 19:56
deadalnix closed D4360: Add simple FlatSigningProvider.
Sat, Nov 9, 19:56
deadalnix committed rABC2633916fbb90: Tests for PSBT (authored by Andrew Chow <achow101-github@achow101.com>).
Tests for PSBT
Sat, Nov 9, 19:49
deadalnix closed D4353: Tests for PSBT.
Sat, Nov 9, 19:49
deadalnix committed rABCf25d2ad300d9: Create wallet RPCs for PSBT (authored by Andrew Chow <achow101-github@achow101.com>).
Create wallet RPCs for PSBT
Sat, Nov 9, 19:37
deadalnix closed D4352: Create wallet RPCs for PSBT.
Sat, Nov 9, 19:37
deadalnix updated the diff for D4353: Tests for PSBT.

Update as per comments

Sat, Nov 9, 16:46
deadalnix added inline comments to D4353: Tests for PSBT.
Sat, Nov 9, 16:40
deadalnix updated the diff for D4352: Create wallet RPCs for PSBT.

Address comments

Sat, Nov 9, 15:59

Thu, Nov 7

deadalnix accepted D4350: [CMAKE] Generate the split-debug.sh script.
Thu, Nov 7, 15:12
deadalnix accepted D4396: Sprinkle some sweet noexcepts over the RNG code.
Thu, Nov 7, 15:07

Wed, Nov 6

deadalnix updated the diff for D4357: Add scantxoutset RPC method.

Add release notes, sort imports

Wed, Nov 6, 16:05
deadalnix committed rABC6e5278d36615: Create utility RPCs for PSBT (authored by Andrew Chow <achow101-github@achow101.com>).
Create utility RPCs for PSBT
Wed, Nov 6, 15:13
deadalnix closed D4351: Create utility RPCs for PSBT.
Wed, Nov 6, 15:13
deadalnix added a comment to D4357: Add scantxoutset RPC method.

This PR doesn't contain any change to the release notes. I'm not sure why we would want to warn people about this, it's not breaking any existing behavior, or fixing any bug they'd waiting on, and is not a very major change.

Wed, Nov 6, 00:10
deadalnix updated the diff for D4357: Add scantxoutset RPC method.

make static and reorder imports

Wed, Nov 6, 00:08
deadalnix updated the diff for D4351: Create utility RPCs for PSBT.

Fix missing else

Wed, Nov 6, 00:00

Tue, Nov 5

deadalnix added inline comments to D4351: Create utility RPCs for PSBT.
Tue, Nov 5, 23:55
deadalnix committed rABC8544daeee4b5: Add more methods to Span class (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Add more methods to Span class
Tue, Nov 5, 23:49
deadalnix closed D4359: Add more methods to Span class.
Tue, Nov 5, 23:48
deadalnix committed rABCa5afd2ec6fda: Fix comment layout in client.h (authored by deadalnix).
Fix comment layout in client.h
Tue, Nov 5, 23:46
deadalnix closed D4358: Fix comment layout in client.h.
Tue, Nov 5, 23:45