Page MenuHomePhabricator

deadalnix (Amaury SÉCHET)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
May 14 2017, 13:52 (205 w, 5 d)
Roles
Administrator

Recent Activity

Yesterday

deadalnix accepted D9430: [backport#19178] Make mininode_lock non-reentrant.
Thu, Apr 22, 17:38
deadalnix accepted D9422: [avalanche] Don't turn on service bit if we don't have a proof.
Thu, Apr 22, 11:19
deadalnix accepted D9440: [avalanche] Move proof verification to processor.
Thu, Apr 22, 11:16

Wed, Apr 21

deadalnix accepted D9345: [avalanche] set a minimum amount for a proof.
Wed, Apr 21, 21:08
deadalnix added a comment to D9345: [avalanche] set a minimum amount for a proof.
In D9345#214194, @PiRK wrote:

What about bool hasDustStake(Proof p);?

Wed, Apr 21, 21:07
deadalnix requested changes to D9430: [backport#19178] Make mininode_lock non-reentrant.
Wed, Apr 21, 18:51
deadalnix added a comment to D9430: [backport#19178] Make mininode_lock non-reentrant.

Why are the changes to P2PTxInvStore ignored?

Wed, Apr 21, 18:51
deadalnix requested changes to D9440: [avalanche] Move proof verification to processor.
Wed, Apr 21, 18:26
deadalnix requested changes to D9425: [avalanche] add an OrphanProofPool class.
Wed, Apr 21, 12:22
deadalnix requested changes to D9440: [avalanche] Move proof verification to processor.

Ok, now this is looking more like something that make sense. There is this encoding/decoding of the session key that needs to be addressed, but beside that, it's all good.

Wed, Apr 21, 12:08

Tue, Apr 20

deadalnix requested changes to D9430: [backport#19178] Make mininode_lock non-reentrant.

This is breaking the test suite, back to your queue. Please make sure you run it, this is happening way too often.

Tue, Apr 20, 15:42
deadalnix accepted D9433: [net] Make cs_inventory nonrecursive.
Tue, Apr 20, 15:41
deadalnix accepted D9429: [backport#19299] remove unused variables and add missing includes.
Tue, Apr 20, 15:40
deadalnix requested changes to D9425: [avalanche] add an OrphanProofPool class.

I note that you often submit patches that break everything. You should make sure that you compile/run what you submit.

Tue, Apr 20, 15:40
deadalnix requested changes to D9345: [avalanche] set a minimum amount for a proof.

This is pretty much good to go. Make sure isProofStateDustThreshold has a descriptive name.

Tue, Apr 20, 00:09
deadalnix requested changes to D9365: [avalanche] Add an option to import a delegation.
Tue, Apr 20, 00:06
deadalnix requested changes to D9423: [avalanche] Remember rejected proofs.
Tue, Apr 20, 00:01

Mon, Apr 19

deadalnix requested changes to D9422: [avalanche] Don't turn on service bit if we don't have a proof.
Mon, Apr 19, 23:50
deadalnix requested changes to D9421: [avalanche] Move the initial proof verification to PeerData constructor.
Mon, Apr 19, 23:48
deadalnix requested changes to D9419: [avalanche] Move the session key to the PeerData structure.

This will allow for initializing the PeerData from the ArgsManager and make it independent from the Processor.

Mon, Apr 19, 23:40
deadalnix requested changes to D9420: [avalanche] Initialize PeerData from ArgsManager.

This kinda have the right idea, but the execution is a problem. For as long as you do these in the various constructors, you must have objects at the end, and therefore you end up constructing possibly invalid objects, which is just bad design.

Mon, Apr 19, 23:29
deadalnix requested changes to D9425: [avalanche] add an OrphanProofPool class.
Mon, Apr 19, 23:27
deadalnix requested changes to D9418: [avalanche] Make the peer data proof and delegation optional.

The rationale of this patch doesn't rally make sense. If data aren't optional, then don't put them in the PeerData. If the name turn out to b confusing then rename.

Mon, Apr 19, 23:16

Wed, Apr 14

deadalnix accepted D9416: [BUILDBOT] Switch secp256k1 to Cirrus CI.
Wed, Apr 14, 15:31
deadalnix requested changes to D9345: [avalanche] set a minimum amount for a proof.

On a side, note, if we commit to the proof score being the amount in satoshi, how do we handle overflows?

Wed, Apr 14, 15:31
deadalnix requested changes to D9414: Fix minerfund in GBT when cashaddr is disabled.

Wouldn't moving away imply to not do the translation in more and more places over time?

Wed, Apr 14, 12:29

Tue, Apr 13

deadalnix accepted D9398: [SECP256K1] ci: Switch all Linux builds to Debian and more improvements.
Tue, Apr 13, 13:23
deadalnix requested changes to D9370: [avalanche] orphan pool for proofs, make AlreadyHave support proofs.

This is doing to many things at once. You should break this up, and, as you do so, you'll discover that there are various holes in some parts. This is just going to take forever to get all the parts right if they all prevent each other from moving.

Tue, Apr 13, 13:22
deadalnix accepted D9397: [SECP256K1] Add support for Cirrus CI.
Tue, Apr 13, 13:11

Mon, Apr 12

deadalnix requested changes to D9368: [avalanche] move proof verification code to processor.cpp.

You'll keep shuffling things around until you ask yourself the questions "What does the initialization?" "What does fetch the config?" "What does verify the validity of the different parameters?" and so on. Once you got the answers to these question, you need to apply them consistently.

Mon, Apr 12, 16:47
deadalnix requested changes to D9368: [avalanche] move proof verification code to processor.cpp.
Mon, Apr 12, 14:45

Sun, Apr 11

deadalnix requested changes to D9394: [avalanche] rename getProof to getLocalProof and return a pointer.

You need to find what the right API for initialization is. Fixing the current API is mostly motion not progress. If you initialized where thing should be initialized, you wouldn't need to access the proof here now (maybe later, but later is later) and therefore, you wouldn't need to figure out what is the right API to access the proof.

Sun, Apr 11, 15:09

Thu, Apr 8

deadalnix accepted D9387: [SECP256K1] Add parens around ROUND_TO_ALIGN's parameter..
Thu, Apr 8, 13:59
deadalnix accepted D9385: [SECP256K1] Remove underscores from header defs..
Thu, Apr 8, 13:48
deadalnix accepted D9386: [SECP256K1] Add missing secp256k1_ge_set_gej_var decl..
Thu, Apr 8, 13:48
deadalnix requested changes to D9387: [SECP256K1] Add parens around ROUND_TO_ALIGN's parameter..

The PR in the description is not correct

Thu, Apr 8, 13:47
deadalnix accepted D9383: [SECP256K1] Avoid casting (void**) values..
Thu, Apr 8, 13:20
deadalnix accepted D9384: [SECP256K1] Remove unused secp256k1_fe_inv_all_var.
Thu, Apr 8, 13:20
deadalnix requested changes to D9345: [avalanche] set a minimum amount for a proof.
Thu, Apr 8, 13:19
deadalnix requested changes to D9368: [avalanche] move proof verification code to processor.cpp.

You need to read your code, it is telling you things and you are ignoring these things.

Thu, Apr 8, 13:16
deadalnix accepted D9371: [avalanche] delay executing avalanche event loop until IBD is done.
Thu, Apr 8, 13:07
deadalnix accepted D9382: [SECP256K1] Autoconf improvements.
Thu, Apr 8, 13:05
deadalnix accepted D9381: [SECP256K1] Extract the secret key from a keypair.
Thu, Apr 8, 13:04
deadalnix accepted D9377: [SECP256K1] sage: Add script for generating scalar_split_lambda constants.
Thu, Apr 8, 13:03
deadalnix accepted D9373: [SECP256K1] Don't use reserved identifiers memczero and benchmark_verify_t.
Thu, Apr 8, 13:03

Wed, Apr 7

deadalnix requested changes to D9368: [avalanche] move proof verification code to processor.cpp.
Wed, Apr 7, 17:04
deadalnix requested changes to D9345: [avalanche] set a minimum amount for a proof.
Wed, Apr 7, 15:40

Tue, Apr 6

deadalnix added inline comments to D9371: [avalanche] delay executing avalanche event loop until IBD is done.
Tue, Apr 6, 23:31
deadalnix requested changes to D9371: [avalanche] delay executing avalanche event loop until IBD is done.

Why not just check for IBD status in runEventLoop ? What benefit does all this complication achieves?

Tue, Apr 6, 23:30
deadalnix requested changes to D9368: [avalanche] move proof verification code to processor.cpp.

Some open question, but this is better.

Tue, Apr 6, 15:26

Sat, Apr 3

deadalnix accepted D8673: Add -overridednsseed for testing DNS seed behavior.
Sat, Apr 3, 20:39
deadalnix requested changes to D9345: [avalanche] set a minimum amount for a proof.
Sat, Apr 3, 20:37
deadalnix requested changes to D9365: [avalanche] Add an option to import a delegation.

What problem removing the distinction between master key and session key solves? It seems to me like it's making security of the whole thing worse for no good reason.

Sat, Apr 3, 19:57

Thu, Apr 1

deadalnix requested changes to D9361: [avalanche] Build a stripped delegation to remove unnecessary levels.

The use case does not make sense. You don't want to have a long delegation chain for all the node one after the other anyways, you want to have a master key and delegate to each node. There is no point delegating to begin with if the master also have all the private key to which it is delegating. If you want to do that, you might as well distribute the master key instead of devising a complicated scheme that isn't any more secure.

Thu, Apr 1, 12:28
deadalnix requested changes to D9345: [avalanche] set a minimum amount for a proof.
Thu, Apr 1, 12:25
deadalnix accepted D9360: [avalanche] add an inventory type and a message for proofs.
Thu, Apr 1, 12:23
deadalnix requested changes to D9364: [avalanche] start implementing reception of avaproof.

You want to fix the proof size handling before moving on there, or you'll just multiply the point where this needs fixing.

Thu, Apr 1, 12:23

Tue, Mar 30

deadalnix accepted D8899: Check for overflow when calculating sum of outputs.
Tue, Mar 30, 16:17
deadalnix requested changes to D9360: [avalanche] add an inventory type and a message for proofs.
Tue, Mar 30, 16:15
deadalnix requested changes to D9361: [avalanche] Build a stripped delegation to remove unnecessary levels.

What problem is this solving?

Tue, Mar 30, 15:06

Feb 23 2021

deadalnix closed D9263: Update links in CONTRIBUTE.md.
Feb 23 2021, 17:24
deadalnix committed rABCb9efc788c9be: Update links in CONTRIBUTE.md (authored by deadalnix).
Update links in CONTRIBUTE.md
Feb 23 2021, 17:24
deadalnix requested review of D9263: Update links in CONTRIBUTE.md.
Feb 23 2021, 17:02

Jan 26 2021

deadalnix updated the diff for D8671: Add a --descriptors option to various tests.

rebase from hell

Jan 26 2021, 16:32

Jan 25 2021

deadalnix requested changes to D9053: create payment URIs with amount in satoshis rather then BCHA.

Make it a config to begin with.

Jan 25 2021, 16:46

Jan 23 2021

deadalnix accepted D8947: test: add wait_for_cookie_credentials() to framework for rpcwait tests.
Jan 23 2021, 20:50
deadalnix accepted D9046: Add Trunk Based Development link to CONTRIBUTING.
Jan 23 2021, 00:25

Jan 22 2021

deadalnix requested changes to D8899: Check for overflow when calculating sum of outputs.
Jan 22 2021, 23:06
deadalnix abandoned D8811: [cashtab] Upgrade node modules.
Jan 22 2021, 23:00

Jan 21 2021

deadalnix accepted D9017: script: prevent UB when computing abs value for num opcode serialize.
Jan 21 2021, 20:52
deadalnix accepted D8942: [net_processing] Pass chainparams to PeerLogicValidation constructor.
Jan 21 2021, 20:51
deadalnix requested changes to D8942: [net_processing] Pass chainparams to PeerLogicValidation constructor.

Back to your queue due to test failures.

Jan 21 2021, 18:12

Jan 18 2021

deadalnix requested changes to D8942: [net_processing] Pass chainparams to PeerLogicValidation constructor.

The config is needed down the road is just saying nothing at all.

Jan 18 2021, 21:58
deadalnix requested changes to D8947: test: add wait_for_cookie_credentials() to framework for rpcwait tests.
Jan 18 2021, 17:03
deadalnix requested changes to D8942: [net_processing] Pass chainparams to PeerLogicValidation constructor.

You say that it differs from the original by passing a config, but provide no reason as to why. It doesn't looks like to me that this difference is justified.

Jan 18 2021, 13:27
deadalnix accepted D8941: test: Replace boost::mutex with std::mutex.
Jan 18 2021, 13:26

Jan 16 2021

deadalnix requested changes to D8899: Check for overflow when calculating sum of outputs.
Jan 16 2021, 15:55

Jan 14 2021

deadalnix requested changes to D8899: Check for overflow when calculating sum of outputs.
In D8899#204315, @PiRK wrote:

I added a few tests, but now I 'm no longer sure that all situations described in the PR are possible. I don't know how to reasonably generate a CTransaction whose outputs would add up to an int64 overflow without any single one of the outputs being larger than MAX_MONEY.
It would require 439208192231 outputs.

Jan 14 2021, 02:51

Jan 13 2021

deadalnix closed D8901: [CashTab] Update react-copy-to-clipboard.
Jan 13 2021, 17:05
deadalnix committed rABCc17adeb89179: [CashTab] Update react-copy-to-clipboard (authored by deadalnix).
[CashTab] Update react-copy-to-clipboard
Jan 13 2021, 17:05
deadalnix accepted D8900: RPC: Fix more formatting nits.
Jan 13 2021, 14:58
deadalnix requested review of D8901: [CashTab] Update react-copy-to-clipboard.
Jan 13 2021, 14:50
deadalnix requested changes to D8899: Check for overflow when calculating sum of outputs.

I know there isn't int he original code, but there should really be tests cases for this.

Jan 13 2021, 14:22
deadalnix accepted D8762: [backport#16658] validation: Rename CheckInputs to CheckInputScripts.
Jan 13 2021, 14:21

Jan 12 2021

deadalnix accepted D8886: Update copyright year to 2021.
Jan 12 2021, 23:12
deadalnix accepted D8883: Limit decimal range of numbers ParseScript accepts.
Jan 12 2021, 15:54
deadalnix accepted D8882: util: Fail to parse space-only strings in ParseMoney(...) (instead of parsing as zero).
Jan 12 2021, 15:34
deadalnix closed D8862: [avalanche] Initiate avalanche when the service bit is present and we have a stake..
Jan 12 2021, 11:35
deadalnix committed rABC42a8d3bc2caa: [avalanche] Initiate avalanche when the service bit is present and we have a… (authored by deadalnix).
[avalanche] Initiate avalanche when the service bit is present and we have a…
Jan 12 2021, 11:35
deadalnix accepted D8879: lockedpool: When possible, use madvise to avoid including sensitive information in core dumps.
Jan 12 2021, 10:58
deadalnix accepted D8880: lockedpool: avoid sensitive data in core files (FreeBSD).
Jan 12 2021, 10:57

Jan 11 2021

deadalnix accepted D8877: [CI] Work around LCOV stupid behavior.
Jan 11 2021, 23:11
deadalnix updated the diff for D8862: [avalanche] Initiate avalanche when the service bit is present and we have a stake..

Address comments

Jan 11 2021, 23:04
deadalnix added inline comments to D8862: [avalanche] Initiate avalanche when the service bit is present and we have a stake..
Jan 11 2021, 20:26
deadalnix updated the diff for D8862: [avalanche] Initiate avalanche when the service bit is present and we have a stake..

rebase

Jan 11 2021, 01:47
deadalnix closed D8861: [net] Add extra entropy to the version message.
Jan 11 2021, 01:34
deadalnix committed rABC9343802bc731: [net] Add extra entropy to the version message (authored by deadalnix).
[net] Add extra entropy to the version message
Jan 11 2021, 01:34

Jan 10 2021

deadalnix requested review of D8861: [net] Add extra entropy to the version message.

The requested change differ from the existing code style for a benefit that is at best elusive.

Jan 10 2021, 16:12
deadalnix updated the diff for D8862: [avalanche] Initiate avalanche when the service bit is present and we have a stake..

Remove debug logs

Jan 10 2021, 03:20

Jan 9 2021

deadalnix requested review of D8862: [avalanche] Initiate avalanche when the service bit is present and we have a stake..
Jan 9 2021, 23:44