Page MenuHomePhabricator

deadalnix (Amaury SÉCHET)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
May 14 2017, 13:52 (220 w, 2 d)
Roles
Administrator

Recent Activity

Mon, Aug 2

deadalnix requested changes to D9839: [avalanche] Compute a node activity score.

I don't understand what this whole RCU business achieves. It's trivially completely wrong: the RCU pointer is stuffed into a larger structure that might be deleted anyways, nothing's actually protected. And it seems that you fitted all the metrics into one value that is small enough to be atomic anyways, so is RCU needed at all?

Mon, Aug 2, 19:25

Thu, Jul 29

deadalnix requested changes to D9844: [avalanche] exclude stakes from the hash used in stake signature.

This is lacking the bigger picture. We can't just break the proof format with every version. What's the format of a proof you are moving toward?

Thu, Jul 29, 12:24

Tue, Jul 27

deadalnix closed D9840: Do not specify a line/char for prettier when not apropriate.
Tue, Jul 27, 14:18
deadalnix committed rABC4c8d559ef552: Do not specify a line/char for prettier when not apropriate (authored by deadalnix).
Do not specify a line/char for prettier when not apropriate
Tue, Jul 27, 14:18
deadalnix requested changes to D9839: [avalanche] Compute a node activity score.
Tue, Jul 27, 14:00
deadalnix requested review of D9840: Do not specify a line/char for prettier when not apropriate.
Tue, Jul 27, 13:33

Thu, Jul 22

deadalnix accepted D9833: init: use std::thread for ThreadImport().
Thu, Jul 22, 17:19

Wed, Jul 21

deadalnix accepted D9828: test: whitelist rpc_rawtransaction peers to speed up tests.
Wed, Jul 21, 16:28

Tue, Jul 20

deadalnix added a comment to D9760: [cashtab] Internationalization: Switch from fbt to react-intl.

If this solves the fbt issues, it's a step in the right direction.

Tue, Jul 20, 10:12

Mon, Jul 19

deadalnix added a comment to D9760: [cashtab] Internationalization: Switch from fbt to react-intl.

Looking at react-intl, it seems to me like it is a significant step backward.

Mon, Jul 19, 10:46
deadalnix accepted D9703: [avalanche] Remember nodes pending a proof and bind them when available.
Mon, Jul 19, 10:26

Sat, Jul 17

deadalnix requested changes to D9703: [avalanche] Remember nodes pending a proof and bind them when available.

A couple of questions, but this looks much better now.

Sat, Jul 17, 09:45

Mon, Jul 12

deadalnix accepted D9742: [avalanche] register local proof at first tip update.
Mon, Jul 12, 20:24
deadalnix requested changes to D9686: [avalanche] add a lock to CNode::AvalancheState.
Mon, Jul 12, 20:22
deadalnix added a comment to D9686: [avalanche] add a lock to CNode::AvalancheState.

The description fo this patch makes no sense. We aren't using the scheduler to read delegations. I do not know why this lock is needed. It seems to me that creating the avalanche state once the delegation has been verified should be enough.

Mon, Jul 12, 20:22
deadalnix closed D9763: [avalanche] Do not bucket brigade broadcast handling.
Mon, Jul 12, 11:53
deadalnix committed rABCcfe13e06ec0b: [avalanche] Do not bucket brigade broadcast handling (authored by deadalnix).
[avalanche] Do not bucket brigade broadcast handling
Mon, Jul 12, 11:53

Sun, Jul 11

deadalnix closed D9764: Remove Processor::forNode.
Sun, Jul 11, 22:53
deadalnix committed rABCa6e531901d68: Remove Processor::forNode (authored by deadalnix).
Remove Processor::forNode
Sun, Jul 11, 22:53

Sat, Jul 10

deadalnix requested review of D9764: Remove Processor::forNode.
Sat, Jul 10, 14:03
deadalnix requested review of D9763: [avalanche] Do not bucket brigade broadcast handling.
Sat, Jul 10, 13:59
deadalnix requested changes to D9762: [avalanche] add a test for a node started with an orphan proof.

I think that should be merged in D9742 . it doesn't make much sense to separate the code and the tests.

Sat, Jul 10, 13:34

Fri, Jul 9

deadalnix closed D9761: TDOD -> TODO.
Fri, Jul 9, 14:38
deadalnix committed rABC0eff3b268791: TDOD -> TODO (authored by deadalnix).
TDOD -> TODO
Fri, Jul 9, 14:38
deadalnix requested review of D9761: TDOD -> TODO.
Fri, Jul 9, 13:10

Thu, Jul 8

deadalnix added inline comments to D9742: [avalanche] register local proof at first tip update.
Thu, Jul 8, 16:05
deadalnix accepted D9756: test: Simplify cs_main locks.
Thu, Jul 8, 13:54
deadalnix accepted D9754: [avalanche] Fix an edge case that can assert when updating a node.
Thu, Jul 8, 13:03
deadalnix added inline comments to D9754: [avalanche] Fix an edge case that can assert when updating a node.
Thu, Jul 8, 12:56
deadalnix accepted D9755: [avalanche] Minor simplification in the fetchOrCreatePeer method.
Thu, Jul 8, 12:43
deadalnix added inline comments to D9754: [avalanche] Fix an edge case that can assert when updating a node.
Thu, Jul 8, 12:42
deadalnix closed D9753: Simple cleanup in net_processing.cpp.
Thu, Jul 8, 10:07
deadalnix committed rABCe90d70657293: Simple cleanup in net_processing.cpp (authored by deadalnix).
Simple cleanup in net_processing.cpp
Thu, Jul 8, 10:07
deadalnix closed D9749: [avalanche] More bucket brigading removal in the Processor.
Thu, Jul 8, 10:03
deadalnix committed rABC5f1a6c2150fd: [avalanche] More bucket brigading removal in the Processor (authored by deadalnix).
[avalanche] More bucket brigading removal in the Processor
Thu, Jul 8, 10:03
deadalnix added inline comments to D9749: [avalanche] More bucket brigading removal in the Processor.
Thu, Jul 8, 09:42
deadalnix closed D9751: Broadcast proofs from the network layer.
Thu, Jul 8, 09:37
deadalnix committed rABC38a9c81fc963: Broadcast proofs from the network layer (authored by deadalnix).
Broadcast proofs from the network layer
Thu, Jul 8, 09:37
deadalnix requested review of D9753: Simple cleanup in net_processing.cpp.
Thu, Jul 8, 09:34
deadalnix closed D9747: [avalanche] Remove some bucket brigading in the Processor.
Thu, Jul 8, 08:51
deadalnix committed rABC972eb4ed8ce2: [avalanche] Remove some bucket brigading in the Processor (authored by deadalnix).
[avalanche] Remove some bucket brigading in the Processor
Thu, Jul 8, 08:51
deadalnix closed D9750: [avalanche] Move code around in the peer manager.
Thu, Jul 8, 08:49
deadalnix committed rABC69125012b6ac: [avalanche] Move code around in the peer manager (authored by deadalnix).
[avalanche] Move code around in the peer manager
Thu, Jul 8, 08:48
Detetivepro1 awarded D9751: Broadcast proofs from the network layer a Mountain of Wealth token.
Thu, Jul 8, 00:43
deadalnix updated the diff for D9749: [avalanche] More bucket brigading removal in the Processor.

Rebase on D9751 to remove circular dependency

Thu, Jul 8, 00:41
deadalnix requested review of D9751: Broadcast proofs from the network layer.
Thu, Jul 8, 00:30
deadalnix retitled D9747: [avalanche] Remove some bucket brigading in the Processor from [avalanche] Remove bucket brigading in the Processor to [avalanche] Remove some bucket brigading in the Processor.
Thu, Jul 8, 00:21
deadalnix retitled D9750: [avalanche] Move code around in the peer manager from [avalanche] Move code aroudn in the peer manager to [avalanche] Move code around in the peer manager.
Thu, Jul 8, 00:20
deadalnix updated the diff for D9747: [avalanche] Remove some bucket brigading in the Processor.

Reoder fields a bit, based on D9750

Thu, Jul 8, 00:07
deadalnix updated the diff for D9750: [avalanche] Move code around in the peer manager.

Get back to unordered_set XD

Thu, Jul 8, 00:05

Wed, Jul 7

deadalnix updated the diff for D9750: [avalanche] Move code around in the peer manager.

Fix mismatch between unordered and ordered sets.

Wed, Jul 7, 23:58
deadalnix requested review of D9750: [avalanche] Move code around in the peer manager.
Wed, Jul 7, 23:52
deadalnix added a comment to D9749: [avalanche] More bucket brigading removal in the Processor.

Why does the peer manager depends on et processing?

Wed, Jul 7, 22:03
deadalnix retitled D9749: [avalanche] More bucket brigading removal in the Processor from [avalanche] More rbucket brigading removal in the Processor to [avalanche] More bucket brigading removal in the Processor.
Wed, Jul 7, 21:12
deadalnix requested review of D9749: [avalanche] More bucket brigading removal in the Processor.
Wed, Jul 7, 21:03
deadalnix requested review of D9747: [avalanche] Remove some bucket brigading in the Processor.
Wed, Jul 7, 19:24
deadalnix closed D9746: [avalanche] Use proof registration time instead of "proof time".
Wed, Jul 7, 19:09
deadalnix committed rABC720a00c1b6f6: [avalanche] Use proof registration time instead of "proof time" (authored by deadalnix).
[avalanche] Use proof registration time instead of "proof time"
Wed, Jul 7, 19:09
deadalnix requested review of D9746: [avalanche] Use proof registration time instead of "proof time".
Wed, Jul 7, 18:32
deadalnix requested changes to D9703: [avalanche] Remember nodes pending a proof and bind them when available.

The general approach seems to make sense, but holly hell, the code is a total mess. You need to think about what these different function do, or should do, and ventilate accordingly, instead of just patching things in random places.

Wed, Jul 7, 15:45

Jun 28 2021

deadalnix accepted D9628: Add -uaclientname and -uaclientversion config options to set the client name and version of the user agent in the version message..
Jun 28 2021, 23:50
deadalnix requested changes to D9628: Add -uaclientname and -uaclientversion config options to set the client name and version of the user agent in the version message..

It looks like to me this got a bit out of control. In D9637, you split FormatSubVersion in two, and in this, you do it again. At this rate, 8 more patches and we get 1024 variation of that function.

Jun 28 2021, 13:02
deadalnix accepted D9708: move buildRemoteSighash out of the avalanche codebase.
Jun 28 2021, 12:24
deadalnix accepted D9700: [avalanche] Don't require the proof when adding an avalanche node.
Jun 28 2021, 12:23
deadalnix requested changes to D9703: [avalanche] Remember nodes pending a proof and bind them when available.

You have a fundamental problem here. You can register a node for 2 proofs and 2 keys. In addition, the key seems duplicated between the PeerManager and the node state. Is it used at all in the peer manager? If not, then get rid of it. In any case, you need to resolve this duplication problem.

Jun 28 2021, 11:28

Jun 24 2021

deadalnix requested changes to D9697: make nExtraNonce static to IncrementExtraNonce.

uint8 is just 256 values, this would make it impossible to CPU mine on testnet or whatnot.

Jun 24 2021, 16:24
deadalnix added inline comments to D9700: [avalanche] Don't require the proof when adding an avalanche node.
Jun 24 2021, 16:22
deadalnix requested changes to D9700: [avalanche] Don't require the proof when adding an avalanche node.
Jun 24 2021, 16:12
deadalnix accepted D9699: [avalanche] Remove unnecessary peer lookup after modifying the peer set.
Jun 24 2021, 16:07
deadalnix requested changes to D9697: make nExtraNonce static to IncrementExtraNonce.

No, this is not thread safe.

Jun 24 2021, 11:39
deadalnix requested changes to D9694: Ensure `nExtraNonce` is initialized randomly.

Back on your queue, this seems to be breaking tests.

Jun 24 2021, 11:35

Jun 23 2021

deadalnix accepted D9691: [avalanche] Fix the abc_p2p_proof_inventory test.
Jun 23 2021, 14:00

Jun 20 2021

baby636 awarded D1646: Hash the input of OP_CHECKDATASIG instead of expecting the user to do it. a Love token.
Jun 20 2021, 05:10

Jun 18 2021

deadalnix requested changes to D9691: [avalanche] Fix the abc_p2p_proof_inventory test.
Jun 18 2021, 15:26

Jun 17 2021

deadalnix requested changes to D9661: [avalanche] add nodes when we have received their proof.
Jun 17 2021, 23:03
deadalnix added a comment to D9661: [avalanche] add nodes when we have received their proof.

This whole approach do not seem very sensible to me.

Jun 17 2021, 14:00
deadalnix requested changes to D9686: [avalanche] add a lock to CNode::AvalancheState.
Jun 17 2021, 13:53
deadalnix added a comment to D9686: [avalanche] add a lock to CNode::AvalancheState.

Because the pointer is set and never mutated, you actually don't need the mutex to access the pointed data - which are immutable. The scope of these lock is too large. buildRemoteSighash for instance, shouldn't need the lock.

Jun 17 2021, 13:48

Jun 15 2021

deadalnix accepted D9365: [avalanche] Add an option to import a delegation.
Jun 15 2021, 12:46

Jun 14 2021

deadalnix added inline comments to D9365: [avalanche] Add an option to import a delegation.
Jun 14 2021, 19:14
deadalnix accepted D9445: [avalanche] Check the delegation generated at startup is valid.
Jun 14 2021, 19:10

Jun 10 2021

deadalnix added inline comments to D9660: [avalanche] Don't request orphaned proofs.
Jun 10 2021, 22:14

Jun 8 2021

deadalnix accepted D9492: [avalanche] Add a sendavalancheproof RPC shell.
Jun 8 2021, 15:29
deadalnix requested changes to D9628: Add -uaclientname and -uaclientversion config options to set the client name and version of the user agent in the version message..
Jun 8 2021, 15:29
deadalnix accepted D9645: [CMAKE] Hint to user to the option flags when an optional dependency is not found.

likestamp

Jun 8 2021, 10:26

Jun 7 2021

deadalnix added a comment to D9643: [avalanche] Keep track of the peer creation time.

Why?

Jun 7 2021, 14:51
deadalnix requested changes to D9628: Add -uaclientname and -uaclientversion config options to set the client name and version of the user agent in the version message..
Jun 7 2021, 09:50

Jun 6 2021

deadalnix requested changes to D9635: [refactor] replace duplicated AmountFromValue function with Amount::Amount(UniValue T).
Jun 6 2021, 14:25
deadalnix added a comment to D9635: [refactor] replace duplicated AmountFromValue function with Amount::Amount(UniValue T).

This honestly seems like a step backward. The thing throws JSONRPC errors, so that most certainly belong in the RPC stack.

Jun 6 2021, 14:25
deadalnix accepted D9637: Add FormatSubVersionUserAgent..
Jun 6 2021, 14:23

Jun 4 2021

deadalnix abandoned D9633: Fix threading issue in processor_tests.cpp.

Abandoning in favor of D9634

Jun 4 2021, 20:46
deadalnix accepted D9634: [avalanche] Fix threading issue in processor_tests.cpp.
Jun 4 2021, 20:46
deadalnix accepted D9582: [avalanche] Answer proof invs with getdata proof requests.
Jun 4 2021, 16:50
deadalnix updated the diff for D9633: Fix threading issue in processor_tests.cpp.

rebase

Jun 4 2021, 16:49
deadalnix requested review of D9633: Fix threading issue in processor_tests.cpp.
Jun 4 2021, 16:43
deadalnix closed D9476: [avalanche] use the OrphanProofPool.
Jun 4 2021, 15:07
deadalnix committed rABCc565a795866a: [avalanche] use the OrphanProofPool (authored by PiRK).
[avalanche] use the OrphanProofPool
Jun 4 2021, 15:07
deadalnix closed D9629: Use smart pointer in the orphan proof pool.
Jun 4 2021, 14:53
deadalnix committed rABCa53677be459f: Use smart pointer in the orphan proof pool (authored by deadalnix).
Use smart pointer in the orphan proof pool
Jun 4 2021, 14:53
deadalnix updated the diff for D9476: [avalanche] use the OrphanProofPool.

Rebase on top of D9629

Jun 4 2021, 14:50