Page MenuHomePhabricator
Differential D11703

[avalanche] Pass chainman to PeerManager
ClosedPublic
Actions

Authored by PiRK on Jul 4 2022, 16:00.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC91a4647992fc: [avalanche] Pass chainman to PeerManager
Summary

This removes usage of global chainstate in the PeerManager class.

Depends on D11702

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jul 4 2022, 16:00
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 4 2022, 16:00
PiRK requested review of this revision.Jul 4 2022, 16:00
PiRK added a child revision: D11704: [avalanche] pass chainman to Proof::verify.
Harbormaster completed remote builds in B19544: Diff 34233.Jul 4 2022, 16:33
deadalnix added a subscriber: deadalnix.Jul 5 2022, 12:47
deadalnix added inline comments.
src/avalanche/peermanager.cpp
12 ↗(On Diff #34233)

ChainstateManager is not a fucntion.

deadalnix requested changes to this revision.Jul 6 2022, 00:55
This revision now requires changes to proceed.Jul 6 2022, 00:55
PiRK updated this revision to Diff 34275.Jul 6 2022, 12:56

fix comment for #include <validation.h>

Harbormaster completed remote builds in B19576: Diff 34275.Jul 6 2022, 13:12
deadalnix accepted this revision.Jul 8 2022, 15:40
This revision is now accepted and ready to land.Jul 8 2022, 15:40
PiRK updated this revision to Diff 34333.Jul 12 2022, 14:08

rebase: fix conflicts with D11736

Harbormaster completed remote builds in B19615: Diff 34333.Jul 12 2022, 14:29
PiRK added a child revision: D11737: use local chainman in peermanager_tests.Jul 12 2022, 14:38
Closed by commit rABC91a4647992fc: [avalanche] Pass chainman to PeerManager (authored by PiRK). · Explain WhyJul 12 2022, 18:12
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC91a4647992fc: [avalanche] Pass chainman to PeerManager.

Revision Contents
Changeset List

PathSize
src/
avalanche/
5 lines
10 lines
2 lines
test/
52 lines
2 lines

Diff 34344

View Options

src/avalanche/peermanager.h

Loading...
View Options

src/avalanche/peermanager.cpp

Loading...
View Options

src/avalanche/processor.cpp

Loading...
View Options

src/avalanche/test/peermanager_tests.cpp

Loading...
View Options

src/avalanche/test/proofpool_tests.cpp

Loading...