use local chainman in peermanager_tests
ClosedPublic
Actions

Authored by PiRK on Jul 12 2022, 14:38.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC4d6d1cb9ca3c: use local chainman in peermanager_tests

Summary

To remove usages of the global chainman in peermanager_tests, pass a reference to the active chainstate to two static functions who need it.

Depends on D11703

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jul 12 2022, 14:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 12 2022, 14:38

PiRK requested review of this revision.Jul 12 2022, 14:38

Harbormaster completed remote builds in B19616: Diff 34334.Jul 12 2022, 14:51

PiRK added a child revision: D11739: use existing chainstate reference in various places.Jul 12 2022, 15:41

Fabien accepted this revision.Jul 12 2022, 16:06

This revision is now accepted and ready to land.Jul 12 2022, 16:06

Closed by commit rABC4d6d1cb9ca3c: use local chainman in peermanager_tests (authored by PiRK). · Explain WhyJul 13 2022, 13:30

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC4d6d1cb9ca3c: use local chainman in peermanager_tests.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

test/

peermanager_tests.cpp

158 lines

Diff 34355

View Options

src/avalanche/test/peermanager_tests.cpp

use local chainman in peermanager_testsClosedPublicActions