Page MenuHomePhabricator
Feed Advanced Search

Tue, Dec 11

deadalnix accepted D2187: Minor improvement to comments.
Tue, Dec 11, 19:08
deadalnix requested changes to D2186: Minor doc update, clarifying intent of 'CInv'.
Tue, Dec 11, 16:58
deadalnix accepted D2149: [Part 1] Core PR 11531: p2p-acceptblock improvements.

Accepting because doing all the nits + the backport would become very tedious. I trust you'll follow through.

Tue, Dec 11, 01:14
deadalnix accepted D2183: Add backporting suggestion to CONTRIBUTING.md.
Tue, Dec 11, 01:06

Sat, Dec 8

deadalnix updated the diff for D2169: [secp256k1] Implement Schnorr signatures.

Fix mixture of tab and spaces

Sat, Dec 8, 15:45
deadalnix requested changes to D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.

Back on your queue, this is apparently breaking many tests.

Sat, Dec 8, 13:10
deadalnix accepted D2182: Remove BTCForks Slack from CONTRIBUTING.md.
Sat, Dec 8, 13:08
deadalnix added a comment to D2169: [secp256k1] Implement Schnorr signatures.

@markblundeberg Both are necessary. one is a public API, one is a private one.

Sat, Dec 8, 03:04
deadalnix updated the diff for D2169: [secp256k1] Implement Schnorr signatures.

reorder code so verify come before sign. This allows to change the signature code (for instance for multisig) without causing the verification code lost in the middle of the signature code.

Sat, Dec 8, 01:49
deadalnix updated the diff for D2169: [secp256k1] Implement Schnorr signatures.

remove useless static

Sat, Dec 8, 00:10

Fri, Dec 7

deadalnix updated the diff for D2169: [secp256k1] Implement Schnorr signatures.

Refactor the signing code.

  • Extract a function to generate a proper value for k
  • Use that fucntion in the signing code.
Fri, Dec 7, 21:46
deadalnix accepted D2181: [wallet] Remove Wallet dependencies from init.cpp.
Fri, Dec 7, 20:59
deadalnix added inline comments to D2181: [wallet] Remove Wallet dependencies from init.cpp.
Fri, Dec 7, 20:58
deadalnix requested changes to D2181: [wallet] Remove Wallet dependencies from init.cpp.

Some small nits, but overall it's good.

Fri, Dec 7, 20:12
deadalnix accepted D2180: [wallet] Clarify wallet initialization / destruction interface.
Fri, Dec 7, 20:06
deadalnix accepted D2179: Fix undefined behaviour errors due to long int overflow in Amount.
Fri, Dec 7, 20:00
deadalnix accepted D2178: Make links clickable in CONTRIBUTING.md.
Fri, Dec 7, 19:58
deadalnix updated the diff for D2169: [secp256k1] Implement Schnorr signatures.

Use R.x in part of the explaination where r is not defined

Fri, Dec 7, 19:57
deadalnix added inline comments to D2169: [secp256k1] Implement Schnorr signatures.
Fri, Dec 7, 19:54

Thu, Dec 6

deadalnix accepted D2162: Add new test cases to abc-finalize-.py.
Thu, Dec 6, 20:03
deadalnix requested changes to D2162: Add new test cases to abc-finalize-.py.
Thu, Dec 6, 18:06
deadalnix requested changes to D1979: [qt] Multiwallet support for GUI (Core PR12610).
Thu, Dec 6, 01:48
deadalnix accepted D2166: Remove unused variables and/or function calls.
Thu, Dec 6, 01:42

Tue, Dec 4

deadalnix updated the diff for D2169: [secp256k1] Implement Schnorr signatures.

Various nits

Tue, Dec 4, 21:17
deadalnix updated the diff for D2169: [secp256k1] Implement Schnorr signatures.

Explain test cases more in details.

Tue, Dec 4, 21:00

Mon, Dec 3

deadalnix committed rABC7f7f55cc7216: [avalanche] Add the concept of inconclusive votes (authored by deadalnix).
[avalanche] Add the concept of inconclusive votes
Mon, Dec 3, 18:23
deadalnix closed D2160: [avalanche] Add the concept of inconclusive votes.
Mon, Dec 3, 18:22
deadalnix committed rABCc7b844fb409d: [avalanche] Use black magic for popcount. (authored by deadalnix).
[avalanche] Use black magic for popcount.
Mon, Dec 3, 18:20
deadalnix closed D2148: [avalanche] Use black magic for popcount..
Mon, Dec 3, 18:20
deadalnix updated the diff for D2148: [avalanche] Use black magic for popcount..

Typos

Mon, Dec 3, 13:36
deadalnix updated the diff for D2160: [avalanche] Add the concept of inconclusive votes.

Fix typo

Mon, Dec 3, 12:20

Sun, Dec 2

deadalnix accepted D2150: Datadir option in linearize scripts.

Please investigate with harbormaster is failing before landing.

Sun, Dec 2, 23:45
deadalnix requested changes to D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.
Sun, Dec 2, 23:42
deadalnix requested changes to D2153: [qa] Make src_dir handling more robust.

I have no idea what problem this diff solves.

Sun, Dec 2, 23:11
deadalnix requested changes to D2159: [Part 1 of 4] [qa] De-globalize port seeding.
Sun, Dec 2, 23:06
deadalnix updated the diff for D2160: [avalanche] Add the concept of inconclusive votes.

Add explaination about error codes

Sun, Dec 2, 23:00
deadalnix updated the diff for D2148: [avalanche] Use black magic for popcount..

Add explainations and link for the blakc magic.
Add parenthesis to make the compiler happy.

Sun, Dec 2, 22:40
deadalnix requested changes to D2162: Add new test cases to abc-finalize-.py.

This ends up changing all the tests for no good reasons. Just add the new tests cases after the existing ones. You can use reconsiderblock/invalidate block to recreate the situation you desire.

Sun, Dec 2, 22:31
deadalnix accepted D2161: Prevent auto-finalization from moving backward the finalization point.
Sun, Dec 2, 22:20
deadalnix requested changes to D2161: Prevent auto-finalization from moving backward the finalization point.

A few small changes, but LGTM.

Sun, Dec 2, 21:32
deadalnix added inline comments to D2130: Fix abc-finalize-block.py header propagation issue.
Sun, Dec 2, 21:19
deadalnix accepted D2130: Fix abc-finalize-block.py header propagation issue.
Sun, Dec 2, 21:17
Herald added a reviewer for D2169: [secp256k1] Implement Schnorr signatures: Restricted Project.
Sun, Dec 2, 19:48

Sat, Dec 1

deadalnix added inline comments to D2130: Fix abc-finalize-block.py header propagation issue.
Sat, Dec 1, 23:11

Fri, Nov 30

deadalnix committed rSTAGING49f8c721b92b: [avalanche] Expire queries once they reached their timeout. (authored by deadalnix).
[avalanche] Expire queries once they reached their timeout.
Fri, Nov 30, 21:35
deadalnix committed rSTAGING80acc8fd3b66: [avalanche] Delegate node management to caller (authored by deadalnix).
[avalanche] Delegate node management to caller
Fri, Nov 30, 21:34
deadalnix committed rSTAGINGaa5be8bc1cca: [avalanche] Make sure the round variable is initialized properly (authored by deadalnix).
[avalanche] Make sure the round variable is initialized properly
Fri, Nov 30, 21:34
deadalnix committed rSTAGING1951a4e6cfef: [avalanche] Use a multi_index to track request so it is easy to determine which… (authored by deadalnix).
[avalanche] Use a multi_index to track request so it is easy to determine which…
Fri, Nov 30, 21:34
deadalnix committed rSTAGING1f50cf0e7ef3: [avalanche] Ensure block added to avalanche have the proper acceptance. (authored by deadalnix).
[avalanche] Ensure block added to avalanche have the proper acceptance.
Fri, Nov 30, 21:34
deadalnix committed rSTAGING751f09e7dbac: [avalanche] Enforce cooldown request present in AvalancheResponse (authored by deadalnix).
[avalanche] Enforce cooldown request present in AvalancheResponse
Fri, Nov 30, 21:34
deadalnix committed rSTAGINGefb6682eb066: [avalanche] consistently use avanodeid in avalanche's test. (authored by deadalnix).
[avalanche] consistently use avanodeid in avalanche's test.
Fri, Nov 30, 21:34
deadalnix committed rSTAGINGddc32b011f5f: Make CNodeStats a struct and add a blurb explaining what it is. (authored by deadalnix).
Make CNodeStats a struct and add a blurb explaining what it is.
Fri, Nov 30, 21:34
deadalnix committed rSTAGINGd98df9d1f7fa: [avalanche] Implement the challenge/response protocol (authored by deadalnix).
[avalanche] Implement the challenge/response protocol
Fri, Nov 30, 21:34
deadalnix committed rSTAGING91e28d4f1b1f: [avalanche] Report the list of finalized blocks when votes are accounted for (authored by deadalnix).
[avalanche] Report the list of finalized blocks when votes are accounted for
Fri, Nov 30, 21:33
deadalnix committed rSTAGING81fcace04fdf: [avalanche] Add support to poll multiple block at once. (authored by deadalnix).
[avalanche] Add support to poll multiple block at once.
Fri, Nov 30, 21:33
deadalnix committed rSTAGINGf245a0ce69ec: [avalanche] Add a facility to select invs to poll (authored by deadalnix).
[avalanche] Add a facility to select invs to poll
Fri, Nov 30, 21:33
deadalnix committed rSTAGING3aeef6295cbe: [avalanche] Create an event loop facility. (authored by deadalnix).
[avalanche] Create an event loop facility.
Fri, Nov 30, 21:33
deadalnix committed rSTAGING7fd9d97515b9: [avalanche] Add a block registry and facility to register votes on these blocks. (authored by deadalnix).
[avalanche] Add a block registry and facility to register votes on these blocks.
Fri, Nov 30, 21:33
deadalnix committed rSTAGING5606e0ab8d93: Move finalization suck as reconsiderblock actualy reconsider blocks (authored by deadalnix).
Move finalization suck as reconsiderblock actualy reconsider blocks
Fri, Nov 30, 21:33
deadalnix committed rSTAGING0f56a224223d: Fix various bugs in the seeder. (authored by deadalnix).
Fix various bugs in the seeder.
Fri, Nov 30, 21:33
deadalnix committed rSTAGING280fa002fa7d: [avalanche] Create a structure to accumulate avalanche votes (authored by deadalnix).
[avalanche] Create a structure to accumulate avalanche votes
Fri, Nov 30, 21:33
deadalnix committed rSTAGINGf3bd9f54e0ff: Process transaction in reverse order in DisconnectedBlockTransactions… (authored by deadalnix).
Process transaction in reverse order in DisconnectedBlockTransactions…
Fri, Nov 30, 21:33
deadalnix committed rSTAGINGd1d091ba73f5: Add test case and release notes for auto finalization (authored by deadalnix).
Add test case and release notes for auto finalization
Fri, Nov 30, 21:32
deadalnix committed rSTAGING59ee4dedf793: Add an RPC to finalize a block (authored by deadalnix).
Add an RPC to finalize a block
Fri, Nov 30, 21:32
deadalnix committed rSTAGING917d65774c40: Auto-finalize block once they reached a certain depth (by default 10) (authored by deadalnix).
Auto-finalize block once they reached a certain depth (by default 10)
Fri, Nov 30, 21:32
deadalnix committed rSTAGING321b2b6363c2: Reconsider parked chains when enough works piles up (authored by deadalnix).
Reconsider parked chains when enough works piles up
Fri, Nov 30, 21:32
deadalnix committed rSTAGING45ca215ceb4f: Do not unpark children of blocks outside of the RPC (authored by deadalnix).
Do not unpark children of blocks outside of the RPC
Fri, Nov 30, 21:32
deadalnix committed rSTAGING94fce1408f84: revert changes to abc-p2p-compactblock.py (authored by deadalnix).
revert changes to abc-p2p-compactblock.py
Fri, Nov 30, 21:32
deadalnix committed rSTAGING05e5edb9bfce: Fix block construction in abc-p2p-compactblocks.py (authored by deadalnix).
Fix block construction in abc-p2p-compactblocks.py
Fri, Nov 30, 21:32
deadalnix committed rSTAGINGf4c416327715: [qa] Fix p2p-fullblocktest.py for magnetic anomaly (authored by deadalnix).
[qa] Fix p2p-fullblocktest.py for magnetic anomaly
Fri, Nov 30, 21:32
deadalnix committed rSTAGING65b595d16cc5: Fix sources of flackiness in p2p-fullblocktest.py (authored by deadalnix).
Fix sources of flackiness in p2p-fullblocktest.py
Fri, Nov 30, 21:32
deadalnix committed rSTAGINGd34870389ab4: Nits in AcceptBlockHeader (authored by deadalnix).
Nits in AcceptBlockHeader
Fri, Nov 30, 21:32
deadalnix committed rSTAGING0e31ab2753c0: Make error message more meaningful when a block contains a duplicate transaction (authored by deadalnix).
Make error message more meaningful when a block contains a duplicate transaction
Fri, Nov 30, 21:32
deadalnix committed rSTAGING651ac4461c2c: Add a checkpoint for the fork block (authored by deadalnix).
Add a checkpoint for the fork block
Fri, Nov 30, 21:31
deadalnix committed rSTAGINGdf358b788cdb: Ensure CPU mining is reliable (authored by deadalnix).
Ensure CPU mining is reliable
Fri, Nov 30, 21:31
deadalnix committed rSTAGING52d8c7e896a1: Fix comment in util.py (authored by deadalnix).
Fix comment in util.py
Fri, Nov 30, 21:31
deadalnix committed rSTAGING35638ea8b3a4: Remove alerts support from mininode.py (authored by deadalnix).
Remove alerts support from mininode.py
Fri, Nov 30, 21:31
deadalnix committed rSTAGING9e94b5dd1024: Nits in arith_uint256_tests.cpp (authored by deadalnix).
Nits in arith_uint256_tests.cpp
Fri, Nov 30, 21:31
deadalnix committed rSTAGINGfb04810e3450: Add braces in net.h (authored by deadalnix).
Add braces in net.h
Fri, Nov 30, 21:31
deadalnix committed rSTAGINGf4cb98f2d663: Run checkdatasig_tests on a larger set of flags (authored by deadalnix).
Run checkdatasig_tests on a larger set of flags
Fri, Nov 30, 21:30
deadalnix committed rSTAGING50d44dcc5c7d: Add missing include in rwcollection.h (authored by deadalnix).
Add missing include in rwcollection.h
Fri, Nov 30, 21:30
deadalnix committed rSTAGING412c5a2a449a: Add RWCollection, a read-write locked collection with a mostly safe API (authored by deadalnix).
Add RWCollection, a read-write locked collection with a mostly safe API
Fri, Nov 30, 21:30
deadalnix committed rSTAGINGa46dd46abc1c: Update relase checklist (authored by deadalnix).
Update relase checklist
Fri, Nov 30, 21:30
deadalnix committed rSTAGING402dfb95965b: Add a way to stop scheduleEvery instances. (authored by deadalnix).
Add a way to stop scheduleEvery instances.
Fri, Nov 30, 21:30
deadalnix added inline comments to D2161: Prevent auto-finalization from moving backward the finalization point.
Fri, Nov 30, 18:20
deadalnix requested changes to D2161: Prevent auto-finalization from moving backward the finalization point.
Fri, Nov 30, 18:18
deadalnix added inline comments to D2130: Fix abc-finalize-block.py header propagation issue.
Fri, Nov 30, 16:13
deadalnix added inline comments to D2130: Fix abc-finalize-block.py header propagation issue.
Fri, Nov 30, 15:56
deadalnix added a child revision for D2148: [avalanche] Use black magic for popcount.: D2160: [avalanche] Add the concept of inconclusive votes.
Fri, Nov 30, 15:37
Herald added a reviewer for D2160: [avalanche] Add the concept of inconclusive votes: Restricted Project.
Fri, Nov 30, 15:37
deadalnix added inline comments to D2130: Fix abc-finalize-block.py header propagation issue.
Fri, Nov 30, 14:40

Thu, Nov 29

deadalnix requested review of D2148: [avalanche] Use black magic for popcount..
Thu, Nov 29, 23:58
deadalnix added inline comments to D1992: Rename wallet functional test files to match bitcoin core.
Thu, Nov 29, 22:55
deadalnix committed rABC49f8c721b92b: [avalanche] Expire queries once they reached their timeout. (authored by deadalnix).
[avalanche] Expire queries once they reached their timeout.
Thu, Nov 29, 17:40
deadalnix closed D2143: [avalanche] Expire queries once they reached their timeout..
Thu, Nov 29, 17:39
deadalnix requested changes to D2130: Fix abc-finalize-block.py header propagation issue.
Thu, Nov 29, 17:38
deadalnix committed rABC80acc8fd3b66: [avalanche] Delegate node management to caller (authored by deadalnix).
[avalanche] Delegate node management to caller
Thu, Nov 29, 17:10
deadalnix closed D2140: [avalanche] Delegate node management to caller.
Thu, Nov 29, 17:10
Herald added a reviewer for D2148: [avalanche] Use black magic for popcount.: Restricted Project.
Thu, Nov 29, 16:25
deadalnix requested changes to D2130: Fix abc-finalize-block.py header propagation issue.
Thu, Nov 29, 16:13