Page MenuHomePhabricator
Feed Advanced Search

Today

deadalnix accepted D5301: lcov: filter /usr/lib/ from coverage reports.
Tue, Feb 18, 00:14

Sun, Feb 16

deadalnix closed D5300: [sigcheck] Add per tx limit.
Sun, Feb 16, 03:57
deadalnix committed rABC18708a54d44c: [sigcheck] Add per tx limit (authored by deadalnix).
[sigcheck] Add per tx limit
Sun, Feb 16, 03:57
deadalnix accepted D5293: Add missing items to release-notes + formatting fixups.
Sun, Feb 16, 03:56
deadalnix updated the diff for D5300: [sigcheck] Add per tx limit.

More nits

Sun, Feb 16, 03:55
deadalnix updated the diff for D5300: [sigcheck] Add per tx limit.

Fix nits

Sun, Feb 16, 03:47
deadalnix committed rABCb46180893ed6: Implement miner funding features (authored by deadalnix).
Implement miner funding features
Sun, Feb 16, 02:45
deadalnix closed D5282: Implement miner funding features.
Sun, Feb 16, 02:45
deadalnix changed the visibility for D5282: Implement miner funding features.
Sun, Feb 16, 02:40
deadalnix created D5300: [sigcheck] Add per tx limit.
Sun, Feb 16, 02:38

Sat, Feb 15

deadalnix committed rABCb9912939d5a9: [sigcheck] Remove redundant sigcheck in CheckInputs (authored by deadalnix).
[sigcheck] Remove redundant sigcheck in CheckInputs
Sat, Feb 15, 18:03
deadalnix closed D5298: [sigcheck] Remove redundant sigcheck in CheckInputs.
Sat, Feb 15, 18:03
deadalnix committed rABCff9578c4bcd3: [ConnectBlock] Use an index to refers into blockundo.vtxundo rather than pusing… (authored by deadalnix).
[ConnectBlock] Use an index to refers into blockundo.vtxundo rather than pusing…
Sat, Feb 15, 18:01
deadalnix closed D5299: [ConnectBlock] Use an index to refers into blockundo.vtxundo rather than pusing as we go.
Sat, Feb 15, 18:01
deadalnix retitled D5282: Implement miner funding features from Implement miner the funding features to Implement miner funding features.
Sat, Feb 15, 17:40
deadalnix requested review of D5299: [ConnectBlock] Use an index to refers into blockundo.vtxundo rather than pusing as we go.
Sat, Feb 15, 17:40
deadalnix requested review of D5298: [sigcheck] Remove redundant sigcheck in CheckInputs.

The comment is still accurate. The behavior did not change, as tests demonstrate.

Sat, Feb 15, 17:39
deadalnix accepted D5287: Update manpages for 0.21.0 release.
Sat, Feb 15, 17:25
deadalnix created D5299: [ConnectBlock] Use an index to refers into blockundo.vtxundo rather than pusing as we go.
Sat, Feb 15, 16:43
deadalnix created D5298: [sigcheck] Remove redundant sigcheck in CheckInputs.
Sat, Feb 15, 16:19

Fri, Feb 14

deadalnix updated the diff for D5282: Implement miner funding features.

Address some nits

Fri, Feb 14, 23:45
deadalnix requested changes to D5287: Update manpages for 0.21.0 release.

Let's wait until tomorow for this, just in case.

Fri, Feb 14, 23:01
deadalnix accepted D5289: Change version to 0.21.0.
Fri, Feb 14, 23:00
deadalnix updated the test plan for D5282: Implement miner funding features.
Fri, Feb 14, 21:36
deadalnix updated the summary of D5282: Implement miner funding features.
Fri, Feb 14, 21:36
deadalnix accepted D5244: Enable new ancestor/descendants chains limit at fork.
Fri, Feb 14, 21:00
deadalnix added inline comments to D5282: Implement miner funding features.
Fri, Feb 14, 20:54
deadalnix accepted D5240: [LINTER] Fix the doxygen linter when inline comments are multilined.
Fri, Feb 14, 16:04
deadalnix requested changes to D5244: Enable new ancestor/descendants chains limit at fork.

Now of course for the most strenuous activation tests (involving consensus features) it's important to actually step through the activation block by block, see e.g. D5179 and D5130. That lets you check very carefully how certain transactions in mempool before the upgrade are handled during the upgrade, and vice versa -- if the upgrade is rewinded, the mempool needs to be sane still. But as this is nonconsensus it's not really important.

Fri, Feb 14, 15:38
deadalnix updated the diff for D5282: Implement miner funding features.

Enforce phonon activation time so that test pass also after the upgrade.

Fri, Feb 14, 13:00
deadalnix updated the diff for D5282: Implement miner funding features.

Remove change to miner_tests, as it is covered by the intergration test and messes with global state.

Fri, Feb 14, 03:46
deadalnix requested changes to D5244: Enable new ancestor/descendants chains limit at fork.

What @markblundeberg said.

Fri, Feb 14, 02:46
deadalnix updated the diff for D5282: Implement miner funding features.

Update to use a whitelist only and bump to 5% after discussions with miners.

Fri, Feb 14, 02:36

Thu, Feb 13

deadalnix requested changes to D5240: [LINTER] Fix the doxygen linter when inline comments are multilined.
Thu, Feb 13, 16:38
deadalnix requested review of D5282: Implement miner funding features.

The builds are clean.

Thu, Feb 13, 15:26
deadalnix changed the visibility for D5282: Implement miner funding features.
Thu, Feb 13, 01:58
deadalnix created D5282: Implement miner funding features.
Thu, Feb 13, 01:57
deadalnix requested changes to D5244: Enable new ancestor/descendants chains limit at fork.
Thu, Feb 13, 01:42
deadalnix requested changes to D5245: [qa] Test that mempool reverts to pre-phonon policies.
Thu, Feb 13, 01:38
deadalnix accepted D5243: Add new post-fork ancestor and descendants limit..
Thu, Feb 13, 01:36

Wed, Feb 12

deadalnix accepted D5279: [CI] Run the functional tests when wallet is disable.
Wed, Feb 12, 23:04
deadalnix added a reverting change for D5130: OP_REVERSEBYTES activation logic: rABCadaa9fe22fbc: Revert "OP_REVERSEBYTES activation logic".
Wed, Feb 12, 22:52
deadalnix added a reverting change for rABCfcf22e8fcc94: OP_REVERSEBYTES activation logic: rABCadaa9fe22fbc: Revert "OP_REVERSEBYTES activation logic".
Wed, Feb 12, 22:52
deadalnix committed rABCadaa9fe22fbc: Revert "OP_REVERSEBYTES activation logic" (authored by deadalnix).
Revert "OP_REVERSEBYTES activation logic"
Wed, Feb 12, 22:52
deadalnix closed D5278: Revert "OP_REVERSEBYTES activation logic".
Wed, Feb 12, 22:52
deadalnix added a reverting change for D5130: OP_REVERSEBYTES activation logic: D5278: Revert "OP_REVERSEBYTES activation logic".
Wed, Feb 12, 22:24
deadalnix added a reverting change for rABCfcf22e8fcc94: OP_REVERSEBYTES activation logic: D5278: Revert "OP_REVERSEBYTES activation logic".
Wed, Feb 12, 22:24
deadalnix created D5278: Revert "OP_REVERSEBYTES activation logic".
Wed, Feb 12, 22:24
deadalnix accepted D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.
Wed, Feb 12, 15:04
deadalnix accepted D5253: Bump automatic replay protection to Nov 2020 upgrade.
Wed, Feb 12, 15:03
deadalnix accepted D5130: OP_REVERSEBYTES activation logic.
Wed, Feb 12, 03:10

Tue, Feb 11

deadalnix added a comment to D5267: Merge #14236: qa: generate --> generatetoaddress change to allow tests run without wallet.

The code looks correct, but the test plan is inadequate.

Tue, Feb 11, 23:08
deadalnix accepted D5267: Merge #14236: qa: generate --> generatetoaddress change to allow tests run without wallet.
Tue, Feb 11, 23:08
deadalnix requested changes to D5240: [LINTER] Fix the doxygen linter when inline comments are multilined.
Tue, Feb 11, 16:42
deadalnix accepted D5238: Merge #15321: doc: Add cs_main lock annotations for mapBlockIndex.
Tue, Feb 11, 16:37
deadalnix closed T743: Build Bitcoin-ABC / Master / Health Checks / Bitcoin-ABC Check Seeds is broken. as Wontfix.

Patch doesn't touch the seeds.

Tue, Feb 11, 04:05
deadalnix committed rABC3d26d0c747cb: [cmake] Add the suite name to the test runner. (authored by deadalnix).
[cmake] Add the suite name to the test runner.
Tue, Feb 11, 00:36
deadalnix closed D5247: [cmake] Add the suite name to the test runner..
Tue, Feb 11, 00:36

Mon, Feb 10

deadalnix created D5247: [cmake] Add the suite name to the test runner..
Mon, Feb 10, 23:40
deadalnix requested changes to D5243: Add new post-fork ancestor and descendants limit..

You need to update the cmake build.

Mon, Feb 10, 22:29
deadalnix accepted D5242: Move mempool policy constants to policy/mempool.h.
Mon, Feb 10, 22:12
deadalnix added inline comments to D5240: [LINTER] Fix the doxygen linter when inline comments are multilined.
Mon, Feb 10, 18:54
deadalnix requested changes to D4418: Add unit tests for parse_name().

This is much better, but is missing cases. Thankfully, it is now possible to see which cases are tested an which are not by now.

Mon, Feb 10, 18:47
deadalnix requested changes to D5238: Merge #15321: doc: Add cs_main lock annotations for mapBlockIndex.
Mon, Feb 10, 14:15
deadalnix accepted D5236: remove SCRIPT_VERIFY_COMPRESSED_PUBKEYTYPE (aka WITNESS_PUBKEYTYPE).
Mon, Feb 10, 14:04
deadalnix accepted D5237: [avalanche_tests] fix block index accesses.
Mon, Feb 10, 14:02
deadalnix committed rABC8e591f10ec22: Cache the result of chainparams.GetConsensus() in miner code (authored by deadalnix).
Cache the result of chainparams.GetConsensus() in miner code
Mon, Feb 10, 13:05
deadalnix closed D5234: Cache the result of chainparams.GetConsensus() in miner code.
Mon, Feb 10, 13:05
deadalnix committed rABCe035b46366e4: Update weird way to check for MTP in functional tests (authored by deadalnix).
Update weird way to check for MTP in functional tests
Mon, Feb 10, 13:02
deadalnix closed D5233: Update weird way to check for MTP in functional tests.
Mon, Feb 10, 13:02
deadalnix accepted D4588: [tests] Add libFuzzer support..
Mon, Feb 10, 13:00

Sun, Feb 9

deadalnix created D5234: Cache the result of chainparams.GetConsensus() in miner code.
Sun, Feb 9, 23:26
deadalnix created D5233: Update weird way to check for MTP in functional tests.
Sun, Feb 9, 21:50
deadalnix accepted D5230: remove print-debugging statement that ended up in master.
Sun, Feb 9, 20:12
deadalnix requested changes to D5232: util_tests.test_LockDirectory: avoid exit in forked process.
Sun, Feb 9, 20:12
deadalnix requested changes to D5223: clean up STANDARD_NOT_MANDATORY_VERIFY_FLAGS.

I get what you want to do with this whole stack, and this is not a bad idea per, but you need to rework the approach so that flagset getting out of sync is less of a problem.

Sun, Feb 9, 03:42
deadalnix requested changes to D5222: remove MANDATORY_SCRIPT_VERIFY_FLAGS in favour of explicit forgiveness flags.
Sun, Feb 9, 03:30
deadalnix requested changes to D5221: Make STANDARD_SCRIPT_VERIFY_FLAGS explicit.

Wait, what did happen here?

Sun, Feb 9, 03:27
deadalnix requested changes to D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.

Some details can be improved, but it is good overall.

Sun, Feb 9, 03:18
deadalnix accepted D5224: [standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade.
Sun, Feb 9, 01:23
deadalnix accepted D5219: [python linting] tweak options.
Sun, Feb 9, 01:08
deadalnix committed rABC89819efc7cc1: Update blockchain RPC to report all BIP9 based on versionbitsinfo (authored by deadalnix).
Update blockchain RPC to report all BIP9 based on versionbitsinfo
Sun, Feb 9, 01:08
deadalnix closed D5218: Update blockchain RPC to report all BIP9 based on versionbitsinfo.
Sun, Feb 9, 01:08

Sat, Feb 8

deadalnix created D5218: Update blockchain RPC to report all BIP9 based on versionbitsinfo.
Sat, Feb 8, 03:19
deadalnix accepted D5217: [python linting] apply aggressive mode in autopep8 (line wrapping).
Sat, Feb 8, 01:54
deadalnix accepted D5216: [python linting] nit.
Sat, Feb 8, 01:46
deadalnix accepted D5215: apply nontrivial changes suggested by autopep8 aggressive.
Sat, Feb 8, 01:46

Fri, Feb 7

deadalnix accepted D5208: [python linting] enforce E722: do not use bare except.
Fri, Feb 7, 18:03
deadalnix accepted D5206: Merge #9739: Fix BIP68 activation test.
Fri, Feb 7, 17:59
deadalnix requested changes to D5188: Make copyright script update to current year instead of last commit year.

If the files are not touched, it doesn't make sense to update the copyright.

Fri, Feb 7, 17:58
deadalnix accepted D5196: Run the linters as part of arc land.
Fri, Feb 7, 17:17
deadalnix added inline comments to D5130: OP_REVERSEBYTES activation logic.
Fri, Feb 7, 16:41
deadalnix requested changes to D5196: Run the linters as part of arc land.
Fri, Feb 7, 16:25
deadalnix accepted D5205: [python linting] Enforce all flake8 F codes.
Fri, Feb 7, 16:19
deadalnix accepted D5204: [python linting] enforce E731: Do not assign a lambda expression, use a def.
Fri, Feb 7, 16:19
deadalnix accepted D5200: [python linting] enforce E712: Comparison to true should be 'if cond is true:' or 'if cond:'.
Fri, Feb 7, 15:29
deadalnix added inline comments to D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.
Fri, Feb 7, 03:13
deadalnix accepted D5181: Add build support for 'gprof' profiling..
Fri, Feb 7, 02:36
deadalnix accepted D5042: Make the CI record and track the unit tests.

This is a bit of a concern, because now a dev adding a new test suite needs to update this to make sure it runs. Failing to do so will just result in not running the test suite, silently. You need to figure this out.

Fri, Feb 7, 02:14
deadalnix accepted D5182: [CMAKE] Get rid of ECM for running the sanitizers.
Fri, Feb 7, 02:06