Page MenuHomePhabricator
Feed Advanced Search

Yesterday

deadalnix accepted D3693: scripted-diff: Rename CChainState::g_failed_blocks to m_failed_blocks.
Thu, Jul 18, 21:18
deadalnix requested changes to D3694: Update the github issue template with more relavant links.

Reddit is not a good place for this kind of questions.

Thu, Jul 18, 21:18
deadalnix requested changes to D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.

cmake build

Thu, Jul 18, 12:06
deadalnix accepted D3692: [test_runner] Fix unidash option for junit output to be one character.
Thu, Jul 18, 02:24

Wed, Jul 17

deadalnix accepted D3688: [gitian-build] Bump default memory setting.
Wed, Jul 17, 23:30
deadalnix accepted D3686: [gitian-build] Fix repo directory to point at bitcoin-abc.
Wed, Jul 17, 23:29
deadalnix accepted D3687: [gitian-build] Default the number of jobs to the number of CPUs.
Wed, Jul 17, 23:29
deadalnix accepted D3690: [test_runner] Fix junitoutput typo.
Wed, Jul 17, 23:28
deadalnix accepted D3691: Fix a bug where the TeamCity build only reports one of the test_runner runs.

ju is probably about the worse name possible.

Wed, Jul 17, 23:27
deadalnix requested changes to D3679: Remove config as a class member of BlockAssembler.

This has not addressed the concern one bit.

Wed, Jul 17, 16:57

Tue, Jul 16

deadalnix requested changes to D3679: Remove config as a class member of BlockAssembler.

It doesn't looks like this is creating a self consistent API. In fact, you are importing assumption about the whole program (namely, that there is one config) into BlockAssembler, which a very clear and very bad regression.

Tue, Jul 16, 23:47
deadalnix created D3678: Nits in Qt test.
Tue, Jul 16, 13:21
deadalnix requested review of D3670: [tests] [qt] Add tests for address book manipulation via EditAddressDialog.
Tue, Jul 16, 13:13
deadalnix committed rABC20dfcce78ef2: [qt] Display more helpful message when adding a send address has failed (authored by James O'Beirne <james.obeirne@gmail.com>).
[qt] Display more helpful message when adding a send address has failed
Tue, Jul 16, 13:09
deadalnix closed D3669: [qt] Display more helpful message when adding a send address has failed.
Tue, Jul 16, 13:08
deadalnix committed rABCf06e9f7b610b: Add purpose arg to Wallet::getAddress (authored by James O'Beirne <james.obeirne@gmail.com>).
Add purpose arg to Wallet::getAddress
Tue, Jul 16, 13:05
deadalnix closed D3668: Add purpose arg to Wallet::getAddress.
Tue, Jul 16, 13:05
deadalnix committed rABCaf857482f5aa: [tests] [qt] Introduce qt/test/util with a generalized ConfirmMessage (authored by James O'Beirne <james.obeirne@gmail.com>).
[tests] [qt] Introduce qt/test/util with a generalized ConfirmMessage
Tue, Jul 16, 13:01
deadalnix closed D3666: [tests] [qt] Introduce qt/test/util with a generalized ConfirmMessage.
Tue, Jul 16, 13:01
deadalnix committed rABCd09a95d5f43d: Merge #9544: [trivial] Add end of namespace comments. Improve consistency. (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #9544: [trivial] Add end of namespace comments. Improve consistency.
Tue, Jul 16, 12:59
deadalnix closed D3619: Merge #9544: [trivial] Add end of namespace comments. Improve consistency..
Tue, Jul 16, 12:59

Mon, Jul 15

deadalnix accepted D3656: Merge #10793: Changing &var[0] to var.data().
Mon, Jul 15, 22:54
deadalnix committed rABC9a3a34b08c19: Add virtual transaction size to the transaction description in Qt (authored by deadalnix).
Add virtual transaction size to the transaction description in Qt
Mon, Jul 15, 22:48
deadalnix closed D3655: Add virtual transaction size to the transaction description in Qt.
Mon, Jul 15, 22:48
deadalnix committed rABC4ee17c4e7bd9: wallet: Change output type globals to members (authored by MarcoFalke <falke.marco@gmail.com>).
wallet: Change output type globals to members
Mon, Jul 15, 22:41
deadalnix closed D3665: wallet: Change output type globals to members.
Mon, Jul 15, 22:41
deadalnix committed rABC7cead03ca992: [wallet] Add change type to CCoinControl (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
[wallet] Add change type to CCoinControl
Mon, Jul 15, 19:25
deadalnix closed D3662: [wallet] Add change type to CCoinControl.
Mon, Jul 15, 19:24
deadalnix committed rABC79fdaf1e1e25: [wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH (authored by Sjors Provoost <sjors@sprovoost.nl>).
[wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH
Mon, Jul 15, 19:20
deadalnix closed D3661: [wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH.
Mon, Jul 15, 19:20
deadalnix committed rABC58bcb91efc72: [qt] receive tab: bech32 address opt-in checkbox (authored by Sjors Provoost <sjors@sprovoost.nl>).
[qt] receive tab: bech32 address opt-in checkbox
Mon, Jul 15, 19:17
deadalnix closed D3664: [qt] receive tab: bech32 address opt-in checkbox.
Mon, Jul 15, 19:17
deadalnix committed rABC9a7c92d30b2c: Bech32 addresses in dumpwallet (authored by fivepiece <fivepiece@users.noreply.github.com>).
Bech32 addresses in dumpwallet
Mon, Jul 15, 17:57
deadalnix closed D3663: Bech32 addresses in dumpwallet.
Mon, Jul 15, 17:57
deadalnix accepted D3675: [refactor multisig] remove redundant counters.
Mon, Jul 15, 16:20

Sun, Jul 14

deadalnix updated the diff for D3619: Merge #9544: [trivial] Add end of namespace comments. Improve consistency..

Update cland-format to enforce the new style

Sun, Jul 14, 17:53
deadalnix commandeered D3619: Merge #9544: [trivial] Add end of namespace comments. Improve consistency..
Sun, Jul 14, 17:49
deadalnix accepted D3586: [2 of 5] validation: Extract basic block file logic into FlatFileSeq class..
Sun, Jul 14, 17:12
deadalnix accepted D3626: [refactor multisig] separate nullfail from stack cleanup.
Sun, Jul 14, 17:06
deadalnix accepted D3673: [refactor multisig] move nulldummy check to front.
Sun, Jul 14, 17:04
deadalnix accepted D3674: remove ComparisonTestFramework dependency from segwit recovery test.
Sun, Jul 14, 16:56

Sat, Jul 13

deadalnix committed rABC655416f9d8cd: Use size_t for stack index in OP_MULTISIG (authored by deadalnix).
Use size_t for stack index in OP_MULTISIG
Sat, Jul 13, 10:50
deadalnix closed D3648: Use size_t for stack index in OP_MULTISIG.
Sat, Jul 13, 10:50
deadalnix accepted D3625: [refactor multisig] make const values up front.
Sat, Jul 13, 10:49
deadalnix accepted D3672: CONTRIBUTING.md - update instructions on linting dependencies.
Sat, Jul 13, 10:47

Fri, Jul 12

deadalnix accepted D3581: Merge #10657: Utils: Improvements to ECDSA key-handling code.
Fri, Jul 12, 23:57
deadalnix created D3670: [tests] [qt] Add tests for address book manipulation via EditAddressDialog.
Fri, Jul 12, 18:24
deadalnix created D3669: [qt] Display more helpful message when adding a send address has failed.
Fri, Jul 12, 18:12
deadalnix created D3668: Add purpose arg to Wallet::getAddress.
Fri, Jul 12, 18:01
deadalnix created D3666: [tests] [qt] Introduce qt/test/util with a generalized ConfirmMessage.
Fri, Jul 12, 17:48
deadalnix created D3665: wallet: Change output type globals to members.
Fri, Jul 12, 17:15
deadalnix created D3664: [qt] receive tab: bech32 address opt-in checkbox.
Fri, Jul 12, 16:52
deadalnix created D3663: Bech32 addresses in dumpwallet.
Fri, Jul 12, 15:39
deadalnix created D3662: [wallet] Add change type to CCoinControl.
Fri, Jul 12, 15:15
deadalnix created D3661: [wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH.
Fri, Jul 12, 13:37
deadalnix committed rABC059cdb971905: Enforce the use of TxId when constructing COutPoint (authored by deadalnix).
Enforce the use of TxId when constructing COutPoint
Fri, Jul 12, 12:26
deadalnix closed D3647: Enforce the use of TxId when constructing COutPoint.
Fri, Jul 12, 12:26
deadalnix accepted D3657: Merge #12298: Refactor HaveKeys to early return on false result.
Fri, Jul 12, 12:23

Thu, Jul 11

deadalnix committed rABC3293912dff81: Update rpcwallet.cpp to use TxId (authored by deadalnix).
Update rpcwallet.cpp to use TxId
Thu, Jul 11, 20:33
deadalnix closed D3645: Update rpcwallet.cpp to use TxId.
Thu, Jul 11, 20:33
deadalnix committed rABC6a813cdb8da7: Factor out outpoint generation in transaction_tests.cpp (authored by deadalnix).
Factor out outpoint generation in transaction_tests.cpp
Thu, Jul 11, 20:32
deadalnix closed D3643: Factor out outpoint generation in transaction_tests.cpp.
Thu, Jul 11, 20:31
deadalnix committed rABCaf06e6c3fb21: Use TxId in miner_tests.cpp (authored by deadalnix).
Use TxId in miner_tests.cpp
Thu, Jul 11, 20:26
deadalnix closed D3644: Use TxId in miner_tests.cpp.
Thu, Jul 11, 20:26
deadalnix created D3655: Add virtual transaction size to the transaction description in Qt.
Thu, Jul 11, 19:57
deadalnix closed D3646: Use txid in bloom tests.
Thu, Jul 11, 19:35
deadalnix committed rABCf3192ddd04cd: Use txid in bloom tests (authored by deadalnix).
Use txid in bloom tests
Thu, Jul 11, 19:35
deadalnix accepted D3653: Update chainparams.
Thu, Jul 11, 19:34
deadalnix committed rABCec39915f5d74: Wrap generation of randomized outpoint in tests (authored by deadalnix).
Wrap generation of randomized outpoint in tests
Thu, Jul 11, 17:25
deadalnix closed D3641: Wrap generation of randomized outpoint in tests.
Thu, Jul 11, 17:24
deadalnix requested changes to D3650: Fix null pointer dereference in SendCoinsEntry.

That's not good either. Removing the tooltip doesn't fix the problem.

Thu, Jul 11, 17:23
deadalnix accepted D3649: Avoid std::locale/imbue in DateTimeStrFormat.
Thu, Jul 11, 11:32
deadalnix requested changes to D3649: Avoid std::locale/imbue in DateTimeStrFormat.

THis fix for MSVC is not backported.

Thu, Jul 11, 11:19
deadalnix requested changes to D3650: Fix null pointer dereference in SendCoinsEntry.

This is reintroducing global state, so no.

Thu, Jul 11, 11:13
deadalnix committed rABC9c0570bf057e: outpt => output (authored by deadalnix).
outpt => output
Thu, Jul 11, 11:12
deadalnix closed D3642: outpt => output.
Thu, Jul 11, 11:12
deadalnix added inline comments to D3648: Use size_t for stack index in OP_MULTISIG.
Thu, Jul 11, 09:43
deadalnix accepted D3630: [wallet] setup wallet background flushing in WalletInit directly.
Thu, Jul 11, 01:49
deadalnix created D3648: Use size_t for stack index in OP_MULTISIG.
Thu, Jul 11, 01:26
deadalnix requested changes to D3502: Added a script to generate chainparams constants header files.

This is looking more like something, but:
1/ Naming is terrible, not even descriptive of anything.
2/ It seems strange to me that you need to rely on bitcoin-cli, when both bitcoin-cli and the test framework - this last one being in python, there may even be code that is reusable - manage to fetch the infos directly. Calling into the shell brings a ton fo baggage, especially since, presumably, this will be called from a shell to begin with.
3/ This require a fulling synced node for mainnet and testnet on the same machine running the script.
4/ It doesn't look like there is a way to only update mainnet or testnet.

Thu, Jul 11, 00:46

Wed, Jul 10

deadalnix accepted D3638: Merge #12988: Hold cs_main while calling UpdatedBlockTip() signal.
Wed, Jul 10, 23:59
deadalnix accepted D3639: Remove criptolayer.net from seeder lists.
Wed, Jul 10, 23:57
deadalnix requested changes to D3619: Merge #9544: [trivial] Add end of namespace comments. Improve consistency..

There is a tool that can do this automatically and exaustively. Use it.

Wed, Jul 10, 23:56
deadalnix requested changes to D3640: Merge #10481: Decodehextx scripts sanity check.

I'll just pretend that never saw this.

Wed, Jul 10, 23:52
deadalnix created D3647: Enforce the use of TxId when constructing COutPoint.
Wed, Jul 10, 23:49
deadalnix created D3646: Use txid in bloom tests.
Wed, Jul 10, 23:46
deadalnix created D3645: Update rpcwallet.cpp to use TxId.
Wed, Jul 10, 23:41
deadalnix created D3644: Use TxId in miner_tests.cpp.
Wed, Jul 10, 23:36
deadalnix created D3643: Factor out outpoint generation in transaction_tests.cpp.
Wed, Jul 10, 23:26
deadalnix created D3642: outpt => output.
Wed, Jul 10, 23:18
deadalnix created D3641: Wrap generation of randomized outpoint in tests.
Wed, Jul 10, 22:41
deadalnix committed rABC2be0a84fdf49: use TxId properly in coincontroldialog (authored by deadalnix).
use TxId properly in coincontroldialog
Wed, Jul 10, 21:28
deadalnix closed D3637: use TxId properly in coincontroldialog.
Wed, Jul 10, 21:28
deadalnix committed rABC7efaaeb4c10c: Rename wallet database classes (authored by Russell Yanofsky <russ@yanofsky.org>).
Rename wallet database classes
Wed, Jul 10, 18:11
deadalnix closed D3618: Rename wallet database classes.
Wed, Jul 10, 18:11
deadalnix committed rABC94d4e0a15975: wallet: Initialize m_last_block_processed to nullptr. Initialize fields where… (authored by practicalswift <practicalswift@users.noreply.github.com>).
wallet: Initialize m_last_block_processed to nullptr. Initialize fields where…
Wed, Jul 10, 18:10
deadalnix closed D3634: wallet: Initialize m_last_block_processed to nullptr. Initialize fields where defined..
Wed, Jul 10, 18:09
deadalnix updated the diff for D3634: wallet: Initialize m_last_block_processed to nullptr. Initialize fields where defined..

Remove mapRequestCount

Wed, Jul 10, 18:03
deadalnix added inline comments to D3634: wallet: Initialize m_last_block_processed to nullptr. Initialize fields where defined..
Wed, Jul 10, 18:00
deadalnix created D3637: use TxId properly in coincontroldialog.
Wed, Jul 10, 17:31