Page MenuHomePhabricator
Feed Advanced Search

Today

deadalnix updated the diff for D4072: Abstract out BlockAssembler options.

Ping. This has not recieved any substancial review for 10 days now.

Mon, Sep 23, 11:41
deadalnix committed rABC5fe43f2303a1: wallet: Use shared pointer to retain wallet instance (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
wallet: Use shared pointer to retain wallet instance
Mon, Sep 23, 11:33
deadalnix closed D4134: wallet: Use shared pointer to retain wallet instance.
Mon, Sep 23, 11:33
deadalnix updated the diff for D4134: wallet: Use shared pointer to retain wallet instance.

Rebase, fix conflicts, remove prev_version

Mon, Sep 23, 11:06
deadalnix requested review of D4134: wallet: Use shared pointer to retain wallet instance.
Mon, Sep 23, 11:01
deadalnix committed rABC630bb8df532e: scripted-diff: Replace boost::bind with std::bind (authored by deadalnix).
scripted-diff: Replace boost::bind with std::bind
Mon, Sep 23, 10:59
deadalnix closed D4133: scripted-diff: Replace boost::bind with std::bind.
Mon, Sep 23, 10:59
deadalnix committed rABC6615be98b28e: refactor: Use boost::scoped_connection in signal/slot, also prefer range-based… (authored by Chun Kuan Lee <ken2812221@gmail.com>).
refactor: Use boost::scoped_connection in signal/slot, also prefer range-based…
Mon, Sep 23, 10:57
deadalnix closed D4132: refactor: Use boost::scoped_connection in signal/slot, also prefer range-based loop instead of std::transform.
Mon, Sep 23, 10:57
deadalnix committed rABC00891cd619e5: Use TxId where apropriate in wallettests.cpp (authored by deadalnix).
Use TxId where apropriate in wallettests.cpp
Mon, Sep 23, 10:55
deadalnix closed D4135: Use TxId where apropriate in wallettests.cpp.
Mon, Sep 23, 10:55

Yesterday

deadalnix created D4135: Use TxId where apropriate in wallettests.cpp.
Sun, Sep 22, 22:03
deadalnix created D4134: wallet: Use shared pointer to retain wallet instance.
Sun, Sep 22, 21:54
deadalnix committed rABC8d88b38a5747: scripted-diff: batch-recase BanMan variables (authored by Carl Dong <accounts@carldong.me>).
scripted-diff: batch-recase BanMan variables
Sun, Sep 22, 12:47
deadalnix closed D4130: scripted-diff: batch-recase BanMan variables.
Sun, Sep 22, 12:47
deadalnix committed rABC8ab0ff176909: banman: Add, use CBanEntry ctor that takes ban reason (authored by Carl Dong <accounts@carldong.me>).
banman: Add, use CBanEntry ctor that takes ban reason
Sun, Sep 22, 12:45
deadalnix closed D4129: banman: Add, use CBanEntry ctor that takes ban reason.
Sun, Sep 22, 12:45
deadalnix committed rABC8c7329748182: banman: reformulate nBanUtil calculation (authored by Carl Dong <accounts@carldong.me>).
banman: reformulate nBanUtil calculation
Sun, Sep 22, 12:43
deadalnix closed D4128: banman: reformulate nBanUtil calculation.
Sun, Sep 22, 12:43
deadalnix committed rABC697f4827b1e5: banman: add thread annotations and mark members const where possible (authored by Cory Fields <cory-nospam-@coryfields.com>).
banman: add thread annotations and mark members const where possible
Sun, Sep 22, 12:41
deadalnix closed D4127: banman: add thread annotations and mark members const where possible.
Sun, Sep 22, 12:41
deadalnix committed rABC40b7384bad21: scripted-diff: batch-rename BanMan members (authored by Cory Fields <cory-nospam-@coryfields.com>).
scripted-diff: batch-rename BanMan members
Sun, Sep 22, 12:39
deadalnix closed D4126: scripted-diff: batch-rename BanMan members.
Sun, Sep 22, 12:39
deadalnix committed rABCf4d2c86a92a8: net: move BanMan to its own files (authored by Cory Fields <cory-nospam-@coryfields.com>).
net: move BanMan to its own files
Sun, Sep 22, 12:36
deadalnix closed D4125: net: move BanMan to its own files.
Sun, Sep 22, 12:35
deadalnix requested review of D4130: scripted-diff: batch-recase BanMan variables.
Sun, Sep 22, 11:50
deadalnix updated the diff for D4125: net: move BanMan to its own files.

Rebase, fix inlucdes due to D4131 and add comment on the #endif

Sun, Sep 22, 11:42
deadalnix added inline comments to D4125: net: move BanMan to its own files.
Sun, Sep 22, 11:36
deadalnix updated the summary of D4133: scripted-diff: Replace boost::bind with std::bind.
Sun, Sep 22, 11:35
deadalnix created D4133: scripted-diff: Replace boost::bind with std::bind.
Sun, Sep 22, 11:34
deadalnix committed rABCb825b6de3913: banman: pass in default ban time as a parameter (authored by Cory Fields <cory-nospam-@coryfields.com>).
banman: pass in default ban time as a parameter
Sun, Sep 22, 11:30
deadalnix closed D4124: banman: pass in default ban time as a parameter.
Sun, Sep 22, 11:29
deadalnix committed rABC1ca887fa7414: banman: pass the banfile path in (authored by Cory Fields <cory-nospam-@coryfields.com>).
banman: pass the banfile path in
Sun, Sep 22, 11:26
deadalnix closed D4117: banman: pass the banfile path in.
Sun, Sep 22, 11:26
deadalnix updated the diff for D4117: banman: pass the banfile path in.

Rebase and nits

Sun, Sep 22, 11:25
deadalnix committed rABC47d52f2e501f: banman: create and split out banman (authored by Cory Fields <cory-nospam-@coryfields.com>).
banman: create and split out banman
Sun, Sep 22, 11:21
deadalnix closed D4114: banman: create and split out banman.
Sun, Sep 22, 11:21
deadalnix created D4132: refactor: Use boost::scoped_connection in signal/slot, also prefer range-based loop instead of std::transform.
Sun, Sep 22, 11:09

Sat, Sep 21

deadalnix accepted D4122: Fix missing newline in make_chainparams.
Sat, Sep 21, 21:26
deadalnix committed rABCc3f3e6af6221: Move util files to directory (authored by deadalnix).
Move util files to directory
Sat, Sep 21, 18:14
deadalnix closed D4131: Move util files to directory.
Sat, Sep 21, 18:14
deadalnix created D4131: Move util files to directory.
Sat, Sep 21, 17:36
deadalnix updated the diff for D4072: Abstract out BlockAssembler options.

Rebase and ping

Sat, Sep 21, 12:41
deadalnix accepted D4118: Merge #13197: util: warn about ignored recursive -includeconf calls.
Sat, Sep 21, 12:06
deadalnix accepted D4123: [RPC] Fix header guard comment.
Sat, Sep 21, 12:05
deadalnix requested changes to D4123: [RPC] Fix header guard comment.
Sat, Sep 21, 12:05
deadalnix accepted D3805: Merge #12716: Fix typos and cleanup in various files.
Sat, Sep 21, 12:05
deadalnix accepted D4112: Merge #13079: Fix rescanblockchain rpc to properly report progress.
Sat, Sep 21, 12:04
deadalnix accepted D4029: Merge #13012: [doc] Add comments for chainparams.h, validation.cpp.
Sat, Sep 21, 11:59
deadalnix created D4130: scripted-diff: batch-recase BanMan variables.
Sat, Sep 21, 11:56
deadalnix created D4129: banman: Add, use CBanEntry ctor that takes ban reason.
Sat, Sep 21, 11:53
deadalnix created D4128: banman: reformulate nBanUtil calculation.
Sat, Sep 21, 11:41
deadalnix created D4127: banman: add thread annotations and mark members const where possible.
Sat, Sep 21, 11:26
deadalnix created D4126: scripted-diff: batch-rename BanMan members.
Sat, Sep 21, 11:15
deadalnix created D4125: net: move BanMan to its own files.
Sat, Sep 21, 11:02
deadalnix created D4124: banman: pass in default ban time as a parameter.
Sat, Sep 21, 10:28
deadalnix committed rABC825e09ba4a76: Use C++11 default member initializers (authored by MarcoFalke <falke.marco@gmail.com>).
Use C++11 default member initializers
Sat, Sep 21, 10:05
deadalnix closed D4091: Use C++11 default member initializers.
Sat, Sep 21, 10:05

Fri, Sep 20

deadalnix accepted D4113: [CMAKE] Remove useless dependency for the check-rpcauth target.
Fri, Sep 20, 16:55
deadalnix updated the diff for D4114: banman: create and split out banman.

Move comments around and remove explicit keyword

Fri, Sep 20, 16:31
deadalnix accepted D4039: [CMAKE] Fix linux cross compilation with the glibc compatibility.
Fri, Sep 20, 16:16
deadalnix accepted D4079: debug log number of unknown wallet records on load.
Fri, Sep 20, 16:15
deadalnix requested changes to D4116: [CMAKE] Only change obj/build.h if the content has changed.
Fri, Sep 20, 16:09
deadalnix committed rABC4a43c7ee730f: Use std::make_unique more consistently (authored by deadalnix).
Use std::make_unique more consistently
Fri, Sep 20, 16:02
deadalnix closed D4115: Use std::make_unique more consistently.
Fri, Sep 20, 16:01
deadalnix updated the summary of D4117: banman: pass the banfile path in.
Fri, Sep 20, 16:00
deadalnix created D4117: banman: pass the banfile path in.
Fri, Sep 20, 15:55
deadalnix requested changes to D4116: [CMAKE] Only change obj/build.h if the content has changed.
Fri, Sep 20, 13:39
deadalnix created D4115: Use std::make_unique more consistently.
Fri, Sep 20, 13:08
deadalnix created D4114: banman: create and split out banman.
Fri, Sep 20, 12:35
deadalnix committed rABC77a40c9061cd: Remove unecessary obj folder (authored by deadalnix).
Remove unecessary obj folder
Fri, Sep 20, 12:03
deadalnix closed D4110: Remove unecessary obj folder.
Fri, Sep 20, 12:03

Thu, Sep 19

deadalnix accepted D4111: [CMAKE] Always build obj/build.h.
Thu, Sep 19, 17:44
deadalnix requested changes to D4111: [CMAKE] Always build obj/build.h.
Thu, Sep 19, 13:40
deadalnix requested changes to D4111: [CMAKE] Always build obj/build.h.

The dependencies are obviously incorrect (there are none).

Thu, Sep 19, 12:38
deadalnix accepted D4078: [qt] send: Clear All also resets coin control options.
Thu, Sep 19, 11:57
deadalnix added a comment to D4039: [CMAKE] Fix linux cross compilation with the glibc compatibility.

While this is clearly not the right solution, we can move on with that for the sake of progress. The longer term solution is to add all we depend on in the depends.

Thu, Sep 19, 11:09
deadalnix created D4110: Remove unecessary obj folder.
Thu, Sep 19, 09:39
deadalnix accepted D4005: cli: Ignore libevent warnings.
Thu, Sep 19, 08:15
deadalnix accepted D4104: Partial Merge #12920: test: Fix sign for expected values.
Thu, Sep 19, 08:14
deadalnix added a comment to D4105: Merge #13383: bench: Use non-throwing ParseDouble(...) instead of throwing boost::lexical_cast<double>(...).

This is a duplicate of D4080

Thu, Sep 19, 08:14
deadalnix accepted D4106: Merge #13234: Break circular dependency: chain -> pow -> chain.
Thu, Sep 19, 08:12
deadalnix committed rSTAGING555fded986aa: net: split up addresses/ban dumps in preparation for moving them (authored by Cory Fields <cory-nospam-@coryfields.com>).
net: split up addresses/ban dumps in preparation for moving them
Thu, Sep 19, 02:25
deadalnix committed rSTAGINGfbe5b35601f6: Remove GetNextBlockScriptFlags's requirement to hold cs_main (authored by deadalnix).
Remove GetNextBlockScriptFlags's requirement to hold cs_main
Thu, Sep 19, 02:24
deadalnix committed rSTAGING0ba7f1945c07: Add compile time checking for all cs_main runtime locking assertions (authored by practicalswift <practicalswift@users.noreply.github.com>).
Add compile time checking for all cs_main runtime locking assertions
Thu, Sep 19, 02:24
deadalnix committed rSTAGING08af61078c59: Use C++11 default member initializers (authored by MarcoFalke <falke.marco@gmail.com>).
Use C++11 default member initializers
Thu, Sep 19, 02:24
deadalnix committed rSTAGING26c617190d1b: Drop unused pindexRet arg to CMerkleTx::GetDepthInMainChain (authored by Ben Woosley <ben.woosley@gmail.com>).
Drop unused pindexRet arg to CMerkleTx::GetDepthInMainChain
Thu, Sep 19, 02:24
deadalnix committed rSTAGING0643cf7b9687: Add recommendation: By default, declare single-argument constructors `explicit` (authored by practicalswift <practicalswift@users.noreply.github.com>).
Add recommendation: By default, declare single-argument constructors `explicit`
Thu, Sep 19, 02:23
deadalnix committed rSTAGING6e77d83988a8: Nits in httpserver.cpp (authored by deadalnix).
Nits in httpserver.cpp
Thu, Sep 19, 02:23
deadalnix committed rSTAGING5d541c439495: Move SocketHandler logic to private method. (authored by Patrick Strateman <patrick.strateman@gmail.com>).
Move SocketHandler logic to private method.
Thu, Sep 19, 02:23
deadalnix committed rSTAGING9b97fa8bb7c4: Move InactivityCheck logic to private method. (authored by Patrick Strateman <patrick.strateman@gmail.com>).
Move InactivityCheck logic to private method.
Thu, Sep 19, 02:22
deadalnix committed rSTAGING00e4ec254731: Move DisconnectNodes logic to private method. (authored by Patrick Strateman <patrick.strateman@gmail.com>).
Move DisconnectNodes logic to private method.
Thu, Sep 19, 02:22
deadalnix committed rSTAGINGfe55cba91008: Move NotifyNumConnectionsChanged logic to private method. (authored by Patrick Strateman <patrick.strateman@gmail.com>).
Move NotifyNumConnectionsChanged logic to private method.
Thu, Sep 19, 02:22
deadalnix committed rSTAGING70b9a1207e4e: tests: remove member connman/peerLogic in TestingSetup (authored by Cory Fields <cory-nospam-@coryfields.com>).
tests: remove member connman/peerLogic in TestingSetup
Thu, Sep 19, 02:22
deadalnix committed rSTAGINGb1ac99112da7: Convert comments to thread safety annotations (authored by MarcoFalke <falke.marco@gmail.com>).
Convert comments to thread safety annotations
Thu, Sep 19, 02:22
deadalnix committed rSTAGING487210686b0a: net: Add Clang thread safety annotations for guarded variables in the… (authored by practicalswift <practicalswift@users.noreply.github.com>).
net: Add Clang thread safety annotations for guarded variables in the…
Thu, Sep 19, 02:22
deadalnix committed rSTAGING57c2fde3f33f: Report minfeefilter value in getpeerinfo rpc (authored by Anthony Towns <aj@erisian.com.au>).
Report minfeefilter value in getpeerinfo rpc
Thu, Sep 19, 02:22
deadalnix committed rSTAGING16854d62f596: Prefer wait_until over polling with time.sleep (authored by Ben Woosley <ben.woosley@gmail.com>).
Prefer wait_until over polling with time.sleep
Thu, Sep 19, 02:21
deadalnix committed rSTAGING8fb2d6add9a1: Improve reliability of avalanche test (authored by deadalnix).
Improve reliability of avalanche test
Thu, Sep 19, 02:20
deadalnix committed rSTAGINGeb13cb19e858: net: Break disconnecting out of Ban() (authored by Cory Fields <cory-nospam-@coryfields.com>).
net: Break disconnecting out of Ban()
Thu, Sep 19, 02:20