Accepting because doing all the nits + the backport would become very tedious. I trust you'll follow through.
Tue, Dec 11
Sat, Dec 8
Fix mixture of tab and spaces
Back on your queue, this is apparently breaking many tests.
@markblundeberg Both are necessary. one is a public API, one is a private one.
reorder code so verify come before sign. This allows to change the signature code (for instance for multisig) without causing the verification code lost in the middle of the signature code.
remove useless static
Fri, Dec 7
Refactor the signing code.
- Extract a function to generate a proper value for k
- Use that fucntion in the signing code.
Some small nits, but overall it's good.
Use R.x in part of the explaination where r is not defined
Thu, Dec 6
Tue, Dec 4
Explain test cases more in details.
Mon, Dec 3
Sun, Dec 2
Please investigate with harbormaster is failing before landing.
I have no idea what problem this diff solves.
Add explaination about error codes
Add explainations and link for the blakc magic.
Add parenthesis to make the compiler happy.
This ends up changing all the tests for no good reasons. Just add the new tests cases after the existing ones. You can use reconsiderblock/invalidate block to recreate the situation you desire.
A few small changes, but LGTM.