Page MenuHomePhabricator
Feed Advanced Search

Today

deadalnix accepted D4502: Add BitcoinApplication & RPCConsole tests.
Fri, Nov 22, 00:10

Yesterday

deadalnix created D4508: Kill AddKeypathToMap.
Thu, Nov 21, 23:34
deadalnix committed rABC8a31c2afd39f: util: Add [[nodiscard]] to all {Decode,Parse}[...](...) functions returning bool (authored by practicalswift <practicalswift@users.noreply.github.com>).
util: Add [[nodiscard]] to all {Decode,Parse}[...](...) functions returning bool
Thu, Nov 21, 23:27
deadalnix closed D4501: util: Add [[nodiscard]] to all {Decode,Parse}[...](...) functions returning bool.
Thu, Nov 21, 23:27
deadalnix committed rABCb386fce87d7b: Make SignPSBTInput operate on a private SignatureData object (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Make SignPSBTInput operate on a private SignatureData object
Thu, Nov 21, 23:20
deadalnix closed D4494: Make SignPSBTInput operate on a private SignatureData object.
Thu, Nov 21, 23:20
deadalnix committed rABC0f0b515c75a8: Pass HD path data through SignatureData (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Pass HD path data through SignatureData
Thu, Nov 21, 23:15
deadalnix closed D4493: Pass HD path data through SignatureData.
Thu, Nov 21, 23:14
deadalnix committed rABCf3f969bc3917: Implement key origin lookup in CWallet (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Implement key origin lookup in CWallet
Thu, Nov 21, 23:09
deadalnix closed D4491: Implement key origin lookup in CWallet.
Thu, Nov 21, 23:09
deadalnix committed rABCa3884c52a1cc: wallet: Fix non-determinism in ParseHDKeypath(...). Avoid using an… (authored by practicalswift <practicalswift@users.noreply.github.com>).
wallet: Fix non-determinism in ParseHDKeypath(...). Avoid using an…
Thu, Nov 21, 23:07
deadalnix closed D4500: wallet: Fix non-determinism in ParseHDKeypath(...). Avoid using an uninitialized variable in path calculation..
Thu, Nov 21, 23:07
deadalnix committed rABC93aa869bfd7e: Generalize PublicOnlySigningProvider into HidingSigningProvider (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Generalize PublicOnlySigningProvider into HidingSigningProvider
Thu, Nov 21, 23:06
deadalnix closed D4490: Generalize PublicOnlySigningProvider into HidingSigningProvider.
Thu, Nov 21, 23:06
deadalnix committed rABCba3dabfd5980: More tests of signer checks (authored by Andrew Chow <achow101-github@achow101.com>).
More tests of signer checks
Thu, Nov 21, 23:01
deadalnix closed D4485: More tests of signer checks.
Thu, Nov 21, 23:01
deadalnix committed rABCe6c6db649672: Update valid PSBT test vectors so that they properly use the value 0 for… (authored by deadalnix).
Update valid PSBT test vectors so that they properly use the value 0 for…
Thu, Nov 21, 22:56
deadalnix closed D4498: Update valid PSBT test vectors so that they properly use the value 0 for utxos's key.
Thu, Nov 21, 22:56
deadalnix updated the diff for D4498: Update valid PSBT test vectors so that they properly use the value 0 for utxos's key.

Rebase and run the test suite

Thu, Nov 21, 17:19
deadalnix requested changes to D4300: Integrate gArgs and chainparams into the Seeder.
Thu, Nov 21, 15:59
deadalnix requested changes to D4495: minor refactor to use ranged_for, auto and const-ness.

I fell like you are a bit overdoing it with auto here. I'm not against auto in general, but C++ is a bit trigger happy with copies and implicit conversions.

Thu, Nov 21, 15:45
deadalnix accepted D4497: Move BitcoinApplication to header so it can be tested.
Thu, Nov 21, 14:36
deadalnix accepted D4499: Allow to pass the chain parameters when formatting a bitcoin URI.
Thu, Nov 21, 14:36
deadalnix created D4501: util: Add [[nodiscard]] to all {Decode,Parse}[...](...) functions returning bool.
Thu, Nov 21, 14:13
deadalnix created D4500: wallet: Fix non-determinism in ParseHDKeypath(...). Avoid using an uninitialized variable in path calculation..
Thu, Nov 21, 14:07
deadalnix updated the diff for D4485: More tests of signer checks.

Actually add the tests that were previusly put in another section by mistake

Thu, Nov 21, 13:40
deadalnix requested changes to D4497: Move BitcoinApplication to header so it can be tested.
Thu, Nov 21, 12:09
deadalnix created D4498: Update valid PSBT test vectors so that they properly use the value 0 for utxos's key.
Thu, Nov 21, 11:24
deadalnix added inline comments to D4474: Added support for -gravitonactivationtime to unit tests.
Thu, Nov 21, 10:01

Wed, Nov 20

deadalnix added a comment to D4496: Split out key-value parsing in ArgsManager into its own function.

Considering there are still many backports to do in there, I don't think this is very wise to go there.

Wed, Nov 20, 22:50
deadalnix accepted D4474: Added support for -gravitonactivationtime to unit tests.
Wed, Nov 20, 22:13
deadalnix updated the diff for D4491: Implement key origin lookup in CWallet.

Rebase and fix merge conflict

Wed, Nov 20, 21:40
deadalnix requested changes to D4300: Integrate gArgs and chainparams into the Seeder.

Use the goddamn ChanParams. You broke the net magic and introduce many branches you don't need to introduce.

Wed, Nov 20, 21:39
deadalnix committed rABCd32a1d5f5fe6: Make SigningProvider expose key origin information (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Make SigningProvider expose key origin information
Wed, Nov 20, 21:25
deadalnix closed D4489: Make SigningProvider expose key origin information.
Wed, Nov 20, 21:25
deadalnix committed rABC239e9c2a5517: [MOVEONLY] Move ParseHDKeypath to utilstrencodings (authored by Pieter Wuille <pieter.wuille@gmail.com>).
[MOVEONLY] Move ParseHDKeypath to utilstrencodings
Wed, Nov 20, 21:21
deadalnix closed D4488: [MOVEONLY] Move ParseHDKeypath to utilstrencodings.
Wed, Nov 20, 21:21
deadalnix requested changes to D4495: minor refactor to use ranged_for, auto and const-ness.
Wed, Nov 20, 21:17
deadalnix committed rABC961cb3f865d5: Introduce KeyOriginInfo for fingerprint + path (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Introduce KeyOriginInfo for fingerprint + path
Wed, Nov 20, 21:13
deadalnix closed D4486: Introduce KeyOriginInfo for fingerprint + path.
Wed, Nov 20, 21:12
deadalnix requested changes to D4474: Added support for -gravitonactivationtime to unit tests.

What about using this: https://www.boost.org/doc/libs/1_71_0/libs/test/doc/html/boost_test/runtime_config/custom_command_line_arguments.html ?

Wed, Nov 20, 18:19
deadalnix accepted D4492: Don't use systray icon on inappropriate systems.
Wed, Nov 20, 17:53
deadalnix created D4494: Make SignPSBTInput operate on a private SignatureData object.
Wed, Nov 20, 17:43
deadalnix updated the summary of D4493: Pass HD path data through SignatureData.
Wed, Nov 20, 17:43
deadalnix created D4493: Pass HD path data through SignatureData.
Wed, Nov 20, 17:36
deadalnix accepted D4487: [CMAKE] Add DBus support to bitcoin-qt.
Wed, Nov 20, 16:34
deadalnix created D4491: Implement key origin lookup in CWallet.
Wed, Nov 20, 16:30
deadalnix created D4490: Generalize PublicOnlySigningProvider into HidingSigningProvider.
Wed, Nov 20, 16:26
deadalnix updated the summary of D4488: [MOVEONLY] Move ParseHDKeypath to utilstrencodings.
Wed, Nov 20, 16:22
deadalnix created D4489: Make SigningProvider expose key origin information.
Wed, Nov 20, 16:21
deadalnix created D4488: [MOVEONLY] Move ParseHDKeypath to utilstrencodings.
Wed, Nov 20, 16:18
deadalnix created D4486: Introduce KeyOriginInfo for fingerprint + path.
Wed, Nov 20, 16:14
deadalnix accepted D4304: Merge #9662: Add createwallet "disableprivatekeys" option: a sane mode for watchonly-wallets.
Wed, Nov 20, 14:30
deadalnix accepted D4445: [CMAKE] Use a NSIS custom template.
Wed, Nov 20, 14:17
deadalnix accepted D4484: qt: All tray menu actions call showNormalIfMinimized.
Wed, Nov 20, 14:13
deadalnix accepted D4483: qt: Use GUIUtil::bringToFront where possible.
Wed, Nov 20, 14:12
deadalnix accepted D4482: qt: Add GUIUtil::bringToFront.
Wed, Nov 20, 14:11
deadalnix accepted D4481: Remove obj_c for macOS Dock icon menu.
Wed, Nov 20, 14:10
deadalnix accepted D4480: Use Qt signal for macOS Dock icon click event.
Wed, Nov 20, 14:09
deadalnix requested changes to D4474: Added support for -gravitonactivationtime to unit tests.

You just removed the ability to use just about 90% of boost's unit tests abilities.

Wed, Nov 20, 13:30
deadalnix created D4485: More tests of signer checks.
Wed, Nov 20, 12:51
deadalnix committed rABC64b198f39284: Test that a non-witness script as witness utxo is not signed (authored by Andrew Chow <achow101-github@achow101.com>).
Test that a non-witness script as witness utxo is not signed
Wed, Nov 20, 12:47
deadalnix closed D4475: Test that a non-witness script as witness utxo is not signed.
Wed, Nov 20, 12:46
deadalnix committed rABC0f2655706817: Use 72 byte dummy signatures when watching only inputs may be used (authored by Andrew Chow <achow101-github@achow101.com>).
Use 72 byte dummy signatures when watching only inputs may be used
Wed, Nov 20, 12:44
deadalnix closed D4470: Use 72 byte dummy signatures when watching only inputs may be used.
Wed, Nov 20, 12:44
deadalnix committed rABC0f5488cfa05d: Use 71 byte signature for DUMMY_SIGNATURE_CREATOR (authored by Andrew Chow <achow101-github@achow101.com>).
Use 71 byte signature for DUMMY_SIGNATURE_CREATOR
Wed, Nov 20, 12:38
deadalnix closed D4468: Use 71 byte signature for DUMMY_SIGNATURE_CREATOR.
Wed, Nov 20, 12:38
deadalnix committed rABC1a5829a4b8bf: Always create 70 byte signatures with low R values (authored by Andrew Chow <achow101-github@achow101.com>).
Always create 70 byte signatures with low R values
Wed, Nov 20, 12:36
deadalnix closed D4467: Always create 70 byte signatures with low R values.
Wed, Nov 20, 12:35
deadalnix committed rABCd9e677821dc6: Additional sanity checks in SignPSBTInput (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Additional sanity checks in SignPSBTInput
Wed, Nov 20, 12:29
deadalnix closed D4459: Additional sanity checks in SignPSBTInput.
Wed, Nov 20, 12:29

Tue, Nov 19

deadalnix accepted D4407: [GITIAN] Migrate OSX Gitian builds to CMake and Ninja.
Tue, Nov 19, 23:39
deadalnix accepted D4404: [CMAKE] Migrate windows gitian build to cmake and ninja.
Tue, Nov 19, 23:37
deadalnix accepted D4472: Remove obj_c for macOS Dock icon setting.
Tue, Nov 19, 23:34
deadalnix created D4475: Test that a non-witness script as witness utxo is not signed.
Tue, Nov 19, 18:07
deadalnix committed rABC449bfe2bb4b2: Add missing braces on key.cpp (authored by deadalnix).
Add missing braces on key.cpp
Tue, Nov 19, 17:09
deadalnix closed D4466: Add missing braces on key.cpp.
Tue, Nov 19, 17:09
deadalnix created D4470: Use 72 byte dummy signatures when watching only inputs may be used.
Tue, Nov 19, 15:53
deadalnix created D4468: Use 71 byte signature for DUMMY_SIGNATURE_CREATOR.
Tue, Nov 19, 15:15
deadalnix created D4467: Always create 70 byte signatures with low R values.
Tue, Nov 19, 14:48
deadalnix created D4466: Add missing braces on key.cpp.
Tue, Nov 19, 13:57
deadalnix accepted D4465: Break circular dependency: init -> * -> init by extracting shutdown.h.

Go on, trash my ccache :)

Tue, Nov 19, 13:39
deadalnix accepted D4464: Drop unused init.h includes.
Tue, Nov 19, 13:33
deadalnix updated the diff for D4459: Additional sanity checks in SignPSBTInput.

Remove 'both'

Tue, Nov 19, 13:25

Mon, Nov 18

deadalnix accepted D4461: Add aarch64 qt depends support for cross compiling bitcoin-qt.
Mon, Nov 18, 17:51
deadalnix created D4459: Additional sanity checks in SignPSBTInput.
Mon, Nov 18, 15:17
deadalnix accepted D4356: [CMAKE] Migrate linux gitian build to cmake and ninja.
Mon, Nov 18, 13:59
deadalnix committed rABC6baa2c0642de: Fix merging of global unknown data in PSBTs (authored by Andrew Chow <achow101-github@achow101.com>).
Fix merging of global unknown data in PSBTs
Mon, Nov 18, 13:36
deadalnix closed D4457: Fix merging of global unknown data in PSBTs.
Mon, Nov 18, 13:36
deadalnix committed rABCd395b70087cb: Check that PSBT keys are the correct length (authored by Andrew Chow <achow101-github@achow101.com>).
Check that PSBT keys are the correct length
Mon, Nov 18, 13:30
deadalnix closed D4456: Check that PSBT keys are the correct length.
Mon, Nov 18, 13:29
deadalnix committed rABC5b3bb8c4ef57: Add brace in bitcoin-tx.cpp (authored by deadalnix).
Add brace in bitcoin-tx.cpp
Mon, Nov 18, 13:23
deadalnix closed D4458: Add brace in bitcoin-tx.cpp.
Mon, Nov 18, 13:23
deadalnix committed rABCe8f1ceb01f0c: Fix PSBT error test vectors (authored by deadalnix).
Fix PSBT error test vectors
Mon, Nov 18, 13:19
deadalnix closed D4454: Fix PSBT error test vectors.
Mon, Nov 18, 13:19
deadalnix committed rABCc453a23e9675: Add outputtype module (authored by Anthony Towns <aj@erisian.com.au>).
Add outputtype module
Mon, Nov 18, 13:18
deadalnix closed D4424: Add outputtype module.
Mon, Nov 18, 13:18
deadalnix added inline comments to D4304: Merge #9662: Add createwallet "disableprivatekeys" option: a sane mode for watchonly-wallets.
Mon, Nov 18, 00:23

Sun, Nov 17

deadalnix requested changes to D4300: Integrate gArgs and chainparams into the Seeder.

It's getting there, this is now much better, but there are still a few things that could be improved.

Sun, Nov 17, 23:55
deadalnix created D4458: Add brace in bitcoin-tx.cpp.
Sun, Nov 17, 23:43