Page MenuHomePhabricator
Differential D11699

[avalanche] Send an empty compact proofs request if there is no shortid
AbandonedPublic
Actions

Authored by Fabien on Jul 4 2022, 09:17.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

Be nice with our peer and let it know that we have nothing to request. This will prevent from running into the timeout cleanup process because our node is not responding.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_send_empty_avareq
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19540
Build 38799: Build Diffbuild-diff · lint-circular-dependencies · build-debug · build-without-wallet · build-clang · build-clang-tidy
Build 38798: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 4 2022, 09:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 4 2022, 09:17
Fabien requested review of this revision.Jul 4 2022, 09:17
Harbormaster completed remote builds in B19540: Diff 34229.Jul 4 2022, 09:31
deadalnix requested changes to this revision.Jul 5 2022, 13:00
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/net_processing.cpp
5336–5343

I don't think this solve any practical problem other than that maybe, indicating that the quorum criterion may be poorly chosen.

This revision now requires changes to proceed.Jul 5 2022, 13:00
Fabien abandoned this revision.Jul 27 2022, 12:00

Revision Contents
Changeset List

PathSize
src/
21 lines
test/
functional/
18 lines
11 lines

Diff 34229

View Options

src/net_processing.cpp

Loading...
View Options

test/functional/abc_p2p_avalanche_quorum.py

Loading...
View Options

test/functional/abc_p2p_compactproofs.py

Loading...