The connected node count is actually retrieved from the node set size rather than counting the nodes attached to peers. Unde some special circumstances, where a node recently polled disconnects, the node structure is not immediately removed so if it reconnects shortly we don't drop the avacooldown value and overquery it. In this case the values returned by the RPC can be wrong and confusing. Otherwise there is no change in behavior.
Details
Details
- Reviewers
deadalnix - Group Reviewers
Restricted Project - Commits
- rABCff5b5c6ce3e4: [avalanche] Fix occasional invalid node count in getavalancheinfo
./test/functional/test_runner.py abc_rpc_getavalancheinfo
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
src/rpc/avalanche.cpp | ||
---|---|---|
780 ↗ | (On Diff #34482) | Maybe this should be either removed or renamed. |