Differential D11556

Clarify that m_tx_relay and m_proof_relay are thread safe
ClosedPublic
Actions

Authored by Fabien on Jun 2 2022, 09:15.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC9b3ef55ab499: Clarify that m_tx_relay and m_proof_relay are thread safe

Summary

They CNode members are set once at construction time and then read only, but this is unclear because they are not declared const. This diff makes them const so this is clear they are thread safe.

Test Plan

ninja all check-all

../contrib/teamcity/build-configurations.py build-tsan

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jun 2 2022, 09:15

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 2 2022, 09:15

Fabien requested review of this revision.Jun 2 2022, 09:15

Fabien mentioned this in D11549: [avalanche] Request compact proofs from our avalanche outbound peers.Jun 2 2022, 09:23

Harbormaster completed remote builds in B19229: Diff 33782.Jun 2 2022, 09:31

deadalnix accepted this revision.Jun 2 2022, 12:02

This revision is now accepted and ready to land.Jun 2 2022, 12:02

Closed by commit rABC9b3ef55ab499: Clarify that m_tx_relay and m_proof_relay are thread safe (authored by Fabien). · Explain WhyJun 2 2022, 13:24

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC9b3ef55ab499: Clarify that m_tx_relay and m_proof_relay are thread safe.

Revision Contents
Changeset List

Path

Size

src/

net.h

4 lines

net.cpp

13 lines

Diff 33784

View Options

src/net.h