Page MenuHomePhabricator

[avalanche] Update the default proof constructor so it can pass a serialization roundtrip
AbandonedPublic

Authored by Fabien on May 23 2022, 09:59.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

This makes it possible to serialize/deserialize a default constructed proof.
This is currently failing because the IDs are set to zero rather than computed from the proof parameters. This will be required for testing the serialization/deserialization of a ProofRef.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_proof_defaultconstructor
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19132
Build 38012: Build Difflint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 38011: arc lint + arc unit

Event Timeline

Fabien requested review of this revision.May 23 2022, 09:59
deadalnix requested changes to this revision.May 23 2022, 11:44
deadalnix added a subscriber: deadalnix.

Why do we want to compute the id of a proof that isn't initialized, and then recompute the correct one later? That doesn't make sense.

This revision now requires changes to proceed.May 23 2022, 11:44