Differential D11466

[avalanche] Turn ProofRef into a RCUPtr
ClosedPublic
Actions

Authored by Fabien on May 14 2022, 00:27.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCcf9bb51b9c91: [avalanche] Turn ProofRef into a RCUPtr

Summary

As per title. This requires to replace the make_shared calls with a call to the RCU factory instead. A move constructor for the proof is needed in order to facilitate deserializing a proof then building the pointer.

Depends on D11509.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.May 14 2022, 00:27

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 14 2022, 00:27

Fabien requested review of this revision.May 14 2022, 00:27

Harbormaster completed remote builds in B19031: Diff 33520.May 14 2022, 00:57

deadalnix requested changes to this revision.May 14 2022, 01:32

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

src/avalanche/proof.h
142 ↗	(On Diff #33520)	How is that not exploding with fireworks? You obviously don't want to do this.
src/rpc/avalanche.cpp
947 ↗	(On Diff #33520)	Why do you allocate the proof on stack then move it on heap?

This revision now requires changes to proceed.May 14 2022, 01:32

Fabien added inline comments.May 14 2022, 01:40

src/rpc/avalanche.cpp
947 ↗	(On Diff #33520)	I'm avoiding the constness from the ProofRef by using some mutable first then moving the data into the ptr to const

Don't copy the refcount

Harbormaster completed remote builds in B19034: Diff 33523.May 14 2022, 02:10

deadalnix requested changes to this revision.May 19 2022, 17:27

deadalnix added inline comments.

src/avalanche/processor.cpp
192 ↗	(On Diff #33523)	It does looks like to me this is allocated int he wrong place.
199 ↗	(On Diff #33523)	The new line should be before this statement, not after.
src/rpc/avalanche.cpp
947 ↗	(On Diff #33520)	Why isn't this a problem with shared_ptr?