Differential D11582
[avalanche] Limit the size of the valid proof pool Authored by sdulfari on Jun 7 2022, 22:05.
Details
The peer manager will now only maintain up to 4000 valid proofs. Since it's This patch indirectly imposes a limit on the conflict pool as well, since only Depends on D11562 ninja check-avalanche
Diff Detail
Event TimelineComment Actions Maybe we should just evict proof for which we have no peer after some time instead. We kind of have to do it anyways, and this makes this patch moot as far as I can tell. Comment Actions You might be right. But in order to remove this pool limit safely, we need to consider how this impacts peer selection (due to DEFAULT_MAX_PEER_CONNECTIONS) and potentially other parts of the net code that we have not yet touched. Having this limit may also impact how staking rewards is implemented but there are more open questions for that one. Ultimately this patch will help us launch Avalanche on mainnet in the short term while we learn from real world data and continue to the next stage. I planned changes for a different reason. I'm investigating an edge case. Comment Actions No this does not help, because you'll have to get rid of proofs for which there is no node regardless. In fact, not only do you need to, but this becomes significantly more important to once you limit how many proofs you can accept. |