Page MenuHomePhabricator
Differential D11561

[avalanche] Add a way to count the number of proofs in a ProofPool
ClosedPublic
Actions

Authored by sdulfari on Jun 3 2022, 04:04.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC1302000df761: [avalanche] Add a way to count the number of proofs in a ProofPool
Summary

This is the first piece needed in order to cap the size of proof pools by the
number of proofs. A simple cache of the proof count is provided to short
circuit the O(n) loop if nothing in the pool has changed.

Test Plan
ninja check-avalanche

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sdulfari created this revision.Jun 3 2022, 04:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 3 2022, 04:04
sdulfari requested review of this revision.Jun 3 2022, 04:04
sdulfari added inline comments.Jun 3 2022, 04:05
src/avalanche/proofpool.cpp
72 ↗(On Diff #33798)

Technically this is redundant with the flag set in addProofIfNoConflict() but it's good form in case the implementation in this function changes in the future.

sdulfari added a child revision: D11562: [avalanche] Add a way to get the lowest scoring proof in a pool.Jun 3 2022, 04:11
Harbormaster completed remote builds in B19241: Diff 33798.Jun 3 2022, 04:19
Fabien requested changes to this revision.Jun 4 2022, 01:29
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/avalanche/proofpool.cpp
87 ↗(On Diff #33798)

You need to clear the cache here.
This also indicates a missing test case

This revision now requires changes to proceed.Jun 4 2022, 01:29
sdulfari updated this revision to Diff 33829.Jun 6 2022, 17:25

Fix cache clearing during rescan and test it

Harbormaster completed remote builds in B19263: Diff 33829.Jun 6 2022, 17:41
Fabien accepted this revision.Jun 6 2022, 18:45
This revision is now accepted and ready to land.Jun 6 2022, 18:45
Closed by commit rABC1302000df761: [avalanche] Add a way to count the number of proofs in a ProofPool (authored by sdulfari). · Explain WhyJun 6 2022, 23:37
This revision was automatically updated to reflect the committed changes.
sdulfari added a commit: rABC1302000df761: [avalanche] Add a way to count the number of proofs in a ProofPool.

Revision Contents
Changeset List

PathSize
src/
avalanche/
4 lines
25 lines
test/
14 lines

Diff 33836

View Options

src/avalanche/proofpool.h

Loading...
View Options

src/avalanche/proofpool.cpp

Loading...
View Options

src/avalanche/test/proofpool_tests.cpp

Loading...