Page MenuHomePhabricator
Differential D11548

[avalanche] Make stale voting parameters configurable
ClosedPublic
Actions

Authored by sdulfari on May 31 2022, 18:27.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCc8b5dd7de231: [avalanche] Make stale voting parameters configurable
Summary

As we write more tests involving stale votes, functional testing times get too long.
This patch makes those voting parameters configurable and saves ~40 seconds when
running abc_p2p_avalanche_proof_voting on my machine.

This also gives fine tuned control to node operators, should it ever be necessary
to modify these parameters.

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sdulfari created this revision.May 31 2022, 18:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 31 2022, 18:27
sdulfari requested review of this revision.May 31 2022, 18:27
Harbormaster completed remote builds in B19205: Diff 33755.May 31 2022, 18:43
deadalnix requested changes to this revision.May 31 2022, 19:16
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/avalanche/processor.cpp
343 ↗(On Diff #33755)

This clearly make no sense to multiply these parameters on each vote reccord.

This revision now requires changes to proceed.May 31 2022, 19:16
sdulfari updated this revision to Diff 33761.May 31 2022, 23:27

Pass voting parameters into isStale() instead of needlessly copying them around in VoteRecord.

Harbormaster completed remote builds in B19210: Diff 33761.May 31 2022, 23:44
ecash1dollar added a subscriber: ecash1dollar.Jun 1 2022, 00:41
This comment was removed by ecash1dollar.
ecash1dollar added a comment.Jun 1 2022, 00:43

Cheer up. I believe you.

deadalnix accepted this revision.Jun 1 2022, 11:03
deadalnix added inline comments.
src/avalanche/voterecord.h
14 ↗(On Diff #33761)

There is no need to change these.

17 ↗(On Diff #33761)

dito

This revision is now accepted and ready to land.Jun 1 2022, 11:03
Closed by commit rABCc8b5dd7de231: [avalanche] Make stale voting parameters configurable (authored by sdulfari). · Explain WhyJun 1 2022, 14:29
This revision was automatically updated to reflect the committed changes.
sdulfari added a commit: rABCc8b5dd7de231: [avalanche] Make stale voting parameters configurable.

Revision Contents
Changeset List

PathSize
src/
avalanche/
7 lines
42 lines
test/
86 lines
13 lines
14 lines
test/
functional/
4 lines

Diff 33767

View Options

src/avalanche/processor.h

Loading...
View Options

src/avalanche/processor.cpp

Loading...
View Options

src/avalanche/test/processor_tests.cpp

Loading...
View Options

src/avalanche/voterecord.h

Loading...
View Options

src/init.cpp

Loading...
View Options

test/functional/abc_p2p_avalanche_proof_voting.py

Loading...