Page MenuHomePhabricator

[Cashtab] Remove largest npm bundles and bug fix
AbandonedPublic

Authored by josephroyking on Thu, Apr 29, 13:19.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

This diff removes minimal-slp-wallet from the package dependencies and reverts to calling it from the unpkg CDN. In testing, it seems like this dependency is causing the long white screen before load issue.

It's important to include minimal-slp-wallet for the chrome extension (vs hosted dependency), but not for the web app. So, another diff will follow to bump the extension version with latest features and keep this dependency for the extension only.

This diff also updates antd/icons to the latest version, which is smaller.

During testing, I discovered an important edge case bug, and included it in this diff because I think it needs to be patched ASAP and is not a complicated change. See the haveUtxosChanged function modification in useWallet.js

Test Plan

npm start, verify wallet loads correctly, verify can send BCHA tx, verify can send SLPA tx

Diff Detail

Repository
rABC Bitcoin ABC
Branch
use-static-bundle-for-web-app
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15601
Build 31118: Build Diffcashtab-tests
Build 31117: arc lint + arc unit