Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F13115661
D2142.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
3 KB
Subscribers
None
D2142.diff
View Options
diff --git a/src/test/avalanche_tests.cpp b/src/test/avalanche_tests.cpp
--- a/src/test/avalanche_tests.cpp
+++ b/src/test/avalanche_tests.cpp
@@ -402,7 +402,7 @@
// Respond to the request.
AvalancheResponse resp = {0, {AvalancheVote(0, blockHash)}};
- BOOST_CHECK(p.registerVotes(avanode->GetId(), resp, updates));
+ BOOST_CHECK(p.registerVotes(avanodeid, resp, updates));
BOOST_CHECK_EQUAL(updates.size(), 0);
// Now that avanode fullfilled his request, it is added back to the list of
@@ -410,7 +410,7 @@
BOOST_CHECK_EQUAL(AvalancheTest::getSuitableNodeToQuery(p), avanodeid);
// Sending a response when not polled fails.
- BOOST_CHECK(!p.registerVotes(avanode->GetId(), resp, updates));
+ BOOST_CHECK(!p.registerVotes(avanodeid, resp, updates));
BOOST_CHECK_EQUAL(updates.size(), 0);
// Trigger a poll on avanode.
@@ -421,33 +421,33 @@
// 1. Too many results.
resp = {0, {AvalancheVote(0, blockHash), AvalancheVote(0, blockHash)}};
AvalancheTest::runEventLoop(p);
- BOOST_CHECK(!p.registerVotes(avanode->GetId(), resp, updates));
+ BOOST_CHECK(!p.registerVotes(avanodeid, resp, updates));
BOOST_CHECK_EQUAL(updates.size(), 0);
BOOST_CHECK_EQUAL(AvalancheTest::getSuitableNodeToQuery(p), avanodeid);
// 2. Not enough results.
resp = {0, {}};
AvalancheTest::runEventLoop(p);
- BOOST_CHECK(!p.registerVotes(avanode->GetId(), resp, updates));
+ BOOST_CHECK(!p.registerVotes(avanodeid, resp, updates));
BOOST_CHECK_EQUAL(updates.size(), 0);
BOOST_CHECK_EQUAL(AvalancheTest::getSuitableNodeToQuery(p), avanodeid);
// 3. Do not match the poll.
resp = {0, {AvalancheVote()}};
AvalancheTest::runEventLoop(p);
- BOOST_CHECK(!p.registerVotes(avanode->GetId(), resp, updates));
+ BOOST_CHECK(!p.registerVotes(avanodeid, resp, updates));
BOOST_CHECK_EQUAL(updates.size(), 0);
BOOST_CHECK_EQUAL(AvalancheTest::getSuitableNodeToQuery(p), avanodeid);
// Proper response gets processed and avanode is available again.
resp = {0, {AvalancheVote(0, blockHash)}};
AvalancheTest::runEventLoop(p);
- BOOST_CHECK(p.registerVotes(avanode->GetId(), resp, updates));
+ BOOST_CHECK(p.registerVotes(avanodeid, resp, updates));
BOOST_CHECK_EQUAL(updates.size(), 0);
BOOST_CHECK_EQUAL(AvalancheTest::getSuitableNodeToQuery(p), avanodeid);
// Making request for invalid nodes do not work.
- BOOST_CHECK(!p.registerVotes(avanode->GetId() + 1234, resp, updates));
+ BOOST_CHECK(!p.registerVotes(avanodeid + 1234, resp, updates));
BOOST_CHECK_EQUAL(updates.size(), 0);
// Out of order response are rejected.
@@ -458,7 +458,7 @@
resp = {0, {AvalancheVote(0, blockHash), AvalancheVote(0, blockHash2)}};
AvalancheTest::runEventLoop(p);
- BOOST_CHECK(!p.registerVotes(avanode->GetId(), resp, updates));
+ BOOST_CHECK(!p.registerVotes(avanodeid, resp, updates));
BOOST_CHECK_EQUAL(updates.size(), 0);
BOOST_CHECK_EQUAL(AvalancheTest::getSuitableNodeToQuery(p), avanodeid);
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Mar 1, 11:41 (3 h, 24 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
5187661
Default Alt Text
D2142.diff (3 KB)
Attached To
D2142: [avalanche] consistently use avanodeid in avalanche's test.
Event Timeline
Log In to Comment