No OneTemporary
Actions

Size

54 KB

Subscribers

None

View Options

	diff --git a/src/rpcrawtransaction.cpp b/src/rpcrawtransaction.cpp
	index a3246b41fb..9eeca5b7d9 100644
	--- a/src/rpcrawtransaction.cpp
	+++ b/src/rpcrawtransaction.cpp
	@@ -1,817 +1,828 @@
	// Copyright (c) 2010 Satoshi Nakamoto
	// Copyright (c) 2009-2015 The Bitcoin Core developers
	// Distributed under the MIT software license, see the accompanying
	// file COPYING or http://www.opensource.org/licenses/mit-license.php.

	#include "base58.h"
	#include "chain.h"
	#include "coins.h"
	#include "consensus/validation.h"
	#include "core_io.h"
	#include "init.h"
	#include "keystore.h"
	#include "main.h"
	#include "merkleblock.h"
	#include "net.h"
	#include "policy/policy.h"
	#include "primitives/transaction.h"
	#include "rpcserver.h"
	#include "script/script.h"
	#include "script/script_error.h"
	#include "script/sign.h"
	#include "script/standard.h"
	#include "txmempool.h"
	#include "uint256.h"
	#include "utilstrencodings.h"
	#ifdef ENABLE_WALLET
	#include "wallet/wallet.h"
	#endif

	#include <stdint.h>

	#include <boost/assign/list_of.hpp>

	#include "univalue/univalue.h"

	using namespace std;

	void ScriptPubKeyToJSON(const CScript& scriptPubKey, UniValue& out, bool fIncludeHex)
	{
	txnouttype type;
	vector<CTxDestination> addresses;
	int nRequired;

	out.push_back(Pair("asm", scriptPubKey.ToString()));
	if (fIncludeHex)
	out.push_back(Pair("hex", HexStr(scriptPubKey.begin(), scriptPubKey.end())));

	if (!ExtractDestinations(scriptPubKey, type, addresses, nRequired)) {
	out.push_back(Pair("type", GetTxnOutputType(type)));
	return;
	}

	out.push_back(Pair("reqSigs", nRequired));
	out.push_back(Pair("type", GetTxnOutputType(type)));

	UniValue a(UniValue::VARR);
	BOOST_FOREACH(const CTxDestination& addr, addresses)
	a.push_back(CBitcoinAddress(addr).ToString());
	out.push_back(Pair("addresses", a));
	}

	void TxToJSON(const CTransaction& tx, const uint256 hashBlock, UniValue& entry)
	{
	entry.push_back(Pair("txid", tx.GetHash().GetHex()));
	entry.push_back(Pair("version", tx.nVersion));
	entry.push_back(Pair("locktime", (int64_t)tx.nLockTime));
	UniValue vin(UniValue::VARR);
	BOOST_FOREACH(const CTxIn& txin, tx.vin) {
	UniValue in(UniValue::VOBJ);
	if (tx.IsCoinBase())
	in.push_back(Pair("coinbase", HexStr(txin.scriptSig.begin(), txin.scriptSig.end())));
	else {
	in.push_back(Pair("txid", txin.prevout.hash.GetHex()));
	in.push_back(Pair("vout", (int64_t)txin.prevout.n));
	UniValue o(UniValue::VOBJ);
	o.push_back(Pair("asm", txin.scriptSig.ToString()));
	o.push_back(Pair("hex", HexStr(txin.scriptSig.begin(), txin.scriptSig.end())));
	in.push_back(Pair("scriptSig", o));
	}
	in.push_back(Pair("sequence", (int64_t)txin.nSequence));
	vin.push_back(in);
	}
	entry.push_back(Pair("vin", vin));
	UniValue vout(UniValue::VARR);
	for (unsigned int i = 0; i < tx.vout.size(); i++) {
	const CTxOut& txout = tx.vout[i];
	UniValue out(UniValue::VOBJ);
	out.push_back(Pair("value", ValueFromAmount(txout.nValue)));
	out.push_back(Pair("n", (int64_t)i));
	UniValue o(UniValue::VOBJ);
	ScriptPubKeyToJSON(txout.scriptPubKey, o, true);
	out.push_back(Pair("scriptPubKey", o));
	vout.push_back(out);
	}
	entry.push_back(Pair("vout", vout));

	if (!hashBlock.IsNull()) {
	entry.push_back(Pair("blockhash", hashBlock.GetHex()));
	BlockMap::iterator mi = mapBlockIndex.find(hashBlock);
	if (mi != mapBlockIndex.end() && (*mi).second) {
	CBlockIndex* pindex = (*mi).second;
	if (chainActive.Contains(pindex)) {
	entry.push_back(Pair("confirmations", 1 + chainActive.Height() - pindex->nHeight));
	entry.push_back(Pair("time", pindex->GetBlockTime()));
	entry.push_back(Pair("blocktime", pindex->GetBlockTime()));
	}
	else
	entry.push_back(Pair("confirmations", 0));
	}
	}
	}

	UniValue getrawtransaction(const UniValue& params, bool fHelp)
	{
	if (fHelp \|\| params.size() < 1 \|\| params.size() > 2)
	throw runtime_error(
	"getrawtransaction \"txid\" ( verbose )\n"
	"\nNOTE: By default this function only works sometimes. This is when the tx is in the mempool\n"
	"or there is an unspent output in the utxo for this transaction. To make it always work,\n"
	"you need to maintain a transaction index, using the -txindex command line option.\n"
	"\nReturn the raw transaction data.\n"
	"\nIf verbose=0, returns a string that is serialized, hex-encoded data for 'txid'.\n"
	"If verbose is non-zero, returns an Object with information about 'txid'.\n"

	"\nArguments:\n"
	"1. \"txid\" (string, required) The transaction id\n"
	"2. verbose (numeric, optional, default=0) If 0, return a string, other return a json object\n"

	"\nResult (if verbose is not set or set to 0):\n"
	"\"data\" (string) The serialized, hex-encoded data for 'txid'\n"

	"\nResult (if verbose > 0):\n"
	"{\n"
	" \"hex\" : \"data\", (string) The serialized, hex-encoded data for 'txid'\n"
	" \"txid\" : \"id\", (string) The transaction id (same as provided)\n"
	" \"version\" : n, (numeric) The version\n"
	" \"locktime\" : ttt, (numeric) The lock time\n"
	" \"vin\" : [ (array of json objects)\n"
	" {\n"
	" \"txid\": \"id\", (string) The transaction id\n"
	" \"vout\": n, (numeric) \n"
	" \"scriptSig\": { (json object) The script\n"
	" \"asm\": \"asm\", (string) asm\n"
	" \"hex\": \"hex\" (string) hex\n"
	" },\n"
	" \"sequence\": n (numeric) The script sequence number\n"
	" }\n"
	" ,...\n"
	" ],\n"
	" \"vout\" : [ (array of json objects)\n"
	" {\n"
	" \"value\" : x.xxx, (numeric) The value in " + CURRENCY_UNIT + "\n"
	" \"n\" : n, (numeric) index\n"
	" \"scriptPubKey\" : { (json object)\n"
	" \"asm\" : \"asm\", (string) the asm\n"
	" \"hex\" : \"hex\", (string) the hex\n"
	" \"reqSigs\" : n, (numeric) The required sigs\n"
	" \"type\" : \"pubkeyhash\", (string) The type, eg 'pubkeyhash'\n"
	" \"addresses\" : [ (json array of string)\n"
	" \"bitcoinaddress\" (string) bitcoin address\n"
	" ,...\n"
	" ]\n"
	" }\n"
	" }\n"
	" ,...\n"
	" ],\n"
	" \"blockhash\" : \"hash\", (string) the block hash\n"
	" \"confirmations\" : n, (numeric) The confirmations\n"
	" \"time\" : ttt, (numeric) The transaction time in seconds since epoch (Jan 1 1970 GMT)\n"
	" \"blocktime\" : ttt (numeric) The block time in seconds since epoch (Jan 1 1970 GMT)\n"
	"}\n"

	"\nExamples:\n"
	+ HelpExampleCli("getrawtransaction", "\"mytxid\"")
	+ HelpExampleCli("getrawtransaction", "\"mytxid\" 1")
	+ HelpExampleRpc("getrawtransaction", "\"mytxid\", 1")
	);

	LOCK(cs_main);

	uint256 hash = ParseHashV(params[0], "parameter 1");

	bool fVerbose = false;
	if (params.size() > 1)
	fVerbose = (params[1].get_int() != 0);

	CTransaction tx;
	uint256 hashBlock;
	if (!GetTransaction(hash, tx, hashBlock, true))
	throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, "No information available about transaction");

	string strHex = EncodeHexTx(tx);

	if (!fVerbose)
	return strHex;

	UniValue result(UniValue::VOBJ);
	result.push_back(Pair("hex", strHex));
	TxToJSON(tx, hashBlock, result);
	return result;
	}

	UniValue gettxoutproof(const UniValue& params, bool fHelp)
	{
	if (fHelp \|\| (params.size() != 1 && params.size() != 2))
	throw runtime_error(
	"gettxoutproof [\"txid\",...] ( blockhash )\n"
	"\nReturns a hex-encoded proof that \"txid\" was included in a block.\n"
	"\nNOTE: By default this function only works sometimes. This is when there is an\n"
	"unspent output in the utxo for this transaction. To make it always work,\n"
	"you need to maintain a transaction index, using the -txindex command line option or\n"
	"specify the block in which the transaction is included in manually (by blockhash).\n"
	"\nReturn the raw transaction data.\n"
	"\nArguments:\n"
	"1. \"txids\" (string) A json array of txids to filter\n"
	" [\n"
	" \"txid\" (string) A transaction hash\n"
	" ,...\n"
	" ]\n"
	"2. \"block hash\" (string, optional) If specified, looks for txid in the block with this hash\n"
	"\nResult:\n"
	"\"data\" (string) A string that is a serialized, hex-encoded data for the proof.\n"
	);

	set<uint256> setTxids;
	uint256 oneTxid;
	UniValue txids = params[0].get_array();
	for (unsigned int idx = 0; idx < txids.size(); idx++) {
	const UniValue& txid = txids[idx];
	if (txid.get_str().length() != 64 \|\| !IsHex(txid.get_str()))
	throw JSONRPCError(RPC_INVALID_PARAMETER, string("Invalid txid ")+txid.get_str());
	uint256 hash(uint256S(txid.get_str()));
	if (setTxids.count(hash))
	throw JSONRPCError(RPC_INVALID_PARAMETER, string("Invalid parameter, duplicated txid: ")+txid.get_str());
	setTxids.insert(hash);
	oneTxid = hash;
	}

	LOCK(cs_main);

	CBlockIndex* pblockindex = NULL;

	uint256 hashBlock;
	if (params.size() > 1)
	{
	hashBlock = uint256S(params[1].get_str());
	if (!mapBlockIndex.count(hashBlock))
	throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, "Block not found");
	pblockindex = mapBlockIndex[hashBlock];
	} else {
	CCoins coins;
	if (pcoinsTip->GetCoins(oneTxid, coins) && coins.nHeight > 0 && coins.nHeight <= chainActive.Height())
	pblockindex = chainActive[coins.nHeight];
	}

	if (pblockindex == NULL)
	{
	CTransaction tx;
	if (!GetTransaction(oneTxid, tx, hashBlock, false) \|\| hashBlock.IsNull())
	throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, "Transaction not yet in block");
	if (!mapBlockIndex.count(hashBlock))
	throw JSONRPCError(RPC_INTERNAL_ERROR, "Transaction index corrupt");
	pblockindex = mapBlockIndex[hashBlock];
	}

	CBlock block;
	if(!ReadBlockFromDisk(block, pblockindex))
	throw JSONRPCError(RPC_INTERNAL_ERROR, "Can't read block from disk");

	unsigned int ntxFound = 0;
	BOOST_FOREACH(const CTransaction&tx, block.vtx)
	if (setTxids.count(tx.GetHash()))
	ntxFound++;
	if (ntxFound != setTxids.size())
	throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, "(Not all) transactions not found in specified block");

	CDataStream ssMB(SER_NETWORK, PROTOCOL_VERSION);
	CMerkleBlock mb(block, setTxids);
	ssMB << mb;
	std::string strHex = HexStr(ssMB.begin(), ssMB.end());
	return strHex;
	}

	UniValue verifytxoutproof(const UniValue& params, bool fHelp)
	{
	if (fHelp \|\| params.size() != 1)
	throw runtime_error(
	"verifytxoutproof \"proof\"\n"
	"\nVerifies that a proof points to a transaction in a block, returning the transaction it commits to\n"
	"and throwing an RPC error if the block is not in our best chain\n"
	"\nArguments:\n"
	"1. \"proof\" (string, required) The hex-encoded proof generated by gettxoutproof\n"
	"\nResult:\n"
	"[\"txid\"] (array, strings) The txid(s) which the proof commits to, or empty array if the proof is invalid\n"
	);

	CDataStream ssMB(ParseHexV(params[0], "proof"), SER_NETWORK, PROTOCOL_VERSION);
	CMerkleBlock merkleBlock;
	ssMB >> merkleBlock;

	UniValue res(UniValue::VARR);

	vector<uint256> vMatch;
	if (merkleBlock.txn.ExtractMatches(vMatch) != merkleBlock.header.hashMerkleRoot)
	return res;

	LOCK(cs_main);

	if (!mapBlockIndex.count(merkleBlock.header.GetHash()) \|\| !chainActive.Contains(mapBlockIndex[merkleBlock.header.GetHash()]))
	throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, "Block not found in chain");

	BOOST_FOREACH(const uint256& hash, vMatch)
	res.push_back(hash.GetHex());
	return res;
	}

	UniValue createrawtransaction(const UniValue& params, bool fHelp)
	{
	if (fHelp \|\| params.size() != 2)
	throw runtime_error(
	- "createrawtransaction [{\"txid\":\"id\",\"vout\":n},...] {\"address\":amount,...}\n"
	- "\nCreate a transaction spending the given inputs and sending to the given addresses.\n"
	+ "createrawtransaction [{\"txid\":\"id\",\"vout\":n},...] {\"address\":amount,\"data\":\"hex\",...}\n"
	+ "\nCreate a transaction spending the given inputs and creating new outputs.\n"
	+ "Outputs can be addresses or data.\n"
	"Returns hex-encoded raw transaction.\n"
	"Note that the transaction's inputs are not signed, and\n"
	"it is not stored in the wallet or transmitted to the network.\n"

	"\nArguments:\n"
	"1. \"transactions\" (string, required) A json array of json objects\n"
	" [\n"
	" {\n"
	- " \"txid\":\"id\", (string, required) The transaction id\n"
	+ " \"txid\":\"id\", (string, required) The transaction id\n"
	" \"vout\":n (numeric, required) The output number\n"
	" }\n"
	" ,...\n"
	" ]\n"
	- "2. \"addresses\" (string, required) a json object with addresses as keys and amounts as values\n"
	+ "2. \"outputs\" (string, required) a json object with outputs\n"
	" {\n"
	" \"address\": x.xxx (numeric, required) The key is the bitcoin address, the value is the " + CURRENCY_UNIT + " amount\n"
	- " ,...\n"
	+ " \"data\": \"hex\", (string, required) The key is \"data\", the value is hex encoded data\n"
	+ " ...\n"
	" }\n"
	-
	"\nResult:\n"
	"\"transaction\" (string) hex string of the transaction\n"

	"\nExamples\n"
	+ HelpExampleCli("createrawtransaction", "\"[{\\\"txid\\\":\\\"myid\\\",\\\"vout\\\":0}]\" \"{\\\"address\\\":0.01}\"")
	+ + HelpExampleCli("createrawtransaction", "\"[{\\\"txid\\\":\\\"myid\\\",\\\"vout\\\":0}]\" \"{\\\"data\\\":\\\"00010203\\\"}\"")
	+ HelpExampleRpc("createrawtransaction", "\"[{\\\"txid\\\":\\\"myid\\\",\\\"vout\\\":0}]\", \"{\\\"address\\\":0.01}\"")
	+ + HelpExampleRpc("createrawtransaction", "\"[{\\\"txid\\\":\\\"myid\\\",\\\"vout\\\":0}]\", \"{\\\"data\\\":\\\"00010203\\\"}\"")
	);

	LOCK(cs_main);
	RPCTypeCheck(params, boost::assign::list_of(UniValue::VARR)(UniValue::VOBJ));

	UniValue inputs = params[0].get_array();
	UniValue sendTo = params[1].get_obj();

	CMutableTransaction rawTx;

	for (unsigned int idx = 0; idx < inputs.size(); idx++) {
	const UniValue& input = inputs[idx];
	const UniValue& o = input.get_obj();

	uint256 txid = ParseHashO(o, "txid");

	const UniValue& vout_v = find_value(o, "vout");
	if (!vout_v.isNum())
	throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, missing vout key");
	int nOutput = vout_v.get_int();
	if (nOutput < 0)
	throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, vout must be positive");

	CTxIn in(COutPoint(txid, nOutput));
	rawTx.vin.push_back(in);
	}

	set<CBitcoinAddress> setAddress;
	vector<string> addrList = sendTo.getKeys();
	BOOST_FOREACH(const string& name_, addrList) {
	- CBitcoinAddress address(name_);
	- if (!address.IsValid())
	- throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, string("Invalid Bitcoin address: ")+name_);

	- if (setAddress.count(address))
	- throw JSONRPCError(RPC_INVALID_PARAMETER, string("Invalid parameter, duplicated address: ")+name_);
	- setAddress.insert(address);
	+ if (name_ == "data") {
	+ std::vector<unsigned char> data = ParseHexV(sendTo[name_].getValStr(),"Data");
	+
	+ CTxOut out(0, CScript() << OP_RETURN << data);
	+ rawTx.vout.push_back(out);
	+ } else {
	+ CBitcoinAddress address(name_);
	+ if (!address.IsValid())
	+ throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, string("Invalid Bitcoin address: ")+name_);

	- CScript scriptPubKey = GetScriptForDestination(address.Get());
	- CAmount nAmount = AmountFromValue(sendTo[name_]);
	+ if (setAddress.count(address))
	+ throw JSONRPCError(RPC_INVALID_PARAMETER, string("Invalid parameter, duplicated address: ")+name_);
	+ setAddress.insert(address);

	- CTxOut out(nAmount, scriptPubKey);
	- rawTx.vout.push_back(out);
	+ CScript scriptPubKey = GetScriptForDestination(address.Get());
	+ CAmount nAmount = AmountFromValue(sendTo[name_]);
	+
	+ CTxOut out(nAmount, scriptPubKey);
	+ rawTx.vout.push_back(out);
	+ }
	}

	return EncodeHexTx(rawTx);
	}

	UniValue decoderawtransaction(const UniValue& params, bool fHelp)
	{
	if (fHelp \|\| params.size() != 1)
	throw runtime_error(
	"decoderawtransaction \"hexstring\"\n"
	"\nReturn a JSON object representing the serialized, hex-encoded transaction.\n"

	"\nArguments:\n"
	"1. \"hex\" (string, required) The transaction hex string\n"

	"\nResult:\n"
	"{\n"
	" \"txid\" : \"id\", (string) The transaction id\n"
	" \"version\" : n, (numeric) The version\n"
	" \"locktime\" : ttt, (numeric) The lock time\n"
	" \"vin\" : [ (array of json objects)\n"
	" {\n"
	" \"txid\": \"id\", (string) The transaction id\n"
	" \"vout\": n, (numeric) The output number\n"
	" \"scriptSig\": { (json object) The script\n"
	" \"asm\": \"asm\", (string) asm\n"
	" \"hex\": \"hex\" (string) hex\n"
	" },\n"
	" \"sequence\": n (numeric) The script sequence number\n"
	" }\n"
	" ,...\n"
	" ],\n"
	" \"vout\" : [ (array of json objects)\n"
	" {\n"
	" \"value\" : x.xxx, (numeric) The value in " + CURRENCY_UNIT + "\n"
	" \"n\" : n, (numeric) index\n"
	" \"scriptPubKey\" : { (json object)\n"
	" \"asm\" : \"asm\", (string) the asm\n"
	" \"hex\" : \"hex\", (string) the hex\n"
	" \"reqSigs\" : n, (numeric) The required sigs\n"
	" \"type\" : \"pubkeyhash\", (string) The type, eg 'pubkeyhash'\n"
	" \"addresses\" : [ (json array of string)\n"
	" \"12tvKAXCxZjSmdNbao16dKXC8tRWfcF5oc\" (string) bitcoin address\n"
	" ,...\n"
	" ]\n"
	" }\n"
	" }\n"
	" ,...\n"
	" ],\n"
	"}\n"

	"\nExamples:\n"
	+ HelpExampleCli("decoderawtransaction", "\"hexstring\"")
	+ HelpExampleRpc("decoderawtransaction", "\"hexstring\"")
	);

	LOCK(cs_main);
	RPCTypeCheck(params, boost::assign::list_of(UniValue::VSTR));

	CTransaction tx;

	if (!DecodeHexTx(tx, params[0].get_str()))
	throw JSONRPCError(RPC_DESERIALIZATION_ERROR, "TX decode failed");

	UniValue result(UniValue::VOBJ);
	TxToJSON(tx, uint256(), result);

	return result;
	}

	UniValue decodescript(const UniValue& params, bool fHelp)
	{
	if (fHelp \|\| params.size() != 1)
	throw runtime_error(
	"decodescript \"hex\"\n"
	"\nDecode a hex-encoded script.\n"
	"\nArguments:\n"
	"1. \"hex\" (string) the hex encoded script\n"
	"\nResult:\n"
	"{\n"
	" \"asm\":\"asm\", (string) Script public key\n"
	" \"hex\":\"hex\", (string) hex encoded public key\n"
	" \"type\":\"type\", (string) The output type\n"
	" \"reqSigs\": n, (numeric) The required signatures\n"
	" \"addresses\": [ (json array of string)\n"
	" \"address\" (string) bitcoin address\n"
	" ,...\n"
	" ],\n"
	" \"p2sh\",\"address\" (string) script address\n"
	"}\n"
	"\nExamples:\n"
	+ HelpExampleCli("decodescript", "\"hexstring\"")
	+ HelpExampleRpc("decodescript", "\"hexstring\"")
	);

	LOCK(cs_main);
	RPCTypeCheck(params, boost::assign::list_of(UniValue::VSTR));

	UniValue r(UniValue::VOBJ);
	CScript script;
	if (params[0].get_str().size() > 0){
	vector<unsigned char> scriptData(ParseHexV(params[0], "argument"));
	script = CScript(scriptData.begin(), scriptData.end());
	} else {
	// Empty scripts are valid
	}
	ScriptPubKeyToJSON(script, r, false);

	r.push_back(Pair("p2sh", CBitcoinAddress(CScriptID(script)).ToString()));
	return r;
	}

	/** Pushes a JSON object for script verification or signing errors to vErrorsRet. */
	static void TxInErrorToJSON(const CTxIn& txin, UniValue& vErrorsRet, const std::string& strMessage)
	{
	UniValue entry(UniValue::VOBJ);
	entry.push_back(Pair("txid", txin.prevout.hash.ToString()));
	entry.push_back(Pair("vout", (uint64_t)txin.prevout.n));
	entry.push_back(Pair("scriptSig", HexStr(txin.scriptSig.begin(), txin.scriptSig.end())));
	entry.push_back(Pair("sequence", (uint64_t)txin.nSequence));
	entry.push_back(Pair("error", strMessage));
	vErrorsRet.push_back(entry);
	}

	UniValue signrawtransaction(const UniValue& params, bool fHelp)
	{
	if (fHelp \|\| params.size() < 1 \|\| params.size() > 4)
	throw runtime_error(
	"signrawtransaction \"hexstring\" ( [{\"txid\":\"id\",\"vout\":n,\"scriptPubKey\":\"hex\",\"redeemScript\":\"hex\"},...] [\"privatekey1\",...] sighashtype )\n"
	"\nSign inputs for raw transaction (serialized, hex-encoded).\n"
	"The second optional argument (may be null) is an array of previous transaction outputs that\n"
	"this transaction depends on but may not yet be in the block chain.\n"
	"The third optional argument (may be null) is an array of base58-encoded private\n"
	"keys that, if given, will be the only keys used to sign the transaction.\n"
	#ifdef ENABLE_WALLET
	+ HelpRequiringPassphrase() + "\n"
	#endif

	"\nArguments:\n"
	"1. \"hexstring\" (string, required) The transaction hex string\n"
	"2. \"prevtxs\" (string, optional) An json array of previous dependent transaction outputs\n"
	" [ (json array of json objects, or 'null' if none provided)\n"
	" {\n"
	" \"txid\":\"id\", (string, required) The transaction id\n"
	" \"vout\":n, (numeric, required) The output number\n"
	" \"scriptPubKey\": \"hex\", (string, required) script key\n"
	" \"redeemScript\": \"hex\" (string, required for P2SH) redeem script\n"
	" }\n"
	" ,...\n"
	" ]\n"
	"3. \"privatekeys\" (string, optional) A json array of base58-encoded private keys for signing\n"
	" [ (json array of strings, or 'null' if none provided)\n"
	" \"privatekey\" (string) private key in base58-encoding\n"
	" ,...\n"
	" ]\n"
	"4. \"sighashtype\" (string, optional, default=ALL) The signature hash type. Must be one of\n"
	" \"ALL\"\n"
	" \"NONE\"\n"
	" \"SINGLE\"\n"
	" \"ALL\|ANYONECANPAY\"\n"
	" \"NONE\|ANYONECANPAY\"\n"
	" \"SINGLE\|ANYONECANPAY\"\n"

	"\nResult:\n"
	"{\n"
	" \"hex\" : \"value\", (string) The hex-encoded raw transaction with signature(s)\n"
	" \"complete\" : true\|false, (boolean) If the transaction has a complete set of signatures\n"
	" \"errors\" : [ (json array of objects) Script verification errors (if there are any)\n"
	" {\n"
	" \"txid\" : \"hash\", (string) The hash of the referenced, previous transaction\n"
	" \"vout\" : n, (numeric) The index of the output to spent and used as input\n"
	" \"scriptSig\" : \"hex\", (string) The hex-encoded signature script\n"
	" \"sequence\" : n, (numeric) Script sequence number\n"
	" \"error\" : \"text\" (string) Verification or signing error related to the input\n"
	" }\n"
	" ,...\n"
	" ]\n"
	"}\n"

	"\nExamples:\n"
	+ HelpExampleCli("signrawtransaction", "\"myhex\"")
	+ HelpExampleRpc("signrawtransaction", "\"myhex\"")
	);

	#ifdef ENABLE_WALLET
	LOCK2(cs_main, pwalletMain ? &pwalletMain->cs_wallet : NULL);
	#else
	LOCK(cs_main);
	#endif
	RPCTypeCheck(params, boost::assign::list_of(UniValue::VSTR)(UniValue::VARR)(UniValue::VARR)(UniValue::VSTR), true);

	vector<unsigned char> txData(ParseHexV(params[0], "argument 1"));
	CDataStream ssData(txData, SER_NETWORK, PROTOCOL_VERSION);
	vector<CMutableTransaction> txVariants;
	while (!ssData.empty()) {
	try {
	CMutableTransaction tx;
	ssData >> tx;
	txVariants.push_back(tx);
	}
	catch (const std::exception&) {
	throw JSONRPCError(RPC_DESERIALIZATION_ERROR, "TX decode failed");
	}
	}

	if (txVariants.empty())
	throw JSONRPCError(RPC_DESERIALIZATION_ERROR, "Missing transaction");

	// mergedTx will end up with all the signatures; it
	// starts as a clone of the rawtx:
	CMutableTransaction mergedTx(txVariants[0]);

	// Fetch previous transactions (inputs):
	CCoinsView viewDummy;
	CCoinsViewCache view(&viewDummy);
	{
	LOCK(mempool.cs);
	CCoinsViewCache &viewChain = *pcoinsTip;
	CCoinsViewMemPool viewMempool(&viewChain, mempool);
	view.SetBackend(viewMempool); // temporarily switch cache backend to db+mempool view

	BOOST_FOREACH(const CTxIn& txin, mergedTx.vin) {
	const uint256& prevHash = txin.prevout.hash;
	CCoins coins;
	view.AccessCoins(prevHash); // this is certainly allowed to fail
	}

	view.SetBackend(viewDummy); // switch back to avoid locking mempool for too long
	}

	bool fGivenKeys = false;
	CBasicKeyStore tempKeystore;
	if (params.size() > 2 && !params[2].isNull()) {
	fGivenKeys = true;
	UniValue keys = params[2].get_array();
	for (unsigned int idx = 0; idx < keys.size(); idx++) {
	UniValue k = keys[idx];
	CBitcoinSecret vchSecret;
	bool fGood = vchSecret.SetString(k.get_str());
	if (!fGood)
	throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, "Invalid private key");
	CKey key = vchSecret.GetKey();
	if (!key.IsValid())
	throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, "Private key outside allowed range");
	tempKeystore.AddKey(key);
	}
	}
	#ifdef ENABLE_WALLET
	else if (pwalletMain)
	EnsureWalletIsUnlocked();
	#endif

	// Add previous txouts given in the RPC call:
	if (params.size() > 1 && !params[1].isNull()) {
	UniValue prevTxs = params[1].get_array();
	for (unsigned int idx = 0; idx < prevTxs.size(); idx++) {
	const UniValue& p = prevTxs[idx];
	if (!p.isObject())
	throw JSONRPCError(RPC_DESERIALIZATION_ERROR, "expected object with {\"txid'\",\"vout\",\"scriptPubKey\"}");

	UniValue prevOut = p.get_obj();

	RPCTypeCheckObj(prevOut, boost::assign::map_list_of("txid", UniValue::VSTR)("vout", UniValue::VNUM)("scriptPubKey", UniValue::VSTR));

	uint256 txid = ParseHashO(prevOut, "txid");

	int nOut = find_value(prevOut, "vout").get_int();
	if (nOut < 0)
	throw JSONRPCError(RPC_DESERIALIZATION_ERROR, "vout must be positive");

	vector<unsigned char> pkData(ParseHexO(prevOut, "scriptPubKey"));
	CScript scriptPubKey(pkData.begin(), pkData.end());

	{
	CCoinsModifier coins = view.ModifyCoins(txid);
	if (coins->IsAvailable(nOut) && coins->vout[nOut].scriptPubKey != scriptPubKey) {
	string err("Previous output scriptPubKey mismatch:\n");
	err = err + coins->vout[nOut].scriptPubKey.ToString() + "\nvs:\n"+
	scriptPubKey.ToString();
	throw JSONRPCError(RPC_DESERIALIZATION_ERROR, err);
	}
	if ((unsigned int)nOut >= coins->vout.size())
	coins->vout.resize(nOut+1);
	coins->vout[nOut].scriptPubKey = scriptPubKey;
	coins->vout[nOut].nValue = 0; // we don't know the actual output value
	}

	// if redeemScript given and not using the local wallet (private keys
	// given), add redeemScript to the tempKeystore so it can be signed:
	if (fGivenKeys && scriptPubKey.IsPayToScriptHash()) {
	RPCTypeCheckObj(prevOut, boost::assign::map_list_of("txid", UniValue::VSTR)("vout", UniValue::VNUM)("scriptPubKey", UniValue::VSTR)("redeemScript",UniValue::VSTR));
	UniValue v = find_value(prevOut, "redeemScript");
	if (!v.isNull()) {
	vector<unsigned char> rsData(ParseHexV(v, "redeemScript"));
	CScript redeemScript(rsData.begin(), rsData.end());
	tempKeystore.AddCScript(redeemScript);
	}
	}
	}
	}

	#ifdef ENABLE_WALLET
	const CKeyStore& keystore = ((fGivenKeys \|\| !pwalletMain) ? tempKeystore : *pwalletMain);
	#else
	const CKeyStore& keystore = tempKeystore;
	#endif

	int nHashType = SIGHASH_ALL;
	if (params.size() > 3 && !params[3].isNull()) {
	static map<string, int> mapSigHashValues =
	boost::assign::map_list_of
	(string("ALL"), int(SIGHASH_ALL))
	(string("ALL\|ANYONECANPAY"), int(SIGHASH_ALL\|SIGHASH_ANYONECANPAY))
	(string("NONE"), int(SIGHASH_NONE))
	(string("NONE\|ANYONECANPAY"), int(SIGHASH_NONE\|SIGHASH_ANYONECANPAY))
	(string("SINGLE"), int(SIGHASH_SINGLE))
	(string("SINGLE\|ANYONECANPAY"), int(SIGHASH_SINGLE\|SIGHASH_ANYONECANPAY))
	;
	string strHashType = params[3].get_str();
	if (mapSigHashValues.count(strHashType))
	nHashType = mapSigHashValues[strHashType];
	else
	throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid sighash param");
	}

	bool fHashSingle = ((nHashType & ~SIGHASH_ANYONECANPAY) == SIGHASH_SINGLE);

	// Script verification errors
	UniValue vErrors(UniValue::VARR);

	// Sign what we can:
	for (unsigned int i = 0; i < mergedTx.vin.size(); i++) {
	CTxIn& txin = mergedTx.vin[i];
	const CCoins* coins = view.AccessCoins(txin.prevout.hash);
	if (coins == NULL \|\| !coins->IsAvailable(txin.prevout.n)) {
	TxInErrorToJSON(txin, vErrors, "Input not found or already spent");
	continue;
	}
	const CScript& prevPubKey = coins->vout[txin.prevout.n].scriptPubKey;

	txin.scriptSig.clear();
	// Only sign SIGHASH_SINGLE if there's a corresponding output:
	if (!fHashSingle \|\| (i < mergedTx.vout.size()))
	SignSignature(keystore, prevPubKey, mergedTx, i, nHashType);

	// ... and merge in other signatures:
	BOOST_FOREACH(const CMutableTransaction& txv, txVariants) {
	txin.scriptSig = CombineSignatures(prevPubKey, mergedTx, i, txin.scriptSig, txv.vin[i].scriptSig);
	}
	ScriptError serror = SCRIPT_ERR_OK;
	if (!VerifyScript(txin.scriptSig, prevPubKey, STANDARD_SCRIPT_VERIFY_FLAGS, MutableTransactionSignatureChecker(&mergedTx, i), &serror)) {
	TxInErrorToJSON(txin, vErrors, ScriptErrorString(serror));
	}
	}
	bool fComplete = vErrors.empty();

	UniValue result(UniValue::VOBJ);
	result.push_back(Pair("hex", EncodeHexTx(mergedTx)));
	result.push_back(Pair("complete", fComplete));
	if (!vErrors.empty()) {
	result.push_back(Pair("errors", vErrors));
	}

	return result;
	}

	UniValue sendrawtransaction(const UniValue& params, bool fHelp)
	{
	if (fHelp \|\| params.size() < 1 \|\| params.size() > 2)
	throw runtime_error(
	"sendrawtransaction \"hexstring\" ( allowhighfees )\n"
	"\nSubmits raw transaction (serialized, hex-encoded) to local node and network.\n"
	"\nAlso see createrawtransaction and signrawtransaction calls.\n"
	"\nArguments:\n"
	"1. \"hexstring\" (string, required) The hex string of the raw transaction)\n"
	"2. allowhighfees (boolean, optional, default=false) Allow high fees\n"
	"\nResult:\n"
	"\"hex\" (string) The transaction hash in hex\n"
	"\nExamples:\n"
	"\nCreate a transaction\n"
	+ HelpExampleCli("createrawtransaction", "\"[{\\\"txid\\\" : \\\"mytxid\\\",\\\"vout\\\":0}]\" \"{\\\"myaddress\\\":0.01}\"") +
	"Sign the transaction, and get back the hex\n"
	+ HelpExampleCli("signrawtransaction", "\"myhex\"") +
	"\nSend the transaction (signed hex)\n"
	+ HelpExampleCli("sendrawtransaction", "\"signedhex\"") +
	"\nAs a json rpc call\n"
	+ HelpExampleRpc("sendrawtransaction", "\"signedhex\"")
	);

	LOCK(cs_main);
	RPCTypeCheck(params, boost::assign::list_of(UniValue::VSTR)(UniValue::VBOOL));

	// parse hex string from parameter
	CTransaction tx;
	if (!DecodeHexTx(tx, params[0].get_str()))
	throw JSONRPCError(RPC_DESERIALIZATION_ERROR, "TX decode failed");
	uint256 hashTx = tx.GetHash();

	bool fOverrideFees = false;
	if (params.size() > 1)
	fOverrideFees = params[1].get_bool();

	CCoinsViewCache &view = *pcoinsTip;
	const CCoins* existingCoins = view.AccessCoins(hashTx);
	bool fHaveMempool = mempool.exists(hashTx);
	bool fHaveChain = existingCoins && existingCoins->nHeight < 1000000000;
	if (!fHaveMempool && !fHaveChain) {
	// push to local node and sync with wallets
	CValidationState state;
	bool fMissingInputs;
	if (!AcceptToMemoryPool(mempool, state, tx, false, &fMissingInputs, !fOverrideFees)) {
	if (state.IsInvalid()) {
	throw JSONRPCError(RPC_TRANSACTION_REJECTED, strprintf("%i: %s", state.GetRejectCode(), state.GetRejectReason()));
	} else {
	if (fMissingInputs) {
	throw JSONRPCError(RPC_TRANSACTION_ERROR, "Missing inputs");
	}
	throw JSONRPCError(RPC_TRANSACTION_ERROR, state.GetRejectReason());
	}
	}
	} else if (fHaveChain) {
	throw JSONRPCError(RPC_TRANSACTION_ALREADY_IN_CHAIN, "transaction already in block chain");
	}
	RelayTransaction(tx);

	return hashTx.GetHex();
	}
	diff --git a/src/test/rpc_tests.cpp b/src/test/rpc_tests.cpp
	index 7946b02855..a65572e6f6 100644
	--- a/src/test/rpc_tests.cpp
	+++ b/src/test/rpc_tests.cpp
	@@ -1,307 +1,325 @@
	// Copyright (c) 2012-2013 The Bitcoin Core developers
	// Distributed under the MIT software license, see the accompanying
	// file COPYING or http://www.opensource.org/licenses/mit-license.php.

	#include "rpcserver.h"
	#include "rpcclient.h"

	#include "base58.h"
	#include "netbase.h"

	#include "test/test_bitcoin.h"

	#include <boost/algorithm/string.hpp>
	#include <boost/test/unit_test.hpp>

	#include "univalue/univalue.h"

	using namespace std;

	UniValue
	createArgs(int nRequired, const char* address1=NULL, const char* address2=NULL)
	{
	UniValue result(UniValue::VARR);
	result.push_back(nRequired);
	UniValue addresses(UniValue::VARR);
	if (address1) addresses.push_back(address1);
	if (address2) addresses.push_back(address2);
	result.push_back(addresses);
	return result;
	}

	UniValue CallRPC(string args)
	{
	vector<string> vArgs;
	boost::split(vArgs, args, boost::is_any_of(" \t"));
	string strMethod = vArgs[0];
	vArgs.erase(vArgs.begin());
	UniValue params = RPCConvertValues(strMethod, vArgs);

	rpcfn_type method = tableRPC[strMethod]->actor;
	try {
	UniValue result = (*method)(params, false);
	return result;
	}
	catch (const UniValue& objError) {
	throw runtime_error(find_value(objError, "message").get_str());
	}
	}


	BOOST_FIXTURE_TEST_SUITE(rpc_tests, TestingSetup)

	BOOST_AUTO_TEST_CASE(rpc_rawparams)
	{
	// Test raw transaction API argument handling
	UniValue r;

	BOOST_CHECK_THROW(CallRPC("getrawtransaction"), runtime_error);
	BOOST_CHECK_THROW(CallRPC("getrawtransaction not_hex"), runtime_error);
	BOOST_CHECK_THROW(CallRPC("getrawtransaction a3b807410df0b60fcb9736768df5823938b2f838694939ba45f3c0a1bff150ed not_int"), runtime_error);

	BOOST_CHECK_THROW(CallRPC("createrawtransaction"), runtime_error);
	BOOST_CHECK_THROW(CallRPC("createrawtransaction null null"), runtime_error);
	BOOST_CHECK_THROW(CallRPC("createrawtransaction not_array"), runtime_error);
	BOOST_CHECK_THROW(CallRPC("createrawtransaction [] []"), runtime_error);
	BOOST_CHECK_THROW(CallRPC("createrawtransaction {} {}"), runtime_error);
	BOOST_CHECK_NO_THROW(CallRPC("createrawtransaction [] {}"));
	BOOST_CHECK_THROW(CallRPC("createrawtransaction [] {} extra"), runtime_error);

	BOOST_CHECK_THROW(CallRPC("decoderawtransaction"), runtime_error);
	BOOST_CHECK_THROW(CallRPC("decoderawtransaction null"), runtime_error);
	BOOST_CHECK_THROW(CallRPC("decoderawtransaction DEADBEEF"), runtime_error);
	string rawtx = "0100000001a15d57094aa7a21a28cb20b59aab8fc7d1149a3bdbcddba9c622e4f5f6a99ece010000006c493046022100f93bb0e7d8db7bd46e40132d1f8242026e045f03a0efe71bbb8e3f475e970d790221009337cd7f1f929f00cc6ff01f03729b069a7c21b59b1736ddfee5db5946c5da8c0121033b9b137ee87d5a812d6f506efdd37f0affa7ffc310711c06c7f3e097c9447c52ffffffff0100e1f505000000001976a9140389035a9225b3839e2bbf32d826a1e222031fd888ac00000000";
	BOOST_CHECK_NO_THROW(r = CallRPC(string("decoderawtransaction ")+rawtx));
	BOOST_CHECK_EQUAL(find_value(r.get_obj(), "version").get_int(), 1);
	BOOST_CHECK_EQUAL(find_value(r.get_obj(), "locktime").get_int(), 0);
	BOOST_CHECK_THROW(r = CallRPC(string("decoderawtransaction ")+rawtx+" extra"), runtime_error);

	BOOST_CHECK_THROW(CallRPC("signrawtransaction"), runtime_error);
	BOOST_CHECK_THROW(CallRPC("signrawtransaction null"), runtime_error);
	BOOST_CHECK_THROW(CallRPC("signrawtransaction ff00"), runtime_error);
	BOOST_CHECK_NO_THROW(CallRPC(string("signrawtransaction ")+rawtx));
	BOOST_CHECK_NO_THROW(CallRPC(string("signrawtransaction ")+rawtx+" null null NONE\|ANYONECANPAY"));
	BOOST_CHECK_NO_THROW(CallRPC(string("signrawtransaction ")+rawtx+" [] [] NONE\|ANYONECANPAY"));
	BOOST_CHECK_THROW(CallRPC(string("signrawtransaction ")+rawtx+" null null badenum"), runtime_error);

	// Only check failure cases for sendrawtransaction, there's no network to send to...
	BOOST_CHECK_THROW(CallRPC("sendrawtransaction"), runtime_error);
	BOOST_CHECK_THROW(CallRPC("sendrawtransaction null"), runtime_error);
	BOOST_CHECK_THROW(CallRPC("sendrawtransaction DEADBEEF"), runtime_error);
	BOOST_CHECK_THROW(CallRPC(string("sendrawtransaction ")+rawtx+" extra"), runtime_error);
	}

	BOOST_AUTO_TEST_CASE(rpc_rawsign)
	{
	UniValue r;
	// input is a 1-of-2 multisig (so is output):
	string prevout =
	"[{\"txid\":\"b4cc287e58f87cdae59417329f710f3ecd75a4ee1d2872b7248f50977c8493f3\","
	"\"vout\":1,\"scriptPubKey\":\"a914b10c9df5f7edf436c697f02f1efdba4cf399615187\","
	"\"redeemScript\":\"512103debedc17b3df2badbcdd86d5feb4562b86fe182e5998abd8bcd4f122c6155b1b21027e940bb73ab8732bfdf7f9216ecefca5b94d6df834e77e108f68e66f126044c052ae\"}]";
	r = CallRPC(string("createrawtransaction ")+prevout+" "+
	"{\"3HqAe9LtNBjnsfM4CyYaWTnvCaUYT7v4oZ\":11}");
	string notsigned = r.get_str();
	string privkey1 = "\"KzsXybp9jX64P5ekX1KUxRQ79Jht9uzW7LorgwE65i5rWACL6LQe\"";
	string privkey2 = "\"Kyhdf5LuKTRx4ge69ybABsiUAWjVRK4XGxAKk2FQLp2HjGMy87Z4\"";
	r = CallRPC(string("signrawtransaction ")+notsigned+" "+prevout+" "+"[]");
	BOOST_CHECK(find_value(r.get_obj(), "complete").get_bool() == false);
	r = CallRPC(string("signrawtransaction ")+notsigned+" "+prevout+" "+"["+privkey1+","+privkey2+"]");
	BOOST_CHECK(find_value(r.get_obj(), "complete").get_bool() == true);
	}

	+BOOST_AUTO_TEST_CASE(rpc_createraw_op_return)
	+{
	+ BOOST_CHECK_NO_THROW(CallRPC("createrawtransaction [{\"txid\":\"a3b807410df0b60fcb9736768df5823938b2f838694939ba45f3c0a1bff150ed\",\"vout\":0}] {\"data\":\"68656c6c6f776f726c64\"}"));
	+
	+ // Allow more than one data transaction output
	+ BOOST_CHECK_NO_THROW(CallRPC("createrawtransaction [{\"txid\":\"a3b807410df0b60fcb9736768df5823938b2f838694939ba45f3c0a1bff150ed\",\"vout\":0}] {\"data\":\"68656c6c6f776f726c64\",\"data\":\"68656c6c6f776f726c64\"}"));
	+
	+ // Key not "data" (bad address)
	+ BOOST_CHECK_THROW(CallRPC("createrawtransaction [{\"txid\":\"a3b807410df0b60fcb9736768df5823938b2f838694939ba45f3c0a1bff150ed\",\"vout\":0}] {\"somedata\":\"68656c6c6f776f726c64\"}"), runtime_error);
	+
	+ // Bad hex encoding of data output
	+ BOOST_CHECK_THROW(CallRPC("createrawtransaction [{\"txid\":\"a3b807410df0b60fcb9736768df5823938b2f838694939ba45f3c0a1bff150ed\",\"vout\":0}] {\"data\":\"12345\"}"), runtime_error);
	+ BOOST_CHECK_THROW(CallRPC("createrawtransaction [{\"txid\":\"a3b807410df0b60fcb9736768df5823938b2f838694939ba45f3c0a1bff150ed\",\"vout\":0}] {\"data\":\"12345g\"}"), runtime_error);
	+
	+ // Data 81 bytes long
	+ BOOST_CHECK_NO_THROW(CallRPC("createrawtransaction [{\"txid\":\"a3b807410df0b60fcb9736768df5823938b2f838694939ba45f3c0a1bff150ed\",\"vout\":0}] {\"data\":\"010203040506070809101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081\"}"));
	+}
	+
	BOOST_AUTO_TEST_CASE(rpc_format_monetary_values)
	{
	BOOST_CHECK(ValueFromAmount(0LL).write() == "0.00000000");
	BOOST_CHECK(ValueFromAmount(1LL).write() == "0.00000001");
	BOOST_CHECK(ValueFromAmount(17622195LL).write() == "0.17622195");
	BOOST_CHECK(ValueFromAmount(50000000LL).write() == "0.50000000");
	BOOST_CHECK(ValueFromAmount(89898989LL).write() == "0.89898989");
	BOOST_CHECK(ValueFromAmount(100000000LL).write() == "1.00000000");
	BOOST_CHECK(ValueFromAmount(2099999999999990LL).write() == "20999999.99999990");
	BOOST_CHECK(ValueFromAmount(2099999999999999LL).write() == "20999999.99999999");

	BOOST_CHECK_EQUAL(ValueFromAmount(0).write(), "0.00000000");
	BOOST_CHECK_EQUAL(ValueFromAmount((COIN/10000)*123456789).write(), "12345.67890000");
	BOOST_CHECK_EQUAL(ValueFromAmount(-COIN).write(), "-1.00000000");
	BOOST_CHECK_EQUAL(ValueFromAmount(-COIN/10).write(), "-0.10000000");

	BOOST_CHECK_EQUAL(ValueFromAmount(COIN*100000000).write(), "100000000.00000000");
	BOOST_CHECK_EQUAL(ValueFromAmount(COIN*10000000).write(), "10000000.00000000");
	BOOST_CHECK_EQUAL(ValueFromAmount(COIN*1000000).write(), "1000000.00000000");
	BOOST_CHECK_EQUAL(ValueFromAmount(COIN*100000).write(), "100000.00000000");
	BOOST_CHECK_EQUAL(ValueFromAmount(COIN*10000).write(), "10000.00000000");
	BOOST_CHECK_EQUAL(ValueFromAmount(COIN*1000).write(), "1000.00000000");
	BOOST_CHECK_EQUAL(ValueFromAmount(COIN*100).write(), "100.00000000");
	BOOST_CHECK_EQUAL(ValueFromAmount(COIN*10).write(), "10.00000000");
	BOOST_CHECK_EQUAL(ValueFromAmount(COIN).write(), "1.00000000");
	BOOST_CHECK_EQUAL(ValueFromAmount(COIN/10).write(), "0.10000000");
	BOOST_CHECK_EQUAL(ValueFromAmount(COIN/100).write(), "0.01000000");
	BOOST_CHECK_EQUAL(ValueFromAmount(COIN/1000).write(), "0.00100000");
	BOOST_CHECK_EQUAL(ValueFromAmount(COIN/10000).write(), "0.00010000");
	BOOST_CHECK_EQUAL(ValueFromAmount(COIN/100000).write(), "0.00001000");
	BOOST_CHECK_EQUAL(ValueFromAmount(COIN/1000000).write(), "0.00000100");
	BOOST_CHECK_EQUAL(ValueFromAmount(COIN/10000000).write(), "0.00000010");
	BOOST_CHECK_EQUAL(ValueFromAmount(COIN/100000000).write(), "0.00000001");
	}

	static UniValue ValueFromString(const std::string &str)
	{
	UniValue value;
	BOOST_CHECK(value.setNumStr(str));
	return value;
	}

	BOOST_AUTO_TEST_CASE(rpc_parse_monetary_values)
	{
	BOOST_CHECK_THROW(AmountFromValue(ValueFromString("-0.00000001")), UniValue);
	BOOST_CHECK_EQUAL(AmountFromValue(ValueFromString("0")), 0LL);
	BOOST_CHECK_EQUAL(AmountFromValue(ValueFromString("0.00000000")), 0LL);
	BOOST_CHECK_EQUAL(AmountFromValue(ValueFromString("0.00000001")), 1LL);
	BOOST_CHECK_EQUAL(AmountFromValue(ValueFromString("0.17622195")), 17622195LL);
	BOOST_CHECK_EQUAL(AmountFromValue(ValueFromString("0.5")), 50000000LL);
	BOOST_CHECK_EQUAL(AmountFromValue(ValueFromString("0.50000000")), 50000000LL);
	BOOST_CHECK_EQUAL(AmountFromValue(ValueFromString("0.89898989")), 89898989LL);
	BOOST_CHECK_EQUAL(AmountFromValue(ValueFromString("1.00000000")), 100000000LL);
	BOOST_CHECK_EQUAL(AmountFromValue(ValueFromString("20999999.9999999")), 2099999999999990LL);
	BOOST_CHECK_EQUAL(AmountFromValue(ValueFromString("20999999.99999999")), 2099999999999999LL);

	BOOST_CHECK_EQUAL(AmountFromValue(ValueFromString("1e-8")), COIN/100000000);
	BOOST_CHECK_EQUAL(AmountFromValue(ValueFromString("0.1e-7")), COIN/100000000);
	BOOST_CHECK_EQUAL(AmountFromValue(ValueFromString("0.01e-6")), COIN/100000000);
	BOOST_CHECK_EQUAL(AmountFromValue(ValueFromString("0.0000000000000000000000000000000000000000000000000000000000000000000000000001e+68")), COIN/100000000);
	BOOST_CHECK_EQUAL(AmountFromValue(ValueFromString("10000000000000000000000000000000000000000000000000000000000000000e-64")), COIN);
	BOOST_CHECK_EQUAL(AmountFromValue(ValueFromString("0.000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000e64")), COIN);

	BOOST_CHECK_THROW(AmountFromValue(ValueFromString("1e-9")), UniValue); //should fail
	BOOST_CHECK_THROW(AmountFromValue(ValueFromString("0.000000019")), UniValue); //should fail
	BOOST_CHECK_EQUAL(AmountFromValue(ValueFromString("0.00000001000000")), 1LL); //should pass, cut trailing 0
	BOOST_CHECK_THROW(AmountFromValue(ValueFromString("19e-9")), UniValue); //should fail
	BOOST_CHECK_EQUAL(AmountFromValue(ValueFromString("0.19e-6")), 19); //should pass, leading 0 is present

	BOOST_CHECK_THROW(AmountFromValue(ValueFromString("92233720368.54775808")), UniValue); //overflow error
	BOOST_CHECK_THROW(AmountFromValue(ValueFromString("1e+11")), UniValue); //overflow error
	BOOST_CHECK_THROW(AmountFromValue(ValueFromString("1e11")), UniValue); //overflow error signless
	BOOST_CHECK_THROW(AmountFromValue(ValueFromString("93e+9")), UniValue); //overflow error
	}

	BOOST_AUTO_TEST_CASE(json_parse_errors)
	{
	// Valid
	BOOST_CHECK_EQUAL(ParseNonRFCJSONValue("1.0").get_real(), 1.0);
	// Valid, with leading or trailing whitespace
	BOOST_CHECK_EQUAL(ParseNonRFCJSONValue(" 1.0").get_real(), 1.0);
	BOOST_CHECK_EQUAL(ParseNonRFCJSONValue("1.0 ").get_real(), 1.0);

	BOOST_CHECK_THROW(AmountFromValue(ParseNonRFCJSONValue(".19e-6")), std::runtime_error); //should fail, missing leading 0, therefore invalid JSON
	BOOST_CHECK_EQUAL(AmountFromValue(ParseNonRFCJSONValue("0.00000000000000000000000000000000000001e+30 ")), 1);
	// Invalid, initial garbage
	BOOST_CHECK_THROW(ParseNonRFCJSONValue("[1.0"), std::runtime_error);
	BOOST_CHECK_THROW(ParseNonRFCJSONValue("a1.0"), std::runtime_error);
	// Invalid, trailing garbage
	BOOST_CHECK_THROW(ParseNonRFCJSONValue("1.0sds"), std::runtime_error);
	BOOST_CHECK_THROW(ParseNonRFCJSONValue("1.0]"), std::runtime_error);
	// BTC addresses should fail parsing
	BOOST_CHECK_THROW(ParseNonRFCJSONValue("175tWpb8K1S7NmH4Zx6rewF9WQrcZv245W"), std::runtime_error);
	BOOST_CHECK_THROW(ParseNonRFCJSONValue("3J98t1WpEZ73CNmQviecrnyiWrnqRhWNL"), std::runtime_error);
	}

	BOOST_AUTO_TEST_CASE(rpc_boostasiotocnetaddr)
	{
	// Check IPv4 addresses
	BOOST_CHECK_EQUAL(BoostAsioToCNetAddr(boost::asio::ip::address::from_string("1.2.3.4")).ToString(), "1.2.3.4");
	BOOST_CHECK_EQUAL(BoostAsioToCNetAddr(boost::asio::ip::address::from_string("127.0.0.1")).ToString(), "127.0.0.1");
	// Check IPv6 addresses
	BOOST_CHECK_EQUAL(BoostAsioToCNetAddr(boost::asio::ip::address::from_string("::1")).ToString(), "::1");
	BOOST_CHECK_EQUAL(BoostAsioToCNetAddr(boost::asio::ip::address::from_string("123:4567:89ab:cdef:123:4567:89ab:cdef")).ToString(),
	"123:4567:89ab:cdef:123:4567:89ab:cdef");
	// v4 compatible must be interpreted as IPv4
	BOOST_CHECK_EQUAL(BoostAsioToCNetAddr(boost::asio::ip::address::from_string("::0:127.0.0.1")).ToString(), "127.0.0.1");
	// v4 mapped must be interpreted as IPv4
	BOOST_CHECK_EQUAL(BoostAsioToCNetAddr(boost::asio::ip::address::from_string("::ffff:127.0.0.1")).ToString(), "127.0.0.1");
	}

	BOOST_AUTO_TEST_CASE(rpc_ban)
	{
	BOOST_CHECK_NO_THROW(CallRPC(string("clearbanned")));

	UniValue r;
	BOOST_CHECK_NO_THROW(r = CallRPC(string("setban 127.0.0.0 add")));
	BOOST_CHECK_THROW(r = CallRPC(string("setban 127.0.0.0:8334")), runtime_error); //portnumber for setban not allowed
	BOOST_CHECK_NO_THROW(r = CallRPC(string("listbanned")));
	UniValue ar = r.get_array();
	UniValue o1 = ar[0].get_obj();
	UniValue adr = find_value(o1, "address");
	BOOST_CHECK_EQUAL(adr.get_str(), "127.0.0.0/255.255.255.255");
	BOOST_CHECK_NO_THROW(CallRPC(string("setban 127.0.0.0 remove")));;
	BOOST_CHECK_NO_THROW(r = CallRPC(string("listbanned")));
	ar = r.get_array();
	BOOST_CHECK_EQUAL(ar.size(), 0);

	BOOST_CHECK_NO_THROW(r = CallRPC(string("setban 127.0.0.0/24 add 1607731200 true")));
	BOOST_CHECK_NO_THROW(r = CallRPC(string("listbanned")));
	ar = r.get_array();
	o1 = ar[0].get_obj();
	adr = find_value(o1, "address");
	UniValue banned_until = find_value(o1, "banned_until");
	BOOST_CHECK_EQUAL(adr.get_str(), "127.0.0.0/255.255.255.0");
	BOOST_CHECK_EQUAL(banned_until.get_int64(), 1607731200); // absolute time check

	BOOST_CHECK_NO_THROW(CallRPC(string("clearbanned")));

	BOOST_CHECK_NO_THROW(r = CallRPC(string("setban 127.0.0.0/24 add 200")));
	BOOST_CHECK_NO_THROW(r = CallRPC(string("listbanned")));
	ar = r.get_array();
	o1 = ar[0].get_obj();
	adr = find_value(o1, "address");
	banned_until = find_value(o1, "banned_until");
	BOOST_CHECK_EQUAL(adr.get_str(), "127.0.0.0/255.255.255.0");
	int64_t now = GetTime();
	BOOST_CHECK(banned_until.get_int64() > now);
	BOOST_CHECK(banned_until.get_int64()-now <= 200);

	// must throw an exception because 127.0.0.1 is in already banned suubnet range
	BOOST_CHECK_THROW(r = CallRPC(string("setban 127.0.0.1 add")), runtime_error);

	BOOST_CHECK_NO_THROW(CallRPC(string("setban 127.0.0.0/24 remove")));;
	BOOST_CHECK_NO_THROW(r = CallRPC(string("listbanned")));
	ar = r.get_array();
	BOOST_CHECK_EQUAL(ar.size(), 0);

	BOOST_CHECK_NO_THROW(r = CallRPC(string("setban 127.0.0.0/255.255.0.0 add")));
	BOOST_CHECK_THROW(r = CallRPC(string("setban 127.0.1.1 add")), runtime_error);

	BOOST_CHECK_NO_THROW(CallRPC(string("clearbanned")));
	BOOST_CHECK_NO_THROW(r = CallRPC(string("listbanned")));
	ar = r.get_array();
	BOOST_CHECK_EQUAL(ar.size(), 0);


	BOOST_CHECK_THROW(r = CallRPC(string("setban test add")), runtime_error); //invalid IP

	//IPv6 tests
	BOOST_CHECK_NO_THROW(r = CallRPC(string("setban FE80:0000:0000:0000:0202:B3FF:FE1E:8329 add")));
	BOOST_CHECK_NO_THROW(r = CallRPC(string("listbanned")));
	ar = r.get_array();
	o1 = ar[0].get_obj();
	adr = find_value(o1, "address");
	BOOST_CHECK_EQUAL(adr.get_str(), "fe80::202:b3ff:fe1e:8329/ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff");

	BOOST_CHECK_NO_THROW(CallRPC(string("clearbanned")));
	BOOST_CHECK_NO_THROW(r = CallRPC(string("setban 2001:db8::/30 add")));
	BOOST_CHECK_NO_THROW(r = CallRPC(string("listbanned")));
	ar = r.get_array();
	o1 = ar[0].get_obj();
	adr = find_value(o1, "address");
	BOOST_CHECK_EQUAL(adr.get_str(), "2001:db8::/ffff:fffc:0:0:0:0:0:0");

	BOOST_CHECK_NO_THROW(CallRPC(string("clearbanned")));
	BOOST_CHECK_NO_THROW(r = CallRPC(string("setban 2001:4d48:ac57:400:cacf:e9ff:fe1d:9c63/128 add")));
	BOOST_CHECK_NO_THROW(r = CallRPC(string("listbanned")));
	ar = r.get_array();
	o1 = ar[0].get_obj();
	adr = find_value(o1, "address");
	BOOST_CHECK_EQUAL(adr.get_str(), "2001:4d48:ac57:400:cacf:e9ff:fe1d:9c63/ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff");
	}

	BOOST_AUTO_TEST_SUITE_END()

File Metadata

Mime Type: text/x-diff
Expires: Wed, May 21, 20:07 (1 d, 6 h)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 5865841
Default Alt Text: (54 KB)

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions