Page MenuHomePhabricator

Script_tests.json handler should ensure pushed groups are the right size
Closed, ResolvedPublic

Description

Per https://reviews.bitcoinabc.org/D1291, you can see that running a push opcode prior to a group of bytes sometimes did not push the intended number of bytes. This can unintentionally allow the test to pass, when it should have failed. Ensuring that the code which parses script_tests.json enforces that groups of bytes are pushed properly will resolve this issue in the future.

Event Timeline

schancel created this task.Apr 16 2018, 19:55
schancel triaged this task as High priority.
schancel claimed this task.Sep 28 2018, 21:17
schancel closed this task as Resolved.