Page MenuHomePhabricator

schancel (Shammah Chancellor)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 7 2017, 01:36 (342 w, 3 h)

Recent Activity

Jun 29 2021

schancel updated the diff for D9694: Ensure `nExtraNonce` is initialized randomly.

Removing deterministic check on txout dump. Does not seem to be
testable given that block hashes and txout hashes are no longer
deterministic on regtest.

Jun 29 2021, 01:32

Jun 23 2021

schancel added a comment to D9694: Ensure `nExtraNonce` is initialized randomly.

Will look at the second test that's broken later.

Jun 23 2021, 05:55
schancel updated the diff for D9694: Ensure `nExtraNonce` is initialized randomly.

Fixes rpc_blockchain. It should have used assert_approx, but dependented on
the deterministic nature of the extra nonce.

Jun 23 2021, 05:54
schancel requested review of D9694: Ensure `nExtraNonce` is initialized randomly.
Jun 23 2021, 04:42

Aug 27 2020

rottengonzo awarded T246: Testing scripts should run all tests a Like token.
Aug 27 2020, 02:50 · Bootcamp

Aug 26 2020

Tom39 awarded T321: Create test to check node banning behavior a Like token.
Aug 26 2020, 04:32 · Bootcamp

Sep 19 2019

schancel committed rSTAGING0965d7294845: Fix lock reference in miner.h (authored by schancel).
Fix lock reference in miner.h
Sep 19 2019, 00:21

Sep 18 2019

schancel committed rSTAGING819b0da6cb91: [mining] Add a test for TestCBlockTemplateEntry (authored by schancel).
[mining] Add a test for TestCBlockTemplateEntry
Sep 18 2019, 23:57
schancel committed rSTAGING30a7f3e07d22: [nit] do not capture unused `this` in wallet interface (authored by schancel).
[nit] do not capture unused `this` in wallet interface
Sep 18 2019, 23:55
schancel committed rSTAGINGcebcb34c93c0: [mining] Rename several CBlockTemplateEntry members for clarity (authored by schancel).
[mining] Rename several CBlockTemplateEntry members for clarity
Sep 18 2019, 23:24
schancel committed rSTAGINGa9acc46b47f0: [nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction` (authored by schancel).
[nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction`
Sep 18 2019, 23:08
schancel committed rSTAGING64cf5c985353: [qa] [nit] remove extranous variable in mining_prioritisetransaction.py (authored by schancel).
[qa] [nit] remove extranous variable in mining_prioritisetransaction.py
Sep 18 2019, 23:06
schancel committed rSTAGING3623cccdc6ff: Nits in abc-high_priority_transaction.py (authored by schancel).
Nits in abc-high_priority_transaction.py
Sep 18 2019, 23:05
schancel committed rSTAGING36fb94ee0821: Remove much of the remaining BIP9 code (authored by schancel).
Remove much of the remaining BIP9 code
Sep 18 2019, 22:56
schancel committed rSTAGINGa57aebfd30e6: [Part 4 of 5] Add a CChainState class to clarify internal interfaces (authored by Matt Corallo <git@bluematt.me>).
[Part 4 of 5] Add a CChainState class to clarify internal interfaces
Sep 18 2019, 22:56
schancel committed rSTAGING1201c8ad49e4: Remove unused depends list from `getblocktemplate` transactions (authored by schancel).
Remove unused depends list from `getblocktemplate` transactions
Sep 18 2019, 22:56
schancel committed rSTAGING0043646b87d1: Remove unused parameter `validFeeEstimates` from `CTxMempool::addUnchecked` (authored by schancel).
Remove unused parameter `validFeeEstimates` from `CTxMempool::addUnchecked`
Sep 18 2019, 22:56
schancel committed rSTAGINGe3e4e04a390f: Fix comment in CheckInputs to match changed code (authored by schancel).
Fix comment in CheckInputs to match changed code
Sep 18 2019, 22:55
schancel committed rSTAGING20f59d582b2b: [Part 3 of 5] Add a CChainState class to clarify internal interfaces (authored by Matt Corallo <git@bluematt.me>).
[Part 3 of 5] Add a CChainState class to clarify internal interfaces
Sep 18 2019, 22:50

Aug 24 2019

James awarded T321: Create test to check node banning behavior a Mountain of Wealth token.
Aug 24 2019, 04:53 · Bootcamp

Jun 16 2019

schancel committed rABC0965d7294845: Fix lock reference in miner.h (authored by schancel).
Fix lock reference in miner.h
Jun 16 2019, 21:51
schancel closed D3351: Fix lock reference in miner.h.
Jun 16 2019, 21:50
schancel updated the test plan for D3351: Fix lock reference in miner.h.
Jun 16 2019, 21:40
schancel retitled D3351: Fix lock reference in miner.h from Fix lock reference in miner.cpp to Fix lock reference in miner.h.
Jun 16 2019, 21:37
schancel created D3351: Fix lock reference in miner.h.
Jun 16 2019, 21:37

Jun 3 2019

markblundeberg awarded D2788: Remove unknown version warning from UpdateTip a Piece of Eight token.
Jun 3 2019, 14:37

Jun 2 2019

schancel added a comment to D2866: [mining] Implement new package selection code which is independent of chain length.

Rebase

Jun 2 2019, 07:29
schancel added a comment to D3164: [mining] Track maximum feerate of parent packages.

Rebase

Jun 2 2019, 07:29
schancel added a comment to D3163: [mining] Track a modified fees field..

rebase

Jun 2 2019, 07:29
schancel added a comment to D2865: [mining] Change inBlock to be an unordered set.

Rebase

Jun 2 2019, 07:25
schancel added a comment to D2864: [mining] Add package accounting functions to CBlockTemplateEntry.

Fix comments

Jun 2 2019, 07:24

Jun 1 2019

schancel committed rABC819b0da6cb91: [mining] Add a test for TestCBlockTemplateEntry (authored by schancel).
[mining] Add a test for TestCBlockTemplateEntry
Jun 1 2019, 18:18
schancel closed D3162: [mining] Add a test for TestCBlockTemplateEntry.
Jun 1 2019, 18:18
schancel committed rABC30a7f3e07d22: [nit] do not capture unused `this` in wallet interface (authored by schancel).
[nit] do not capture unused `this` in wallet interface
Jun 1 2019, 07:22
schancel closed D3166: [nit] do not capture unused `this` in wallet interface.
Jun 1 2019, 07:22
schancel updated the diff for D2866: [mining] Implement new package selection code which is independent of chain length.

size_t -> bool ...

Jun 1 2019, 07:19

May 31 2019

Herald added a reviewer for D3166: [nit] do not capture unused `this` in wallet interface: deadalnix.
May 31 2019, 07:13
schancel updated the summary of D3028: [mempool] remove `CompareTxMemPoolEntryByAncestorFee` as it is no longer needed.
May 31 2019, 06:16
schancel updated the diff for D2866: [mining] Implement new package selection code which is independent of chain length.

Rebase on diffs that were split up more for clarity.

May 31 2019, 06:16
schancel updated the summary of D2866: [mining] Implement new package selection code which is independent of chain length.
May 31 2019, 06:10
schancel updated the summary of D3164: [mining] Track maximum feerate of parent packages.
May 31 2019, 06:09
Herald added a reviewer for D3164: [mining] Track maximum feerate of parent packages: deadalnix.
May 31 2019, 06:06
Herald added a reviewer for D3163: [mining] Track a modified fees field.: deadalnix.
May 31 2019, 04:07
schancel updated the diff for D2865: [mining] Change inBlock to be an unordered set.

Rebase

May 31 2019, 03:54
schancel updated the diff for D2864: [mining] Add package accounting functions to CBlockTemplateEntry.

Rebase with a test

May 31 2019, 03:53
schancel updated the summary of D2863: [mining] Add fields for tracking package data..
May 31 2019, 03:32
schancel updated the diff for D2863: [mining] Add fields for tracking package data..

Rebase on D3162

May 31 2019, 03:32
Herald added a reviewer for D3162: [mining] Add a test for TestCBlockTemplateEntry: deadalnix.
May 31 2019, 03:23
schancel added inline comments to D2866: [mining] Implement new package selection code which is independent of chain length.
May 31 2019, 02:10

May 13 2019

schancel accepted D3013: [rpc] Move tojson.h into blockchain.h.
May 13 2019, 18:45
schancel added a comment to D3013: [rpc] Move tojson.h into blockchain.h.

Okay, I see. That's weird -- still not sure *toJSON functions should go there, but okay.

May 13 2019, 18:45
schancel added a comment to D3013: [rpc] Move tojson.h into blockchain.h.

I think more and more stuff should be better organized. Core doesn't seem to care about separating stuff out much.

May 13 2019, 02:53

May 12 2019

schancel added inline comments to D3013: [rpc] Move tojson.h into blockchain.h.
May 12 2019, 23:48
schancel requested changes to D3013: [rpc] Move tojson.h into blockchain.h.

I think these should be left in place.

May 12 2019, 23:47
schancel updated the summary of D3027: [mining] Delete accuratelyAddPackageTxns and its associates.
May 12 2019, 06:27
Herald added a reviewer for D3029: [move] move TxCoinAgePriority to it's sole usage location.: deadalnix.
May 12 2019, 06:08
Herald added a reviewer for D3028: [mempool] remove `CompareTxMemPoolEntryByAncestorFee` as it is no longer needed: deadalnix.
May 12 2019, 05:34
Herald added a reviewer for D3027: [mining] Delete accuratelyAddPackageTxns and its associates: deadalnix.
May 12 2019, 02:56
schancel accepted D3012: Backport current GetDifficulty logic (& tests) from Core.
May 12 2019, 02:29

May 10 2019

schancel updated the diff for D2863: [mining] Add fields for tracking package data..

packageOrder(1) -> packageOrder(0)

May 10 2019, 01:48
schancel added inline comments to D2864: [mining] Add package accounting functions to CBlockTemplateEntry.
May 10 2019, 00:49
schancel added inline comments to D2864: [mining] Add package accounting functions to CBlockTemplateEntry.
May 10 2019, 00:48

May 9 2019

schancel added inline comments to D2863: [mining] Add fields for tracking package data..
May 9 2019, 06:08
schancel updated the diff for D2863: [mining] Add fields for tracking package data..

Update comment on the order field

May 9 2019, 02:22
schancel updated the diff for D2863: [mining] Add fields for tracking package data..

Rebase and fix a couple errors in the comments.

May 9 2019, 02:20
schancel committed rABCcebcb34c93c0: [mining] Rename several CBlockTemplateEntry members for clarity (authored by schancel).
[mining] Rename several CBlockTemplateEntry members for clarity
May 9 2019, 02:16
schancel closed D2862: [mining] Rename several CBlockTemplateEntry members for clarity.
May 9 2019, 02:16
schancel updated the diff for D2862: [mining] Rename several CBlockTemplateEntry members for clarity.

Update for clarity that the comment pertains only to the coinbase

May 9 2019, 01:31
schancel updated the summary of D2862: [mining] Rename several CBlockTemplateEntry members for clarity.
May 9 2019, 01:14
schancel added inline comments to D2862: [mining] Rename several CBlockTemplateEntry members for clarity.
May 9 2019, 01:13
schancel updated the diff for D2862: [mining] Rename several CBlockTemplateEntry members for clarity.

Update with comment per @jasonbcox

May 9 2019, 01:13

May 5 2019

schancel added inline comments to D2862: [mining] Rename several CBlockTemplateEntry members for clarity.
May 5 2019, 07:08

Apr 25 2019

schancel added inline comments to D2863: [mining] Add fields for tracking package data..
Apr 25 2019, 05:54
schancel committed rABCa9acc46b47f0: [nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction` (authored by schancel).
[nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction`
Apr 25 2019, 05:53
schancel closed D2853: [nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction`.
Apr 25 2019, 05:53

Apr 24 2019

schancel added inline comments to D2862: [mining] Rename several CBlockTemplateEntry members for clarity.
Apr 24 2019, 23:47
schancel requested review of D2862: [mining] Rename several CBlockTemplateEntry members for clarity.
Apr 24 2019, 23:42
schancel added inline comments to D2862: [mining] Rename several CBlockTemplateEntry members for clarity.
Apr 24 2019, 23:42
schancel added inline comments to D2862: [mining] Rename several CBlockTemplateEntry members for clarity.
Apr 24 2019, 04:41
schancel requested review of D2862: [mining] Rename several CBlockTemplateEntry members for clarity.
Apr 24 2019, 04:40

Apr 23 2019

schancel added inline comments to D2866: [mining] Implement new package selection code which is independent of chain length.
Apr 23 2019, 02:18
schancel updated the diff for D2866: [mining] Implement new package selection code which is independent of chain length.

Fix rebase error on packageOrder

Apr 23 2019, 02:09
schancel updated the diff for D2866: [mining] Implement new package selection code which is independent of chain length.

Update some comments

Apr 23 2019, 02:05
schancel updated the diff for D2853: [nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction`.

Make identical to core pr cited

Apr 23 2019, 01:58
schancel updated the summary of D2853: [nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction`.
Apr 23 2019, 01:52
schancel committed rABC64cf5c985353: [qa] [nit] remove extranous variable in mining_prioritisetransaction.py (authored by schancel).
[qa] [nit] remove extranous variable in mining_prioritisetransaction.py
Apr 23 2019, 01:46
schancel closed D2854: [qa] [nit] remove extranous variable in mining_prioritisetransaction.py.
Apr 23 2019, 01:46
schancel updated the summary of D2866: [mining] Implement new package selection code which is independent of chain length.
Apr 23 2019, 01:37
Herald added a reviewer for D2866: [mining] Implement new package selection code which is independent of chain length: deadalnix.
Apr 23 2019, 01:37
schancel updated the summary of D2865: [mining] Change inBlock to be an unordered set.
Apr 23 2019, 01:24
Herald added a reviewer for D2865: [mining] Change inBlock to be an unordered set: deadalnix.
Apr 23 2019, 01:23
Herald added a reviewer for D2864: [mining] Add package accounting functions to CBlockTemplateEntry: deadalnix.
Apr 23 2019, 01:17
schancel updated the diff for D2863: [mining] Add fields for tracking package data..

Change name of packageCount and add some explanatory comments

Apr 23 2019, 01:15
schancel retitled D2863: [mining] Add fields for tracking package data. from Add fields for tracking package data. to [mining] Add fields for tracking package data..
Apr 23 2019, 01:12
Herald added a reviewer for D2863: [mining] Add fields for tracking package data.: deadalnix.
Apr 23 2019, 01:06
Herald added a reviewer for D2862: [mining] Rename several CBlockTemplateEntry members for clarity: deadalnix.
Apr 23 2019, 01:05

Apr 22 2019

Herald added a reviewer for D2854: [qa] [nit] remove extranous variable in mining_prioritisetransaction.py: deadalnix.
Apr 22 2019, 04:09
Herald added a reviewer for D2853: [nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction`: deadalnix.
Apr 22 2019, 01:23

Apr 21 2019

Herald added a reviewer for D2852: [mining] Require priority transactions to be below minimum relay fee: deadalnix.
Apr 21 2019, 08:07

Apr 20 2019

schancel committed rABC3623cccdc6ff: Nits in abc-high_priority_transaction.py (authored by schancel).
Nits in abc-high_priority_transaction.py
Apr 20 2019, 21:56