Page MenuHomePhabricator

markblundeberg (Mark B Lundeberg)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 23 2018, 01:26 (21 w, 5 d)

Recent Activity

Today

markblundeberg added a revision to T589: BIP157 & BIP158 backports: D2873: serialize: Serialization support for big-endian 32-bit ints..
Wed, Apr 24, 15:22
markblundeberg added a task to D2873: serialize: Serialization support for big-endian 32-bit ints.: T589: BIP157 & BIP158 backports.
Wed, Apr 24, 15:22
Herald added a reviewer for D2873: serialize: Serialization support for big-endian 32-bit ints.: deadalnix.
Wed, Apr 24, 15:20
markblundeberg added a revision to T589: BIP157 & BIP158 backports: D2872: blockfilter: Refactor and add tests for BlockFilter construction.
Wed, Apr 24, 05:19
markblundeberg added a task to D2872: blockfilter: Refactor and add tests for BlockFilter construction: T589: BIP157 & BIP158 backports.
Wed, Apr 24, 05:19
Herald added a reviewer for D2872: blockfilter: Refactor and add tests for BlockFilter construction: deadalnix.
Wed, Apr 24, 05:18
markblundeberg updated the task description for T589: BIP157 & BIP158 backports.
Wed, Apr 24, 01:16
markblundeberg added a comment to T589: BIP157 & BIP158 backports.

getting commit fef5adcc3 looks like it should be done after T590, though it can also wait.

Wed, Apr 24, 01:05
markblundeberg added a parent task for T590: Backport Core 14555: Move util files to new directory: T589: BIP157 & BIP158 backports.
Wed, Apr 24, 01:05 · Backport, Restricted Project
markblundeberg added a subtask for T589: BIP157 & BIP158 backports: T590: Backport Core 14555: Move util files to new directory.
Wed, Apr 24, 01:05

Yesterday

markblundeberg added a revision to T589: BIP157 & BIP158 backports: D2867: blockfilter: add block filters.
Tue, Apr 23, 03:22
markblundeberg added a task to D2867: blockfilter: add block filters: T589: BIP157 & BIP158 backports.
Tue, Apr 23, 03:22
Herald added a reviewer for D2867: blockfilter: add block filters: deadalnix.
Tue, Apr 23, 03:18

Fri, Apr 19

markblundeberg accepted D2457: [schnorr] Refactor the signature process in reusable component.
Fri, Apr 19, 20:20

Wed, Apr 17

markblundeberg updated the diff for D2800: Extract CSipHasher to it's own file in crypto/ directory..

rebase

Wed, Apr 17, 00:44

Tue, Apr 16

markblundeberg added a comment to D2811: Refactor: separate gui from wallet and node.

Macro sobig:

Tue, Apr 16, 23:12
markblundeberg created Image Macro "sobig".
Tue, Apr 16, 23:12
markblundeberg updated the diff for D2803: blockfilter: add GCSFilter class.

forgot cmakelists for test

Tue, Apr 16, 20:39

Sun, Apr 14

markblundeberg updated the diff for D2800: Extract CSipHasher to it's own file in crypto/ directory..

cstdint

Sun, Apr 14, 23:36
markblundeberg updated the diff for D2803: blockfilter: add GCSFilter class.

char eradication and header normalization

Sun, Apr 14, 23:30
markblundeberg added a task to D2803: blockfilter: add GCSFilter class: T589: BIP157 & BIP158 backports.
Sun, Apr 14, 05:31
markblundeberg added a revision to T589: BIP157 & BIP158 backports: D2803: blockfilter: add GCSFilter class.
Sun, Apr 14, 05:31
Herald added a reviewer for D2803: blockfilter: add GCSFilter class: deadalnix.
Sun, Apr 14, 05:31

Sat, Apr 13

markblundeberg updated the task description for T589: BIP157 & BIP158 backports.
Sat, Apr 13, 18:51
markblundeberg updated the diff for D2800: Extract CSipHasher to it's own file in crypto/ directory..
  • added cmakelists entry
  • created siphash.* files from ABC code instead of Core code
Sat, Apr 13, 16:39
markblundeberg added inline comments to D2800: Extract CSipHasher to it's own file in crypto/ directory..
Sat, Apr 13, 16:16
markblundeberg requested changes to D2457: [schnorr] Refactor the signature process in reusable component.

getting this rolling again ...

Sat, Apr 13, 14:47
markblundeberg added a revision to T589: BIP157 & BIP158 backports: D2800: Extract CSipHasher to it's own file in crypto/ directory..
Sat, Apr 13, 00:33
markblundeberg added a task to D2800: Extract CSipHasher to it's own file in crypto/ directory.: T589: BIP157 & BIP158 backports.
Sat, Apr 13, 00:33
Herald added a reviewer for D2800: Extract CSipHasher to it's own file in crypto/ directory.: deadalnix.
Sat, Apr 13, 00:31

Fri, Apr 12

markblundeberg updated the task description for T589: BIP157 & BIP158 backports.
Fri, Apr 12, 22:49
markblundeberg updated the diff for D2799: streams: Implement BitStreamReader/Writer classes..

fix comments & typo

Fri, Apr 12, 20:14
markblundeberg updated the diff for D2797: streams: Create VectorReader stream interface for vectors..
  • remove seek method per later backport
  • adjust comments style per comments
  • use cstdint types
Fri, Apr 12, 19:37
markblundeberg added inline comments to D2799: streams: Implement BitStreamReader/Writer classes..
Fri, Apr 12, 17:44
markblundeberg planned changes to D2797: streams: Create VectorReader stream interface for vectors..
Fri, Apr 12, 15:45
markblundeberg added a task to D2799: streams: Implement BitStreamReader/Writer classes.: T589: BIP157 & BIP158 backports.
Fri, Apr 12, 03:17
markblundeberg added a revision to T589: BIP157 & BIP158 backports: D2799: streams: Implement BitStreamReader/Writer classes..
Fri, Apr 12, 03:17
Herald added a reviewer for D2799: streams: Implement BitStreamReader/Writer classes.: deadalnix.
Fri, Apr 12, 03:16
markblundeberg updated the summary of D2797: streams: Create VectorReader stream interface for vectors..
Fri, Apr 12, 02:52
markblundeberg abandoned D2798: streams: Unit test for VectorReader class..
Fri, Apr 12, 02:37
markblundeberg updated the diff for D2797: streams: Create VectorReader stream interface for vectors..

squashed in child commit

Fri, Apr 12, 02:36
markblundeberg planned changes to D2798: streams: Unit test for VectorReader class..
Fri, Apr 12, 02:15
markblundeberg planned changes to D2797: streams: Create VectorReader stream interface for vectors..
Fri, Apr 12, 02:14
markblundeberg updated the test plan for D2798: streams: Unit test for VectorReader class..
Fri, Apr 12, 02:12
markblundeberg updated the test plan for D2797: streams: Create VectorReader stream interface for vectors..
Fri, Apr 12, 02:11
markblundeberg updated the summary of D2798: streams: Unit test for VectorReader class..
Fri, Apr 12, 02:04
markblundeberg updated the summary of D2798: streams: Unit test for VectorReader class..
Fri, Apr 12, 02:04
markblundeberg updated the summary of D2797: streams: Create VectorReader stream interface for vectors..
Fri, Apr 12, 02:03
markblundeberg added a revision to T589: BIP157 & BIP158 backports: D2798: streams: Unit test for VectorReader class..
Fri, Apr 12, 02:03
markblundeberg added a task to D2798: streams: Unit test for VectorReader class.: T589: BIP157 & BIP158 backports.
Fri, Apr 12, 02:03
markblundeberg added a task to D2797: streams: Create VectorReader stream interface for vectors.: T589: BIP157 & BIP158 backports.
Fri, Apr 12, 02:03
markblundeberg added a revision to T589: BIP157 & BIP158 backports: D2797: streams: Create VectorReader stream interface for vectors..
Fri, Apr 12, 02:03
Herald added a reviewer for D2798: streams: Unit test for VectorReader class.: deadalnix.
Fri, Apr 12, 02:02
Herald added a reviewer for D2797: streams: Create VectorReader stream interface for vectors.: deadalnix.
Fri, Apr 12, 02:00

Thu, Apr 11

markblundeberg triaged T589: BIP157 & BIP158 backports as Normal priority.
Thu, Apr 11, 01:21

Feb 22 2019

markblundeberg abandoned D2516: Add address_cashaddr/address_legacy to validateaddress output.

It's been a couple of weeks. @Mondas if you want to reactivate this Diff, let me know.

Feb 22 2019, 16:31

Feb 18 2019

markblundeberg accepted D2563: Added missing release notes for 0.19.
Feb 18 2019, 19:25
Herald added a reviewer for D2562: un-mention segwit in addnode help text: deadalnix.
Feb 18 2019, 15:45

Feb 17 2019

markblundeberg added inline comments to D2457: [schnorr] Refactor the signature process in reusable component.
Feb 17 2019, 01:16

Feb 16 2019

markblundeberg updated the diff for D2559: fix Qt crash.

s/Qt/bitcoin-qt

Feb 16 2019, 03:40
markblundeberg updated the diff for D2559: fix Qt crash.

add release note

Feb 16 2019, 03:35
Herald added a reviewer for D2559: fix Qt crash: deadalnix.
Feb 16 2019, 03:02
markblundeberg added a comment to D2322: remove minimum total fee option.

Need fix: https://github.com/bitcoin/bitcoin/pull/11332

Feb 16 2019, 02:41
markblundeberg added inline comments to D2322: remove minimum total fee option.
Feb 16 2019, 02:22

Feb 15 2019

markblundeberg removed a task from D2349: fix confusingly named function parameter 'scriptSig': T527: Add Schnorr support to OP_CHECKSIG and OP_CHECKDATASIG.
Feb 15 2019, 17:08
markblundeberg removed a revision from T527: Add Schnorr support to OP_CHECKSIG and OP_CHECKDATASIG: D2349: fix confusingly named function parameter 'scriptSig'.
Feb 15 2019, 17:08
markblundeberg closed T527: Add Schnorr support to OP_CHECKSIG and OP_CHECKDATASIG, a subtask of T526: Schnorr-ifying, as Resolved.
Feb 15 2019, 03:48
markblundeberg closed T527: Add Schnorr support to OP_CHECKSIG and OP_CHECKDATASIG as Resolved.
Feb 15 2019, 03:48
markblundeberg updated the diff for D2483: Schnorr signature activation.
  • add extra node for doing actual ban-checking (whitelist was stopping this)
  • include positive ban tests (for schnorr multisig)
  • get rid of update_block
Feb 15 2019, 03:01

Feb 14 2019

markblundeberg accepted D2542: Format BIP32 test cases manually.

Yeah that was hideous before ... linters aren't always right. :-D

Feb 14 2019, 17:34
markblundeberg added a comment to D2554: CONTRIBUTING.md : recommend ccache.

Not 100% sure about the placement of this, but I think it does deserve to go *somewhere*.

Feb 14 2019, 17:31
Herald added a reviewer for D2554: CONTRIBUTING.md : recommend ccache: deadalnix.
Feb 14 2019, 17:30
markblundeberg accepted D2547: Merge #12366: http: Join worker threads before deleting work queue.

A nice simplification and improvement. Presumably there is no chance that StopHTTPServer will be called during StartHTTPServer execution, as they are only ever called from a particular thread?

Feb 14 2019, 06:08
markblundeberg accepted D2545: qt: Poll ShutdownTimer after init is done.
Feb 14 2019, 05:30
markblundeberg updated the diff for D2548: fix abc-parkedchain timeouts.

use wait_for_tip instead of sync_blocks

Feb 14 2019, 05:21
markblundeberg updated the summary of D2548: fix abc-parkedchain timeouts.
Feb 14 2019, 04:25
markblundeberg added a comment to D2548: fix abc-parkedchain timeouts.

Check out the debug logs.

Feb 14 2019, 04:21
Herald added a reviewer for D2548: fix abc-parkedchain timeouts: deadalnix.
Feb 14 2019, 04:14
markblundeberg updated the test plan for D2483: Schnorr signature activation.
Feb 14 2019, 02:15
markblundeberg updated the diff for D2483: Schnorr signature activation.

various:

  • rebase on now-landed D2479 (+ address conflicts in overlap)
  • now fully mock-timed
  • added actual mininode testing of non-banning (borrowed from D2479)
  • added a reorg test at end, for good measure
  • nits
Feb 14 2019, 02:13
markblundeberg planned changes to D2483: Schnorr signature activation.
Feb 14 2019, 00:17

Feb 13 2019

markblundeberg updated subscribers of D2544: Improve shutdown process.

@dagurval points out, maybe we want to go straight for https://github.com/bitcoin/bitcoin/pull/14670 ... sounds like this exits uncleanly in some cases?

Feb 13 2019, 22:03
markblundeberg added inline comments to D2479: Add activation code for SEGWIT_RECOVERY.
Feb 13 2019, 21:57
markblundeberg updated the diff for D2479: Add activation code for SEGWIT_RECOVERY.

some tiny nits that @Fabien pointed out on D2483 / D2527

Feb 13 2019, 21:55
markblundeberg updated the diff for D2479: Add activation code for SEGWIT_RECOVERY.
  • fully mock test time
  • one more sendrawtransaction rejection test
  • misc changes
Feb 13 2019, 21:49
markblundeberg added inline comments to D2479: Add activation code for SEGWIT_RECOVERY.
Feb 13 2019, 17:45
markblundeberg added inline comments to D2483: Schnorr signature activation.
Feb 13 2019, 17:42
markblundeberg added inline comments to D2483: Schnorr signature activation.
Feb 13 2019, 17:42
markblundeberg added inline comments to D2483: Schnorr signature activation.
Feb 13 2019, 17:36
markblundeberg updated the diff for D2479: Add activation code for SEGWIT_RECOVERY.

rebase after D2527 landing

Feb 13 2019, 16:36
markblundeberg commandeered D2479: Add activation code for SEGWIT_RECOVERY.

commandeering this one for the home stretch

Feb 13 2019, 16:35
markblundeberg updated the diff for D2483: Schnorr signature activation.

rebase after D2527 landing

Feb 13 2019, 16:28
markblundeberg updated the diff for D2527: Improved mempool handling when changing validation rulesets.

last nit for % formatting

Feb 13 2019, 15:01
markblundeberg updated the diff for D2527: Improved mempool handling when changing validation rulesets.

address jason comments

Feb 13 2019, 00:32

Feb 12 2019

markblundeberg updated the diff for D2527: Improved mempool handling when changing validation rulesets.

address requests for change:

  • misc nits
  • logging messages altered
  • test now fully mock-timed
  • expanded comments about how transactions are tracked in invalidateblock and reorg events
Feb 12 2019, 20:14
markblundeberg commandeered D2527: Improved mempool handling when changing validation rulesets.

Gonna take control of this as florian will be away for the next few days, and this needs landing soon. Thanks for the hard work thus far @florian . :-D

Feb 12 2019, 17:54
markblundeberg updated subscribers of D2539: nits in abc-replay-protection.

@Fabien ping

Feb 12 2019, 16:08
Herald added a reviewer for D2539: nits in abc-replay-protection: deadalnix.
Feb 12 2019, 16:07
markblundeberg updated the diff for D2483: Schnorr signature activation.

fix nits that Fabien pointed out

Feb 12 2019, 15:18
markblundeberg added inline comments to D2527: Improved mempool handling when changing validation rulesets.
Feb 12 2019, 02:57