Page MenuHomePhabricator

markblundeberg (Mark B Lundeberg)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 23 2018, 01:26 (70 w, 5 d)

Recent Activity

Feb 15 2020

markblundeberg added inline comments to D3898: Use best-fit strategy in Arena, now O(log(n)) instead O(n).
Feb 15 2020, 11:35
markblundeberg added a task to D5297: fix ASAN error relating to nSigChecksBlockLimiter: T704: sigChecks implementation.
Feb 15 2020, 11:29
markblundeberg added a revision to T704: sigChecks implementation: D5297: fix ASAN error relating to nSigChecksBlockLimiter.
Feb 15 2020, 11:29
markblundeberg added a comment to D5297: fix ASAN error relating to nSigChecksBlockLimiter.

Longer explanation:

Feb 15 2020, 11:28
markblundeberg closed T744: Build Bitcoin-ABC / Master / Bitcoin-ABC Master ASAN is broken. as Resolved.

https://reviews.bitcoinabc.org/D5297

Feb 15 2020, 10:28
markblundeberg updated the summary of D5297: fix ASAN error relating to nSigChecksBlockLimiter.
Feb 15 2020, 10:11
markblundeberg retitled D5297: fix ASAN error relating to nSigChecksBlockLimiter from fix ASAN error to fix ASAN error relating to nSigChecksBlockLimiter.
Feb 15 2020, 10:06
markblundeberg created D5297: fix ASAN error relating to nSigChecksBlockLimiter.
Feb 15 2020, 10:03
markblundeberg updated the diff for D5253: Bump automatic replay protection to Nov 2020 upgrade.

(add depends on 0.21 update)

Feb 15 2020, 08:32

Feb 14 2020

markblundeberg accepted D5245: [qa]ย Test that mempool reverts to pre-phonon policies.

Yes this works because the mempool is being reprocessed now due to another upgrade, as the reversebytes thing D5130 (==D5283) is landed already. ๐Ÿ‘
(that's not bad btw, I rely on the same in my now-landed D5224 tests)

Feb 14 2020, 02:22
markblundeberg added a comment to D5244: Enable new ancestor/descendants chains limit at fork.

@dagurval this is the only way I know how to do these kinds of tests. We have never written tests that depend explicitly on --with-phononactivation and we avoid writing tests that directly invoke time(), so that would be pretty weird if you did that. In other words we write tests that are either testing activation-independent behaviour, or if they are sensitive then they must handle their own activation parameters and override any effect that --with-phononactivation might have, like you've done here.

Feb 14 2020, 01:41
markblundeberg removed a reviewer for D5282: Implement miner funding features: markblundeberg.
Feb 14 2020, 01:26
markblundeberg resigned from D5282: Implement miner funding features.

I won't block this as I'm not confident to effectively review its substance, but good to see the build failures are showing up now.

Feb 14 2020, 01:25

Feb 13 2020

markblundeberg added a comment to D5282: Implement miner funding features.

The builds are clean.

Feb 13 2020, 16:26
markblundeberg accepted D5284: [CMAKE] Use the new FindPython module.

All good!

Feb 13 2020, 13:51
markblundeberg added a comment to D5284: [CMAKE] Use the new FindPython module.

Thanks! I'm going to give this a whirl... (I was the one having pyenv issues ๐Ÿ˜Š )

Feb 13 2020, 13:31
markblundeberg updated the task description for T704: sigChecks implementation.
Feb 13 2020, 05:47
markblundeberg updated the task description for T704: sigChecks implementation.
Feb 13 2020, 05:46
markblundeberg updated the summary of D5224: [standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade.
Feb 13 2020, 05:45
markblundeberg updated the diff for D5224: [standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade.

just rebase

Feb 13 2020, 05:44
markblundeberg added a comment to D5282: Implement miner funding features.

Where is the spec for this? If there isn't any yet, one can be put under doc/abc/ . It's not clear what is the intended behaviour in simple language -- how does activation work, when does rule take effect, when does rule stop taking effect, etc etc.

Feb 13 2020, 05:18
markblundeberg added a comment to D5278: Revert "OP_REVERSEBYTES activation logic".

For the record in future (as this is going to happen again and again) the required change to fix this kind of thing is not hard, you just need to change the generate rpc to generatetoaddress rpc, see D5267.

Feb 13 2020, 03:51
markblundeberg updated the test plan for D5224: [standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade.
Feb 13 2020, 03:46
markblundeberg updated the diff for D5224: [standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade.

update test to work with nowallet build

Feb 13 2020, 03:46
markblundeberg updated the test plan for D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.
Feb 13 2020, 03:40
markblundeberg updated the diff for D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.

update func test to work with nowallet build

Feb 13 2020, 03:40
markblundeberg updated the test plan for D5029: deactivate sigops limits in phonon upgrade.
Feb 13 2020, 03:36
markblundeberg accepted D5283: OP_REVERSEBYTES activation logic.
Feb 13 2020, 03:33
markblundeberg updated the diff for D5029: deactivate sigops limits in phonon upgrade.

update functional test to work with nowallet build

Feb 13 2020, 03:33
markblundeberg added a comment to D5278: Revert "OP_REVERSEBYTES activation logic".

I am guessing this is due to D5184, and we are going to see this happen over and over until nowallet build is added to the Diff testing CI

Feb 13 2020, 03:17
markblundeberg requested changes to D5282: Implement miner funding features.

fix the build fail

Feb 13 2020, 02:32
markblundeberg added a comment to D5282: Implement miner funding features.

Teamcity is not able to post build failures here unless it's given permission (it's not part of Bitcoin ABC group) -- if you want that you have to add it to policy as a second entry.

Feb 13 2020, 02:16

Feb 12 2020

markblundeberg updated the diff for D5224: [standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade.

update after D5130 landing, now the mempool is reprocessed on upgrade so this has no dependencies.

Feb 12 2020, 15:14
markblundeberg updated the diff for D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.

simple rebase

Feb 12 2020, 04:16
markblundeberg updated the diff for D5029: deactivate sigops limits in phonon upgrade.

simple rebase

Feb 12 2020, 04:15
markblundeberg updated the diff for D5253: Bump automatic replay protection to Nov 2020 upgrade.

putting in a name : axion

Feb 12 2020, 03:58
markblundeberg added a comment to D5130: OP_REVERSEBYTES activation logic.

Good!

Feb 12 2020, 03:28
markblundeberg added a comment to D5253: Bump automatic replay protection to Nov 2020 upgrade.

Best runner so far: Axion

Feb 12 2020, 02:55
markblundeberg added a comment to D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.

I think I am going to leave off the virtualsize tests to a separate Diff, to keep this focussed on consensus behaviour. (It's not like we're introducing any new virtualsize behaviours, just changing what count is used)

Feb 12 2020, 01:02
markblundeberg retitled D5179: [consensus rule] limit sigchecks in a block after phonon upgrade from [WIP] [consensus rule] limit sigchecks in a block after phonon upgrade to [consensus rule] limit sigchecks in a block after phonon upgrade.
Feb 12 2020, 01:01

Feb 11 2020

markblundeberg accepted D5263: Prevent arc land from failing if there is nothing to lint.
Feb 11 2020, 14:32
markblundeberg updated the diff for D5262: Merge #13030: [bugfix] [wallet] Fix zapwallettxes/multiwallet interaction..

fixed parent

Feb 11 2020, 14:26
markblundeberg updated the diff for D5261: Merge #10816: Properly forbid -salvagewallet and -zapwallettxes for multi wallet..

minor text fix (will not change result after child)

Feb 11 2020, 14:24
markblundeberg added inline comments to D5257: RPCHelpMan fixups.
Feb 11 2020, 14:08
markblundeberg created D5262: Merge #13030: [bugfix] [wallet] Fix zapwallettxes/multiwallet interaction..
Feb 11 2020, 13:45
markblundeberg created D5261: Merge #10816: Properly forbid -salvagewallet and -zapwallettxes for multi wallet..
Feb 11 2020, 13:38
markblundeberg created D5260: Merge #10451: contrib/init/bitcoind.openrcconf: Don't disable wallet by default.
Feb 11 2020, 13:05
markblundeberg created D5259: rm cruft: travis-ci doc.
Feb 11 2020, 12:31
markblundeberg created D5258: rm cruft: contrib/rpm.
Feb 11 2020, 12:29
markblundeberg added a comment to D5239: Merge #14530: Use RPCHelpMan to generate RPC doc strings.

actually various wrong params -- moved to D5257

Feb 11 2020, 11:50
markblundeberg created D5257: RPCHelpMan fixups.
Feb 11 2020, 11:46
markblundeberg updated the diff for D5239: Merge #14530: Use RPCHelpMan to generate RPC doc strings.

braces; drop nonexistent param

Feb 11 2020, 11:45
markblundeberg updated the diff for D5251: Merge #17455: tests: Update valgrind suppressions.

update per nit

Feb 11 2020, 11:27
markblundeberg updated the diff for D5253: Bump automatic replay protection to Nov 2020 upgrade.

bump

Feb 11 2020, 11:14
markblundeberg added inline comments to D5239: Merge #14530: Use RPCHelpMan to generate RPC doc strings.
Feb 11 2020, 11:13
markblundeberg added inline comments to D5239: Merge #14530: Use RPCHelpMan to generate RPC doc strings.
Feb 11 2020, 11:12
markblundeberg created D5256: Merge #14398: tests: Don't access out of bounds array index: array[sizeof(array)].
Feb 11 2020, 11:05
markblundeberg planned changes to D5253: Bump automatic replay protection to Nov 2020 upgrade.
Feb 11 2020, 11:04
markblundeberg accepted D5255: Fix nits in RPC help messages.
Feb 11 2020, 11:03
markblundeberg updated the test plan for D5252: Merge #14822: bench: Destroy wallet txs instead of leaking their memory.
Feb 11 2020, 09:48
markblundeberg updated the summary of D5251: Merge #17455: tests: Update valgrind suppressions.
Feb 11 2020, 09:41
markblundeberg updated the diff for D5251: Merge #17455: tests: Update valgrind suppressions.

update comments with --child-silent-after-fork=yes

Feb 11 2020, 09:40
markblundeberg added a comment to D5214: Merge #13152: [rpc] Add getnodeaddresses RPC command.

Should be fixed now by D5254, please rebase.

Feb 11 2020, 09:33
markblundeberg updated the summary of D5251: Merge #17455: tests: Update valgrind suppressions.
Feb 11 2020, 09:33
markblundeberg updated the diff for D5251: Merge #17455: tests: Update valgrind suppressions.

update based on D5254

Feb 11 2020, 09:32
markblundeberg abandoned D5232: util_tests.test_LockDirectory: avoid exit in forked process.

see D5254

Feb 11 2020, 09:22
markblundeberg accepted D5254: Fix LockDirectory test failure when the Junit logger is enabled.
Feb 11 2020, 09:12
markblundeberg added a comment to D5214: Merge #13152: [rpc] Add getnodeaddresses RPC command.

Macro lolfail:

Feb 11 2020, 08:08
markblundeberg added a comment to D5214: Merge #13152: [rpc] Add getnodeaddresses RPC command.
Feb 11 2020, 07:58
markblundeberg updated the summary of D5252: Merge #14822: bench: Destroy wallet txs instead of leaking their memory.
Feb 11 2020, 07:40
markblundeberg updated the summary of D5252: Merge #14822: bench: Destroy wallet txs instead of leaking their memory.
Feb 11 2020, 07:40
markblundeberg updated the summary of D5253: Bump automatic replay protection to Nov 2020 upgrade.
Feb 11 2020, 07:38
markblundeberg added a comment to D5253: Bump automatic replay protection to Nov 2020 upgrade.

Opening this now to take suggestions on names. :-)

Feb 11 2020, 07:38
markblundeberg created D5253: Bump automatic replay protection to Nov 2020 upgrade.
Feb 11 2020, 07:37
markblundeberg updated the diff for D5238: Merge #15321: doc: Add cs_main lock annotations for mapBlockIndex.

update comment

Feb 11 2020, 07:16
markblundeberg added inline comments to D5238: Merge #15321: doc: Add cs_main lock annotations for mapBlockIndex.
Feb 11 2020, 07:15
markblundeberg added inline comments to D5232: util_tests.test_LockDirectory: avoid exit in forked process.
Feb 11 2020, 05:55
markblundeberg updated the test plan for D5252: Merge #14822: bench: Destroy wallet txs instead of leaking their memory.
Feb 11 2020, 05:42
markblundeberg added a comment to D5251: Merge #17455: tests: Update valgrind suppressions.

(the 5 remaining reachable leaked blocks are: 4 from leveldb, 1 from LogInstance)

Feb 11 2020, 05:25
markblundeberg created D5252: Merge #14822: bench: Destroy wallet txs instead of leaking their memory.
Feb 11 2020, 05:23
markblundeberg added a reviewer for D5251: Merge #17455: tests: Update valgrind suppressions: Fabien.
Feb 11 2020, 05:13
markblundeberg updated the test plan for D5251: Merge #17455: tests: Update valgrind suppressions.
Feb 11 2020, 05:13
markblundeberg updated the test plan for D5251: Merge #17455: tests: Update valgrind suppressions.
Feb 11 2020, 05:12
markblundeberg created D5251: Merge #17455: tests: Update valgrind suppressions.
Feb 11 2020, 05:11
markblundeberg updated the diff for D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.

update per comments; still todo: virtualsize test

Feb 11 2020, 03:24
markblundeberg added a comment to D5214: Merge #13152: [rpc] Add getnodeaddresses RPC command.

Snippet of first build failure:

[01:41:23]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_is_not_directory
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_is_not_relative
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_no_trailing
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_no_trailing2
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] psbt_wallet_tests.psbt_updater_test
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] psbt_wallet_tests.parse_hd_keypath
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.rescan
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.importwallet_rescan
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.coin_mark_dirty_immature_credit
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.ComputeTimeSmart
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.LoadReceiveRequests
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.ListCoins
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.wallet_disableprivkeys
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.write_erase_name
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.write_erase_purpose
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.write_erase_destdata
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.no_dest_fails
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_crypto_tests.passphrase
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_crypto_tests.encrypt
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_crypto_tests.decrypt
[01:42:52] :	 [Step 1/1] Running 454 test cases...
[01:42:52] :	 [Step 1/1] 
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:58]W:	 [Step 1/1] corrupted double-linked list
[01:42:58] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365../src/test/util_tests.cpp(1368):  [1;31;49merror: in "util_tests/test_LockDirectory": check processstatus == 0 has failed [11 != 0] [0;39;49m
[01:43:04]W:	 [Step 1/1] 
[01:43:04]W:	 [Step 1/1]  [1;31;49m*** 1 failure is detected in the test module "Bitcoin ABC unit tests with next upgrade activated"
[01:43:04]W:	 [Step 1/1]  [0;39;49m
[01:43:04]W:	 [Step 1/1] Process exited with code 201
[01:43:04]E:	 [Step 1/1] Process exited with code 201 (Step: Command Line)

Each failure log is accessible here:
Bitcoin_ABC_unit_tests_with_next_upgrade_activated: util_tests.test_LockDirectory

Feb 11 2020, 02:18
markblundeberg added inline comments to D5244: Enable new ancestor/descendants chains limit at fork.
Feb 11 2020, 00:14

Feb 10 2020

markblundeberg added inline comments to D5232: util_tests.test_LockDirectory: avoid exit in forked process.
Feb 10 2020, 14:56
markblundeberg updated the diff for D5239: Merge #14530: Use RPCHelpMan to generate RPC doc strings.

fix //!< comments to be in front

Feb 10 2020, 14:51
markblundeberg added a comment to D5239: Merge #14530: Use RPCHelpMan to generate RPC doc strings.

a few examples of the changes:

Feb 10 2020, 14:46
markblundeberg added inline comments to D5239: Merge #14530: Use RPCHelpMan to generate RPC doc strings.
Feb 10 2020, 14:42
markblundeberg created D5239: Merge #14530: Use RPCHelpMan to generate RPC doc strings.
Feb 10 2020, 14:40
markblundeberg updated the summary of D5237: [avalanche_tests] fix block index accesses.
Feb 10 2020, 12:46
markblundeberg created D5238: Merge #15321: doc: Add cs_main lock annotations for mapBlockIndex.
Feb 10 2020, 12:45
markblundeberg created D5237: [avalanche_tests] fix block index accesses.
Feb 10 2020, 12:36
markblundeberg abandoned D5231: [just testing] dump core file in build-master.
Feb 10 2020, 10:25
markblundeberg added inline comments to D5236: remove SCRIPT_VERIFY_COMPRESSED_PUBKEYTYPE (aka WITNESS_PUBKEYTYPE).
Feb 10 2020, 02:56
markblundeberg updated the diff for D5236: remove SCRIPT_VERIFY_COMPRESSED_PUBKEYTYPE (aka WITNESS_PUBKEYTYPE).

better IsMine comment

Feb 10 2020, 02:53
markblundeberg created D5236: remove SCRIPT_VERIFY_COMPRESSED_PUBKEYTYPE (aka WITNESS_PUBKEYTYPE).
Feb 10 2020, 02:48
markblundeberg created D5235: Merge #15203: Fix issue #9683 "gui, wallet: random abort (segmentation fault).
Feb 10 2020, 02:00