Page MenuHomePhabricator

markblundeberg (Mark B Lundeberg)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 23 2018, 01:26 (29 w, 2 d)

Recent Activity

Today

markblundeberg added a comment to D3253: Remove Schnorr activation.

IBD testing done

Sun, Jun 16, 00:57
markblundeberg updated the test plan for D3253: Remove Schnorr activation.
Sun, Jun 16, 00:57
markblundeberg added a comment to D3253: Remove Schnorr activation.

update per my last comment; we can't properly test 64 byte ECDSA here,
but we can test the multisig length check banning.

Sun, Jun 16, 00:53

Yesterday

markblundeberg added a comment to D3076: Merge #14409: utils and libraries: Make 'blocksdir' always net specific.

rebase pre-land

Sat, Jun 15, 19:23
markblundeberg added a comment to D3312: create net-specific data directory early in init process.

Discussions with @Fabien make it clear that this is pretty ugly behaviour, and I've forwarded this problem to Core to see if they have some solutions in mind. https://github.com/bitcoin/bitcoin/issues/16220

Sat, Jun 15, 18:16
markblundeberg added a comment to D3312: create net-specific data directory early in init process.

add TODO comments to aid in clean backporting one day (when Core figures out
how they want to fix this)

Sat, Jun 15, 18:13
markblundeberg added inline comments to D1438: Add a NUM2BIN test with a 5 byte operand.
Sat, Jun 15, 02:41
markblundeberg added inline comments to D3253: Remove Schnorr activation.
Sat, Jun 15, 01:52
markblundeberg added a comment to D3253: Remove Schnorr activation.

keep functional test same name to allow diff to show properly

Sat, Jun 15, 01:50
markblundeberg added inline comments to D3332: remove SCRIPT_ENABLE_SCHNORR flag and clean up tests.
Sat, Jun 15, 00:34
markblundeberg added inline comments to D3253: Remove Schnorr activation.
Sat, Jun 15, 00:32
markblundeberg added a comment to D3347: [script_tests] improve coverage of minimal number encoding.

(Also I find it a bit odd that we have a known error that triggers UNKNOWN_ERROR (this is because it works by throwing an exception instead of doing the usual s_error mechanism). Would be good to make it clearer, but that can be a separate diff.)

Sat, Jun 15, 00:31
markblundeberg created D3347: [script_tests] improve coverage of minimal number encoding.
Sat, Jun 15, 00:28

Fri, Jun 14

markblundeberg added a comment to D3310: Merge #14085: index: Fix for indexers skipping genesis block..

rebase for good measure

Fri, Jun 14, 18:28
markblundeberg added a comment to D3329: [txindex] transaction Hash -> TxId.

rebase for conflict

Fri, Jun 14, 17:41
markblundeberg updated the task description for T653: Clean up past upgrades.
Fri, Jun 14, 16:33
markblundeberg updated the test plan for D3253: Remove Schnorr activation.
Fri, Jun 14, 16:30
markblundeberg added a comment to D3253: Remove Schnorr activation.

(Note that the functional test is identical to the prior version of this diff.)

Fri, Jun 14, 04:53
markblundeberg retitled D3332: remove SCRIPT_ENABLE_SCHNORR flag and clean up tests from remove Schnorr flag and clean up tests to remove SCRIPT_ENABLE_SCHNORR flag and clean up tests.
Fri, Jun 14, 04:51
markblundeberg updated the summary of D3265: add new encoding checker for Schnorr sigs.
Fri, Jun 14, 04:51
markblundeberg added a comment to D3255: Remove unused great wall activation code.

rebase onto split parent

Fri, Jun 14, 04:49
markblundeberg updated the summary of D3254: Revert "add flags to VerifySignature and sigcache".

rebased onto split parent

Fri, Jun 14, 04:47
markblundeberg updated the summary of D3264: sigencoding_tests: improve test coverage.

rebased onto split-up schnorr removal diffs

Fri, Jun 14, 04:35
markblundeberg added a comment to D3253: Remove Schnorr activation.

Now split out into D3331 and then D3332 (result after D3332 is identical).

Fri, Jun 14, 04:26
markblundeberg added a revision to T653: Clean up past upgrades: D3332: remove SCRIPT_ENABLE_SCHNORR flag and clean up tests.
Fri, Jun 14, 04:26
markblundeberg added a task to D3332: remove SCRIPT_ENABLE_SCHNORR flag and clean up tests: T653: Clean up past upgrades.
Fri, Jun 14, 04:26
markblundeberg created D3332: remove SCRIPT_ENABLE_SCHNORR flag and clean up tests.
Fri, Jun 14, 04:25
markblundeberg added a revision to T653: Clean up past upgrades: D3331: remove effect of SCRIPT_ENABLE_SCHNORR flag.
Fri, Jun 14, 04:23
markblundeberg added a task to D3331: remove effect of SCRIPT_ENABLE_SCHNORR flag: T653: Clean up past upgrades.
Fri, Jun 14, 04:23
markblundeberg planned changes to D3264: sigencoding_tests: improve test coverage.
Fri, Jun 14, 04:18
markblundeberg created D3331: remove effect of SCRIPT_ENABLE_SCHNORR flag.
Fri, Jun 14, 04:13
markblundeberg updated the summary of D3253: Remove Schnorr activation.

rework into first of multiple parts

Fri, Jun 14, 03:14
markblundeberg added a comment to D3329: [txindex] transaction Hash -> TxId.

missed a few spots!

Fri, Jun 14, 01:57

Thu, Jun 13

markblundeberg added a comment to D3310: Merge #14085: index: Fix for indexers skipping genesis block..

use GetId

Thu, Jun 13, 23:40
markblundeberg added inline comments to D3310: Merge #14085: index: Fix for indexers skipping genesis block..
Thu, Jun 13, 23:40
markblundeberg created D3329: [txindex] transaction Hash -> TxId.
Thu, Jun 13, 23:34
markblundeberg planned changes to D3269: move CheckMinimalPush to script.h.
Thu, Jun 13, 22:31
markblundeberg planned changes to D3270: add CScript::IsMinimalPushOnly.
Thu, Jun 13, 22:31
markblundeberg planned changes to D3271: add SCRIPTSIGMINPUSHONLY flag and logic.
Thu, Jun 13, 22:31
markblundeberg added a comment to D3308: Merge #9894: remove 'label' filter for rpc command help.

What I recall is that the new label commands that get added are sorted in correctly, and it's the existing label entries that are wrong. So we do want this Diff, and indeed some old code isn't cleaned up right.

Thu, Jun 13, 22:04
markblundeberg added inline comments to D3323: Add missing release notes for 0.19.8 release.
Thu, Jun 13, 20:16
markblundeberg accepted D3321: Updated chainparams for 0.19.8 release.
Thu, Jun 13, 17:45
markblundeberg added a comment to D3321: Updated chainparams for 0.19.8 release.

Confirm (note: at this time the mainnet block is 9 confs old).

Thu, Jun 13, 17:45
markblundeberg added a comment to D3310: Merge #14085: index: Fix for indexers skipping genesis block..

address comments

Thu, Jun 13, 14:22
markblundeberg added inline comments to D3076: Merge #14409: utils and libraries: Make 'blocksdir' always net specific.
Thu, Jun 13, 14:06
markblundeberg added a comment to D3076: Merge #14409: utils and libraries: Make 'blocksdir' always net specific.

take out accidental backported line

Thu, Jun 13, 14:04
markblundeberg updated the summary of D3076: Merge #14409: utils and libraries: Make 'blocksdir' always net specific.

finally found the bug that was making tests fail! (D3312)

Thu, Jun 13, 05:46
markblundeberg created D3312: create net-specific data directory early in init process.
Thu, Jun 13, 05:44
markblundeberg added inline comments to D3273: qa: Normalize executable location.
Thu, Jun 13, 03:53
markblundeberg created D3311: fix `test_runner.py --help`.
Thu, Jun 13, 03:52
markblundeberg added a revision to T630: Backport PR 13243 "Make reusable base class for auxiliary indices": D3310: Merge #14085: index: Fix for indexers skipping genesis block..
Thu, Jun 13, 02:08
markblundeberg added a task to D3310: Merge #14085: index: Fix for indexers skipping genesis block.: T630: Backport PR 13243 "Make reusable base class for auxiliary indices".
Thu, Jun 13, 02:08
markblundeberg created D3310: Merge #14085: index: Fix for indexers skipping genesis block..
Thu, Jun 13, 02:07
markblundeberg added a comment to D2788: Remove unknown version warning from UpdateTip.

This should in principle work on master now, once rebased...

Thu, Jun 13, 01:43
markblundeberg added a comment to D3308: Merge #9894: remove 'label' filter for rpc command help.

I tried backporting this one and I noticed that it produced duplicate entries for commands with "label" in the name, and I couldn't figure out why.... Is that still the case now? Can "examine bitcoin-cli help" be added to test plan?

Thu, Jun 13, 01:17
markblundeberg added a comment to D3181: Merge #15471: rpc/gui: Remove 'Unknown block versions being mined' warning.

rebase for freshness

Thu, Jun 13, 01:15

Wed, Jun 12

markblundeberg requested review of D3271: add SCRIPTSIGMINPUSHONLY flag and logic.
Wed, Jun 12, 14:52
markblundeberg added a comment to D3270: add CScript::IsMinimalPushOnly.

There is already logic to check if a push is minimal or not, duplicating indicate the approach is wrong.

Wed, Jun 12, 00:08

Tue, Jun 11

markblundeberg accepted D3279: Merge #9350: [Trivial] Adding label for amount inside of tx_valid/tx_invalid.json.
Tue, Jun 11, 13:18
markblundeberg planned changes to D3076: Merge #14409: utils and libraries: Make 'blocksdir' always net specific.
Tue, Jun 11, 00:25
markblundeberg added a comment to D3076: Merge #14409: utils and libraries: Make 'blocksdir' always net specific.

still awful

Tue, Jun 11, 00:25

Mon, Jun 10

markblundeberg added a comment to D3279: Merge #9350: [Trivial] Adding label for amount inside of tx_valid/tx_invalid.json.

Hmm looks like transaction_tests.cpp (e.g., BOOST_AUTO_TEST_CASE(tx_invalid) comment) needs to be updated as well.

Mon, Jun 10, 21:12
markblundeberg updated the task description for T667: add rule for **minimal** push only in scriptSig.
Mon, Jun 10, 17:59
markblundeberg updated the task description for T667: add rule for **minimal** push only in scriptSig.
Mon, Jun 10, 17:56
markblundeberg updated the task description for T667: add rule for **minimal** push only in scriptSig.
Mon, Jun 10, 17:56
markblundeberg updated the summary of D3271: add SCRIPTSIGMINPUSHONLY flag and logic.
Mon, Jun 10, 17:55
markblundeberg updated the summary of D3268: Increase test coverage on CScript.IsPushOnly().
Mon, Jun 10, 17:54
markblundeberg updated the task description for T667: add rule for **minimal** push only in scriptSig.
Mon, Jun 10, 17:52
markblundeberg updated the task description for T667: add rule for **minimal** push only in scriptSig.
Mon, Jun 10, 17:52
markblundeberg requested review of D3269: move CheckMinimalPush to script.h.
Mon, Jun 10, 17:50
markblundeberg updated the task description for T667: add rule for **minimal** push only in scriptSig.
Mon, Jun 10, 17:50
markblundeberg requested review of D3270: add CScript::IsMinimalPushOnly.
Mon, Jun 10, 17:49
markblundeberg added a comment to D3270: add CScript::IsMinimalPushOnly.

Needs a summary. What's the goal here?

Mon, Jun 10, 17:49
markblundeberg updated the summary of D3270: add CScript::IsMinimalPushOnly.
Mon, Jun 10, 17:48
markblundeberg updated the summary of D3269: move CheckMinimalPush to script.h.
Mon, Jun 10, 17:48
markblundeberg updated the task description for T667: add rule for **minimal** push only in scriptSig.
Mon, Jun 10, 17:47
markblundeberg added inline comments to D3271: add SCRIPTSIGMINPUSHONLY flag and logic.
Mon, Jun 10, 03:35
markblundeberg added a comment to D3253: Remove Schnorr activation.

remove newline from timing.json

Mon, Jun 10, 00:02

Sun, Jun 9

markblundeberg added a comment to D3253: Remove Schnorr activation.

rebase for D3262 & tweak accordingly

Sun, Jun 9, 23:55
markblundeberg added a comment to D3262: Add script tests with valid 64-byte ECDSA signatures..

update comment per suggestion

Sun, Jun 9, 22:33
markblundeberg added a comment to D3263: add CScriptNum operator>>=.

Probably going to abandon this. The motivation was to avoid using int for a bitfield as it has implementation-defined length, but I think I will just use use asserts / tests to get rid of weird platforms.

Sun, Jun 9, 17:13
markblundeberg added a comment to D3265: add new encoding checker for Schnorr sigs.

update per comments

Sun, Jun 9, 14:45
markblundeberg updated the summary of D3271: add SCRIPTSIGMINPUSHONLY flag and logic.
Sun, Jun 9, 12:37
markblundeberg requested review of D3262: Add script tests with valid 64-byte ECDSA signatures..
Sun, Jun 9, 05:59
markblundeberg added a revision to T667: add rule for **minimal** push only in scriptSig: D3271: add SCRIPTSIGMINPUSHONLY flag and logic.
Sun, Jun 9, 05:51
markblundeberg added a task to D3271: add SCRIPTSIGMINPUSHONLY flag and logic: T667: add rule for **minimal** push only in scriptSig.
Sun, Jun 9, 05:51
markblundeberg created D3271: add SCRIPTSIGMINPUSHONLY flag and logic.
Sun, Jun 9, 05:49
markblundeberg added a comment to D3270: add CScript::IsMinimalPushOnly.

rebuild

Sun, Jun 9, 05:27
markblundeberg added a comment to D3270: add CScript::IsMinimalPushOnly.
Sun, Jun 9, 03:18
markblundeberg added a comment to D3262: Add script tests with valid 64-byte ECDSA signatures..

tweak names; add multisig test too

Sun, Jun 9, 03:11
markblundeberg added a task to D3270: add CScript::IsMinimalPushOnly: T667: add rule for **minimal** push only in scriptSig.
Sun, Jun 9, 02:30
markblundeberg added a revision to T667: add rule for **minimal** push only in scriptSig: D3270: add CScript::IsMinimalPushOnly.
Sun, Jun 9, 02:30
markblundeberg added a revision to T667: add rule for **minimal** push only in scriptSig: D3269: move CheckMinimalPush to script.h.
Sun, Jun 9, 02:30
markblundeberg added a task to D3269: move CheckMinimalPush to script.h: T667: add rule for **minimal** push only in scriptSig.
Sun, Jun 9, 02:30
markblundeberg added a revision to T667: add rule for **minimal** push only in scriptSig: D3268: Increase test coverage on CScript.IsPushOnly().
Sun, Jun 9, 02:30
markblundeberg added a task to D3268: Increase test coverage on CScript.IsPushOnly(): T667: add rule for **minimal** push only in scriptSig.
Sun, Jun 9, 02:30
markblundeberg created D3270: add CScript::IsMinimalPushOnly.
Sun, Jun 9, 02:28
markblundeberg created D3269: move CheckMinimalPush to script.h.
Sun, Jun 9, 02:27
markblundeberg created D3268: Increase test coverage on CScript.IsPushOnly().
Sun, Jun 9, 02:27
markblundeberg added inline comments to D3267: check negative CScriptNum.getint() and introduce new error code.
Sun, Jun 9, 00:23