- User Since
- Nov 23 2018, 01:26 (54 w, 18 h)
This seems to just remove functionality and Core only did this because they have problems telling apart segwit txns from partially constructed non-segwit transactions (see discussion on PR). This isn't a crutch that we need to be copying.
Tue, Dec 3
rm assert & update comment
rebase to master and tweak a few comments
a number of updates
- added a couple of behaviours that are nonstandard to fund but the wallet
will pick up, and will spend successfully.
- rename test, the general idea is to make sure wallet is not DoSable.
Mon, Dec 2
Ah OK it is documented here at least https://pubs.opengroup.org/onlinepubs/009695399/basedefs/sys/select.h.html
Sun, Dec 1
Fri, Nov 29
remove spurious newline and request teamcity rerun
Thu, Nov 28
- add SCHNORR_MULTISIG to mandatory flags
- remove NULLDUMMY completely from codebase
Thu, Nov 21
I find it amusing that there didn't need to be a main() before :D
Wed, Nov 20
Sun, Nov 17
Fri, Nov 15
Sep 25 2019
rebase & revive
Aug 18 2019
Going to pull this off review queue for now, since the intent is to delay landing this until some time later.
Aug 17 2019
oh goody, I was looking forward to this one :)
Would have been good to have a release note for this, I just chatted with one person who was confused their regtest setup mysteriously stopped working upon upgrade.
Aug 15 2019
ok, still feels weird to me to have chainwork not match the assumevalid block though
rebase for landed parent
add nonnegative check per Fabien's suggestion
update per comments
Aug 14 2019
resubmit from arc (with lint changes)
This is a variant of D3818 that tests all the forms, and does some extra testing on each one.
rebase; increase test coverage and add comments.
updated to use CheckMinimalPush
Aug 13 2019
arc update to make it follow standard procedure
Aug 12 2019
oops! that was me :)
Aug 9 2019
just noticed this bug on testnet in my -debug=net logfile
Just to follow up, this did indeed break my testnet node's ability to sync to the fork testnet. I had to put minimumchainwork=0 in the bitcoin.conf so it would stop disconnecting imaginary_username's node with reason "Disconnecting outbound peer 51 -- headers chain has insufficient work"
rebase for conflict (standard.cpp in D3807)
Aug 6 2019
rebase for landed parent
move comments up a line
Aug 5 2019
Aug 4 2019
Note -- it only supports up to 20 pubkeys like regular multisig, rather this static assert is only here since the implementation's usage of a 32-bit number (and >> operator) is implicitly assuming < 32 keys.
Aug 1 2019
Jul 30 2019
Jul 29 2019
Hmm, I don't get why there is the 'should' / 'must' distinction here, but yeah 👍 I wondered why it had been written that way.
rebase onto the updated parent