Page MenuHomePhabricator

markblundeberg (Mark B Lundeberg)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 23 2018, 01:26 (60 w, 3 d)

Recent Activity

Today

markblundeberg requested review of D4940: add a flag that (if unset) zeroes sigchecks reported by VerifyScript.

@deadalnix returning for review due to slight changes. Note after our discussion that ScriptExecutionMetrics will remain a pure struct (as it is in this diff) since accumulation etc will happen elsewhere.

Mon, Jan 20, 06:15
markblundeberg updated the diff for D4940: add a flag that (if unset) zeroes sigchecks reported by VerifyScript.

remove dependency on D4834

Mon, Jan 20, 06:13
markblundeberg added inline comments to D4903: Use virtualsize for mining/mempool priority.
Mon, Jan 20, 05:46
markblundeberg added inline comments to D4903: Use virtualsize for mining/mempool priority.
Mon, Jan 20, 04:49
markblundeberg requested review of D5019: CreateNewBlock: insert entries into block slightly earlier so that correct size is logged.
Mon, Jan 20, 04:16
markblundeberg added inline comments to D5027: always unpark even when -parkdeepreorg=0.
Mon, Jan 20, 04:13
markblundeberg planned changes to D5027: always unpark even when -parkdeepreorg=0.
Mon, Jan 20, 04:09
markblundeberg added inline comments to D5027: always unpark even when -parkdeepreorg=0.
Mon, Jan 20, 04:08
markblundeberg added a reviewer for D5027: always unpark even when -parkdeepreorg=0: Fabien.
Mon, Jan 20, 04:08
markblundeberg created D5027: always unpark even when -parkdeepreorg=0.
Mon, Jan 20, 04:07
markblundeberg added inline comments to D4903: Use virtualsize for mining/mempool priority.
Mon, Jan 20, 00:03

Yesterday

markblundeberg retitled D5019: CreateNewBlock: insert entries into block slightly earlier so that correct size is logged from CreateNewBlock: insert entries into block slightly earlier to CreateNewBlock: insert entries into block slightly earlier so that correct size is logged.
Sun, Jan 19, 05:57
markblundeberg created D5022: CreateNewBlock: small tweaks.
Sun, Jan 19, 05:55
markblundeberg updated the diff for D5019: CreateNewBlock: insert entries into block slightly earlier so that correct size is logged.

simplify changes to smallest possible (move-only on the for loop, and an extra update)

Sun, Jan 19, 04:42
markblundeberg added inline comments to D5019: CreateNewBlock: insert entries into block slightly earlier so that correct size is logged.
Sun, Jan 19, 04:37
markblundeberg added a comment to D5019: CreateNewBlock: insert entries into block slightly earlier so that correct size is logged.

(For reference, this mechanism was introduced in D2047 which was basically a good fix.)

Sun, Jan 19, 03:35
markblundeberg updated the diff for D5018: add input sigchecks limit to STANDARD_SCRIPT_VERIFY_FLAGS (but not mempool flags).

rebase

Sun, Jan 19, 02:18
markblundeberg updated the diff for D5017: [abc-wallet-standardness] do test the signing error code.

rebase

Sun, Jan 19, 02:17
markblundeberg planned changes to D5013: CheckBlockIndex before unlocking cs_main.
Sun, Jan 19, 02:15
markblundeberg added inline comments to D4834: add sigChecks value to script cache.
Sun, Jan 19, 00:43

Sat, Jan 18

markblundeberg added inline comments to D5019: CreateNewBlock: insert entries into block slightly earlier so that correct size is logged.
Sat, Jan 18, 17:17
markblundeberg created D5019: CreateNewBlock: insert entries into block slightly earlier so that correct size is logged.
Sat, Jan 18, 17:12
markblundeberg added a comment to D4903: Use virtualsize for mining/mempool priority.

A note for curiosity: I tried to make the same kind of test using fundrawtransaction / signrawtransactionwithwallet RPC, however it took about 100 ms per tx. So with 500 txes, that made a 50 second long test, yuck! This test runs in 2 seconds.

Sat, Jan 18, 16:31
markblundeberg updated the diff for D4917: more optimal virtualsize accounting with increments.

simplify API ; rebase

Sat, Jan 18, 16:29
markblundeberg added inline comments to D4917: more optimal virtualsize accounting with increments.
Sat, Jan 18, 16:26
markblundeberg updated the diff for D4903: Use virtualsize for mining/mempool priority.

add test

Sat, Jan 18, 16:24
markblundeberg created D5018: add input sigchecks limit to STANDARD_SCRIPT_VERIFY_FLAGS (but not mempool flags).
Sat, Jan 18, 12:15
markblundeberg created D5017: [abc-wallet-standardness] do test the signing error code.
Sat, Jan 18, 11:26
markblundeberg added inline comments to D5015: simplify ATMP standard flag computation [2/2] - move computation to another function.
Sat, Jan 18, 11:24
markblundeberg created D5016: fix a test in anticipation of SCRIPT_VERIFY_INPUT_SIGCHECKS activation.
Sat, Jan 18, 11:13
markblundeberg created D5015: simplify ATMP standard flag computation [2/2] - move computation to another function.
Sat, Jan 18, 11:04
markblundeberg created D5014: simplify ATMP standard flag computation [1/2] - remove CHECKDATASIG_SIGOPS.
Sat, Jan 18, 11:02
markblundeberg abandoned D4897: Add virtualsize tracking to mempool.
Sat, Jan 18, 04:50
markblundeberg updated the diff for D4834: add sigChecks value to script cache.

rebase ; comments ; tweak to not use uint256

Sat, Jan 18, 04:49
markblundeberg added inline comments to D4834: add sigChecks value to script cache.
Sat, Jan 18, 04:48
markblundeberg abandoned D4716: do not accept anything into mempool before UAHF has activated.

Fabien added some comments to this effect in D4642.

Sat, Jan 18, 04:38
markblundeberg abandoned D4902: change default -blockmintxfee to 0.

Going to drop this from my queue for now, but I still think it's worth considering in future.

Sat, Jan 18, 04:37
markblundeberg added inline comments to D5013: CheckBlockIndex before unlocking cs_main.
Sat, Jan 18, 04:33
markblundeberg requested review of D4941: track ScriptExecutionMetrics in CheckInputs.
Sat, Jan 18, 04:05
markblundeberg added a comment to D5013: CheckBlockIndex before unlocking cs_main.

The remaining inconsistencies are probably related to this fix:

Sat, Jan 18, 03:43
markblundeberg requested changes to D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.
Sat, Jan 18, 03:32
markblundeberg added a comment to D5013: CheckBlockIndex before unlocking cs_main.

OK, just a few failures remaining now, so it's better with that parent but something still wrong...

Sat, Jan 18, 03:26
markblundeberg updated the summary of D5013: CheckBlockIndex before unlocking cs_main.
Sat, Jan 18, 03:23
markblundeberg updated the diff for D5013: CheckBlockIndex before unlocking cs_main.

rebase onto D4929

Sat, Jan 18, 03:22
markblundeberg added a comment to D5013: CheckBlockIndex before unlocking cs_main.

Above failures on master, now will try rebased.

Sat, Jan 18, 03:12
markblundeberg updated the summary of D5013: CheckBlockIndex before unlocking cs_main.
Sat, Jan 18, 03:06
markblundeberg created D5013: CheckBlockIndex before unlocking cs_main.
Sat, Jan 18, 03:06
markblundeberg added a comment to D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.

From what I can tell, this change is actually a bugfix and should have really been combined with D4802. Please get this landed soon.

Sat, Jan 18, 02:47

Thu, Jan 16

markblundeberg added inline comments to D4941: track ScriptExecutionMetrics in CheckInputs.
Thu, Jan 16, 07:53
markblundeberg added a comment to D4950: Fully revert D4803 due to TSAN test failures.

Hmm weird that build failures happen with this patch, it smells like one of the prior diffs (which all got landed sort of at once) may actually be responsible. Safest option might be to revert all.

Thu, Jan 16, 07:15
markblundeberg accepted D4871: Added OP_ENDIAN_REVERSE+implementation, added (always disabled) activation flag, added tests for OP_ENDIAN_REVERSE..

Tiny quibble but otherwise good.

Thu, Jan 16, 07:12
markblundeberg added a comment to D4757: Call RewindBlockIndex without cs_main held.

For some reason my name appears as the Author for the commit, any idea why that happened?

Thu, Jan 16, 04:40
markblundeberg added inline comments to D4834: add sigChecks value to script cache.
Thu, Jan 16, 01:24
markblundeberg added inline comments to D4834: add sigChecks value to script cache.
Thu, Jan 16, 01:19
markblundeberg added inline comments to D4834: add sigChecks value to script cache.
Thu, Jan 16, 01:14
markblundeberg added inline comments to D4834: add sigChecks value to script cache.
Thu, Jan 16, 01:13

Wed, Jan 15

markblundeberg added a comment to D4903: Use virtualsize for mining/mempool priority.

There is another side-effect here, which is that bumping GetMinFee can technically bring sigops (and virtualsize) into play for wallet estimation. To accurately capture this would really suck, since we would need to communicate two fee rates (one for min relay fee in sat/byte, and one for the mempool rolling fee floor in sat/vbyte).

Wed, Jan 15, 07:44

Tue, Jan 14

markblundeberg added inline comments to D4942: Call FinalizeBlockAndInvalidate without cs_main held.
Tue, Jan 14, 21:31
markblundeberg added a comment to D4939: Move the functional test temporary directory under the build directory.

Seems OK I guess, we'll just have to remember to nuke test/tmp on our local builds occasionally as it fills up with test failures.

Tue, Jan 14, 21:23
markblundeberg added a comment to D4871: Added OP_ENDIAN_REVERSE+implementation, added (always disabled) activation flag, added tests for OP_ENDIAN_REVERSE..
Build Bitcoin-ABC / Diffs / Diff Testing failed. Snippet of first build failure: ` [17:32:02]W: [Step 1/1] + case "$ABC_BUILD_NAME" in [17:32:02] : [Step 1/1] Error: Invalid build name 'build-diff' [17:32:02]W: [Step 1/1] + echo 'Error: Invalid build name '\''build-diff'\''' [17:32:02]W: [Step 1/1] + exit 2 [17:32:02]W: [Step 1/1] Process exited with code 2 [17:32:02]E: [Step 1/1] Process exited with code 2 (Step: Command Line) `

This seems like a configuration error. Does someone know what‘s going on there?

Tue, Jan 14, 20:17
markblundeberg created D4941: track ScriptExecutionMetrics in CheckInputs.
Tue, Jan 14, 15:05
markblundeberg added inline comments to D4937: tweak auto-unparking message.
Tue, Jan 14, 13:36
markblundeberg added a revision to T704: sigChecks implementation: D4940: add a flag that (if unset) zeroes sigchecks reported by VerifyScript.
Tue, Jan 14, 12:35
markblundeberg added a task to D4940: add a flag that (if unset) zeroes sigchecks reported by VerifyScript: T704: sigChecks implementation.
Tue, Jan 14, 12:35
markblundeberg created D4940: add a flag that (if unset) zeroes sigchecks reported by VerifyScript.
Tue, Jan 14, 12:34
markblundeberg added a revision to T704: sigChecks implementation: D4920: save ScriptExecutionMetrics during CScriptCheck.
Tue, Jan 14, 09:50
markblundeberg added a task to D4920: save ScriptExecutionMetrics during CScriptCheck: T704: sigChecks implementation.
Tue, Jan 14, 09:50
markblundeberg created D4937: tweak auto-unparking message.
Tue, Jan 14, 08:53
markblundeberg updated the diff for D4834: add sigChecks value to script cache.

big overhaul to use ScriptExecutionMetrics

Tue, Jan 14, 08:34
markblundeberg updated the diff for D4935: [validation.cpp] parking-related comment tweaks.

add another comment

Tue, Jan 14, 04:41
markblundeberg created D4935: [validation.cpp] parking-related comment tweaks.
Tue, Jan 14, 04:40
markblundeberg added a comment to D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.

This clearly includes a lot of code that isn't in the original PR. Where does the clocking mechanism changes come from?

The new code is related to @markblundeberg and your comments in D4758: InvalidateBlock now requires that cs_main be unlocked.
Also: abc-finalize-block is broken here if I don't make the changes. (Not broken in previous Diffs).
I could move the related code to D4758 (I didn't do it because it had already been approved) or to a new Diff.

Tue, Jan 14, 00:32

Mon, Jan 13

markblundeberg accepted D4900: parameterize ecmult_const over input size.

Never mind, I was wrong -- Core does have these changes.

Mon, Jan 13, 23:16
markblundeberg added a revision to T704: sigChecks implementation: D4918: move ScriptExecutionMetrics to its own file.
Mon, Jan 13, 15:09
markblundeberg added a task to D4918: move ScriptExecutionMetrics to its own file: T704: sigChecks implementation.
Mon, Jan 13, 15:09
markblundeberg created D4926: move MANDATORY_SCRIPT_VERIFY_FLAGS to policy.h.
Mon, Jan 13, 14:32
markblundeberg added a comment to D4900: parameterize ecmult_const over input size.

Out of curiosity, why are we backporting these when Core doesn't have them in their master?

Mon, Jan 13, 14:13
markblundeberg created D4923: [tests] remove test_bitcoin.h dependency on txmempool.h.
Mon, Jan 13, 14:01
markblundeberg updated the test plan for D4918: move ScriptExecutionMetrics to its own file.
Mon, Jan 13, 13:00
markblundeberg added a comment to D4920: save ScriptExecutionMetrics during CScriptCheck.

Note: As far as closures go, CScriptCheck is slightly weird because it saves (some of) the results into the closure, rather than returning them.

Mon, Jan 13, 12:52
markblundeberg created D4920: save ScriptExecutionMetrics during CScriptCheck.
Mon, Jan 13, 12:44
markblundeberg created D4918: move ScriptExecutionMetrics to its own file.
Mon, Jan 13, 12:27
markblundeberg added a comment to D4834: add sigChecks value to script cache.

I am thinking of making two changes here:

Mon, Jan 13, 11:00
markblundeberg updated the diff for D4834: add sigChecks value to script cache.

update tests

Mon, Jan 13, 07:58
markblundeberg added inline comments to D4834: add sigChecks value to script cache.
Mon, Jan 13, 07:55
markblundeberg added a comment to D4917: more optimal virtualsize accounting with increments.

Or should it be called GetVirtualSizeIncrement instead of GetIncrementalVirtualSize ?

Mon, Jan 13, 07:50
markblundeberg added a comment to D4903: Use virtualsize for mining/mempool priority.

I have a feeling this needs some tests...

Mon, Jan 13, 06:42
markblundeberg added a comment to D4917: more optimal virtualsize accounting with increments.

This could be integrated into the mentioned Diffs, but I figured the mathematical concepts here are a bit weird and deserve a separate think.

Mon, Jan 13, 05:13
markblundeberg updated the summary of D4917: more optimal virtualsize accounting with increments.
Mon, Jan 13, 05:10
markblundeberg accepted D4915: scripted-diff: Remove unused first argument to addUnchecked.
Mon, Jan 13, 05:09
markblundeberg created D4917: more optimal virtualsize accounting with increments.
Mon, Jan 13, 05:08
markblundeberg requested changes to D4915: scripted-diff: Remove unused first argument to addUnchecked.

Ah fantastic, I was planning to do this at some point. Please fix rebase conflict (D4898 landed) but otherwise looks good, also include make bench-bitcoin (or whatever) in the test plan just to make sure that compiles too.

Mon, Jan 13, 01:17
markblundeberg accepted D4914: Mark CTxMemPoolEntry members that should not be modified const.
Mon, Jan 13, 01:13
markblundeberg accepted D4916: test: add "diamond" unit test to MempoolAncestryTests.
Mon, Jan 13, 01:12
markblundeberg updated the diff for D4913: Merge #13142: Separate IsMine from solvability.

rebase

Mon, Jan 13, 01:07
markblundeberg added inline comments to D4912: Reintroduce IsSolvable.
Mon, Jan 13, 00:39
markblundeberg added inline comments to D4913: Merge #13142: Separate IsMine from solvability.
Mon, Jan 13, 00:17
markblundeberg planned changes to D4903: Use virtualsize for mining/mempool priority.
Mon, Jan 13, 00:14
markblundeberg updated the diff for D4903: Use virtualsize for mining/mempool priority.

rebase onto D4906 for CI

Mon, Jan 13, 00:12
markblundeberg updated the diff for D4906: Add virtualsize computation to mempool.

rebase

Mon, Jan 13, 00:09