Page MenuHomePhabricator

markblundeberg (Mark B Lundeberg)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 23 2018, 01:26 (38 w, 3 d)

Recent Activity

Yesterday

markblundeberg accepted D3896: Cleanup reject_code in abc-minimaldata-activation.
Sun, Aug 18, 05:55
markblundeberg accepted D3895: Cleanup reject_code in abc-schnorrmultisig-activation.
Sun, Aug 18, 05:55

Sat, Aug 17

markblundeberg accepted D3901: Merge #12811: test: Make summary row bold-red if any test failed and show failed tests at end of table.
Sat, Aug 17, 09:54
markblundeberg added a comment to D3901: Merge #12811: test: Make summary row bold-red if any test failed and show failed tests at end of table.

oh goody, I was looking forward to this one :)

Sat, Aug 17, 06:30
markblundeberg added a comment to D3773: Merge #10825: net: set regtest JSON-RPC port to 18443 to avoid conflict with testnet 18332.

Would have been good to have a release note for this, I just chatted with one person who was confused their regtest setup mysteriously stopped working upon upgrade.

Sat, Aug 17, 06:27

Thu, Aug 15

markblundeberg accepted D3884: Update chainparams.

ok, still feels weird to me to have chainwork not match the assumevalid block though

Thu, Aug 15, 22:36
markblundeberg closed T631: Backport PR 15118 "Refactor block file logic", a subtask of T589: BIP157 & BIP158 backports, as Resolved.
Thu, Aug 15, 00:01
markblundeberg closed T631: Backport PR 15118 "Refactor block file logic" as Resolved.
Thu, Aug 15, 00:01

Wed, Aug 14

markblundeberg updated the task description for T589: BIP157 & BIP158 backports.
Wed, Aug 14, 23:35
markblundeberg accepted D3868: Bump automatic replay protection to May 2020 upgrade.
Wed, Aug 14, 21:52
markblundeberg created D3872: make CheckMinimalPush available to codebase.
Wed, Aug 14, 14:43

Mon, Aug 12

markblundeberg accepted D3859: Fix incorrect node being checked in segwit recovery test.

oops! that was me :)

Mon, Aug 12, 22:12

Fri, Aug 9

markblundeberg added a revision to T528: Add Schnorr support to OP_CHECKMULTISIG (new mechanics): D3736: New Schnorr multisig activation.
Fri, Aug 9, 19:21
markblundeberg added a task to D3736: New Schnorr multisig activation: T528: Add Schnorr support to OP_CHECKMULTISIG (new mechanics).
Fri, Aug 9, 19:20
markblundeberg updated the summary of D3837: Merge #13162: [net] Don't incorrectly log that REJECT messages are unknown..
Fri, Aug 9, 17:07
markblundeberg added a comment to D3837: Merge #13162: [net] Don't incorrectly log that REJECT messages are unknown..

just noticed this bug on testnet in my -debug=net logfile

Fri, Aug 9, 16:58
markblundeberg created D3837: Merge #13162: [net] Don't incorrectly log that REJECT messages are unknown..
Fri, Aug 9, 16:57
markblundeberg added a comment to D3830: Update chainparams.

Just to follow up, this did indeed break my testnet node's ability to sync to the fork testnet. I had to put minimumchainwork=0 in the bitcoin.conf so it would stop disconnecting imaginary_username's node with reason "Disconnecting outbound peer 51 -- headers chain has insufficient work"

Fri, Aug 9, 15:29
markblundeberg added a comment to D3807: Fix some more copies in loops.

@Fabien Note for reference: https://github.com/bitcoin/bitcoin/pull/13241 -- is that backport skippable now?

Fri, Aug 9, 02:47
markblundeberg updated the diff for D3810: Merge #13194: Remove template matching and pseudo opcodes.

rebase for conflict (standard.cpp in D3807)

Fri, Aug 9, 00:55

Tue, Aug 6

markblundeberg updated the diff for D3810: Merge #13194: Remove template matching and pseudo opcodes.

rebase for landed parent

Tue, Aug 6, 22:30
markblundeberg created D3811: better error message for mandatory-flag tx rejections.
Tue, Aug 6, 20:12
markblundeberg updated the diff for D3810: Merge #13194: Remove template matching and pseudo opcodes.

move comments up a line

Tue, Aug 6, 19:47
markblundeberg updated the diff for D3810: Merge #13194: Remove template matching and pseudo opcodes.

braces

Tue, Aug 6, 19:44
markblundeberg added inline comments to D3810: Merge #13194: Remove template matching and pseudo opcodes.
Tue, Aug 6, 19:04
markblundeberg updated the summary of D3810: Merge #13194: Remove template matching and pseudo opcodes.
Tue, Aug 6, 19:03
markblundeberg created D3810: Merge #13194: Remove template matching and pseudo opcodes.
Tue, Aug 6, 19:02
markblundeberg created D3808: Merge #12460: Assert CPubKey::ValidLength to the pubkey's header-relevant size.
Tue, Aug 6, 18:49

Mon, Aug 5

markblundeberg accepted D3794: Add a message to static_assert.
Mon, Aug 5, 23:15

Sun, Aug 4

markblundeberg added a comment to D3794: Add a message to static_assert.

Note -- it only supports up to 20 pubkeys like regular multisig, rather this static assert is only here since the implementation's usage of a 32-bit number (and >> operator) is assuming < 32.

Sun, Aug 4, 00:51

Thu, Aug 1

markblundeberg accepted D3474: Implement new checkmultisig trigger logic and execution logic..
Thu, Aug 1, 23:48

Tue, Jul 30

markblundeberg abandoned D3473: [refactor multisig] consolidate legacy mode logic.

obsolete

Tue, Jul 30, 01:37

Mon, Jul 29

markblundeberg accepted D3761: Merge #11900: [script] simplify CheckMinimalPush checks, add safety assert.

Hmm, I don't get why there is the 'should' / 'must' distinction here, but yeah 👍 I wondered why it had been written that way.

Mon, Jul 29, 21:21
markblundeberg added a reviewer for D3763: MINIMALDATA consensus activation: Mengerian.
Mon, Jul 29, 21:10
markblundeberg created D3763: MINIMALDATA consensus activation.
Mon, Jul 29, 21:10
markblundeberg added inline comments to D3736: New Schnorr multisig activation.
Mon, Jul 29, 18:54
markblundeberg updated the diff for D3736: New Schnorr multisig activation.

rebase onto the updated parent

Mon, Jul 29, 18:04

Sun, Jul 28

markblundeberg added inline comments to D3474: Implement new checkmultisig trigger logic and execution logic..
Sun, Jul 28, 20:58
markblundeberg added inline comments to D3474: Implement new checkmultisig trigger logic and execution logic..
Sun, Jul 28, 19:50
markblundeberg requested changes to D3474: Implement new checkmultisig trigger logic and execution logic..
Sun, Jul 28, 19:46

Sat, Jul 27

markblundeberg added a comment to D3474: Implement new checkmultisig trigger logic and execution logic..
Sat, Jul 27, 15:45
markblundeberg created D3754: Merge #10682: Trivial: Move the AreInputsStandard documentation next to its implementation.
Sat, Jul 27, 02:11

Fri, Jul 26

markblundeberg added inline comments to D3736: New Schnorr multisig activation.
Fri, Jul 26, 21:13
markblundeberg updated the diff for D3736: New Schnorr multisig activation.

update feature_nulldummy test to only run pre-activation

Fri, Jul 26, 21:12

Thu, Jul 25

markblundeberg planned changes to D3736: New Schnorr multisig activation.
Thu, Jul 25, 05:42
markblundeberg added a comment to D3736: New Schnorr multisig activation.

Hmm, I tried also running ./test/functional/test_runner.py --with-gravitonactivation which actually causes a failure in feature_nulldummy.py, which is not surprising because the reject reason will have changed.

Thu, Jul 25, 05:32
markblundeberg created D3736: New Schnorr multisig activation.
Thu, Jul 25, 05:29
markblundeberg added a comment to D3474: Implement new checkmultisig trigger logic and execution logic..

@deadalnix ok to commandeer now

Thu, Jul 25, 02:04
markblundeberg planned changes to D3474: Implement new checkmultisig trigger logic and execution logic..
Thu, Jul 25, 02:04
markblundeberg updated the diff for D3474: Implement new checkmultisig trigger logic and execution logic..

add more test cases

Thu, Jul 25, 02:03

Tue, Jul 23

markblundeberg added inline comments to D3474: Implement new checkmultisig trigger logic and execution logic..
Tue, Jul 23, 17:18

Jul 20 2019

markblundeberg added inline comments to D3474: Implement new checkmultisig trigger logic and execution logic..
Jul 20 2019, 00:14

Jul 19 2019

markblundeberg requested review of D3589: [5 of 5] Style cleanup..
Jul 19 2019, 15:34
markblundeberg requested review of D3588: [4 of 5] scripted-diff: Rename CBlockDiskPos to FlatFilePos..
Jul 19 2019, 15:31
markblundeberg added a comment to D3588: [4 of 5] scripted-diff: Rename CBlockDiskPos to FlatFilePos..

This is clearly missing at least one (if not more) backports. See ReadRawBlockFromDisk in the original PR.

Jul 19 2019, 15:31
markblundeberg added inline comments to D3474: Implement new checkmultisig trigger logic and execution logic..
Jul 19 2019, 06:08
markblundeberg updated the diff for D3474: Implement new checkmultisig trigger logic and execution logic..

rebased & change to the new bitfield decoding scheme

Jul 19 2019, 06:07

Jul 18 2019

markblundeberg added a comment to D3589: [5 of 5] Style cleanup..

system.h/cpp needs to be backported first

Jul 18 2019, 06:13

Jul 15 2019

markblundeberg updated the diff for D3586: [2 of 5] validation: Extract basic block file logic into FlatFileSeq class..

for include order (and rebuild)

Jul 15 2019, 22:17
markblundeberg created D3676: fix backported comment placement.
Jul 15 2019, 15:04
markblundeberg created D3675: [refactor multisig] remove redundant counters.
Jul 15 2019, 01:10

Jul 14 2019

markblundeberg added a comment to D3674: remove ComparisonTestFramework dependency from segwit recovery test.

Note that rejected and reconnect_p2p don't actually get used in this test; could probably be taken out. Initially I was thinking they might come in useful later, now I can't imagine that anything like that would be added.

Jul 14 2019, 15:52
markblundeberg created D3674: remove ComparisonTestFramework dependency from segwit recovery test.
Jul 14 2019, 01:55
markblundeberg planned changes to D3473: [refactor multisig] consolidate legacy mode logic.
Jul 14 2019, 01:10
markblundeberg updated the diff for D3473: [refactor multisig] consolidate legacy mode logic.

reworked into parents

Jul 14 2019, 01:05
markblundeberg abandoned D3540: make check in parallel - turbo mode.
Jul 14 2019, 00:49
markblundeberg updated the diff for D3626: [refactor multisig] separate nullfail from stack cleanup.

reworked parents

Jul 14 2019, 00:43
markblundeberg created D3673: [refactor multisig] move nulldummy check to front.
Jul 14 2019, 00:37
markblundeberg updated the summary of D3625: [refactor multisig] make const values up front.
Jul 14 2019, 00:23

Jul 13 2019

markblundeberg updated the diff for D3625: [refactor multisig] make const values up front.

update comments & remove unneeded empty line

Jul 13 2019, 23:51
markblundeberg updated the summary of D3625: [refactor multisig] make const values up front.
Jul 13 2019, 19:47
markblundeberg added inline comments to D3625: [refactor multisig] make const values up front.
Jul 13 2019, 15:15
markblundeberg updated the diff for D3625: [refactor multisig] make const values up front.

guessing at what types are expected

Jul 13 2019, 02:28
markblundeberg updated the diff for D3589: [5 of 5] Style cleanup..

minor conflict -- one braces fix now done in ancestor

Jul 13 2019, 02:02
markblundeberg updated the diff for D3588: [4 of 5] scripted-diff: Rename CBlockDiskPos to FlatFilePos..

minor conflict from parent

Jul 13 2019, 02:02
markblundeberg updated the diff for D3587: [3 of 5] Move CDiskBlockPos from chain to flatfile..

rebased parent & new abc ver

Jul 13 2019, 02:01
markblundeberg updated the diff for D3586: [2 of 5] validation: Extract basic block file logic into FlatFileSeq class..

address nits

Jul 13 2019, 01:58
markblundeberg accepted D3648: Use size_t for stack index in OP_MULTISIG.
Jul 13 2019, 01:53
markblundeberg created D3672: CONTRIBUTING.md - update instructions on linting dependencies.
Jul 13 2019, 01:51
markblundeberg updated the diff for D3350: [script_tests] improve test coverage of minimal push rules.

update per jason's comments

Jul 13 2019, 01:11

Jul 12 2019

markblundeberg added a comment to D3667: Version number bumped to 0.19.11.

[Errno 28] No space left on device

Jul 12 2019, 18:16

Jul 11 2019

markblundeberg accepted D3653: Update chainparams.
Jul 11 2019, 21:58
markblundeberg added a comment to D3653: Update chainparams.

Confirm mainnet 000000000000000004425aeeb553758650da20031643fbfff0f53ac5dd1b39c3 and its chainwork; has currently 45 confirmations.

Jul 11 2019, 21:58
markblundeberg updated the diff for D3638: Merge #12988: Hold cs_main while calling UpdatedBlockTip() signal.

retest rebase

Jul 11 2019, 19:00
markblundeberg accepted D3646: Use txid in bloom tests.
Jul 11 2019, 18:58
markblundeberg added inline comments to D3648: Use size_t for stack index in OP_MULTISIG.
Jul 11 2019, 02:00

Jul 10 2019

markblundeberg closed T436: Backport core PR 10286, a subtask of T437: Backport core PR 11738, as Resolved.
Jul 10 2019, 18:33 · Restricted Project
markblundeberg closed T436: Backport core PR 10286, a subtask of T638: Backport Core PR 11738 (fix hang in sendrawtransaction), as Resolved.
Jul 10 2019, 18:33
markblundeberg closed T436: Backport core PR 10286, a subtask of T626: Backport Core PR 12988, as Resolved.
Jul 10 2019, 18:33
markblundeberg closed T436: Backport core PR 10286 as Resolved.

developer notes were done in D2941

Jul 10 2019, 18:33 · Restricted Project
markblundeberg closed T626: Backport Core PR 12988, a subtask of T623: Backport Core PR 13023, as Resolved.
Jul 10 2019, 18:13
markblundeberg closed T626: Backport Core PR 12988 as Resolved.

see D3638

Jul 10 2019, 18:13
markblundeberg created D3638: Merge #12988: Hold cs_main while calling UpdatedBlockTip() signal.
Jul 10 2019, 18:12
markblundeberg abandoned D3267: check negative CScriptNum.getint() and introduce new error code.
Jul 10 2019, 16:08
markblundeberg planned changes to D3626: [refactor multisig] separate nullfail from stack cleanup.
Jul 10 2019, 15:49
markblundeberg abandoned D3627: [refactor multisig] remove redundant stack check.
Jul 10 2019, 15:44
markblundeberg accepted D3629: [wallet] Fix potential memory leak in CreateWalletFromFile.
Jul 10 2019, 15:30
markblundeberg requested review of D3625: [refactor multisig] make const values up front.

@deadalnix I've thought over more and I'm not convinced at all about converting to size_t. We can continue to debate but the longer this goes on, the more chance it means that dependent diffs will be delayed, resulting in Schnorr multisig being postponed until May or a later upgrade. That's fine, there's no rush to get these things done, but it seems unfortunate that feature work would be blocked on a nit like this.

Jul 10 2019, 14:15
markblundeberg updated the diff for D3581: Merge #10657: Utils: Improvements to ECDSA key-handling code.

include comment (except part about hashtype byte) into sigencoding.cpp

Jul 10 2019, 04:31
markblundeberg added a comment to D3581: Merge #10657: Utils: Improvements to ECDSA key-handling code.
Jul 10 2019, 04:26