Page MenuHomePhabricator

markblundeberg (Mark B Lundeberg)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 23 2018, 01:26 (54 w, 18 h)

Recent Activity

Today

markblundeberg added a comment to D4247: Decodehextx scripts sanity check.

This seems to just remove functionality and Core only did this because they have problems telling apart segwit txns from partially constructed non-segwit transactions (see discussion on PR). This isn't a crutch that we need to be copying.

Fri, Dec 6, 19:38

Yesterday

markblundeberg updated the diff for D3880: Add wallet acceptance / mempool acceptance tests for non-standard variants.

rebase

Thu, Dec 5, 18:32

Tue, Dec 3

markblundeberg updated the diff for D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.

rm assert & update comment

Tue, Dec 3, 22:16
markblundeberg added inline comments to D4621: allow cuckoocache to function as a map.
Tue, Dec 3, 17:28
markblundeberg created D4621: allow cuckoocache to function as a map.
Tue, Dec 3, 05:49
markblundeberg updated the diff for D3880: Add wallet acceptance / mempool acceptance tests for non-standard variants.

rebase to master and tweak a few comments

Tue, Dec 3, 01:20
markblundeberg added inline comments to D3880: Add wallet acceptance / mempool acceptance tests for non-standard variants.
Tue, Dec 3, 01:13
markblundeberg updated the diff for D3880: Add wallet acceptance / mempool acceptance tests for non-standard variants.

a number of updates

  • added a couple of behaviours that are nonstandard to fund but the wallet

will pick up, and will spend successfully.

  • rename test, the general idea is to make sure wallet is not DoSable.
Tue, Dec 3, 01:11

Mon, Dec 2

markblundeberg updated the summary of D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.
Mon, Dec 2, 23:46
markblundeberg updated the diff for D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.

update ctor

Mon, Dec 2, 23:43
markblundeberg commandeered D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.
Mon, Dec 2, 23:39
markblundeberg planned changes to D4617: add sigChecks counting and a flag that restricts it per-input.
Mon, Dec 2, 21:54
markblundeberg added a comment to D4618: fix undefined behaviour in seeder (select() aliasing).

Ah OK it is documented here at least https://pubs.opengroup.org/onlinepubs/009695399/basedefs/sys/select.h.html

Mon, Dec 2, 21:16
markblundeberg created D4618: fix undefined behaviour in seeder (select() aliasing).
Mon, Dec 2, 19:43
markblundeberg added inline comments to D4617: add sigChecks counting and a flag that restricts it per-input.
Mon, Dec 2, 19:28
markblundeberg added a task to D4617: add sigChecks counting and a flag that restricts it per-input: T704: sigChecks implementation.
Mon, Dec 2, 19:26
markblundeberg added a revision to T704: sigChecks implementation: D4617: add sigChecks counting and a flag that restricts it per-input.
Mon, Dec 2, 19:26
markblundeberg created D4617: add sigChecks counting and a flag that restricts it per-input.
Mon, Dec 2, 19:26
markblundeberg added a comment to D4453: [CI] Remove functional tests with graviton activation.

I think it would be better to replace this with the next upgrade, even if it does nothing for now. Otherwise, we have to re-implement this later.

Mon, Dec 2, 18:53

Sun, Dec 1

markblundeberg updated the task description for T704: sigChecks implementation.
Sun, Dec 1, 18:40
markblundeberg updated the task description for T704: sigChecks implementation.
Sun, Dec 1, 18:39
markblundeberg created T704: sigChecks implementation.
Sun, Dec 1, 18:33

Fri, Nov 29

markblundeberg updated the test plan for D4577: remove NULLDUMMY.
Fri, Nov 29, 15:57
markblundeberg updated the diff for D4577: remove NULLDUMMY.

remove spurious newline and request teamcity rerun

Fri, Nov 29, 04:46
markblundeberg added inline comments to D4577: remove NULLDUMMY.
Fri, Nov 29, 04:16
markblundeberg created D4577: remove NULLDUMMY.
Fri, Nov 29, 04:13

Thu, Nov 28

markblundeberg added a comment to T703: clean up schnorr activations.

TODO:

  • add SCHNORR_MULTISIG to mandatory flags
  • remove NULLDUMMY completely from codebase
Thu, Nov 28, 21:52
markblundeberg added a revision to T703: clean up schnorr activations: D4576: drop 'check3' upgrade-conditional-script-failure for Schnorr multisig.
Thu, Nov 28, 21:51
markblundeberg added a task to D4576: drop 'check3' upgrade-conditional-script-failure for Schnorr multisig: T703: clean up schnorr activations.
Thu, Nov 28, 21:51
markblundeberg triaged T703: clean up schnorr activations as Normal priority.
Thu, Nov 28, 21:51
markblundeberg closed T528: Add Schnorr support to OP_CHECKMULTISIG (new mechanics), a subtask of T526: Schnorr-ifying, as Resolved.
Thu, Nov 28, 21:49
markblundeberg closed T528: Add Schnorr support to OP_CHECKMULTISIG (new mechanics) as Resolved.
Thu, Nov 28, 21:49
markblundeberg created D4576: drop 'check3' upgrade-conditional-script-failure for Schnorr multisig.
Thu, Nov 28, 21:49

Thu, Nov 21

markblundeberg added a comment to D4474: Added support for -gravitonactivationtime to unit tests.

I find it amusing that there didn't need to be a main() before :D
Macro batman_approves:

Thu, Nov 21, 01:23

Wed, Nov 20

markblundeberg updated the diff for D3880: Add wallet acceptance / mempool acceptance tests for non-standard variants.

bump (rebased)

Wed, Nov 20, 23:13

Sun, Nov 17

markblundeberg added inline comments to D4455: add a couple more Schnorr checkmultisig tests.
Sun, Nov 17, 02:25
markblundeberg created D4455: add a couple more Schnorr checkmultisig tests.
Sun, Nov 17, 02:11

Fri, Nov 15

markblundeberg added inline comments to D4452: Add checkpoints for graviton upgrade.
Fri, Nov 15, 15:02
markblundeberg created D4451: fix txvalidationcache_tests to not rely on NULLDUMMY.
Fri, Nov 15, 14:38

Sep 25 2019

markblundeberg updated the diff for D3880: Add wallet acceptance / mempool acceptance tests for non-standard variants.

rebase & revive

Sep 25 2019, 01:46

Aug 18 2019

markblundeberg planned changes to D3880: Add wallet acceptance / mempool acceptance tests for non-standard variants.

Going to pull this off review queue for now, since the intent is to delay landing this until some time later.

Aug 18 2019, 05:56
markblundeberg accepted D3896: Cleanup reject_code in abc-minimaldata-activation.
Aug 18 2019, 05:55
markblundeberg accepted D3895: Cleanup reject_code in abc-schnorrmultisig-activation.
Aug 18 2019, 05:55

Aug 17 2019

markblundeberg accepted D3901: Merge #12811: test: Make summary row bold-red if any test failed and show failed tests at end of table.
Aug 17 2019, 09:54
markblundeberg added a comment to D3901: Merge #12811: test: Make summary row bold-red if any test failed and show failed tests at end of table.

oh goody, I was looking forward to this one :)

Aug 17 2019, 06:30
markblundeberg added a comment to D3773: Merge #10825: net: set regtest JSON-RPC port to 18443 to avoid conflict with testnet 18332.

Would have been good to have a release note for this, I just chatted with one person who was confused their regtest setup mysteriously stopped working upon upgrade.

Aug 17 2019, 06:27

Aug 15 2019

markblundeberg accepted D3884: Update chainparams.

ok, still feels weird to me to have chainwork not match the assumevalid block though

Aug 15 2019, 22:36
markblundeberg added inline comments to D3880: Add wallet acceptance / mempool acceptance tests for non-standard variants.
Aug 15 2019, 22:22
markblundeberg updated the diff for D3880: Add wallet acceptance / mempool acceptance tests for non-standard variants.

rebase for landed parent

Aug 15 2019, 22:19
markblundeberg added inline comments to D3865: recognize bare multisigs as standard only when using minimal pushes.
Aug 15 2019, 20:54
markblundeberg updated the diff for D3865: recognize bare multisigs as standard only when using minimal pushes.

add nonnegative check per Fabien's suggestion

Aug 15 2019, 20:54
markblundeberg changed the visibility for D3865: recognize bare multisigs as standard only when using minimal pushes.
Aug 15 2019, 04:26
markblundeberg changed the visibility for D3880: Add wallet acceptance / mempool acceptance tests for non-standard variants.
Aug 15 2019, 04:26
markblundeberg updated the diff for D3880: Add wallet acceptance / mempool acceptance tests for non-standard variants.

update per comments

Aug 15 2019, 02:33
markblundeberg closed T631: Backport PR 15118 "Refactor block file logic", a subtask of T589: BIP157 & BIP158 backports, as Resolved.
Aug 15 2019, 00:01
markblundeberg closed T631: Backport PR 15118 "Refactor block file logic" as Resolved.
Aug 15 2019, 00:01

Aug 14 2019

markblundeberg updated the task description for T589: BIP157 & BIP158 backports.
Aug 14 2019, 23:35
markblundeberg updated the diff for D3880: Add wallet acceptance / mempool acceptance tests for non-standard variants.

resubmit from arc (with lint changes)

Aug 14 2019, 23:15
markblundeberg added a comment to D3880: Add wallet acceptance / mempool acceptance tests for non-standard variants.

This is a variant of D3818 that tests all the forms, and does some extra testing on each one.

Aug 14 2019, 23:12
markblundeberg added reviewers for D3880: Add wallet acceptance / mempool acceptance tests for non-standard variants: jasonbcox, Fabien.
Aug 14 2019, 23:11
markblundeberg updated the summary of D3880: Add wallet acceptance / mempool acceptance tests for non-standard variants.
Aug 14 2019, 23:11
markblundeberg created D3880: Add wallet acceptance / mempool acceptance tests for non-standard variants.
Aug 14 2019, 23:10
markblundeberg updated the diff for D3865: recognize bare multisigs as standard only when using minimal pushes.

rebase; increase test coverage and add comments.

Aug 14 2019, 23:00
markblundeberg accepted D3868: Bump automatic replay protection to May 2020 upgrade.
Aug 14 2019, 21:52
markblundeberg updated the diff for D3865: recognize bare multisigs as standard only when using minimal pushes.

updated to use CheckMinimalPush

Aug 14 2019, 14:49
markblundeberg created D3872: make CheckMinimalPush available to codebase.
Aug 14 2019, 14:43

Aug 13 2019

markblundeberg updated the diff for D3865: recognize bare multisigs as standard only when using minimal pushes.

arc update to make it follow standard procedure

Aug 13 2019, 17:01
markblundeberg updated the summary of D3865: recognize bare multisigs as standard only when using minimal pushes.
Aug 13 2019, 16:59
markblundeberg updated the summary of D3865: recognize bare multisigs as standard only when using minimal pushes.
Aug 13 2019, 16:58
markblundeberg created D3865: recognize bare multisigs as standard only when using minimal pushes.
Aug 13 2019, 16:58

Aug 12 2019

markblundeberg accepted D3859: Fix incorrect node being checked in segwit recovery test.

oops! that was me :)

Aug 12 2019, 22:12

Aug 9 2019

markblundeberg added a revision to T528: Add Schnorr support to OP_CHECKMULTISIG (new mechanics): D3736: New Schnorr multisig activation.
Aug 9 2019, 19:21
markblundeberg added a task to D3736: New Schnorr multisig activation: T528: Add Schnorr support to OP_CHECKMULTISIG (new mechanics).
Aug 9 2019, 19:20
markblundeberg updated the summary of D3837: Merge #13162: [net] Don't incorrectly log that REJECT messages are unknown..
Aug 9 2019, 17:07
markblundeberg added a comment to D3837: Merge #13162: [net] Don't incorrectly log that REJECT messages are unknown..

just noticed this bug on testnet in my -debug=net logfile

Aug 9 2019, 16:58
markblundeberg created D3837: Merge #13162: [net] Don't incorrectly log that REJECT messages are unknown..
Aug 9 2019, 16:57
markblundeberg added a comment to D3830: Update chainparams.

Just to follow up, this did indeed break my testnet node's ability to sync to the fork testnet. I had to put minimumchainwork=0 in the bitcoin.conf so it would stop disconnecting imaginary_username's node with reason "Disconnecting outbound peer 51 -- headers chain has insufficient work"

Aug 9 2019, 15:29
markblundeberg added a comment to D3807: Fix some more copies in loops.

@Fabien Note for reference: https://github.com/bitcoin/bitcoin/pull/13241 -- is that backport skippable now?

Aug 9 2019, 02:47
markblundeberg updated the diff for D3810: Merge #13194: Remove template matching and pseudo opcodes.

rebase for conflict (standard.cpp in D3807)

Aug 9 2019, 00:55

Aug 6 2019

markblundeberg updated the diff for D3810: Merge #13194: Remove template matching and pseudo opcodes.

rebase for landed parent

Aug 6 2019, 22:30
markblundeberg created D3811: better error message for mandatory-flag tx rejections.
Aug 6 2019, 20:12
markblundeberg updated the diff for D3810: Merge #13194: Remove template matching and pseudo opcodes.

move comments up a line

Aug 6 2019, 19:47
markblundeberg updated the diff for D3810: Merge #13194: Remove template matching and pseudo opcodes.

braces

Aug 6 2019, 19:44
markblundeberg added inline comments to D3810: Merge #13194: Remove template matching and pseudo opcodes.
Aug 6 2019, 19:04
markblundeberg updated the summary of D3810: Merge #13194: Remove template matching and pseudo opcodes.
Aug 6 2019, 19:03
markblundeberg created D3810: Merge #13194: Remove template matching and pseudo opcodes.
Aug 6 2019, 19:02
markblundeberg created D3808: Merge #12460: Assert CPubKey::ValidLength to the pubkey's header-relevant size.
Aug 6 2019, 18:49

Aug 5 2019

markblundeberg accepted D3794: Add a message to static_assert.
Aug 5 2019, 23:15

Aug 4 2019

markblundeberg added a comment to D3794: Add a message to static_assert.

Note -- it only supports up to 20 pubkeys like regular multisig, rather this static assert is only here since the implementation's usage of a 32-bit number (and >> operator) is implicitly assuming < 32 keys.

Aug 4 2019, 00:51

Aug 1 2019

markblundeberg accepted D3474: Implement new checkmultisig trigger logic and execution logic..
Aug 1 2019, 23:48

Jul 30 2019

markblundeberg abandoned D3473: [refactor multisig] consolidate legacy mode logic.

obsolete

Jul 30 2019, 01:37

Jul 29 2019

markblundeberg accepted D3761: Merge #11900: [script] simplify CheckMinimalPush checks, add safety assert.

Hmm, I don't get why there is the 'should' / 'must' distinction here, but yeah 👍 I wondered why it had been written that way.

Jul 29 2019, 21:21
markblundeberg added a reviewer for D3763: MINIMALDATA consensus activation: Mengerian.
Jul 29 2019, 21:10
markblundeberg created D3763: MINIMALDATA consensus activation.
Jul 29 2019, 21:10
markblundeberg added inline comments to D3736: New Schnorr multisig activation.
Jul 29 2019, 18:54
markblundeberg updated the diff for D3736: New Schnorr multisig activation.

rebase onto the updated parent

Jul 29 2019, 18:04

Jul 28 2019

markblundeberg added inline comments to D3474: Implement new checkmultisig trigger logic and execution logic..
Jul 28 2019, 20:58
markblundeberg added inline comments to D3474: Implement new checkmultisig trigger logic and execution logic..
Jul 28 2019, 19:50
markblundeberg requested changes to D3474: Implement new checkmultisig trigger logic and execution logic..
Jul 28 2019, 19:46

Jul 27 2019

markblundeberg added a comment to D3474: Implement new checkmultisig trigger logic and execution logic..
Jul 27 2019, 15:45