- User Since
- Nov 23 2018, 01:26 (126 w, 11 h)
Feb 15 2020
(add depends on 0.21 update)
Feb 14 2020
Yes this works because the mempool is being reprocessed now due to another upgrade, as the reversebytes thing D5130 (==D5283) is landed already. 👍
(that's not bad btw, I rely on the same in my now-landed D5224 tests)
@dagurval this is the only way I know how to do these kinds of tests. We have never written tests that depend explicitly on --with-phononactivation and we avoid writing tests that directly invoke time(), so that would be pretty weird if you did that. In other words we write tests that are either testing activation-independent behaviour, or if they are sensitive then they must handle their own activation parameters and override any effect that --with-phononactivation might have, like you've done here.
I won't block this as I'm not confident to effectively review its substance, but good to see the build failures are showing up now.
Feb 13 2020
Thanks! I'm going to give this a whirl... (I was the one having pyenv issues 😊 )
Where is the spec for this? If there isn't any yet, one can be put under doc/abc/ . It's not clear what is the intended behaviour in simple language -- how does activation work, when does rule take effect, when does rule stop taking effect, etc etc.
For the record in future (as this is going to happen again and again) the required change to fix this kind of thing is not hard, you just need to change the generate rpc to generatetoaddress rpc, see D5267.
update test to work with nowallet build
update func test to work with nowallet build
update functional test to work with nowallet build
I am guessing this is due to D5184, and we are going to see this happen over and over until nowallet build is added to the Diff testing CI
fix the build fail
Teamcity is not able to post build failures here unless it's given permission (it's not part of Bitcoin ABC group) -- if you want that you have to add it to policy as a second entry.
Feb 12 2020
update after D5130 landing, now the mempool is reprocessed on upgrade so this has no dependencies.
putting in a name : axion
Best runner so far: Axion
I think I am going to leave off the virtualsize tests to a separate Diff, to keep this focussed on consensus behaviour. (It's not like we're introducing any new virtualsize behaviours, just changing what count is used)
Feb 11 2020
minor text fix (will not change result after child)
actually various wrong params -- moved to D5257
braces; drop nonexistent param
update per nit
update comments with --child-silent-after-fork=yes
Should be fixed now by D5254, please rebase.
update based on D5254
Opening this now to take suggestions on names. :-)
(the 5 remaining reachable leaked blocks are: 4 from leveldb, 1 from LogInstance)
update per comments; still todo: virtualsize test
Feb 10 2020
fix //!< comments to be in front
a few examples of the changes:
better IsMine comment
update comment, second argument to execlp needs to be nonnull