Page MenuHomePhabricator

Merge #13030: [bugfix] [wallet] Fix zapwallettxes/multiwallet interaction.
ClosedPublic

Authored by markblundeberg on Tue, Feb 11, 13:45.

Details

Summary

PR13030 backport

Depends on D5261

Pull request description:

`-zapwallettxes` should be disallowed when starting bitcoin in multiwallet mode.

There's code in `WalletInit::ParameterInteraction()` to disallow `-zapwallettxes` when running in multiwallet mode. This code functioned as expected when passing the parameter `-zapwallettxes=1`, but not when passing the parameter `-zapwallettxes` (ie without the value specified). Fix that and add a test.

The new test in the
_[wallet] [tests] Test disallowed multiwallet params_ commit reproduces the bug and should fail against master.
Test Plan

ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markblundeberg created this revision.Tue, Feb 11, 13:45
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Feb 11, 13:45
teamcity edited the summary of this revision. (Show Details)Tue, Feb 11, 13:45

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

fixed parent

Fabien accepted this revision.Tue, Feb 11, 14:36
This revision is now accepted and ready to land.Tue, Feb 11, 14:36