HomePhabricator

Merge #13030: [bugfix] [wallet] Fix zapwallettxes/multiwallet interaction.

Description

Merge #13030: [bugfix] [wallet] Fix zapwallettxes/multiwallet interaction.

Summary:
PR13030 backport

Depends on D5261

Pull request description:

`-zapwallettxes` should be disallowed when starting bitcoin in multiwallet mode.

There's code in `WalletInit::ParameterInteraction()` to disallow `-zapwallettxes` when running in multiwallet mode. This code functioned as expected when passing the parameter `-zapwallettxes=1`, but not when passing the parameter `-zapwallettxes` (ie without the value specified). Fix that and add a test.

The new test in the
_[wallet] [tests] Test disallowed multiwallet params_ commit reproduces the bug and should fail against master.

Test Plan: ninja check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D5262

Details