Page MenuHomePhabricator

Merge #13152: [rpc] Add getnodeaddresses RPC command
ClosedPublic

Authored by nakihito on Sat, Feb 8, 00:05.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC48916ac8540e: Merge #13152: [rpc] Add getnodeaddresses RPC command
Summary

a2eb6f5405 [rpc] Add getnodeaddresses RPC command (chris-belcher)

Pull request description:

Implements issue https://github.com/bitcoin/bitcoin/issues/9463

New getnodeaddresses call gives access via RPC to the peers known by the node. It may be useful for bitcoin wallets to broadcast their transactions over tor for improved privacy without using the centralized DNS seeds. getnodeaddresses is very similar to the getaddr p2p method.

Please advise me on the best approach for writing an automated test. By my reading the getaddr p2p method also isn't really tested.

Tree-SHA512: ad03abf518847476495b76a2f5394b8030aa86654429167fa618e21460abb505c10ef9817ec1b80472320d41d0aff5dc94a8efce023aaaaf5e81386aa92b852b

Backport of Core PR13152

Test Plan
ninja check
ninja check-functional

./bitcoind
./bitcoin-cli help getnodeaddresses

Verify help text

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Sat, Feb 8, 00:05
Owners added a reviewer: Restricted Owners Package.Sat, Feb 8, 00:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptSat, Feb 8, 00:05
teamcity edited the summary of this revision. (Show Details)Sat, Feb 8, 00:06

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

teamcity added a comment.Sat, Feb 8, 00:11

Snippet of first build failure:

[00:10:39]F:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_LockDirectory
[00:10:39]i:			 [util_tests.test_LockDirectory] [Test Error Output]
Failures detected in:
- test case: util_tests/test_LockDirectory
- file: util_tests.cpp
- line: 1290
[00:10:39]F:			 [util_tests.test_LockDirectory] assertion error: failure
[00:10:39]F:			 [util_tests.test_LockDirectory] ASSERTION FAILURE:
- file   : util_tests.cpp
- line   : 1368
- message: check processstatus == 0 has failed [11 != 0]
[00:10:40]E:	 [Step 1/1] Failed tests detected
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_DirIsWritable
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_ConvertBits
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_ToLower
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_ToUpper
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_Capitalize
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] validation_block_tests.processnewblock_signals_ordering
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] validation_tests.block_subsidy_test
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] validation_tests.subsidy_limit_test
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] validation_tests.validation_load_external_block_file
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] versionbits_tests.versionbits_test
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] versionbits_tests.versionbits_computeblockversion
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] work_comparator_tests.work_comparator
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] server_tests.server_IsDeprecatedRPCEnabled
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] accounting_tests.acc_orderupgrade
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] db_tests.getwalletenv_file
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] db_tests.getwalletenv_directory
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] db_tests.getwalletenv_g_dbenvs_multiple
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] db_tests.getwalletenv_g_dbenvs_free_instance
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] coinselector_tests.bnb_search_test
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] coinselector_tests.knapsack_solver_test
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] coinselector_tests.ApproximateBestSubset
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] coinselector_tests.SelectCoins_test
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_default
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_custom
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_does_not_exist
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_is_not_directory
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_is_not_relative
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_no_trailing
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_no_trailing2
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] psbt_wallet_tests.psbt_updater_test
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] psbt_wallet_tests.parse_hd_keypath
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.rescan
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.importwallet_rescan
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.coin_mark_dirty_immature_credit
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.ComputeTimeSmart
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.LoadReceiveRequests
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.ListCoins
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.wallet_disableprivkeys
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] walletdb_tests.write_erase_name
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] walletdb_tests.write_erase_purpose
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] walletdb_tests.write_erase_destdata
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] walletdb_tests.no_dest_fails
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_crypto_tests.passphrase
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_crypto_tests.encrypt
[00:10:39]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_crypto_tests.decrypt
[00:10:39]W:	 [Step 1/1]  [0;39;49m
[00:10:39]W:	 [Step 1/1] Process exited with code 201
[00:10:40]E:	 [Step 1/1] Process exited with code 201 (Step: Command Line)

Each failure log is accessible here:
Bitcoin_ABC_unit_tests_with_next_upgrade_activated: util_tests.test_LockDirectory

teamcity added a comment.Sat, Feb 8, 01:23

Snippet of first build failure:

[01:21:16]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_is_not_relative
[01:21:16]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_no_trailing
[01:21:16]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_no_trailing2
[01:21:16]i:		 [Bitcoin_ABC_unit_tests] psbt_wallet_tests.psbt_updater_test
[01:21:16]i:		 [Bitcoin_ABC_unit_tests] psbt_wallet_tests.parse_hd_keypath
[01:21:16]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.rescan
[01:21:16]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.importwallet_rescan
[01:21:16]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.coin_mark_dirty_immature_credit
[01:21:16]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.ComputeTimeSmart
[01:21:16]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.LoadReceiveRequests
[01:21:16]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.ListCoins
[01:21:16]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.wallet_disableprivkeys
[01:21:16]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.write_erase_name
[01:21:16]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.write_erase_purpose
[01:21:16]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.write_erase_destdata
[01:21:16]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.no_dest_fails
[01:21:16]i:		 [Bitcoin_ABC_unit_tests] wallet_crypto_tests.passphrase
[01:21:16]i:		 [Bitcoin_ABC_unit_tests] wallet_crypto_tests.encrypt
[01:21:16]i:		 [Bitcoin_ABC_unit_tests] wallet_crypto_tests.decrypt
[01:22:41] :	 [Step 1/1] Running 454 test cases...
[01:22:41] :	 [Step 1/1] 
[01:22:41] :	 [Step 1/1] Assertion occurred in a following context:
[01:22:41] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[01:22:41] :	 [Step 1/1] Assertion occurred in a following context:
[01:22:41] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[01:22:41] :	 [Step 1/1] Assertion occurred in a following context:
[01:22:41] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[01:22:41] :	 [Step 1/1] Assertion occurred in a following context:
[01:22:41] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[01:22:41] :	 [Step 1/1] Assertion occurred in a following context:
[01:22:41] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[01:22:41] :	 [Step 1/1] Assertion occurred in a following context:
[01:22:41] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[01:22:41] :	 [Step 1/1] Assertion occurred in a following context:
[01:22:41] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[01:22:41] :	 [Step 1/1] Assertion occurred in a following context:
[01:22:41] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[01:22:41] :	 [Step 1/1] Assertion occurred in a following context:
[01:22:41] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[01:22:41] :	 [Step 1/1] Assertion occurred in a following context:
[01:22:41] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[01:22:41] :	 [Step 1/1] Assertion occurred in a following context:
[01:22:41] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[01:22:41] :	 [Step 1/1] Assertion occurred in a following context:
[01:22:41] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[01:22:41] :	 [Step 1/1] Assertion occurred in a following context:
[01:22:41] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365
[01:22:41] :	 [Step 1/1] Assertion occurred in a following context:
[01:22:41] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365
[01:22:41] :	 [Step 1/1] Assertion occurred in a following context:
[01:22:41] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365
[01:22:41] :	 [Step 1/1] Assertion occurred in a following context:
[01:22:47]W:	 [Step 1/1] corrupted double-linked list
[01:22:47] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365../src/test/util_tests.cpp(1368):  [1;31;49merror: in "util_tests/test_LockDirectory": check processstatus == 0 has failed [11 != 0] [0;39;49m
[01:22:53] :	 [Step 1/1] 30000000
[01:22:53]W:	 [Step 1/1] 
[01:22:53]W:	 [Step 1/1]  [1;31;49m*** 1 failure is detected in the test module "Bitcoin ABC unit tests with next upgrade activated"
[01:22:53]W:	 [Step 1/1]  [0;39;49m
[01:22:53]W:	 [Step 1/1] Process exited with code 201
[01:22:53]E:	 [Step 1/1] Process exited with code 201 (Step: Command Line)

Each failure log is accessible here:
Bitcoin_ABC_unit_tests_with_next_upgrade_activated: util_tests.test_LockDirectory

nakihito planned changes to this revision.Sat, Feb 8, 01:24

Investigating build failures.

nakihito updated this revision to Diff 16249.Tue, Feb 11, 01:38

Rebased.

nakihito planned changes to this revision.Tue, Feb 11, 01:38

Snippet of first build failure:

[01:41:23]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_is_not_directory
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_is_not_relative
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_no_trailing
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_no_trailing2
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] psbt_wallet_tests.psbt_updater_test
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] psbt_wallet_tests.parse_hd_keypath
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.rescan
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.importwallet_rescan
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.coin_mark_dirty_immature_credit
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.ComputeTimeSmart
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.LoadReceiveRequests
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.ListCoins
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.wallet_disableprivkeys
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.write_erase_name
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.write_erase_purpose
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.write_erase_destdata
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.no_dest_fails
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_crypto_tests.passphrase
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_crypto_tests.encrypt
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_crypto_tests.decrypt
[01:42:52] :	 [Step 1/1] Running 454 test cases...
[01:42:52] :	 [Step 1/1] 
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:58]W:	 [Step 1/1] corrupted double-linked list
[01:42:58] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365../src/test/util_tests.cpp(1368):  [1;31;49merror: in "util_tests/test_LockDirectory": check processstatus == 0 has failed [11 != 0] [0;39;49m
[01:43:04]W:	 [Step 1/1] 
[01:43:04]W:	 [Step 1/1]  [1;31;49m*** 1 failure is detected in the test module "Bitcoin ABC unit tests with next upgrade activated"
[01:43:04]W:	 [Step 1/1]  [0;39;49m
[01:43:04]W:	 [Step 1/1] Process exited with code 201
[01:43:04]E:	 [Step 1/1] Process exited with code 201 (Step: Command Line)

Each failure log is accessible here:
Bitcoin_ABC_unit_tests_with_next_upgrade_activated: util_tests.test_LockDirectory

Build Bitcoin-ABC / Diffs / Diff Testing failed. Snippet of first build failure: `lines=16,COUNTEREXAMPLE [01:41:23]i: [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_is_not_directory [01:41:23]i: [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_is_not_relative [01:41:23]i: [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_no_trailing [01:41:23]i: [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_no_trailing2 [01:41:23]i: [Bitcoin_ABC_unit_tests] psbt_wallet_tests.psbt_updater_test [01:41:23]i: [Bitcoin_ABC_unit_tests] psbt_wallet_tests.parse_hd_keypath [01:41:23]i: [Bitcoin_ABC_unit_tests] wallet_tests.rescan [01:41:23]i: [Bitcoin_ABC_unit_tests] wallet_tests.importwallet_rescan [01:41:23]i: [Bitcoin_ABC_unit_tests] wallet_tests.coin_mark_dirty_immature_credit [01:41:23]i: [Bitcoin_ABC_unit_tests] wallet_tests.ComputeTimeSmart [01:41:23]i: [Bitcoin_ABC_unit_tests] wallet_tests.LoadReceiveRequests [01:41:23]i: [Bitcoin_ABC_unit_tests] wallet_tests.ListCoins [01:41:23]i: [Bitcoin_ABC_unit_tests] wallet_tests.wallet_disableprivkeys [01:41:23]i: [Bitcoin_ABC_unit_tests] walletdb_tests.write_erase_name [01:41:23]i: [Bitcoin_ABC_unit_tests] walletdb_tests.write_erase_purpose [01:41:23]i: [Bitcoin_ABC_unit_tests] walletdb_tests.write_erase_destdata [01:41:23]i: [Bitcoin_ABC_unit_tests] walletdb_tests.no_dest_fails [01:41:23]i: [Bitcoin_ABC_unit_tests] wallet_crypto_tests.passphrase [01:41:23]i: [Bitcoin_ABC_unit_tests] wallet_crypto_tests.encrypt [01:41:23]i: [Bitcoin_ABC_unit_tests] wallet_crypto_tests.decrypt [01:42:52] : [Step 1/1] Running 454 test cases... [01:42:52] : [Step 1/1] [01:42:52] : [Step 1/1] Assertion occurred in a following context: [01:42:52] : [Step 1/1] ../src/test/sigcheckcount_tests.cpp:341 [01:42:52] : [Step 1/1] Assertion occurred in a following context: [01:42:52] : [Step 1/1] ../src/test/sigcheckcount_tests.cpp:341 [01:42:52] : [Step 1/1] Assertion occurred in a following context: [01:42:52] : [Step 1/1] ../src/test/sigcheckcount_tests.cpp:341 [01:42:52] : [Step 1/1] Assertion occurred in a following context: [01:42:52] : [Step 1/1] ../src/test/sigcheckcount_tests.cpp:341 [01:42:52] : [Step 1/1] Assertion occurred in a following context: [01:42:52] : [Step 1/1] ../src/test/sigcheckcount_tests.cpp:345 [01:42:52] : [Step 1/1] Assertion occurred in a following context: [01:42:52] : [Step 1/1] ../src/test/sigcheckcount_tests.cpp:345 [01:42:52] : [Step 1/1] Assertion occurred in a following context: [01:42:52] : [Step 1/1] ../src/test/sigcheckcount_tests.cpp:345 [01:42:52] : [Step 1/1] Assertion occurred in a following context: [01:42:52] : [Step 1/1] ../src/test/sigcheckcount_tests.cpp:345 [01:42:52] : [Step 1/1] Assertion occurred in a following context: [01:42:52] : [Step 1/1] ../src/test/sigcheckcount_tests.cpp:355 [01:42:52] : [Step 1/1] Assertion occurred in a following context: [01:42:52] : [Step 1/1] ../src/test/sigcheckcount_tests.cpp:355 [01:42:52] : [Step 1/1] Assertion occurred in a following context: [01:42:52] : [Step 1/1] ../src/test/sigcheckcount_tests.cpp:355 [01:42:52] : [Step 1/1] Assertion occurred in a following context: [01:42:52] : [Step 1/1] ../src/test/sigcheckcount_tests.cpp:355 [01:42:52] : [Step 1/1] Assertion occurred in a following context: [01:42:52] : [Step 1/1] ../src/test/sigcheckcount_tests.cpp:365 [01:42:52] : [Step 1/1] Assertion occurred in a following context: [01:42:52] : [Step 1/1] ../src/test/sigcheckcount_tests.cpp:365 [01:42:52] : [Step 1/1] Assertion occurred in a following context: [01:42:52] : [Step 1/1] ../src/test/sigcheckcount_tests.cpp:365 [01:42:52] : [Step 1/1] Assertion occurred in a following context: [01:42:58]W: [Step 1/1] corrupted double-linked list [01:42:58] : [Step 1/1] ../src/test/sigcheckcount_tests.cpp:365../src/test/util_tests.cpp(1368): [1;31;49merror: in "util_tests/test_LockDirectory": check processstatus == 0 has failed [11 != 0] [0;39;49m [01:43:04]W: [Step 1/1] [01:43:04]W: [Step 1/1] [1;31;49m*** 1 failure is detected in the test module "Bitcoin ABC unit tests with next upgrade activated" [01:43:04]W: [Step 1/1] [0;39;49m [01:43:04]W: [Step 1/1] Process exited with code 201 [01:43:04]E: [Step 1/1] Process exited with code 201 (Step: Command Line) ` Each failure log is accessible here: Bitcoin_ABC_unit_tests_with_next_upgrade_activated: util_tests.test_LockDirectory

hey that's not your diff's fault: see D5232

nakihito requested review of this revision.Tue, Feb 11, 02:43

Snippet of first build failure:

[07:53:27]F:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_LockDirectory
[07:53:27]i:			 [util_tests.test_LockDirectory] [Test Error Output]
Failures detected in:
- test case: util_tests/test_LockDirectory
- file: util_tests.cpp
- line: 1290
[07:53:27]F:			 [util_tests.test_LockDirectory] assertion error: failure
[07:53:27]F:			 [util_tests.test_LockDirectory] ASSERTION FAILURE:
- file   : util_tests.cpp
- line   : 1368
- message: check processstatus == 0 has failed [11 != 0]
[07:53:28]E:	 [Step 1/1] Failed tests detected
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_DirIsWritable
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_ConvertBits
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_ToLower
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_ToUpper
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_Capitalize
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] validation_block_tests.processnewblock_signals_ordering
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] validation_tests.block_subsidy_test
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] validation_tests.subsidy_limit_test
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] validation_tests.validation_load_external_block_file
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] versionbits_tests.versionbits_test
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] versionbits_tests.versionbits_computeblockversion
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] work_comparator_tests.work_comparator
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] server_tests.server_IsDeprecatedRPCEnabled
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] accounting_tests.acc_orderupgrade
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] db_tests.getwalletenv_file
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] db_tests.getwalletenv_directory
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] db_tests.getwalletenv_g_dbenvs_multiple
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] db_tests.getwalletenv_g_dbenvs_free_instance
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] coinselector_tests.bnb_search_test
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] coinselector_tests.knapsack_solver_test
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] coinselector_tests.ApproximateBestSubset
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] coinselector_tests.SelectCoins_test
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_default
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_custom
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_does_not_exist
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_is_not_directory
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_is_not_relative
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_no_trailing
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_no_trailing2
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] psbt_wallet_tests.psbt_updater_test
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] psbt_wallet_tests.parse_hd_keypath
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.rescan
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.importwallet_rescan
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.coin_mark_dirty_immature_credit
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.ComputeTimeSmart
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.LoadReceiveRequests
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.ListCoins
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.wallet_disableprivkeys
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] walletdb_tests.write_erase_name
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] walletdb_tests.write_erase_purpose
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] walletdb_tests.write_erase_destdata
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] walletdb_tests.no_dest_fails
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_crypto_tests.passphrase
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_crypto_tests.encrypt
[07:53:27]i:		 [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_crypto_tests.decrypt
[07:53:27]W:	 [Step 1/1]  [0;39;49m
[07:53:27]W:	 [Step 1/1] Process exited with code 201
[07:53:28]E:	 [Step 1/1] Process exited with code 201 (Step: Command Line)

Each failure log is accessible here:
Bitcoin_ABC_unit_tests_with_next_upgrade_activated: util_tests.test_LockDirectory

Geez this bug really hates this diff ... o_O

Snippet of first build failure:

[08:00:18]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_is_not_directory
[08:00:18]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_is_not_relative
[08:00:18]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_no_trailing
[08:00:18]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_no_trailing2
[08:00:18]i:		 [Bitcoin_ABC_unit_tests] psbt_wallet_tests.psbt_updater_test
[08:00:18]i:		 [Bitcoin_ABC_unit_tests] psbt_wallet_tests.parse_hd_keypath
[08:00:18]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.rescan
[08:00:18]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.importwallet_rescan
[08:00:18]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.coin_mark_dirty_immature_credit
[08:00:18]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.ComputeTimeSmart
[08:00:18]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.LoadReceiveRequests
[08:00:18]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.ListCoins
[08:00:18]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.wallet_disableprivkeys
[08:00:18]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.write_erase_name
[08:00:18]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.write_erase_purpose
[08:00:18]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.write_erase_destdata
[08:00:18]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.no_dest_fails
[08:00:18]i:		 [Bitcoin_ABC_unit_tests] wallet_crypto_tests.passphrase
[08:00:18]i:		 [Bitcoin_ABC_unit_tests] wallet_crypto_tests.encrypt
[08:00:18]i:		 [Bitcoin_ABC_unit_tests] wallet_crypto_tests.decrypt
[08:01:44] :	 [Step 1/1] Running 454 test cases...
[08:01:44] :	 [Step 1/1] 
[08:01:44] :	 [Step 1/1] Assertion occurred in a following context:
[08:01:44] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[08:01:44] :	 [Step 1/1] Assertion occurred in a following context:
[08:01:44] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[08:01:44] :	 [Step 1/1] Assertion occurred in a following context:
[08:01:44] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[08:01:44] :	 [Step 1/1] Assertion occurred in a following context:
[08:01:44] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[08:01:44] :	 [Step 1/1] Assertion occurred in a following context:
[08:01:44] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[08:01:44] :	 [Step 1/1] Assertion occurred in a following context:
[08:01:44] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[08:01:44] :	 [Step 1/1] Assertion occurred in a following context:
[08:01:44] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[08:01:44] :	 [Step 1/1] Assertion occurred in a following context:
[08:01:44] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[08:01:44] :	 [Step 1/1] Assertion occurred in a following context:
[08:01:44] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[08:01:44] :	 [Step 1/1] Assertion occurred in a following context:
[08:01:44] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[08:01:44] :	 [Step 1/1] Assertion occurred in a following context:
[08:01:44] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[08:01:44] :	 [Step 1/1] Assertion occurred in a following context:
[08:01:44] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[08:01:44] :	 [Step 1/1] Assertion occurred in a following context:
[08:01:44] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365
[08:01:44] :	 [Step 1/1] Assertion occurred in a following context:
[08:01:44] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365
[08:01:44] :	 [Step 1/1] Assertion occurred in a following context:
[08:01:44] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365
[08:01:44] :	 [Step 1/1] Assertion occurred in a following context:
[08:01:50]W:	 [Step 1/1] corrupted double-linked list
[08:01:50] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365../src/test/util_tests.cpp(1368):  [1;31;49merror: in "util_tests/test_LockDirectory": check processstatus == 0 has failed [11 != 0] [0;39;49m
[08:01:56]W:	 [Step 1/1] 
[08:01:56]W:	 [Step 1/1]  [1;31;49m*** 1 failure is detected in the test module "Bitcoin ABC unit tests with next upgrade activated"
[08:01:56]W:	 [Step 1/1]  [0;39;49m
[08:01:56]W:	 [Step 1/1] Process exited with code 201
[08:01:56]E:	 [Step 1/1] Process exited with code 201 (Step: Command Line)

Each failure log is accessible here:
Bitcoin_ABC_unit_tests_with_next_upgrade_activated: util_tests.test_LockDirectory

Snippet of first build failure:

[08:04:03]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_is_not_directory
[08:04:03]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_is_not_relative
[08:04:03]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_no_trailing
[08:04:03]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_no_trailing2
[08:04:03]i:		 [Bitcoin_ABC_unit_tests] psbt_wallet_tests.psbt_updater_test
[08:04:03]i:		 [Bitcoin_ABC_unit_tests] psbt_wallet_tests.parse_hd_keypath
[08:04:03]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.rescan
[08:04:03]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.importwallet_rescan
[08:04:03]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.coin_mark_dirty_immature_credit
[08:04:03]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.ComputeTimeSmart
[08:04:03]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.LoadReceiveRequests
[08:04:03]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.ListCoins
[08:04:03]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.wallet_disableprivkeys
[08:04:03]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.write_erase_name
[08:04:03]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.write_erase_purpose
[08:04:03]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.write_erase_destdata
[08:04:03]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.no_dest_fails
[08:04:03]i:		 [Bitcoin_ABC_unit_tests] wallet_crypto_tests.passphrase
[08:04:03]i:		 [Bitcoin_ABC_unit_tests] wallet_crypto_tests.encrypt
[08:04:03]i:		 [Bitcoin_ABC_unit_tests] wallet_crypto_tests.decrypt
[08:05:43] :	 [Step 1/1] Running 454 test cases...
[08:05:43] :	 [Step 1/1] 
[08:05:43] :	 [Step 1/1] Assertion occurred in a following context:
[08:05:43] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[08:05:43] :	 [Step 1/1] Assertion occurred in a following context:
[08:05:43] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[08:05:43] :	 [Step 1/1] Assertion occurred in a following context:
[08:05:43] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[08:05:43] :	 [Step 1/1] Assertion occurred in a following context:
[08:05:43] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[08:05:43] :	 [Step 1/1] Assertion occurred in a following context:
[08:05:43] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[08:05:43] :	 [Step 1/1] Assertion occurred in a following context:
[08:05:43] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[08:05:43] :	 [Step 1/1] Assertion occurred in a following context:
[08:05:43] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[08:05:43] :	 [Step 1/1] Assertion occurred in a following context:
[08:05:43] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[08:05:43] :	 [Step 1/1] Assertion occurred in a following context:
[08:05:43] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[08:05:43] :	 [Step 1/1] Assertion occurred in a following context:
[08:05:43] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[08:05:43] :	 [Step 1/1] Assertion occurred in a following context:
[08:05:43] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[08:05:43] :	 [Step 1/1] Assertion occurred in a following context:
[08:05:43] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[08:05:43] :	 [Step 1/1] Assertion occurred in a following context:
[08:05:43] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365
[08:05:43] :	 [Step 1/1] Assertion occurred in a following context:
[08:05:43] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365
[08:05:43] :	 [Step 1/1] Assertion occurred in a following context:
[08:05:43] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365
[08:05:43] :	 [Step 1/1] Assertion occurred in a following context:
[08:05:50]W:	 [Step 1/1] corrupted double-linked list
[08:05:50] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365../src/test/util_tests.cpp(1368):  [1;31;49merror: in "util_tests/test_LockDirectory": check processstatus == 0 has failed [11 != 0] [0;39;49m
[08:05:57]W:	 [Step 1/1] 
[08:05:57]W:	 [Step 1/1]  [1;31;49m*** 1 failure is detected in the test module "Bitcoin ABC unit tests with next upgrade activated"
[08:05:57]W:	 [Step 1/1]  [0;39;49m
[08:05:57]W:	 [Step 1/1] Process exited with code 201
[08:05:57]E:	 [Step 1/1] Process exited with code 201 (Step: Command Line)

Each failure log is accessible here:
Bitcoin_ABC_unit_tests_with_next_upgrade_activated: util_tests.test_LockDirectory

Should be fixed now by D5254, please rebase.

nakihito updated this revision to Diff 16292.Tue, Feb 11, 16:51

Rebased.

jasonbcox requested changes to this revision.Wed, Feb 12, 00:44
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/rpc/net.cpp
841 ↗(On Diff #16292)

function-style casting

This revision now requires changes to proceed.Wed, Feb 12, 00:44
nakihito updated this revision to Diff 16311.Wed, Feb 12, 00:46

Functional style casting.

jasonbcox accepted this revision.Wed, Feb 12, 17:27
This revision is now accepted and ready to land.Wed, Feb 12, 17:27