- User Since
- Sep 6 2017, 16:08 (123 w, 2 d)
Fixes according to feedback:
- Merge common lines into a single step
- Fix file verification step when the working directory isn't clean
Rebase on D5008
Beat me to it. For posterity, this was missed in D4698
Fix sloppy includes merge
For posterity: the failed run was on the wrong build agent and should be ignored. The resource intensive build passed as expected.
Thu, Jan 16
test plan needs TSAN not Werror
werror doesn't test anything interesting here. What you want is TSAN (thread sanitizer)
Fabien took care of the revert in this diff: D4959
Something appears to be flaky that is unrelated. Hopefully we'll see more info on CI soon, because that last failed build was missing some logs (log issue is now fixed).
Wed, Jan 15
We had discussed offline about adding the commandline args to the junit name to make it obvious which test run it was. Any reason why you didn't include this? I think it drastically improves the usability of this fix.
Tue, Jan 14
Sanitizer tests look ok to me.
It's important to note that CI sets tmpdir to be within the build dir, so the CI can find these reports. Otherwise, reviewers may mistakenly believe the junit_reports will end up in /tmp/ on CI.
Mon, Jan 13
This diff makes it 2 different configurations instead, making it easier to follow and easier to maintain.
- Use versioned keys.txt file from bitcoinabc.org or github.com depending on availability by version.
- Fixed a bug where the script would break on multiple signature files.
Sun, Jan 12
Sat, Jan 11
Make the patterns less greedy by including a weak requirement for version number
Fri, Jan 10
Switch backticks in section 3 to a link
Everything looks good except for the one missed line in the comment.
Embarrassing I forgot about this: D2286
Thu, Jan 9
Wed, Jan 8
Please write a runnable test plan.
Nit: I would prefer quoted echo statements, but this is probably best left to a linter.
Tue, Jan 7
Remove erroneously copied release note from the archived note file