Page MenuHomePhabricator

jasonbcox (Jason Cox)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Sep 6 2017, 16:08 (127 w, 4 d)
Roles
Administrator
Slack Username
jasonbcox

Recent Activity

Yesterday

jasonbcox committed rABCa64244c3a727: Update manpages for 0.21.0 release (authored by jasonbcox).
Update manpages for 0.21.0 release
Sun, Feb 16, 04:29
jasonbcox closed D5287: Update manpages for 0.21.0 release.
Sun, Feb 16, 04:29
jasonbcox committed rABCf265c59f93da: Add missing items to release-notes + formatting fixups (authored by jasonbcox).
Add missing items to release-notes + formatting fixups
Sun, Feb 16, 04:28
jasonbcox closed D5293: Add missing items to release-notes + formatting fixups.
Sun, Feb 16, 04:28
jasonbcox updated the diff for D5293: Add missing items to release-notes + formatting fixups.

Rebase

Sun, Feb 16, 04:12
jasonbcox committed rABCc4fd03771c42: Bump automatic replay protection to Nov 2020 upgrade (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>).
Bump automatic replay protection to Nov 2020 upgrade
Sun, Feb 16, 04:11
jasonbcox closed D5253: Bump automatic replay protection to Nov 2020 upgrade.
Sun, Feb 16, 04:10
jasonbcox committed rABC13b62df93f33: Change version to 0.21.0 (authored by jasonbcox).
Change version to 0.21.0
Sun, Feb 16, 03:59
jasonbcox closed D5289: Change version to 0.21.0.
Sun, Feb 16, 03:59
jasonbcox updated the diff for D5293: Add missing items to release-notes + formatting fixups.

Added IFP

Sun, Feb 16, 03:53
jasonbcox accepted D5300: [sigcheck] Add per tx limit.
Sun, Feb 16, 03:48
jasonbcox requested changes to D5300: [sigcheck] Add per tx limit.
Sun, Feb 16, 03:42

Sat, Feb 15

jasonbcox accepted D5299: [ConnectBlock] Use an index to refers into blockundo.vtxundo rather than pusing as we go.
Sat, Feb 15, 17:42
jasonbcox accepted D5298: [sigcheck] Remove redundant sigcheck in CheckInputs.
Sat, Feb 15, 17:42
jasonbcox commandeered D5253: Bump automatic replay protection to Nov 2020 upgrade.
Sat, Feb 15, 17:23
jasonbcox updated the diff for D5293: Add missing items to release-notes + formatting fixups.

Update SigChecks note

Sat, Feb 15, 17:22
jasonbcox requested changes to D5299: [ConnectBlock] Use an index to refers into blockundo.vtxundo rather than pusing as we go.
Sat, Feb 15, 17:02
jasonbcox requested changes to D5298: [sigcheck] Remove redundant sigcheck in CheckInputs.

There's a comment regarding this behavior in validation.h:490 that needs updating.

Sat, Feb 15, 16:54

Fri, Feb 14

jasonbcox accepted D5292: Merge #12079: Improve prioritisetransaction test coverage.
Fri, Feb 14, 23:47
jasonbcox added a comment to D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.

In the interest of time, I'm not going to block this diff, but this really needs some release notes attached. Feel free to incorporate the SigCheck note that I started in D5179

Fri, Feb 14, 23:44
jasonbcox added inline comments to D5293: Add missing items to release-notes + formatting fixups.
Fri, Feb 14, 23:44
jasonbcox created D5293: Add missing items to release-notes + formatting fixups.
Fri, Feb 14, 23:43
jasonbcox added a comment to D5282: Implement miner funding features.

Also, add a release note.

Fri, Feb 14, 23:34
jasonbcox accepted D5282: Implement miner funding features.
Fri, Feb 14, 21:20
jasonbcox accepted D5244: Enable new ancestor/descendants chains limit at fork.
Fri, Feb 14, 21:15
jasonbcox created D5291: Move build_* wrapper scripts to devtools.
Fri, Feb 14, 20:06
jasonbcox created D5290: Move github-release to appropriate contrib sub-directory.
Fri, Feb 14, 19:46
jasonbcox requested changes to D5245: [qa] Test that mempool reverts to pre-phonon policies.

Just pointing out that not including this as part of D5244 makes getting this feature in more difficult, since both patches will need to be reviewed green by potentially different sets of people (and preferably landed very soon one after the other).

Fri, Feb 14, 18:11
jasonbcox retitled D5287: Update manpages for 0.21.0 release from Update manpages for 0.20.13 release to Update manpages for 0.21.0 release.
Fri, Feb 14, 17:41
jasonbcox updated the diff for D5287: Update manpages for 0.21.0 release.

Changed 0.20.13 -> 0.21.0

Fri, Feb 14, 17:41
jasonbcox requested changes to D5282: Implement miner funding features.

The test has a lot of magic numbers that can be cleaned up. My focus is mostly on the timestamps, which have some relationship to each other (modifications to the test become a pain otherwise). The period and threshold are less important IMO.

Fri, Feb 14, 17:38
jasonbcox created D5289: Change version to 0.21.0.
Fri, Feb 14, 17:13
jasonbcox planned changes to D5287: Update manpages for 0.21.0 release.
Fri, Feb 14, 16:50
jasonbcox committed rABC6af55e8d098f: Add --commit to automated-commits to make local testing easier (authored by jasonbcox).
Add --commit to automated-commits to make local testing easier
Fri, Feb 14, 16:46
jasonbcox closed D5269: Add --commit to automated-commits to make local testing easier.
Fri, Feb 14, 16:46
jasonbcox committed rABC65e498b71699: Update seeds (authored by jasonbcox).
Update seeds
Fri, Feb 14, 16:44
jasonbcox closed D5286: Update seeds.
Fri, Feb 14, 16:43
jasonbcox created D5287: Update manpages for 0.21.0 release.
Fri, Feb 14, 00:43
jasonbcox created D5286: Update seeds.
Fri, Feb 14, 00:24
jasonbcox closed D5285: Fix exit behavior in test-seeds.
Fri, Feb 14, 00:16
jasonbcox committed rABC0635d24b76c9: Fix exit behavior in test-seeds (authored by jasonbcox).
Fix exit behavior in test-seeds
Fri, Feb 14, 00:16
jasonbcox updated the diff for D5269: Add --commit to automated-commits to make local testing easier.

Fixed confusing double-negative

Fri, Feb 14, 00:16

Thu, Feb 13

jasonbcox added inline comments to D5269: Add --commit to automated-commits to make local testing easier.
Thu, Feb 13, 20:52
jasonbcox created D5285: Fix exit behavior in test-seeds.
Thu, Feb 13, 20:52
jasonbcox updated the test plan for D5269: Add --commit to automated-commits to make local testing easier.
Thu, Feb 13, 20:49
jasonbcox updated the diff for D5269: Add --commit to automated-commits to make local testing easier.
  • Fixes according to feedback
  • Small refactor so error messages will appear early
  • Rename --commit to --parent since this is more self explanatory. Associated variable names changed as well.
Thu, Feb 13, 20:48
jasonbcox added inline comments to D5270: Make all automated commits run smoke tests prior to pushing.
Thu, Feb 13, 20:29
jasonbcox added inline comments to D5282: Implement miner funding features.
Thu, Feb 13, 19:55
jasonbcox requested changes to D5282: Implement miner funding features.
Thu, Feb 13, 19:43
jasonbcox added a comment to D5282: Implement miner funding features.

Teamcity is not able to post build failures here unless it's given permission (it's not part of Bitcoin ABC group) -- if you want that you have to add it to policy as a second entry.
https://build.bitcoinabc.org/viewLog.html?buildId=29215&buildTypeId=BitcoinABC_BitcoinAbcStaging&tab=buildResultsDiv

Thu, Feb 13, 17:32
jasonbcox closed T573: Build Bitcoin-ABC / Master / Initial Block Download w/o Checkpoints is broken. as Resolved.
Thu, Feb 13, 17:27
jasonbcox closed T628: Build Bitcoin-ABC / Master / Initial Block Download is broken. as Resolved.
Thu, Feb 13, 17:27
jasonbcox closed T668: Build Bitcoin-ABC / Master / Gitian Builds / Nightly - Linux is broken. as Resolved.
Thu, Feb 13, 17:27
jasonbcox closed T672: Build Bitcoin-ABC / Master / Gitian Builds / Nightly - OSX is broken. as Resolved.
Thu, Feb 13, 17:27
jasonbcox closed T740: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Master TSAN is broken. as Resolved.
Thu, Feb 13, 17:27
jasonbcox closed T741: Build Bitcoin-ABC / Master / Bitcoin-ABC Master UBSAN is broken. as Resolved.
Thu, Feb 13, 17:26
jasonbcox committed rABC7f63be6a4ba6: Fix a race condition with rpc ports in check-seeds (authored by jasonbcox).
Fix a race condition with rpc ports in check-seeds
Thu, Feb 13, 16:49
jasonbcox closed D5268: Fix a race condition with rpc ports in check-seeds.
Thu, Feb 13, 16:49

Wed, Feb 12

jasonbcox accepted D5214: Merge #13152: [rpc] Add getnodeaddresses RPC command.
Wed, Feb 12, 17:27
jasonbcox accepted D4436: Add unit tests for CSeederNode::ProcessMessage().
Wed, Feb 12, 17:23
jasonbcox requested changes to D4436: Add unit tests for CSeederNode::ProcessMessage().

Looking much better. Please review the includes, because I don't want to dig into all of them.

Wed, Feb 12, 01:43
jasonbcox accepted D5271: Merge #14310: [wallet] Ensure wallet is unlocked before signing.
Wed, Feb 12, 01:04
jasonbcox requested changes to D5214: Merge #13152: [rpc] Add getnodeaddresses RPC command.
Wed, Feb 12, 00:44
jasonbcox updated the test plan for D5269: Add --commit to automated-commits to make local testing easier.
Wed, Feb 12, 00:39
jasonbcox created D5270: Make all automated commits run smoke tests prior to pushing.
Wed, Feb 12, 00:38
jasonbcox created D5269: Add --commit to automated-commits to make local testing easier.
Wed, Feb 12, 00:34

Tue, Feb 11

jasonbcox requested review of D5268: Fix a race condition with rpc ports in check-seeds.
Tue, Feb 11, 22:35
jasonbcox requested changes to D5244: Enable new ancestor/descendants chains limit at fork.

Needs an update in doc/release-notes.md

Tue, Feb 11, 22:30
jasonbcox added inline comments to D5244: Enable new ancestor/descendants chains limit at fork.
Tue, Feb 11, 22:25
jasonbcox planned changes to D5268: Fix a race condition with rpc ports in check-seeds.
Tue, Feb 11, 22:13
jasonbcox created D5268: Fix a race condition with rpc ports in check-seeds.
Tue, Feb 11, 22:13
jasonbcox accepted D5243: Add new post-fork ancestor and descendants limit..
Tue, Feb 11, 22:09
jasonbcox committed rABC5b6f369672e7: Use a temporary datadir and non-default RPC port when testing seeds (authored by jasonbcox).
Use a temporary datadir and non-default RPC port when testing seeds
Tue, Feb 11, 19:37
jasonbcox closed D5246: Use a temporary datadir and non-default RPC port when testing seeds.
Tue, Feb 11, 19:37
jasonbcox committed rABC0e76b141405d: Remove updating chainparams from release process (authored by jasonbcox).
Remove updating chainparams from release process
Tue, Feb 11, 19:36
jasonbcox closed D5250: Remove updating chainparams from release process.
Tue, Feb 11, 19:36
jasonbcox created D5250: Remove updating chainparams from release process.
Tue, Feb 11, 01:57
jasonbcox accepted D5241: Make parse_name() properly fail when the query name is longer than 255 characters.
Tue, Feb 11, 00:28
jasonbcox accepted D5247: [cmake] Add the suite name to the test runner..
Tue, Feb 11, 00:26
jasonbcox updated the test plan for D5246: Use a temporary datadir and non-default RPC port when testing seeds.
Tue, Feb 11, 00:25

Mon, Feb 10

jasonbcox planned changes to D5248: Add update-seeds to automated-commits.
Mon, Feb 10, 23:53
jasonbcox created D5248: Add update-seeds to automated-commits.
Mon, Feb 10, 23:53
jasonbcox requested review of D5246: Use a temporary datadir and non-default RPC port when testing seeds.
Mon, Feb 10, 23:34
jasonbcox planned changes to D5246: Use a temporary datadir and non-default RPC port when testing seeds.
Mon, Feb 10, 23:33
jasonbcox created D5246: Use a temporary datadir and non-default RPC port when testing seeds.
Mon, Feb 10, 23:10
jasonbcox added inline comments to D5243: Add new post-fork ancestor and descendants limit..
Mon, Feb 10, 22:34
jasonbcox added inline comments to D5243: Add new post-fork ancestor and descendants limit..
Mon, Feb 10, 22:32
jasonbcox requested changes to D4436: Add unit tests for CSeederNode::ProcessMessage().
Mon, Feb 10, 22:23
jasonbcox requested changes to D5241: Make parse_name() properly fail when the query name is longer than 255 characters.
Mon, Feb 10, 22:04
jasonbcox renamed abc-bot-borked from abc-bot to abc-bot-borked.
Mon, Feb 10, 19:55
jasonbcox committed rABC9241317208b7: Add a script for building and pushing automated commits (authored by jasonbcox).
Add a script for building and pushing automated commits
Mon, Feb 10, 18:11
jasonbcox closed D5045: Add a script for building and pushing automated commits.
Mon, Feb 10, 18:11
jasonbcox updated the diff for D5045: Add a script for building and pushing automated commits.

OKAY -> exit code check
Also expanded the test plan

Mon, Feb 10, 17:51
jasonbcox updated the test plan for D5045: Add a script for building and pushing automated commits.
Mon, Feb 10, 17:50
jasonbcox updated the test plan for D5045: Add a script for building and pushing automated commits.
Mon, Feb 10, 17:49
jasonbcox updated the test plan for D5045: Add a script for building and pushing automated commits.
Mon, Feb 10, 17:49
jasonbcox updated the test plan for D5045: Add a script for building and pushing automated commits.
Mon, Feb 10, 17:48

Sat, Feb 8

jasonbcox accepted D5221: Make STANDARD_SCRIPT_VERIFY_FLAGS explicit.
Sat, Feb 8, 20:56
jasonbcox accepted D5222: remove MANDATORY_SCRIPT_VERIFY_FLAGS in favour of explicit forgiveness flags.
Sat, Feb 8, 20:55
jasonbcox accepted D5220: Make standard flags based off consensus flags.
Sat, Feb 8, 20:44