- User Since
- Sep 6 2017, 16:08 (127 w, 4 d)
- Slack Username
Sat, Feb 15
Update SigChecks note
There's a comment regarding this behavior in validation.h:490 that needs updating.
Fri, Feb 14
In the interest of time, I'm not going to block this diff, but this really needs some release notes attached. Feel free to incorporate the SigCheck note that I started in D5179
Also, add a release note.
Just pointing out that not including this as part of D5244 makes getting this feature in more difficult, since both patches will need to be reviewed green by potentially different sets of people (and preferably landed very soon one after the other).
Changed 0.20.13 -> 0.21.0
The test has a lot of magic numbers that can be cleaned up. My focus is mostly on the timestamps, which have some relationship to each other (modifications to the test become a pain otherwise). The period and threshold are less important IMO.
Fixed confusing double-negative
Thu, Feb 13
- Fixes according to feedback
- Small refactor so error messages will appear early
- Rename --commit to --parent since this is more self explanatory. Associated variable names changed as well.
Wed, Feb 12
Looking much better. Please review the includes, because I don't want to dig into all of them.
Tue, Feb 11
Needs an update in doc/release-notes.md
Mon, Feb 10
OKAY -> exit code check
Also expanded the test plan