Page MenuHomePhabricator

jasonbcox (Jason Cox)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Sep 6 2017, 16:08 (142 w, 5 d)
Roles
Administrator
Slack Username
jasonbcox

Recent Activity

Today

jasonbcox accepted D6316: Merge #16481: Trivial: add missing space.
Mon, Jun 1, 17:37
jasonbcox updated the diff for D6264: Add arcanist land bot workflow.
  • Check that gpg is installed
  • Unset unencrypted Conduit token after use
Mon, Jun 1, 17:36
jasonbcox accepted D6313: [CMAKE] Rename secp256k1 test targets.
Mon, Jun 1, 16:20
jasonbcox added inline comments to D6314: [CI] Install Clang 10 and use it for the werror build.
Mon, Jun 1, 16:08
jasonbcox committed rABC9fc0ab8ec1ea: Add land bot dependencies to base image setup script (authored by jasonbcox).
Add land bot dependencies to base image setup script
Mon, Jun 1, 16:06
jasonbcox closed D6265: Add land bot dependencies to base image setup script.
Mon, Jun 1, 16:05
jasonbcox committed rABC1f965f78f94d: Generate assumed blockchain and chainstate disk sizes when updating chainparams (authored by jasonbcox).
Generate assumed blockchain and chainstate disk sizes when updating chainparams
Mon, Jun 1, 15:21
jasonbcox closed D6289: Generate assumed blockchain and chainstate disk sizes when updating chainparams.
Mon, Jun 1, 15:21
jasonbcox updated the test plan for D6289: Generate assumed blockchain and chainstate disk sizes when updating chainparams.
Mon, Jun 1, 15:21

Sat, May 30

jasonbcox committed rABC7df5863a2333: Merge #15345: net: Correct comparison of addr count (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #15345: net: Correct comparison of addr count
Sat, May 30, 00:43
jasonbcox closed D6301: Merge #15345: net: Correct comparison of addr count.
Sat, May 30, 00:43
jasonbcox retitled D6265: Add land bot dependencies to base image setup script from Add base image setup script for the land bot to Add land bot dependencies to base image setup script.
Sat, May 30, 00:41
jasonbcox updated the diff for D6265: Add land bot dependencies to base image setup script.

Update same base image used for CI builds rather than introducing a new one.

Sat, May 30, 00:39

Fri, May 29

jasonbcox requested review of D6301: Merge #15345: net: Correct comparison of addr count.
Fri, May 29, 22:31
jasonbcox added a comment to D6291: [SECP256K1] Fix -Wmaybe-uninitialized in tests.

I would rather avoid taking ownership of this. The part of libsecp256k1 we have ownership over are very well delimited and separated from the rest of the codebase. IMO this is a feature.

I would suggest you go about this by either:

  • Disable this warning for libsecp256k1 and report the problem upstream.
  • Submit a patch upstream.
Fri, May 29, 21:53
jasonbcox planned changes to D6265: Add land bot dependencies to base image setup script.
Fri, May 29, 21:52
jasonbcox accepted D6268: [wallet] abort when attempting to fund a transaction above maxtxfee.
Fri, May 29, 21:51
jasonbcox added inline comments to D6290: Remove CBlockIndex::SetNull.
Fri, May 29, 21:51
jasonbcox requested changes to D6268: [wallet] abort when attempting to fund a transaction above maxtxfee.
Fri, May 29, 21:33
jasonbcox added a comment to D6265: Add land bot dependencies to base image setup script.

Why would we want the land bot to use different dependencies that CI builds?

Fri, May 29, 20:58
jasonbcox requested changes to D6294: [backport#14599] Use functions guaranteed to be locale independent.

Are the missed changes in LocaleDependenceLinter due to missing backports? If so, why not do those first?

Fri, May 29, 20:26
jasonbcox committed rABCd5188dc324c4: Bump version to 0.21.9 (authored by jasonbcox).
Bump version to 0.21.9
Fri, May 29, 20:21
jasonbcox closed D6298: Bump version to 0.21.9.
Fri, May 29, 20:20
jasonbcox added a comment to D6298: Bump version to 0.21.9.

Should probably start including checking the seeder version?

Fri, May 29, 20:19
jasonbcox accepted D6299: Fix WSL file locking by using flock instead of fcntl.
Fri, May 29, 20:19
jasonbcox requested review of D6298: Bump version to 0.21.9.
Fri, May 29, 19:20
jasonbcox updated the diff for D6289: Generate assumed blockchain and chainstate disk sizes when updating chainparams.

Fixed output ordering issue + tests

Fri, May 29, 18:46
jasonbcox added inline comments to D6289: Generate assumed blockchain and chainstate disk sizes when updating chainparams.
Fri, May 29, 01:13
jasonbcox requested review of D6289: Generate assumed blockchain and chainstate disk sizes when updating chainparams.
Fri, May 29, 01:12
jasonbcox committed rABCd00c0ae750cd: Fixup release notes (authored by jasonbcox).
Fixup release notes
Fri, May 29, 00:38
jasonbcox closed D6280: Fixup release notes.
Fri, May 29, 00:38

Thu, May 28

jasonbcox requested review of D6280: Fixup release notes.
Thu, May 28, 17:39

Wed, May 27

jasonbcox requested changes to D6268: [wallet] abort when attempting to fund a transaction above maxtxfee.
Wed, May 27, 16:21
jasonbcox accepted D6267: [wallet] Move maxTxFee to wallet.
Wed, May 27, 16:14
jasonbcox accepted D6266: rpc: Uncouple non-wallet rpcs from maxTxFee global.
Wed, May 27, 16:01
jasonbcox requested review of D6265: Add land bot dependencies to base image setup script.
Wed, May 27, 00:33

Tue, May 26

jasonbcox updated the summary of D6264: Add arcanist land bot workflow.
Tue, May 26, 23:00
jasonbcox requested review of D6264: Add arcanist land bot workflow.
Tue, May 26, 22:57

Fri, May 22

jasonbcox planned changes to D6234: WIP arcanist land bot workflow.
Fri, May 22, 21:53
jasonbcox requested review of D6234: WIP arcanist land bot workflow.
Fri, May 22, 21:53

Thu, May 21

jasonbcox accepted D6203: [CI] Disable unsupported qemu feature by bypassing the configuration.
Thu, May 21, 19:54
jasonbcox committed rABCa382f87da683: Merge #17469: test: Remove fragile assert_memory_usage_stable (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #17469: test: Remove fragile assert_memory_usage_stable
Thu, May 21, 19:06
jasonbcox closed D6202: Merge #17469: test: Remove fragile assert_memory_usage_stable.
Thu, May 21, 19:06
jasonbcox added inline comments to D6202: Merge #17469: test: Remove fragile assert_memory_usage_stable.
Thu, May 21, 18:26
jasonbcox requested review of D6202: Merge #17469: test: Remove fragile assert_memory_usage_stable.
Thu, May 21, 17:53
jasonbcox added inline comments to D6202: Merge #17469: test: Remove fragile assert_memory_usage_stable.
Thu, May 21, 17:53
jasonbcox planned changes to D6202: Merge #17469: test: Remove fragile assert_memory_usage_stable.
Thu, May 21, 17:50
jasonbcox requested review of D6202: Merge #17469: test: Remove fragile assert_memory_usage_stable.
Thu, May 21, 17:49
jasonbcox committed rABCc6a0647adabe: Merge #14522: tests: add invalid P2P message tests (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #14522: tests: add invalid P2P message tests
Thu, May 21, 16:40
jasonbcox closed D6178: Merge #14522: tests: add invalid P2P message tests.
Thu, May 21, 16:40
jasonbcox committed rABCcfb493b7a1a7: [land-bot] Improve error reporting when fetching revision status fails (authored by jasonbcox).
[land-bot] Improve error reporting when fetching revision status fails
Thu, May 21, 16:35
jasonbcox closed D6143: [land-bot] Improve error reporting when fetching revision status fails.
Thu, May 21, 16:34
jasonbcox updated the diff for D6178: Merge #14522: tests: add invalid P2P message tests.

Fix nits

Thu, May 21, 16:26
jasonbcox updated the diff for D6016: Test patch; please do NOT review.

Rebase

Thu, May 21, 00:29
jasonbcox planned changes to D6016: Test patch; please do NOT review.
Thu, May 21, 00:29

Wed, May 20

jasonbcox abandoned D5123: [Review ONLY] Migrate abcbot codebase into the ABC repo.
Wed, May 20, 23:04
jasonbcox accepted D6175: [backport#16106] refactor: Rename getWallets to getOpenWallets in WalletController.
Wed, May 20, 22:52
jasonbcox accepted D6183: [backport#16348] qt: Assert QMetaObject::invokeMethod result.
Wed, May 20, 22:51
jasonbcox accepted D6181: [backport#16348] gui: Fix missing qRegisterMetaType(WalletModel*).

Talked offline to clear up when splitting up backports is reasonable. Since there's a large stack we'll let it slide for now.

Wed, May 20, 22:46
jasonbcox accepted D6180: [backport#15091] Qt: Fix update headers-count.
Wed, May 20, 22:45
jasonbcox accepted D6179: [backport#15091] Qt: update header count regardless of update delay.
Wed, May 20, 22:44
jasonbcox accepted D6177: [backport#15462] gui: Fix async open wallet call order.
Wed, May 20, 22:38
jasonbcox requested changes to D6181: [backport#16348] gui: Fix missing qRegisterMetaType(WalletModel*).

Any reason to not do the whole backport?

Wed, May 20, 22:37
jasonbcox accepted D6172: [backport#16231] gui: Fix open wallet menu initialization order.
Wed, May 20, 21:45
jasonbcox accepted D6174: [backport#16106] gui: Sort wallets in open wallet menu.
Wed, May 20, 21:43
jasonbcox accepted D6173: Removed activation logic for OP_REVERSEBYTES to pretend it was always enabled.

Thanks for cleaning this up :)

Wed, May 20, 21:26
jasonbcox requested changes to D6127: Add options to seeder to determine initial seed list at start up.

My original feedback still hasn't been entirely incorporated. Look at the name (-connect) and the description you've given it (essentially: "do some things related to seed lists but say absolutely nothing about connecting"). This is incredibly confusing for a user that has no idea how a seeder works. They know nothing about any default seeds.

Wed, May 20, 21:15
jasonbcox added a comment to D6178: Merge #14522: tests: add invalid P2P message tests.

abc-invalid-message will eventually be replaced by p2p_invalid_messages once we've backported all of the test cases. But as of this patch, it still provides test coverage that p2p_invalid_messages does not.

Wed, May 20, 21:11
jasonbcox requested review of D6178: Merge #14522: tests: add invalid P2P message tests.
Wed, May 20, 21:09
jasonbcox requested changes to D6127: Add options to seeder to determine initial seed list at start up.
Wed, May 20, 17:35
jasonbcox accepted D6164: [backport#16995] net: Fail instead of truncate command name in CMessageHeader.
Wed, May 20, 17:30
jasonbcox accepted D6160: Seed randomness with process id / thread id / various clocks.
Wed, May 20, 17:23

Tue, May 19

jasonbcox accepted D6144: Release notes for PR14477.
Tue, May 19, 17:45
jasonbcox requested review of D6143: [land-bot] Improve error reporting when fetching revision status fails.
Tue, May 19, 16:54
jasonbcox accepted D6141: [wallet] Refactor ProcessImport().
Tue, May 19, 16:18
jasonbcox accepted D6115: [backport#15153] gui: Add Open Wallet menu.
Tue, May 19, 16:01

Mon, May 18

jasonbcox closed T896: Build Bitcoin ABC Diffs / Bitcoin-ABC Land Bot is broken. as Invalid.
Mon, May 18, 20:36
jasonbcox accepted D6117: Fix Flake8 E741 errors.
Mon, May 18, 18:56
jasonbcox planned changes to D5808: [land-patch] Bail early if there's nothing to land.
Mon, May 18, 16:56
jasonbcox requested changes to D6115: [backport#15153] gui: Add Open Wallet menu.

Test plan doesn't test the GUI

Mon, May 18, 16:55
jasonbcox accepted D6118: Lint everything.
Mon, May 18, 16:53
jasonbcox accepted D6117: Fix Flake8 E741 errors.
Mon, May 18, 16:51
jasonbcox accepted D6116: Fix dbcrash spurious failures.

Macro likestamp:

Mon, May 18, 16:48
jasonbcox closed T858: Build Automated Deployments / Bitcoin ABC Automated Commits / Bitcoin-ABC Update Chainparams is broken. as Resolved.
Mon, May 18, 15:42
jasonbcox closed T860: Build Automated Deployments / Bitcoin ABC Automated Commits / Bitcoin-ABC Update timings.json is broken. as Resolved.
Mon, May 18, 15:41
jasonbcox closed T596: Backport Core PR 14350: Add WalletLocation class, a subtask of T595: Backport Core PR15639: bitcoin-wallet tool: Drop libbitcoin_server.a dependency, as Resolved.
Mon, May 18, 15:27 · Restricted Project, Backport
jasonbcox closed T596: Backport Core PR 14350: Add WalletLocation class, a subtask of T600: Backport Core PR 14711: Refactor: Start to separate wallet from node, as Resolved.
Mon, May 18, 15:27 · Restricted Project, Backport
jasonbcox closed T596: Backport Core PR 14350: Add WalletLocation class as Resolved.
Mon, May 18, 15:27 · Restricted Project, Backport
jasonbcox closed T592: Backport Core PR 14437: Refactor: Start to separate wallet from node, a subtask of T596: Backport Core PR 14350: Add WalletLocation class, as Resolved.
Mon, May 18, 15:27 · Restricted Project, Backport
jasonbcox closed T592: Backport Core PR 14437: Refactor: Start to separate wallet from node as Resolved.
Mon, May 18, 15:26 · Backport, Restricted Project
jasonbcox closed T574: Backport Core PR 14708: unrecognized section names in the config should supply warnings in the logs as Resolved.
Mon, May 18, 15:26 · Restricted Project, Bootcamp
jasonbcox closed T629: Backport Core PR 11372: Address encoding cleanup, a subtask of T590: Backport Core 14555: Move util files to new directory, as Resolved.
Mon, May 18, 15:25 · Backport, Restricted Project
jasonbcox closed T629: Backport Core PR 11372: Address encoding cleanup as Resolved.
Mon, May 18, 15:25 · Backport, Restricted Project
jasonbcox closed T590: Backport Core 14555: Move util files to new directory, a subtask of T574: Backport Core PR 14708: unrecognized section names in the config should supply warnings in the logs, as Resolved.
Mon, May 18, 15:25 · Restricted Project, Bootcamp
jasonbcox closed T590: Backport Core 14555: Move util files to new directory, a subtask of T591: Backport Core 14494: Error if # is used in rpcpassword in conf, as Resolved.
Mon, May 18, 15:25 · Backport, Restricted Project
jasonbcox closed T590: Backport Core 14555: Move util files to new directory as Resolved.
Mon, May 18, 15:25 · Backport, Restricted Project
jasonbcox closed T590: Backport Core 14555: Move util files to new directory, a subtask of T592: Backport Core PR 14437: Refactor: Start to separate wallet from node, as Resolved.
Mon, May 18, 15:25 · Backport, Restricted Project
jasonbcox committed rSTAGING90ee2a3fef5b: Cleanup useless dependency in setup-debian-buster.sh (authored by jasonbcox).
Cleanup useless dependency in setup-debian-buster.sh
Mon, May 18, 15:25
jasonbcox closed T583: Backport Core PR 13190, a subtask of T582: Backport Core PR 13341, as Resolved.
Mon, May 18, 15:25 · Backport, Bootcamp, Restricted Project
jasonbcox closed T583: Backport Core PR 13190, a subtask of T637: Backport Core PR 14168: Remove ENABLE_WALLET from libbitcoin_server.a, as Resolved.
Mon, May 18, 15:25 · Backport, Restricted Project