Page MenuHomePhabricator

jasonbcox (Jason Cox)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Sep 6 2017, 16:08 (75 w, 5 d)
Roles
Administrator

Recent Activity

Yesterday

jasonbcox committed rABCd252e8987d66: Added missing release notes for 0.19 (authored by jasonbcox).
Added missing release notes for 0.19
Mon, Feb 18, 19:47
jasonbcox closed D2563: Added missing release notes for 0.19.
Mon, Feb 18, 19:47
jasonbcox committed rABC15445e3a4ab2: Update manpages for 0.19 (authored by jasonbcox).
Update manpages for 0.19
Mon, Feb 18, 19:46
jasonbcox closed D2565: Update manpages for 0.19.
Mon, Feb 18, 19:45
jasonbcox committed rABCc148a1582e7b: Update chainparams for 0.19 (authored by jasonbcox).
Update chainparams for 0.19
Mon, Feb 18, 19:45
jasonbcox closed D2564: Update chainparams for 0.19.
Mon, Feb 18, 19:45
jasonbcox added inline comments to D2565: Update manpages for 0.19.
Mon, Feb 18, 19:16
Herald added a reviewer for D2565: Update manpages for 0.19: Restricted Project.
Mon, Feb 18, 19:13
jasonbcox triaged T542: Give proper error message when DISPLAY is not set (rather than crash) as Low priority.
Mon, Feb 18, 19:08 · Bootcamp, Restricted Project
Herald added a reviewer for D2564: Update chainparams for 0.19: Restricted Project.
Mon, Feb 18, 18:40
Herald added a reviewer for D2563: Added missing release notes for 0.19: Restricted Project.
Mon, Feb 18, 18:32
jasonbcox accepted D2562: un-mention segwit in addnode help text.
Mon, Feb 18, 17:27

Sat, Feb 16

jasonbcox accepted D2559: fix Qt crash.
Sat, Feb 16, 03:22

Thu, Feb 14

jasonbcox committed rABC4a2ad75ca9c4: qt: Poll ShutdownTimer after init is done (authored by MarcoFalke <falke.marco@gmail.com>).
qt: Poll ShutdownTimer after init is done
Thu, Feb 14, 15:38
jasonbcox closed D2545: qt: Poll ShutdownTimer after init is done.
Thu, Feb 14, 15:38
jasonbcox accepted D2552: Check that key length is correct when deserializing CExtKey.
Thu, Feb 14, 15:31
jasonbcox accepted D2550: Various nit in pubkey.h.
Thu, Feb 14, 15:26
jasonbcox accepted D2548: fix abc-parkedchain timeouts.
Thu, Feb 14, 05:34
jasonbcox requested changes to D2548: fix abc-parkedchain timeouts.
Thu, Feb 14, 04:59
jasonbcox committed rABC2ba3ac5b795d: Fix regression in getrawtransaction (authored by jasonbcox).
Fix regression in getrawtransaction
Thu, Feb 14, 01:14
jasonbcox closed D2546: Fix regression in getrawtransaction.
Thu, Feb 14, 01:14
jasonbcox added a comment to D2499: refactor TxToJSON() and ScriptPubKeyToJSON().

For posterity, this backport was fubar'd. See D2546 for details.

Thu, Feb 14, 01:14
Herald added a reviewer for D2547: Merge #12366: http: Join worker threads before deleting work queue: Restricted Project.
Thu, Feb 14, 01:11
jasonbcox added a comment to D2544: Improve shutdown process.

@dagurval points out, maybe we want to go straight for https://github.com/bitcoin/bitcoin/pull/14670 ... sounds like this exits uncleanly in some cases?

Thu, Feb 14, 00:41
jasonbcox triaged T541: Backport Core PR10267 to support includeconf as Normal priority.
Thu, Feb 14, 00:25 · Restricted Project
jasonbcox triaged T540: Backport Core PR12755 as High priority.
Thu, Feb 14, 00:23 · Restricted Project
jasonbcox triaged T539: Backport Core PR12366 as High priority.
Thu, Feb 14, 00:16 · Restricted Project
jasonbcox triaged T538: Backport Core PR13554 as Normal priority.
Thu, Feb 14, 00:14 · Restricted Project
jasonbcox triaged T537: Backport Core PR14670 as High priority.
Thu, Feb 14, 00:13 · Restricted Project
jasonbcox updated the summary of D2546: Fix regression in getrawtransaction.
Thu, Feb 14, 00:03

Wed, Feb 13

Herald added a reviewer for D2546: Fix regression in getrawtransaction: Restricted Project.
Wed, Feb 13, 23:57
Herald added a reviewer for D2545: qt: Poll ShutdownTimer after init is done: Restricted Project.
Wed, Feb 13, 20:00
Herald added a reviewer for D2544: Improve shutdown process: Restricted Project.
Wed, Feb 13, 19:45
jasonbcox added inline comments to D2542: Format BIP32 test cases manually.
Wed, Feb 13, 19:30
Herald added a reviewer for D2543: Remove unused param from txmempool::estimateFee and estimatefee RPC: Restricted Project.
Wed, Feb 13, 19:18
jasonbcox added a parent task for T521: Backport Core PR 10706: T536: Make nTxConfirmTarget use config instead of being global.
Wed, Feb 13, 18:24 · Backport
jasonbcox added a subtask for T536: Make nTxConfirmTarget use config instead of being global: T521: Backport Core PR 10706.
Wed, Feb 13, 18:24 · Bootcamp, Restricted Project
jasonbcox triaged T536: Make nTxConfirmTarget use config instead of being global as Normal priority.
Wed, Feb 13, 18:24 · Bootcamp, Restricted Project
jasonbcox committed rABCea21177017ac: Remove txmempool::estimateSmartFee as it's redundant with ::estimateFee (authored by jasonbcox).
Remove txmempool::estimateSmartFee as it's redundant with ::estimateFee
Wed, Feb 13, 18:03
jasonbcox closed D2540: Remove txmempool::estimateSmartFee as it's redundant with ::estimateFee.
Wed, Feb 13, 18:03
jasonbcox accepted D2527: Improved mempool handling when changing validation rulesets.
Wed, Feb 13, 00:59

Tue, Feb 12

jasonbcox accepted D2008: Change signrawtransaction to signrawtransactionwithwallet in tests, add a test for legacy signrawtransaction.
Tue, Feb 12, 23:50
jasonbcox accepted D2009: [Target v0.19] Deprecate and add test for signrawtransaction.
Tue, Feb 12, 23:47
jasonbcox accepted D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.
Tue, Feb 12, 23:46
jasonbcox accepted D2483: Schnorr signature activation.
Tue, Feb 12, 23:36
jasonbcox requested changes to D2527: Improved mempool handling when changing validation rulesets.
Tue, Feb 12, 23:25
Herald added a reviewer for D2540: Remove txmempool::estimateSmartFee as it's redundant with ::estimateFee: Restricted Project.
Tue, Feb 12, 22:53
jasonbcox closed T512: Backport Core PR 10420 as Resolved.
Tue, Feb 12, 22:44 · Backport
jasonbcox closed T512: Backport Core PR 10420, a subtask of T417: Backport PR10244 from core, as Resolved.
Tue, Feb 12, 22:44 · Backport
jasonbcox committed rABCc3f35428fd2e: Add Qt tests for wallet spends (authored by Russell Yanofsky <russ@yanofsky.org>).
Add Qt tests for wallet spends
Tue, Feb 12, 22:28
jasonbcox closed D2538: Add Qt tests for wallet spends.
Tue, Feb 12, 22:28
jasonbcox closed T511: Backport Core PR 10770 as Resolved.
Tue, Feb 12, 19:15 · Backport
jasonbcox closed T511: Backport Core PR 10770, a subtask of T417: Backport PR10244 from core, as Resolved.
Tue, Feb 12, 19:15 · Backport
jasonbcox accepted D2518: Add an argument to the test framework to enable great wall activation.
Tue, Feb 12, 19:15
jasonbcox added a comment to D2538: Add Qt tests for wallet spends.

I can see this is a dependency for T417 in the task list but fail to see how they are linked together; is there another intermediate backport that needs to build on top of this one ?

Tue, Feb 12, 19:09
jasonbcox updated the diff for D2538: Add Qt tests for wallet spends.

Fixed according to feedback

Tue, Feb 12, 19:07
jasonbcox added inline comments to D2538: Add Qt tests for wallet spends.
Tue, Feb 12, 19:07
jasonbcox added inline comments to D2538: Add Qt tests for wallet spends.
Tue, Feb 12, 01:21
Herald added a reviewer for D2538: Add Qt tests for wallet spends: Restricted Project.
Tue, Feb 12, 01:19

Mon, Feb 11

jasonbcox accepted D2479: Add activation code for SEGWIT_RECOVERY.
Mon, Feb 11, 22:48
jasonbcox closed T381: Implement polymorphic RPC call registration as Resolved.
Mon, Feb 11, 22:36 · Restricted Project
jasonbcox closed T381: Implement polymorphic RPC call registration, a subtask of T367: Create proof-of-concept for BlockTemplateManager, as Resolved.
Mon, Feb 11, 22:36 · Restricted Project
jasonbcox closed T381: Implement polymorphic RPC call registration, a subtask of T368: Implement new getblocktemplate mode, as Resolved.
Mon, Feb 11, 22:36 · Restricted Project
jasonbcox committed rABC97c2227fc9ba: Added RPCCommand base classes in preparation for RPC migration (authored by jasonbcox).
Added RPCCommand base classes in preparation for RPC migration
Mon, Feb 11, 22:36
jasonbcox closed D1894: Added RPCCommand base classes in preparation for RPC migration.
Mon, Feb 11, 22:35
jasonbcox added inline comments to D2483: Schnorr signature activation.
Mon, Feb 11, 22:15
jasonbcox requested changes to D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.
Mon, Feb 11, 22:03
jasonbcox accepted D2535: Refactor TestNode arguments management.
Mon, Feb 11, 18:48
jasonbcox added inline comments to D2535: Refactor TestNode arguments management.
Mon, Feb 11, 18:48
jasonbcox added inline comments to D2535: Refactor TestNode arguments management.
Mon, Feb 11, 18:34
jasonbcox committed rABC5f2ade873098: Remove BytesIO dependency from feature_dersig (authored by jasonbcox).
Remove BytesIO dependency from feature_dersig
Mon, Feb 11, 18:04
jasonbcox closed D2529: Remove BytesIO dependency from feature_dersig.
Mon, Feb 11, 18:04
jasonbcox accepted D2536: Use ToHex() in rpc_decodescript.py, remove dependency to mininode.
Mon, Feb 11, 17:52
jasonbcox accepted D2537: Use ToHex() in feature_nulldummy.py.
Mon, Feb 11, 17:51
jasonbcox committed rABC7777c68cf676: Remove dependency on BytesIO in feature_nulldummy.py (authored by jasonbcox).
Remove dependency on BytesIO in feature_nulldummy.py
Mon, Feb 11, 01:52
jasonbcox closed D2528: Remove dependency on BytesIO in feature_nulldummy.py.
Mon, Feb 11, 01:52
jasonbcox accepted D2525: Add importMempool.
Mon, Feb 11, 00:07

Sun, Feb 10

jasonbcox closed T534: Backport Core PR10712 as Resolved.
Sun, Feb 10, 05:36 · Backport
jasonbcox closed T534: Backport Core PR10712, a subtask of T521: Backport Core PR 10706, as Resolved.
Sun, Feb 10, 05:36 · Backport
jasonbcox committed rABC268be8dd95e0: Merge #10712: Add change output if necessary to reduce excess fee (authored by jasonbcox).
Merge #10712: Add change output if necessary to reduce excess fee
Sun, Feb 10, 05:35
jasonbcox closed D2526: Merge #10712: Add change output if necessary to reduce excess fee.
Sun, Feb 10, 05:35
jasonbcox updated the diff for D2529: Remove BytesIO dependency from feature_dersig.

Rebase + removed unnecessary intermediate variable

Sun, Feb 10, 05:34
jasonbcox committed rABC634af4262efc: Remove unused function and dependencies from rpc_listtransactions (authored by jasonbcox).
Remove unused function and dependencies from rpc_listtransactions
Sun, Feb 10, 05:32
jasonbcox closed D2530: Remove unused function and dependencies from rpc_listtransactions.
Sun, Feb 10, 05:31
jasonbcox committed rABCbff2287cf61c: Removed BytesIO dependency from rpc_decodescript (authored by jasonbcox).
Removed BytesIO dependency from rpc_decodescript
Sun, Feb 10, 05:31
jasonbcox closed D2531: Removed BytesIO dependency from rpc_decodescript.
Sun, Feb 10, 05:31
jasonbcox requested changes to D2483: Schnorr signature activation.
Sun, Feb 10, 05:29
jasonbcox added inline comments to D2483: Schnorr signature activation.
Sun, Feb 10, 05:23
jasonbcox updated the diff for D2528: Remove dependency on BytesIO in feature_nulldummy.py.

Fix according to feedback

Sun, Feb 10, 05:04

Sat, Feb 9

Herald added a reviewer for D2531: Removed BytesIO dependency from rpc_decodescript: Restricted Project.
Sat, Feb 9, 00:29
Herald added a reviewer for D2530: Remove unused function and dependencies from rpc_listtransactions: Restricted Project.
Sat, Feb 9, 00:18
Herald added a reviewer for D2529: Remove BytesIO dependency from feature_dersig: Restricted Project.
Sat, Feb 9, 00:07
jasonbcox added inline comments to D2508: [tests] nulldummy cleanup.
Sat, Feb 9, 00:02
Herald added a reviewer for D2528: Remove dependency on BytesIO in feature_nulldummy.py: Restricted Project.
Sat, Feb 9, 00:02

Fri, Feb 8

Herald added a reviewer for D2526: Merge #10712: Add change output if necessary to reduce excess fee: Restricted Project.
Fri, Feb 8, 23:47
jasonbcox accepted D2452: Make the number service of service flag bits to display a constant.
Fri, Feb 8, 23:46
jasonbcox abandoned D2524: Revert "Revert "Merge #10712: Add change output if necessary to reduce excess fee"".
Fri, Feb 8, 23:39
jasonbcox committed rABC622196dc3d13: [QA] Renaming rawtx into rawTx (authored by NicolasDorier <nicolas.dorier@gmail.com>).
[QA] Renaming rawtx into rawTx
Fri, Feb 8, 23:36
jasonbcox closed D2523: [QA] Renaming rawtx into rawTx.
Fri, Feb 8, 23:36
jasonbcox updated the diff for D1894: Added RPCCommand base classes in preparation for RPC migration.

Better tests and other feedback

Fri, Feb 8, 23:34