Page MenuHomePhabricator

jasonbcox (Jason Cox)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Sep 6 2017, 16:08 (85 w, 23 h)
Roles
Administrator

Recent Activity

Today

jasonbcox committed rABCaeb3ff3467ce: [qt] Simplifies boolean expression model && model->haveWatchOnly() (authored by 251 <13120787+251Labs@users.noreply.github.com>).
[qt] Simplifies boolean expression model && model->haveWatchOnly()
Thu, Apr 25, 15:38
jasonbcox closed D2876: [qt] Simplifies boolean expression model && model->haveWatchOnly().
Thu, Apr 25, 15:38
jasonbcox committed rABC370d6146a348: [qt] Avoid potential null pointer dereference in TransactionView::exportClicked… (authored by practicalswift <practicalswift@users.noreply.github.com>).
[qt] Avoid potential null pointer dereference in TransactionView::exportClicked…
Thu, Apr 25, 15:37
jasonbcox closed D2875: [qt] Avoid potential null pointer dereference in TransactionView::exportClicked().
Thu, Apr 25, 15:37
jasonbcox accepted D2870: Use angle bracket in include for wallet test.

Realized my comment isn't really standardizable across all source files, so ignore me.

Thu, Apr 25, 15:35
jasonbcox accepted D2873: serialize: Serialization support for big-endian 32-bit ints..

Although this backport looks ok, I do think we should investigate test coverage in the future

Thu, Apr 25, 01:35

Yesterday

jasonbcox requested changes to D2873: serialize: Serialization support for big-endian 32-bit ints..

I don't see this being used in https://github.com/bitcoin/bitcoin/pull/14121/files Why is it needed?

Wed, Apr 24, 23:15
jasonbcox added inline comments to D2863: [mining] Add fields for tracking package data..
Wed, Apr 24, 23:07
jasonbcox requested changes to D2863: [mining] Add fields for tracking package data..
Wed, Apr 24, 23:05
jasonbcox accepted D2853: [nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction`.
Wed, Apr 24, 23:00
jasonbcox updated the summary of D2853: [nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction`.
Wed, Apr 24, 23:00
jasonbcox requested changes to D2862: [mining] Rename several CBlockTemplateEntry members for clarity.
Wed, Apr 24, 22:57
jasonbcox accepted D2868: Use angle bracket in include for seeder.
Wed, Apr 24, 22:49
jasonbcox accepted D2869: Use angle bracket in include for wallet.
Wed, Apr 24, 22:48
jasonbcox requested changes to D2870: Use angle bracket in include for wallet test.
Wed, Apr 24, 22:46
jasonbcox added inline comments to D2874: Remove most direct bitcoin calls from qt/walletmodel.cpp.
Wed, Apr 24, 22:43
jasonbcox updated the diff for D2874: Remove most direct bitcoin calls from qt/walletmodel.cpp.

Fixed minor changes that shouldn't have deviated from the backport

Wed, Apr 24, 22:42
jasonbcox added inline comments to D2874: Remove most direct bitcoin calls from qt/walletmodel.cpp.
Wed, Apr 24, 22:38
jasonbcox updated the summary of D2874: Remove most direct bitcoin calls from qt/walletmodel.cpp.
Wed, Apr 24, 20:49
Herald added a reviewer for D2876: [qt] Simplifies boolean expression model && model->haveWatchOnly(): Restricted Project.
Wed, Apr 24, 20:48
Herald added a reviewer for D2875: [qt] Avoid potential null pointer dereference in TransactionView::exportClicked(): Restricted Project.
Wed, Apr 24, 20:46
jasonbcox planned changes to D2874: Remove most direct bitcoin calls from qt/walletmodel.cpp.

Doing another round of self review and annotating deviations from the original PR.

Wed, Apr 24, 20:36
Herald added a reviewer for D2874: Remove most direct bitcoin calls from qt/walletmodel.cpp: Restricted Project.
Wed, Apr 24, 20:35
jasonbcox accepted D2682: [CMAKE] Avoid displaying the console when launching bitcoin-qt.exe.
Wed, Apr 24, 16:03
Herald added a reviewer for D2871: Remove direct bitcoin calls from qt/optionsdialog.cpp: Restricted Project.
Wed, Apr 24, 00:01

Tue, Apr 23

jasonbcox committed rABC966fcf6ef3b0: Remove direct bitcoin calls from qt/rpcconsole.cpp (authored by Russell Yanofsky <russ@yanofsky.org>).
Remove direct bitcoin calls from qt/rpcconsole.cpp
Tue, Apr 23, 22:30
jasonbcox closed D2845: Remove direct bitcoin calls from qt/rpcconsole.cpp.
Tue, Apr 23, 22:30
jasonbcox committed rABCcdbb52ef348b: Remove direct bitcoin calls from qt/bantablemodel.cpp (authored by Russell Yanofsky <russ@yanofsky.org>).
Remove direct bitcoin calls from qt/bantablemodel.cpp
Tue, Apr 23, 22:23
jasonbcox closed D2822: Remove direct bitcoin calls from qt/bantablemodel.cpp.
Tue, Apr 23, 22:23
jasonbcox committed rABC11a062c29019: Remove direct bitcoin calls from qt/peertablemodel.cpp (authored by Russell Yanofsky <russ@yanofsky.org>).
Remove direct bitcoin calls from qt/peertablemodel.cpp
Tue, Apr 23, 22:06
jasonbcox closed D2821: Remove direct bitcoin calls from qt/peertablemodel.cpp.
Tue, Apr 23, 22:06
jasonbcox committed rABC23f2b13cbdb8: Remove direct bitcoin calls from qt/intro.cpp (authored by Russell Yanofsky <russ@yanofsky.org>).
Remove direct bitcoin calls from qt/intro.cpp
Tue, Apr 23, 22:02
jasonbcox closed D2819: Remove direct bitcoin calls from qt/intro.cpp.
Tue, Apr 23, 22:01
jasonbcox committed rABCd5744ecaae97: Remove direct bitcoin calls from qt/clientmodel.cpp (authored by Russell Yanofsky <russ@yanofsky.org>).
Remove direct bitcoin calls from qt/clientmodel.cpp
Tue, Apr 23, 21:35
jasonbcox closed D2818: Remove direct bitcoin calls from qt/clientmodel.cpp.
Tue, Apr 23, 21:35
jasonbcox committed rABC916ce3b5660d: Remove direct bitcoin calls from qt/splashscreen.cpp (authored by Russell Yanofsky <russ@yanofsky.org>).
Remove direct bitcoin calls from qt/splashscreen.cpp
Tue, Apr 23, 21:20
jasonbcox closed D2817: Remove direct bitcoin calls from qt/splashscreen.cpp.
Tue, Apr 23, 21:19
jasonbcox requested changes to D2846: Do not allow users to get keys from keypool without reserving them.
Tue, Apr 23, 20:04
jasonbcox abandoned D1514: Update EMCH testvectors to match UTXO serialization.
Tue, Apr 23, 17:09
jasonbcox commandeered D1514: Update EMCH testvectors to match UTXO serialization.
Tue, Apr 23, 17:09
jasonbcox abandoned D1513: Add test/data directory to enable make check.
Tue, Apr 23, 17:09
jasonbcox commandeered D1513: Add test/data directory to enable make check.
Tue, Apr 23, 17:09
jasonbcox abandoned D1474: Include unverified UTXO commitment in Coinbase on generate.
Tue, Apr 23, 17:07
jasonbcox commandeered D1474: Include unverified UTXO commitment in Coinbase on generate.
Tue, Apr 23, 17:06
jasonbcox abandoned D1470: Add gitian-sigs path and description to use it.
Tue, Apr 23, 17:06
jasonbcox commandeered D1470: Add gitian-sigs path and description to use it.
Tue, Apr 23, 17:06
jasonbcox abandoned D1495: Add unit tests for combining UTXO commitments..
Tue, Apr 23, 17:05
jasonbcox commandeered D1495: Add unit tests for combining UTXO commitments..
Tue, Apr 23, 17:05
jasonbcox added a comment to D1074: Add Utxo Commitment wrapper around libsecp256k1.

If this diff is revisited, also land D1495

Tue, Apr 23, 17:05
jasonbcox abandoned D1150: [WIP] Extensible Blockchain Protocol first approach.
Tue, Apr 23, 17:02
jasonbcox abandoned D1074: Add Utxo Commitment wrapper around libsecp256k1.
Tue, Apr 23, 17:02
jasonbcox abandoned D1117: Integrate UtxoCommitment in CCoinView.
Tue, Apr 23, 17:02
jasonbcox commandeered D1074: Add Utxo Commitment wrapper around libsecp256k1.
Tue, Apr 23, 17:02
jasonbcox commandeered D1117: Integrate UtxoCommitment in CCoinView.
Tue, Apr 23, 17:01
jasonbcox commandeered D1150: [WIP] Extensible Blockchain Protocol first approach.
Tue, Apr 23, 17:01
jasonbcox abandoned D1367: add symlink option.
Tue, Apr 23, 17:01
jasonbcox abandoned D1277: WIP: Prototype structured key-value logger..
Tue, Apr 23, 17:00
jasonbcox commandeered D1277: WIP: Prototype structured key-value logger..
Tue, Apr 23, 17:00
jasonbcox commandeered D1367: add symlink option.
Tue, Apr 23, 16:59
jasonbcox abandoned D598: MalFix: Drop auto-requesting parents of orphans from the same peer.
Tue, Apr 23, 16:59
jasonbcox abandoned D613: MalFix: Drop support for GetTransaction lookups using the UTXO-index.
Tue, Apr 23, 16:59
jasonbcox commandeered D598: MalFix: Drop auto-requesting parents of orphans from the same peer.
Tue, Apr 23, 16:58
jasonbcox abandoned D597: MalFix: Drop lookup in UTXO set to prevent unneeded relay.
Tue, Apr 23, 16:58
jasonbcox commandeered D613: MalFix: Drop support for GetTransaction lookups using the UTXO-index.
Tue, Apr 23, 16:58
jasonbcox commandeered D597: MalFix: Drop lookup in UTXO set to prevent unneeded relay.
Tue, Apr 23, 16:58
jasonbcox abandoned D596: Introduce SIGHASH_SPENDANYOUTPUT.
Tue, Apr 23, 16:57
jasonbcox commandeered D596: Introduce SIGHASH_SPENDANYOUTPUT.
Tue, Apr 23, 16:57
jasonbcox requested changes to D2862: [mining] Rename several CBlockTemplateEntry members for clarity.
Tue, Apr 23, 15:56

Mon, Apr 22

jasonbcox accepted D2859: Use angle bracket in include for src (part 5).
Mon, Apr 22, 18:48
jasonbcox accepted D2860: Use angle bracket in include for src (part 6).
Mon, Apr 22, 18:48
jasonbcox accepted D2857: Use angle bracket in include for src (part 3).
Mon, Apr 22, 18:47
jasonbcox accepted D2854: [qa] [nit] remove extranous variable in mining_prioritisetransaction.py.
Mon, Apr 22, 17:44
jasonbcox requested changes to D2853: [nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction`.

This is an existing Core PR. Please apply the entire backport: https://github.com/bitcoin/bitcoin/pull/9801/files

Mon, Apr 22, 17:40
jasonbcox accepted D2855: Use angle bracket in include for src (part 1).
Mon, Apr 22, 17:37
jasonbcox requested changes to D2860: Use angle bracket in include for src (part 6).
Mon, Apr 22, 17:07
jasonbcox requested changes to D2859: Use angle bracket in include for src (part 5).
Mon, Apr 22, 17:06
jasonbcox accepted D2858: Use angle bracket in include for src (part 4).
Mon, Apr 22, 17:03
jasonbcox requested changes to D2857: Use angle bracket in include for src (part 3).
Mon, Apr 22, 17:01
jasonbcox requested changes to D2855: Use angle bracket in include for src (part 1).
Mon, Apr 22, 16:57
jasonbcox accepted D2856: Use angle bracket in include for src (part 2).
Mon, Apr 22, 16:53
jasonbcox committed rABC419d3000d54c: Bump version number to 0.19.5 (authored by jasonbcox).
Bump version number to 0.19.5
Mon, Apr 22, 16:48
jasonbcox closed D2861: Bump version number to 0.19.5.
Mon, Apr 22, 16:48
jasonbcox updated the diff for D2818: Remove direct bitcoin calls from qt/clientmodel.cpp.

Rebase + fix include ordering

Mon, Apr 22, 16:47
jasonbcox updated the diff for D2817: Remove direct bitcoin calls from qt/splashscreen.cpp.

Rebase

Mon, Apr 22, 16:46
Herald added a reviewer for D2861: Bump version number to 0.19.5: Restricted Project.
Mon, Apr 22, 16:20

Sun, Apr 21

jasonbcox committed rABCf2225b39dcc4: Added missing notes to release notes (authored by jasonbcox).
Added missing notes to release notes
Sun, Apr 21, 17:00
jasonbcox closed D2827: Added missing notes to release notes.
Sun, Apr 21, 17:00

Sat, Apr 20

jasonbcox updated the diff for D2827: Added missing notes to release notes.

Amended note to indicate only bitcoin-cli

Sat, Apr 20, 16:49
jasonbcox updated the diff for D2817: Remove direct bitcoin calls from qt/splashscreen.cpp.

Fixed includes (and angle brackets) + header guards

Sat, Apr 20, 16:46
jasonbcox requested changes to D2846: Do not allow users to get keys from keypool without reserving them.
Sat, Apr 20, 02:02

Fri, Apr 19

Herald added a reviewer for D2845: Remove direct bitcoin calls from qt/rpcconsole.cpp: Restricted Project.
Fri, Apr 19, 23:29
jasonbcox updated the diff for D2822: Remove direct bitcoin calls from qt/bantablemodel.cpp.

Rebase, interface -> interfaces, fixed angle brackets

Fri, Apr 19, 22:49
jasonbcox updated the diff for D2821: Remove direct bitcoin calls from qt/peertablemodel.cpp.

Rebase, interface -> interfaces, peertablemodel.h using angle brackets

Fri, Apr 19, 22:35
jasonbcox updated the diff for D2819: Remove direct bitcoin calls from qt/intro.cpp.

Rebase

Fri, Apr 19, 22:27
jasonbcox accepted D2844: Use angle bracket in rpcwallet and rpcdump.
Fri, Apr 19, 21:59
jasonbcox updated the diff for D2818: Remove direct bitcoin calls from qt/clientmodel.cpp.

Rebase

Fri, Apr 19, 21:58
jasonbcox updated the summary of D2817: Remove direct bitcoin calls from qt/splashscreen.cpp.
Fri, Apr 19, 21:34
jasonbcox updated the diff for D2817: Remove direct bitcoin calls from qt/splashscreen.cpp.

Rebase (with D2842, fixing the linking issue)

Fri, Apr 19, 21:34
jasonbcox committed rABC176342ca4a94: build: Move interfaces/* to libbitcoin_server (authored by jasonbcox).
build: Move interfaces/* to libbitcoin_server
Fri, Apr 19, 21:33
jasonbcox closed D2842: build: Move interfaces/* to libbitcoin_server.
Fri, Apr 19, 21:33