Page MenuHomePhabricator

jasonbcox (Jason B. Cox)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Sep 6 2017, 16:08 (189 w, 1 d)
Roles
Administrator
Slack Username
jasonbcox

Recent Activity

Wed, Apr 21

jasonbcox requested review of D9414: Fix minerfund in GBT when cashaddr is disabled.
Wed, Apr 21, 18:06
jasonbcox updated the summary of D9414: Fix minerfund in GBT when cashaddr is disabled.
Wed, Apr 21, 18:05
jasonbcox reclaimed D9414: Fix minerfund in GBT when cashaddr is disabled.

Reopening this diff. See improved rationale in the summary.

Wed, Apr 21, 18:00
jasonbcox updated the summary of D9414: Fix minerfund in GBT when cashaddr is disabled.
Wed, Apr 21, 18:00

Wed, Apr 14

jasonbcox closed D9413: Ignore .mypy_cache at all levels.
Wed, Apr 14, 22:48
jasonbcox committed rABCba0e06aa7a16: Ignore .mypy_cache at all levels (authored by jasonbcox).
Ignore .mypy_cache at all levels
Wed, Apr 14, 22:48
jasonbcox abandoned D9414: Fix minerfund in GBT when cashaddr is disabled.

Wouldn't moving away imply to not do the translation in more and more places over time?

Is that causing an actual problem for that mining software?

Wed, Apr 14, 22:47

Tue, Apr 13

jasonbcox requested review of D9414: Fix minerfund in GBT when cashaddr is disabled.
Tue, Apr 13, 22:12
jasonbcox requested review of D9413: Ignore .mypy_cache at all levels.
Tue, Apr 13, 22:07

Fri, Apr 9

jasonbcox closed D8673: Add -overridednsseed for testing DNS seed behavior.
Fri, Apr 9, 17:59
jasonbcox committed rABC45d5037db635: Add -overridednsseed for testing DNS seed behavior (authored by jasonbcox).
Add -overridednsseed for testing DNS seed behavior
Fri, Apr 9, 17:59

Sun, Mar 28

jasonbcox closed D9355: Cleanup invalid inputs in p2sh test.
Sun, Mar 28, 21:48
jasonbcox committed rABC6ab7261e6537: Cleanup invalid inputs in p2sh test (authored by jasonbcox).
Cleanup invalid inputs in p2sh test
Sun, Mar 28, 21:48

Sat, Mar 27

jasonbcox requested review of D9355: Cleanup invalid inputs in p2sh test.
Sat, Mar 27, 17:24

Mar 21 2021

jasonbcox accepted D9335: Cleanup the seeder list.
Mar 21 2021, 15:41

Mar 5 2021

jasonbcox closed D9300: Fix typo in USE_LINKER error message.
Mar 5 2021, 17:05
jasonbcox committed rABC96bbb10b7bd8: Fix typo in USE_LINKER error message (authored by jasonbcox).
Fix typo in USE_LINKER error message
Mar 5 2021, 17:05
jasonbcox closed D9301: Fix setting CXXFLAGS in linux build docs.
Mar 5 2021, 17:04
jasonbcox committed rABC87adc0e4b27b: Fix setting CXXFLAGS in linux build docs (authored by jasonbcox).
Fix setting CXXFLAGS in linux build docs
Mar 5 2021, 17:04
jasonbcox requested review of D9301: Fix setting CXXFLAGS in linux build docs.
Mar 5 2021, 04:18
jasonbcox requested review of D9300: Fix typo in USE_LINKER error message.
Mar 5 2021, 04:15

Mar 3 2021

jasonbcox closed D9293: Use correct length sig in sigcheck test.
Mar 3 2021, 23:19
jasonbcox committed rABC0ec3be6798d1: Use correct length sig in sigcheck test (authored by jasonbcox).
Use correct length sig in sigcheck test
Mar 3 2021, 23:19

Mar 2 2021

jasonbcox requested review of D9293: Use correct length sig in sigcheck test.
Mar 2 2021, 22:16

Feb 5 2021

jasonbcox resigned from D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.
Feb 5 2021, 20:04

Feb 4 2021

jasonbcox closed D9159: Use npm ci instead of install for docker deployments.
Feb 4 2021, 16:08
jasonbcox committed rABC81b7eac423d6: Use npm ci instead of install for docker deployments (authored by jasonbcox).
Use npm ci instead of install for docker deployments
Feb 4 2021, 16:08
jasonbcox closed D9158: Do not bust cached npm-installed dependencies when source files change.
Feb 4 2021, 16:06
jasonbcox committed rABC5ba6211c6d43: Do not bust cached npm-installed dependencies when source files change (authored by jasonbcox).
Do not bust cached npm-installed dependencies when source files change
Feb 4 2021, 16:06
jasonbcox closed D9157: Do not bust cached apt-install'd dependencies when source files change.
Feb 4 2021, 16:04
jasonbcox committed rABC6daeacab5488: Do not bust cached apt-install'd dependencies when source files change (authored by jasonbcox).
Do not bust cached apt-install'd dependencies when source files change
Feb 4 2021, 16:04

Feb 3 2021

jasonbcox requested review of D9158: Do not bust cached npm-installed dependencies when source files change.
Feb 3 2021, 21:58
jasonbcox requested review of D9159: Use npm ci instead of install for docker deployments.
Feb 3 2021, 21:36
jasonbcox updated the test plan for D9157: Do not bust cached apt-install'd dependencies when source files change.
Feb 3 2021, 21:29
jasonbcox requested review of D9158: Do not bust cached npm-installed dependencies when source files change.
Feb 3 2021, 21:29
jasonbcox requested review of D9157: Do not bust cached apt-install'd dependencies when source files change.
Feb 3 2021, 21:17

Jan 27 2021

jasonbcox updated the diff for D8673: Add -overridednsseed for testing DNS seed behavior.

Separated out GetRandomizedDNSSeeds into its own files. Over time, these new files can house the
DNS seed related logic and constants that currently reside in the net.h/cpp mess.

Jan 27 2021, 00:22

Jan 5 2021

jasonbcox added inline comments to D8673: Add -overridednsseed for testing DNS seed behavior.
Jan 5 2021, 00:45
jasonbcox updated the diff for D8673: Add -overridednsseed for testing DNS seed behavior.
  • Rename DNSSeeds -> GetRandomizedDNSSeeds
  • Make the currently node-specific randomization logic available to the seeder
  • Doing the above also incidentally makes better use of the vector copy that I introduced in this patch.
Jan 5 2021, 00:41

Dec 29 2020

jasonbcox accepted D8707: [WEBSITE] Remove the BCHN variant from the release page.
Dec 29 2020, 17:26
jasonbcox requested changes to D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.
Dec 29 2020, 17:21

Dec 28 2020

jasonbcox accepted D8757: [backport#17674] tests: Add initialization order fiasco detection in Travis.
Dec 28 2020, 17:53
jasonbcox accepted D8756: [backport#17205] ci: Enable address sanitizer (ASan) stack-use-after-return checking.
Dec 28 2020, 17:50
jasonbcox requested changes to D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.

Tests still failing.

Dec 28 2020, 17:49
jasonbcox accepted D8760: Bump version to 0.22.11.
Dec 28 2020, 17:48

Dec 21 2020

jasonbcox requested changes to D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.

abc_mining_basic.py still needs to test that the old prefix is valid for mining

Dec 21 2020, 19:25

Dec 17 2020

jasonbcox added inline comments to D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.
Dec 17 2020, 23:54
jasonbcox updated the diff for D8673: Add -overridednsseed for testing DNS seed behavior.
  • Fixed checking if the arg is set
  • Added another sanity checking test case
Dec 17 2020, 23:30
jasonbcox requested changes to D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.
Dec 17 2020, 22:36

Dec 14 2020

jasonbcox added a comment to D8673: Add -overridednsseed for testing DNS seed behavior.

The cppcheck issue appears to be a bug in cppcheck. Fabien has confirmed this lint error does not appear in a newer version.

Dec 14 2020, 20:12
jasonbcox updated the diff for D5380: [seeder] Require good seeds to have latest checkpoint.
  • Refactor and simplify the logic tracking checkpoint state
  • Refactor and simplify the tests
  • Rewrite summary and test plan
  • New changes depend on D8673 to make the test plan easier to understand by simple examination of the command line arguments in each step.
Dec 14 2020, 20:10
jasonbcox updated the summary of D5380: [seeder] Require good seeds to have latest checkpoint.
Dec 14 2020, 20:04
jasonbcox updated the test plan for D5380: [seeder] Require good seeds to have latest checkpoint.
Dec 14 2020, 20:03
jasonbcox updated the test plan for D5380: [seeder] Require good seeds to have latest checkpoint.
Dec 14 2020, 20:03
jasonbcox updated the test plan for D5380: [seeder] Require good seeds to have latest checkpoint.
Dec 14 2020, 19:51
jasonbcox updated the test plan for D5380: [seeder] Require good seeds to have latest checkpoint.
Dec 14 2020, 19:49
jasonbcox updated the test plan for D5380: [seeder] Require good seeds to have latest checkpoint.
Dec 14 2020, 19:45
jasonbcox updated the test plan for D5380: [seeder] Require good seeds to have latest checkpoint.
Dec 14 2020, 19:20
jasonbcox updated the test plan for D5380: [seeder] Require good seeds to have latest checkpoint.
Dec 14 2020, 19:18
jasonbcox updated the test plan for D5380: [seeder] Require good seeds to have latest checkpoint.
Dec 14 2020, 18:52
jasonbcox updated the test plan for D5380: [seeder] Require good seeds to have latest checkpoint.
Dec 14 2020, 18:47
jasonbcox requested review of D8673: Add -overridednsseed for testing DNS seed behavior.
Dec 14 2020, 18:31

Dec 12 2020

jasonbcox updated the test plan for D5380: [seeder] Require good seeds to have latest checkpoint.
Dec 12 2020, 00:21
jasonbcox updated the test plan for D5380: [seeder] Require good seeds to have latest checkpoint.
Dec 12 2020, 00:14
jasonbcox retitled D5380: [seeder] Require good seeds to have latest checkpoint from Seeder requires good seeds to have block after most recent checkpoint in its chain and bans those that don't to [seeder] Require good seeds to have latest checkpoint.
Dec 12 2020, 00:13
jasonbcox closed D6283: [seeder] Request headers from new connections.
Dec 12 2020, 00:00
jasonbcox committed rABC8099bc1028b2: [seeder] Request headers from new connections (authored by jasonbcox).
[seeder] Request headers from new connections
Dec 12 2020, 00:00

Dec 11 2020

jasonbcox commandeered D5380: [seeder] Require good seeds to have latest checkpoint.
Dec 11 2020, 22:09
jasonbcox abandoned D8486: Temporarily disable caching for css and js files.
Dec 11 2020, 22:05
jasonbcox accepted D8650: refactor: Use AbortError in FatalError.
Dec 11 2020, 01:32
jasonbcox closed D8657: Update seeds.
Dec 11 2020, 00:36
jasonbcox committed rABC1a4c91afe748: Update seeds (authored by jasonbcox).
Update seeds
Dec 11 2020, 00:36
jasonbcox accepted D8658: refactor: Fix unreachable code in init arg checks (part 2).
Dec 11 2020, 00:03

Dec 10 2020

jasonbcox accepted D8649: Pass bilingual_str argument to AbortNode().
Dec 10 2020, 23:44
jasonbcox requested review of D8657: Update seeds.
Dec 10 2020, 23:39
jasonbcox accepted D8652: Fix bitcoin-qt RPC when -server is used.

Looks like we need some better test coverage to make sure bitcoin-qt in server mode work as expected.

Dec 10 2020, 23:27
jasonbcox updated the summary of D6283: [seeder] Request headers from new connections.
Dec 10 2020, 23:08
jasonbcox retitled D6283: [seeder] Request headers from new connections from Seeder sends GETHEADERS message to [seeder] Request headers from new connections.
Dec 10 2020, 23:06
jasonbcox updated the diff for D6283: [seeder] Request headers from new connections.

Rebase and add some basic test coverage

Dec 10 2020, 23:05
jasonbcox commandeered D6283: [seeder] Request headers from new connections.
Dec 10 2020, 23:04
jasonbcox closed D8624: [seeder] Add a test to check outgoing messages in response to VERACK.
Dec 10 2020, 17:57
jasonbcox committed rABC6b57151f3e4d: [seeder] Add a test to check outgoing messages in response to VERACK (authored by jasonbcox).
[seeder] Add a test to check outgoing messages in response to VERACK
Dec 10 2020, 17:57
jasonbcox abandoned D8641: Make version constants fixed-width.
Dec 10 2020, 02:47
teamcity awarded D8642: [seeder] Use GetTime() utility function instead of accessing ctime directly a Haypence token.
Dec 10 2020, 02:47
jasonbcox added a comment to D8642: [seeder] Use GetTime() utility function instead of accessing ctime directly.

@bot build-linux32 build-osx

Dec 10 2020, 02:47
jasonbcox requested review of D8642: [seeder] Use GetTime() utility function instead of accessing ctime directly.
Dec 10 2020, 02:46
teamcity awarded D8641: Make version constants fixed-width a Haypence token.
Dec 10 2020, 01:56
jasonbcox added a comment to D8641: Make version constants fixed-width.

@bot build-linux32 build-osx

Dec 10 2020, 01:56
jasonbcox planned changes to D8641: Make version constants fixed-width.
Dec 10 2020, 01:55
jasonbcox requested review of D8641: Make version constants fixed-width.
Dec 10 2020, 01:55
jasonbcox closed D6357: Dedup net message writing code in the seeder.
Dec 10 2020, 00:06
jasonbcox committed rABC2a8d9ce51932: Dedup net message writing code in the seeder (authored by nakihito).
Dedup net message writing code in the seeder
Dec 10 2020, 00:06

Dec 9 2020

jasonbcox updated the diff for D6357: Dedup net message writing code in the seeder.

This was a good question. There's multiple copies going on here and they aren't necessary.
While the handling of the outgoing data stream is not identical between the seeder and the
node software, the new WriteMessage function can easily write directly to the stream in
question instead of copying into an intermediate which then is copied into the outgoing stream.

Dec 9 2020, 22:16
jasonbcox updated the diff for D8624: [seeder] Add a test to check outgoing messages in response to VERACK.
  • Improve the API for testing
  • Use NetMsgType::GETADDR in place of a hardcoded string
  • Other minor nits
Dec 9 2020, 18:47

Dec 8 2020

jasonbcox closed D8623: [seeder] Use netmagic from chainparams instead of a cached global.
Dec 8 2020, 19:43
jasonbcox committed rABC207a1f435e9e: [seeder] Use netmagic from chainparams instead of a cached global (authored by jasonbcox).
[seeder] Use netmagic from chainparams instead of a cached global
Dec 8 2020, 19:43
jasonbcox closed D8622: Fix seeder linking due to missing dependency in libcommon.
Dec 8 2020, 19:41
jasonbcox committed rABC68ba35006344: Fix seeder linking due to missing dependency in libcommon (authored by jasonbcox).
Fix seeder linking due to missing dependency in libcommon
Dec 8 2020, 19:41

Dec 7 2020

jasonbcox requested review of D8624: [seeder] Add a test to check outgoing messages in response to VERACK.
Dec 7 2020, 23:26
jasonbcox requested review of D8623: [seeder] Use netmagic from chainparams instead of a cached global.
Dec 7 2020, 23:23