Page MenuHomePhabricator

jasonbcox (Jason Cox)Administrator
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 6 2017, 16:08 (66 w, 1 d)
Roles
Administrator

Recent Activity

Today

Herald added a reviewer for D2189: Remove redundant connect_nodes call in abc-parkedchain.py: Restricted Project.
Thu, Dec 13, 01:47
Herald added a reviewer for D2188: Added abc-sync-chain test to ensure node doesn't seize while syncing many blocks: Restricted Project.
Thu, Dec 13, 00:18

Yesterday

jasonbcox closed D2149: [Part 1] Core PR 11531: p2p-acceptblock improvements.
Wed, Dec 12, 00:00

Tue, Dec 11

jasonbcox added a comment to D2149: [Part 1] Core PR 11531: p2p-acceptblock improvements.

Task to followup on the nits: T501

Tue, Dec 11, 05:00
jasonbcox accepted D2183: Add backporting suggestion to CONTRIBUTING.md.
Tue, Dec 11, 04:24

Mon, Dec 10

jasonbcox requested review of D2149: [Part 1] Core PR 11531: p2p-acceptblock improvements.

In the interest of reducing merge conflicts, the nits regarding hash formatting and comment location will need to be handled after this series of backports.

Mon, Dec 10, 23:25
jasonbcox closed D2185: Use the variable name _ for unused return values.
Mon, Dec 10, 17:18
jasonbcox closed D2166: Remove unused variables and/or function calls.
Mon, Dec 10, 02:31
jasonbcox closed D2151: Use sys.exit(...) instead of exit(...): exit(...) should not be used in programs.
Mon, Dec 10, 02:29
Herald added a reviewer for D2185: Use the variable name _ for unused return values: Restricted Project.
Mon, Dec 10, 01:32
jasonbcox added a child revision for D2166: Remove unused variables and/or function calls: D2185: Use the variable name _ for unused return values.
Mon, Dec 10, 01:32
jasonbcox requested changes to D2183: Add backporting suggestion to CONTRIBUTING.md.
Mon, Dec 10, 01:07
jasonbcox added inline comments to D2183: Add backporting suggestion to CONTRIBUTING.md.
Mon, Dec 10, 01:05
jasonbcox closed D2150: Datadir option in linearize scripts.
Mon, Dec 10, 01:01

Thu, Dec 6

jasonbcox accepted D2176: Move OP_CSV from scriptSig to scriptPubKey in bip68-112-113-p2p.
Thu, Dec 6, 02:40

Wed, Dec 5

jasonbcox added inline comments to D2176: Move OP_CSV from scriptSig to scriptPubKey in bip68-112-113-p2p.
Wed, Dec 5, 19:34
jasonbcox updated the diff for D1979: [qt] Multiwallet support for GUI (Core PR12610).

Rebase

Wed, Dec 5, 00:38
jasonbcox added inline comments to D1979: [qt] Multiwallet support for GUI (Core PR12610).
Wed, Dec 5, 00:36
D2166: Remove unused variables and/or function calls now requires review to proceed.
Wed, Dec 5, 00:27

Tue, Dec 4

jasonbcox committed rABCc97320473fa4: Fix broken boost mirror for BSD and fix http -> https in some links (authored by rex4539).
Fix broken boost mirror for BSD and fix http -> https in some links
Tue, Dec 4, 23:32
jasonbcox closed D2175: Fix broken boost mirror for BSD and fix http -> https in some links.
Tue, Dec 4, 23:31
jasonbcox accepted D2177: Make bip68-112-113-p2p.py conform to magnetic anomaly.
Tue, Dec 4, 17:54
jasonbcox requested changes to D2176: Move OP_CSV from scriptSig to scriptPubKey in bip68-112-113-p2p.
Tue, Dec 4, 17:53

Mon, Dec 3

D2149: [Part 1] Core PR 11531: p2p-acceptblock improvements now requires review to proceed.
Mon, Dec 3, 23:26
jasonbcox accepted D2174: [avalanche] Fix inconsistent numeric types.
Mon, Dec 3, 21:59
jasonbcox updated the summary of D2175: Fix broken boost mirror for BSD and fix http -> https in some links.
Mon, Dec 3, 21:54
Herald added a reviewer for D2175: Fix broken boost mirror for BSD and fix http -> https in some links: Restricted Project.
Mon, Dec 3, 21:38
jasonbcox requested review of D1979: [qt] Multiwallet support for GUI (Core PR12610).
Mon, Dec 3, 20:45
jasonbcox updated the test plan for D1979: [qt] Multiwallet support for GUI (Core PR12610).
Mon, Dec 3, 20:41
jasonbcox accepted D2160: [avalanche] Add the concept of inconclusive votes.
Mon, Dec 3, 17:58

Sun, Dec 2

jasonbcox added inline comments to D2160: [avalanche] Add the concept of inconclusive votes.
Sun, Dec 2, 23:17
jasonbcox accepted D2148: [avalanche] Use black magic for popcount..

One nit in the new comment

Sun, Dec 2, 23:16
jasonbcox accepted D2130: Fix abc-finalize-block.py header propagation issue.
Sun, Dec 2, 23:13

Sat, Dec 1

jasonbcox added a parent revision for D2166: Remove unused variables and/or function calls: D2151: Use sys.exit(...) instead of exit(...): exit(...) should not be used in programs.
Sat, Dec 1, 00:04
jasonbcox added a child revision for D2151: Use sys.exit(...) instead of exit(...): exit(...) should not be used in programs: D2166: Remove unused variables and/or function calls.
Sat, Dec 1, 00:04
jasonbcox updated the diff for D2166: Remove unused variables and/or function calls.

Fixed merged conflict on a single whitespace

Sat, Dec 1, 00:03

Fri, Nov 30

Herald added a reviewer for D2166: Remove unused variables and/or function calls: Restricted Project.
Fri, Nov 30, 23:59
jasonbcox requested changes to D1969: [Part 2 of 5] Add a CChainState class to clarify internal interfaces.
Fri, Nov 30, 22:43
jasonbcox requested changes to D2153: [qa] Make src_dir handling more robust.
Fri, Nov 30, 22:05
jasonbcox added inline comments to D2160: [avalanche] Add the concept of inconclusive votes.
Fri, Nov 30, 21:45
jasonbcox committed rSTAGINGe8b8dc1b128b: Do not pull from Core repos when using gitian-build.sh (authored by jasonbcox).
Do not pull from Core repos when using gitian-build.sh
Fri, Nov 30, 21:34
jasonbcox committed rSTAGINGeec5e1a47f3b: Enforce protocol message size against INV message size (authored by jasonbcox).
Enforce protocol message size against INV message size
Fri, Nov 30, 21:34
jasonbcox committed rSTAGING2ca5901d7c01: Fixed whitespace issues in gitian-build.sh (authored by jasonbcox).
Fixed whitespace issues in gitian-build.sh
Fri, Nov 30, 21:34
jasonbcox committed rSTAGING475202114234: Rename function in bip65 integration test so it does not collide with… (authored by jasonbcox).
Rename function in bip65 integration test so it does not collide with…
Fri, Nov 30, 21:34
jasonbcox committed rSTAGINGe6b8f1969542: Revert "Cleanup unused contrib scripts" (authored by jasonbcox).
Revert "Cleanup unused contrib scripts"
Fri, Nov 30, 21:34
jasonbcox added a reverting change for rSTAGINGb86f0e990021: Cleanup unused contrib scripts: rSTAGINGe6b8f1969542: Revert "Cleanup unused contrib scripts".
Fri, Nov 30, 21:34
jasonbcox committed rSTAGINGdfaed8898e54: [qa] fix abc-p2p-compactblocks to be compatible with magnetic anomaly upgrade (authored by schancel).
[qa] fix abc-p2p-compactblocks to be compatible with magnetic anomaly upgrade
Fri, Nov 30, 21:32
jasonbcox committed rSTAGING84e5c7f0a0e7: Cleanup redundant function in abc-p2p-compactblocks (authored by jasonbcox).
Cleanup redundant function in abc-p2p-compactblocks
Fri, Nov 30, 21:32
jasonbcox committed rSTAGINGd9a6381ac810: Removed unused update_block from abc-p2p-compactblocks (authored by jasonbcox).
Removed unused update_block from abc-p2p-compactblocks
Fri, Nov 30, 21:32
jasonbcox committed rSTAGING6d18d4c703af: Ensure bip68-112-113-p2p passes for pre-fork conditions (authored by jasonbcox).
Ensure bip68-112-113-p2p passes for pre-fork conditions
Fri, Nov 30, 21:32
jasonbcox committed rSTAGINGa0038cf47f56: Assert on block number earlier in next_block (authored by jasonbcox).
Assert on block number earlier in next_block
Fri, Nov 30, 21:32
jasonbcox committed rSTAGING1a1b68c4d0e8: Update chainparams for 0.18.5 release (authored by jasonbcox).
Update chainparams for 0.18.5 release
Fri, Nov 30, 21:32
jasonbcox committed rSTAGINGe0797f6dbefe: Fix pad_tx off by one error + nits (authored by jasonbcox).
Fix pad_tx off by one error + nits
Fri, Nov 30, 21:32
jasonbcox committed rSTAGING5e8bcc09fbbc: [qa] fix transaction ordering and padding in abc-p2p-compactblocks.py (authored by jasonbcox).
[qa] fix transaction ordering and padding in abc-p2p-compactblocks.py
Fri, Nov 30, 21:32
jasonbcox committed rSTAGINGf0afbcc15f09: [qa] fix abc-p2p-fullblock test to support magnetic anomaly (authored by jasonbcox).
[qa] fix abc-p2p-fullblock test to support magnetic anomaly
Fri, Nov 30, 21:32
jasonbcox committed rSTAGINGb8e3cc2f834c: Cleanup pre-fork testing for bip68-sequence (authored by jasonbcox).
Cleanup pre-fork testing for bip68-sequence
Fri, Nov 30, 21:32
jasonbcox committed rSTAGING388d3c1f12b2: Fixed p2p-compactblocks failures (authored by jasonbcox).
Fixed p2p-compactblocks failures
Fri, Nov 30, 21:32
jasonbcox committed rSTAGING2b4be88522d4: Fix transaction ordering in abc-mempool-accept-txn (authored by jasonbcox).
Fix transaction ordering in abc-mempool-accept-txn
Fri, Nov 30, 21:32
jasonbcox committed rSTAGING7a3f5d84bcca: Fix absurdly-high-fee failure in bip65-cltv-p2p.py (authored by jasonbcox).
Fix absurdly-high-fee failure in bip65-cltv-p2p.py
Fri, Nov 30, 21:32
jasonbcox committed rSTAGING013dfca8ee5c: Consolidate tx rehashing in helper function as expected (authored by jasonbcox).
Consolidate tx rehashing in helper function as expected
Fri, Nov 30, 21:31
jasonbcox committed rSTAGING8e5124edc5b5: Fix nulldummy.py transaction ordering (authored by jasonbcox).
Fix nulldummy.py transaction ordering
Fri, Nov 30, 21:31
jasonbcox committed rSTAGING5e3bd712d180: Fix bip65-cltv-p2p test for pre-fork conditions (authored by jasonbcox).
Fix bip65-cltv-p2p test for pre-fork conditions
Fri, Nov 30, 21:31
jasonbcox committed rSTAGINGe3b39f225b20: Update README.md (authored by theo-armour).
Update README.md
Fri, Nov 30, 21:31
jasonbcox committed rSTAGING44b288a6fd62: Bump protocol message length (authored by jasonbcox).
Bump protocol message length
Fri, Nov 30, 21:31
jasonbcox committed rSTAGINGfba3f3e1f413: Remove unused github-merge script (authored by jasonbcox).
Remove unused github-merge script
Fri, Nov 30, 21:31
jasonbcox committed rSTAGINGdef0035118cd: Fixed disclosure policy formatting (authored by jasonbcox).
Fixed disclosure policy formatting
Fri, Nov 30, 21:31
jasonbcox committed rSTAGING91ba8bb3d634: Added responsible discloure policy (authored by jasonbcox).
Added responsible discloure policy
Fri, Nov 30, 21:30
jasonbcox committed rSTAGINGbc151caa8888: Update chainparams for release (authored by jasonbcox).
Update chainparams for release
Fri, Nov 30, 21:30
jasonbcox committed rSTAGING6d1ebd13b1d2: Fix up release note on parked chain RPC (authored by jasonbcox).
Fix up release note on parked chain RPC
Fri, Nov 30, 21:30
jasonbcox requested changes to D2160: [avalanche] Add the concept of inconclusive votes.
Fri, Nov 30, 21:23
jasonbcox updated the diff for D2150: Datadir option in linearize scripts.

Rebase

Fri, Nov 30, 19:02
jasonbcox added inline comments to D2130: Fix abc-finalize-block.py header propagation issue.
Fri, Nov 30, 18:59
jasonbcox accepted D2148: [avalanche] Use black magic for popcount..

magic

Fri, Nov 30, 18:56
jasonbcox requested changes to D2159: [Part 1 of 4] [qa] De-globalize port seeding.
Fri, Nov 30, 18:24
Herald added a reviewer for D2151: Use sys.exit(...) instead of exit(...): exit(...) should not be used in programs: Restricted Project.
Fri, Nov 30, 00:03
jasonbcox added a child revision for D2150: Datadir option in linearize scripts: D2151: Use sys.exit(...) instead of exit(...): exit(...) should not be used in programs.
Fri, Nov 30, 00:02

Thu, Nov 29

Herald added a reviewer for D2150: Datadir option in linearize scripts: Restricted Project.
Thu, Nov 29, 23:58
jasonbcox added inline comments to D2130: Fix abc-finalize-block.py header propagation issue.
Thu, Nov 29, 23:30
jasonbcox requested changes to D2130: Fix abc-finalize-block.py header propagation issue.
Thu, Nov 29, 23:25
jasonbcox requested review of D1894: Added RPCCommand base classes in preparation for RPC migration.
Thu, Nov 29, 23:03
jasonbcox abandoned D2051: Added build-all script to automate calling gitian builds for each platform.
Thu, Nov 29, 22:22
jasonbcox updated the diff for D1894: Added RPCCommand base classes in preparation for RPC migration.

Fixed according to feedback. Always return a factory for MatchCommand, even in the error case.

Thu, Nov 29, 21:38
jasonbcox added inline comments to D1894: Added RPCCommand base classes in preparation for RPC migration.
Thu, Nov 29, 21:37
jasonbcox requested changes to D2148: [avalanche] Use black magic for popcount..
Thu, Nov 29, 20:11
jasonbcox updated the summary of D2149: [Part 1] Core PR 11531: p2p-acceptblock improvements.
Thu, Nov 29, 19:16
Herald added a reviewer for D2149: [Part 1] Core PR 11531: p2p-acceptblock improvements: Restricted Project.
Thu, Nov 29, 19:12
jasonbcox accepted D2140: [avalanche] Delegate node management to caller.
Thu, Nov 29, 17:08

Wed, Nov 28

jasonbcox added inline comments to D1894: Added RPCCommand base classes in preparation for RPC migration.
Wed, Nov 28, 22:30
jasonbcox accepted D2137: [avalanche] Use a multi_index to track request so it is easy to determine which timed out..
Wed, Nov 28, 18:45

Tue, Nov 27

jasonbcox requested changes to D2140: [avalanche] Delegate node management to caller.

Back on your queue because tests fail.

Tue, Nov 27, 22:23
jasonbcox updated the diff for D1894: Added RPCCommand base classes in preparation for RPC migration.

Rebase + feedback:

  • map of UniValues -> UniValue
  • Use factory method properly
  • Deleted CommandName class, as it's unnecessary
Tue, Nov 27, 22:04
jasonbcox added inline comments to D1894: Added RPCCommand base classes in preparation for RPC migration.
Tue, Nov 27, 21:57
jasonbcox committed rABCe8b8dc1b128b: Do not pull from Core repos when using gitian-build.sh (authored by jasonbcox).
Do not pull from Core repos when using gitian-build.sh
Tue, Nov 27, 19:06
jasonbcox closed D2055: Do not pull from Core repos when using gitian-build.sh.
Tue, Nov 27, 19:06
jasonbcox planned changes to D1979: [qt] Multiwallet support for GUI (Core PR12610).

Need to test bitcoin-qt still. Having some issues running Qt on WSL.

Tue, Nov 27, 19:04
jasonbcox updated the diff for D1979: [qt] Multiwallet support for GUI (Core PR12610).

Rebase + feedback changes

Tue, Nov 27, 19:03
jasonbcox added inline comments to D1979: [qt] Multiwallet support for GUI (Core PR12610).
Tue, Nov 27, 18:46
jasonbcox updated the summary of D1979: [qt] Multiwallet support for GUI (Core PR12610).
Tue, Nov 27, 18:41
jasonbcox accepted D2144: Fix nits in bitcoingui.cpp.
Tue, Nov 27, 18:27
jasonbcox updated the diff for D2055: Do not pull from Core repos when using gitian-build.sh.

Rebase

Tue, Nov 27, 18:18