Page MenuHomePhabricator

jasonbcox (Jason Cox)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Sep 6 2017, 16:08 (110 w, 4 d)
Roles
Administrator

Recent Activity

Fri, Oct 18

jasonbcox accepted D4267: [CMAKE] Use CPack to build packages.

Thanks for explaining. I think there's some minor improvements we can make later, but they don't need to block this diff specifically.

Fri, Oct 18, 21:51
jasonbcox requested changes to D3950: Merge #12953: Deprecate accounts.
Fri, Oct 18, 18:26
jasonbcox requested changes to D4267: [CMAKE] Use CPack to build packages.
Fri, Oct 18, 18:06
jasonbcox accepted D3949: Merge #12892: [wallet] [rpc] introduce 'label' API for wallet.
Fri, Oct 18, 00:47
jasonbcox accepted D4254: ui: Support wallets unloaded dynamically.
Fri, Oct 18, 00:33

Wed, Oct 16

jasonbcox added a comment to D4240: [gitian-build] Remove ambiguous buildsign argument.

Why increased automation would make this parameter obsolete? Why remove it before such automation exists and the parameter actually is obsolete?

Wed, Oct 16, 23:59
jasonbcox added a comment to D4241: [gitian-build] Rename ambiguous --sign argument.

First, I'm not convinced this is ambiguous. What would you sign in there that makes any sense? Is that worth breaking things? Second, the test plan doesn't cover the feature whatsoever.

Wed, Oct 16, 23:57
jasonbcox accepted D4255: bugfix: Remove dangling wallet env instance and Delete walletView in WalletFrame::removeWallet.
Wed, Oct 16, 20:27
jasonbcox requested changes to D4254: ui: Support wallets unloaded dynamically.
Wed, Oct 16, 20:26
jasonbcox accepted D4253: rpc: Add unloadwallet RPC, release notes, and tests.

I don't see a good reason to block this based on the discussion in PR14941. That change is an improvement, but we'll need to backport up to it to get it.

Wed, Oct 16, 20:15
jasonbcox accepted D4252: rpc: Extract GetWalletNameFromJSONRPCRequest from GetWalletForJSONRPCRequest.
Wed, Oct 16, 20:00
jasonbcox committed rABCdef2d9c3216e: Fix misnamed 0.20.4 release notes (authored by jasonbcox).
Fix misnamed 0.20.4 release notes
Wed, Oct 16, 16:21
jasonbcox closed D4260: Fix misnamed 0.20.4 release notes.
Wed, Oct 16, 16:21
jasonbcox accepted D4250: Introduce constant default variables to initialize seeder options.
Wed, Oct 16, 16:21
jasonbcox created D4260: Fix misnamed 0.20.4 release notes.
Wed, Oct 16, 06:32

Tue, Oct 15

jasonbcox requested changes to D4250: Introduce constant default variables to initialize seeder options.
Tue, Oct 15, 22:31
jasonbcox requested changes to D4255: bugfix: Remove dangling wallet env instance and Delete walletView in WalletFrame::removeWallet.
Tue, Oct 15, 15:38
jasonbcox requested changes to D4250: Introduce constant default variables to initialize seeder options.
Tue, Oct 15, 15:37
jasonbcox accepted D4251: Change CDnsSeedOpts to use std::string instead of c-strings.

I don't agree that this is easier to read, but I do agree with where this is heading and that it will integrate with ArgsManager better.

Tue, Oct 15, 00:20

Mon, Oct 14

jasonbcox requested changes to D4250: Introduce constant default variables to initialize seeder options.

testplan doesn't verify that all modified defaults are still set as expected

Mon, Oct 14, 23:42
jasonbcox accepted D4248: Merge #13722: trivial: Replace CPubKey::operator[] with CPubKey::vch where possible.
Mon, Oct 14, 21:08
jasonbcox requested changes to D4250: Introduce constant default variables to initialize seeder options.

For testing the defaults, the testplan should *not* include various arguments.

Mon, Oct 14, 21:06
jasonbcox accepted D4249: Fix --wipeignore and add message indicating if wipe options are set and successful.

Good catch.

Mon, Oct 14, 20:00
jasonbcox accepted D4190: Rename master key to seed.
Mon, Oct 14, 03:43

Fri, Oct 11

jasonbcox accepted D4246: Version Bump to v20.5.
Fri, Oct 11, 23:38
jasonbcox accepted D4245: Merge #13273: Qt/Bugfix: fix handling default wallet with no name.
Fri, Oct 11, 23:26
jasonbcox committed rABC0d9b54b65610: [gitian-build] Move manifest files to output directory (authored by jasonbcox).
[gitian-build] Move manifest files to output directory
Fri, Oct 11, 16:13
jasonbcox closed D4232: [gitian-build] Move manifest files to output directory.
Fri, Oct 11, 16:12
jasonbcox committed rABCba1767e8c10f: [gitian-build] Refactor to calculate output directories in fewer places (authored by jasonbcox).
[gitian-build] Refactor to calculate output directories in fewer places
Fri, Oct 11, 16:12
jasonbcox closed D4231: [gitian-build] Refactor to calculate output directories in fewer places.
Fri, Oct 11, 16:12
jasonbcox committed rABC679786401e1f: Update manpages for 0.20.4 release (authored by jasonbcox).
Update manpages for 0.20.4 release
Fri, Oct 11, 03:47
jasonbcox closed D4237: Update manpages for 0.20.4 release.
Fri, Oct 11, 03:47
jasonbcox committed rABCd6393cf929f5: Update chainparams (authored by jasonbcox).
Update chainparams
Fri, Oct 11, 03:46
jasonbcox closed D4235: Update chainparams.
Fri, Oct 11, 03:46
jasonbcox committed rABC2f6b0e6eb1ac: Update seeds (authored by jasonbcox).
Update seeds
Fri, Oct 11, 03:45
jasonbcox closed D4233: Update seeds.
Fri, Oct 11, 03:45
jasonbcox created D4242: [gitian-build] Split apart building and signing the build.
Fri, Oct 11, 03:43
jasonbcox created D4241: [gitian-build] Rename ambiguous --sign argument.
Fri, Oct 11, 03:36
jasonbcox created D4240: [gitian-build] Remove ambiguous buildsign argument.
Fri, Oct 11, 03:30

Thu, Oct 10

jasonbcox created D4237: Update manpages for 0.20.4 release.
Thu, Oct 10, 18:22
jasonbcox created D4235: Update chainparams.
Thu, Oct 10, 18:16
jasonbcox updated the summary of D4233: Update seeds.
Thu, Oct 10, 17:35
jasonbcox created D4233: Update seeds.
Thu, Oct 10, 17:33
jasonbcox requested review of D4232: [gitian-build] Move manifest files to output directory.
Thu, Oct 10, 16:24
jasonbcox requested review of D4231: [gitian-build] Refactor to calculate output directories in fewer places.
Thu, Oct 10, 16:05
jasonbcox planned changes to D4232: [gitian-build] Move manifest files to output directory.
Thu, Oct 10, 13:56
jasonbcox planned changes to D4231: [gitian-build] Refactor to calculate output directories in fewer places.
Thu, Oct 10, 13:56
jasonbcox updated the test plan for D4232: [gitian-build] Move manifest files to output directory.
Thu, Oct 10, 02:46
jasonbcox updated the test plan for D4231: [gitian-build] Refactor to calculate output directories in fewer places.
Thu, Oct 10, 02:46
jasonbcox updated the summary of D4232: [gitian-build] Move manifest files to output directory.
Thu, Oct 10, 02:46
jasonbcox created D4232: [gitian-build] Move manifest files to output directory.
Thu, Oct 10, 02:46
jasonbcox updated the test plan for D4231: [gitian-build] Refactor to calculate output directories in fewer places.
Thu, Oct 10, 02:44
jasonbcox created D4231: [gitian-build] Refactor to calculate output directories in fewer places.
Thu, Oct 10, 02:40

Wed, Oct 9

jasonbcox committed rSTAGINGcdddac09dfb4: [build-configurations] Make BUILD_DIR configurable (authored by jasonbcox).
[build-configurations] Make BUILD_DIR configurable
Wed, Oct 9, 20:12
jasonbcox committed rSTAGING79eec8bc0714: [build-configurations] Resurface the more informative error message when… (authored by jasonbcox).
[build-configurations] Resurface the more informative error message when…
Wed, Oct 9, 20:12
jasonbcox committed rSTAGING54cbf5636d1b: Minor improvements to github-release script (authored by jasonbcox).
Minor improvements to github-release script
Wed, Oct 9, 20:10
jasonbcox committed rSTAGING4a4b489b0d84: Change CI builds to use utf-8 encoding (authored by jasonbcox).
Change CI builds to use utf-8 encoding
Wed, Oct 9, 20:10
jasonbcox committed rSTAGING7af048cfc2b0: Added support for `export LC_ALL=C.UTF-8` to the shell linter (authored by jasonbcox).
Added support for `export LC_ALL=C.UTF-8` to the shell linter
Wed, Oct 9, 20:10
jasonbcox committed rSTAGINGf2c61fd8c087: Updated release-process to use github-release.sh (authored by jasonbcox).
Updated release-process to use github-release.sh
Wed, Oct 9, 20:10
jasonbcox committed rSTAGINGa3ec2f6a0686: Added more explicit instructions for release tagging (authored by jasonbcox).
Added more explicit instructions for release tagging
Wed, Oct 9, 20:10
jasonbcox committed rSTAGING84b63b2cde4d: Bump version to 0.20.4 (authored by jasonbcox).
Bump version to 0.20.4
Wed, Oct 9, 20:10
jasonbcox committed rSTAGING5ab2f96ed68d: Add phpcs exclusion for strict_types declararion (authored by jasonbcox).
Add phpcs exclusion for strict_types declararion
Wed, Oct 9, 20:10
jasonbcox committed rSTAGING65e770d8d5b5: Added a script for creating Github release drafts (authored by jasonbcox).
Added a script for creating Github release drafts
Wed, Oct 9, 20:10
jasonbcox requested changes to D4224: Rename some seeder options.

+1 to release notes

Wed, Oct 9, 00:20

Tue, Oct 8

jasonbcox committed rABCcdddac09dfb4: [build-configurations] Make BUILD_DIR configurable (authored by jasonbcox).
[build-configurations] Make BUILD_DIR configurable
Tue, Oct 8, 21:45
jasonbcox closed D4213: [build-configurations] Make BUILD_DIR configurable.
Tue, Oct 8, 21:45

Mon, Oct 7

jasonbcox committed rABC79eec8bc0714: [build-configurations] Resurface the more informative error message when… (authored by jasonbcox).
[build-configurations] Resurface the more informative error message when…
Mon, Oct 7, 18:44
jasonbcox closed D4214: [build-configurations] Resurface the more informative error message when ABC_BUILD_NAME is not set.
Mon, Oct 7, 18:44
jasonbcox added a comment to D4214: [build-configurations] Resurface the more informative error message when ABC_BUILD_NAME is not set.

Good point on the composability aspect. I started to notice issues arising from the current design while working on D4213. It's more clear to me now that a composable design would make it more robust in addition to providing the caller with more customization of the build.

Mon, Oct 7, 17:13
jasonbcox updated the diff for D4214: [build-configurations] Resurface the more informative error message when ABC_BUILD_NAME is not set.

Fix according to feedback

Mon, Oct 7, 17:10
jasonbcox updated the diff for D4213: [build-configurations] Make BUILD_DIR configurable.

Fix failing check-java tests

Mon, Oct 7, 17:04
jasonbcox planned changes to D4213: [build-configurations] Make BUILD_DIR configurable.
Mon, Oct 7, 16:28
jasonbcox updated the diff for D4213: [build-configurations] Make BUILD_DIR configurable.

Prevent re-runs of setup bleeding the default value previously set on BUILD_DIR

Mon, Oct 7, 16:28

Fri, Oct 4

jasonbcox accepted D4207: Bump wallet version for pre split keypool.

Considering the error message, I would prefer that this is merged with D4206. Landing immediately after is acceptable as long as the diffs don't cross release boundaries, but why risk it in the first place?

Fri, Oct 4, 21:57
jasonbcox accepted D4206: Allow -upgradewallet to upgradewallets to HD and use a keypool of presplit keys after upgrading to hd chain split.
Fri, Oct 4, 21:45
jasonbcox added inline comments to D4206: Allow -upgradewallet to upgradewallets to HD and use a keypool of presplit keys after upgrading to hd chain split.
Fri, Oct 4, 21:35
jasonbcox updated the diff for D4213: [build-configurations] Make BUILD_DIR configurable.

Simplify build dir creation

Fri, Oct 4, 21:12
jasonbcox updated the test plan for D4213: [build-configurations] Make BUILD_DIR configurable.
Fri, Oct 4, 21:10
jasonbcox updated the diff for D4213: [build-configurations] Make BUILD_DIR configurable.

Fixed a bug where non-existant build dir would fail

Fri, Oct 4, 21:09
jasonbcox updated the summary of D4195: Added a land bot script.
Fri, Oct 4, 21:04
jasonbcox updated the diff for D4195: Added a land bot script.
  • Rebase on D4213 and take advantage of it to make this script more robust.
  • Cleanup the repo state, especially in the case of failures.
Fri, Oct 4, 21:04
jasonbcox created D4214: [build-configurations] Resurface the more informative error message when ABC_BUILD_NAME is not set.
Fri, Oct 4, 21:01
jasonbcox created D4213: [build-configurations] Make BUILD_DIR configurable.
Fri, Oct 4, 20:53
jasonbcox added a comment to D4200: Generic TransactionSignatureCreator works with both CTransaction and CMutableTransaction.
  1. Reduced code ownership.
  2. Reduced cognitive load on merge conflicts.
Fri, Oct 4, 16:40
jasonbcox accepted D4200: Generic TransactionSignatureCreator works with both CTransaction and CMutableTransaction.
Fri, Oct 4, 16:21

Thu, Oct 3

jasonbcox added inline comments to D4200: Generic TransactionSignatureCreator works with both CTransaction and CMutableTransaction.
Thu, Oct 3, 23:28
jasonbcox triaged T689: Backport of Core PR13131 as Low priority.
Thu, Oct 3, 23:22 · Restricted Project
jasonbcox triaged T688: Backport Core PR13235 as High priority.
Thu, Oct 3, 23:15 · Restricted Project
jasonbcox closed T416: October backport session as Resolved.
Thu, Oct 3, 22:02 · Backport
jasonbcox closed T445: December backports as Resolved.
Thu, Oct 3, 22:01 · Restricted Project
jasonbcox closed T569: Backport PR12843, a subtask of T446: Backport Core PR 12904, as Resolved.
Thu, Oct 3, 22:01 · Restricted Project
jasonbcox closed T569: Backport PR12843 as Resolved.
Thu, Oct 3, 22:01
jasonbcox closed T446: Backport Core PR 12904, a subtask of T445: December backports, as Resolved.
Thu, Oct 3, 22:00 · Restricted Project
jasonbcox closed T446: Backport Core PR 12904 as Resolved.
Thu, Oct 3, 22:00 · Restricted Project
jasonbcox closed T623: Backport Core PR 13023 as Resolved.

D3436

Thu, Oct 3, 21:59
jasonbcox closed T663: Automate updating assume valid chainparams, a subtask of T646: Release Automation, as Resolved.
Thu, Oct 3, 21:58 · Restricted Project, Restricted Project
jasonbcox closed T663: Automate updating assume valid chainparams as Resolved.
Thu, Oct 3, 21:58 · Restricted Project, Restricted Project
jasonbcox accepted D4208: Added translations for new send coins dialog box.
Thu, Oct 3, 21:55
jasonbcox requested changes to D4208: Added translations for new send coins dialog box.

Where did these translations come from? (should be in summary)

Thu, Oct 3, 20:55
jasonbcox accepted D4201: Separate HaveKey function that checks whether a key is in a keystore.
Thu, Oct 3, 20:51