Page MenuHomePhabricator

jasonbcox (Jason Cox)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Sep 6 2017, 16:08 (123 w, 2 d)
Roles
Administrator

Recent Activity

Today

jasonbcox created D5012: Merge #14494: Error if # is used in rpcpassword in conf.
Sat, Jan 18, 01:15
jasonbcox created D5011: Merge #14413: tests: Allow closed rpc handler in assert_start_raises_init_error.
Sat, Jan 18, 00:51
jasonbcox created D5009: Merge #14105: util: Report parse errors in configuration file.
Sat, Jan 18, 00:40

Yesterday

jasonbcox updated the diff for D4807: Add instructions for verifying download integrity against release signer keys.

Fixes according to feedback:

  • Merge common lines into a single step
  • Fix file verification step when the working directory isn't clean
Fri, Jan 17, 23:31
jasonbcox updated the diff for D5004: Merge #14146: wallet: Remove trailing separators from -walletdir arg.

Rebase on D5008

Fri, Jan 17, 22:46
jasonbcox added inline comments to D5004: Merge #14146: wallet: Remove trailing separators from -walletdir arg.
Fri, Jan 17, 22:46
jasonbcox committed rABC7f1f8a59cc69: Merge #13862: utils: drop boost::interprocess::file_lock (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13862: utils: drop boost::interprocess::file_lock
Fri, Jan 17, 22:34
jasonbcox closed D5005: Merge #13862: utils: drop boost::interprocess::file_lock.
Fri, Jan 17, 22:34
jasonbcox added inline comments to D5004: Merge #14146: wallet: Remove trailing separators from -walletdir arg.
Fri, Jan 17, 22:33
jasonbcox accepted D5008: [CMAKE] Run wallet tests as part of the check-bitcoin target.

Beat me to it. For posterity, this was missed in D4698

Fri, Jan 17, 22:32
jasonbcox updated the diff for D5005: Merge #13862: utils: drop boost::interprocess::file_lock.

Fix sloppy includes merge

Fri, Jan 17, 22:05
jasonbcox accepted D4961: [CMAKE] Add a check_linker_flag function.
Fri, Jan 17, 22:05
jasonbcox lowered the priority of T692: Fix apptests from Unbreak Now! to Low.
Fri, Jan 17, 21:51
jasonbcox accepted D5007: [CMAKE] Fix getentropy detection on OSX.
Fri, Jan 17, 21:45
jasonbcox accepted D5006: [CMAKE] Fix daemon() detection on OSX.
Fri, Jan 17, 20:46
jasonbcox created D5005: Merge #13862: utils: drop boost::interprocess::file_lock.
Fri, Jan 17, 19:54
jasonbcox committed rABCe65bde748260: Temporary fix for recent build flakiness (authored by jasonbcox).
Temporary fix for recent build flakiness
Fri, Jan 17, 19:24
jasonbcox closed D5003: Temporary fix for recent build flakiness.
Fri, Jan 17, 19:24
jasonbcox created D5004: Merge #14146: wallet: Remove trailing separators from -walletdir arg.
Fri, Jan 17, 18:44
jasonbcox accepted D4967: Merge #14108: tests: Add missing locking annotations and locks (g_cs_orphans).

For posterity: the failed run was on the wrong build agent and should be ignored. The resource intensive build passed as expected.

Fri, Jan 17, 18:38
jasonbcox committed rABCf1b94edf4392: Update manpages for 0.20.11 release (authored by jasonbcox).
Update manpages for 0.20.11 release
Fri, Jan 17, 18:07
jasonbcox closed D4969: Update manpages for 0.20.11 release.
Fri, Jan 17, 18:07
jasonbcox committed rABC5b51ba74e77a: Merge #12804: [tests] Fix intermittent rpc_net.py failure. (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #12804: [tests] Fix intermittent rpc_net.py failure.
Fri, Jan 17, 18:07
jasonbcox closed D4966: Merge #12804: [tests] Fix intermittent rpc_net.py failure..
Fri, Jan 17, 18:07
jasonbcox committed rABC91dde1e3db09: Update seeds (authored by jasonbcox).
Update seeds
Fri, Jan 17, 18:06
jasonbcox closed D4970: Update seeds.
Fri, Jan 17, 18:06
jasonbcox committed rABCff116589e783: Update chainparams (authored by jasonbcox).
Update chainparams
Fri, Jan 17, 18:05
jasonbcox closed D4968: Update chainparams.
Fri, Jan 17, 18:05
jasonbcox created D5003: Temporary fix for recent build flakiness.
Fri, Jan 17, 18:01
jasonbcox created D4970: Update seeds.
Fri, Jan 17, 00:29
jasonbcox created D4969: Update manpages for 0.20.11 release.
Fri, Jan 17, 00:22
jasonbcox created D4968: Update chainparams.
Fri, Jan 17, 00:19

Thu, Jan 16

jasonbcox accepted D4965: Merge #13126: util: Add Clang thread safety annotations for variables guarded by cs_args.
Thu, Jan 16, 23:41
jasonbcox requested changes to D4967: Merge #14108: tests: Add missing locking annotations and locks (g_cs_orphans).

test plan needs TSAN not Werror

Thu, Jan 16, 23:26
jasonbcox updated subscribers of D4965: Merge #13126: util: Add Clang thread safety annotations for variables guarded by cs_args.
Thu, Jan 16, 23:25
jasonbcox requested changes to D4965: Merge #13126: util: Add Clang thread safety annotations for variables guarded by cs_args.

werror doesn't test anything interesting here. What you want is TSAN (thread sanitizer)

Thu, Jan 16, 23:20
jasonbcox committed rABCff3a2b5084c7: Merge #15507: test: Bump timeout on tests (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #15507: test: Bump timeout on tests
Thu, Jan 16, 23:06
jasonbcox closed D4964: Merge #15507: test: Bump timeout on tests.
Thu, Jan 16, 23:06
jasonbcox created D4966: Merge #12804: [tests] Fix intermittent rpc_net.py failure..
Thu, Jan 16, 23:02
jasonbcox added inline comments to D4964: Merge #15507: test: Bump timeout on tests.
Thu, Jan 16, 22:47
jasonbcox created D4964: Merge #15507: test: Bump timeout on tests.
Thu, Jan 16, 22:46
jasonbcox accepted D4418: Add unit tests for parse_name().
Thu, Jan 16, 22:13
jasonbcox accepted D4943: Make the test suite name unique in the JUnit result file.
Thu, Jan 16, 21:58
jasonbcox requested changes to D4961: [CMAKE] Add a check_linker_flag function.
Thu, Jan 16, 21:56
jasonbcox abandoned D4950: Fully revert D4803 due to TSAN test failures.
Thu, Jan 16, 18:07
jasonbcox commandeered D4950: Fully revert D4803 due to TSAN test failures.

Fabien took care of the revert in this diff: D4959

Thu, Jan 16, 18:07
jasonbcox accepted D4959: Revert "Prevent callback overruns in InvalidateBlock and RewindBlockIndex".
Thu, Jan 16, 18:06
jasonbcox accepted D4958: [CMAKE] Remove useless remove_compile_flag in leveldb.
Thu, Jan 16, 16:46
jasonbcox accepted D4950: Fully revert D4803 due to TSAN test failures.

Something appears to be flaky that is unrelated. Hopefully we'll see more info on CI soon, because that last failed build was missing some logs (log issue is now fixed).

Thu, Jan 16, 16:44

Wed, Jan 15

jasonbcox accepted D4954: [secp256k1] fix tests.c in the count == 0 case.
Wed, Jan 15, 23:32
jasonbcox requested changes to D4943: Make the test suite name unique in the JUnit result file.

We had discussed offline about adding the commandline args to the junit name to make it obvious which test run it was. Any reason why you didn't include this? I think it drastically improves the usability of this fix.

Wed, Jan 15, 22:41
jasonbcox accepted D4939: Move the functional test temporary directory under the build directory.
Wed, Jan 15, 17:07
jasonbcox accepted D4927: [CI] Use ninja targets instead of calling binaries.
Wed, Jan 15, 17:06

Tue, Jan 14

jasonbcox accepted D4942: Call FinalizeBlockAndInvalidate without cs_main held.

Sanitizer tests look ok to me.

Tue, Jan 14, 20:48
jasonbcox accepted D4938: Move the JUnit file to the temporary directory.

It's important to note that CI sets tmpdir to be within the build dir, so the CI can find these reports. Otherwise, reviewers may mistakenly believe the junit_reports will end up in /tmp/ on CI.

Tue, Jan 14, 18:09
jasonbcox requested changes to D4942: Call FinalizeBlockAndInvalidate without cs_main held.
Tue, Jan 14, 17:43
jasonbcox committed rABCb2c7043ba97e: Add a script to generate sha256sums from Gitian output (authored by jasonbcox).
Add a script to generate sha256sums from Gitian output
Tue, Jan 14, 17:25
jasonbcox closed D4893: Add a script to generate sha256sums from Gitian output.
Tue, Jan 14, 17:25
jasonbcox added a comment to D4893: Add a script to generate sha256sums from Gitian output.

While I don't have anything against that patch per se, it seems somewhat questionable that the signing process that core used was ditched in favor of something that clearly requires work.

Tue, Jan 14, 17:24

Mon, Jan 13

jasonbcox accepted D4924: [CI] Add a configuration to build and run the benchmarks.
Mon, Jan 13, 18:13
jasonbcox added a comment to D4925: [CI] Split build-default into build-diff and build-master.

This diff makes it 2 different configurations instead, making it easier to follow and easier to maintain.

I think the most important part is that in addition to easier to maintain and follow, it's easier to test locally. Although testing is part of maintenance, I think this is clearly the most important part of this change.

Mon, Jan 13, 18:09
jasonbcox accepted D4925: [CI] Split build-default into build-diff and build-master.

This diff makes it 2 different configurations instead, making it easier to follow and easier to maintain.

Mon, Jan 13, 18:06
jasonbcox updated the test plan for D4807: Add instructions for verifying download integrity against release signer keys.
Mon, Jan 13, 17:58
jasonbcox updated the diff for D4807: Add instructions for verifying download integrity against release signer keys.
  • Use versioned keys.txt file from bitcoinabc.org or github.com depending on availability by version.
  • Fixed a bug where the script would break on multiple signature files.
Mon, Jan 13, 17:52

Sun, Jan 12

jasonbcox committed rABC67412d1ef956: Add keys to source package (authored by jasonbcox).
Add keys to source package
Sun, Jan 12, 17:54
jasonbcox closed D4828: Add keys to source package.
Sun, Jan 12, 17:54

Sat, Jan 11

Vjteuro awarded rABC5c61837cc260: Wrap paths in codeblocks in release-process.md a Like token.
Sat, Jan 11, 20:53
jasonbcox accepted D4891: Free BerkeleyEnvironment instances when not in use.
Sat, Jan 11, 16:50
jasonbcox committed rABC5c61837cc260: Wrap paths in codeblocks in release-process.md (authored by jasonbcox).
Wrap paths in codeblocks in release-process.md
Sat, Jan 11, 16:50
jasonbcox closed D4890: Wrap paths in codeblocks in release-process.md.
Sat, Jan 11, 16:50
jasonbcox updated the diff for D4893: Add a script to generate sha256sums from Gitian output.

Make the patterns less greedy by including a weak requirement for version number

Sat, Jan 11, 16:49
jasonbcox added inline comments to D4893: Add a script to generate sha256sums from Gitian output.
Sat, Jan 11, 16:44
jasonbcox added inline comments to D4893: Add a script to generate sha256sums from Gitian output.
Sat, Jan 11, 16:39
jasonbcox created D4893: Add a script to generate sha256sums from Gitian output.
Sat, Jan 11, 01:07

Fri, Jan 10

jasonbcox accepted D4879: Increase sparsity of pippenger fixed window naf representation.
Fri, Jan 10, 23:04
jasonbcox updated the diff for D4890: Wrap paths in codeblocks in release-process.md.

Switch backticks in section 3 to a link

Fri, Jan 10, 22:56
jasonbcox committed rABC93315d55ead0: Remove unnecessary major.minor version from gitian-descriptors (authored by jasonbcox).
Remove unnecessary major.minor version from gitian-descriptors
Fri, Jan 10, 22:42
jasonbcox closed D4889: Remove unnecessary major.minor version from gitian-descriptors.
Fri, Jan 10, 22:42
jasonbcox requested changes to D4891: Free BerkeleyEnvironment instances when not in use.

Everything looks good except for the one missed line in the comment.

Fri, Jan 10, 22:36
jasonbcox accepted D4888: Add Clang thread safety annotations for variables guarded by cs_db.
Fri, Jan 10, 22:24
jasonbcox created D4890: Wrap paths in codeblocks in release-process.md.
Fri, Jan 10, 19:51
jasonbcox created D4889: Remove unnecessary major.minor version from gitian-descriptors.
Fri, Jan 10, 19:30
jasonbcox committed rABC1960118f3dd3: Make ECM error message more helpful (authored by jasonbcox).
Make ECM error message more helpful
Fri, Jan 10, 17:34
jasonbcox closed D4881: Make ECM error message more helpful.
Fri, Jan 10, 17:34
jasonbcox abandoned D4880: Add update-version script.

Embarrassing I forgot about this: D2286

Fri, Jan 10, 16:47

Thu, Jan 9

jasonbcox created D4881: Make ECM error message more helpful.
Thu, Jan 9, 21:56
jasonbcox added inline comments to D4871: Added OP_ENDIAN_REVERSE+implementation, added (always disabled) activation flag, added tests for OP_ENDIAN_REVERSE..
Thu, Jan 9, 21:40
jasonbcox added inline comments to D4880: Add update-version script.
Thu, Jan 9, 21:16
jasonbcox created D4880: Add update-version script.
Thu, Jan 9, 21:12

Wed, Jan 8

jasonbcox accepted D4833: Add pippenger_wnaf for multi-multiplication.

Please write a runnable test plan.

Wed, Jan 8, 22:48
jasonbcox accepted D3898: Use best-fit strategy in Arena, now O(log(n)) instead O(n).
Wed, Jan 8, 22:05
jasonbcox committed rABC991c11f90bc0: Bump version to 0.20.11 (authored by jasonbcox).
Bump version to 0.20.11
Wed, Jan 8, 18:01
jasonbcox closed D4850: Bump version to 0.20.11.
Wed, Jan 8, 18:01
jasonbcox accepted D4826: Add a facility to extract libsecp256k1 from the repository.

Nit: I would prefer quoted echo statements, but this is probably best left to a linter.

Wed, Jan 8, 03:56

Tue, Jan 7

jasonbcox updated the diff for D4850: Bump version to 0.20.11.

Remove erroneously copied release note from the archived note file

Tue, Jan 7, 19:20
jasonbcox added inline comments to D4850: Bump version to 0.20.11.
Tue, Jan 7, 19:18
jasonbcox created D4850: Bump version to 0.20.11.
Tue, Jan 7, 19:18
jasonbcox accepted D4849: Clean up more instances of create_transaction().
Tue, Jan 7, 18:52
jasonbcox accepted D4848: [UBSAN] Fix UBSAN issue in test_bitcon_main.cpp.
Tue, Jan 7, 18:14

Mon, Jan 6

jasonbcox abandoned D1442: Discourage selfish mining by favoring blocks with more accurate timestamps.

Regarding this: I noticed in a recent reddit discussion that ProHashing does not use accurate timestamps: https://www.reddit.com/r/btc/comments/bqy05r/sensible_defaults_and_unintended_consequences_of/eo9f9fa/
If this is seriously planned to be landed, then it would be good to actually talk to miners and see what they think.

Mon, Jan 6, 20:40