Page MenuHomePhabricator

jasonbcox (Jason B. Cox)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Sep 6 2017, 16:08 (163 w, 4 d)
Roles
Administrator
Slack Username
jasonbcox

Recent Activity

Fri, Oct 23

jasonbcox closed D8090: Automatically show a customized message for the upgrade notice before and after activation.
Fri, Oct 23, 22:51
jasonbcox committed rABCWEBa6e76b9d7f3e: Automatically show a customized message for the upgrade notice before and after… (authored by jasonbcox).
Automatically show a customized message for the upgrade notice before and after…
Fri, Oct 23, 22:51
jasonbcox closed D8089: Add an upgrade notice on the release page.
Fri, Oct 23, 22:51
jasonbcox committed rABCWEB5fbbb36af49e: Add an upgrade notice on the release page (authored by jasonbcox).
Add an upgrade notice on the release page
Fri, Oct 23, 22:51
jasonbcox requested review of D8091: Bump version to 0.22.6.
Fri, Oct 23, 22:50
jasonbcox requested review of D8090: Automatically show a customized message for the upgrade notice before and after activation.
Fri, Oct 23, 22:13
jasonbcox updated the diff for D8089: Add an upgrade notice on the release page.

Move the upgrade notice to an include

Fri, Oct 23, 21:11
jasonbcox requested review of D8089: Add an upgrade notice on the release page.
Fri, Oct 23, 21:04
jasonbcox closed D8064: Merge #18262: bnb: exit selection when best_waste is 0.
Fri, Oct 23, 18:44
jasonbcox committed rABC113104448c86: Merge #18262: bnb: exit selection when best_waste is 0 (authored by Samuel Dobson <dobsonsa68@gmail.com>).
Merge #18262: bnb: exit selection when best_waste is 0
Fri, Oct 23, 18:44
jasonbcox accepted D8085: [BUILDBOT] Use phabricator version from master instead of pip.
Fri, Oct 23, 17:16
jasonbcox accepted D8026: [backport#14696 2/2] New regression testing for CVE-2018-17144, CVE-2012-2459, and CVE-2010-5137..
Fri, Oct 23, 17:13
jasonbcox accepted D8081: Remove the Dockerfile-doxygen file.
Fri, Oct 23, 17:05

Thu, Oct 22

jasonbcox closed D8063: Merge #17522: test: Wait until mempool is loaded in wallet_abandonconflict.
Thu, Oct 22, 23:21
jasonbcox committed rABCecc9c997c95d: Merge #17522: test: Wait until mempool is loaded in wallet_abandonconflict (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #17522: test: Wait until mempool is loaded in wallet_abandonconflict
Thu, Oct 22, 23:21
jasonbcox requested review of D8064: Merge #18262: bnb: exit selection when best_waste is 0.
Thu, Oct 22, 23:08
jasonbcox requested review of D8063: Merge #17522: test: Wait until mempool is loaded in wallet_abandonconflict.
Thu, Oct 22, 22:53
jasonbcox closed D8034: Merge #13928: qa: blocktools enforce named args for amount.
Thu, Oct 22, 22:00
jasonbcox committed rABC7eb5e1e2e49a: Merge #13928: qa: blocktools enforce named args for amount (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #13928: qa: blocktools enforce named args for amount
Thu, Oct 22, 22:00
jasonbcox closed D8060: [build-bot] Fix database test when an extension is not present on the database file.
Thu, Oct 22, 21:25
jasonbcox committed rABC47e2944da10c: [build-bot] Fix database test when an extension is not present on the database… (authored by jasonbcox).
[build-bot] Fix database test when an extension is not present on the database…
Thu, Oct 22, 21:25
jasonbcox accepted D8057: [backport#15558] Do not query all DNS seed at once.
Thu, Oct 22, 21:17
jasonbcox requested changes to D8026: [backport#14696 2/2] New regression testing for CVE-2018-17144, CVE-2012-2459, and CVE-2010-5137..
Thu, Oct 22, 21:16
jasonbcox requested changes to D8057: [backport#15558] Do not query all DNS seed at once.
Thu, Oct 22, 17:38
jasonbcox accepted D8058: [BUILDBOT] Remove unecessary imports of the phabricator library.
Thu, Oct 22, 17:32
jasonbcox requested review of D8034: Merge #13928: qa: blocktools enforce named args for amount.

Re-ran CI. It looks like the new logging fix is working, so hopefully we can nail the flakiness in that test soon.

Thu, Oct 22, 17:15
jasonbcox requested review of D8060: [build-bot] Fix database test when an extension is not present on the database file.
Thu, Oct 22, 17:05
jasonbcox closed D8059: Add more release notes.
Thu, Oct 22, 16:08
jasonbcox committed rABC8e73a882cb48: Add more release notes (authored by jasonbcox).
Add more release notes
Thu, Oct 22, 16:08
jasonbcox requested review of D8059: Add more release notes.
Thu, Oct 22, 16:05

Wed, Oct 21

jasonbcox requested changes to D8026: [backport#14696 2/2] New regression testing for CVE-2018-17144, CVE-2012-2459, and CVE-2010-5137..
Wed, Oct 21, 21:53
jasonbcox closed D8031: Merge #15772: test: Properly log named args in authproxy.
Wed, Oct 21, 21:41
jasonbcox committed rABC0064e37fff35: Merge #15772: test: Properly log named args in authproxy (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #15772: test: Properly log named args in authproxy
Wed, Oct 21, 21:41
jasonbcox requested review of D8034: Merge #13928: qa: blocktools enforce named args for amount.
Wed, Oct 21, 21:35
jasonbcox closed D8033: Merge #14664: example_test.py: fixup coinbase height argument, derive number clearly.
Wed, Oct 21, 21:28
jasonbcox committed rABC438ec29b07f7: Merge #14664: example_test.py: fixup coinbase height argument, derive number… (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14664: example_test.py: fixup coinbase height argument, derive number…
Wed, Oct 21, 21:28
jasonbcox closed D8030: [build-bot] Fix skipping comments in ignore list.
Wed, Oct 21, 21:21
jasonbcox committed rABCa99c8c9710a8: [build-bot] Fix skipping comments in ignore list (authored by jasonbcox).
[build-bot] Fix skipping comments in ignore list
Wed, Oct 21, 21:21
jasonbcox accepted D8012: Add <datadir>/settings.json persistent settings storage..
Wed, Oct 21, 21:18
jasonbcox closed D8028: [build-bot] Use unittest.assert* instead of plain asserts.
Wed, Oct 21, 21:01
jasonbcox committed rABCab27bf8d7a87: [build-bot] Use unittest.assert* instead of plain asserts (authored by jasonbcox).
[build-bot] Use unittest.assert* instead of plain asserts
Wed, Oct 21, 21:01
jasonbcox closed D8032: Merge #15631: qa: mininode: Clearer error message on invalid magic bytes.
Wed, Oct 21, 20:47
jasonbcox committed rABC25ce183dcc9f: Merge #15631: qa: mininode: Clearer error message on invalid magic bytes (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #15631: qa: mininode: Clearer error message on invalid magic bytes
Wed, Oct 21, 20:47
jasonbcox closed D7994: [build-bot] Persist build info between redeployments.
Wed, Oct 21, 19:54
jasonbcox committed rABC594d974a35d2: [build-bot] Persist build info between redeployments (authored by jasonbcox).
[build-bot] Persist build info between redeployments
Wed, Oct 21, 19:54
jasonbcox closed D8029: [build-bot] Correctly match hex in ignore pattern for flaky Windows cross-builds.
Wed, Oct 21, 19:39
jasonbcox committed rABC7aec57ad89cd: [build-bot] Correctly match hex in ignore pattern for flaky Windows cross-builds (authored by jasonbcox).
[build-bot] Correctly match hex in ignore pattern for flaky Windows cross-builds
Wed, Oct 21, 19:39
jasonbcox updated the diff for D8030: [build-bot] Fix skipping comments in ignore list.

Added strip() to detect indented comments as well

Wed, Oct 21, 19:22
jasonbcox requested review of D8033: Merge #14664: example_test.py: fixup coinbase height argument, derive number clearly.
Wed, Oct 21, 18:53
jasonbcox requested review of D8032: Merge #15631: qa: mininode: Clearer error message on invalid magic bytes.
Wed, Oct 21, 18:48
jasonbcox closed D8015: Revert "Revert recent coin selection changes".
Wed, Oct 21, 18:44
jasonbcox added a reverting change for D7729: Revert recent coin selection changes: rABC54fef78d5b20: Revert "Revert recent coin selection changes".
Wed, Oct 21, 18:44
jasonbcox committed rABC54fef78d5b20: Revert "Revert recent coin selection changes" (authored by jasonbcox).
Revert "Revert recent coin selection changes"
Wed, Oct 21, 18:44
jasonbcox added a reverting change for rABC85f266319f58: Revert recent coin selection changes: rABC54fef78d5b20: Revert "Revert recent coin selection changes".
Wed, Oct 21, 18:44
jasonbcox requested review of D8031: Merge #15772: test: Properly log named args in authproxy.
Wed, Oct 21, 18:43
jasonbcox requested review of D8030: [build-bot] Fix skipping comments in ignore list.
Wed, Oct 21, 18:26
jasonbcox requested review of D8029: [build-bot] Correctly match hex in ignore pattern for flaky Windows cross-builds.
Wed, Oct 21, 18:23
jasonbcox requested review of D8028: [build-bot] Use unittest.assert* instead of plain asserts.
Wed, Oct 21, 17:26
jasonbcox updated the diff for D7994: [build-bot] Persist build info between redeployments.

Fixed according to feedback

Wed, Oct 21, 16:55
jasonbcox updated the diff for D8015: Revert "Revert recent coin selection changes".
  • Rebase
  • Updated summary to better reflect the "why"
Wed, Oct 21, 16:28
jasonbcox updated the summary of D8015: Revert "Revert recent coin selection changes".
Wed, Oct 21, 16:27
jasonbcox closed D8014: test: Set catch_system_errors=no on boost unit tests.
Wed, Oct 21, 16:04
jasonbcox committed rABC1a60077296f7: test: Set catch_system_errors=no on boost unit tests (authored by jasonbcox).
test: Set catch_system_errors=no on boost unit tests
Wed, Oct 21, 16:04
jasonbcox added inline comments to D8014: test: Set catch_system_errors=no on boost unit tests.
Wed, Oct 21, 00:35
jasonbcox requested review of D8015: Revert "Revert recent coin selection changes".
Wed, Oct 21, 00:33
jasonbcox added inline comments to D8015: Revert "Revert recent coin selection changes".
Wed, Oct 21, 00:14
jasonbcox updated the test plan for D8015: Revert "Revert recent coin selection changes".
Wed, Oct 21, 00:13
jasonbcox added a comment to D8015: Revert "Revert recent coin selection changes".

@bot build-tsan

Wed, Oct 21, 00:13
jasonbcox planned changes to D8015: Revert "Revert recent coin selection changes".
Wed, Oct 21, 00:12
jasonbcox requested review of D8015: Revert "Revert recent coin selection changes".
Wed, Oct 21, 00:12
jasonbcox added a reverting change for D7729: Revert recent coin selection changes: D8015: Revert "Revert recent coin selection changes".
Wed, Oct 21, 00:12
jasonbcox added a reverting change for rABC85f266319f58: Revert recent coin selection changes: D8015: Revert "Revert recent coin selection changes".
Wed, Oct 21, 00:12

Tue, Oct 20

jasonbcox requested review of D8014: test: Set catch_system_errors=no on boost unit tests.
Tue, Oct 20, 23:46
jasonbcox requested changes to D8012: Add <datadir>/settings.json persistent settings storage..

Back to you. Still a translation issue.

Tue, Oct 20, 19:10
jasonbcox accepted D8011: util: Add ReadSettings and WriteSettings functions.
Tue, Oct 20, 19:09
jasonbcox closed D7996: Merge #16957: 9% less memory: make SaltedOutpointHasher noexcept.
Tue, Oct 20, 17:33
jasonbcox committed rABC7caa48fc89ba: Merge #16957: 9% less memory: make SaltedOutpointHasher noexcept (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
Merge #16957: 9% less memory: make SaltedOutpointHasher noexcept
Tue, Oct 20, 17:33
jasonbcox accepted D8006: [backport#16822 1/3] gui: rename encrypt(), blank(), disablePrivateKeys().
Tue, Oct 20, 16:16
jasonbcox accepted D8008: [backport#16822 3/3] gui: fix autofocus in CreateWalletActivity::askPassphrase().
Tue, Oct 20, 16:06
jasonbcox accepted D8007: [backport#16822 2/3] gui: fix passphrase labels/tooltip in createwalletdialog/askpassphrasedialog.
Tue, Oct 20, 16:05
jasonbcox requested changes to D8006: [backport#16822 1/3] gui: rename encrypt(), blank(), disablePrivateKeys().
Tue, Oct 20, 16:04
jasonbcox accepted D8010: [backport#16847] doc: add comments clarifying how local services are advertised.
Tue, Oct 20, 16:00
jasonbcox closed D7995: Merge #16931: test: add unittests for CheckProofOfWork.
Tue, Oct 20, 15:59
jasonbcox committed rABCa87c1a8f2312: Merge #16931: test: add unittests for CheckProofOfWork (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
Merge #16931: test: add unittests for CheckProofOfWork
Tue, Oct 20, 15:59
jasonbcox updated the diff for D7996: Merge #16957: 9% less memory: make SaltedOutpointHasher noexcept.

Rebase

Tue, Oct 20, 15:58
jasonbcox accepted D8009: doc: Add detailed info about Bitcoin Core files.
Tue, Oct 20, 15:49
jasonbcox accepted D7990: refactor: Pass NodeContext to RPC and REST methods through util::Ref.
Tue, Oct 20, 15:44
jasonbcox closed T614: Backport Core PR 11640 as Resolved.
Tue, Oct 20, 00:36 · Bootcamp, Restricted Project
jasonbcox closed T613: Backport Core PR 10587 as Resolved.
Tue, Oct 20, 00:36 · Bootcamp, Restricted Project
jasonbcox closed T612: Backport Core PR 10408, a subtask of T613: Backport Core PR 10587, as Resolved.
Tue, Oct 20, 00:36 · Bootcamp, Restricted Project
jasonbcox closed T612: Backport Core PR 10408 as Resolved.
Tue, Oct 20, 00:36 · Bootcamp, Restricted Project
jasonbcox closed T558: Backport Core PR 12830 as Resolved.
Tue, Oct 20, 00:35 · Bootcamp, Restricted Project
jasonbcox closed T246: Testing scripts should run all tests as Resolved.
Tue, Oct 20, 00:34 · Bootcamp
jasonbcox closed T189: Ensure documentation for new developers is easy to understand as Resolved.

Resolving this since the docs are constantly improving and this task is too open-ended. Patches to improve the docs further are always welcome.

Tue, Oct 20, 00:33 · Bootcamp
jasonbcox closed T191: Fix missing-braces warnings. as Resolved.
Tue, Oct 20, 00:29 · Bootcamp
jasonbcox closed T321: Create test to check node banning behavior as Resolved.
Tue, Oct 20, 00:28 · Bootcamp
jasonbcox updated the diff for D7994: [build-bot] Persist build info between redeployments.

Rebase

Tue, Oct 20, 00:27
jasonbcox updated the diff for D7996: Merge #16957: 9% less memory: make SaltedOutpointHasher noexcept.

Rebase

Tue, Oct 20, 00:25
jasonbcox updated the diff for D7995: Merge #16931: test: add unittests for CheckProofOfWork.

Rebase so that CI passes with the new build-debug config

Tue, Oct 20, 00:25
jasonbcox requested review of D7996: Merge #16957: 9% less memory: make SaltedOutpointHasher noexcept.
Tue, Oct 20, 00:20