Page MenuHomePhabricator

jasonbcox (Jason Cox)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Sep 6 2017, 16:08 (92 w, 4 d)
Roles
Administrator

Recent Activity

Yesterday

jasonbcox added inline comments to D3332: remove SCRIPT_ENABLE_SCHNORR flag and clean up tests.
Sat, Jun 15, 00:20
jasonbcox added inline comments to D3253: Remove Schnorr activation.
Sat, Jun 15, 00:20
jasonbcox added inline comments to D3331: remove effect of SCRIPT_ENABLE_SCHNORR flag.
Sat, Jun 15, 00:18
D3253: Remove Schnorr activation now requires changes to proceed.
Sat, Jun 15, 00:09

Fri, Jun 14

D3344: Merge #10999: Fix amounts formatting in `decoderawtransaction` now requires changes to proceed.
Fri, Jun 14, 23:58
D3346: bench: Simplify CoinSelection is now accepted and ready to land.
Fri, Jun 14, 23:52
D3339: Make CMutableTransaction constructor explicit is now accepted and ready to land.
Fri, Jun 14, 23:49
D3345: Kill MAX_FREE_TRANSACTION_CREATE_SIZE is now accepted and ready to land.
Fri, Jun 14, 22:16
D3338: bitcoin-tx: Remove unused for loop is now accepted and ready to land.
Fri, Jun 14, 22:14
D3337: Remove redundant code in MutateTxSign(CMutableTransaction&, const std::string&) is now accepted and ready to land.
Fri, Jun 14, 22:13
jasonbcox added inline comments to D3336: tests: Avoid copies of CTransaction.
Fri, Jun 14, 22:12
jasonbcox updated the test plan for D3295: Added a script to automate collecting and updating seeds.
Fri, Jun 14, 22:04
jasonbcox added a comment to D3295: Added a script to automate collecting and updating seeds.
  • Added sanity checks at various steps in the seed updating process
  • Added basic error checking
  • Added ability to skip one set of seeds if it fails
Fri, Jun 14, 22:00
jasonbcox planned changes to D3340: Cleanup ibd.sh.
Fri, Jun 14, 18:46
jasonbcox created D3340: Cleanup ibd.sh.
Fri, Jun 14, 18:45
jasonbcox committed rABC164b37e003d6: Explicitly call out updating makeseeds.py after major releases (authored by jasonbcox).
Explicitly call out updating makeseeds.py after major releases
Fri, Jun 14, 18:16
jasonbcox closed D3292: Explicitly call out updating makeseeds.py after major releases.
Fri, Jun 14, 18:16
D3329: [txindex] transaction Hash -> TxId is now accepted and ready to land.
Fri, Jun 14, 16:18
jasonbcox retitled D3292: Explicitly call out updating makeseeds.py after major releases from Explicitly call out updating makeseeds.py for major releases to Explicitly call out updating makeseeds.py after major releases.
Fri, Jun 14, 01:00
jasonbcox added a comment to D3292: Explicitly call out updating makeseeds.py after major releases.

Should come after a major release, not during

Fri, Jun 14, 01:00
D3316: Update mempool eviction benchmark is now accepted and ready to land.
Fri, Jun 14, 00:54
jasonbcox updated the summary of D3316: Update mempool eviction benchmark.
Fri, Jun 14, 00:52
D3328: Take a CTransaction as argument for ValidateCheckInputsForAllFlags is now accepted and ready to land.
Fri, Jun 14, 00:51
jasonbcox retitled D3328: Take a CTransaction as argument for ValidateCheckInputsForAllFlags from Take a CTransactiona s argument for ValidateCheckInputsForAllFlags to Take a CTransaction as argument for ValidateCheckInputsForAllFlags.
Fri, Jun 14, 00:50
D3327: Avoid creating transaction copies in script_tests.cpp and multisig_tests.cpp is now accepted and ready to land.
Fri, Jun 14, 00:49
D3326: Relayout comments in validation.cpp is now accepted and ready to land.
Fri, Jun 14, 00:45
D3317: Use MakeTransactionRef in serialize_tests.cpp is now accepted and ready to land.
Fri, Jun 14, 00:45
D3307: mempool: Fix missing locking in CTxMemPool::check(…) and CTxMemPool::setSanityCheck(…) is now accepted and ready to land.
Fri, Jun 14, 00:43
D3313: Make float <-> int casts explicit outside of test, qt, CFeeRate is now accepted and ready to land.
Fri, Jun 14, 00:34
D3330: Directly use CMutableTransaction more often in txvaidationcache_tests.cpp is now accepted and ready to land.
Fri, Jun 14, 00:31
D3329: [txindex] transaction Hash -> TxId now requires changes to proceed.
Fri, Jun 14, 00:24
D3315: Make m_coinbase_txns a vector of CTransactionRef is now accepted and ready to land.
Fri, Jun 14, 00:19
D3314: coinbaseTxns => m_coinbase_txns is now accepted and ready to land.

For posterity: D3315 explains why the name change is not applied by simply backporting this PR: https://github.com/bitcoin/bitcoin/pull/12949/files

Fri, Jun 14, 00:14
jasonbcox committed rABCd44c820bd23a: Bump version to 0.19.9 (authored by jasonbcox).
Bump version to 0.19.9
Fri, Jun 14, 00:04
jasonbcox closed D3325: Bump version to 0.19.9.
Fri, Jun 14, 00:04
jasonbcox updated the test plan for D3193: Added update-chainparams.py to fetch and replace assume valid block values from a node using HTTP RPC.
Fri, Jun 14, 00:03
jasonbcox added a comment to D3193: Added update-chainparams.py to fetch and replace assume valid block values from a node using HTTP RPC.
  • Added unit tests
  • Improved test coverage
  • Added new unit tests as a new cmake target check-devtools
  • Fixed some bugs in the original script as a result of the new tests
Fri, Jun 14, 00:01

Thu, Jun 13

jasonbcox retitled D3325: Bump version to 0.19.9 from Bump version to 0.19.8 to Bump version to 0.19.9.
Thu, Jun 13, 20:31
jasonbcox created D3325: Bump version to 0.19.9.
Thu, Jun 13, 20:31
jasonbcox added a comment to D3308: Merge #9894: remove 'label' filter for rpc command help.

Investigate the duplicate RPCs in the help message. It sounds to me like some of the accounts code as either not deprecated correctly or needs to be cleaned up before this is backported.

Thu, Jun 13, 20:24
D3324: Merge #9949: [bench] Avoid function call arguments which are pointers to uninitialized values is now accepted and ready to land.
Thu, Jun 13, 20:01
jasonbcox closed D3323: Add missing release notes for 0.19.8 release.
Thu, Jun 13, 19:59
jasonbcox committed rABC2f7b26a00036: Add missing release notes for 0.19.8 release (authored by jasonbcox).
Add missing release notes for 0.19.8 release
Thu, Jun 13, 19:59
jasonbcox committed rABC60dea04ed605: Update manpages for 0.19.8 release (authored by jasonbcox).
Update manpages for 0.19.8 release
Thu, Jun 13, 17:55
jasonbcox closed D3322: Update manpages for 0.19.8 release.
Thu, Jun 13, 17:55
jasonbcox committed rABC64576902969d: Update seeds for 0.19.8 release (authored by jasonbcox).
Update seeds for 0.19.8 release
Thu, Jun 13, 17:54
jasonbcox closed D3320: Update seeds for 0.19.8 release.
Thu, Jun 13, 17:54
jasonbcox committed rABCc106fcb25e17: Updated chainparams for 0.19.8 release (authored by jasonbcox).
Updated chainparams for 0.19.8 release
Thu, Jun 13, 17:54
jasonbcox closed D3321: Updated chainparams for 0.19.8 release.
Thu, Jun 13, 17:54
jasonbcox created D3323: Add missing release notes for 0.19.8 release.
Thu, Jun 13, 17:46
jasonbcox created D3322: Update manpages for 0.19.8 release.
Thu, Jun 13, 17:31
jasonbcox created D3321: Updated chainparams for 0.19.8 release.
Thu, Jun 13, 17:26
jasonbcox created D3320: Update seeds for 0.19.8 release.
Thu, Jun 13, 17:20

Wed, Jun 12

jasonbcox added a comment to D3193: Added update-chainparams.py to fetch and replace assume valid block values from a node using HTTP RPC.

Missed Amaury's comment regarding testing. This is a good idea and should be included.

Wed, Jun 12, 15:40
D3297: Eliminate fee overpaying edge case when subtracting fee from recipients is now accepted and ready to land.
Wed, Jun 12, 00:38
D3296: Don't create change at the dust limit, even if it means paying more than expected is now accepted and ready to land.
Wed, Jun 12, 00:34

Tue, Jun 11

jasonbcox updated the test plan for D3193: Added update-chainparams.py to fetch and replace assume valid block values from a node using HTTP RPC.
Tue, Jun 11, 23:45
jasonbcox added a comment to D3193: Added update-chainparams.py to fetch and replace assume valid block values from a node using HTTP RPC.

Fixes according to feedback

Tue, Jun 11, 23:43
jasonbcox added inline comments to D3193: Added update-chainparams.py to fetch and replace assume valid block values from a node using HTTP RPC.
Tue, Jun 11, 23:42
D3283: Merge #10408, #13291, and partial #13163 now requires changes to proceed.
Tue, Jun 11, 23:40
jasonbcox updated the summary of D3295: Added a script to automate collecting and updating seeds.
Tue, Jun 11, 23:08
jasonbcox added a comment to D3295: Added a script to automate collecting and updating seeds.

Still need to update docs, but looking for a concept ACK before continuing.

Tue, Jun 11, 23:00
jasonbcox created D3295: Added a script to automate collecting and updating seeds.
Tue, Jun 11, 22:59
jasonbcox created D3292: Explicitly call out updating makeseeds.py after major releases.
Tue, Jun 11, 22:24
jasonbcox committed rABCacb45f2c4e35: Merge #9350: [Trivial] Adding label for amount inside of tx_valid/tx_invalid. (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #9350: [Trivial] Adding label for amount inside of tx_valid/tx_invalid.
Tue, Jun 11, 16:23
jasonbcox closed D3279: Merge #9350: [Trivial] Adding label for amount inside of tx_valid/tx_invalid.json.
Tue, Jun 11, 16:23
jasonbcox committed rABCe137db475ec6: Merge #10090: Update bitcoin.conf with example for pruning (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #10090: Update bitcoin.conf with example for pruning
Tue, Jun 11, 16:22
jasonbcox closed D3281: Merge #10090: Update bitcoin.conf with example for pruning.
Tue, Jun 11, 16:22
jasonbcox committed rABCc17c0116e853: Merge #10177: Changed "Send" button default status from true to false (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #10177: Changed "Send" button default status from true to false
Tue, Jun 11, 16:21
jasonbcox closed D3282: Merge #10177: Changed "Send" button default status from true to false.
Tue, Jun 11, 16:20
jasonbcox committed rABC504322bef4ed: Merge #10404: doc: Add logging to FinalizeNode() (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #10404: doc: Add logging to FinalizeNode()
Tue, Jun 11, 16:19
jasonbcox closed D3284: Merge #10404: doc: Add logging to FinalizeNode().
Tue, Jun 11, 16:19
jasonbcox committed rABCa9d60a397d35: Merge #10460: Broadcast address every day, not 9 hours (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #10460: Broadcast address every day, not 9 hours
Tue, Jun 11, 16:18
jasonbcox closed D3286: Merge #10460: Broadcast address every day, not 9 hours.
Tue, Jun 11, 16:18
jasonbcox accepted D3256: Fix make distcheck.
Tue, Jun 11, 16:08

Mon, Jun 10

jasonbcox requested review of D3286: Merge #10460: Broadcast address every day, not 9 hours.
Mon, Jun 10, 23:23
jasonbcox planned changes to D3286: Merge #10460: Broadcast address every day, not 9 hours.
Mon, Jun 10, 23:18
jasonbcox created D3286: Merge #10460: Broadcast address every day, not 9 hours.
Mon, Jun 10, 23:18
D3285: Merge #10587: Net: Fix resource leak in ReadBinaryFile(...) is now accepted and ready to land.
Mon, Jun 10, 23:03
D3283: Merge #10408, #13291, and partial #13163 now requires changes to proceed.
Mon, Jun 10, 23:03
D3278: Merge #10536: Remove unreachable or otherwise redundant code is now accepted and ready to land.
Mon, Jun 10, 22:56
D3268: Increase test coverage on CScript.IsPushOnly() now requires changes to proceed.
Mon, Jun 10, 22:49
jasonbcox requested review of D3284: Merge #10404: doc: Add logging to FinalizeNode().
Mon, Jun 10, 21:31
jasonbcox updated the test plan for D3284: Merge #10404: doc: Add logging to FinalizeNode().
Mon, Jun 10, 21:31
jasonbcox planned changes to D3284: Merge #10404: doc: Add logging to FinalizeNode().
Mon, Jun 10, 21:30
jasonbcox created D3284: Merge #10404: doc: Add logging to FinalizeNode().
Mon, Jun 10, 21:30
jasonbcox requested review of D3282: Merge #10177: Changed "Send" button default status from true to false.
Mon, Jun 10, 21:27
jasonbcox updated the test plan for D3282: Merge #10177: Changed "Send" button default status from true to false.
Mon, Jun 10, 21:26
jasonbcox created D3282: Merge #10177: Changed "Send" button default status from true to false.
Mon, Jun 10, 21:23
jasonbcox planned changes to D3282: Merge #10177: Changed "Send" button default status from true to false.
Mon, Jun 10, 21:23
D3273: qa: Normalize executable location is now accepted and ready to land.
Mon, Jun 10, 21:16
jasonbcox requested review of D3281: Merge #10090: Update bitcoin.conf with example for pruning.
Mon, Jun 10, 21:15
jasonbcox updated the test plan for D3281: Merge #10090: Update bitcoin.conf with example for pruning.
Mon, Jun 10, 21:15
jasonbcox updated the test plan for D3281: Merge #10090: Update bitcoin.conf with example for pruning.
Mon, Jun 10, 21:14
jasonbcox updated the test plan for D3281: Merge #10090: Update bitcoin.conf with example for pruning.
Mon, Jun 10, 21:11
jasonbcox planned changes to D3281: Merge #10090: Update bitcoin.conf with example for pruning.
Mon, Jun 10, 21:08
jasonbcox created D3281: Merge #10090: Update bitcoin.conf with example for pruning.
Mon, Jun 10, 21:08
jasonbcox created D3279: Merge #9350: [Trivial] Adding label for amount inside of tx_valid/tx_invalid.json.
Mon, Jun 10, 20:48
jasonbcox added inline comments to D3273: qa: Normalize executable location.
Mon, Jun 10, 20:36
D3270: add CScript::IsMinimalPushOnly now requires changes to proceed.

Needs a summary. What's the goal here?

Mon, Jun 10, 17:12