Page MenuHomePhabricator
Feed Advanced Search

Fri, Feb 5

jasonbcox resigned from D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.
Fri, Feb 5, 20:04

Thu, Feb 4

jasonbcox closed D9159: Use npm ci instead of install for docker deployments.
Thu, Feb 4, 16:08
jasonbcox committed rABC81b7eac423d6: Use npm ci instead of install for docker deployments (authored by jasonbcox).
Use npm ci instead of install for docker deployments
Thu, Feb 4, 16:08
jasonbcox closed D9158: Do not bust cached npm-installed dependencies when source files change.
Thu, Feb 4, 16:06
jasonbcox committed rABC5ba6211c6d43: Do not bust cached npm-installed dependencies when source files change (authored by jasonbcox).
Do not bust cached npm-installed dependencies when source files change
Thu, Feb 4, 16:06
jasonbcox closed D9157: Do not bust cached apt-install'd dependencies when source files change.
Thu, Feb 4, 16:04
jasonbcox committed rABC6daeacab5488: Do not bust cached apt-install'd dependencies when source files change (authored by jasonbcox).
Do not bust cached apt-install'd dependencies when source files change
Thu, Feb 4, 16:04

Wed, Feb 3

jasonbcox requested review of D9158: Do not bust cached npm-installed dependencies when source files change.
Wed, Feb 3, 21:58
jasonbcox requested review of D9159: Use npm ci instead of install for docker deployments.
Wed, Feb 3, 21:36
jasonbcox updated the test plan for D9157: Do not bust cached apt-install'd dependencies when source files change.
Wed, Feb 3, 21:29
jasonbcox requested review of D9158: Do not bust cached npm-installed dependencies when source files change.
Wed, Feb 3, 21:29
jasonbcox requested review of D9157: Do not bust cached apt-install'd dependencies when source files change.
Wed, Feb 3, 21:17

Jan 27 2021

jasonbcox updated the diff for D8673: Add -overridednsseed for testing DNS seed behavior.

Separated out GetRandomizedDNSSeeds into its own files. Over time, these new files can house the
DNS seed related logic and constants that currently reside in the net.h/cpp mess.

Jan 27 2021, 00:22

Jan 5 2021

jasonbcox added inline comments to D8673: Add -overridednsseed for testing DNS seed behavior.
Jan 5 2021, 00:45
jasonbcox updated the diff for D8673: Add -overridednsseed for testing DNS seed behavior.
  • Rename DNSSeeds -> GetRandomizedDNSSeeds
  • Make the currently node-specific randomization logic available to the seeder
  • Doing the above also incidentally makes better use of the vector copy that I introduced in this patch.
Jan 5 2021, 00:41

Dec 29 2020

jasonbcox accepted D8707: [WEBSITE] Remove the BCHN variant from the release page.
Dec 29 2020, 17:26
jasonbcox requested changes to D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.
Dec 29 2020, 17:21

Dec 28 2020

jasonbcox accepted D8757: [backport#17674] tests: Add initialization order fiasco detection in Travis.
Dec 28 2020, 17:53
jasonbcox accepted D8756: [backport#17205] ci: Enable address sanitizer (ASan) stack-use-after-return checking.
Dec 28 2020, 17:50
jasonbcox requested changes to D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.

Tests still failing.

Dec 28 2020, 17:49
jasonbcox accepted D8760: Bump version to 0.22.11.
Dec 28 2020, 17:48

Dec 21 2020

jasonbcox requested changes to D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.

abc_mining_basic.py still needs to test that the old prefix is valid for mining

Dec 21 2020, 19:25

Dec 17 2020

jasonbcox added inline comments to D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.
Dec 17 2020, 23:54
jasonbcox updated the diff for D8673: Add -overridednsseed for testing DNS seed behavior.
  • Fixed checking if the arg is set
  • Added another sanity checking test case
Dec 17 2020, 23:30
jasonbcox requested changes to D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.
Dec 17 2020, 22:36

Dec 14 2020

jasonbcox added a comment to D8673: Add -overridednsseed for testing DNS seed behavior.

The cppcheck issue appears to be a bug in cppcheck. Fabien has confirmed this lint error does not appear in a newer version.

Dec 14 2020, 20:12
jasonbcox updated the diff for D5380: [seeder] Require good seeds to have latest checkpoint.
  • Refactor and simplify the logic tracking checkpoint state
  • Refactor and simplify the tests
  • Rewrite summary and test plan
  • New changes depend on D8673 to make the test plan easier to understand by simple examination of the command line arguments in each step.
Dec 14 2020, 20:10
jasonbcox updated the summary of D5380: [seeder] Require good seeds to have latest checkpoint.
Dec 14 2020, 20:04
jasonbcox updated the test plan for D5380: [seeder] Require good seeds to have latest checkpoint.
Dec 14 2020, 20:03
jasonbcox updated the test plan for D5380: [seeder] Require good seeds to have latest checkpoint.
Dec 14 2020, 20:03
jasonbcox updated the test plan for D5380: [seeder] Require good seeds to have latest checkpoint.
Dec 14 2020, 19:51
jasonbcox updated the test plan for D5380: [seeder] Require good seeds to have latest checkpoint.
Dec 14 2020, 19:49
jasonbcox updated the test plan for D5380: [seeder] Require good seeds to have latest checkpoint.
Dec 14 2020, 19:45
jasonbcox updated the test plan for D5380: [seeder] Require good seeds to have latest checkpoint.
Dec 14 2020, 19:20
jasonbcox updated the test plan for D5380: [seeder] Require good seeds to have latest checkpoint.
Dec 14 2020, 19:18
jasonbcox updated the test plan for D5380: [seeder] Require good seeds to have latest checkpoint.
Dec 14 2020, 18:52
jasonbcox updated the test plan for D5380: [seeder] Require good seeds to have latest checkpoint.
Dec 14 2020, 18:47
jasonbcox requested review of D8673: Add -overridednsseed for testing DNS seed behavior.
Dec 14 2020, 18:31

Dec 12 2020

jasonbcox updated the test plan for D5380: [seeder] Require good seeds to have latest checkpoint.
Dec 12 2020, 00:21
jasonbcox updated the test plan for D5380: [seeder] Require good seeds to have latest checkpoint.
Dec 12 2020, 00:14
jasonbcox retitled D5380: [seeder] Require good seeds to have latest checkpoint from Seeder requires good seeds to have block after most recent checkpoint in its chain and bans those that don't to [seeder] Require good seeds to have latest checkpoint.
Dec 12 2020, 00:13
jasonbcox closed D6283: [seeder] Request headers from new connections.
Dec 12 2020, 00:00
jasonbcox committed rABC8099bc1028b2: [seeder] Request headers from new connections (authored by jasonbcox).
[seeder] Request headers from new connections
Dec 12 2020, 00:00

Dec 11 2020

jasonbcox commandeered D5380: [seeder] Require good seeds to have latest checkpoint.
Dec 11 2020, 22:09
jasonbcox abandoned D8486: Temporarily disable caching for css and js files.
Dec 11 2020, 22:05
jasonbcox accepted D8650: refactor: Use AbortError in FatalError.
Dec 11 2020, 01:32
jasonbcox closed D8657: Update seeds.
Dec 11 2020, 00:36
jasonbcox committed rABC1a4c91afe748: Update seeds (authored by jasonbcox).
Update seeds
Dec 11 2020, 00:36
jasonbcox accepted D8658: refactor: Fix unreachable code in init arg checks (part 2).
Dec 11 2020, 00:03

Dec 10 2020

jasonbcox accepted D8649: Pass bilingual_str argument to AbortNode().
Dec 10 2020, 23:44
jasonbcox requested review of D8657: Update seeds.
Dec 10 2020, 23:39
jasonbcox accepted D8652: Fix bitcoin-qt RPC when -server is used.

Looks like we need some better test coverage to make sure bitcoin-qt in server mode work as expected.

Dec 10 2020, 23:27
jasonbcox updated the summary of D6283: [seeder] Request headers from new connections.
Dec 10 2020, 23:08
jasonbcox retitled D6283: [seeder] Request headers from new connections from Seeder sends GETHEADERS message to [seeder] Request headers from new connections.
Dec 10 2020, 23:06
jasonbcox updated the diff for D6283: [seeder] Request headers from new connections.

Rebase and add some basic test coverage

Dec 10 2020, 23:05
jasonbcox commandeered D6283: [seeder] Request headers from new connections.
Dec 10 2020, 23:04
jasonbcox closed D8624: [seeder] Add a test to check outgoing messages in response to VERACK.
Dec 10 2020, 17:57
jasonbcox committed rABC6b57151f3e4d: [seeder] Add a test to check outgoing messages in response to VERACK (authored by jasonbcox).
[seeder] Add a test to check outgoing messages in response to VERACK
Dec 10 2020, 17:57
jasonbcox abandoned D8641: Make version constants fixed-width.
Dec 10 2020, 02:47
teamcity awarded D8642: [seeder] Use GetTime() utility function instead of accessing ctime directly a Haypence token.
Dec 10 2020, 02:47
jasonbcox added a comment to D8642: [seeder] Use GetTime() utility function instead of accessing ctime directly.

@bot build-linux32 build-osx

Dec 10 2020, 02:47
jasonbcox requested review of D8642: [seeder] Use GetTime() utility function instead of accessing ctime directly.
Dec 10 2020, 02:46
teamcity awarded D8641: Make version constants fixed-width a Haypence token.
Dec 10 2020, 01:56
jasonbcox added a comment to D8641: Make version constants fixed-width.

@bot build-linux32 build-osx

Dec 10 2020, 01:56
jasonbcox planned changes to D8641: Make version constants fixed-width.
Dec 10 2020, 01:55
jasonbcox requested review of D8641: Make version constants fixed-width.
Dec 10 2020, 01:55
jasonbcox closed D6357: Dedup net message writing code in the seeder.
Dec 10 2020, 00:06
jasonbcox committed rABC2a8d9ce51932: Dedup net message writing code in the seeder (authored by nakihito).
Dedup net message writing code in the seeder
Dec 10 2020, 00:06

Dec 9 2020

jasonbcox updated the diff for D6357: Dedup net message writing code in the seeder.

This was a good question. There's multiple copies going on here and they aren't necessary.
While the handling of the outgoing data stream is not identical between the seeder and the
node software, the new WriteMessage function can easily write directly to the stream in
question instead of copying into an intermediate which then is copied into the outgoing stream.

Dec 9 2020, 22:16
jasonbcox updated the diff for D8624: [seeder] Add a test to check outgoing messages in response to VERACK.
  • Improve the API for testing
  • Use NetMsgType::GETADDR in place of a hardcoded string
  • Other minor nits
Dec 9 2020, 18:47

Dec 8 2020

jasonbcox closed D8623: [seeder] Use netmagic from chainparams instead of a cached global.
Dec 8 2020, 19:43
jasonbcox committed rABC207a1f435e9e: [seeder] Use netmagic from chainparams instead of a cached global (authored by jasonbcox).
[seeder] Use netmagic from chainparams instead of a cached global
Dec 8 2020, 19:43
jasonbcox closed D8622: Fix seeder linking due to missing dependency in libcommon.
Dec 8 2020, 19:41
jasonbcox committed rABC68ba35006344: Fix seeder linking due to missing dependency in libcommon (authored by jasonbcox).
Fix seeder linking due to missing dependency in libcommon
Dec 8 2020, 19:41

Dec 7 2020

jasonbcox requested review of D8624: [seeder] Add a test to check outgoing messages in response to VERACK.
Dec 7 2020, 23:26
jasonbcox requested review of D8623: [seeder] Use netmagic from chainparams instead of a cached global.
Dec 7 2020, 23:23
jasonbcox closed D8621: Remove 0.21.x from makeseeds.
Dec 7 2020, 21:19
jasonbcox committed rABC94848143d33a: Remove 0.21.x from makeseeds (authored by jasonbcox).
Remove 0.21.x from makeseeds
Dec 7 2020, 21:19
jasonbcox updated the summary of D6357: Dedup net message writing code in the seeder.
Dec 7 2020, 21:17
jasonbcox retitled D6357: Dedup net message writing code in the seeder from Refactor seeder to use CNetMsgMaker to write its messages to Dedup net message writing code in the seeder.
Dec 7 2020, 21:16
jasonbcox updated the summary of D6357: Dedup net message writing code in the seeder.
Dec 7 2020, 21:15
jasonbcox updated the diff for D6357: Dedup net message writing code in the seeder.
  • Rebase ontop of linker fixes: D8622
  • Use netmagic from config instead of hardcoding the values in multiple places. (More cleanup can be done here, but out of scope of this patch)
  • Use TransportSerializer.prepareForTransport to de-dup header serialization code.
Dec 7 2020, 21:14
jasonbcox commandeered D6357: Dedup net message writing code in the seeder.
Dec 7 2020, 21:10
jasonbcox requested review of D8622: Fix seeder linking due to missing dependency in libcommon.
Dec 7 2020, 20:35
jasonbcox requested review of D8621: Remove 0.21.x from makeseeds.
Dec 7 2020, 18:15
jasonbcox accepted D8606: [avalanche] Refactor the PeerManager.
Dec 7 2020, 17:21

Dec 6 2020

jasonbcox accepted D8606: [avalanche] Refactor the PeerManager.
Dec 6 2020, 02:27
jasonbcox accepted D8607: [avalanche] Specify the proof to be used by the node via config.

There's an ava functional test, so at least original behavior still works as expected. Not much more to test here.

Dec 6 2020, 02:10
jasonbcox requested changes to D8607: [avalanche] Specify the proof to be used by the node via config.

Functional test would be ideal. Manual test instructions in the test plan at minimum though. Both would be best :)

Dec 6 2020, 02:08
jasonbcox added inline comments to D8607: [avalanche] Specify the proof to be used by the node via config.
Dec 6 2020, 02:05
jasonbcox accepted D8604: [avalanche] Add nodes using a verifiable delegation instead of asserting the public key.
Dec 6 2020, 02:01

Dec 5 2020

jasonbcox accepted D8602: [avalanche] Add a mechanism to delegate proofs.
Dec 5 2020, 19:00

Dec 4 2020

jasonbcox planned changes to D8600: Refactor chainparams class in preparation for splitting them by network.
Dec 4 2020, 17:42
jasonbcox updated the diff for D8600: Refactor chainparams class in preparation for splitting them by network.

Fix clang build

Dec 4 2020, 17:42
jasonbcox planned changes to D8600: Refactor chainparams class in preparation for splitting them by network.
Dec 4 2020, 17:17
jasonbcox updated the diff for D8600: Refactor chainparams class in preparation for splitting them by network.

Moved function to generated file and fixed test failure

Dec 4 2020, 17:17

Dec 3 2020

jasonbcox requested review of D8600: Refactor chainparams class in preparation for splitting them by network.
Dec 3 2020, 23:26
jasonbcox planned changes to D8600: Refactor chainparams class in preparation for splitting them by network.
Dec 3 2020, 23:26

Dec 2 2020

jasonbcox accepted D8581: Clean up sponsor section of homepage.
Dec 2 2020, 22:14
jasonbcox closed D8579: Run autogen on recent version bump.
Dec 2 2020, 17:03