Page MenuHomePhabricator
Feed Advanced Search

Yesterday

jasonbcox accepted D8501: Just pass a TxId to AddInventoryKnown, rename to AddKnownTx.
Mon, Nov 23, 22:21
jasonbcox closed D8510: Update Electrum ABC link to point to repo maintained under bitcoin-abc Github.
Mon, Nov 23, 22:05
jasonbcox committed rABCWEB0b55832151ce: Update Electrum ABC link to point to repo maintained under bitcoin-abc Github (authored by jasonbcox).
Update Electrum ABC link to point to repo maintained under bitcoin-abc Github
Mon, Nov 23, 22:05
jasonbcox closed D8509: [buildbot] Set build status as passed when a target has no builds.
Mon, Nov 23, 22:03
jasonbcox committed rABCf4ebfd31f403: [buildbot] Set build status as passed when a target has no builds (authored by jasonbcox).
[buildbot] Set build status as passed when a target has no builds
Mon, Nov 23, 22:02
jasonbcox requested review of D8510: Update Electrum ABC link to point to repo maintained under bitcoin-abc Github.
Mon, Nov 23, 22:00
jasonbcox closed D8508: [buildbot] Build targets should default to success when no builds are queued.
Mon, Nov 23, 21:53
jasonbcox committed rABC2fe36f9fec5e: [buildbot] Build targets should default to success when no builds are queued (authored by jasonbcox).
[buildbot] Build targets should default to success when no builds are queued
Mon, Nov 23, 21:53
jasonbcox requested review of D8509: [buildbot] Set build status as passed when a target has no builds.
Mon, Nov 23, 21:39
jasonbcox closed D8504: Add Electrum ABC to supported wallets.
Mon, Nov 23, 21:20
jasonbcox committed rABCWEB6ce4130ca8f9: Add Electrum ABC to supported wallets (authored by jasonbcox).
Add Electrum ABC to supported wallets
Mon, Nov 23, 21:20
jasonbcox requested review of D8508: [buildbot] Build targets should default to success when no builds are queued.
Mon, Nov 23, 21:08
jasonbcox closed D8507: Run secp256k1 tests on diffs where changes to the library are made.
Mon, Nov 23, 21:03
jasonbcox committed rABCf74c5b86af5c: Run secp256k1 tests on diffs where changes to the library are made (authored by jasonbcox).
Run secp256k1 tests on diffs where changes to the library are made
Mon, Nov 23, 21:03
jasonbcox requested review of D8507: Run secp256k1 tests on diffs where changes to the library are made.
Mon, Nov 23, 20:00
jasonbcox accepted D8505: Add landing page for electrum ABC wallet.
Mon, Nov 23, 19:56
jasonbcox closed D8483: Only run node-related builds on diffs where the node software has changed.
Mon, Nov 23, 19:55
jasonbcox committed rABC665129e956ab: Only run node-related builds on diffs where the node software has changed (authored by jasonbcox).
Only run node-related builds on diffs where the node software has changed
Mon, Nov 23, 19:55
jasonbcox requested changes to D8505: Add landing page for electrum ABC wallet.
Mon, Nov 23, 18:58
jasonbcox updated the diff for D8504: Add Electrum ABC to supported wallets.

Rebase

Mon, Nov 23, 18:10
jasonbcox closed D8503: Use absolute paths for images on BCHA page.
Mon, Nov 23, 18:09
jasonbcox committed rABCWEBf881e24b8931: Use absolute paths for images on BCHA page (authored by jasonbcox).
Use absolute paths for images on BCHA page
Mon, Nov 23, 18:09
jasonbcox updated the diff for D8483: Only run node-related builds on diffs where the node software has changed.

Use the template on the clang builds. Even though changes to functional tests only will be a false positive,
catching changes to /cmake are important. Functional test only changes are not super common, so we
can live with this tradeoff to reduce maintenance overhead and reduce false negatives.

Mon, Nov 23, 17:40
jasonbcox updated the diff for D8483: Only run node-related builds on diffs where the node software has changed.

Used a template where it makes sense. For the others, it doesn't make sense to run them when
only changes to the functional tests are made.

Mon, Nov 23, 17:36
jasonbcox requested review of D8504: Add Electrum ABC to supported wallets.
Mon, Nov 23, 17:23
jasonbcox requested review of D8503: Use absolute paths for images on BCHA page.
Mon, Nov 23, 17:20

Fri, Nov 20

jasonbcox planned changes to D8486: Temporarily disable caching for css and js files.
Fri, Nov 20, 22:18
jasonbcox requested review of D8486: Temporarily disable caching for css and js files.
Fri, Nov 20, 22:18
jasonbcox accepted D8485: Add version tag to main.css file.

Let's try this. If this doesn't work well, we can disable caching all together.

Fri, Nov 20, 22:16
jasonbcox accepted D8484: Moving bcha page CSS to main.css.
Fri, Nov 20, 21:25
jasonbcox requested changes to D8484: Moving bcha page CSS to main.css.

Please remove the reference to overrides.css from the bcha page too

Fri, Nov 20, 21:21
jasonbcox requested review of D8483: Only run node-related builds on diffs where the node software has changed.
Fri, Nov 20, 20:02
jasonbcox closed D8472: [buildbot] Support a list of regex when matching builds to changed files.
Fri, Nov 20, 19:57
jasonbcox committed rABC72637855dccc: [buildbot] Support a list of regex when matching builds to changed files (authored by jasonbcox).
[buildbot] Support a list of regex when matching builds to changed files
Fri, Nov 20, 19:57
jasonbcox updated the diff for D8472: [buildbot] Support a list of regex when matching builds to changed files.

Rebase to fix another issue. See D8482

Fri, Nov 20, 19:12
jasonbcox closed D8482: [buildbot] Fix getcommitpaths result type.
Fri, Nov 20, 19:07
jasonbcox committed rABCf6664ddd8ad6: [buildbot] Fix getcommitpaths result type (authored by jasonbcox).
[buildbot] Fix getcommitpaths result type
Fri, Nov 20, 19:07
jasonbcox requested review of D8482: [buildbot] Fix getcommitpaths result type.
Fri, Nov 20, 18:56
jasonbcox updated the diff for D8472: [buildbot] Support a list of regex when matching builds to changed files.

Rebase with D8481 to fix CI

Fri, Nov 20, 18:38
jasonbcox closed D8481: [buildbot] Fix missing revision_id that is expected to be strictly an integer.
Fri, Nov 20, 18:35
jasonbcox committed rABC33babbf34deb: [buildbot] Fix missing revision_id that is expected to be strictly an integer (authored by jasonbcox).
[buildbot] Fix missing revision_id that is expected to be strictly an integer
Fri, Nov 20, 18:34
jasonbcox requested review of D8481: [buildbot] Fix missing revision_id that is expected to be strictly an integer.
Fri, Nov 20, 16:41
jasonbcox updated the diff for D8472: [buildbot] Support a list of regex when matching builds to changed files.

Rebasing again since buildbot did not finish re-deploying

Fri, Nov 20, 16:30
jasonbcox updated the diff for D8472: [buildbot] Support a list of regex when matching builds to changed files.

Rebase to kick off new buildbot tests on the diff

Fri, Nov 20, 16:13
jasonbcox closed D8471: [buildbot] Introduce selecting diff builds based on filename regex.
Fri, Nov 20, 16:12
jasonbcox committed rABC96022ff9077a: [buildbot] Introduce selecting diff builds based on filename regex (authored by jasonbcox).
[buildbot] Introduce selecting diff builds based on filename regex
Fri, Nov 20, 16:12
jasonbcox committed rABCad746f3c3989: Split chainparams by network (authored by jasonbcox).
Split chainparams by network
Fri, Nov 20, 00:44
jasonbcox updated the diff for D8472: [buildbot] Support a list of regex when matching builds to changed files.

Rebase

Fri, Nov 20, 00:24
jasonbcox closed D8473: [buildbot] Add a facility for fetching the files changed in a given revision.
Fri, Nov 20, 00:20
jasonbcox committed rABCcd684dad5ea7: [buildbot] Add a facility for fetching the files changed in a given revision (authored by jasonbcox).
[buildbot] Add a facility for fetching the files changed in a given revision
Fri, Nov 20, 00:20

Thu, Nov 19

jasonbcox added inline comments to D8474: adding parent dir web/ for web apps.
Thu, Nov 19, 23:16
jasonbcox updated the summary of D8471: [buildbot] Introduce selecting diff builds based on filename regex.
Thu, Nov 19, 22:38
jasonbcox updated the diff for D8471: [buildbot] Introduce selecting diff builds based on filename regex.

Changes according to feedback, and rebased on D8473

Thu, Nov 19, 22:38
jasonbcox requested review of D8473: [buildbot] Add a facility for fetching the files changed in a given revision.
Thu, Nov 19, 21:04
jasonbcox requested review of D8472: [buildbot] Support a list of regex when matching builds to changed files.
Thu, Nov 19, 18:19
jasonbcox updated the summary of D8471: [buildbot] Introduce selecting diff builds based on filename regex.
Thu, Nov 19, 18:08
jasonbcox accepted D8470: refactor: replace CNode pointers by references within net_processing.{h,cpp}.
Thu, Nov 19, 18:04
jasonbcox requested review of D8471: [buildbot] Introduce selecting diff builds based on filename regex.
Thu, Nov 19, 18:03
jasonbcox requested changes to D8470: refactor: replace CNode pointers by references within net_processing.{h,cpp}.
Thu, Nov 19, 17:23
jasonbcox closed D8459: [buildbot] Add revision ID as arg to /buildDiff.
Thu, Nov 19, 17:00
jasonbcox committed rABCc21047603fd7: [buildbot] Add revision ID as arg to /buildDiff (authored by jasonbcox).
[buildbot] Add revision ID as arg to /buildDiff
Thu, Nov 19, 17:00
jasonbcox accepted D8466: Implement CWallet::IsSpentKey for non-LegacySPKMans.
Thu, Nov 19, 16:36
jasonbcox accepted D8467: Return error when no ScriptPubKeyMan is available for specified type.
Thu, Nov 19, 16:34
jasonbcox accepted D8468: Correctly check for default wallet.
Thu, Nov 19, 16:28
jasonbcox requested review of D8459: [buildbot] Add revision ID as arg to /buildDiff.
Thu, Nov 19, 01:21
jasonbcox closed D8456: Set a different default PPA depending on network.
Thu, Nov 19, 00:46
jasonbcox committed rABCd3793e529d04: Set a different default PPA depending on network (authored by jasonbcox).
Set a different default PPA depending on network
Thu, Nov 19, 00:46
jasonbcox requested review of D8456: Set a different default PPA depending on network.
Thu, Nov 19, 00:27

Wed, Nov 18

jasonbcox closed D8440: Bump version to 0.22.8.
Wed, Nov 18, 22:28
jasonbcox committed rABC44267f74fc66: Bump version to 0.22.8 (authored by jasonbcox).
Bump version to 0.22.8
Wed, Nov 18, 22:28
jasonbcox closed D8442: Add temporary file for current release notes page.
Wed, Nov 18, 15:11
jasonbcox committed rABCWEBc15d728253db: Add temporary file for current release notes page (authored by jasonbcox).
Add temporary file for current release notes page
Wed, Nov 18, 15:11

Tue, Nov 17

jasonbcox requested review of D8442: Add temporary file for current release notes page.
Tue, Nov 17, 23:40
jasonbcox requested review of D8440: Bump version to 0.22.8.
Tue, Nov 17, 16:15
jasonbcox closed D8439: Add a release note.
Tue, Nov 17, 16:08
jasonbcox committed rABC010f0a307bcd: Add a release note (authored by jasonbcox).
Add a release note
Tue, Nov 17, 16:08
jasonbcox updated the diff for D8439: Add a release note.

Fixed typo

Tue, Nov 17, 16:00
jasonbcox requested review of D8439: Add a release note.
Tue, Nov 17, 15:58
jasonbcox closed D8422: Add checkpoints for Axion upgrade.
Tue, Nov 17, 15:53
jasonbcox committed rABC95a8a552ad62: Add checkpoints for Axion upgrade (authored by jasonbcox).
Add checkpoints for Axion upgrade
Tue, Nov 17, 15:53
jasonbcox updated the diff for D8422: Add checkpoints for Axion upgrade.

Fix comment

Tue, Nov 17, 15:26

Sun, Nov 15

teamcity awarded D8422: Add checkpoints for Axion upgrade a Haypence token.
Sun, Nov 15, 16:30
jasonbcox added a comment to D8422: Add checkpoints for Axion upgrade.

@bot build-ibd build-ibd-bchn

Sun, Nov 15, 16:30
jasonbcox updated the summary of D8422: Add checkpoints for Axion upgrade.
Sun, Nov 15, 16:29
jasonbcox requested review of D8422: Add checkpoints for Axion upgrade.
Sun, Nov 15, 16:26
jasonbcox closed D8420: Add email form to landing page and sub pages.
Sun, Nov 15, 10:57
jasonbcox committed rABCWEB037f6b044108: Add email form to landing page and sub pages (authored by johnkuney).
Add email form to landing page and sub pages
Sun, Nov 15, 10:57
jasonbcox updated the diff for D8420: Add email form to landing page and sub pages.

Move most of the includes to the footer. This looks better in some cases and puts it on more pages.

Sun, Nov 15, 10:55
jasonbcox updated the diff for D8420: Add email form to landing page and sub pages.

Apply my feedback from earlier

Sun, Nov 15, 10:41
jasonbcox commandeered D8420: Add email form to landing page and sub pages.
Sun, Nov 15, 10:32
jasonbcox added a comment to D8339: Move seed list vector operations into distinct compilation unit.

Ignore the failures. One of the build agents was having a network issue and failed multiple builds.

Sun, Nov 15, 10:23
jasonbcox removed a reviewer for D8420: Add email form to landing page and sub pages: deadalnix.
Sun, Nov 15, 10:01
jasonbcox requested changes to D8420: Add email form to landing page and sub pages.

Similar to docindex, is it possible to add this to the page layout instead of the index and release pages directly?

Sun, Nov 15, 10:01
jasonbcox updated the diff for D8339: Move seed list vector operations into distinct compilation unit.

Move the bulk of the implementation of FixedSeedsList into chainparams.cpp

Sun, Nov 15, 09:31

Fri, Nov 13

jasonbcox accepted D8397: Revert "fuzz: Add process_messages harness".
Fri, Nov 13, 21:00
jasonbcox closed D8396: Make a temporary copy of the latest release notes if the current version is not archived.
Fri, Nov 13, 19:34
jasonbcox committed rABCWEB6119875c7361: Make a temporary copy of the latest release notes if the current version is not… (authored by jasonbcox).
Make a temporary copy of the latest release notes if the current version is not…
Fri, Nov 13, 19:34
jasonbcox requested review of D8396: Make a temporary copy of the latest release notes if the current version is not archived.
Fri, Nov 13, 18:17

Thu, Nov 12

jasonbcox accepted D8374: Refactor message transport packaging.
Thu, Nov 12, 19:42
jasonbcox updated the diff for D8340: Split fixed seeds to support multiple networks.

Rebase. Note that D8339 has taken on some of the changes that were in this
patch as they belong there instead.

Thu, Nov 12, 16:29