Fri, May 24
For posterity: Harbormaster seems to be missing something and not detecting the tests being run, despite them passing. I'm going to land this and keep an eye on master just to be sure.
Add an item in the release notes.
Thu, May 23
Wed, May 22
Tue, May 21
Wed, May 15
Nit: comment these as needed on Windows
Rebase + added missing includes due to refactors over the last couple weeks
Tue, May 14
iirc there are backports that do similar things, but this is a good start regardless
Mon, May 13
Fri, May 10
Added my suggestions which include capitalization, periods, and some rewordings.
still exists in this form in Core.
I notice the comment in merkleblock.h in ABC is noticeably different from Core, did we put that in or missing backport?
Thu, May 9
For posterity: both of those PRs have already been backported.
Thanks for the links. I'll look into them.
This sounds strange: the PR adds a comment to state explicitly that GuessVerificationProgress requires cs_main, and a later PR discard the lock in interfaces/nodes.cpp.
Is it possible that the call from the Node interface could not trigger the behavior described in the GuessVerificationProgress comment, so it is safe to not hold the lock ?