Page MenuHomePhabricator
Feed Advanced Search

Today

jasonbcox committed rABCf3bbfc8e6e74: Merge #10308: [wallet] Securely erase potentially sensitive keys/values (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #10308: [wallet] Securely erase potentially sensitive keys/values
Mon, May 27, 06:13
jasonbcox closed D3107: Merge #10308: [wallet] Securely erase potentially sensitive keys/values.
Mon, May 27, 06:13
jasonbcox committed rABC8c74fb8597cc: Merge #10341: rpc/wallet: Workaround older UniValue which returns a std::string… (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #10341: rpc/wallet: Workaround older UniValue which returns a std::string…
Mon, May 27, 06:08
jasonbcox closed D3106: Merge #10341: rpc/wallet: Workaround older UniValue which returns a std::string temporary for get_str.
Mon, May 27, 06:07
jasonbcox accepted D3123: Merge #13894: shutdown: Stop threads before resetting ptrs.
Mon, May 27, 06:00

Fri, May 24

jasonbcox accepted D3109: Merge #12425: Add some script tests.
Fri, May 24, 23:05
jasonbcox accepted D3110: Merge #12468: Add missing newline in init.cpp log message.
Fri, May 24, 23:03
jasonbcox accepted D3111: [refactor] GetAccount{PubKey,Address} -> GetAccountDestination.
Fri, May 24, 23:02
Herald added a reviewer for D3107: Merge #10308: [wallet] Securely erase potentially sensitive keys/values: Restricted Project.
Fri, May 24, 19:42
Herald added a reviewer for D3106: Merge #10341: rpc/wallet: Workaround older UniValue which returns a std::string temporary for get_str: Restricted Project.
Fri, May 24, 18:08
jasonbcox committed rABC13c0b0619074: Add a test to ensure memory isn't consumed for blocks pre-checkpoint (authored by jasonbcox).
Add a test to ensure memory isn't consumed for blocks pre-checkpoint
Fri, May 24, 16:36
jasonbcox closed D2729: Add a test to ensure memory isn't consumed for blocks pre-checkpoint.
Fri, May 24, 16:35
jasonbcox changed the visibility for D2729: Add a test to ensure memory isn't consumed for blocks pre-checkpoint.
Fri, May 24, 16:28
jasonbcox added a comment to D2729: Add a test to ensure memory isn't consumed for blocks pre-checkpoint.

For posterity: Harbormaster seems to be missing something and not detecting the tests being run, despite them passing. I'm going to land this and keep an eye on master just to be sure.

Fri, May 24, 16:26
jasonbcox accepted D3101: [rpc] Add initialblockdownload to getblockchaininfo.
Fri, May 24, 16:24
jasonbcox accepted D3094: [qa] don't pad transactions during make_conform_to_ctor.
Fri, May 24, 00:49
jasonbcox requested changes to D3101: [rpc] Add initialblockdownload to getblockchaininfo.

Add an item in the release notes.

Fri, May 24, 00:49
jasonbcox updated the diff for D2729: Add a test to ensure memory isn't consumed for blocks pre-checkpoint.

Rebase

Fri, May 24, 00:26

Thu, May 23

jasonbcox accepted D3098: tests: move pwalletMain to wallet test fixture.
Thu, May 23, 21:56
jasonbcox requested changes to D3012: Backport current GetDifficulty logic (& tests) from Core.
Thu, May 23, 21:51
jasonbcox accepted D3021: Merge #12151: rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON.
Thu, May 23, 21:42

Wed, May 22

jasonbcox accepted D3069: Add CHECKDATASIG to standard flags..
Wed, May 22, 16:21
jasonbcox updated the diff for D2729: Add a test to ensure memory isn't consumed for blocks pre-checkpoint.

Rebase

Wed, May 22, 16:16
jasonbcox accepted D3090: Avoid calling add_nodes multiple times in functional tests.
Wed, May 22, 16:07

Tue, May 21

jasonbcox removed a subtask for T646: Release Bot: T655: Migrate bitcoinabc.org to bitcoin-abc repo.
Tue, May 21, 17:23 · Restricted Project, Restricted Project
jasonbcox removed a parent task for T655: Migrate bitcoinabc.org to bitcoin-abc repo: T646: Release Bot.
Tue, May 21, 17:23 · Restricted Project, Restricted Project
jasonbcox added a parent task for T655: Migrate bitcoinabc.org to bitcoin-abc repo: T656: Automate release page.
Tue, May 21, 17:23 · Restricted Project, Restricted Project
jasonbcox added a subtask for T656: Automate release page: T655: Migrate bitcoinabc.org to bitcoin-abc repo.
Tue, May 21, 17:23 · Restricted Project, Restricted Project
jasonbcox triaged T656: Automate release page as High priority.
Tue, May 21, 17:23 · Restricted Project, Restricted Project
jasonbcox triaged T655: Migrate bitcoinabc.org to bitcoin-abc repo as High priority.
Tue, May 21, 17:21 · Restricted Project, Restricted Project

Wed, May 15

jasonbcox accepted D3054: Fix boost::thread::interruption_point causing build failure on Windows.

Nit: comment these as needed on Windows

Wed, May 15, 17:16
jasonbcox accepted D3053: Count checkdatasig for transaction entering the mempool.
Wed, May 15, 14:18
jasonbcox accepted D3052: Update man pages for v0.19.6.
Wed, May 15, 12:41
jasonbcox accepted D3051: Update chainparams for 0.19.6 release.
Wed, May 15, 12:35
jasonbcox updated the diff for D2729: Add a test to ensure memory isn't consumed for blocks pre-checkpoint.

Rebase + added missing includes due to refactors over the last couple weeks

Wed, May 15, 12:15

Tue, May 14

jasonbcox committed rABC0ace84b6fe2e: Merge #9980: Fix mem access violation merkleblock (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Merge #9980: Fix mem access violation merkleblock
Tue, May 14, 16:53
jasonbcox closed D3009: Merge #9980: Fix mem access violation merkleblock.
Tue, May 14, 16:53
jasonbcox committed rABC965b235866e3: Update disclosure policy standards (authored by jasonbcox).
Update disclosure policy standards
Tue, May 14, 16:42
jasonbcox closed D2762: Update disclosure policy standards.
Tue, May 14, 16:42
jasonbcox accepted D3042: Remove useless include of boost thread.

iirc there are backports that do similar things, but this is a good start regardless

Tue, May 14, 16:39
jasonbcox accepted D3011: Merge #9833: Trivial: fix comments referencing AppInit2.
Tue, May 14, 16:11
jasonbcox requested changes to D3021: Merge #12151: rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON.
Tue, May 14, 15:59

Mon, May 13

jasonbcox committed rABC15afe1da08a5: Added missing release notes (authored by jasonbcox).
Added missing release notes
Mon, May 13, 22:35
jasonbcox closed D3037: Added missing release notes.
Mon, May 13, 22:35
jasonbcox requested changes to D3021: Merge #12151: rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON.
Mon, May 13, 19:41
jasonbcox committed rABCd2551147a913: Updated seed list for 0.19.6 release (authored by jasonbcox).
Updated seed list for 0.19.6 release
Mon, May 13, 19:35
jasonbcox closed D3036: Updated seed list for 0.19.6 release.
Mon, May 13, 19:35
Herald added a reviewer for D3037: Added missing release notes: Restricted Project.
Mon, May 13, 19:34
jasonbcox accepted D3010: update release notes.
Mon, May 13, 19:09
Herald added a reviewer for D3036: Updated seed list for 0.19.6 release: Restricted Project.
Mon, May 13, 19:01

Fri, May 10

jasonbcox accepted D3016: build: Remove -I for everything but project root.
Fri, May 10, 16:35
jasonbcox requested changes to D3010: update release notes.

Added my suggestions which include capitalization, periods, and some rewordings.

Fri, May 10, 15:23
jasonbcox requested changes to D3011: Merge #9833: Trivial: fix comments referencing AppInit2.
Fri, May 10, 15:19
jasonbcox added a comment to D3009: Merge #9980: Fix mem access violation merkleblock.

still exists in this form in Core.
I notice the comment in merkleblock.h in ABC is noticeably different from Core, did we put that in or missing backport?

Fri, May 10, 15:17
jasonbcox committed rABC034171f92e1b: Merge #12415: Interrupt loading thread after shutdown request (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #12415: Interrupt loading thread after shutdown request
Fri, May 10, 15:17
jasonbcox closed D2958: Merge #12415: Interrupt loading thread after shutdown request.
Fri, May 10, 15:17
jasonbcox accepted D2939: [backport PR12653] Allow to optional specify the directory for the blocks storage.
Fri, May 10, 01:12
jasonbcox committed rABCe7a2b61eeaee: Merge #10258: Fixed typo in documentation for merkleblock.h (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #10258: Fixed typo in documentation for merkleblock.h
Fri, May 10, 01:10
jasonbcox closed D3008: Merge #10258: Fixed typo in documentation for merkleblock.h.
Fri, May 10, 01:10
jasonbcox added a reverting change for D2999: Merge #10126: Compensate for memory peak at flush time: rABCb809b0250876: Revert "Merge #10126: Compensate for memory peak at flush time".
Fri, May 10, 01:09
jasonbcox added a reverting change for rABC7bd410c3c230: Merge #10126: Compensate for memory peak at flush time: rABCb809b0250876: Revert "Merge #10126: Compensate for memory peak at flush time".
Fri, May 10, 01:09
jasonbcox committed rABCb809b0250876: Revert "Merge #10126: Compensate for memory peak at flush time" (authored by jasonbcox).
Revert "Merge #10126: Compensate for memory peak at flush time"
Fri, May 10, 01:09
jasonbcox closed D3007: Revert "Merge #10126: Compensate for memory peak at flush time".
Fri, May 10, 01:09
Herald added a reviewer for D3009: Merge #9980: Fix mem access violation merkleblock: Restricted Project.
Fri, May 10, 00:30

Thu, May 9

Herald added a reviewer for D3008: Merge #10258: Fixed typo in documentation for merkleblock.h: deadalnix.
Thu, May 9, 23:50
jasonbcox updated the task description for T646: Release Bot.
Thu, May 9, 23:21 · Restricted Project, Restricted Project
jasonbcox updated the test plan for D2958: Merge #12415: Interrupt loading thread after shutdown request.
Thu, May 9, 22:58
jasonbcox updated the diff for D2958: Merge #12415: Interrupt loading thread after shutdown request.

Rebase

Thu, May 9, 22:57
jasonbcox updated the test plan for D2958: Merge #12415: Interrupt loading thread after shutdown request.
Thu, May 9, 22:49
jasonbcox added a parent task for T351: Create an abandon-diff bot: T647: [Epic] Development Automation Base Infra.
Thu, May 9, 22:48 · Restricted Project, Bootcamp
jasonbcox added a parent task for T336: Phabricator to Github repo sync bot: T647: [Epic] Development Automation Base Infra.
Thu, May 9, 22:48
jasonbcox added a parent task for T646: Release Bot: T647: [Epic] Development Automation Base Infra.
Thu, May 9, 22:48 · Restricted Project, Restricted Project
jasonbcox added subtasks for T647: [Epic] Development Automation Base Infra: T646: Release Bot, T351: Create an abandon-diff bot, T336: Phabricator to Github repo sync bot.
Thu, May 9, 22:48 · Restricted Project, Restricted Project
jasonbcox triaged T647: [Epic] Development Automation Base Infra as High priority.
Thu, May 9, 22:47 · Restricted Project, Restricted Project
jasonbcox added a comment to T646: Release Bot.

Related: T336

Thu, May 9, 22:44 · Restricted Project, Restricted Project
jasonbcox triaged T646: Release Bot as High priority.
Thu, May 9, 22:43 · Restricted Project, Restricted Project
jasonbcox requested changes to D2864: [mining] Add package accounting functions to CBlockTemplateEntry.
Thu, May 9, 21:16
jasonbcox requested changes to D2863: [mining] Add fields for tracking package data..
Thu, May 9, 20:55
jasonbcox requested changes to D2939: [backport PR12653] Allow to optional specify the directory for the blocks storage.
Thu, May 9, 20:52
jasonbcox triaged T645: Backport deduplication of version numbers as Normal priority.
Thu, May 9, 19:59 · Restricted Project
jasonbcox added a reverting change for D2999: Merge #10126: Compensate for memory peak at flush time: D3007: Revert "Merge #10126: Compensate for memory peak at flush time".
Thu, May 9, 19:43
jasonbcox added a reverted change for D3007: Revert "Merge #10126: Compensate for memory peak at flush time": D2999: Merge #10126: Compensate for memory peak at flush time.
Thu, May 9, 19:43
jasonbcox added a comment to D2999: Merge #10126: Compensate for memory peak at flush time.

For posterity: both of those PRs have already been backported.

Thu, May 9, 19:43
Herald added a reviewer for D3007: Revert "Merge #10126: Compensate for memory peak at flush time": Restricted Project.
Thu, May 9, 19:41
jasonbcox added a reverting change for rABC7bd410c3c230: Merge #10126: Compensate for memory peak at flush time: D3007: Revert "Merge #10126: Compensate for memory peak at flush time".
Thu, May 9, 19:41
jasonbcox committed rABC7bd410c3c230: Merge #10126: Compensate for memory peak at flush time (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #10126: Compensate for memory peak at flush time
Thu, May 9, 19:32
jasonbcox closed D2999: Merge #10126: Compensate for memory peak at flush time.
Thu, May 9, 19:32
jasonbcox added a comment to D2999: Merge #10126: Compensate for memory peak at flush time.

Thanks for the links. I'll look into them.

Thu, May 9, 19:30
jasonbcox added a comment to D2980: Merge #12287: Optimise lock behaviour for GuessVerificationProgress().
In D2980#70690, @Fabien wrote:

This sounds strange: the PR adds a comment to state explicitly that GuessVerificationProgress requires cs_main, and a later PR discard the lock in interfaces/nodes.cpp.
Is it possible that the call from the Node interface could not trigger the behavior described in the GuessVerificationProgress comment, so it is safe to not hold the lock ?

Thu, May 9, 18:35
jasonbcox closed T641: Backport Core PR 11281 as Resolved.
Thu, May 9, 18:27
jasonbcox closed T641: Backport Core PR 11281, a subtask of T642: Backport Core PR 12287, as Resolved.
Thu, May 9, 18:27
jasonbcox closed T643: Backport Core PR 10265, a subtask of T641: Backport Core PR 11281, as Resolved.
Thu, May 9, 18:27
jasonbcox closed T643: Backport Core PR 10265 as Resolved.
Thu, May 9, 18:27
jasonbcox committed rABCd8446f81da7a: Merge #11281: Avoid permanent cs_main/cs_wallet lock during RescanFromTime (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #11281: Avoid permanent cs_main/cs_wallet lock during RescanFromTime
Thu, May 9, 18:27
jasonbcox closed D2979: Merge #11281: Avoid permanent cs_main/cs_wallet lock during RescanFromTime.
Thu, May 9, 18:27
jasonbcox committed rABC3bd53249b037: Merge #10489: build: silence gcc7's implicit fallthrough warning (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #10489: build: silence gcc7's implicit fallthrough warning
Thu, May 9, 17:41
jasonbcox closed D2960: Merge #10489: build: silence gcc7's implicit fallthrough warning.
Thu, May 9, 17:41
jasonbcox committed rABC10233aae12a2: Merge #10154: init: Remove redundant logging code (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #10154: init: Remove redundant logging code
Thu, May 9, 17:20
jasonbcox closed D3001: Merge #10154: init: Remove redundant logging code.
Thu, May 9, 17:20
jasonbcox committed rABC79fdf71ed0c0: Merge #10128: Speed Up CuckooCache tests (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #10128: Speed Up CuckooCache tests
Thu, May 9, 17:07