HomePhabricator

Fix minerfund in GBT when cashaddr is disabled

Description

Fix minerfund in GBT when cashaddr is disabled

Summary:
When testing changes to https://github.com/viabtc/viabtc_mining_server I noticed that -usecashaddr=0 did
not impact the address format for the miner fund in getblocktemplate. This patch fixes that.

While it would be ideal to move away from legacy address support entirely, it's still very common that mining pool software only support the legacy format. Some reasons to not push for cashaddr-only at this time:

  1. Pushing BCH-prefixed cashaddr doesn't make sense strategically at this time. Once the rebranding is completed, we can put energy behind a rebranded prefix cashaddr.
  2. Pools often mine to the same (legacy) address across different chains, so supporting legacy addresses for the time being is important to them to prevent over-complicating their pool configurations.

Test Plan:

ninja check check-functional

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D9414

Details

Provenance
jasonbcoxAuthored on Apr 12 2021, 18:21
jasonbcoxPushed on Apr 28 2021, 16:59
Reviewer
Restricted Project
Differential Revision
D9414: Fix minerfund in GBT when cashaddr is disabled
Parents
rABC6bcc0e609cb0: [avalanche] set a minimum amount for a proof
Branches
Unknown
Tags
Unknown