Page MenuHomePhabricator
Differential D8652

Fix bitcoin-qt RPC when -server is used
ClosedPublic
Actions

Authored by Fabien on Dec 10 2020, 23:24.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABCd0207bfcd35f: Fix bitcoin-qt RPC when -server is used
Summary

The bug was introduced in D7990. The node name usually designates a
node context, but not in this case.

Test Plan
ninja all check-all

Without this diff, returns a Node context not found error:

./src/qt/bitcoin-qt -server
./src/bitcoin-cli getnetworkinfo

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Dec 10 2020, 23:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 10 2020, 23:24
Fabien requested review of this revision.Dec 10 2020, 23:24
jasonbcox accepted this revision.Dec 10 2020, 23:27
jasonbcox added a subscriber: jasonbcox.

Looks like we need some better test coverage to make sure bitcoin-qt in server mode work as expected.

This revision is now accepted and ready to land.Dec 10 2020, 23:27
Harbormaster completed remote builds in B14379: Diff 26317.Dec 10 2020, 23:37
Closed by commit rABCd0207bfcd35f: Fix bitcoin-qt RPC when -server is used (authored by Fabien). · Explain WhyDec 11 2020, 00:12
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCd0207bfcd35f: Fix bitcoin-qt RPC when -server is used.

Revision Contents
Changeset List

PathSize
src/
qt/
2 lines

Diff 26326

View Options

src/qt/bitcoin.cpp

Loading...