Page MenuHomePhabricator

Fix bitcoin-qt RPC when -server is used
ClosedPublic

Authored by Fabien on Dec 10 2020, 23:24.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABCd0207bfcd35f: Fix bitcoin-qt RPC when -server is used
Summary

The bug was introduced in D7990. The node name usually designates a
node context, but not in this case.

Test Plan
ninja all check-all

Without this diff, returns a Node context not found error:

./src/qt/bitcoin-qt -server
./src/bitcoin-cli getnetworkinfo

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien requested review of this revision.Dec 10 2020, 23:24
jasonbcox added a subscriber: jasonbcox.

Looks like we need some better test coverage to make sure bitcoin-qt in server mode work as expected.

This revision is now accepted and ready to land.Dec 10 2020, 23:27
This revision was automatically updated to reflect the committed changes.