Page MenuHomePhabricator
Differential D7990

refactor: Pass NodeContext to RPC and REST methods through util::Ref
ClosedPublic
Actions

Authored by Fabien on Oct 19 2020, 21:24.

Details

Reviewers
jasonbcox
deadalnix
Group Reviewers
Restricted Project
Commits
rABC5c70631e078b: refactor: Pass NodeContext to RPC and REST methods through util::Ref
Summary
This commit does not change behavior

Partial backport of core PR18740:
https://github.com/bitcoin/bitcoin/pull/18740/commits/6fca33b2edc09ed62dab2323c780b31585de1750#diff-2ae094f9329ce9498e1b4a9cb7767945b54a33b4ee9fed4f0ba401a98e1683c1

Depends on D7988 and D7989.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 19 2020, 21:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 19 2020, 21:24
Fabien requested review of this revision.Oct 19 2020, 21:24
teamcity edited the summary of this revision. (Show Details)Oct 19 2020, 21:24
Fabien added a child revision: D7991: scripted-diff: Remove g_rpc_node references.Oct 19 2020, 21:28
Harbormaster completed remote builds in B13500: Diff 24797.Oct 19 2020, 21:36
jasonbcox requested changes to this revision.Oct 19 2020, 22:53
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/httprpc.h
29 ↗(On Diff #24797)

This looks like it'd be better treated as a private member and passed in during init.

This revision now requires changes to proceed.Oct 19 2020, 22:53
Fabien updated this revision to Diff 24814.Oct 20 2020, 07:18

Make context a member of HTTPRPCRequestProcessor

Harbormaster completed remote builds in B13512: Diff 24814.Oct 20 2020, 07:35
deadalnix accepted this revision.Oct 20 2020, 14:18
jasonbcox accepted this revision.Oct 20 2020, 15:44
This revision is now accepted and ready to land.Oct 20 2020, 15:44
Closed by commit rABC5c70631e078b: refactor: Pass NodeContext to RPC and REST methods through util::Ref (authored by Russell Yanofsky <russ@yanofsky.org>, committed by Fabien). · Explain WhyOct 20 2020, 17:44
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC5c70631e078b: refactor: Pass NodeContext to RPC and REST methods through util::Ref.
Fabien mentioned this in D8652: Fix bitcoin-qt RPC when -server is used.Dec 10 2020, 23:24
Fabien mentioned this in rABCd0207bfcd35f: Fix bitcoin-qt RPC when -server is used.Dec 11 2020, 00:12
PiRK mentioned this in D12700: refactor: Add and use EnsureConnman in rpc code.Nov 30 2022, 14:58
PiRK mentioned this in rABCb5814dc5fcda: refactor: Add and use EnsureConnman in rpc code.Nov 30 2022, 16:25

Revision Contents
Changeset List

PathSize
src/
7 lines
13 lines
3 lines
3 lines
2 lines
interfaces/
4 lines
qt/
4 lines
test/
4 lines
60 lines
rpc/
6 lines
30 lines
17 lines
13 lines
39 lines
12 lines
9 lines
test/
13 lines
9 lines
15 lines
util/
2 lines
wallet/
test/
10 lines

Diff 24854

View Options

src/bitcoind.cpp

Loading...
View Options

src/httprpc.h

Loading...
View Options

src/httprpc.cpp

Loading...
View Options

src/init.h

Loading...
View Options

src/init.cpp

Loading...
View Options

src/interfaces/node.cpp

Loading...
View Options

src/qt/bitcoin.cpp

Loading...
View Options

src/qt/test/apptests.cpp

Loading...
View Options

src/rest.cpp

Loading...
View Options

src/rpc/blockchain.h

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/rpc/mining.cpp

Loading...
View Options

src/rpc/misc.cpp

Loading...
View Options

src/rpc/net.cpp

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/rpc/request.h

Loading...
View Options

src/test/excessiveblock_tests.cpp

Loading...
View Options

src/test/rpc_server_tests.cpp

Loading...
View Options

src/test/rpc_tests.cpp

Loading...
View Options

src/test/util/setup_common.cpp

Loading...
View Options

src/wallet/test/wallet_tests.cpp

Loading...