Page MenuHomePhabricator

refactor: Pass NodeContext to RPC and REST methods through util::Ref
ClosedPublic

Authored by Fabien on Oct 19 2020, 21:24.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien requested review of this revision.Oct 19 2020, 21:24
jasonbcox requested changes to this revision.Oct 19 2020, 22:53
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/httprpc.h
29 ↗(On Diff #24797)

This looks like it'd be better treated as a private member and passed in during init.

This revision now requires changes to proceed.Oct 19 2020, 22:53

Make context a member of HTTPRPCRequestProcessor

This revision is now accepted and ready to land.Oct 20 2020, 15:44