Differential D7984

test: Add generatetodescriptor RPC
ClosedPublic
Actions

Authored by Fabien on Oct 19 2020, 14:22.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC08a28259cd0e: test: Add generatetodescriptor RPC

Summary

The existing generatetoaddress RPC can only generate to scriptPubKeys
that can be represented by an address. However, raw scripts (such as
OP_TRUE) or P2PK can not be represented by an address, which complicates
testing.

Backport of core PR16943.

Depends on D7983.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 19 2020, 14:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 19 2020, 14:22

Fabien requested review of this revision.Oct 19 2020, 14:22

teamcity edited the summary of this revision. (Show Details)Oct 19 2020, 14:23

Harbormaster completed remote builds in B13492: Diff 24786.Oct 19 2020, 14:34

deadalnix accepted this revision.Oct 19 2020, 16:13

This revision is now accepted and ready to land.Oct 19 2020, 16:13

Fabien added a child revision: D7988: rpc: Remove mempool global from miner.Oct 19 2020, 18:32

Closed by commit rABC08a28259cd0e: test: Add generatetodescriptor RPC (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyOct 19 2020, 20:43

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC08a28259cd0e: test: Add generatetodescriptor RPC.

Fabien removed a child revision: D7988: rpc: Remove mempool global from miner.Oct 19 2020, 20:45

Fabien added a child revision: D7988: rpc: Remove mempool global from miner.Oct 20 2020, 06:19

Revision Contents
Changeset List

Path

Size

src/

rpc/

client.cpp

2 lines

mining.cpp

52 lines

test/

functional/

rpc_invalidateblock.py

10 lines

test_framework/

address.py

1 line

Diff 24794

View Options

src/rpc/client.cpp

View Options

src/rpc/mining.cpp

View Options

test/functional/rpc_invalidateblock.py

View Options

test/functional/test_framework/address.py

test: Add generatetodescriptor RPCClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 24794

src/rpc/client.cpp

src/rpc/mining.cpp

test/functional/rpc_invalidateblock.py

test/functional/test_framework/address.py

test: Add generatetodescriptor RPC
ClosedPublic
Actions

Revision Contents
Changeset List