Page MenuHomePhabricator

scripted-diff: Remove g_rpc_node references
ClosedPublic

Authored by Fabien on Oct 19 2020, 21:28.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCb37ed6f1ed1f: scripted-diff: Remove g_rpc_node references
Summary
This commit does not change behavior

-BEGIN VERIFY SCRIPT-
git grep -l g_rpc_node | xargs sed -i 's/g_rpc_node->/node./g'
-END VERIFY SCRIPT-

Partial backport of core PR18740:
https://github.com/bitcoin/bitcoin/pull/18740/commits/ccb5059ee89f6e8dc31ba5b82830b384890bb65e

Depends on D7990.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Oct 19 2020, 21:28

Snippet of first build failure:

[359/411] Running utility command for check-bitcoin-sigencoding_tests
[360/411] Running utility command for check-bitcoin-uint256_tests
[361/411] bitcoin: testing walletdb_tests
[362/411] bitcoin: testing op_reversebytes_tests
[363/411] Running utility command for check-bitcoin-walletdb_tests
[364/411] Running utility command for check-bitcoin-op_reversebytes_tests
[365/411] bitcoin: testing undo_tests
[366/411] Running utility command for check-bitcoin-undo_tests
[367/411] bitcoin: testing txvalidationcache_tests
[368/411] bitcoin: testing serialize_tests
[369/411] bitcoin: testing compilerbug_tests
[370/411] Running utility command for check-bitcoin-txvalidationcache_tests
[371/411] Running utility command for check-bitcoin-serialize_tests
[372/411] Running utility command for check-bitcoin-compilerbug_tests
[373/411] bitcoin: testing checkpoints_tests
[374/411] bitcoin: testing validationinterface_tests
[375/411] Running utility command for check-bitcoin-checkpoints_tests
[376/411] Running utility command for check-bitcoin-validationinterface_tests
[377/411] bitcoin: testing radix_tests
[378/411] bitcoin: testing script_standard_tests
[379/411] Running utility command for check-bitcoin-radix_tests
[380/411] Running utility command for check-bitcoin-script_standard_tests
[381/411] bitcoin: testing blockstatus_tests
[382/411] bitcoin: testing blockcheck_tests
[383/411] bitcoin: testing coinselector_tests
FAILED: src/test/CMakeFiles/check-bitcoin-coinselector_tests 
cd /work/abc-ci-builds/build-clang-tidy/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang-tidy/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang-tidy/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-clang-tidy/test/log/bitcoin-coinselector_tests.log /work/abc-ci-builds/build-clang-tidy/src/test/test_bitcoin --run_test=coinselector_tests --logger=HRF,test_suite:JUNIT,message,bitcoin-coinselector_tests.xml
Running 4 test cases...
Entering test module "Bitcoin ABC unit tests"
../../src/wallet/test/coinselector_tests.cpp(22): Entering test suite "coinselector_tests"
../../src/wallet/test/coinselector_tests.cpp(142): Entering test case "bnb_search_test"
/work/abc-ci-builds/build-clang-tidy/src/test/test_bitcoin: relocation error: /lib/x86_64-linux-gnu/libgcc_s.so.1: symbol dl_iterate_phdr version GLIBC_2.2.5 not defined in file libc.so.6 with link time reference
[384/411] bitcoin: testing crypto_tests
[385/411] Running utility command for check-bitcoin-blockstatus_tests
[386/411] Running utility command for check-bitcoin-blockcheck_tests
[387/411] Running utility command for check-bitcoin-crypto_tests
[388/411] bitcoin: testing ref_tests
[389/411] Running utility command for check-bitcoin-ref_tests
[390/411] bitcoin: testing bswap_tests
[391/411] Running utility command for check-bitcoin-bswap_tests
[392/411] bitcoin: testing validation_tests
[393/411] bitcoin: testing script_tests
[394/411] Running utility command for check-bitcoin-validation_tests
[395/411] Running utility command for check-bitcoin-script_tests
[396/411] bitcoin: testing validation_block_tests
[397/411] Running utility command for check-bitcoin-validation_block_tests
[398/411] bitcoin: testing monolith_opcodes_tests
[399/411] Running utility command for check-bitcoin-monolith_opcodes_tests
[400/411] bitcoin: testing cuckoocache_tests
[401/411] bitcoin: testing skiplist_tests
[402/411] Running utility command for check-bitcoin-cuckoocache_tests
[403/411] Running utility command for check-bitcoin-skiplist_tests
[404/411] bitcoin: testing util_tests
[405/411] Running utility command for check-bitcoin-util_tests
[406/411] bitcoin: testing transaction_tests
[407/411] Running utility command for check-bitcoin-transaction_tests
[408/411] bitcoin: testing coins_tests
[409/411] Running utility command for check-bitcoin-coins_tests
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1
This revision is now accepted and ready to land.Oct 19 2020, 23:51
This revision was landed with ongoing or failed builds.Oct 20 2020, 17:46
This revision was automatically updated to reflect the committed changes.