refactor: Pass NodeContext to RPC and REST methods through util::Ref
5c70631e078b
Actions

Description

refactor: Pass NodeContext to RPC and REST methods through util::Ref

Summary:

This commit does not change behavior

Partial backport of core PR18740:
https://github.com/bitcoin/bitcoin/pull/18740/commits/6fca33b2edc09ed62dab2323c780b31585de1750#diff-2ae094f9329ce9498e1b4a9cb7767945b54a33b4ee9fed4f0ba401a98e1683c1

Depends on D7988 and D7989.

Test Plan:

ninja all check-all

Reviewers: #bitcoin_abc, jasonbcox, deadalnix

Reviewed By: #bitcoin_abc, jasonbcox, deadalnix

Subscribers: jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D7990

Details

Provenance

Russell Yanofsky <russ@yanofsky.org>	Authored on Apr 17 2020, 15:28
Fabien	Committed on Oct 20 2020, 17:43
Fabien	Pushed on Oct 20 2020, 17:44

Reviewer

Restricted Project

Differential Revision

D7990: refactor: Pass NodeContext to RPC and REST methods through util::Ref

Parents

rABC7caa48fc89ba: Merge #16957: 9% less memory: make SaltedOutpointHasher noexcept

Branches

Unknown

Tags

Unknown

Event Timeline

Fabien committed rABC5c70631e078b: refactor: Pass NodeContext to RPC and REST methods through util::Ref (authored by Russell Yanofsky <russ@yanofsky.org>).Oct 20 2020, 17:43

Fabien added an edge: D7990: refactor: Pass NodeContext to RPC and REST methods through util::Ref.

teamcity mentioned this in T1118: Build Bitcoin-ABC / Master / Make Generator is broken..Oct 20 2020, 18:09

Changes (21)

Path

Size

src/

interfaces/

qt/

test/

rpc/

test/

excessiveblock_tests.cpp

rpc_server_tests.cpp

rpc_tests.cpp

util/

setup_common.cpp

wallet/

test/

wallet_tests.cpp

rABC5c70631e078b

View Options

src/bitcoind.cpp

View Options

src/httprpc.cpp

View Options

src/httprpc.h

View Options

src/init.cpp

View Options

src/init.h

View Options

src/interfaces/node.cpp

View Options

src/qt/bitcoin.cpp

View Options

src/qt/test/apptests.cpp

View Options

src/rest.cpp

View Options

src/rpc/blockchain.cpp

View Options

src/rpc/blockchain.h

View Options

src/rpc/mining.cpp

View Options

src/rpc/misc.cpp

View Options

src/rpc/net.cpp

View Options

src/rpc/rawtransaction.cpp

View Options

src/rpc/request.h

View Options

src/test/excessiveblock_tests.cpp

View Options

src/test/rpc_server_tests.cpp

View Options

src/test/rpc_tests.cpp

View Options

src/test/util/setup_common.cpp

View Options

src/wallet/test/wallet_tests.cpp

refactor: Pass NodeContext to RPC and REST methods through util::Ref5c70631e078bActions

Description

Details

Event Timeline

Changes (21)

rABC5c70631e078b

src/bitcoind.cpp

src/httprpc.cpp

src/httprpc.h

src/init.cpp

src/init.h

src/interfaces/node.cpp

src/qt/bitcoin.cpp

src/qt/test/apptests.cpp

src/rest.cpp

src/rpc/blockchain.cpp

src/rpc/blockchain.h

src/rpc/mining.cpp

src/rpc/misc.cpp

src/rpc/net.cpp

src/rpc/rawtransaction.cpp

src/rpc/request.h

src/test/excessiveblock_tests.cpp

src/test/rpc_server_tests.cpp

src/test/rpc_tests.cpp

src/test/util/setup_common.cpp

src/wallet/test/wallet_tests.cpp

refactor: Pass NodeContext to RPC and REST methods through util::Ref
5c70631e078b
Actions