Differential D7989

Add util::Ref class as temporary alternative for c++17 std::any
ClosedPublic
Actions

Authored by Fabien on Oct 19 2020, 21:11.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rABC07f35b986149: Add util::Ref class as temporary alternative for c++17 std::any

Summary

This commit does not change behavior

Partial backport of core PR18740:
https://github.com/bitcoin/bitcoin/pull/18740/commits/691c817b340d10e806dc3b1834d2a8fcc5e681fd

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 19 2020, 21:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 19 2020, 21:11

Fabien requested review of this revision.Oct 19 2020, 21:11

teamcity edited the summary of this revision. (Show Details)Oct 19 2020, 21:11

Harbormaster completed remote builds in B13499: Diff 24796.Oct 19 2020, 21:22

Fabien added a child revision: D7990: refactor: Pass NodeContext to RPC and REST methods through util::Ref.Oct 19 2020, 21:24

jasonbcox accepted this revision.Oct 19 2020, 22:48

This revision is now accepted and ready to land.Oct 19 2020, 22:48

Closed by commit rABC07f35b986149: Add util::Ref class as temporary alternative for c++17 std::any (authored by Russell Yanofsky <russ@yanofsky.org>, committed by Fabien). · Explain WhyOct 20 2020, 06:34

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC07f35b986149: Add util::Ref class as temporary alternative for c++17 std::any.

Revision Contents
Changeset List

Path

Size

arcanist/

linter/

CppVoidParameterLinter.php

18 lines

src/

test/

CMakeLists.txt

1 line

ref_tests.cpp

32 lines

util/

check.h

4 lines

ref.h

48 lines

Diff 24813

View Options

arcanist/linter/CppVoidParameterLinter.php

View Options

src/test/CMakeLists.txt

View Options

src/test/ref_tests.cpp

View Options

src/util/check.h

View Options

Add util::Ref class as temporary alternative for c++17 std::anyClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 24813

arcanist/linter/CppVoidParameterLinter.php

src/test/CMakeLists.txt

src/test/ref_tests.cpp

src/util/check.h

src/util/ref.h

Add util::Ref class as temporary alternative for c++17 std::any
ClosedPublic
Actions

Revision Contents
Changeset List