HomePhabricator

Use correct length sig in sigcheck test

Description

Use correct length sig in sigcheck test

Summary:
Even though the test currently passes (due to dummysigchecker), it's not using the sig + sighashtype
as expected. When debugging, it becomes clear that the sighashtype is being stripped off as part of OP_CHECKSIG
despite it not being present. While this doesn't produce any unexpected behavior today, it's confusing and not
technically correct so best to fix before it becomes an issue.

Shoutout to Tobias for finding this.

Test Plan: ninja check

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D9293

Details

Provenance
jasonbcoxAuthored on Feb 27 2021, 17:58
jasonbcoxPushed on Mar 3 2021, 23:19
Reviewer
Restricted Project
Differential Revision
D9293: Use correct length sig in sigcheck test
Parents
rABC80aa02a917cf: [Cashtab] Pull spinner color out of css
Branches
Unknown
Tags
Unknown